Re: Review Request of 8152492: [macosx swing] double key event actions when using Mac menubar

Hi All, I have added some comments and made some minor tweaks as per the inputs received. Please review my code changes as available at this link below: http://cr.openjdk.java.net/~aniyogi/8152492/webrev.02/ With Regards, Avik Niyogi > O

Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

On 4/20/2016 12:11 AM, Phil Race wrote: PS I see the class doc talks about shouldYieldFocus() being called, so I don't understand the inter-relationship of that and verify(), but it makes me no more sure that deprecating that method is right. I deprecated shouldYieldFocus(JCopmponent) and added

Re: RfR JDK-8076554, [macosx] Custom Swing text components need to allow standard accessibility

p.s. JPRT ran OK. Still need one more +1. On 4/19/16 2:16 PM, Phil Race wrote: > +1 > > -phil. > > On 04/19/2016 12:05 PM, Pete Brunet wrote: >> New patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8076554/webrev.03/ >> >> Changes: >> - removed _AccessibleState >> - removed wildcard imports. >> >

Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

PS I see the class doc talks about shouldYieldFocus() being called, so I don't understand the inter-relationship of that and verify(), but it makes me no more sure that deprecating that method is right. I think perhaps verify() is all that the app is supposed to have over-ridden and the comments

Re: RfR JDK-8076554, [macosx] Custom Swing text components need to allow standard accessibility

+1 -phil. On 04/19/2016 12:05 PM, Pete Brunet wrote: New patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8076554/webrev.03/ Changes: - removed _AccessibleState - removed wildcard imports. Is this ready to push? Pete On 4/19/16 12:26 PM, Phil Race wrote: oh one nit picky thing - can we get

Re: RfR JDK-8076554, [macosx] Custom Swing text components need to allow standard accessibility

New patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8076554/webrev.03/ Changes: - removed _AccessibleState - removed wildcard imports. Is this ready to push? Pete On 4/19/16 12:26 PM, Phil Race wrote: > oh one nit picky thing - can we get rid of the wild card imports ? > > -phil. > > On 04/19/2

Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

On 4/19/2016 7:47 PM, Phil Race wrote: Hi, You are deprecating shouldYieldFocus(JComponent) and yet this class directly uses it. Is this deprecation really the right thing to do ? Why is this not correct? There are plenty examples in JDK: Component#setVisible() & Component#show(), Component#t

Re: RfR JDK-8076554, [macosx] Custom Swing text components need to allow standard accessibility

oh one nit picky thing - can we get rid of the wild card imports ? -phil. On 04/19/2016 10:21 AM, Phil Race wrote: Which seems to imply the _AccessibleState subclass has been obsolete since 1.5 Although when these tools were unbundled it perhaps could not assume 1.5. The rest of the changes l

Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

Hi, You are deprecating shouldYieldFocus(JComponent) and yet this class directly uses it. Is this deprecation really the right thing to do ? The new over-loaded shouldYieldFocus() is perhaps not much more than a utility. And the doc says "calls verify(input)" which seems odd since you do not

Re: RfR JDK-8076554, [macosx] Custom Swing text components need to allow standard accessibility

Which seems to imply the _AccessibleState subclass has been obsolete since 1.5 Although when these tools were unbundled it perhaps could not assume 1.5. The rest of the changes look fine and it is a lot simpler than the v0 .. -phil. On 04/19/2016 08:54 AM, Pete Brunet wrote: Thanks for noticin

Re: RfR JDK-8076554, [macosx] Custom Swing text components need to allow standard accessibility

Thanks for noticing that Alexandr. I see this state was added in 1.5 and apparently the code from which I borrowed this from was never updated. I will remove that and open a bug to remove that from the original. -Pete On 4/19/16 7:39 AM, Alexander Scherbatiy wrote: > On 19/04/16 05:50, Pete Bru

Re: [9] Review request for 8152677 [macosx] All files filter can't be selected in JFileChooser

Looks fine. On 19.04.16 15:21, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8152677/webrev.01 - file chooser file filter is used as an initial value for the old file filter in the AquaFileChooserUI.FilterComboBoxModel

Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

On 19/04/16 15:40, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8154431 webrev: http://cr.openjdk.java.net/~ssadetsky/8154431/webrev.00/ - there is a small typo in the test copyright year: 20016 - could you add a check to the verif

Re: RfR JDK-8076554, [macosx] Custom Swing text components need to allow standard accessibility

On 19/04/16 05:50, Pete Brunet wrote: Please review the following patch. Bug: https://bugs.openjdk.java.net/browse/JDK-8076554 Patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8076554/webrev.02/ The problem is that the code is currently hardcoded to only support text accessibility for JTextCompo

Re: Review Request of 8152492: [macosx swing] double key event actions when using Mac menubar

On 19.04.16 11:46, Avik Niyogi wrote: Hi All, Please review my code changes with inputs received: Can you please add some description of your changes, it seems you removed all code which was added by you previously. http://cr.openjdk.java.net/~aniyogi/8152492/webrev.01/ With Regards, Avik

Re: [9] Review request for 8152677 [macosx] All files filter can't be selected in JFileChooser

Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8152677/webrev.01 - file chooser file filter is used as an initial value for the old file filter in the AquaFileChooserUI.FilterComboBoxModel - AcceptAllFileFilter class and filed are made static The c

[9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8154431 webrev: http://cr.openjdk.java.net/~ssadetsky/8154431/webrev.00/ The thing is the Swing validation doesn't allow to validate state of the target component of input focus transfer operation. To support that

[PATCH] JDK-7169915 : Swing Table Layout bad repaint of the row [REGRESSION] JDK-8133864 : Wrong display, when the document I18n properties is true.

Hello, I built the recent OpenJDK8u and OpenJDK9 sources (openjdk_versions.txt) with the patch shown in the output_diff.txt attachment. I applied your patch for JDK-8133864 : Wrong display, when the document I18n properties is true. And I applied my patch for JDK-7169915 : Swing Table Layout

Re: Review Request of 8152492: [macosx swing] double key event actions when using Mac menubar

Hi All, Please review my code changes with inputs received: http://cr.openjdk.java.net/~aniyogi/8152492/webrev.01/ With Regards, Avik Niyogi > On 19-Apr-2016, at 11:47 am, Avik Niyogi wrote: > > Hi Sergey, > I have tried all these Input s

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

On 4/11/2016 4:29 PM, Philip Race wrote: On 4/6/16, 1:23 PM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8132119/webrev.09 - TextUIDrawing interface and its default implementaion BasicTextUIDrawing class are added - font met