?
I am not able to find a way to write an automated test case for this. I can
write a Manual test but don't know how much that will help as SwingSet2 can
also be used to verify this. Please let me know your thoughts on this.
-Pankaj
-Original Message-
From: Sergey Bylokhov
Sent: Sa
On 09/03/2019 22:59, Philip Race wrote:
What was H3 is in italics and what follows in regular style is intended
to be a sub-section.
It is unclear why "Attribute Categories and Values" and "Attribute Roles" is a
sub-section of "What is an Attribute?", while all other stuff is not.
--
Best
at posted that would be easier to tell.
I am using make docs to verify and the docs output can be found at
http://cr.openjdk.java.net/~psadhukhan/8220250/docs/api/java.desktop/module-summary.html
Regards
Prasanta
-phil.
On 3/8/19, 3:37 AM, Sergey Bylokhov wrote:
Looks fine.
On 07/03/2019 03:37
Looks fine.
On 07/03/2019 03:37, Prasanta Sadhukhan wrote:
Hi All,
Bug: https://bugs.openjdk.java.net/browse/JDK-8220250
webrev: http://cr.openjdk.java.net/~psadhukhan/8220250/webrev.0/
Please review a doc fix to fix heading style to improve the accessibility JDK
API documentation of
Looks fine.
On 05/03/2019 21:03, Prasanta Sadhukhan wrote:
Hi Sergey,
Modified test in webrev to iterate through installed L
http://cr.openjdk.java.net/~psadhukhan/8215396/webrev.1/
Regards
Prasanta
On 06-Mar-19 6:35 AM, Sergey Bylokhov wrote:
Hi, Prasanta.
The change looks fine, but I have
Hi, Prasanta.
The change looks fine, but I have two comments.
- Please close the JDK-7151452 as a duplicate of JDK-8215396, since you sent
JDK-8215396 to the review.
- Looks like the test depends on the L, on my system it is passed on macOS on
jdk11, probably it should checks all installe L?
Hi, Shashi.
On 04/03/2019 01:40, Shashidhara Veerabhadraiah wrote:
Hi Sergey\Phil, Here is a new Webrev containing the new test case along with
the fix. With this change, the test fails before the fix and passes after the
fix.
http://cr.openjdk.java.net/~sveerabhadra/8213516/webrev.04/
Hello.
Please review the fix for JDK 13.
Bug: https://bugs.openjdk.java.net/browse/JDK-8177960
CSR: https://bugs.openjdk.java.net/browse/JDK-8218637
Fix: http://cr.openjdk.java.net/~serb/8177960/webrev.01
This is a request to deprecate the Swing Motif Look and Feel,
and document it as
On 04/03/2019 01:47, Pankaj Bansal wrote:
Sergey, this is the new bug I have created for reading the values from the CSS.
https://bugs.openjdk.java.net/browse/JDK-8220053
Thank you, the fix looks fine.
-Pankaj
*From:*Prasanta Sadhukhan
*Sent:* Monday, March 4, 2019 2:06 PM
*To:* Pankaj
Looks fine.
On 28/02/2019 23:55, Pankaj Bansal wrote:
Hi All,
Please review the following fix.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8214253
webrev
http://cr.openjdk.java.net/~pbansal/8214253/webrev00/
Issue:
From gtk 3.20, gtk has changed the way themes and styles work for
Looks fine.
On 21/02/2019 08:44, Sergey Bylokhov wrote:
On 20/02/2019 22:21, Krishna Addepalli wrote:
Hi Sergey,
I have fixed the issue. Could you check now?
Yes, it works now, I look to the fix.
Thanks,
Krishna
-Original Message-
From: Sergey Bylokhov
Sent: Thursday, February 21
Hi, Pankaj.
Can you please create a separate CR to read these colors from the CSS.
On 26/02/2019 02:33, Pankaj Bansal wrote:
Hi All,
Please review the following fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8214112
webrev: http://cr.openjdk.java.net/~pbansal/8214112/webrev00/
Issue:
Looks fine.
On 25/02/2019 23:32, gauri.pa...@oracle.com wrote:
Hi All,
Gentle Reminder.
Thanks and Regards
Gauri Patil
On 20/02/19 11:03 AM, gauri.pa...@oracle.com wrote:
Hi Shura,
A bug is created for this issue, the bug id for the same is,
Looks fine.
On 21/02/2019 09:52, Prasanta Sadhukhan wrote:
Thanks Sergey for the pointer. I have modified the test not to use google.com.
http://cr.openjdk.java.net/~psadhukhan/8213781/webrev.2/
Regards
Prasanta
On 21-Feb-19 10:53 PM, Sergey Bylokhov wrote:
It can be done using CSS style
On 21/02/2019 09:23, Prasanta Sadhukhan wrote:
There are tests which connects to www.google.com.
java/net/Inet6Address/PreferIPv6AddressesTest.java,
java/net/CookieHandler/TestHttpCookie.java which is an open test so I guess it
should not be a problem.
PreferIPv6AddressesTest test is
It can be done using CSS style for the body tag, like this:
body {
background: #0FF;
}
Title
On 21/02/2019 09:14, Prasanta Sadhukhan wrote:
On 21-Feb-19 10:39 PM, Sergey Bylokhov wrote:
Why is is impossible to create such page by the test?
I am not sure how to create
Why is is impossible to create such page by the test?
On 21/02/2019 09:03, Prasanta Sadhukhan wrote:
You should not set a proxy and access the google.com. The test should run w/o
dependency on the external resource.
But the bug manifest itself only for some webpage and I only know of
On 21/02/2019 08:46, Prasanta Sadhukhan wrote:
But it can always be changed if somebody wants to run as a standalone test.
There are many test in java/net, sun/security where they explicitly do
setProperty(proxy) [for ex, java/net/ProxySelector/B6737819.java,
On 20/02/2019 22:21, Krishna Addepalli wrote:
Hi Sergey,
I have fixed the issue. Could you check now?
Yes, it works now, I look to the fix.
Thanks,
Krishna
-Original Message-
From: Sergey Bylokhov
Sent: Thursday, February 21, 2019 3:54 AM
To: Krishna Addepalli ; swing-dev
On 21/02/2019 08:31, Prasanta Sadhukhan wrote:
The test has some assumptions which is no necessary true:
- it might be executed outside of our internal network
I know that but it was not working inside internal network, without proxy,
which is where we will be running the jtreg tests mostly,
Hi, Prasanta.
The test has some assumptions which is no necessary true:
- it might be executed outside of our internal network
- the background color of 100x100 on https://www.google.com is not necessary
white(this is not guarantied)
On 21/02/2019 00:34, Prasanta Sadhukhan wrote:
Hi All,
Regards
Prasanta
On 14-Feb-19 4:12 AM, Sergey Bylokhov wrote:
Hi, Prasanta.
I modified the fix to use deviceFRC if not compatible and in sync with the comment which
says "obtain a TextLayout with advances for the printer graphics FRC"
I used SwingUtilies2.getStringWidth() which cal
Hi, Krishna.
Some links have wrong file permissions, "403 - Forbidden":
http://cr.openjdk.java.net/~kaddepalli/8218674/webrev00/raw_files/new/test/jdk/javax/swing/text/html/8218674/circle.png
Looks fine.
On 19/02/2019 22:11, shashidhara.veerabhadra...@oracle.com wrote:
Hi Sergey, Thank you for the review and here is the new webrev fixing your
comments:
http://cr.openjdk.java.net/~sveerabhadra/8213071/webrev.02/
Thanks and regards,
Shashi
On 20/02/19 6:40 AM, Sergey Bylokhov
Looks fine.
On 19/02/2019 21:17, Prasanta Sadhukhan wrote:
Hi Sergey,
I guess that code was commented out anyway I have removed that line in the
modified webrev
http://cr.openjdk.java.net/~psadhukhan/8219156/webrev.1/
Regards
Prasant
On 20-Feb-19 2:37 AM, Sergey Bylokhov wrote:
Hi, Prasanta
Hi, Andrey.
I found only one questionable place in the fix:
==
/**
* Returns an object created with id=key. If the object is not of
- * type type, this will throw an exception.
+ * that type, this will throw an exception.
*/
private Object
Bylokhov wrote:
On 21/11/2018 16:00, Sergey Bylokhov wrote:
Can you please double check it on a different systems,
I tried to reproduce it a few time on the current client and it seems to work.
And the question about the current fix, are you sure that the static boolean
flag will
work properly
Hi, Prasanta.
Looks like in the test you have a code to check a foreground color(attrBackground,
"green_foreground ") but it is unused.
On 19/02/2019 03:23, Prasanta Sadhukhan wrote:
Hi All,
Please review a fix for an issue where it is seen that JTextPane with
RTFEditorKit writes
for
this fix. The reproducer provided in the bug is good enough(ofcourse, with some
addition of pass fail criteria as for manual tests).
Thanks,
Krishna
On 31-Jan-2019, at 4:09 AM, Phil Race wrote:
+1
-phil.
On 1/24/19 9:16 AM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk 13.
Bug
on an expected thread.
-phil.
On 11/26/18 6:29 PM, Sergey Bylokhov wrote:
The "ProblemList.txt" is updated in the new version:
http://cr.openjdk.java.net/~serb/8213110/webrev.04
On 08/11/2018 10:57, Sergey Bylokhov wrote:
Note that for some of the tests I'll need to update the pr
Hi, Phil.
Thank you for review, see my comments inline:
You discuss the life cycle of an applet in jtreg
---
- Call init() and start() methods of the Applet
- Waits for 2 seconds
- Call stop() and destroy() methods of the Applet
- Dispose the frame
--
I see init() and
Hi, Shashi.
HashTable class uses these methods for key types used in the hash table, hence
they need to be implemented as part of the key types. The JCK test already
tests this, so Sergey do you want me to write another open test for this
problem?
The rules above are applicable to the keys
Hi, Prasanta.
I modified the fix to use deviceFRC if not compatible and in sync with the comment which
says "obtain a TextLayout with advances for the printer graphics FRC"
I used SwingUtilies2.getStringWidth() which calculates the advances of the
string if text layouting is used.
Looks fine.
On 12/02/2019 14:40, Semyon Sadetsky wrote:
Hello,
Please review a fix for JDK 12.
JBS: https://bugs.openjdk.java.net/browse/JDK-8218473
webrev: http://cr.openjdk.java.net/~ssadetsky/8218473/webrev.00/
This is a JCK test failure fix. The test fails under the GTKLookAndFeel on
Looks fine.
On 12/02/2019 14:46, Semyon Sadetsky wrote:
Hello,
Please review a fix for JDK 12.
JBS: https://bugs.openjdk.java.net/browse/JDK-8218479
webrev: http://cr.openjdk.java.net/~ssadetsky/8218479/webrev.00/
This is a JCK test failure fix. The test fails under the GTKLookAndFeel on
Looks fine.
On 06/02/2019 21:49, Muneer Kolarkunnu wrote:
Hi All,
Please review fix for the task:
Task: https://bugs.openjdk.java.net/browse/JDK-8218599
Webrev: http://cr.openjdk.java.net/~akolarkunnu/8218599/webrev.00/
Just adding the test group jdk_client_sanity under jdk_desktop group.
ified text.
-phil.
On 1/24/19 9:33 AM, Sergey Bylokhov wrote:
Hi, Prasanta.
On 24/01/2019 02:18, Prasanta Sadhukhan wrote:
Proposed fix is to check if we need text layouting for printing too as it is
done for swing text drawing on console. If we need text layouting, then only
use textlayout jus
Hi, Prasanta.
On 24/01/2019 02:18, Prasanta Sadhukhan wrote:
Proposed fix is to check if we need text layouting for printing too as it is
done for swing text drawing on console. If we need text layouting, then only
use textlayout justification.
For swing components we skip textlayout by
Hello.
Please review the fix for jdk 13.
Bug: https://bugs.openjdk.java.net/browse/JDK-8061381
Fix: http://cr.openjdk.java.net/~serb/8061381/webrev.00
This fix adds the support of swing menu accelerators for Voice Over on macOS
(note that swing menu is used when the "apple.laf.useScreenMenuBar"
: Sergey Bylokhov
Sent: Wednesday, January 23, 2019 4:20 AM
To: Vikrant Agarwal ; swing-dev@openjdk.java.net
Cc: Aleksandre Iline
Subject: Re: [13] RFR [JDK-8217235] Create automated test for
SwingSet ColorChooserDemoTest
Hi, Vikrant.
Currently this test is only for Metal look and feel. I will ad
Hi, Vikrant.
Currently this test is only for Metal look and feel. I will ad> > support for
other look and feels subsequently.
On macOS it will test the Aqua L, is it expected?
--
Best regards, Sergey.
Looks fine.
On 20/01/2019 23:23, Vikrant Agarwal wrote:
Hi Sergey,
I have updated the test.
Updated Webrev: http://cr.openjdk.java.net/~vagarwal/8217377/webrev.1/
Best Regards,
Vikrant
-Original Message-
From: Sergey Bylokhov
Sent: Saturday, January 19, 2019 3:52 AM
To: Vikrant
way to tell not to load any assistive technologies and additional
parsing would only lead to other ways/expectations.
Thanks and regards,
Shashi
-Original Message-
From: Sergey Bylokhov
Sent: Thursday, January 17, 2019 1:33 AM
To: Shashidhara Veerabhadraiah ;
awt-...@openjdk.java.net; swing-d
Looks fine.
On 17/01/2019 10:29, Pankaj Bansal wrote:
Hi All,
Please review the following fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8214765
webrev: http://cr.openjdk.java.net/~pbansal/8214765/webrev.00/
Issue:
The icons are not being displayed in System TrayIcon for warning,
Looks fine.
On 16/01/2019 23:04, Vikrant Agarwal wrote:
Hi All,
Please review this fix for SwingSet3 SliderDemoTest:
Bug: https://bugs.openjdk.java.net/browse/JDK-8217297
Webrev: http://cr.openjdk.java.net/~vagarwal/8217297/webrev.0/
Summary: This fix enables support for multiple look and
e we will deprecate the Stock icons from gtk 3.10. So I have not made
any changes for those here.
Please let me know if this looks good.
Regards,
Pankaj
-Original Message-
From: Sergey Bylokhov
Sent: Tuesday, January 15, 2019 4:37 AM
To: Pankaj Bansal; swing-dev@openjdk.java.net
Subject: Re:
a 'mistake' if done by the developers. Hence I feel it is
not required(as there is a way to tell nothing to load). Please let me know if
you think otherwise.
Thanks and regards,
Shashi
-Original Message-
From: Sergey Bylokhov
Sent: Tuesday, January 15, 2019 7:32 AM
To: Shashidhara V
he new Webrev:
http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.01/
Thanks and regards,
Shashi
-Original Message-
From: Sergey Bylokhov
Sent: Friday, January 4, 2019 3:48 AM
To: Shashidhara Veerabhadraiah ;
awt-...@openjdk.java.net; swing-dev@openjdk.java.net
Subject: R
with this implementation all the tests passes consistently.
Thanks and regards,
Shashi
-Original Message-
From: Sergey Bylokhov
Sent: Friday, December 21, 2018 12:42 PM
To: Shashidhara Veerabhadraiah ; Philip Race
Cc: swing-dev@openjdk.java.net; Dmitry Bessonov ; Krishna
Addepalli
Subject
Hi, Pankaj.
Based on the links below the next names were deprecated as well:
"gtk-ok", "gtk-cancel", "gtk-dnd" etc.
Should we change them as well?
On 14/01/2019 04:26, Pankaj Bansal wrote:
https://developer.gnome.org/gtk2/stable/gtk2-Stock-Items.html#GTK-STOCK-DIALOG-ERROR:CAPS
Looks fine.
On 14/01/2019 07:34, Muneer Kolarkunnu wrote:
Hi All,
Please review fix for the task:
Task: https://bugs.openjdk.java.net/browse/JDK-8214471
Webrev: http://cr.openjdk.java.net/~akolarkunnu/8214471/webrev/
Tested this on windows, linux and osx platforms in 1000 iterations, on
Hi, Shashi.
I think you can update an existing test:
open/test/jdk/javax/accessibility/AccessibilityProvider/basic.sh
On 03/01/2019 01:36, Shashidhara Veerabhadraiah wrote:
Hi All, Please review a fix for the below bug.
Bug: https://bugs.openjdk.java.net/browse/JDK-8216008
Webrev:
Looks fine.
On 02/01/2019 01:56, Prasanta Sadhukhan wrote:
Hi All,
Please review a doc fix to fix space missing after {@code} tag.
diff -r 9eee0b148002 src/java.desktop/share/classes/javax/swing/MenuElement.java
--- a/src/java.desktop/share/classes/javax/swing/MenuElement.java Thu Dec 20
to do that. The fix that I
proposed is small and should not cause any issues at this late moment.
Thanks and regards,
Shashi
-Original Message-
From: Philip Race
Sent: Friday, December 21, 2018 10:48 AM
To: Shashidhara Veerabhadraiah
Cc: Sergey Bylokhov ; swing-dev@openjdk.java.net; Dmitry
t wouldn't solve the problem today.
But excluding the test is a possible option for 12, so we could defer fixing
the underlying regression until 13.
-phil.
On 12/20/18 3:33 PM, Sergey Bylokhov wrote:
On 20/12/2018 15:25, Phil Race wrote:
On 12/20/18 2:51 PM, Sergey Bylokhov wrote:
I have checke
On 20/12/2018 15:25, Phil Race wrote:
On 12/20/18 2:51 PM, Sergey Bylokhov wrote:
I have checked the test which uses AccessibleResourceBundle and I have two
comments:
- This test should not be a part of jck since it is not a part of public specification.
What isn't ? Do you mean the class
is somehow pre-empting the resources that should be used ?
-phil.
On 12/20/18 8:22 AM, Sergey Bylokhov wrote:
Hi, Shashi.
Can you please provide more details, why this deprecated resource bundle is
loaded by the test?
It is strange because it should not be used, and was replaced
am unable to reproduce it on my local machine.
Thanks and regards,
Shashi
-Original Message-
From: Shashidhara Veerabhadraiah
Sent: Thursday, December 20, 2018 9:49 AM
To: Sergey Bylokhov ; swing-dev@openjdk.java.net; Philip Race
; Dmitry Bessonov
Subject: Re: [12] JDK-8213516: jck
Hi, Shashi.
Can you please describe the sequence of calls which might break the
the static table?
BTW did you tried the system where Dmitry was able to reproduce the bug?
On 18/12/2018 22:24, Shashidhara Veerabhadraiah wrote:
Hi All, Please review a fix for the JDK 12 for the below bug:
Bug:
re called. Everytime these
functions are called, a new instance of the class is created and returned.
Also, these classes look like to be short-lived. I saw that for example
AccessibleJListChild object is created inside a property change function in
JList.
Thanks,
Krishna
-Original Message-
From:
+1
On 06/12/2018 01:08, Krishna Addepalli wrote:
Looks good to me.
Thanks,
Krishna
On 06-Dec-2018, at 1:34 PM, Prasanta Sadhukhan mailto:prasanta.sadhuk...@oracle.com>> wrote:
Hi All,
It is found that this test is not able to find ExtendedRobot directory which has been
moved to lib/client
Hi, Krishna.
As far as I understand the bug is reproduced because the "Page"
class sets its accessibility parent in the constructor and never reset it to
"null".
The same code exists in the other classes as well:
AccessibleJTableHeaderEntry, AccessibleJTableHeaderCell, AccessibleJTableCell,
Hi, Shashi.
On 26/11/2018 01:15, Shashidhara Veerabhadraiah wrote:
Hi Alexey, The accessible information is already set for the component
in question and that is the reason it works with the accessibility
short cut(without this fix).
Did you check that VO announces when the ProgressBar is
Hi, Prasanta.
The "summary" attr in our tables was used for accessibility purpose:
https://bugs.java.com/bugdatabase/view_bug.do?bug_id=4637604
But since this attr is unsupported in html5 it was replaced
by the with appropriate text:
Looks fine.
On 29/11/2018 09:37, Krishna Addepalli wrote:
Hi Sergey,
I’m not sure for other components, so I have limited the fix to work only for
JTabbedPane.
Here is the new webrev: http://cr.openjdk.java.net/~kaddepalli/7124301/webrev01
Thanks,
Krishna
On 27-Nov-2018, at 1:42 AM, Sergey
+1
On 29/11/2018 00:01, Jayathirth Rao wrote:
Changes are fine.
Thanks,
Jay
On 29-Nov-2018, at 12:40 PM, Prasanta Sadhukhan mailto:prasanta.sadhuk...@oracle.com>> wrote:
Hi All,
It is found that this test is not able to find ExtendedRobot directory which has been
moved to lib/client as
Hi, Krishna.
The "ACCESSIBLE_NAME_PROPERTY" is also used in JTable/JFileChooser etc,
are you sure that we need to call the "titleChanged(ptr)" for all of them?
On 22/11/2018 21:04, shashidhara.veerabhadra...@oracle.com wrote:
Hi Krishna, The changes looks fine to me.
Thanks and regards,
On 21/11/2018 16:00, Sergey Bylokhov wrote:
Can you please double check it on a different systems,
I tried to reproduce it a few time on the current client and it seems to work.
And the question about the current fix, are you sure that the static boolean
flag will
work properly if the app
it is not a
regression I think.
Thanks and regards,
Shashi
On 13/11/18 6:12 AM, Sergey Bylokhov wrote:
Hi, Shashi.
Did you check this behavior was in jdk7/8 GA, or it is a regression?
On 11/11/2018 04:58, shashidhara.veerabhadra...@oracle.com wrote:
Hi All, Please review a fix for an accessibility vpat
On 20/11/2018 22:16, Shashidhara Veerabhadraiah wrote:
Thank you Alexey. I agree to it as well.
Sergey, I saw that the accessibility short cuts does not work on some of the
components of the dialogs and only the TAB key has to be used to traverse the
components. Hence I think the traversal
Hi, Prasanta
On 21/11/2018 02:27, Prasanta Sadhukhan wrote:
where caching of SynthButtonUI is done. It seems caching of button ui object
causes SynthButtoUI.getMinimumSize() to be called again
whereas without caching, the SynthButtonUI class is not invoked when
Container.layout() lay outs the
Hello.
Please review the fix for jdk 12.
Bug: https://bugs.openjdk.java.net/browse/JDK-8213817
Webrev: http://cr.openjdk.java.net/~serb/8213817/webrev.00
In the fix a few duplicate @return tags were removed.
Note that in a few places like:
Looks fine.
--
Best regards, Sergey.
4/webrev.1/
Regards
Prasanta
On 09-Nov-18 9:22 AM, Prasanta Sadhukhan wrote:
On 09-Nov-18 2:22 AM, Sergey Bylokhov wrote:
On 08/11/2018 01:11, Prasanta Sadhukhan wrote:
Hi Sergey,
I am not getting ClassCastException when I run
com/sun/java/swing/plaf/windows/Test8173145 on mach5, rather I get
xtracted
the internalframe from BasicInternalFrameTitlePane.
Regards
Prasanta
On 13-Nov-18 7:56 AM, Sergey Bylokhov wrote:
Hi, Prasanta.
Can you please provide more details on the hierarchy of components which
trigger this assertion.
This method is used in 3 places, in two places
th provided binary and issue is resolved with this fix. Thanks for
fixing this issue.
Regards,
Muneer
-Original Message-
From: Muneer Kolarkunnu
Sent: Wednesday, October 24, 2018 12:00 PM
To: Prasanta Sadhukhan ; Sergey Bylokhov
; swing-dev@openjdk.java.net
Subject: Re: [12] RFR JDK-8211703: JI
Hi, Prasanta.
On 12/11/2018 03:36, Prasanta Sadhukhan wrote:
It seems this scaling of backing store image is not needed for printing as the
original backing store image or base image was printed correctly before this
fix.
Did you check why we should not scale the "backing store image" in
Hello.
Please review the fix for jdk 12.
Bug: https://bugs.openjdk.java.net/browse/JDK-8198339
Webrev: http://cr.openjdk.java.net/~serb/8198339/webrev.00
The reason of instability was an intermittent HeadlessException in the headless
mode.
But in most cases the test passed, because the test
Hi, Shashi.
Did you check this behavior was in jdk7/8 GA, or it is a regression?
On 11/11/2018 04:58, shashidhara.veerabhadra...@oracle.com wrote:
Hi All, Please review a fix for an accessibility vpat issue.
Bug: https://bugs.openjdk.java.net/browse/JDK-8213071
Webrev:
On 11/11/2018 05:30, shashidhara.veerabhadra...@oracle.com wrote:
This fix works for both windows and mac. Mac may have a short cut to ignore
such things but we still need to solve the problem for windows and for mac(for
TAB key traversal case). TAB key is consumed by java swing for traversal
s,
against which you need to verify the new change/fix
in the testcase(the updated test should fail before the
fix for "@bugid" and pass after).
On 08/11/2018 20:24, Prasanta Sadhukhan wrote:
looks ok. Please add the bugid to the test.
Regards
Prasanta
On 09-Nov-18 5:28 AM, Sergey By
On 07/11/2018 23:18, Shashidhara Veerabhadraiah wrote:
From the usability perspective of a disabled person, I don't think one would
know use the Ctrl+option+shift kind of traversal and they would definitely
prefer to be same across the platforms. i.e., TAB key traversals(just the
important
Looks fine.
On 09/11/2018 08:09, Anton Litvinov wrote:
Hello reviewers,
This is a kind reminder. Could anybody please look at this review request?
Thank you,
Anton
On 02/11/2018 22:32, Anton Litvinov wrote:
Hello,
Could you please review the following fix for the bug.
Bug:
Hello.
Please review the fix for jdk 12.
Bug: https://bugs.openjdk.java.net/browse/JDK-8198398
Webrev: http://cr.openjdk.java.net/~serb/8198398/webrev.00
Exception reported in this bug is not reproducible since we run our tests
in othervm mode, but we have an opposite bug, the jtreg may report
Looks fine.
On 08/11/2018 15:23, Alexandre (Shura) Iline wrote:
I have updated the web rev accordingly:
http://cr.openjdk.java.net/~shurailine/8186549/webrev.01/test/jdk/java/awt/Modal/ModalBlockingTests/BlockingDFSetModalTest.java.sdiff.html
Let me know if there are other concerns.
Shura
and regards,
Shashi
-Original Message-
From: Sergey Bylokhov
Sent: Tuesday, November 6, 2018 2:06 AM
To: Shashidhara Veerabhadraiah ;
swing-dev@openjdk.java.net
Subject: Re: [12] JDK-8198624:
java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.html fails on
mac
Hi
Hi, Prasanta.
This also looks like a product bug, which was triggered by not strictly correct
test.
The test creates a situation when the JFileChooser start initialization during
VM shutdown.
This initialization tries to install shutdownHooks which unexpectedly fails,
and causes the whole
Hi, Prasanta.
It looks like a product issue in 2D in the GDI native code, isn't it?
I think that the reason might be a race between disposing the component in
main(), and draw operation on EDT.
Based on the stack trace it looks like Java2D tries to draw something to the
native component which
/~pbansal/8213536/webrev.01/
Regards,
Pankaj
-Original Message-----
From: Sergey Bylokhov
Sent: Thursday, November 8, 2018 11:47 PM
To: Pankaj Bansal; awt-...@openjdk.java.net; swing-dev@openjdk.java.net
Subject: Re: [12] RFR JDK-8213536: Update ProblemList.txt for Linux
Hi, Pankaj.
On 08/11/2
Hello.
Please review the fix for jdk 12.
Bug: https://bugs.openjdk.java.net/browse/JDK-8199072
Webrev: http://cr.openjdk.java.net/~serb/8199072/webrev.00
Bug was found when our tests executed in the "agentvm" mode.
The reason of test failure was the jtreg not able to interrupt EDT,
on which the
In light of above comments, I think we can safely remove these below 4 tests from
problemlist> javax/swing/JButton/8151303/PressedIconTest.java>
javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedPerPixelTranslucentGradient.java>
javax/swing/JComboBox/6607130/bug6607130.java
Hello.
Please review the fix for jdk 12.
Bug: https://bugs.openjdk.java.net/browse/JDK-8198321
Webrev: http://cr.openjdk.java.net/~serb/8198321/webrev.00
This test verifies that "JEditorPane.copy()" method will trigger
security check for "accessClipboard" permission. This is the same permission
penjdk.java.net/browse/JDK-8213514
webrev: http://cr.openjdk.java.net/~psadhukhan/8213514/webrev/
Regards
Prasanta
On 08-Nov-18 12:22 AM, Sergey Bylokhov wrote:
Hi, Prasanta.
In the log of Test8173145 the ClassCastException exists as well:
https://bugs.openjdk.java.net/browse/JDK
I think it is fine.
On 08/11/2018 11:23, Alexandre (Shura) Iline wrote:
That aside, Phil, Sergey, I would really like your opinion on test selection.
Did I run the right tests to verify the fix?
Shura
On Nov 7, 2018, at 3:05 PM, Alexandre (Shura) Iline mailto:alexandre.il...@oracle.com>>
Note that for some of the tests I'll need to update the problem list and
replace the .html by the .java.
But since we actively updates the problem lists right now I postponed this task
for a weekend.
On 07/11/2018 15:47, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk 12.
Bug
Hi, Pankaj.
On 08/11/2018 05:33, Pankaj Bansal wrote:
This change adds 20 new tests to the ProblemList for Linux, though only 2 new
bugs have been created. Other failures already have corresponding bugs.
Can you please update all old bugs with a comment that the test can fail on
On 08/11/2018 08:30, Alexey Ivanov wrote:
What Sergey found is not general purpose but rather accessibility tool
shortcuts. In that case, progress bar is still not accessible when using Tab,
is it?
This bug is not about access of the components using Tab,
but about access information from
On 07/11/2018 11:42, Alexey Ivanov wrote:
Narrator does not work with Java apps: it sees only the top-level window of
SwingSet2.
It is still unsupported =(, we need to check the jaws first using their
shortcuts:
https://www.freedomscientific.com/Content/Documents/Manuals/JAWS/Keystrokes.txt
the UI.
On macOS the "tab" iterates over the visible UI components, while the "special"
shortcuts iterates over the accessible elements that implements some roles.
Thanks and regards,
Shashi
-Original Message-
From: Sergey Bylokhov
Sent: Thursday, November 8, 2018 12:3
On 07/11/2018 21:44, Prasanta Sadhukhan wrote:
I found that these tests are passing when ran for 100 iterations on windows
javax/swing/plaf/basic/Test6984643.java
It is necessary to check the code of the tests as well, for example the test
above was reported in JDK-8198340.
The reason is that
801 - 900 of 1923 matches
Mail list logo
