On 4/20/2016 12:11 AM, Phil Race wrote:
PS I see the class doc talks about shouldYieldFocus() being called,
so I don't understand the inter-relationship of that and verify(), but
it makes me no more sure that deprecating that method is right.
I deprecated shouldYieldFocus(JCopmponent) and added
p.s. JPRT ran OK.
Still need one more +1.
On 4/19/16 2:16 PM, Phil Race wrote:
> +1
>
> -phil.
>
> On 04/19/2016 12:05 PM, Pete Brunet wrote:
>> New patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8076554/webrev.03/
>>
>> Changes:
>> - removed _AccessibleState
>> - removed wildcard imports.
>>
PS I see the class doc talks about shouldYieldFocus() being called,
so I don't understand the inter-relationship of that and verify(), but
it makes me no more sure that deprecating that method is right.
I think perhaps verify() is all that the app is supposed to have over-ridden
and the comments
+1
-phil.
On 04/19/2016 12:05 PM, Pete Brunet wrote:
New patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8076554/webrev.03/
Changes:
- removed _AccessibleState
- removed wildcard imports.
Is this ready to push?
Pete
On 4/19/16 12:26 PM, Phil Race wrote:
oh one nit picky thing - can we get
New patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8076554/webrev.03/
Changes:
- removed _AccessibleState
- removed wildcard imports.
Is this ready to push?
Pete
On 4/19/16 12:26 PM, Phil Race wrote:
> oh one nit picky thing - can we get rid of the wild card imports ?
>
> -phil.
>
> On
On 4/19/2016 7:47 PM, Phil Race wrote:
Hi,
You are deprecating shouldYieldFocus(JComponent) and yet this class
directly uses it.
Is this deprecation really the right thing to do ?
Why is this not correct? There are plenty examples in JDK:
Component#setVisible() & Component#show(),
oh one nit picky thing - can we get rid of the wild card imports ?
-phil.
On 04/19/2016 10:21 AM, Phil Race wrote:
Which seems to imply the _AccessibleState subclass has been obsolete
since 1.5
Although when these tools were unbundled it perhaps could not assume 1.5.
The rest of the changes
Hi,
You are deprecating shouldYieldFocus(JComponent) and yet this class
directly uses it.
Is this deprecation really the right thing to do ?
The new over-loaded shouldYieldFocus() is perhaps not much more than a
utility.
And the doc says "calls verify(input)" which seems odd since you do
Which seems to imply the _AccessibleState subclass has been obsolete
since 1.5
Although when these tools were unbundled it perhaps could not assume 1.5.
The rest of the changes look fine and it is a lot simpler than the v0 ..
-phil.
On 04/19/2016 08:54 AM, Pete Brunet wrote:
Thanks for
On 19.04.16 11:46, Avik Niyogi wrote:
Hi All,
Please review my code changes with inputs received:
Can you please add some description of your changes, it seems you
removed all code which was added by you previously.
http://cr.openjdk.java.net/~aniyogi/8152492/webrev.01/
With Regards,
Avik
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8152677/webrev.01
- file chooser file filter is used as an initial value for the old
file filter in the AquaFileChooserUI.FilterComboBoxModel
- AcceptAllFileFilter class and filed are made static
The
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8154431
webrev: http://cr.openjdk.java.net/~ssadetsky/8154431/webrev.00/
The thing is the Swing validation doesn't allow to validate state of the
target component of input focus transfer operation.
To support that
On 4/11/2016 4:29 PM, Philip Race wrote:
On 4/6/16, 1:23 PM, Alexander Scherbatiy wrote:
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8132119/webrev.09
- TextUIDrawing interface and its default implementaion
BasicTextUIDrawing class are added
- font
Hi Sergey,
I have tried all these Input sources:
I am unable to reproduce the test failure as mentioned by you with these
inputs. Please provide some screenshots and/or details of the procedure used
for this test failure.
Thank you in advance.
With Regards,
Avik Niyogi
> On 08-Apr-2016, at
14 matches
Mail list logo
