+1
On 27.08.2020 01:33, Prasanta Sadhukhan wrote:
Thanks Sergey for your review. I have added AquaComboBoxButton also in the fix as
the regression test fails for Aqua L
http://cr.openjdk.java.net/~psadhukhan/6542439/webrev.1/
mach5 job link is in JBS.
Regards
Prasanta
On 22-Aug-20 8:27 AM,
+1
On 27.08.2020 11:51, Philip Race wrote:
+1
-phil
On 8/27/20, 11:42 AM, Prasanta Sadhukhan wrote:
Hi All,
This is a request to review backout of JFileChooser fix. The change affects mac
and the fix should be restricted to windows. I tested the fix on windows/linux
but mac was omitted.
+1
-phil
On 8/27/20, 11:42 AM, Prasanta Sadhukhan wrote:
Hi All,
This is a request to review backout of JFileChooser fix. The change
affects mac and the fix should be restricted to windows. I tested the
fix on windows/linux but mac was omitted.
It seems Desktop/ is not
Hi All,
This is a request to review backout of JFileChooser fix. The change
affects mac and the fix should be restricted to windows. I tested the
fix on windows/linux but mac was omitted.
It seems Desktop/ is not IShellFolder/IShellDetails
interface so returns null, which is why the data is
Hi, Prasanta.
On 27.08.2020 02:59, Prasanta Sadhukhan wrote:
I have added the evaluation to JBS and I can see the issue even in 6u211, 7u281
too in my windows10.
- I checked behavior of the test on macOS and it looks like the JFileChooser has only 3 columns:
"name", "Size", "date".
How
On 27-Aug-20 12:58 AM, Philip Race wrote:
Approved but ...
Can you add an evaluation to the bug report ? It has none.
Was this a regression due to some other fix in JDK 8? Or been there
forever which would be suprising
Either way please add that info.
I have added the evaluation to JBS
Hi Alexey,
Thanks for the review
> On 21-Aug-2020, at 1:04 AM, Alexey Ivanov wrote:
>
> Hi Tejpal,
>
> Looks good overall, however, I have a couple of comments.
>
> I suggest using the elements for setting width of table columns. Add
> the following three lines before in *properties.html*:
Thanks Sergey for your review. I have added AquaComboBoxButton also in
the fix as the regression test fails for Aqua L
http://cr.openjdk.java.net/~psadhukhan/6542439/webrev.1/
mach5 job link is in JBS.
Regards
Prasanta
On 22-Aug-20 8:27 AM, Sergey Bylokhov wrote:
Looks fine.
On 20.08.2020
Hi All,
Please review a fix for a test issue problemlisted for mac.
Proposed fix is to add autodelay to add some delay between key events,
without which the test fail in some slow mach5 system.
mach5 job for several iterations is successful in all platforms and link
is in JBS.
Bug:
