Re: [13] RFR 8196467:javax/swing/JInternalFrame/Test6325652.java fails

> wrote: > > looks ok to me but I think ProblemList really should have 8224977 > <https://bugs.openjdk.java.net/browse/JDK-8224977> as the bug id which is the > product issue. > Regards > Prasanta > On 17-Jun-19 3:05 PM, Tejpal Rebari wrote: >> Hi All, >> Please

Re: [13] RFR 8196467:javax/swing/JInternalFrame/Test6325652.java fails

; > Thanks, > Jay > >> On 19-Jun-2019, at 2:17 PM, Tejpal Rebari > <mailto:tejpal.reb...@oracle.com>> wrote: >> >> Hi All, >> Changed the Bug Id In the ProblemList to 8224977. >> Updated webrev : >> http://cr.openjdk.java.net/~pkbalakr/Tejpa

[13] RFR 8196467:javax/swing/JInternalFrame/Test6325652.java fails

Hi All, Please review a test fix for issue where test fails while restoring the iconified frame in linux platform, and fails while iconifying the frame in Mac platform. Adding some delay after robot events solves the problem. 1.Linux : Test runs successfully. 2.Mac :

[13] RFR 8194048:Regression automated test '/open/test/jdk/javax/swing/text/DefaultCaret/HidingSelection/HidingSelectionTest.java' fails

Hi All, Please review a test-fix for JDK-8194048 where the test fails on windows 7 because, when selection ownership goes to second window the selection is still shown in first window. In Windows and Mac platform when some text field is selected on second Window, the selected text in first

[13] RFR 8042383:javax/swing/plaf/basic/BasicMenuUI/4983388/bug4983388.java fails with shortcuts on menus do not work

Hi All, Please review a test fix for the issue where the test fails while selecting menu by shortcut keys in Mac OS. The test contains some KeyPress and KeyRelease events in the hitMnemonics method of Util.And there is no delay added after these events. Adding some delay after robot events

[13] RFR 8194944:Regression automated test 'open/test/jdk/javax/swing/JInternalFrame/8145896/TestJInternalFrameMaximize.java' fails

Hi All, Please review a test fix for the issue where the test fails on Mac and Linux intermittently. The test fails because of “component must be showing on the screen to determine its location” error. Which is because the test tries to get the location of the component and the component is

Re: [13] RFR 8194944:Regression automated test 'open/test/jdk/javax/swing/JInternalFrame/8145896/TestJInternalFrameMaximize.java' fails

Looking for the second “+1”. Thanks Tejpal > On 07-Aug-2019, at 2:20 PM, Ambarish Rapte wrote: > > Looks good to me, +1. > > Regards, > Ambarish > > From: Tejpal Rebari > Sent: Tuesday, August 06, 2019 12:36 PM > To: Ambarish Rapte <mailto:ambarish.

Re: [13] RFR 8194944:Regression automated test 'open/test/jdk/javax/swing/JInternalFrame/8145896/TestJInternalFrameMaximize.java' fails

bove comments and here is the latest changes. webrev : http://cr.openjdk.java.net/~trebari/swing/8194944/webrev3/ <http://cr.openjdk.java.net/~trebari/swing/8194944/webrev3/> Thanks and regards Tejpal > > From: Prasanta Sadhukhan > Sent: Thursday, July 25, 2019 3:43 PM > To: Tejpal Rebari

Re: [13] RFR 8194944:Regression automated test 'open/test/jdk/javax/swing/JInternalFrame/8145896/TestJInternalFrameMaximize.java' fails

Hi All, Added the blockTillDisplayed() method instead of 1000ms delay. here is the latest changes. webrev : http://cr.openjdk.java.net/~pkbalakr/Tejpal/8194944/webrev1 <http://cr.openjdk.java.net/~pkbalakr/Tejpal/8194944/webrev1> Thanks and regards Tejpal Rebari > On 08-Jul-2019, a

Re: [13] RFR 8194944:Regression automated test 'open/test/jdk/javax/swing/JInternalFrame/8145896/TestJInternalFrameMaximize.java' fails

ariable for executeTest() should be retained. > > Regards > Prasanta > On 19-Jul-19 1:11 PM, Tejpal Rebari wrote: >> Hi All, >> Added the blockTillDisplayed() method instead of 1000ms delay. >> >> here is the latest changes. >> webrev : http://cr.openj

Re: [13] RFR 8194944:Regression automated test 'open/test/jdk/javax/swing/JInternalFrame/8145896/TestJInternalFrameMaximize.java' fails

a.net/jdk9/jdk9/jdk/rev/ef8fd276efe1 > <http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/ef8fd276efe1>]. > > Regards > Prasanta > On 25-Jul-19 12:33 PM, Tejpal Rebari wrote: >> Hi Prasanta, >> Agreed that the two points should be different, so retained the p

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

**. > 3. You should not need the GridBagConstraints code anywhere to reproduce > the issue. You should remove this. > > > Regards, > Pankaj >   <> > From: Prasanta Sadhukhan > Sent: Monday, November 11, 2019 11:47 AM > To: Tejpal Rebari > Cc:

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

nta Sadhukhan >> *Sent:* Tuesday, November 12, 2019 11:30 AM >> *To:* Tejpal Rebari; Pankaj Bansal >> *Cc:* swing-dev@openjdk.java.net >> *Subject:* Re: [14] RFR JDK-8190763 - Class cast exception on >> (CompoundEdit) UndoableEditEvent.getEdit() >> Please re

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

ckSupport which was also introduced as a fix of JDK-8030702. Regards Tejpal > >> Regards >> Tejpal >>> >>> On 11/11/19 11:04 pm, Pankaj Bansal wrote: >>>> Looks good to me >>>> -Pankaj >>>> *From:*Prasanta Sadhu

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

, > > Can you add a testcase to the fix? I guess one is there in the JBS itself. > > Regards > Prasanta > On 24-Oct-19 10:31 AM, Tejpal Rebari wrote: >> Hi All, >> Please review the following fix for jdk14. >> >> Bug : https://bugs.openjdk.ja

Re: [14] RFR JDK-7020860 - BasicTreeUI contains getters/setters with unclear spec

ote: >> >> Its looks okay. >> Lets wait for Sergey’s inputs on the same. >> >> And I think it needs CSR also. >> >> Thanks, >> Jay >> >>> On 22-Nov-2019, at 3:04 PM, Tejpal Rebari >> <mailto:tejpal.reb...@oracle.com>>

Re: [14] RFR JDK-7020860 - BasicTreeUI contains getters/setters with unclear spec

Gentle reminder > On 04-Dec-2019, at 3:02 PM, Tejpal Rebari wrote: > > > Hi Phil, > >> On 27-Nov-2019, at 9:59 PM, Philip Race > <mailto:philip.r...@oracle.com>> wrote: >> >> Yes it needs a CSR. >> > Will raise a CSR once the re

Re: [14] RFR JDK-7020860 - BasicTreeUI contains getters/setters with unclear spec

Hi Sergey, > On 13-Dec-2019, at 5:07 AM, Sergey Bylokhov > wrote: > > Probably we can update the BasicTreeUI.setLargeModel() as well? current spec > looks incomplete: > >/** > * Updates the componentListener, if necessary. > * > * @param largeModel the new value > */ >

Re: [14] RFR JDK-8223788 - [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key

Hi Sergey, > Is it possible to add an automated test for this use case? I have added an automated test. Here is the updated webrev : http://cr.openjdk.java.net/~trebari/swing/8223788/webrev1/ Tested on Mac,Windows and Linux , with

Re: [14] RFR JDK-8223788 - [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key

gards Tejpal > On 12/4/19 10:25 pm, Tejpal Rebari wrote: >> There is no such issue with other LookAndFeels. >> Fix : The focusable property is set to true by default, Fix is to set the >> JSpinner button focusable property false in AquaLookAndFeel. > > > > > > -- > Best regards, Sergey.

Re: [14] RFR JDK-8234802 - [TESTBUG] Test Right Mouse Button Drag Gesture Recognition in all the platforms

The test should dispose the frame on all code paths. > > On 12/5/19 4:06 am, Tejpal Rebari wrote: >> Hi All, >> Please review a test fix for jdk-14. >> Bug : https://bugs.openjdk.java.net/browse/JDK-8234802 >> Webrev : http://cr.openjdk.java.net/~trebari/swing/823

[14] RFR JDK-8223788 - [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key

Hi All, Please review the following fix for jdk14. Bug : https://bugs.openjdk.java.net/browse/JDK-8223788 Webrev : http://cr.openjdk.java.net/~trebari/swing/8223788/webrev0/

[14] RFR JDK-8234802 - [TESTBUG] Test Right Mouse Button Drag Gesture Recognition in all the platforms

Hi All, Please review a test fix for jdk-14. Bug : https://bugs.openjdk.java.net/browse/JDK-8234802 Webrev : http://cr.openjdk.java.net/~trebari/swing/8234802/webrev0/ This

Re: [14] RFR JDK-7020860 - BasicTreeUI contains getters/setters with unclear spec

Hi Sergey, I have updated the summary for setLargeModel. Please take a look : http://cr.openjdk.java.net/~trebari/swing/7020860/webrev2/ Regards Tejpal

[14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

Hi All, Please review the following fix for jdk14. Bug : https://bugs.openjdk.java.net/browse/JDK-8190763 Webrev : http://cr.openjdk.java.net/~trebari/swing/8190763/webrev0/

[14] RFR JDK-7020860 - BasicTreeUI contains getters/setters with unclear spec

Hi All, Please review the following fix for JDK 14. Bug : https://bugs.openjdk.java.net/browse/JDK-7020860 Webrev : http://cr.openjdk.java.net/~trebari/swing/7020860/webrev0/

Re: [14] RFR JDK-7020860 - BasicTreeUI contains getters/setters with unclear spec

ctober/006815.html> > and http://mail.openjdk.java.net/pipermail/swing-dev/2017-June/007495.html > <http://mail.openjdk.java.net/pipermail/swing-dev/2017-June/007495.html> > > Apart from this changes are fine. > > Thanks, > Jay > > From: Tejpal

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

ain() > itself. I guess frame.setIconImage() also is not needed. > Also, please add @Override annotation to run() method of EDT. > On 11-Nov-19 3:07 PM, Tejpal Rebari wrote: >> Hi all, >> I have removed GridBagLayout() ,GridBagConstraints and author tag , >> moved

RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

Hi All, Please review the following fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8146330 Webrev : http://cr.openjdk.java.net/~trebari/swing/8146330/webrev0/

Re: [14] RFR JDK-8223788 - [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key

/~trebari/swing/8223788/webrev3/ <http://cr.openjdk.java.net/~trebari/swing/8223788/webrev3/> regards Tejpal > > On 1/10/20 1:32 am, Tejpal Rebari wrote: >> Hi Sergey, >> I had removed the colorchooser and created a frame and added two spinner to >>

Re: [14] RFR JDK-8223788 - [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key

Hi Sergey, I had removed the colorchooser and created a frame and added two spinner to it. Then noticed that the issue is reproducible only when the ContainerOrderFocusTraversalPolicy is set. When ContainerOrderFocusTraversalPolicy is set, in JSpinner there are four components which captures

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

Hi Sergey, > On 09-Mar-2020, at 5:27 PM, Sergey Bylokhov > wrote: > > Hi, Tejpal. > Do not you need to call super.keySet() as well? > +set.addAll(super.keySet()); > return set; Yes, will update this. > > similar to public Set> entrySet() {...} > > It would be good to update the test to

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

Hello Pankaj and Sergey, I have updated the keySet() method and test as per your suggestions. Please take a look. Webrev : http://cr.openjdk.java.net/~trebari/swing/8146330/webrev1/ Regards Tejpal

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

Thanks for review Pankaj. > On 09-Mar-2020, at 11:42 AM, Pankaj Bansal wrote: > > Hello Tejpal, > > The product fix part looks ok to me. > You are still not following the 80 chars max per line convention in line 44. > Also, you don’t need to print keysCount and KeySetCount if they are equal.

Re: RFR: 8241228 Test jdk/javax/swing/UIDefaults/8146330/UIDefaultKeySizeTest.java is failing

Sadhukhan > wrote: > > I think for this bug only, you can create a webrev out of jdk/jdk with this > fix and an updated problem list removing aix-all and commit that in jdk/jdk > directly. > > Regards > Prasanta > On 31-Mar-20 11:35 AM, Tejpal Rebari wrote: >> H

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

enjdk.java.net/~trebari/swing/8146330/webrev3/> Thanks Tejpal >> On 13-Mar-2020, at 3:36 PM, Sergey Bylokhov > <mailto:sergey.bylok...@oracle.com>> wrote: >> >> Looks fine. >> >> On 3/13/20 2:30 am, Tejpal Rebari wrote: >>> Hi Sergey, >>&

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

Hi Sergey, > On 11-Mar-2020, at 5:27 AM, Sergey Bylokhov > wrote: > > On 3/10/20 1:04 am, Tejpal Rebari wrote: >> I am not getting how to cover this in the test. > > I that additional call is necessary, then it should be possible to trigger it > by the test. >

Re: RFR: 8241228 Test jdk/javax/swing/UIDefaults/8146330/UIDefaultKeySizeTest.java is failing

Hi Sergey, > On 31-Mar-2020, at 11:14 AM, Sergey Bylokhov > wrote: > > Hi, Tejpal. > > The fix looks fine, but you need to wait until the fix for JDK-8241491 > will not be merged to JDK/client, otherwise, the merge conflict will occur. JDK-8241491 is problem listing the test for aix-all. I

RFR: 8241228 Test jdk/javax/swing/UIDefaults/8146330/UIDefaultKeySizeTest.java is failing

Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8241228 Fix : http://cr.openjdk.java.net/~trebari/swing/8241228/webrev00/

RFR: 8229856 [macos] Opening a menu on a JTextField can clear the text selection

Hi All, Please review the following fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8229856 Webrev : http://cr.openjdk.java.net/~trebari/swing/8229856/webrev00/ Issue : This issue exists in AquaLookandFeel only. The issue is that while opening a menu on a JTextFeild using

RFR: 8233559 [TESTBUG] TestNimbusOverride.java is failing on macos

Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233559 Webrev : http://cr.openjdk.java.net/~trebari/swing/8233559/webrev00/

RFR: 8238085 PIT: javax/swing/JSpinner/8223788/JSpinnerButtonFocusTest.java fails on mac

Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8238085 Fix : http://cr.openjdk.java.net/~trebari/swing/8238085/webrev00/

Re: RFR: 8238085 PIT: javax/swing/JSpinner/8223788/JSpinnerButtonFocusTest.java fails on mac

Hi Sergey, > On 07-May-2020, at 3:11 AM, Sergey Bylokhov > wrote: > > Hi, Tejpal. > > Please confirm that the update test still fail before the fix of JDK-8223788. Yes I verified that the test fails without the fix of JDK-8223788. > > On 5/6/20 11:38 am, Tejpa

Re: RFR: 8229856 [macos] Opening a menu on a JTextField can clear the text selection

Hi Prasanta, > On 22-Apr-2020, at 1:59 PM, Prasanta Sadhukhan > wrote: > > Hi Tejpal, > > Does it need to be triple click of any button or only left mouse button? If > only left, then it needs to be checked? > It is triple click of left mouse button, I have added a check for it. > Also, I

Re: RFR: 8233559 [TESTBUG] TestNimbusOverride.java is failing on macos

Hi Pankaj, > On 19-May-2020, at 9:52 AM, Pankaj Bansal wrote: > > < > Actually I meant to ask if you have tried to run the test in group with other > tests. The test may be passing when run as individual test, but may again > start failing when run in nightly after removing from ProblemList.

RFR: 8233553 [TESTBUG] JSpinner test bug4973721.java fails on MacOS

Hi All, Please review the following test only fix for jdk15. Bug: https://bugs.openjdk.java.net/browse/JDK-8233553 Webrev : http://cr.openjdk.java.net/~trebari/swing/8233553/webrev00/

Re: RFR: 8229856 [macos] Opening a menu on a JTextField can clear the text selection

Hi Prasanta, > On 06-May-2020, at 5:11 PM, Prasanta Sadhukhan > wrote: > > Looks good to me. But one question, do you require showPopupMenu() on > mouseReleased() too? > It doesn’t have any effect. I just kept it because it was there in submitted test [JBS]. Thanks and regards Tejpal

RFR: 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual

Hi All, Please review the following test only fix for jdk15. Bug: https://bugs.openjdk.java.net/browse/JDK-8239827 Webrev : http://cr.openjdk.java.net/~trebari/swing/8239827/webrev00/

Re: RFR: 8251122: doclint html5 errors in java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html

t; reserved. > > The same comment applies to *properties.html* and *componentProperties.html* > files in the webrev. I don't mind if you make this change before pushing > without creating an additional webrev. > > > Other that, it looks fine to me. > > Regards, > Alexe

Re: RFR: 8251122: doclint html5 errors in java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html

ing/8251122/webrev03/> > On 27-Aug-2020, at 2:15 PM, Tejpal Rebari wrote: > > Hi Alexey, > Thanks for the review > >> On 21-Aug-2020, at 1:04 AM, Alexey Ivanov > <mailto:alexey.iva...@oracle.com>> wrote: >> >> Hi Tejpal, >> >> Loo

Re: RFR: 8254112: javax/swing/plaf/basic/BasicComboPopup/JComboBoxPopupLocation/JComboBoxPopupLocation.java fails on windows [v2]

On Wed, 7 Oct 2020 08:54:22 GMT, Prasanta Sadhukhan wrote: >> Please review a test issue where the test was seen to be failing on windows >> mach5 system in hidpi mode. >> I have ran the test locally with different scale factors without reproducing >> the issue. Also, mach5 job running this

RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions

Please review the following fix for jdk16. Issue : There is a JToggleButton that will post/take down a JPopupMenu when the button is selected. If the button is selected and the menu is not posted the action listener will post the menu. If the button is selected and the menu is displayed the

Re: RFR: 8194126: Regression automated Test '/open/test/jdk/javax/swing/JColorChooser/Test7194184.java' fails

On Fri, 16 Oct 2020 03:31:41 GMT, Prasanta Sadhukhan wrote: > Please review a test fix for an issue where the color is not chosen correctly. > The issue seems to stem from the fact that keys are not processed properly so > the proper color is not chosen. > Fixed by adding autoDelay during

Re: RFR: 8251122: doclint html5 errors in java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html

Hi Alexey, Thanks for the review > On 21-Aug-2020, at 1:04 AM, Alexey Ivanov wrote: > > Hi Tejpal, > > Looks good overall, however, I have a couple of comments. > > I suggest using the elements for setting width of table columns. Add > the following three lines before in *properties.html*:

RFR: 8251122: doclint html5 errors in java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html

Hi All, Please review the following fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8251122 Webrev : http://cr.openjdk.java.net/~trebari/swing/8251122/webrev00/ Issue

Re: RFR: 6441211: Small Error in API at javax.swing.plaf.synth.Region

On Tue, 29 Sep 2020 08:27:43 GMT, Prasanta Sadhukhan wrote: > Fixed a small typo Marked as reviewed by trebari (Author). - PR: https://git.openjdk.java.net/jdk/pull/396

Re: RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac [v2]

On Thu, 24 Sep 2020 16:11:11 GMT, Phil Race wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Testing filechooser on aqua at a different place, where context popup works > > test/jdk/

Integrated: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac

On Wed, 16 Sep 2020 11:45:12 GMT, Tejpal Rebari wrote: > The test test/jdk/javax/swing/JPopupMenu/4966112/bug4966112.java fails for > Mac OS X > with the error message Popup was not shown on FileChooser. > > Popup doesn't appear for JFileChooser in MAC OS X platform so >

Re: RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac [v2]

> The test test/jdk/javax/swing/JPopupMenu/4966112/bug4966112.java fails for > Mac OS X > with the error message Popup was not shown on FileChooser. > > Popup doesn't appear for JFileChooser in MAC OS X platform so > skipping this test for Mac OS X. Tejpal Rebari has update

Re: RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac

On Wed, 23 Sep 2020 06:50:52 GMT, Sergey Bylokhov wrote: >>> So the popup actually works in that dialog, we just need to test it in a >>> different place? >> >> Yes. > >> > So the popup actually works in that dialog, we just need to test it in a >> > different place? >> Yes. > > Then it

Re: RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac [v3]

> The test test/jdk/javax/swing/JPopupMenu/4966112/bug4966112.java fails for > Mac OS X > with the error message Popup was not shown on FileChooser. > > Popup doesn't appear for JFileChooser in MAC OS X platform so > skipping this test for Mac OS X. Tejpal Rebari has update

Re: RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac [v3]

On Fri, 25 Sep 2020 21:40:14 GMT, Sergey Bylokhov wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added check for Aqua LAF instead of Mac OS and minor cleanup > > test/jdk/

Re: RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac [v4]

> The test test/jdk/javax/swing/JPopupMenu/4966112/bug4966112.java fails for > Mac OS X > with the error message Popup was not shown on FileChooser. > > Popup doesn't appear for JFileChooser in MAC OS X platform so > skipping this test for Mac OS X. Tejpal Rebari has update

Re: RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac [v3]

On Sat, 26 Sep 2020 06:13:43 GMT, Sergey Bylokhov wrote: >> I doubt that if some test will be added later the filechooser under the test >> became non-aqua. > > It is the Aqua from the beginning till the end or some other L Ok, in that case we can remove this line - PR:

Re: RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac

On Wed, 16 Sep 2020 20:29:39 GMT, Sergey Bylokhov wrote: >> The test test/jdk/javax/swing/JPopupMenu/4966112/bug4966112.java fails for >> Mac OS X >> with the error message Popup was not shown on FileChooser. >> >> Popup doesn't appear for JFileChooser in MAC OS X platform so >> skipping this

Re: RFR: 8233559 [TESTBUG] TestNimbusOverride.java is failing on macos

green. Links are in JBS Thanks and regards Tejpal > On 19-May-2020, at 1:39 PM, Tejpal Rebari wrote: > > Hi Pankaj, > >> On 19-May-2020, at 9:52 AM, Pankaj Bansal wrote: >> >> <> >> Actually I meant to ask if you have tried to run the test in gro

RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac

The test test/jdk/javax/swing/JPopupMenu/4966112/bug4966112.java fails for Mac OS X with the error message Popup was not shown on FileChooser. Popup doesn't appear for JFileChooser in MAC OS X platform so skipping this test for Mac OS X. - Commit messages: - Skip JFileChooser test

Re: RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac

On Sat, 19 Sep 2020 02:30:54 GMT, Sergey Bylokhov wrote: > So the popup actually works in that dialog, we just need to test it in a > different place? Yes. - PR: https://git.openjdk.java.net/jdk/pull/204

Re: RFR: 8249674: Redo: Nimbus JTree renderer properties persist across L changes

away from using bug ids in path names or the names > of the tests themselves. > > -phil > > On 7/29/20, 4:53 AM, Prasanta Sadhukhan wrote: >> >> >> On 29-Jul-20 1:25 PM, Tejpal Rebari wrote: >>> Hi Prasanta, >>> >>>> On 27-Jul-2

Re: RFR: 8249674: Redo: Nimbus JTree renderer properties persist across L changes

Gentle Reminder. > On 04-Aug-2020, at 11:46 AM, Tejpal Rebari wrote: > > Hi Phil, > I have updated the path of the test. > Updated webrev : http://cr.openjdk.java.net/~trebari/swing/8249674/webrev02/ > <http://cr.openjdk.java.net/~trebari/swing/8249674/webrev02/&

Re: RFR: 8251125: doclint errors about missing references in Swing javadoc

Hi Prasanta, > On 13-Aug-2020, at 6:52 PM, Prasanta Sadhukhan > wrote: > > > On 13-Aug-20 6:46 PM, Tejpal Rebari wrote: >> Hi Prasanta, >> Thanks for the review. >> >>> On 13-Aug-2020, at 6:36 PM, Prasanta Sadhukhan >>> wrote: >>&g

Re: RFR: 8251125: doclint errors about missing references in Swing javadoc

le. I have seen that there are other lines in the same file that doesn’t follow 80 chars per line. Regards Tejpal > > Regards > > Prasanta > > On 13-Aug-20 6:12 PM, Tejpal Rebari wrote: >> Hi All, >> Please review the following fix for jdk16. >> >&

RFR: 8251125: doclint errors about missing references in Swing javadoc

Hi All, Please review the following fix for jdk16. Bug: https://bugs.openjdk.java.net/browse/JDK-8251125 Webrev : http://cr.openjdk.java.net/~trebari/swing/8251125/webrev00/ Issue :

RFR: 8041701 Nimbus JTree renderer properties persist across L changes

Hi All, Please review the following fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8041701 Webrev : http://cr.openjdk.java.net/~trebari/swing/8041701/webrev00/ Issue

Re: RFR: 8041705 Bugs in DefaultTreeCellRenderer.updateUI()

> On 02-Jul-2020, at 2:44 PM, Tejpal Rebari wrote: > > Hi Pankaj, > > Thanks for the review. > >> On 02-Jul-2020, at 2:05 PM, Pankaj Bansal > <mailto:pankaj.b.ban...@oracle.com>> wrote: >> >> Hello Tejpal, >> >> Few comments ab

Re: RFR: 8041705 Bugs in DefaultTreeCellRenderer.updateUI()

Hi gouessej, > On 26-Jun-2020, at 7:02 PM, goues...@orange.fr wrote: > > Will this bug fix be backported into jdk11? > About the backport you should ask on jdk-updates-...@openjdk.java.net once this bug is fixed in latest jdk. Regards Tejpal

Re: RFR: 8041705 Bugs in DefaultTreeCellRenderer.updateUI()

Hi Prasanta, Thanks for the review. > On 29-Jun-2020, at 9:06 AM, Prasanta Sadhukhan > wrote: > > Fix looks ok but I think the test should actually set "Tree.rendererMargins" > value for NimbusL and check insets for other L is not same as nimbus when > "Tree.rendererMargins" is reset to

Re: RFR: 8041705 Bugs in DefaultTreeCellRenderer.updateUI()

Hi Pankaj, Thanks for the review. > On 02-Jul-2020, at 2:05 PM, Pankaj Bansal wrote: > > Hello Tejpal, > > Few comments about the test > > 1. Remove all wild imports > > 2. Why do you need to create "lf" variable? Just call setLookAndFeel with L > name > 3. Dispose the frame in EDT thread

Re: RFR: 8041701 Nimbus JTree renderer properties persist across L changes

Hi Sergey, Thanks for the review. > On 11-Jul-2020, at 11:41 AM, Sergey Bylokhov > wrote: > > Hi, Tejpal. > > The fix looks fine, could you please update the test to check that all > installed L work the same way. I have updated the test to check for all installed LAF. Updated webrev :

RFR: 8041705 Bugs in DefaultTreeCellRenderer.updateUI()

Hi All, Please review the following fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8041705 Webrev : http://cr.openjdk.java.net/~trebari/swing/8041705/webrev00/ Issue

RFR: 8249674: Redo: Nimbus JTree renderer properties persist across L changes

Hi All, Please review the following fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8249674 Webrev : http://cr.openjdk.java.net/~trebari/swing/8249674/webrev00/ This

RFR: Nimbus L Fix for 8041701 is causing some Nimbus tests to fail

Hi All, Please review the following fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8249619 Webrev : http://cr.openjdk.java.net/~trebari/swing/8249619/webrev00/ This

Re: RFR: Nimbus L Fix for 8041701 is causing some Nimbus tests to fail

> On 17-Jul-2020, at 8:59 PM, Philip Race wrote: > > Sound fine except do NOT re-open 8041701 - please file a new bug. Ok, sure I will file a new bug. Can somebody please push this change, as I don’t have commit rights. Thanks Tejpal > > -phil. > > On 7/17/20, 6:16 AM

Re: RFR: 8249674: Redo: Nimbus JTree renderer properties persist across L changes

9674/webrev01/> Thanks Tejpal > Regards > Prasanta > On 24-Jul-20 2:36 PM, Tejpal Rebari wrote: >> Hi All, >> Please review the following fix for jdk16. >> >> Bug : https://bugs.openjdk.java.net/browse/JDK-8249674 >> <https://bugs.openjdk.java.net/browse

Re: RFR: 8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64 [v2]

On Mon, 11 Jan 2021 04:50:09 GMT, Prasanta Sadhukhan wrote: >> This test was failing on mach5 nightly on ubuntu systems long time back. >> Modified the test to add some delays and call robot.waitForIdle() to make it >> more stable and the resultant test passes on all mach5 systems including

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v2]

and > feel. > > Fix : MouseGrabber is not removed while uninstalling the listeners in the > BasicPopupMenuUI. > By removing the mouseGrabber in the uninstallListeners() methods fixes this > issue. > > Added a test to test the same in all the LookAndFeels Tejpal Re

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v3]

and > feel. > > Fix : MouseGrabber is not removed while uninstalling the listeners in the > BasicPopupMenuUI. > By removing the mouseGrabber in the uninstallListeners() methods fixes this > issue. > > Added a test to test the same in all the LookAndFeels Tejpal Re

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v3]

On Wed, 14 Oct 2020 01:52:12 GMT, Sergey Bylokhov wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reworked fix, also fixed for nimbus,motif,GTK LAF > > t

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v2]

On Mon, 30 Nov 2020 17:53:48 GMT, Prasanta Sadhukhan wrote: >>> not wrong but different account but that doesnot make the comment invalid, >>> I guess. >> >> But nobody sees it, it is hidden. > > Well, the comment was added on Oct 15 and it got hidden on Oct28 because the > ac was not of

Re: RFR: 8258233: Reenable another fixed problemlisted test

On Mon, 14 Dec 2020 12:45:12 GMT, Prasanta Sadhukhan wrote: > javax/swing/JFileChooser/6868611/bug6868611.java was failing in windows in > mach5 testing but was fixed in JDK-8198004 later on, but this test was not > removed from problemList. We can remove it from problemlist now. > Tested for

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v4]

On Fri, 18 Dec 2020 00:18:22 GMT, Sergey Bylokhov wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> changed mode of files > > src/java.desktop/share/classes/com/sun/java/swing/plaf/g

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v4]

On Fri, 11 Dec 2020 10:18:12 GMT, Prasanta Sadhukhan wrote: >> In case of the first attempt to bring down the popup menu the event was >> consumed by following code of BasicPopupMenuUI >> boolean consumeEvent = >> >>

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v4]

On Fri, 18 Dec 2020 21:43:24 GMT, Sergey Bylokhov wrote: >> Before the fix the mouse event that cause the popup to close was consumed >> here as the "PopupMenu.consumeEventOnClose" was true. >> >> After the fix the mouse event that cause the popup to close will not be >> consumed here as

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v4]

On Wed, 14 Oct 2020 01:52:35 GMT, Sergey Bylokhov wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> changed mode of files > > Changes requested by serb (Reviewer). @mrserb please t

Re: RFR: 8258557: Deproblemlist fixed problemlisted test

On Thu, 17 Dec 2020 04:59:43 GMT, Prasanta Sadhukhan wrote: > javax/swing/PopupFactory/8048506/bug8048506.java was failing on windows in > nightly mach5 testing but was later fixed in JDK-6847157 but this test was > not removed from ProblemList. > We can remove this test from problemlist

RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic

Please review the following fix for jdk17. In this fix i have deprecated and marked for removal following classes and methods public void intervalAdded(ListDataEvent e) public void intervalRemoved(ListDataEvent e) protected boolean lt(File a, File b) in BasicDirectoryModel.java

Integrated: 8048109: JToggleButton does not fire actionPerformed under certain conditions

On Mon, 12 Oct 2020 08:01:43 GMT, Tejpal Rebari wrote: > Please review the following fix for jdk16. > > Issue : There is a JToggleButton that will post/take down a JPopupMenu when > the button is selected. If the button is selected and the menu is not posted > the action lis

Re: RFR: 8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64 [v2]

On Mon, 11 Jan 2021 04:50:09 GMT, Prasanta Sadhukhan wrote: >> This test was failing on mach5 nightly on ubuntu systems long time back. >> Modified the test to add some delays and call robot.waitForIdle() to make it >> more stable and the resultant test passes on all mach5 systems including

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic

On Wed, 13 Jan 2021 05:52:49 GMT, Prasanta Sadhukhan wrote: >> Please review the following fix for jdk17. >> In this fix i have deprecated and marked for removal following classes and >> methods >>public void intervalAdded(ListDataEvent e) >>public void intervalRemoved(ListDataEvent

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic [v2]

om 8049700 not deprecated the paintText(Graphics g, JComponent c, Rectangle > textRect, String text) method in BasicButtonUI as AquaButtonUI, > MetalButtonUI and MetalToggleButtonUI overrides it. > Similarly not deprecated ChangeHandler of BasicMenuUI as AquaMenuUI and > MotifMenuUI u

  1   2   >