On Wed, 25 Aug 2021 10:39:42 GMT, Pankaj Bansal wrote:
>> A container may include few default components as children, which are added
>> to it during creation. Due to this, calling function getChildrenCount on a
>> new created instance may return non zero value. This behaviour may vary
>>
On Mon, 16 Aug 2021 08:22:35 GMT, Pankaj Bansal wrote:
> A container may include few default components as children, which are added
> to it during creation. Due to this, calling function getChildrenCount on a
> new created instance may return non zero value. This behaviour may vary
>
On Mon, 23 Aug 2021 03:58:49 GMT, Prasanta Sadhukhan
wrote:
>> JInternalFrame.getDesktopIcon() can be null as setDesktopIcon() can be
>> called with null value. There are many places in JInternalFrame where
>> getDesktopIcon() is accessed without null check which might cause NPE.
>> Added
On Thu, 19 Aug 2021 16:48:46 GMT, Prasanta Sadhukhan
wrote:
>> JInternalFrame.getDesktopIcon() can be null as setDesktopIcon() can be
>> called with null value. There are many places in JInternalFrame where
>> getDesktopIcon() is accessed without null check which might cause NPE.
>> Added
On Mon, 16 Aug 2021 04:36:03 GMT, Prasanta Sadhukhan
wrote:
> > We should either prevent null being set or catch all those nulls.
>
> I did that in 1st iteration of this
> PR..https://github.com/openjdk/jdk/pull/4989/files/2a2ab50ded3305f3a9e0f01e90417b484a0b2db4
>
> @prrace Should I bring
On Mon, 16 Aug 2021 13:45:49 GMT, Prasanta Sadhukhan
wrote:
>> The test fails in CI testing citing expected "rededited" but found
>> "redEDITED", which seems to point to fact that either there is a CAPS_LOCK
>> key switched on or some other test did not use SHIFT key corectly ie,
>> pressed
On Mon, 16 Aug 2021 13:45:49 GMT, Prasanta Sadhukhan
wrote:
>> The test fails in CI testing citing expected "rededited" but found
>> "redEDITED", which seems to point to fact that either there is a CAPS_LOCK
>> key switched on or some other test did not use SHIFT key corectly ie,
>> pressed
On Sun, 15 Aug 2021 16:23:52 GMT, Phil Race wrote:
> This will fail regularly so problem list it.
This pull request has now been integrated.
Changeset: 6a5241c3
Author: Phil Race
URL:
https://git.openjdk.java.net/jdk/commit/6a5241c3adfd3ba886e469156dea56ed5b9673ff
Stats: 1 l
This will fail regularly so problem list it.
-
Commit messages:
- 8272491: Problem list
javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java on macos
Changes: https://git.openjdk.java.net/jdk/pull/5119/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5119=00
Issue:
On Sat, 14 Aug 2021 22:15:53 GMT, Sergey Bylokhov wrote:
> > Folks who are doing it are likely seeing random exceptions anyway at a
> > later time !
>
> What we will do if the field will be set to null directly? Throw NPE at any
> point later when we will found null?
The field is protected.
On Sat, 14 Aug 2021 22:12:57 GMT, Sergey Bylokhov wrote:
> > I don't believe any of the scenarios.
> > As you well know these headful tests will be re-run 2 more times if they
> > fail.
>
> But we know the log information only for the last failure, probably the
> button was pressed only for
On Wed, 11 Aug 2021 09:03:57 GMT, Prasanta Sadhukhan
wrote:
> The test fails in CI testing citing expected "rededited" but found
> "redEDITED", which seems to point to fact that either there is a CAPS_LOCK
> key switched on or some other test did not use SHIFT key corectly ie,
> pressed but
On Fri, 13 Aug 2021 04:34:52 GMT, Prasanta Sadhukhan
wrote:
>> JInternalFrame.getDesktopIcon() can be null as setDesktopIcon() can be
>> called with null value. There are many places in JInternalFrame where
>> getDesktopIcon() is accessed without null check which might cause NPE.
>> Added
On Tue, 20 Jul 2021 19:34:30 GMT, Phil Race wrote:
> These fields
> - have not been used by the implementation since JDK8,
> - are not supposed to be used by applications,
> - have been deprecated for removal since JDK 9
> - are non-standard, JDK not Java, classes
>
On Mon, 9 Aug 2021 03:17:20 GMT, Phil Race wrote:
> As per the bug comments, these tests fail too often on macOS arm.
> This will be too noisy for CI. So I would like to problem list them for
> mac-arm
This pull request has now been integrated.
Changeset: 0ac2be9b
Author:Phil
On Mon, 9 Aug 2021 04:39:02 GMT, Prasanta Sadhukhan
wrote:
> Maybe we should use JDK-8266243 instead. Other one has other tests as well.
I can do that. Somehow my search missed that as an option.
> Looks like this bug is a closed one, can it be open?
I think it can be open but it won't be
> As per the bug comments, these tests fail too often on macOS arm.
> This will be too noisy for CI. So I would like to problem list them for
> mac-arm
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8272123: Problem lis
As per the bug comments, these tests fail too often on macOS arm.
This will be too noisy for CI. So I would like to problem list them for mac-arm
-
Commit messages:
- 8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64
Changes:
On Wed, 21 Jul 2021 07:19:02 GMT, Sergey Bylokhov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8268824: Remove unused jdk.accessibility APIs deprecated for removal in
>> JDK 9
&
asses : just those
> implementing ATs
>
>
> The CSR for this is https://bugs.openjdk.java.net/browse/JDK-8270918
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8268824: Remove unused jdk.accessibility APIs deprecated for removal in
On Fri, 16 Jul 2021 20:52:08 GMT, Weijun Wang wrote:
> This is the last part of Post JEP 411 refactoring that makes
> `@SuppressWarnings("removal")` more fine grained. This fix deals with all
> client libs annotations that cover more than 10K bytes of code.
On Fri, 16 Jul 2021 21:39:56 GMT, Vest
wrote:
>> This is the last part of Post JEP 411 refactoring that makes
>> `@SuppressWarnings("removal")` more fine grained. This fix deals with all
>> client libs annotations that cover more than 10K bytes of code.
>
>
On Wed, 30 Jun 2021 14:58:28 GMT, Alexander Zuev wrote:
>> 8268775: Password is being converted to String in AccessibleJPasswordField
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use getDocumnt().getLength() instead
On Wed, 30 Jun 2021 19:19:24 GMT, Alexander Zuev wrote:
>>> No, the native code will fail to load the icon
>> So what call will fail? Is the "sf.getIcon()" return null? in what line of
>> code?
>
> Yes, from my remote debugging it happens in sf.getIcon() but the
> circumstances are quite rare
On Wed, 23 Jun 2021 19:31:15 GMT, Alexander Zuev wrote:
>> src/java.desktop/share/classes/javax/swing/JPasswordField.java line 546:
>>
>>> 544: public String getAfterIndex(int part, int index) {
>>> 545: if (part == AccessibleText.CHARACTER) {
>>> 546: return
On Wed, 23 Jun 2021 17:20:27 GMT, Alexander Zuev wrote:
> 8268775: Password is being converted to String in AccessibleJPasswordField
src/java.desktop/share/classes/javax/swing/JPasswordField.java line 634:
> 632: Arrays.fill(password, getEchoChar());
> 633:
On Wed, 23 Jun 2021 17:20:27 GMT, Alexander Zuev wrote:
> 8268775: Password is being converted to String in AccessibleJPasswordField
There's code but not a single word of description of the fix.
What is the problem, what are the changes here, why do they fix it, and what
are the risks /
On Thu, 3 Jun 2021 21:31:20 GMT, Sergey Bylokhov wrote:
>> Some useful documentation was added to the JPasswordField.
>
> Sergey Bylokhov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update JPasswordField.java
Marked as reviewed by prr
On Wed, 2 Jun 2021 13:08:08 GMT, Alexander Zvegintsev
wrote:
>> Some useful documentation was added to the JPasswordField.
>
> src/java.desktop/share/classes/javax/swing/JPasswordField.java line 68:
>
>> 66: * handling confidential information such as the password text, refer to
>> the
>>
On Wed, 2 Jun 2021 01:14:39 GMT, Sergey Bylokhov wrote:
> Some useful documentation was added to the JPasswordField.
> _Mailing list message from [Alan Snyder](mailto:javali...@cbfiddle.com) on
> [swing-dev](mailto:swing-...@mail.openjdk.java.net):_
>
> I think this statement is
On Thu, 3 Jun 2021 01:23:25 GMT, Sergey Bylokhov wrote:
>> I do not like the phrase "Although the text displayed in", the "text" is not
>> displayed in the JPasswordField per se, please suggest something else.
>
> "The text entered in {@code JPasswordField} displays that something was typed
>
On Thu, 3 Jun 2021 00:46:04 GMT, Phil Race wrote:
>> The previous text you refer to is presumably
>> "where the view indicates something was typed,"
>>
>> that is fine. Your text is trying to say something else AND you added the
>> word that which means
On Thu, 3 Jun 2021 00:45:40 GMT, Phil Race wrote:
>> The "something was typed" text is used already in the description of the
>> JPasswordField, in the first sentence.
>>
>> Not sure that the word "text" in the "Although the text displayed&quo
On Thu, 3 Jun 2021 00:31:22 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/share/classes/javax/swing/JPasswordField.java line 64:
>>
>>> 62: *
>>> 63: * Warning: The text entered in {@code JPasswordField}
>>> displays
>>> 64: * something that was typed and does not show the original
On Wed, 2 Jun 2021 01:14:39 GMT, Sergey Bylokhov wrote:
> Some useful documentation was added to the JPasswordField.
src/java.desktop/share/classes/javax/swing/JPasswordField.java line 64:
> 62: *
> 63: * Warning: The text entered in {@code JPasswordField}
> displays
> 64: * something
On Fri, 21 May 2021 20:37:30 GMT, Weijun Wang wrote:
>> The code change refactors classes that have a `SuppressWarnings("removal")`
>> annotation that covers more than 50KB of code. The big annotation is often
>> quite faraway from the actual deprecated API usage it is suppressing, and
>>
On Fri, 28 May 2021 02:50:55 GMT, Weijun Wang wrote:
>> src/java.desktop/share/classes/java/awt/Component.java line 630:
>>
>>> 628: }
>>> 629:
>>> 630: @SuppressWarnings("removal")
>>
>> I'm confused. I thought the reason this wasn't done in the JEP
>> implementation PR is
On Fri, 21 May 2021 20:37:30 GMT, Weijun Wang wrote:
>> The code change refactors classes that have a `SuppressWarnings("removal")`
>> annotation that covers more than 50KB of code. The big annotation is often
>> quite faraway from the actual deprecated API usage it is suppressing, and
>>
On Mon, 24 May 2021 13:53:34 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>>
On Wed, 26 May 2021 16:52:38 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Fixed small errors
>Adjustments in the test
> - Grammar fix in
On Wed, 26 May 2021 21:37:44 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JFileChooser/FileSystemView/SystemIconTest.java line 77:
>>
>>> 75: int[] sizes = new int[] {16, 32, 48, 64, 128};
>>> 76: for (int size : sizes) {
>>> 77: ImageIcon icon = (ImageIcon)
On Wed, 26 May 2021 15:15:42 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> null file now properly causes IllegalArgumentException
>> Small fixed in JavaDoc
>
>
On Tue, 25 May 2021 23:36:43 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> null file now properly causes IllegalArgumentException
> Small fixed
On Tue, 25 May 2021 22:01:36 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Changed API to support non-square icons and updated documentation
>
On Fri, 21 May 2021 21:41:44 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Chenged implementation specification based on CSR review
> > if the
On Thu, 20 May 2021 22:25:05 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Specification of getSystemIcon reworded to get rid of the non-public
>
On Wed, 19 May 2021 13:47:53 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>>
On Thu, 20 May 2021 22:25:05 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Specification of getSystemIcon reworded to get rid of the non-public
>
On Tue, 18 May 2021 21:44:43 GMT, Weijun Wang wrote:
>> Please review the test changes for [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> With JEP 411 and the default value of `-Djava.security.manager` becoming
>> `disallow`, tests calling `System.setSecurityManager()` need
>>
On Thu, 20 May 2021 07:06:00 GMT, Alan Bateman wrote:
>> The JEP isn't PTT for 17 so there's plenty of time isn't there ?
>
> There are 827 files in this patch. Phil is right that adding SW at the class
> level is introducing technical debt but if addressing that requires
> refactoring and
On Thu, 20 May 2021 19:22:50 GMT, Alexander Zuev wrote:
>> But it is still part of the specification unlike implnote/apinote, and we
>> cannot use non-public classes there, since other JavaSE implementations may
>> not have this class. see discussion on the link above.
>
>> But it is still
On Thu, 20 May 2021 04:05:23 GMT, Phil Race wrote:
>> By converting JDK-8267432 to a bug, there is an extra benefit that we can
>> fix it after RDP. So I'll convert it now.
>
> That is unfortunate, but nonetheless I think required to be done.
> We have acknowledeged
On Thu, 20 May 2021 02:09:57 GMT, Weijun Wang wrote:
>> I can make it a bug.
>>
>> I don't want to do it here is because it involves indefinite amount of
>> manual work and we will see everyone having their preferences. The more time
>> we spend on this PR the more likely there will be merge
On Wed, 19 May 2021 22:14:20 GMT, Weijun Wang wrote:
>> I don't think it is a separate P4 enhancement (?) that someone will (maybe)
>> do next release.
>> I think it should all be taken care of as part of this proposed change.
>
> I just made it P3 (P4 was the default value), and I will target
On Wed, 19 May 2021 21:53:35 GMT, Weijun Wang wrote:
>> That's a sad limitation of the annotation stuff then, but I don't think that
>> it is insurmountable.
>> You can define a static private method to contain this and call it from the
>> static initializer block.
>> Much better than applying
On Wed, 19 May 2021 18:38:39 GMT, Weijun Wang wrote:
>> src/java.desktop/share/classes/java/awt/Component.java line 217:
>>
>>> 215: * @author Sami Shaio
>>> 216: */
>>> 217: @SuppressWarnings("removal")
>>
>> Why is this placed on the *entire class* ??
>> This class is 10535 lines long
On Wed, 19 May 2021 13:47:53 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>>
On Wed, 19 May 2021 13:47:53 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>>
On Wed, 19 May 2021 13:47:53 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>>
On Wed, 21 Apr 2021 11:23:02 GMT, Prasanta Sadhukhan
wrote:
>> This test was marked as unstable in CI run in samevm mode but later on was
>> found passing in now-default othervm mode but was problemlisted only on
>> macos by JDK-8254976.
>> It is found that this test started failing in macos
On Wed, 21 Apr 2021 11:23:02 GMT, Prasanta Sadhukhan
wrote:
>> This test was marked as unstable in CI run in samevm mode but later on was
>> found passing in now-default othervm mode but was problemlisted only on
>> macos by JDK-8254976.
>> It is found that this test started failing in macos
On Wed, 21 Apr 2021 05:09:48 GMT, Prasanta Sadhukhan
wrote:
>> So on macOS 11 we enter this block since isMacOSX14 is false and the test
>> passes ?
>
> No, it still fails in macosx11 without this modification. macos11, System
> .getProperty returns 10.16 so it satisfies this macosx >=10.14
On Wed, 21 Apr 2021 03:55:50 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/javax/swing/UIDefaults/6302464/bug6302464.java line 138:
>>
>>> 136: }
>>> 137: if (!isMacOSX14) {
>>> 138: HashSet colorsAAOff =
>>> getAntialiasedColors(VALUE_TEXT_ANTIALIAS_OFF, 100);
>>
>>
On Fri, 16 Apr 2021 06:53:21 GMT, Prasanta Sadhukhan
wrote:
> This test was marked as unstable in CI run in samevm mode but later on was
> found passing in now-default othervm mode but was problemlisted only on macos
> by JDK-8254976.
> It is found that this test started failing in macos due
On Thu, 1 Apr 2021 23:33:28 GMT, Phil Race wrote:
>> Tejpal Rebari has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight addi
On Thu, 4 Mar 2021 05:50:18 GMT, Tejpal Rebari wrote:
>> Please review the following fix for jdk17.
>> In this fix i have deprecated and marked for removal following classes and
>> methods
>>public void intervalAdded(ListDataEvent e)
>>public void intervalRemoved(ListDataEvent e)
>>
On Thu, 25 Mar 2021 22:58:53 GMT, Andy Herrick wrote:
>> implementation of
>> JDK-8256145: JEP 398: Deprecate the Applet API for Removal
>
> Andy Herrick has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
>
On Wed, 24 Mar 2021 04:22:56 GMT, Prasanta Sadhukhan
wrote:
>> It's unclear from the spec that the original implementation of the method
>> JComponent.updateUI() does nothing which needs to be explicitly stated in
>> the javadoc.
>
> Prasanta Sadhukhan has updated the pull request
On Sun, 7 Mar 2021 03:18:53 GMT, Yasumasa Suenaga wrote:
> I saw C4530 with VS 2019 (16.9.0) as following (on Japanese locale):
>
> AccessBridgeDebug.cpp
> メモ: インクルード ファイル:
> d:\github-forked\jdk\src\jdk.accessibility\windows\native\common\AccessBridgeDebug.h
>
> :
>
>
On Fri, 26 Feb 2021 20:21:21 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/unix/classes/sun/print/UnixPrintJob.java line 601:
>>
>>> 599: try (BufferedInputStream bin = new
>>> BufferedInputStream(instream);
>>> 600: BufferedOutputStream bout = new
>>>
On Mon, 21 Dec 2020 07:54:17 GMT, Andrey Turbanov
wrote:
> Cleanup code to use new handy methods in
> `java.io.InputStream`/`java.nio.file.Files` instead of manual stream copy:
> 1. java.io.InputStream#readAllBytes
> 2. java.io.InputStream#transferTo
> 3. java.nio.file.Files#copy
>
> Similar
On Mon, 21 Dec 2020 07:54:17 GMT, Andrey Turbanov
wrote:
> Cleanup code to use new handy methods in
> `java.io.InputStream`/`java.nio.file.Files` instead of manual stream copy:
> 1. java.io.InputStream#readAllBytes
> 2. java.io.InputStream#transferTo
> 3. java.nio.file.Files#copy
>
> Similar
On Tue, 9 Feb 2021 07:27:00 GMT, Tejpal Rebari wrote:
>> Please review the following fix for jdk17.
>> In this fix i have deprecated and marked for removal following classes and
>> methods
>>public void intervalAdded(ListDataEvent e)
>>public void intervalRemoved(ListDataEvent e)
>>
On Fri, 15 Jan 2021 07:59:24 GMT, K Suman Rajkumaar
wrote:
> Dear All,
>
> Hi All, Could you please review this fix for JDK17?
>
> Problem Description: The test
> open/test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java is applet based.
>
> Fix: Rewritten the above applet based test as a
On Fri, 5 Feb 2021 01:27:26 GMT, Phil Race wrote:
> we need to specify ()I for the signature of the method that returns int.
> Additionally number (the instance!) needs to be passed to the method up call.
This pull request has now been integrated.
Changeset: 4a89733e
Author: Phil Rac
On Mon, 18 Jan 2021 16:08:37 GMT, Phil Race wrote:
> This removes desktop module usage of the JNF JNI reference convenience APIs
> These are simply a direct conversion
> JNFNewGlobalRef
> JNFDeleteGlobalRef
> JNFNewWeakGlobalRef
> JNFDeleteWeakGlobalRef
>
> These
gt; All our automated regression and JCK tests pass with this change.
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
-
Changes:
- all: https://git.
On Wed, 20 Jan 2021 06:02:55 GMT, Sergey Bylokhov wrote:
>> This removes desktop module usage of the JNF JNI reference convenience APIs
>> These are simply a direct conversion
>> JNFNewGlobalRef
>> JNFDeleteGlobalRef
>> JNFNewWeakGlobalRef
>> JNFDeleteWeakGlobalRef
>>
>> These two
>>
On Wed, 6 Jan 2021 16:25:16 GMT, K Suman Rajkumaar
wrote:
>> Hi All, Could you please review this fix for JDK16?
>>
>> Problem Description: The test
>> open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java is applet based.
>>
>> Fix: Rewritten the above applet based test to a regular
On Wed, 6 Jan 2021 19:52:35 GMT, Alexey Ivanov wrote:
>> K Suman Rajkumaar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed the setSize()
>
> Marked as reviewed by aivanov (Reviewer).
"Hi All, Could you please review this fix
On Sun, 20 Dec 2020 01:37:47 GMT, Phil Race wrote:
> The fix is to reverse the order of acquisition to get dst before src so that
> the call to GetArrayLength() comes first.
> This also necessitates moving the RELEASE_ARRAYS() call on an error condition
> to the new "2nd&quo
On Thu, 24 Dec 2020 18:36:12 GMT, Prasanta Sadhukhan
wrote:
>> Please review a fix for jdk16.
>> On macOS 11 (bigsur), using the Swing Aqua Look and Feel, the text of the
>> selected JTabbedPane tab title text is just a light gray outline of white
>> text on a white background. The macOS 11
On Wed, 23 Dec 2020 10:41:04 GMT, Prasanta Sadhukhan
wrote:
> Please review a fix for jdk16.
> On macOS 11 (bigsur), using the Swing Aqua Look and Feel, the text of the
> selected JTabbedPane tab title text is just a light gray outline of white
> text on a white background. The macOS 11
On Wed, 23 Dec 2020 10:41:04 GMT, Prasanta Sadhukhan
wrote:
> Please review a fix for jdk16.
> On macOS 11 (bigsur), using the Swing Aqua Look and Feel, the text of the
> selected JTabbedPane tab title text is just a light gray outline of white
> text on a white background. The macOS 11
On Wed, 23 Dec 2020 22:21:04 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList javax/swing/JComboBox/6559152/bug6559152.java on
> Linux-X64.
Marked as reviewed by prr (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1885
On Tue, 22 Dec 2020 19:39:57 GMT, Andrey Turbanov
wrote:
> I checked JDK16 repository in SpotBugs 4.2.0
> 
> I fixed only places in java.desktop module.
> I didn't fixed places,
On Sun, 20 Dec 2020 20:22:48 GMT, Andrey Turbanov
wrote:
>> jrtfs is compiled twice, the second is to --release 8 so it can be packaged
>> into jrt-fs.jar for use by IDEs/tools running on older JDK releases. So need
>> to be careful with the changes here as it will likely causing build
The fix is to reverse the order of acquisition to get dst before src so that
the call to GetArrayLength() comes first.
This also necessitates moving the RELEASE_ARRAYS() call on an error condition
to the new "2nd" block.
The new regression test passes on all platforms and all the other headless
On Fri, 18 Dec 2020 22:41:18 GMT, Sergey Bylokhov wrote:
>> So why would this API return the wrong colour ?
>> Sounds like we need to re-cap the alternatives and the pros and cons along
>> with some explanation
>> And do it before opening the 16 PR.
>
>> So why would this API return the wrong
On Fri, 18 Dec 2020 22:14:48 GMT, Sergey Bylokhov wrote:
>>>It does not cached it is a mutable SystemColor which is updated on the color
>>>theme switch,
>>> it works in a similar way as text selection color which might be configured
>>> in the macOS settings.
>>
>> Looked in the code as if
On Fri, 18 Dec 2020 21:38:59 GMT, Sergey Bylokhov wrote:
>It does not cached it is a mutable SystemColor which is updated on the color
>theme switch,
> it works in a similar way as text selection color which might be configured
> in the macOS settings.
Looked in the code as if it was cached
On Thu, 17 Dec 2020 13:02:12 GMT, Kevin Rushforth wrote:
>> @prrace Did you approve the 1st version of the fix
>> [https://openjdk.github.io/cr/?repo=jdk=1182=00]
>> or the current (4th) version?
>> If 1st, is there any way to integrate the 1st version without updating the
>> PR?
>
>> If
On Wed, 16 Dec 2020 20:35:04 GMT, Sergey Bylokhov wrote:
> - The JTextComponent.setText() is overidden in the JPasswordField to make the
> "text" property non-"bound" in the JPasswordField, same as in the
> JTextComponent
> - The new implementation of setText() clean an internal data storage
On Wed, 16 Dec 2020 19:37:23 GMT, Anton Litvinov wrote:
> Hello,
>
> This is a review request for straight back port of the fix for the bug
> JDK-8255880 from JDK 17 to JDK 16, which is currently in RDP 1 phase. The fix
> was tested and the regression test was executed on MS Windows OS, Linux
On Tue, 15 Dec 2020 15:24:03 GMT, Andrey Turbanov
wrote:
>> There are few places in code where manual `while` loop is used with
>> `Iterator` to iterate over `Collection`.
>> Instead of manual `while` cycles it's preferred to use _enhanced-for_ cycle
>> instead: it's less verbose, makes code
On Tue, 15 Dec 2020 17:14:11 GMT, Andrey Turbanov
wrote:
>>> I've added few words in description.
>>>
>>> About testing: as I can see testing is done via Github Actions. tier1
>>> builds are ok.
>>
>> OK that's better But about testing. The github actions won't run a single
>> test that
On Mon, 14 Dec 2020 04:55:02 GMT, Prasanta Sadhukhan
wrote:
> The forumpost is here https://discussions.apple.com/thread/252067605
> The hardcoded being referred was in this 1st iteration of the fix
> https://openjdk.github.io/cr/?repo=jdk=1182=00
OK. So I guess this could work for either
On Thu, 19 Nov 2020 03:37:16 GMT, Prasanta Sadhukhan
wrote:
>> On macOS 11 (bigsur) beta, using the Swing Aqua Look and Feel, the text of
>> the selected JTabbedPane tab title text is just a light gray outline of
>> white text on a white background. The macOS 11 design inverted from dark
>>
On Tue, 15 Dec 2020 09:46:49 GMT, Prasanta Sadhukhan
wrote:
> Test was failing if JComboBox tests was run in group in nightly mach5 testing.
> Modified test to move frame to centre of screen, add delays before frame
> show. Also updated the test that ran just before this test move frame to
>
On Mon, 14 Dec 2020 19:48:36 GMT, Andrey Turbanov
wrote:
> I've added few words in description.
>
> About testing: as I can see testing is done via Github Actions. tier1 builds
> are ok.
OK that's better But about testing. The github actions won't run a single test
that touches any code
1 - 100 of 433 matches
Mail list logo
