RFR JDK-8250849: Address reliance on default constructors in the javax.swing.plaf APIs

2020-08-12 Thread Prasanta Sadhukhan
Hi All, Please review a fix for issue where it was seen that several classes rely on default constructors as part of their public API. It's to be noted that "A no-arg public constructor is generated by the compiler for a class if it does not declare an explicit constructor. While

Re: RFR: 8247753: UIManager.getSytemLookAndFeelClassName() returns wrong value on Fedora 32

2020-08-06 Thread Prasanta Sadhukhan
nv("XDG_CURRENT_DESKTOP")); +    return (desktop != null && desktop.toLowerCase().contains(gnome)) +   ? gnome : null; + } -phil. On 8/4/20, 10:16 PM, Prasanta Sadhukhan wrote: Looks ok to me. One observation is, in testcase you can remove line71 linux c

Re: RFR JDK-8250811: Address reliance on default constructors in the javax.swing.plaf.multi APIs

2020-08-06 Thread Prasanta Sadhukhan
of the fields and before the methods. BTW I am not sure about the "one line" "{}" type of brackets, do we use it somewhere? For example in some classes like a java.awt.Canvas uses brackets on different lines. On 31.07.2020 07:20, Prasanta Sadhukhan wrote: Hi All, Please review a

RFR 8249838: javax.swing.JLayeredPane has used valueOf twice in example code in documentation

2020-08-05 Thread Prasanta Sadhukhan
Hi All, Please review a doc fix where details section of JLayeredPane has used valueOf twice as a typo Bug: https://bugs.openjdk.java.net/browse/JDK-8249838 hg diff src/java.desktop/share/classes/javax/swing/JLayeredPane.java diff -r cda47533b1ee

RFR JDK-8251187: Mark BasicComboNPE regression test as headful

2020-08-05 Thread Prasanta Sadhukhan
Hi All, Please review a test-fix for an issue seen failing in mach5 due to test throwing HeadlessException. Test needs to be marked as headful and also setPopupVisible(false) is used as setPopupVisible(true) gives StackOverflowError in macOS, which will be investigated separately.

Re: RFR: 8247753: UIManager.getSytemLookAndFeelClassName() returns wrong value on Fedora 32

2020-08-04 Thread Prasanta Sadhukhan
Looks ok to me. One observation is, in testcase you can remove line71 linux check as we already did the check in l54. Regards Prasanta On 04-Aug-20 11:12 PM, Pankaj Bansal wrote: Hi All, Please review the following fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8247753

Re: RFR JDK-8250811: Address reliance on default constructors in the javax.swing.plaf.multi APIs

2020-08-04 Thread Prasanta Sadhukhan
I guess since it is mentioned in the coding guidelines, we should follow that. We should try changing the event package and others, if time permits to match coding guidelines. But having said that, I am open to follow whatever you leads decide. Regards Prasanta On 05-Aug-20 8:17 AM, Sergey

Re: RFR JDK-6709913: BasicComboBoxUI.isPopupVisible returns NullPointerException

2020-08-04 Thread Prasanta Sadhukhan
20 23:18, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue whereby javax.swing.plaf.basic.BasicComboBoxUI.isPopupVisible returns NullPointerException when called from a overridden method of getModel(). If a class extends JComboBox and overrides getModel() and then it calls isPopu

Re: RFR JDK-8250811: Address reliance on default constructors in the javax.swing.plaf.multi APIs

2020-08-04 Thread Prasanta Sadhukhan
anta On 31.07.2020 07:20, Prasanta Sadhukhan wrote: Hi All, Please review a fix for issue where it was seen that several classes rely on default constructors as part of their public API. It's to be noted that "A no-arg public constructor is generated by the compiler for a class if it doe

RFR JDK-8250811: Address reliance on default constructors in the javax.swing.plaf.multi APIs

2020-07-31 Thread Prasanta Sadhukhan
Hi All, Please review a fix for issue where it was seen that several classes rely on default constructors as part of their public API. It's to be noted that "A no-arg public constructor is generated by the compiler for a class if it does not declare an explicit constructor. While

Re: RFR: 8233635: [TESTBUG] ProgressMonitorEscapeKeyPress.java fails on macos

2020-07-31 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 31-Jul-20 11:37 AM, Pankaj Bansal wrote: Hello Prasanta, I have ran this test on mach5 on MacOS 10.15. It is passing always. Link in the JBS. Please have a look. Regards, Pankaj On 21/05/20 1:01 PM, Prasanta Sadhukhan wrote: Hi Pankaj, It seems this issue

Re: RFR JDK-8250639: Address reliance on default constructors in the javax.swing.plaf.multi module

2020-07-30 Thread Prasanta Sadhukhan
Sadhukhan wrote: Kevin mentioned even if fx they are breaking it up and tackling these issue. Regards Prasanta On 30-Jul-20 9:27 PM, Prasanta Sadhukhan wrote: it will be easier for me to break up in parts if I have to do all of it. Regards Prasanta On 30-Jul-20 9:26 PM, Joe Darcy wrote: If you

Re: RFR JDK-8250639: Address reliance on default constructors in the javax.swing.plaf.multi module

2020-07-30 Thread Prasanta Sadhukhan
Kevin mentioned even if fx they are breaking it up and tackling these issue. Regards Prasanta On 30-Jul-20 9:27 PM, Prasanta Sadhukhan wrote: it will be easier for me to break up in parts if I have to do all of it. Regards Prasanta On 30-Jul-20 9:26 PM, Joe Darcy wrote: If you want to make

Re: RFR JDK-8250639: Address reliance on default constructors in the javax.swing.plaf.multi module

2020-07-30 Thread Prasanta Sadhukhan
it will be easier for me to break up in parts if I have to do all of it. Regards Prasanta On 30-Jul-20 9:26 PM, Joe Darcy wrote: If you want to make the changes all in one go, I can accommodate that too. Thanks, -Joe On 7/30/2020 8:34 AM, Prasanta Sadhukhan wrote: I had talked with Joe

Re: RFR JDK-8250811: Address reliance on default constructors in the javax.swing.plaf.multi module

2020-07-30 Thread Prasanta Sadhukhan
Ok. The bugid should read https://bugs.openjdk.java.net/browse/JDK-8250811 On 30-Jul-20 9:04 PM, Prasanta Sadhukhan wrote: I had talked with Joe and it was decided to break up in parts as it will be easy for him. Regards PRasanta On 30-Jul-20 9:02 PM, Sergey Bylokhov wrote: On 30.07.2020

Re: RFR JDK-8250639: Address reliance on default constructors in the javax.swing.plaf.multi module

2020-07-30 Thread Prasanta Sadhukhan
I had talked with Joe and it was decided to break up in parts as it will be easy for him. Regards PRasanta On 30-Jul-20 9:02 PM, Sergey Bylokhov wrote: On 30.07.2020 01:24, Prasanta Sadhukhan wrote: Proposed fix is to create no-arg default constructor for javax.swing.plaf.multi module

RFR JDK-8250639: Address reliance on default constructors in the javax.swing.plaf.multi module

2020-07-30 Thread Prasanta Sadhukhan
Hi All, Please review a fix for issue where it was seen that several classes rely on default constructors as part of their public API. It's to be noted that "A no-arg public constructor is generated by the compiler for a class if it does not declare an explicit constructor. While

RFR JDK-6709913: BasicComboBoxUI.isPopupVisible returns NullPointerException

2020-07-30 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue whereby javax.swing.plaf.basic.BasicComboBoxUI.isPopupVisible returns NullPointerException when called from a overridden method of getModel(). If a class extends JComboBox and overrides getModel() and then it calls isPopupVisible() from the overriden

Re: RFR: 8249674: Redo: Nimbus JTree renderer properties persist across L changes

2020-07-29 Thread Prasanta Sadhukhan
On 29-Jul-20 1:25 PM, Tejpal Rebari wrote: Hi Prasanta, On 27-Jul-2020, at 2:21 PM, Prasanta Sadhukhan <mailto:prasanta.sadhuk...@oracle.com>> wrote: Fix looks ok to me. But I think the test is more appropriate if it is placed in javax/swing/plaf/nimbus directory. Also, the

Re: RFR JDK-8146451: javax/swing/JComponent/4337267/bug4337267.java failed on Windows

2020-07-28 Thread Prasanta Sadhukhan
can drop "doneTask()" and all related things used to wait while invokeLater is completed? On 19.07.2020 05:13, Prasanta Sadhukhan wrote: Hi All, Please review a test-fix for an issue seen to be failing in windows in mach5 with mismatch in bufferedimage. It seems the test is run asyn

Re: RFR JDK-8146451: javax/swing/JComponent/4337267/bug4337267.java failed on Windows

2020-07-27 Thread Prasanta Sadhukhan
ping? any reviewers? On 19-Jul-20 5:43 PM, Prasanta Sadhukhan wrote: Hi All, Please review a test-fix for an issue seen to be failing in windows in mach5 with mismatch in bufferedimage. It seems the test is run asynchronously in test.run() under SwingUtilities.invokeLater which is causing

Re: RFR JDK-8169959: javax/swing/JTable/6263446/bug6263446.java: Table should be editing

2020-07-27 Thread Prasanta Sadhukhan
ping? any reviewers? On 18-Jul-20 6:14 PM, Prasanta Sadhukhan wrote: HI All, Please review a test fix for an issue where this test fails with message ""java.lang.RuntimeException: Table should be editing” in mach5  It seems it will fail with that message when the robot m

Re: RFR: 8249674: Redo: Nimbus JTree renderer properties persist across L changes

2020-07-27 Thread Prasanta Sadhukhan
Fix looks ok to me. But I think the test is more appropriate if it is placed in javax/swing/plaf/nimbus directory. Also, the test can be enhanced a bit to not fail at the first attempt as we are testing 8 different properties, so I think it will be good if you will store the results in a

Re: RFR JDK-7184956: [macosx] JPopupMenu.setDefaultLightPopupEnable(true) doesn't work correctly

2020-07-27 Thread Prasanta Sadhukhan
On 24-Jul-20 4:45 AM, Sergey Bylokhov wrote: Hi, Prasanta. This is because com.apple.laf.ScreenPopupFactory#getPopup method always sets HEAVY_WEIGHT_POPUP when com.apple.laf.ScreenPopupFactory#fIsActive is true and fIsActive is always set to true in AquaLookAndFeel#initialize()>> Proposed

RFR JDK-7184956: [macosx] JPopupMenu.setDefaultLightPopupEnable(true) doesn't work correctly

2020-07-23 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue in macos where regression test javax/swing/JPopupMenu/6800513/bug6800513.java fails with java.lang.Exception: popup class is: javax.swing.PopupFactory$HeavyWeightPopup, expected: javax.swing.PopupFactory$LightWeightPopup This is because

Re: RFR JDK-8232927:ToolTipManager is unable to force heavy weight popups

2020-07-23 Thread Prasanta Sadhukhan
On 23-Jul-20 11:55 AM, Sergey Bylokhov wrote: On 22.07.2020 22:46, Prasanta Sadhukhan wrote: Hi Sergey, Not exactly, that is support of heavyweight popup in PopupFactory class. This is in Tooltipmanager which can utilise PopupFactory Heavyweight enhancement but there's no way to create HW

Re: RFR JDK-8232927:ToolTipManager is unable to force heavy weight popups

2020-07-22 Thread Prasanta Sadhukhan
-8147521 ? On 22.07.2020 00:44, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue whereby Java developer is not able to to force the tooltips to be displayed in a heavyweight popup. In ToolTipManager#showTipWindow() , even if we do "ToolTipManager.setLightWeightPopupEn

Re: RFR JDK-8232927:ToolTipManager is unable to force heavy weight popups

2020-07-22 Thread Prasanta Sadhukhan
? On 22.07.2020 00:44, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue whereby Java developer is not able to to force the tooltips to be displayed in a heavyweight popup. In ToolTipManager#showTipWindow() , even if we do "ToolTipManager.setLightWeightPopupEnabled(false)" w

RFR JDK-8232927:ToolTipManager is unable to force heavy weight popups

2020-07-22 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue whereby Java developer is not able to to force the tooltips to be displayed in a heavyweight popup. In ToolTipManager#showTipWindow() , even if we do "ToolTipManager.setLightWeightPopupEnabled(false)" we can only force a medium weight popup as can be

RFR JDK-8146451: javax/swing/JComponent/4337267/bug4337267.java failed on Windows

2020-07-19 Thread Prasanta Sadhukhan
Hi All, Please review a test-fix for an issue seen to be failing in windows in mach5 with mismatch in bufferedimage. It seems the test is run asynchronously in test.run() under SwingUtilities.invokeLater which is causing the test to be unstable in mach5. Also, the actual BufferedImage

RFR JDK-8169959: javax/swing/JTable/6263446/bug6263446.java: Table should be editing

2020-07-18 Thread Prasanta Sadhukhan
HI All, Please review a test fix for an issue where this test fails with message ""java.lang.RuntimeException: Table should be editing” in mach5 It seems it will fail with that message when the robot mouse event are executed without frame being visible on which the events are to be executed.

Re: RFR JDK-8245785: javax.swing.JTabbedPane cannot be deserialized

2020-07-15 Thread Prasanta Sadhukhan
On 14-Jul-20 7:41 PM, Prasanta Sadhukhan wrote: On 13-Jul-20 8:07 PM, Philip Race wrote: The regression test needs some clean up. It seems to be a copy+paste of the submitter's test case including the comment in German which can be removed. Also IMO all the English comments are stating

RFR JDK-8042055: Nimbus DerivedColor incorrectly clamps hue

2020-07-15 Thread Prasanta Sadhukhan
Hi All, Please review a fix for a nimbus issue where it is seen that "hue" color in Nimbus.DerivedColor.rederiveColor is being incorrectly clamped. rederiveColor() calls Color.HSBtoRGB() to get the RGB color from Hue/Saturation/Brightness color and as per HSBtoRGB spec

RFR JDK-8210850: There is a Java icon instead of a i icon on mac

2020-07-15 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue where it is seen JOptionPane showInputDialog and showConfirmationDialog in SwingSet2 "OptionPane Demo" dialog is being shown as a "Java" icon instead of "i" icon for AquaLookAndFeel in mac. Other L show "i" icon. Issue is because in Aqua L,

Re: RFR JDK-8245785: javax.swing.JTabbedPane cannot be deserialized

2020-07-14 Thread Prasanta Sadhukhan
ByteArray based streams not File streams. OK. Modified webrev http://cr.openjdk.java.net/~psadhukhan/8245785/webrev.3/ Regards Prasanta There are fewer clean up issues if you do that. -phil. On 7/13/20, 7:10 AM, Prasanta Sadhukhan wrote: On 13-Jul-20 11:30 AM, Sergey Bylokhov wrote

Re: RFR JDK-8245785: javax.swing.JTabbedPane cannot be deserialized

2020-07-13 Thread Prasanta Sadhukhan
On 13-Jul-20 11:30 AM, Sergey Bylokhov wrote: On 11.07.2020 23:05, Prasanta Sadhukhan wrote: It's just a null check so I guess we can keep getTabCount() check in-place. Also, there are no other fields is missing which is required. But as far as I understand this check is not needed

Re: RFR: 8041701 Nimbus JTree renderer properties persist across L changes

2020-07-12 Thread Prasanta Sadhukhan
+1 On 11-Jul-20 3:10 PM, Tejpal Rebari wrote: Hi Sergey, Thanks for the review. On 11-Jul-2020, at 11:41 AM, Sergey Bylokhov mailto:sergey.bylok...@oracle.com>> wrote: Hi, Tejpal. The fix looks fine, could you please update the test to check that all installed L work the same way. I have

Re: RFR JDK-8245785: javax.swing.JTabbedPane cannot be deserialized

2020-07-12 Thread Prasanta Sadhukhan
On 11-Jul-20 11:45 AM, Sergey Bylokhov wrote: On 09.07.2020 06:26, Prasanta Sadhukhan wrote: Hi Sergey, It seems "pages" object is not instantiated as readObject() did not read the object. I have modified the code to read the "pages" object after deserialization a

Re: RFR JDK-8245785: javax.swing.JTabbedPane cannot be deserialized

2020-07-09 Thread Prasanta Sadhukhan
serialization, will all pages be serialized/deserialized in this case? On 09.07.2020 01:14, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where deserializing a serialized JTabbedPane-object results in NullPointerException. The NPE is result of tabbed "pages&q

RFR JDK-8239907: Vertical White Line appears with JOptionPane.showMessageDialog using a JTextPane/JEditorPane

2020-07-09 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue where a white line artifact is appearing in JOptionPane.showMessageDialog, This issue is a regression of JDK-8098835 where the caretMargin is added to TextPane width in getMaximumSize/getMinimumSize/getVisibleEditorRect The present issue stems from

RFR JDK-8245785: javax.swing.JTabbedPane cannot be deserialized

2020-07-09 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue where deserializing a serialized JTabbedPane-object results in NullPointerException. The NPE is result of tabbed "pages" object not being instantiated when deserialized. Proposed fix is to add a null check for "pages" object. Bug:

Re: RFR: 8041705 Bugs in DefaultTreeCellRenderer.updateUI()

2020-07-08 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 07-Jul-20 10:53 AM, Tejpal Rebari wrote: On 02-Jul-2020, at 2:44 PM, Tejpal Rebari > wrote: Hi Pankaj, Thanks for the review. On 02-Jul-2020, at 2:05 PM, Pankaj Bansal mailto:pankaj.b.ban...@oracle.com>> wrote: Hello Tejpal, Few

Re: RFR: 8197560: test javax/swing/JTree/8003400/Test8003400.java fails

2020-06-30 Thread Prasanta Sadhukhan
. webrev: http://cr.openjdk.java.net/~pbansal/8197560/webrev01/ <http://cr.openjdk.java.net/%7Epbansal/8197560/webrev01/> Regards, Pankaj On 26/06/20 9:39 PM, Sergey Bylokhov wrote: On 6/25/20 9:27 pm, Prasanta Sadhukhan wrote: sting only in windows, then probably we need to move the

Re: RFR: 8041705 Bugs in DefaultTreeCellRenderer.updateUI()

2020-06-28 Thread Prasanta Sadhukhan
Fix looks ok but I think the test should actually set "Tree.rendererMargins" value for NimbusL and check insets for other L is not same as nimbus when "Tree.rendererMargins" is reset to null. Regards Prasanta On 26-Jun-20 11:12 AM, Tejpal Rebari wrote: Hi All, Please review the following fix

Re: RFR: 8197560: test javax/swing/JTree/8003400/Test8003400.java fails

2020-06-25 Thread Prasanta Sadhukhan
Hi Pankaj, I am not sure if making the test windows-only is right here as the 8003400 fix was done in BasicTreeUI which is common for all L If the 8003400 bug is manifesting only in windows, then probably we need to move the bugfix to WindowsTreeUI before changing the test to windows-only.

RFR 8245921:Minor copy/paste issue in BasicScrollBarUI

2020-06-25 Thread Prasanta Sadhukhan
Hi All, Please review a small fix for a minor copy/paste error in javax.swing.plaf.basic.BasicScrollBarUI.installDefaults() if ("large".equals(scaleKey)){ scrollBarWidth *= 1.15; incrGap *= 1.15; decrGap *= 1.15; } else if

Re: RFR JDK-8244324: RTFEditorKit does not display some of Japanese characters correctly

2020-06-25 Thread Prasanta Sadhukhan
, I will sponsor this as I am ok with this fix. Regards Prasanta On 15-May-20 12:34 PM, Prasanta Sadhukhan wrote: Thanks Vyom. You could have proposed the patch yourself only... Anyways, I have tested with Font2DTest with all unicodes for default Latin and it seems ok. Will you be able to test

Re: RFR 8248187: javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails with String is not properly drawn

2020-06-25 Thread Prasanta Sadhukhan
a exception. Is this intentional or you were using it for debugging and forgot to remove it? Regards, Pankaj On 24/06/20 8:29 PM, Prasanta Sadhukhan wrote: Hi All, Please review a test only fix for an issue seen in ubuntu linux 20.04. The test draws "AOB" with and without underline

RFR 8248187: javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails with String is not properly drawn

2020-06-24 Thread Prasanta Sadhukhan
Hi All, Please review a test only fix for an issue seen in ubuntu linux 20.04. The test draws "AOB" with and without underline underneath and then looks to try to calculate the midpoint of "O" and then expects to see the transition from top to bottom of bg->fg->bg->fg->bg as you get when you

Re: RFR 8245668:closed test javax/swing/JComboBox/4765319/bug4765319.java fails on windows

2020-06-02 Thread Prasanta Sadhukhan
ping? any reviewer? On 23-May-20 5:41 PM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue seen whereby VK_ENTER is not handled when popup is visible for a comboBox. This issue is regressed because of the JDK-8067986 fix where a check is done upfront whether to accept

Re: RFR JDK-8244324: RTFEditorKit does not display some of Japanese characters correctly

2020-06-01 Thread Prasanta Sadhukhan
is not japanese locale specific. It needs to be tested for other CK locales for normal case at least. Regards Prasanta Thanks! -Prasanta Sadhukhan wrote: - To: Vyom Tiwari , jayashre...@in.ibm.com From: Prasanta Sadhukhan Date: 06/01/2020 05:42PM Cc: "swing-dev@openjdk.jav

Re: RFR: 8196094: [TESTBUG] Test javax/swing/JFileChooser/8002077/bug8002077.java fails

2020-06-01 Thread Prasanta Sadhukhan
. Regards, Pankaj On 01/06/20 12:12 PM, Prasanta Sadhukhan wrote: I think for better test stability, we should also modify invokeLater to invokeAndWait() to be more deterministic. Regards Prasanta On 30-May-20 11:25 PM, Pankaj Bansal wrote: Hi All, Please review the following test only fix

Re: RFR JDK-8244324: RTFEditorKit does not display some of Japanese characters correctly

2020-06-01 Thread Prasanta Sadhukhan
: Hi Prasanta, sorry for the late reply, my teammate Jayashree will send you the test by today. Thanks, Vyom On Mon, Jun 1, 2020 at 5:20 PM Prasanta Sadhukhan mailto:prasanta.sadhuk...@oracle.com>> wrote: Hi Vyom, On 15-May-20 12:34 PM, Prasanta Sadhukhan wrote: Thank

Re: RFR JDK-8244324: RTFEditorKit does not display some of Japanese characters correctly

2020-06-01 Thread Prasanta Sadhukhan
Hi Vyom, On 15-May-20 12:34 PM, Prasanta Sadhukhan wrote: Thanks Vyom. You could have proposed the patch yourself only... Anyways, I have tested with Font2DTest with all unicodes for default Latin and it seems ok. Will you be able to test in other CJK locales (as  I am not sure

Re: RFR: 8196094: [TESTBUG] Test javax/swing/JFileChooser/8002077/bug8002077.java fails

2020-06-01 Thread Prasanta Sadhukhan
I think for better test stability, we should also modify invokeLater to invokeAndWait() to be more deterministic. Regards Prasanta On 30-May-20 11:25 PM, Pankaj Bansal wrote: Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8196094

Re: RFR: 8245968: javax/swing/JTable/7124218/SelectEditTableCell.java is added to ProblemList twice

2020-05-27 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 28-May-20 10:05 AM, Pankaj Bansal wrote: Hi All, Please review the following fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8245968 Patch: diff -r 083deccc617e test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt  Wed May 27 18:02:49 2020 +0530 +++

Re: RFR 8245668:closed test javax/swing/JComboBox/4765319/bug4765319.java fails on windows

2020-05-27 Thread Prasanta Sadhukhan
ping? On 23-May-20 5:41 PM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue seen whereby VK_ENTER is not handled when popup is visible for a comboBox. This issue is regressed because of the JDK-8067986 fix where a check is done upfront whether to accept this key VK_ENTER

Re: RFR: 8233647: [TESTBUG] JColorChooser/Test8051548.java is failing on macos

2020-05-27 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 23-May-20 6:25 PM, Pankaj Bansal wrote: Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233647 Patch: diff -r 0842c9b1bde9 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt  Sat May 23 13:27:09 2020

Re: FR: 8233566: [TESTBUG] KeyboardFocusManager tests failing on MacoS

2020-05-27 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 25-May-20 8:36 PM, Pankaj Bansal wrote: Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233566 webrev: http://cr.openjdk.java.net/~pbansal/8233566/webrev/

Re: RFR: 8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS

2020-05-27 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 26-May-20 1:53 PM, Pankaj Bansal wrote: Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233551 webrev: http://cr.openjdk.java.net/~pbansal/8233551/webrev00/

RFR 8245668:closed test javax/swing/JComboBox/4765319/bug4765319.java fails on windows

2020-05-23 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue seen whereby VK_ENTER is not handled when popup is visible for a comboBox. This issue is regressed because of the JDK-8067986 fix where a check is done upfront whether to accept this key VK_ENTER by checking if InputMap for VK_ENTER is set up or not.

Re: RFR: 8233550: [TESTBUG] JTree tests fail regularly on MacOS

2020-05-22 Thread Prasanta Sadhukhan
+1 On 22-May-20 5:31 PM, Pankaj Bansal wrote: Hello Prasanta, Thanks for the review. I have made the suggested changes. webrev: http://cr.openjdk.java.net/~pbansal/8233550/webrev01/ <http://cr.openjdk.java.net/%7Epbansal/8233550/webrev01/> Regards, Pankaj On 22/05/20 1:44 PM, Pr

Re: RFR: 8233550: [TESTBUG] JTree tests fail regularly on MacOS

2020-05-22 Thread Prasanta Sadhukhan
I guess just to ensure these tests not hampering other tests, you can add a frame.dispose() at finally block. Regards Prasanta On 22-May-20 1:08 PM, Pankaj Bansal wrote: Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233550

Re: Minor copy/paste issue in BasicScrollBarUI ?

2020-05-21 Thread Prasanta Sadhukhan
This code snippet is part of the enhancement that has been added to support Nimbus L It seems to be a bug as it is like this from initial commit for the enhancement. You can raise a bug for this in JBS. Regards Prasanta On 21-May-20 9:07 PM, Vicne wrote: Hi, I came across the following code

Re: RFR: 8233552: [TESTBUG] JTable Test bug7068740.java fails on MacOS

2020-05-21 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 21-May-20 6:49 PM, Pankaj Bansal wrote: Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233552 Patch: diff -r dd652a1b2a39 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt  Sat May 09 09:49:08 2020

Re: RFR: 8233635: [TESTBUG] ProgressMonitorEscapeKeyPress.java fails on macos

2020-05-21 Thread Prasanta Sadhukhan
Hi Pankaj, It seems this issue is observed in osx10.15 as was commented by one tester. I do not see mach5 running this test on osx10.15. Did you verify in osx10.15? Regards Prasanta On 21-May-20 10:08 AM, Pankaj Bansal wrote: Hi All, Please review the following test only fix for jdk15.

Re: RFR: 8233553 [TESTBUG] JSpinner test bug4973721.java fails on MacOS

2020-05-19 Thread Prasanta Sadhukhan
looks ok to me. But you need to rectify code-formatting before pushing 88 try { listener.wait(5000); } 89 catch (InterruptedException e) {} 90 } as try { } catch () {} 128 if (frame != null) 129 SwingUtilities.invokeAndWait(() -> frame.dispose()); Please add curly braces

Re: RFR: 8233559 [TESTBUG] TestNimbusOverride.java is failing on macos

2020-05-18 Thread Prasanta Sadhukhan
Looks good to me. Regards Prasanta On 18-May-20 3:41 PM, Tejpal Rebari wrote: Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233559 Webrev : http://cr.openjdk.java.net/~trebari/swing/8233559/webrev00/ This test was added to the

Re: RFR: 8245165: Update bug id for javax/swing/text/StyledEditorKit/4506788/bug4506788.java in ProblemList

2020-05-18 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 18-May-20 3:24 PM, Jayathirth D v wrote: Hello All, Please review the following fix in JDK 15: Bug : https://bugs.openjdk.java.net/browse/JDK-8245165 Webrev : http://cr.openjdk.java.net/~jdv/8245165/webrev.00/ Fixing copy paste error in ProblemList. Thanks, Jay

Re: RFR: 8199529 : javax/swing/text/Utilities/8142966/SwingFontMetricsTest.java fails on windows

2020-05-18 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 18-May-20 8:57 AM, Philip Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8199529 webrev : http://cr.openjdk.java.net/~prr/8199529/ Whilst this test does not currently fail, it did fail at the time when freetype was returning different metrics for LCD vs B

Re: RFR JDK-8244324: RTFEditorKit does not display some of Japanese characters correctly

2020-05-15 Thread Prasanta Sadhukhan
they are not adversely affected? Regards Prasanta On 14-May-20 9:01 PM, Vyom Tiwari wrote: Hi prasanta, Code changes look OK to me, although I am not a expert in this area, but  the same patch resolves the issue at our end. Thanks, Vyom On Thu, May 14, 2020 at 4:20 PM Prasanta Sadhukhan

Re: RFR JDK-8067986: Test javax/swing/JComboBox/ConsumedKeyTest/ConsumedKeyTest.java fails

2020-05-14 Thread Prasanta Sadhukhan
milar code in AquaComboBoxUI.triggerSelectionEvent() On 5/6/20 1:45 am, Prasanta Sadhukhan wrote: ping? On 27-Apr-20 9:32 PM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that ComboBox is consuming Enter key without taking action on it. The test was introduced by JDK-805

RFR JDK-8244324: RTFEditorKit does not display some of Japanese characters correctly

2020-05-14 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue seen whereby RTFEditorKit used to read Japanese characters reads some garbage characters. The default character set used for the RTF document is set to "ansi" in our RTFReader.java. And share/classes/javax/swing/text/rtf/charsets/ansi.txt code table

Re: RFR JDK-8238824: [macos] javax/swing/JSpinner/4840869/bug4840869.java fails on macos

2020-05-07 Thread Prasanta Sadhukhan
is overridden in the SynthSpinnerUI, and it will be good to check that it works as well. On 5/6/20 1:02 am, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue in macOS where it is seen that JSpinner keeps spinning while JOptionPane is shown on ChangeListener. This is continuation

RFR JDK-8244557: test/jdk/javax/swing/JTabbedPane/TestBackgroundScrollPolicy.java failed

2020-05-07 Thread Prasanta Sadhukhan
Hi All, Please review a test fix for an issue seen to be failing on mach5 nightly testing. This test was cloned from javax/swing/JTabbedPane/8007563/Test8007563.java (which was added to test fix for JTabbedPane background when tabs are opaque for default WRAP_TAB_LAYOUT policy) and 

Re: RFR: 8229856 [macos] Opening a menu on a JTextField can clear the text selection

2020-05-06 Thread Prasanta Sadhukhan
Looks good to me. But one question, do you require showPopupMenu() on mouseReleased() too? Regards Prasanta On 06-May-20 9:43 AM, Tejpal Rebari wrote: Hi Prasanta, On 22-Apr-2020, at 1:59 PM, Prasanta Sadhukhan <mailto:prasanta.sadhuk...@oracle.com>> wrote: Hi Tejpal, Doe

Re: RFR JDK-8067986: Test javax/swing/JComboBox/ConsumedKeyTest/ConsumedKeyTest.java fails

2020-05-06 Thread Prasanta Sadhukhan
ping? On 27-Apr-20 9:32 PM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that ComboBox is consuming Enter key without taking action on it. The test was introduced by JDK-8058193 where the "Escape" and "Enter" key problem for ComboB

Re: RFR JDK-8242410: JEditorPane with test/html type and zero margins is not shown

2020-05-06 Thread Prasanta Sadhukhan
ping? On 22-Apr-20 3:05 PM, Prasanta Sadhukhan wrote: The regression caused by change in this method was because the rootView layout was changed in those fix(es), but this code is only changing the preferredSize height but I can understand the scepticism. I think since this fix is more about

RFR JDK-8238824: [macos] javax/swing/JSpinner/4840869/bug4840869.java fails on macos

2020-05-06 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue in macOS where it is seen that JSpinner keeps spinning while JOptionPane is shown on ChangeListener. This is continuation of JDK-4840869 fix where it was fixed for BasicSpinnerUI but it still fails in macOS as AquaSpinnerUI has overridden the fixed

RFR JDK-8233643 [TESTBUG] JMenu test bug4515762.java fails on macos

2020-05-04 Thread Prasanta Sadhukhan
Hi All, Please review a testbug fix for an issue seen to be failing on macOS nightly testing with the message “Action has not been received”. It seems to stem from the fact that the menu/menuitem was not visible at the point when robot keypress event was supposed to trigger an action, so it

Re: RFR JDK-8233642: [TESTBUG] JMenuBar test bug 4750590.java fails on macos

2020-05-03 Thread Prasanta Sadhukhan
Bylokhov wrote: Hi, Prasanta. On 5/2/20 1:31 am, Prasanta Sadhukhan wrote: Please review a testbug fix for an issue seen to be failing in macOS nightly testing. The test was failing with “Test failed” message on mach5 macOS system primarily because there was no time gap between component setup

RFR JDK-8233642: [TESTBUG] JMenuBar test bug 4750590.java fails on macos

2020-05-02 Thread Prasanta Sadhukhan
Hi All, Please review a testbug fix for an issue seen to be failing in macOS nightly testing. The test was failing with “Test failed” message on mach5 macOS system primarily because there was no time gap between component setup and test being executed on that component. Added a delay

RFR JDK-8233638 [TESTBUG] Swing test ScreenMenuBarInputTwice.java fails on macos

2020-05-01 Thread Prasanta Sadhukhan
Hi All, Please review a test bug fix for an issue where it is seen the test was failing on macOS during nightly testing. It was found the test failed with the reason "IllegalComponentStateException: component must be showing on the screen to determine its location” which was because the test

RFR JDK-8221902: PIT: javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java fails on ubuntu

2020-04-30 Thread Prasanta Sadhukhan
Hi All, Please review a testbug fix for an issue where the test fails on ubuntu in mach5 system. The test has already been modified twice via JDK-8161470 and JDK-8163169 to add waitForIdle() and delay for mac failure, however we still continued to see failure in ubuntu. I added a delay

Re: [13] RFR JDK-8213535:Windows HiDPI html lightweight tooltips are truncated

2020-04-30 Thread Prasanta Sadhukhan
On 30-Apr-20 2:48 PM, Sergey Bylokhov wrote: On 4/29/20 8:29 pm, Prasanta Sadhukhan wrote: I could understand that we need to use some specific GC instead of null(which is the default), but a force to use GC instead of another non-null GC sounds not good, isn't it? I couldn't get what you

Re: [13] RFR JDK-8213535:Windows HiDPI html lightweight tooltips are truncated

2020-04-29 Thread Prasanta Sadhukhan
= this.getGraphicsConfiguration(); -phil. On 4/20/20, 11:14 AM, Prasanta Sadhukhan wrote: On 20-Apr-20 10:20 PM, Prasanta Sadhukhan wrote: On 20-Apr-20 10:16 PM, Sergey Bylokhov wrote: On 4/20/20 8:34 am, Prasanta Sadhukhan wrote: On 20-Apr-20 8:54 PM, Sergey Bylokhov wrote: On 4/20/20 2:40 am, Prasanta Sadhukhan

Re: [13] RFR JDK-8213535:Windows HiDPI html lightweight tooltips are truncated

2020-04-29 Thread Prasanta Sadhukhan
On 30-Apr-20 8:06 AM, Sergey Bylokhov wrote: On 4/20/20 11:14 am, Prasanta Sadhukhan wrote: It seems JPanel (component created for LW popup) GC is again null and not in sync with JToolTip's GC so in addition to fix JToolTip's GC, we also need to set GC of JPanel (jn sync with "con

RFR JDK-8208566: [TEST_BUG] javax\swing\text\GlyphPainter2\6427244\bug6427244.java: Test failed

2020-04-29 Thread Prasanta Sadhukhan
Hi All, This test was added to ProblemList few months back due to it failing on macOS during nightly testing. But I tried with latest build on local mac and mach5 system (job detail in JBS) where it passed for several iterations, so we can remove it from ProblemList Bug:

RFR JDK-8169953:JComboBox/8057893: ComboBoxEdited event is not fired! on Windows

2020-04-28 Thread Prasanta Sadhukhan
Hi All, This test was added to ProblemList due to it failing on windows and sometimes on mac. But  I have tried with latest build on local windows and mac system and also on mach5 system (job detail in JBS) where it passed for several iterations so we can remove it from ProblemList Bug:

RFR JDK-8067986: Test javax/swing/JComboBox/ConsumedKeyTest/ConsumedKeyTest.java fails

2020-04-27 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue where it is seen that ComboBox is consuming Enter key without taking action on it. The test was introduced by JDK-8058193 where the "Escape" and "Enter" key problem for ComboBox was fixed for mac, but it was seen still for windows and linux. This

Re: RFR JDK-8232243:Wrong caret position in JTextPane on Windows with a screen resolution > 100%

2020-04-26 Thread Prasanta Sadhukhan
bot robot = new Robot(); For the sake of stability would it be better to create the robot and wait for idle before getting the pane location ? -phil. On 4/24/20, 9:31 PM, Prasanta Sadhukhan wrote: Thanks for your review. All comments incorporated http://cr.openjdk.java.net/~psadhukhan/8232243/web

Re: RFR JDK-8232243:Wrong caret position in JTextPane on Windows with a screen resolution > 100%

2020-04-24 Thread Prasanta Sadhukhan
eral times at different scales. Also currently 1.5 is truncated to 1 except on Windows ... If you want to test on Linux or Mac you need 2. Another reason to use the command line way of doing it. -phil On 4/16/20, 3:16 AM, Prasanta Sadhukhan wrote: Hi All, Please review a fix

RFR JDK-8172269: When checking the default behaviour for a scroll tab layout and checking the 'opaque' checkbox, the area behind tabs is not red

2020-04-24 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue where it is seen that the JTabbedPane background for SCROLL_TAB_LAYOUT policy is not same as what is set by user. This is in continuation with the fix done inJDK-8007563 and JDK-8078269

Re: RFR JDK-8242410: JEditorPane with test/html type and zero margins is not shown

2020-04-22 Thread Prasanta Sadhukhan
in this method, I suggest to improve it by some additional code only when we investigate the root cause of all previous issues. The general approach of using zeros as non-initialized flags seems broken. On 4/13/20 3:06 am, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where

Re: RFR: 8229856 [macos] Opening a menu on a JTextField can clear the text selection

2020-04-22 Thread Prasanta Sadhukhan
Hi Tejpal, Does it need to be triple click of any button or only left mouse button? If only left, then it needs to be checked? Also, I guess the test can be automated by calling robot to do 3 clicks and then calling JTextField.getSelectedText() to see if the text is still selected or not.

Re: RFR: 8233584: [Win LAF] When navigating the contents of the file list changes in Win LAF

2020-04-22 Thread Prasanta Sadhukhan
On 22-Apr-20 12:13 PM, Prasanta Sadhukhan wrote: Hi Bhawesh, On 21-Apr-20 12:56 AM, Alexey Ivanov wrote: Hi Bhawesh, Looks good to me. Sorry for my delayed response. I noted that making the test automatic is out of scope at this time, however, it seems to be possible. You don't need

Re: RFR: 8233584: [Win LAF] When navigating the contents of the file list changes in Win LAF

2020-04-22 Thread Prasanta Sadhukhan
Hi Bhawesh, On 21-Apr-20 12:56 AM, Alexey Ivanov wrote: Hi Bhawesh, Looks good to me. Sorry for my delayed response. I noted that making the test automatic is out of scope at this time, however, it seems to be possible. You don't need to read the list of files. The file list reacts to the

Re: RFR JDK-8178028: Typing 'C' cannot change the tab layout to WRAP_TAB_LAYOUT

2020-04-22 Thread Prasanta Sadhukhan
internal CI system is automated testing whereas this test is manual . Regards Prasanta On 22-Apr-20 12:05 PM, Jayathirth D v wrote: Looks good to me if it is verified to pass in our internal CI system also. Thanks, Jay On 17-Apr-2020, at 8:34 PM, Prasanta Sadhukhan wrote: Hi All, Please

Re: [13] RFR JDK-8213535:Windows HiDPI html lightweight tooltips are truncated

2020-04-20 Thread Prasanta Sadhukhan
On 20-Apr-20 10:20 PM, Prasanta Sadhukhan wrote: On 20-Apr-20 10:16 PM, Sergey Bylokhov wrote: On 4/20/20 8:34 am, Prasanta Sadhukhan wrote: On 20-Apr-20 8:54 PM, Sergey Bylokhov wrote: On 4/20/20 2:40 am, Prasanta Sadhukhan wrote: http://cr.openjdk.java.net/~psadhukhan/8213535/webrev.4

Re: [13] RFR JDK-8213535:Windows HiDPI html lightweight tooltips are truncated

2020-04-20 Thread Prasanta Sadhukhan
On 20-Apr-20 10:16 PM, Sergey Bylokhov wrote: On 4/20/20 8:34 am, Prasanta Sadhukhan wrote: On 20-Apr-20 8:54 PM, Sergey Bylokhov wrote: On 4/20/20 2:40 am, Prasanta Sadhukhan wrote: http://cr.openjdk.java.net/~psadhukhan/8213535/webrev.4/ used the right GC for the tip but we still need

  1   2   3   4   5   6   7   8   >