focus.
Added a method to update the selection ownership for caret when text is
selected/unselected in the JTextPane/JTextArea.
Regards,
Rajeev Chamyal
Hello Sergey,
Please review the updated test case.
Webrev : http://cr.openjdk.java.net/~rchamyal/8030099/webrev.01/
As this issue is reported for Parallel GC collector. So, I have added
-XX:+UseParallelGC to child process VM arguments in test case.
Regards,
Rajeev Chamyal
-Original
by dispose method
DefaultDeskTopManager:closeFrame is unable to find reference to previous frame.
Fix: Removed the selection change code from Dispose method.
Regards,
Rajeev Chamyal
themselves.
I have tested the fix with all look and feels on Windows and Ubuntu and on MAC
with Aqua LAF as well.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 06 November 2015 19:41
To: Rajeev Chamyal
Cc: Sergey Bylokhov; swing-dev@openjdk.java.net
Subject
Hello Avik,
1) In the tryLookAndFeel exception handling is skipped. createUI and other
calls should be skipped in case of exception..
2) What all platforms you have tested the bug?
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 04 November 2015 14:51
To: Rajeev Chamyal
repeatedly till it reaches the other end of
scrollbar.
Fix: Added checks in the BasicScrollBarUI action listener to stop the recursion.
Regards,
Rajeev Chamyal
Hello Phil,
I have updated the test case as per your review comments.
Could you please review it.
http://cr.openjdk.java.net/~rchamyal/8030099/webrev.02/
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 12 November 2015 16:02
To: Rajeev Chamyal; Philip Race
Hello Prasanta,
Please review the updated webrev. I have updated it as per review comments.
http://cr.openjdk.java.net/~rchamyal/6288609/webrev.01
Regards,
Rajeev Chamyal
-Original Message-
From: prasanta sadhukhan
Sent: 16 November 2015 12:32
To: Rajeev Chamyal
Cc: Alexander
The fix looks good to me.
Regards,
Rajeev Chamyal
Subject:
Re: RFR: [9] [JDK-8081491] The case print incomplete.
Date:
Fri, 16 Oct 2015 13:19:37 +0300
From:
Alexander Scherbatiy HYPERLINK
"mailto:alexandr.scherba...@oracle.com;<alexandr.scherba...@oracle.com>
To:
The fix looks good to me.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 17 November 2015 11:16
To: Rajeev Chamyal
Cc: Alexander Scherbatiy; swing-dev@openjdk.java.net
Subject: Re: Review for 8132770: Test
javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java fails in MacOSX
The fix looks good to me.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 17 November 2015 15:34
To: Avik Niyogi
Cc: Rajeev Chamyal; swing-dev@openjdk.java.net
Subject: Re: Review request for 7124218: Space should select cell in the JTable
The fix looks
Hello Phil,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8030099/webrev.02/
The test case has been updated as per review comments. Added tests for both
Parallel and default collector.
Regards,
Rajeev Chamyal
-Original Message-
From: Phil Race
Sent: 30
e.
Also we need set the opaque property on label component which makes sure that
all of the bits contained within component's rectangular bounds are painted.
Fix: Setting the default look and feel decoration for frame size issue and
making label opaque.
Regards,
Rajeev Chamyal
Hello Alexander,
Thanks for the review.
We need to set the opaque property on the label as well.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 06 November 2015 15:39
To: Rajeev Chamyal
Cc: Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re: Review
Hello Sergey,
Thanks for the review. The test was working before the fix as well.
The current implementation of OSInfo.getWindowsVersion() adds the missing
values also to windowsVersionMap.
So test always passes.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent
,
Rajeev Chamyal
Hello Sergey,
Thanks for the review. I have updated the webrev with review comments.
WebRev : http://cr.openjdk.java.net/~rchamyal/8138881/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 14 October 2015 20:44
To: Rajeev Chamyal; Alexander Scherbatiy
Hello All,
Please review the below fix for JDK9.
Bug: https://bugs.openjdk.java.net/browse/JDK-8025082
webrev: http://cr.openjdk.java.net/~psadhukhan/rajeev/8025082/webrev.00/
Regards,
Rajeev Chamyal
From: Rajeev Chamyal
Sent: Friday, August 21, 2015 5:40 PM
To: swing-dev
or less size. Test condition was
checking for inequality and throwing Runtime exception.
Regards,
Rajeev Chamyal
Hello All,
Please review the updated webrev.
Webrev: http://cr.openjdk.java.net/~psadhukhan/rajeev/8025082/webrev.02/
Bug: https://bugs.openjdk.java.net/browse/JDK-8025082
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: Wednesday, August 26, 2015 6:39 PM
and child components.
Added a default Insets value for Nimbus look and feel, similar to other layouts.
Regards,
Rajeev Chamyal
Hi All,
Please review the following webrev.
http://cr.openjdk.java.net/~psadhukhan/rajeev/5042886/webrev.open/
http://cr.openjdk.java.net/~psadhukhan/rajeev/5042886/webrev.closed/
Test has been moved to open repository.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander
Hello All,
I need one more review for this fix. Can someone please review it.
http://cr.openjdk.java.net/~psadhukhan/rajeev/5042886/webrev.open/
http://cr.openjdk.java.net/~psadhukhan/rajeev/5042886/webrev.closed/
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent
Hello All,
I need one more review for this fix. Can someone please review it.
Webrev : http://cr.openjdk.java.net/~psadhukhan/rajeev/8032568/webrev.00/
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: Thursday, September 03, 2015 9:05 PM
To: Rajeev Chamyal
Hello All,
Please review the following webrev. I have updated the fix as per review
comments.
http://cr.openjdk.java.net/~psadhukhan/rajeev/8032568/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Phil Race
Sent: Thursday, September 03, 2015 11:26 PM
To: Rajeev Chamyal
Cc
Hello All,
I need one more review for this fix. Can someone please review it.
Webrev : http://cr.openjdk.java.net/~psadhukhan/rajeev/8032568/webrev.02/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: Tuesday, September 08, 2015 2:27 PM
To: Rajeev Chamyal
Cc
Hello All,
Please review the below webrev.
http://cr.openjdk.java.net/~psadhukhan/rajeev/8032568/webrev.02/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: Monday, September 07, 2015 6:21 PM
To: Rajeev Chamyal
Cc: Philip Race; Alexander Zvegintsev; swing
Hello All,
Please review the below webrev.
Bug: https://bugs.openjdk.java.net/browse/JDK-7190596
Webrev : http://cr.openjdk.java.net/~psadhukhan/rajeev/7190596/webrev.00/
Regards,
Rajeev Chamyal
From: Rajeev Chamyal
Sent: Monday, August 31, 2015 6:14 PM
To: Alexander Scherbatiy
for different languages.
For example in German close mnemonic is now S and for French its now F. To fix
the issue we are now finding the correct mnemonic character and passing it to
robo.
Regards,
Rajeev Chamyal
Hello All,
I need one more review for this fix. Can someone please review it.
Webrev : http://cr.openjdk.java.net/~psadhukhan/rajeev/8032568/webrev.02/
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent: Tuesday, September 08, 2015 2:38 PM
To: Sergey Bylokhov
Hi Alexander,
Could you please push the fix to JDK9.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: Wednesday, September 09, 2015 6:03 PM
To: Rajeev Chamyal; Alexander Zvegintsev; swing-dev@openjdk.java.net; Alexander
Scherbatiy
Subject: Re: Request for review
Hi All,
Please review the following fix for jdk9:
Bug: https://bugs.openjdk.java.net/browse/JDK-7190596
Webrev : http://cr.openjdk.java.net/~psadhukhan/rajeev/7190596/webrev.00/
Test being moved from closed to open repository.
Regards,
Rajeev Chamyal
Hello Alexander,
Thanks for the review. I have updated webrev as per review comments.
Bug: https://bugs.openjdk.java.net/browse/JDK-8067346
Webrev: http://cr.openjdk.java.net/~psadhukhan/rajeev/8067346/webrev.02/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Hello Alexey,
Thanks for noticing it. Yes, we need to resolve it.
Alexander, Should I create a new bug for this or I can submit against the
existing bug.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexey Ivanov
Sent: Friday, October 02, 2015 7:30 PM
To: Alexander Scherbatiy
Hello Alexander,
Thanks for the review. Please push the changes to JDK9.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: Friday, September 18, 2015 9:22 PM
To: Rajeev Chamyal
Cc: Alexander Zvegintsev; swing-dev@openjdk.java.net; Sergey Bylokhov
Subject: Re
.
Current implementation is applying Vista defaults to Windows7 as well and as a
result submenu on windows7 has changed offset.
Added checks in WindowsLookAndFeel.java to skip Vista menu defaults for
Windows7.
Verified changes on Netbeans9 Dev build and SwingSet2 applications.
Regards,
Rajeev
Hello Avik,
Can you use @requires (os.family == "mac") instead of a method to check the OS
type.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 30 November 2015 17:22
To: Rajeev Chamyal; Alexander Scherbatiy; Sergey Bylokhov;
swing-dev@openjdk.java.net
Subject: Revi
Hello,
Gentle reminder for review.
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent: 10 December 2015 22:42
To: Sergey Bylokhov; Alexander Scherbatiy; swing-dev@openjdk.java.net; Prasanta
Sadhukhan
Subject: RE: JDK9 Review Request for JDK-7104635 HTMLEditorKit
JDesktopPane.java as part of fix.
Regards,
Rajeev Chamyal
Hello Sergey,
Thanks for the review.
indentLevel is decremented in AbstractWriter :: incrIndent method as well.
Here also we have a check before decrementing indentLevel.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 09 December 2015 01:49
To: Rajeev Chamyal
has already
updated the cache so
Current frame is not found in cache and focus shift fails.
Fix: Internal frame removal from container is done after focus shift.
Regards,
Rajeev Chamyal
Hello Sergey,
Thanks for review I have updated webrev.
There was one more issue with fix to fix it , I have updated
BasicInternalFrameUI.java and added it to webrev.
http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey
and
BasicScrollBarUI::scrollByUnit method is again getting called recursively,
Because of which the scroll bar pointer keeps on moving till the end of
scrollbar.
With this new implementation these issue are not seen.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 25
Hello Sergey,
Thanks for the review. I have updated the code.
http://cr.openjdk.java.net/~rchamyal/8145060/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 25 December 2015 21:23
To: Rajeev Chamyal; Alexander Scherbatiy; Prasanta Sadhukhan;
swing-dev
Hello Alexey,
Thanks for the review. I have updated the code as suggested.
http://cr.openjdk.java.net/~rchamyal/4769772/webrev.02/
Please see response to questions inline.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexey Ivanov
Sent: 25 December 2015 18:14
To: Rajeev Chamyal
waste time calculating
the position if we ignore the operation eventually?
[Rajeev Chamyal] Updated the code as suggested.
2) Yet your new errorMessage filed has the same issue. It should be marked
volatile since it's accessed from different threads without synchronization.
Actually I suggest
Fix looks good to me.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 21 December 2015 09:47
To: Sergey Bylokhov
Cc: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net
Subject: Re: Review request for 8041894: Test
javax/swing/JSpinner/8008657/bug8008657.java failed on Mac
Component orientation is missing.
Fix: Updated the property change listener of Aqua LAF to update editor text
orientation.
Regards,
Rajeev Chamyal
Hello Sergey,
Yes, similar issue is there with maximize as well. I will raise a separate bug
for it.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 19 December 2015 03:51
To: Rajeev Chamyal; Alexander Scherbatiy; Prasanta Sadhukhan;
swing-dev@openjdk.java.net
Hello Alexandr,
I have updated the fix. Please review it.
http://cr.openjdk.java.net/~rchamyal/8075084/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 10 December 2015 16:59
To: Rajeev Chamyal
Cc: Sergey Bylokhov; Prasanta Sadhukhan; swing-dev
for parent and Desktop pane are missing
Fix: Added null checks for parent and desktop pane.
Verified the fix on windows,Ubuntu and Mac with all supported LAF.
Regards,
Rajeev Chamyal
Hello Sergey,
Thanks for the review.
The issues is reproducible with mac Aqua LAF only with other LAF/platforms
issue is not reproducible.
I have updated webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/8078489/webrev.01/
Regards,
Rajeev Chamyal
-Original Message
Hello Alexey,
Thanks for the review.
I have updated webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/4769772/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexey Ivanov
Sent: 23 December 2015 19:27
To: swing-dev@openjdk.java.net
Subject: Re: Review
://cr.openjdk.java.net/~rchamyal/8075084/webrev.02/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 22 December 2015 05:13
To: Rajeev Chamyal
Cc: Sergey Bylokhov; Prasanta Sadhukhan; swing-dev@openjdk.java.net
Subject: Re: Review request for JDK-8075084
Hello All,
I need one more review for this webrev.
HYPERLINK
"http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/"http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/
Regards,
Rajeev Chamyal
From: Alexander Scherbatiy
Sent: 23 December 2015 19:44
To: Rajeev
Hello Sergey,
I have updated the webrev.
http://cr.openjdk.java.net/~rchamyal/8145060/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 29 December 2015 19:48
To: Rajeev Chamyal; Alexander Scherbatiy; Prasanta Sadhukhan;
swing-dev@openjdk.java.net
, along with all necessary parent
directories; false otherwise.
Please let me know if your inputs on this.
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 25 November 2015 21:30
To: Rajeev Chamyal
Cc: Prasanta Sadhukhan; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re: JDK9
t disabled on windows.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexandr Scherbatiy
Sent: 27 November 2015 19:21
To: Rajeev Chamyal
Cc: Prasanta Sadhukhan; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re: JDK9 Review Request for 8067660: JFileChooser create
new fo
: The AbstractWriter::indent method is passing negative length of
indentChars to writer.
Fix: Added checks for negative value while decrementing the
AbstractWriter::indentlevel.
Regards,
Rajeev Chamyal
Hello Alexandr,
I have updated the webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/8067660/webrev.01/
Attached image shows the error message.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 26 November 2015 16:18
To: Rajeev Chamyal
Cc
from GenericFileSystemView:: createNewFolder,
WindowsFileSystemView:: createNewFolder and UnixFileSystemView::
createNewFolder if mkdirs call returns false.
Regards,
Rajeev Chamyal
Hello Sergey,
Could you please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent: 02 January 2016 11:46
To: Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: RE: Review request
SynthToolBar is not checking if preferred size is set for the components.
Fix: Updated the minimumLayoutSize method of SynthToolBarUI.java to check
preferred size of components as well.
Regards,
Rajeev Chamyal
in AquaButtonAreaLayout to consider default
button width and height while calculating minimum size for JOptionPane.
Regards,
Rajeev Chamyal
Hello All,
Gentle reminder to review the fix.
http://cr.openjdk.java.net/~rchamyal/8075084/webrev.02/
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent: 27 December 2015 20:32
To: Sergey Bylokhov
Cc: swing-dev@openjdk.java.net
Subject: Re: Review request for JDK
to select the correct
image.
Regards,
Rajeev Chamyal
Hello Alexandr,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8159135/webrev.01/
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 10 June 2016 19:52
To: Rajeev Chamyal; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re: [9] Review request
only.
Fix: checking for other color values(green and blue) also.
Regards,
Rajeev Chamyal
Looks good to me.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 31 May 2016 13:28
To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net
Subject: Re: Review request for 8132771: [TEST_BUG][macosx] Test
javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java fails for MacOSX
Looks good to me.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexandr Scherbatiy
Sent: 10 June 2016 13:06
To: Ajit Ghaisas; Sergey Bylokhov; Rajeev Chamyal; swing-dev@openjdk.java.net
Subject: Re: Fix for JDK-8065861 : Pressing Esc does not set 'canceled'
property
Hello Prem,
testResult variable is accessed in 2 different threads. It should be declared
volatile.
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 10 June 2016 19:53
To: Prem Balakrishnan; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re: Review Request JDK-8152419
Hello Alexandr,
Thanks for the review. I have updated the webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/8150176/webrev.01/
I tried drawing the image directly to paint graphics without buffered image and
it was getting cropped.
Regards,
Rajeev Chamyal
From
Hello Avik,
The frame should be disposed in case of exception also.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 31 May 2016 11:14
To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net
Subject: Review request for 8132771: [TEST_BUG][macosx] Test
javax/swing
Hello Alexandr,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8146319/webrev.02/
Update: Updated code to use try with resources.
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 01 June 2016 19:30
To: Rajeev Chamyal; Sergey Bylokhov; swing-dev
Fix looks fine to me.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 25 May 2016 22:12
To: Ajit Ghaisas; swing-dev@openjdk.java.net; Alexander Scherbatiy; Rajeev
Chamyal
Subject: Re: Fix for JDK-6827800 : Default button is activated even when it is
invisible
Hello All,
Please review the following webrev
Webrev : http://cr.openjdk.java.net/~rchamyal/8158358/webrev.00/
Bug : https://bugs.openjdk.java.net/browse/JDK-8158358
Fix : Fixed the compilation error.
Regards,
Rajeev Chamyal
Hello Alexandr,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8158358/webrev.01/
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 02 June 2016 01:20
To: Rajeev Chamyal; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re: [9] Review request
block.
Regards,
Rajeev Chamyal
Hello Semyon,
Thanks for the review. Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8146319/webrev.01/
Update: Updated test to use File.createTempFile() for creating temp file.
Regards,
Rajeev Chamyal
From: Semyon Sadetsky
Sent: 01 June 2016 15:01
to find the correct resolution
variant image in current implementation.
Fix: Applied the screen transforms to graphics object.
Regards,
Rajeev Chamyal
Hello Alexandr,
Thanks for the review. I have updated webrev as per comments.
http://cr.openjdk.java.net/~rchamyal/8147648/webrev.01/
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 21 June 2016 17:37
To: Rajeev Chamyal; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject
lFrame all are passing.
http://cr.openjdk.java.net/~rchamyal/8159152/webrev.01/
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 21 June 2016 16:48
To: Rajeev Chamyal; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re: Review Request JDK-8159152 Ctrl+F6, Ctrl+F5 doe
on the desktop.
Fix: Updated the iconifyFrame method so that frame cache updates properly on
internal frame remove and icon addition to desktop.
Regards,
Rajeev Chamyal
Hello All,
Gentle reminder for review.
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent: 13 January 2016 16:37
To: Sergey Bylokhov; Alexander Scherbatiy; Prasanta Sadhukhan;
swing-dev@openjdk.java.net
Subject: Review request for JDK-8139213 : Mac OS X Aqua Look
The fix looks good to me.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 09 February 2016 11:43
To: Sergey Bylokhov; Alexandr Scherbatiy; Rajeev Chamyal
Cc: swing-dev@openjdk.java.net
Subject: Re: Review Request of 8146321: [macosx] JInternalFrame
frame icon in wrong position on Mac L
Hello Prem,
Did you test this fix for other LAF's as well.
Regards,
Rajeev Chamyal
From: Prem Balakrishnan
Sent: 09 February 2016 14:40
To: Sergey Bylokhov; Semyon Sadetsky; Alexander Scherbatiy; Ambarish Rapte;
swing-dev@openjdk.java.net; awt-...@openjdk.java.net
Subject: Review
Hello Avik,
Fix looks good to me.
Can you please check if test case works on windows and linux.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 29 February 2016 09:46
To: Sergey Bylokhov; Alexander Scherbatiy; Rajeev Chamyal;
swing-dev@openjdk.java.net
Subject: Re: Review Request
Hello Avik,
All exception caught during test should mark the test as failed. For example
not able to set any LAF should also be considered as test failure.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 20 January 2016 10:20
To: Rajeev Chamyal
Cc: Alexander Scherbatiy; Sergey
that needs to be added to the minimum
size obtained from the parent class.
The current webrev code I feel is much cleaner than getting the size from
parent class.
Regards,
Rajeev Chamyal
From: Alexander Scherbatiy
Sent: 19 January 2016 21:00
To: Rajeev Chamyal; Sergey Bylokhov; Prasanta
Hello Alexandr,
Thanks for the review.
I have updated the webrev as suggested.
http://cr.openjdk.java.net/~rchamyal/8139213/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 20 January 2016 17:04
To: Rajeev Chamyal
Cc: Sergey Bylokhov; Prasanta
Hello Prem,
1) UI should be created in a swing thread so please update the createUI
method to use a swing thread.
2) Also please use SwingUtilities.invokeAndWait instead of
SwingUtilities.invokeLater.
Regards,
Rajeev Chamyal
From: Prem Balakrishnan
Sent: 11 February 2016 12
Looks good to me.
Regards,
Rajeev Chamyal
From: Prem Balakrishnan
Sent: 15 February 2016 14:22
To: Rajeev Chamyal; Alexander Scherbatiy
Cc: Sergey Bylokhov; Semyon Sadetsky; Ambarish Rapte; swing-dev@openjdk.java.net
Subject: RE: Review Request for 7126823
Hello Ajit,
Can you please if similar fix is required for other LAF windows ,Aqua etc.
Please add a regression test case also.
Regards,
Rajeev Chamyal
From: Ajit Ghaisas
Sent: 15 February 2016 17:30
To: Rajeev Chamyal; Sergey Bylokhov; Alexander Scherbatiy;
swing-dev
Looks good to me.
Regards,
Rajeev Chamyal
From: Ajit Ghaisas
Sent: 17 February 2016 16:51
To: Rajeev Chamyal; Sergey Bylokhov; Alexander Scherbatiy;
swing-dev@openjdk.java.net
Subject: RE: [9] Review fix for JDK-8020039 : SynthTableHeaderUI
refers to possibly null parameter in cell
Hello Sergey,
I have updated the test as per review comments.
http://cr.openjdk.java.net/~rchamyal/8145896/webrev.02/
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 09 March 2016 18:57
To: Rajeev Chamyal; swing-dev@openjdk.java.net
Subject: Re: Review request
Hello Sergey,
Could you please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/
Regards,
Rajeev Chamyal
On 11-01-2016 15:27, Rajeev Chamyal wrote:
Hello Sergey,
Could you please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8145896/webrev
Hello Sergey,
I have run JCK tests for HTMLWriter and AbstractWriter with this fix and all
passed.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 09 March 2016 15:54
To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net
Subject: Re: [9] Review
Hello Avik,
I can’t comment on objective C code.
As far as test is concerned below are my comments.
1) UI should be created in Swing thread.
2) Switch case in actionPerformed should be refactored.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 21 March 2016 12:20
listener determines the state of arrow buttons and source of
mouse events and based on these it stops the timer.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 13 January 2016 21:48
To: Rajeev Chamyal
Cc: Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re
Hello All,
Gentle reminder.
Please review the fix.
Bug : https://bugs.openjdk.java.net/browse/JDK-8150225
Webrev: http://cr.openjdk.java.net/~rchamyal/8150225/webrev.00/
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent: 09 March 2016 15:58
To: Sergey Bylokhov
1 - 100 of 157 matches
Mail list logo
