More updates on this: you can now dismiss pull request reviews (ignore
them for the purposes of required reviews).
https://github.com/blog/2265-dismissing-reviews-on-pull-requests. So
it might be worth trying reenabling required reviews again, as
outdated negative reviews can now be dismissed with
I can't merge either, until you change your review.
On Wed, Sep 28, 2016 at 10:55 AM, Aaron Meurer wrote:
> So here's a problem. At https://github.com/sympy/sympy/pull/11648, I
> requested changes (an X review), and the author pushed some fixes. But it
> still lists me with an X, as requesting ch
So here's a problem. At https://github.com/sympy/sympy/pull/11648, I
requested changes (an X review), and the author pushed some fixes. But it
still lists me with an X, as requesting changes, and says the PR can't be
merged. I'm curious if others are able to merge that PR, or if I have to
revert my
So now it's impossible to merge your own PR (someone else has to review it
first). Hopefully this doesn't become an issue. If you need me to review
your PR, feel free to ping me on Gitter.
Aaron Meurer
On Wed, Sep 21, 2016 at 10:33 PM, Ondřej Čertík
wrote:
> GitHub reached out to me again, that
On Wed, Sep 21, 2016 at 8:33 PM, Ondřej Čertík wrote:
> GitHub reached out to me again, that they fixed it. Indeed, it seems
> to be fixed, so I have enabled the "require review", even for
> administrators. Now if you want to merge a PR, just click on "review"
> and click "approve". Then it will b
GitHub reached out to me again, that they fixed it. Indeed, it seems
to be fixed, so I have enabled the "require review", even for
administrators. Now if you want to merge a PR, just click on "review"
and click "approve". Then it will be allowed to merge.
On Thu, Sep 15, 2016 at 7:40 PM, Ondřej Če
GitHub got back to me, they said it's a bug, that they have an issue
open for it internally. So after they fix it, I think this will do
exactly what we need --- we'll enable the "require approval" check
box, and then it will fail the status if the PR is reviewed and
require more work (i.e. not appr
