kqueue.2: Add a comma

2022-10-21 Thread Josiah Frentsos
Index: kqueue.2 === RCS file: /cvs/src/lib/libc/sys/kqueue.2,v retrieving revision 1.46 diff -u -p -r1.46 kqueue.2 --- kqueue.231 Mar 2022 17:27:16 - 1.46 +++ kqueue.221 Oct 2022 23:02:57 - @@ -105,7 +105,7 @@ is

Re: sparc64: constify ddb instruction table

2022-10-21 Thread Theo de Raadt
Todd C. Miller wrote: > On Fri, 21 Oct 2022 22:55:57 +0200, Mark Kettenis wrote: > > > Be careful. By moving more stuff into .rodata, you may overflow the > > .text/.rodata block. Make sure you build and test the kernels and > > also test an actual bsd.rd. > > Do we know exactly what these

Re: sparc64: constify ddb instruction table

2022-10-21 Thread Todd C . Miller
On Fri, 21 Oct 2022 22:55:57 +0200, Mark Kettenis wrote: > Be careful. By moving more stuff into .rodata, you may overflow the > .text/.rodata block. Make sure you build and test the kernels and > also test an actual bsd.rd. Do we know exactly what these limits are? If so, couldn't we test

Re: sparc64: constify ddb instruction table

2022-10-21 Thread Theo de Raadt
Mark Kettenis wrote: > Be careful. By moving more stuff into .rodata, you may overflow the > .text/.rodata block. Make sure you build and test the kernels and > also test an actual bsd.rd. Unless it fits, just barely, and then a commit three weeks later breaks it. Or three months. Or two

Re: sparc64: constify ddb instruction table

2022-10-21 Thread Mark Kettenis
> Date: Fri, 21 Oct 2022 20:02:48 + > From: Klemens Nanni > > This is the second biggest read-write global in a sparc64 bsd.mp: > 01c091b8 g O .data 2cb8 sparc_i > > ddb(4) does not ever write to it and happily decodes instructions after > moving it to .rodata: > >

Re: sparc64: constify ddb instruction table

2022-10-21 Thread Klemens Nanni
On Fri, Oct 21, 2022 at 11:29:32AM -0900, Philip Guenther wrote: > On Fri, Oct 21, 2022 at 11:04 AM Klemens Nanni wrote: > > > --- a/sys/arch/sparc64/sparc64/db_disasm.c > > +++ b/sys/arch/sparc64/sparc64/db_disasm.c > > > ... > > > @@ -877,7 +877,7 @@ struct sparc_insn sparc_i[] = { > >

Re: sparc64: constify ddb instruction table

2022-10-21 Thread Philip Guenther
On Fri, Oct 21, 2022 at 11:04 AM Klemens Nanni wrote: > --- a/sys/arch/sparc64/sparc64/db_disasm.c > +++ b/sys/arch/sparc64/sparc64/db_disasm.c > ... > @@ -877,7 +877,7 @@ struct sparc_insn sparc_i[] = { > vaddr_t > db_disasm(vaddr_t loc, int altfmt) > { > - struct sparc_insn*

sparc64: constify ddb instruction table

2022-10-21 Thread Klemens Nanni
This is the second biggest read-write global in a sparc64 bsd.mp: 01c091b8 g O .data 2cb8 sparc_i ddb(4) does not ever write to it and happily decodes instructions after moving it to .rodata: ddb{3}> x /i %pc db_inst_branch+0x10:be,pn

malloc diff

2022-10-21 Thread Otto Moerbeek
Hi, this diff has been sent out earlier, but now that more or the immutable parts are in, it is time to test it in this new environment. Thanks, -Otto Index: stdlib/malloc.c === RCS file:

Re: netstart: fix synopsis

2022-10-21 Thread Klemens Nanni
On Fri, Oct 21, 2022 at 06:39:59PM +0100, Jason McIntyre wrote: > i was going to incliude this in my answer, but eventually thought it > looks like a seperate diff: > > the text currently reads as though only a singular interface is > specified, and -n is kind of hidden. so i reworked the text. i

Re: ZZZ and extra mountpoints

2022-10-21 Thread Theo de Raadt
Mark Kettenis wrote: > > I tend to agree that the complexity of this is out of scope for > > man pages. Understanding this properly requires reading books > > about computer architecture first. > > So I would phrase this as something like "device that the OpenBSD > kernel considers removable".

ubcmtp: constify device table

2022-10-21 Thread Klemens Nanni
As usual, a global that's only ever read during match and attach. The device type pointer gets stored in the softc, so that member must be const as well. Builds on amd64 but I don't have Apple notebooks to run-test: 820dd550 l O .rodata0410 ubcmtp_devices Tests?

Re: ZZZ and extra mountpoints

2022-10-21 Thread Mark Kettenis
> Date: Fri, 21 Oct 2022 20:11:49 +0200 > From: Stefan Sperling > > On Fri, Oct 21, 2022 at 06:46:14PM +0100, Jason McIntyre wrote: > > pluggable? The word "removable" is probably a better choice as this is the language used by the ACPI and device tree standards. > It really is a very

Re: uvideo: constify device table

2022-10-21 Thread Marcus Glocker
On Fri, Oct 21, 2022 at 02:25:52PM +, Klemens Nanni wrote: > Not that big, but quirks are likely to grow in the feature and there is > no reason to keep them writable: > 822c0750 g O .data 0160 uvideo_devs > > Builds fine on amd64 but I don't have uvideo(4) attaching

Re: ZZZ and extra mountpoints

2022-10-21 Thread Theo de Raadt
Stefan Sperling wrote: > And perhaps the entire USB bus will be powered down when > the host controller goes to sleep, and all connected devices > will lose power. but oh ... the situation is even more complicated: There are situations where a machine won't suspend because a bus has

malloc: constify memname table

2022-10-21 Thread Klemens Nanni
These are the compile-time constant strings behind vmstat(1)'s "malloc", the kern.malloc.kmemnames sysctl(8) and panic strings. Boots and displays unchanged on amd64: 82068690 g O .rodata0490 memname OK? Index: kern/kern_malloc.c

Re: ZZZ and extra mountpoints

2022-10-21 Thread Stefan Sperling
On Fri, Oct 21, 2022 at 06:46:14PM +0100, Jason McIntyre wrote: > pluggable? It really is a very machine-specific question. It depends on how the manufaturer decided to connect devices to the mainboard, which is not always possible to tell from the perspective of software which runs on the

Re: ZZZ and extra mountpoints

2022-10-21 Thread Theo de Raadt
Jason McIntyre wrote: > > It is extremely complicated, there is no way to accurately explain > > in user-speak what devices detach and what devices don't detach. > > > > pluggable? Sorry, that is completely untrue. What kind of plug? A USB plug? A MMC plug? A PCI plug? A MINI-PCIE plug? A

Re: ZZZ and extra mountpoints

2022-10-21 Thread Jason McIntyre
On Fri, Oct 21, 2022 at 10:34:23AM -0600, Theo de Raadt wrote: > Sol??ne Rapenne wrote: > > > I agree my sentence isn't good enough or is too much, but I think ZZZ > > explanations isn't enough in its current form > > Maybe it is lacking. But your previous diff didn't help anyone. > > > from

Re: netstart: fix synopsis

2022-10-21 Thread Jason McIntyre
On Fri, Oct 21, 2022 at 12:55:49PM +0100, Jason McIntyre wrote: > On Fri, Oct 21, 2022 at 09:30:08AM +, Klemens Nanni wrote: > > Using -n does not require an interface: > > > > # sh /etc/netstart -n ; echo $? > > ifconfig lo0 inet 127.0.0.1/8 > > route -qn add -inet6 fe80::

Re: ZZZ and extra mountpoints

2022-10-21 Thread Theo de Raadt
Solène Rapenne wrote: > I agree my sentence isn't good enough or is too much, but I think ZZZ > explanations isn't enough in its current form Maybe it is lacking. But your previous diff didn't help anyone. > from your reply I got > information such as external devices that wasn't described in

Re: ZZZ and extra mountpoints

2022-10-21 Thread Theo de Raadt
I disagree with this sentence. The machine is unhiberated in the same way that an unsuspend happens. EVERYTHING is as it was before, except for one thing: Devices which are not known to be part of the machine, will have become detached, and if/when they reattach, configuration of them will be

uvideo: constify device table

2022-10-21 Thread Klemens Nanni
Not that big, but quirks are likely to grow in the feature and there is no reason to keep them writable: 822c0750 g O .data 0160 uvideo_devs Builds fine on amd64 but I don't have uvideo(4) attaching anywhere. OK? diff --git a/sys/dev/usb/uvideo.c b/sys/dev/usb/uvideo.c

Re: loop_clone_destroy: read ifnetlist/rdomain with shared net lock

2022-10-21 Thread Vitaliy Makkoveev
On Fri, Oct 21, 2022 at 12:14:16PM +, Klemens Nanni wrote: > On Fri, Oct 21, 2022 at 03:02:33PM +0300, Vitaliy Makkoveev wrote: > > netlock could be completely dropped here. > > We could probably drop the net lock around ifnetlist wherever the kernel > lock is currently held, but that would

weird behavior with timeout(1) in a script

2022-10-21 Thread Solène Rapenne
hi I found a weird behavior trying to use timeout(1) in a script with interactive commands. My use case is to ask for unlocking /home from /etc/rc.local but continue if I don't type it in time. this is working: timeout 2s less /etc/fstab the same command isn't working from a script,

rpki-client: add support for draft-ietf-sidrops-signed-tal-12

2022-10-21 Thread Job Snijders
Dear all, I've authored an extension to rpki-client(8) to support validation of Signed Objects containing Trust Anchor Keys (aka 'Signed TALs'). Signed TALs provide a mechanism for RIRs to distribute and sign the next Trust Anchor with the current Trust Anchor. This might be an improvement over

Re: loop_clone_destroy: read ifnetlist/rdomain with shared net lock

2022-10-21 Thread Klemens Nanni
On Fri, Oct 21, 2022 at 03:02:33PM +0300, Vitaliy Makkoveev wrote: > netlock could be completely dropped here. We could probably drop the net lock around ifnetlist wherever the kernel lock is currently held, but that would just make it harder to reason about ifnetlist locking, imho. Eventually,

grdc: show timezone when TZ is set

2022-10-21 Thread James Russell Stickney
I am the author of the original patch, and I have to say it is very neat seeing the attention it is getting. I am really enjoying the discussion about how to make the patch better, but note that the original patch was deliberately kept extremely, almost offensivly, simple. like one early

Re: loop_clone_destroy: read ifnetlist/rdomain with shared net lock

2022-10-21 Thread Vitaliy Makkoveev
On Fri, Oct 21, 2022 at 10:28:04AM +, Klemens Nanni wrote: > All interface ioctls always run with the kernel lock anyway, so this > doesn't make a difference, except that it reflects how ifnetlist is not > modified. > > OK? > netlock could be completely dropped here. > diff --git

Re: netstart: fix synopsis

2022-10-21 Thread Jason McIntyre
On Fri, Oct 21, 2022 at 09:30:08AM +, Klemens Nanni wrote: > Using -n does not require an interface: > > # sh /etc/netstart -n ; echo $? > ifconfig lo0 inet 127.0.0.1/8 > route -qn add -inet6 fe80:: -prefixlen 10 ::1 -reject > ... > 0 > > OK? > ok. jmc >

loop_clone_destroy: read ifnetlist/rdomain with shared net lock

2022-10-21 Thread Klemens Nanni
All interface ioctls always run with the kernel lock anyway, so this doesn't make a difference, except that it reflects how ifnetlist is not modified. OK? diff --git a/sys/net/if_loop.c b/sys/net/if_loop.c index a15820420ef..16006c4c102 100644 --- a/sys/net/if_loop.c +++ b/sys/net/if_loop.c @@

netstart: fix synopsis

2022-10-21 Thread Klemens Nanni
Using -n does not require an interface: # sh /etc/netstart -n ; echo $? ifconfig lo0 inet 127.0.0.1/8 route -qn add -inet6 fe80:: -prefixlen 10 ::1 -reject ... 0 OK? Index: etc/netstart ===

Re: ZZZ and extra mountpoints

2022-10-21 Thread Alexander Hall
I think this adds nothing. It already states your system will be restored to its previous state, and so it will, as far as possible. Actually, specifically external (USB) disks, are probably *not* properly restored though... /Alexander On October 21, 2022 9:05:25 AM GMT+02:00, "Solène