Re: diff: tcp ack improvement

2021-02-03 Thread Jan Klemkow
On Tue, Jan 05, 2021 at 10:30:33AM +0100, Claudio Jeker wrote: > On Tue, Jan 05, 2021 at 10:16:04AM +0100, Jan Klemkow wrote: > > On Wed, Dec 23, 2020 at 11:59:13AM +, Stuart Henderson wrote: > > > On 2020/12/17 20:50, Jan Klemkow wrote: > > > > ping > > >

Re: diff: tcp ack improvement

2021-01-05 Thread Jan Klemkow
On Wed, Dec 23, 2020 at 11:59:13AM +, Stuart Henderson wrote: > On 2020/12/17 20:50, Jan Klemkow wrote: > > ping > > > > On Fri, Nov 06, 2020 at 01:10:52AM +0100, Jan Klemkow wrote: > > > bluhm and I make some network performance measurements and kernel > >

Re: remove double call of ttyopen()

2020-12-28 Thread Jan Klemkow
On Mon, Dec 28, 2020 at 07:59:23PM +0100, Klemens Nanni wrote: > On Mon, Dec 28, 2020 at 03:49:35PM +0100, Jan Klemkow wrote: > > The following diff removes useless double calls of ttyopen. l_open is > > a pointer to ttyopen(). All other serial drivers also

remove double call of ttyopen()

2020-12-28 Thread Jan Klemkow
Hi, The following diff removes useless double calls of ttyopen. l_open is a pointer to ttyopen(). All other serial drivers also just use l_open, as it is the general API for this. OK? Bye, Jan Index: arch/luna88k/dev/siotty.c

Re: diff: tcp ack improvement

2020-12-17 Thread Jan Klemkow
ping On Fri, Nov 06, 2020 at 01:10:52AM +0100, Jan Klemkow wrote: > Hi, > > bluhm and I make some network performance measurements and kernel > profiling. > > Setup:Linux (iperf) -10gbit-> OpenBSD (relayd) -10gbit-> Linux (iperf) > > We figured out, that

Re: rc.d(8) for tcpbench

2020-12-15 Thread Jan Klemkow
On Tue, Dec 15, 2020 at 10:59:50PM +, Stuart Henderson wrote: > On 2020/12/15 23:07, Jan Klemkow wrote: > > for frequent performance test it would be nice to just start tcpbench > > as a regular service. tcpbench gets an extra user and group with this > > diff and is alre

Re: rc.d(8) for tcpbench

2020-12-15 Thread Jan Klemkow
On Tue, Dec 15, 2020 at 03:43:38PM -0700, Theo de Raadt wrote: > Jan Klemkow wrote: > > > for frequent performance test it would be nice to just start tcpbench > > as a regular service. tcpbench gets an extra user and group with this > > diff and is already p

rc.d(8) for tcpbench

2020-12-15 Thread Jan Klemkow
Hi, for frequent performance test it would be nice to just start tcpbench as a regular service. tcpbench gets an extra user and group with this diff and is already pledged to "stdio". Thus, there should be no security risk to do this even in hostile environments. OK? bye, Jan Index:

diff: mbuf-chains for tcp/ip/ether_ouput

2020-12-15 Thread Jan Klemkow
Hi, I took on old idea and diff [1] from bluhm and finished it for the IPv4 case. This change uses mbuf chains in tcp/ip/ether_output instead of single mbufs. This approach takes lesser processing power per packets, which we want to send out. In several code path it optimises the processing

diff: cleanup type handling

2020-12-12 Thread Jan Klemkow
Hi, The type of the local variable hash in pf_map_addr() has right length but the wrong type. This diff uses the correct type and removes the useless casts. Both functions uses hash as pf_addr, so no cast is needed. OK? bye, Jan Index: net/pf_lb.c

diff: replace useless use of MCLGETL with MCLGET

2020-12-12 Thread Jan Klemkow
Hi, The use of MCLGETL with the default length MCLBYTES is useless. Thus, this diff removes '(void)' from the MCLGET macro as it is in the MCLGETL and replaces all uses of MCLGETL with MCLBYTES by MCLGET. OK? bye, Jan Index: arch/octeon/dev/if_ogx.c

Re: FT232H variant in uftdi(4)

2020-12-09 Thread Jan Klemkow
On Wed, Dec 09, 2020 at 09:11:35AM +0100, Jan Klemkow wrote: > On Tue, Dec 08, 2020 at 09:03:53PM -0300, Daniel Bolgheroni wrote: > > I have a FT232H variant (marked FT232HQ, 0403:6014) which works with > > uftdi(4). > > > > Still related to uftdi(4), sys/dev/usb/

Re: FT232H variant in uftdi(4)

2020-12-09 Thread Jan Klemkow
On Tue, Dec 08, 2020 at 09:03:53PM -0300, Daniel Bolgheroni wrote: > I have a FT232H variant (marked FT232HQ, 0403:6014) which works with uftdi(4). > > Still related to uftdi(4), sys/dev/usb/ftdi.c has a comment saying uftdi(4) > does not support multiple serial ports because ucom(4), but I'm

Re: diff: tcp ack improvement

2020-11-06 Thread Jan Klemkow
On Fri, Nov 06, 2020 at 08:03:36AM +0100, Otto Moerbeek wrote: > On Fri, Nov 06, 2020 at 01:10:52AM +0100, Jan Klemkow wrote: > > bluhm and I make some network performance measurements and kernel > > profiling. > > > > Setup: Linux (iperf) -10gbit-> OpenBSD (

diff: tcp ack improvement

2020-11-05 Thread Jan Klemkow
Hi, bluhm and I make some network performance measurements and kernel profiling. Setup: Linux (iperf) -10gbit-> OpenBSD (relayd) -10gbit-> Linux (iperf) We figured out, that the kernel uses a huge amount of processing time for sending ACKs to the sender on the receiving interface. After

diff: refactor MCLGETI() macro

2020-10-07 Thread Jan Klemkow
Hi, The name of the macro MCLGETI obsolete. It was made to use a network interface pointer inside. But, now it is just used to define a special length and the interface pointer is discarded. Thus, the following diff renames the macro to MCLGETL and removes the dead parameter ifp. OK? Bye,

diff: remove dead code in a{rm,md}64/a{rm,md}/conf.c

2020-10-07 Thread Jan Klemkow
Hi, the cdev_joy_init makro is just used in i386. OK? Bye, Jan Index: amd64/amd64/conf.c === RCS file: /cvs/src/sys/arch/amd64/amd64/conf.c,v retrieving revision 1.71 diff -u -p -r1.71 conf.c --- amd64/amd64/conf.c 6 Jul 2020

new: rp(4): RocketPort multi serial port pci card driver

2020-10-03 Thread Jan Klemkow
1 Jan 1970 00:00:00 - +++ share/man/man4/rp.4 2 Oct 2020 17:50:01 - @@ -0,0 +1,54 @@ +.\" $OpenBSD$ +.\" +.\" Copyright (c) 2020 Jan Klemkow +.\" +.\" Permission to use, copy, modify, and distribute this software for any +.\" purpose with or without f

fix: ospf6d(8): wrong intra area announcement

2020-10-01 Thread Jan Klemkow
Hi, The new intra area db entry has to be saved into the tree before orig_intra_area_prefix_lsas() is called. If not, the ospf6d will not announce the new intra area db for a newly learned link from another ospf router of the broadcast domain. This bug is triggered, if you add new addresses an

Re: snmpd(8) Remove struct listen_sock

2020-08-22 Thread Jan Klemkow
On Sun, Aug 09, 2020 at 04:10:13PM +0200, Martijn van Duren wrote: > I still want to move udp/tcp handling out of snmpe, so that there's > better layering, but my previous diff never got any response and might > do with some more polishing. > > For now, lets remove listen_sock from snmpd,

diff: simplify ospf6d code

2020-08-21 Thread Jan Klemkow
Hi, The following diff simplifies a switch case statement with no functional change. In case of IMSG_CTL_SHOW_DATABASE duplicated code is removed. This part of the code is now the same as in ospfd. In case of IMSG_CTL_SHOW_DB_INTRA the code was also duplicated and due to a missing continue the

diff: uvm: fix unitialized var and simplify code in km_alloc()

2020-05-20 Thread Jan Klemkow
Hi, The function km_alloc() returns the uninitialized local variable sva if pgl is empty. It seems to be not possible in the current condition of the code, but I'm not sure if this is guaranteed. Thus, I would prefer to initialize sva with zero. It also seems to be unnecessary to loop over the

Re: diff: em(4) deadlock fix

2020-05-09 Thread Jan Klemkow
On Fri, May 08, 2020 at 04:36:28PM +0200, Mark Kettenis wrote: > > Date: Fri, 8 May 2020 15:39:26 +0200 > > From: Jan Klemkow > > On Mon, Apr 27, 2020 at 10:42:52AM +0200, Martin Pieuchot wrote: > > > So the current logic assumes that as long as the ring contains de

Re: diff: em(4) deadlock fix

2020-05-08 Thread Jan Klemkow
On Mon, Apr 27, 2020 at 10:42:52AM +0200, Martin Pieuchot wrote: > On 21/04/20(Tue) 15:54, Jan Klemkow wrote: > > The following diff fixes a deadlock in em(4) when system runs out of > > mbuf(9)s. > > > > Tested with current on amd64 with: > > em0 at pci0 dev

Re: patch: Enable dock audio on Thinkpad dock (Thinkpad L460)

2020-04-27 Thread Jan Klemkow
On Thu, Apr 16, 2020 at 05:59:44PM -0500, Abel Abraham Camarillo Ojeda wrote: > On Tuesday, February 11, 2020, Abel Abraham Camarillo Ojeda > wrote: > > On Wednesday, January 8, 2020, Abel Abraham Camarillo Ojeda > > wrote: > >> On Mon, Dec 30, 2019 at 1:24 PM Abel Abraham Camarillo Ojeda >

diff: em(4) deadlock fix

2020-04-21 Thread Jan Klemkow
Hi, The following diff fixes a deadlock in em(4) when system runs out of mbuf(9)s. Tested with current on amd64 with: em0 at pci0 dev 25 function 0 "Intel I217-LM" rev 0x05: msi, mac 0x1e phy 0xb, address d0:50:99:c1:67:94 When the system runs out of mbufs, the receive ring of the em-NIC also

Re: snmpd(8): fix use of uninitialized pointer

2020-03-10 Thread Jan Klemkow
the additional varbinds to > the trap handle "command". > > Now actually asking for OKs. :-) OK jan@ > On 3/10/20 1:43 PM, Jan Klemkow wrote: > > On Tue, Mar 10, 2020 at 01:13:46PM +0100, Martijn van Duren wrote: > >> On 3/10/20 10:21 AM, Jan Klemkow wrote: >

Re: snmpd(8): fix use of uninitialized pointer

2020-03-10 Thread Jan Klemkow
On Tue, Mar 10, 2020 at 01:13:46PM +0100, Martijn van Duren wrote: > On 3/10/20 10:21 AM, Jan Klemkow wrote: > > On Tue, Mar 10, 2020 at 12:27:20AM +0100, Martijn van Duren wrote: > >> Looking at RFC1157 section 4.1.6, an snmpv1 trap should also contain a > >> varbindlis

Re: snmpd(8): fix use of uninitialized pointer

2020-03-10 Thread Jan Klemkow
NULL anyway? bye, Jan > On 3/9/20 11:38 PM, Jan Klemkow wrote: > > Hi, > > > > The following diff fixes the use of the uninitialized pointer iter > > in trapcmd_exec(). > > > > iter is just initialized in traphandler_parse() if vers is SNMP_V2. In &

snmpd(8): fix use of uninitialized pointer

2020-03-09 Thread Jan Klemkow
Hi, The following diff fixes the use of the uninitialized pointer iter in trapcmd_exec(). iter is just initialized in traphandler_parse() if vers is SNMP_V2. In all other cases iter stays uninitialized and may dereferenced in trapcmd_exec(). OK? bye, Jan Index: traphandler.c

Re: diff: simplify globbing in ftpd(8)

2020-01-14 Thread Jan Klemkow
On Mon, Jan 13, 2020 at 10:30:11AM -0700, Todd C. Miller wrote: > On Mon, 13 Jan 2020 13:45:55 +0100, Jan Klemkow wrote: > > > This diff simplifies globbing for the ftpd(8) ls and stat command. And > > it avoids to glob for the parameters "-lgA". > > >

Re: [PATCH] src/libexec/ftpd: fix nlist with -option does not work

2020-01-14 Thread Jan Klemkow
On Mon, Nov 18, 2019 at 02:56:46PM +0900, SASANO Takayoshi wrote: > At least OpenBSD-6.5 and 6.6's ftpd does not work NLIST command with > any -option like this. > > > ftp> nlist > 150 Opening ASCII mode data connection for 'file list'. > uaa > _sysupgrade > 226 Transfer complete. > ftp>

Re: diff: simplify globbing in ftpd(8)

2020-01-13 Thread Jan Klemkow
On Mon, Jan 13, 2020 at 10:30:11AM -0700, Todd C. Miller wrote: > On Mon, 13 Jan 2020 13:45:55 +0100, Jan Klemkow wrote: > > This diff simplifies globbing for the ftpd(8) ls and stat command. And > > it avoids to glob for the parameters "-lgA". > > > &

diff: simplify globbing in ftpd(8)

2020-01-13 Thread Jan Klemkow
Hi, This diff simplifies globbing for the ftpd(8) ls and stat command. And it avoids to glob for the parameters "-lgA". Due, we just pass a single string to the ftpd_ls() function, we don't need to provide infrastructure for a dynamic list of arguments. Tested it manually and by regression

Re: Add sizes for free() in clct(4)

2019-12-20 Thread Jan Klemkow
On Fri, Dec 20, 2019 at 05:26:56PM +0100, Frederic Cambus wrote: > Here is a diff to add sizes for free() in clct(4). > > Similar diff to the ones previously sent for other audio drivers. > > Comments? OK? OK jan@ > Index: sys/dev/pci/cs4281.c >

Re: ublink(4), led(4) and ledctl(1)

2019-12-14 Thread Jan Klemkow
+main(int argc, char **argv) > +{ > ... > + exit(0); > +} I think its better to return 0 in main() instead of calling the libc function exit(3). > ... and also there are no manpages yet. Below is an example for ledctl.8. Thanks, Jan .\" $OpenBSD$ .\" .\" Copyr

Re: diff: simplify MGETHDR error handling in tcp_output

2019-11-06 Thread Jan Klemkow
Hi Lucas, On Wed, Nov 06, 2019 at 08:28:43PM +, Lucas wrote: > Jan Klemkow wrote: > > the following diff simplifies the error handling of MGETHDR() in > > tcp_output(). Jumps earlier to out, prevents a double check of NULL and > > makes the code more readable. >

Re: [patch] ftp: improve SMALL and NOSSL #ifdefs

2019-11-06 Thread Jan Klemkow
Hi Hiltjo, On Wed, Nov 06, 2019 at 07:53:02PM +0100, Hiltjo Posthuma wrote: > The below patch fixes the #ifndef's for usr.bin/ftp so any combination of > SMALL > and NOSSL will compile again. Diff looks good for me and works in all ifdef combinations without any warning or error. OK jan@

diff: simplify MGETHDR error handling in tcp_output

2019-11-06 Thread Jan Klemkow
Hi, the following diff simplifies the error handling of MGETHDR() in tcp_output(). Jumps earlier to out, prevents a double check of NULL and makes the code more readable. OK? Bye, Jan Index: netinet/tcp_output.c === RCS file:

Re: iwm: support dynamic queue allocation (DQA)

2019-10-16 Thread Jan Klemkow
On Mon, Oct 14, 2019 at 01:51:02PM +0200, Stefan Sperling wrote: > I have successfully tested this diff on 8265 with our current firmware > image (22.361476.0) as well as a newer -22 firmware image (22.391740.0, > which is *not* in fw_update yet). I have also tested 7265 successfully. Also works

Re: net80211: increase background scan backoff timer

2019-10-16 Thread Jan Klemkow
On Mon, Oct 14, 2019 at 02:22:24PM +0200, Stefan Sperling wrote: > Is anyone running this already? OK? I run the diff without any noticeable problems. Run this with iwm and wpa-enterprise. iwm0 at pci1 dev 0 function 0 "Intel Dual Band Wireless-AC 8265" rev 0x78, msi Seems to work for me. bye,

fix: build of aac(4)

2019-10-05 Thread Jan Klemkow
Hi, aac(4) doesn't build in the current status. The following diff fixes compile errors. Also, with the AAC_DEBUG option. I removed the prototypes of the inline functions in aacvar.h because of a K style compile error and that the prototypes are directly followed by their implementation. ok?

Re: system boot hang due to inteldrm(4)

2019-10-02 Thread Jan Klemkow
On Tue, Oct 01, 2019 at 11:34:09AM +1000, Jonathan Gray wrote: > On Tue, Oct 01, 2019 at 12:27:48AM +0200, Jan Klemkow wrote: > > After updating my router to current, the systems hangs during the boot. > > Maybe its caused by the "invalid EDID"?! The System boots up nor

system boot hang due to inteldrm(4)

2019-09-30 Thread Jan Klemkow
Hi, After updating my router to current, the systems hangs during the boot. Maybe its caused by the "invalid EDID"?! The System boots up normaly and doesn't hang, if I disable inteldrm(4) in UKC. Is this issue known? Or, witch additional debug information should I provide to help fixing this

Re: ix(4): enable checksum offload

2019-07-27 Thread Jan Klemkow
On 9.9.2013. 22:07, Mike Belopuhov wrote: > On 9 September 2013 21:48, Brad Smith wrote: > > Here is a diff to enable the checksum offload support for ix(4). > > > > Looking for any testing. > > > > last time i checked this broke ospf traffic. please make sure at least > ip/tcp, ip/udp,

Re: fix: NULL dereference in bios(4)

2019-07-23 Thread Jan Klemkow
On Tue, Jul 23, 2019 at 10:05:58PM +1000, Jonathan Gray wrote: > On Mon, Jul 22, 2019 at 10:03:38AM +0200, Jan Klemkow wrote: > > On Sat, Jul 20, 2019 at 07:16:05PM +1000, Jonathan Gray wrote: > > > On Fri, Jul 19, 2019 at 02:15:03PM +0200, Jan Klemkow wrote: > > > >

Re: fix: NULL dereference in bios(4)

2019-07-22 Thread Jan Klemkow
On Sat, Jul 20, 2019 at 07:16:05PM +1000, Jonathan Gray wrote: > On Fri, Jul 19, 2019 at 02:15:03PM +0200, Jan Klemkow wrote: > > On Fri, Jul 19, 2019 at 09:13:38PM +1000, Jonathan Gray wrote: > > > On Fri, Jul 19, 2019 at 01:07:34PM +0200, Jan Klemkow wrote: > > > &g

Re: fix: NULL dereference in bios(4)

2019-07-19 Thread Jan Klemkow
On Fri, Jul 19, 2019 at 09:13:38PM +1000, Jonathan Gray wrote: > On Fri, Jul 19, 2019 at 01:07:34PM +0200, Jan Klemkow wrote: > > Hi, > > > > fixstring() can return NULL and it does on one of my machines. > > Here is s fix that checks for NULL and return a

fix: NULL dereference in bios(4)

2019-07-19 Thread Jan Klemkow
Hi, fixstring() can return NULL and it does on one of my machines. Here is s fix that checks for NULL and return an empty string. ok? bye, Jan Index: arch/amd64/amd64/bios.c === RCS file: /cvs/src/sys/arch/amd64/amd64/bios.c,v

Re: wsfont & free(9) sizes

2019-07-10 Thread Jan Klemkow
On Wed, Jul 10, 2019 at 12:59:41PM -0300, Martin Pieuchot wrote: > Some free(9) sizes & fix to make wsfont_remove() compile. This function > is #ifndef for the moment. That's mainly for coherency and to reduce > grep noise. > > ok? ok jan > Index: dev/wsfont/wsfont.c >

Re: uvideo(4): *ALL*

2019-07-08 Thread Jan Klemkow
Hi Patrick, I tested all you patches with my integrated uvideo(4) device. ... uvideo0 at uhub0 port 8 configuration 1 interface 0 "SunplusIT Inc Integrated Camera" rev 2.01/54.20 addr 9 video0 at uvideo0 ... addr 09: 5986:2115 SunplusIT Inc, Integrated Camera high speed, power 500 mA,

Re: sparc64 ldomctl(8) fix

2019-07-06 Thread Jan Klemkow
On Sat, Jul 06, 2019 at 12:59:55AM +0200, Mark Kettenis wrote: > The diff below fixes interction between ldomctl(8) and the firmware on > a SPARC T4 system that I have access to. To make sure that this > doesn't break other machines it would be good if people could test > this on a few more

Re: free() sizes for ahc(4)

2019-05-14 Thread Jan Klemkow
On Tue, May 14, 2019 at 10:35:22AM +, Miod Vallat wrote: > Note ahc_set_name() gets invoked with the dv_xname field of a struct > device, so it's not a good idea to free anything, should it be invoked > more than once. > > Tested on: > ahc0 at pci0 dev 1 function 0 "Adaptec AIC-7880" rev

Re: softraid(4): fix wrong malloc size and zero sized free calls

2019-05-13 Thread Jan Klemkow
On Mon, May 13, 2019 at 07:25:37PM -0400, Ted Unangst wrote: > Jan Klemkow wrote: > > The diff mainly add sizes to free(9) calls. But, while here fix a > > malloc(9) call with the wrong size in sr_ioctl_installboot(). > > omi->omi_som is allocated with size of struct

softraid(4): fix wrong malloc size and zero sized free calls

2019-05-13 Thread Jan Klemkow
Hi, The diff mainly add sizes to free(9) calls. But, while here fix a malloc(9) call with the wrong size in sr_ioctl_installboot(). omi->omi_som is allocated with size of struct sr_meta_crypto, but used as struct sr_meta_boot later. One free(9) with size zero left over in sr_discipline_free().

enable cy(4) by default on amd64

2019-05-12 Thread Jan Klemkow
Hi, I use tree cy(4) cards on amd64 for several releases. Its totally stable and works fine beside known bugs already mentioned in the manpage. Thus, I would prefer to enabled it by default in amd64 as it is in i386. Bye, Jan Index: arch/amd64/conf/GENERIC

sv(4): fix free with zero size

2019-05-12 Thread Jan Klemkow
Hi, The following diff fixes "free with zero size" in sv(4). Builds and stats the kernel with sv at pci and audio at sv enabled. bye, Jan Index: dev/pci/sv.c === RCS file: /cvs/src/sys/dev/pci/sv.c,v retrieving revision 1.34 diff

Re: ftpd(8): rm dead code and simplifies popen clone

2019-05-08 Thread Jan Klemkow
On Wed, May 08, 2019 at 07:10:37PM -0400, Ted Unangst wrote: > Jan Klemkow wrote: > > - * Special version of popen which avoids call to shell. This ensures noone > > + * Special version of popen which avoids call to shell. This ensures none > > If we don't like noone,

ftpd(8): rm dead code and simplifies popen clone

2019-05-08 Thread Jan Klemkow
Hi, This diff removes dead code from ftpd(8). In the past ftpd executes ls(1) for directory listings. But, quite a while now It justs calls the main function of the linked in ls(1) directly. The code path to the main function of ls(1) as well as the read-only mode are hard coded in the current

diff: reboot(8): document the -l option

2019-03-25 Thread Jan Klemkow
Hi, The following diff adds missing documentation for the -l option of reboot(8) as its done in NetBSD. Bye, Jan Index: reboot.8 === RCS file: /cvs/src/sbin/reboot/reboot.8,v retrieving revision 1.50 diff -u -p -r1.50 reboot.8 ---

diff: add support for ANT-USBStick2 to uscom(4)

2019-02-22 Thread Jan Klemkow
Hi, The diff below adds support for the Dynastream "ANT USBStick2" to uscom(4). The device attached with the following message: uscom0 at uhub0 port 2 configuration 1 interface 0 "Dynastream Innovations ANT USBStick2" rev 2.00/1.00 addr 2 ucom0 at uscom0 portno 0 Additionally, I tested the

diff: add missing bit description for pkthdr_pf.flags

2019-02-08 Thread Jan Klemkow
Hi, The following diff adds the description of the second bit of the struct pkthdr_pf field flags. bye, Jan Index: sys/sys/mbuf.h === RCS file: /cvs/src/sys/sys/mbuf.h,v retrieving revision 1.241 diff -u -p -r1.241 mbuf.h ---

snmpd: dup open ttys to /dev/null in demons mode

2019-01-07 Thread Jan Klemkow
Hi, This diff is similar to bluhm@'s fix for httpd and relayd, but for snmpd. > During the fork+exec implementation, daemon(3) was moved after > proc_init(). As a consequence httpd(8) and relayd(8) child processes > do not detach from the terminal anymore. Dup /dev/null to the stdio > file

diff: new PCI Vendor and Product ID for RocketPort serial card

2019-01-07 Thread Jan Klemkow
Hi, the following diff adds the PCI vendor and product ID for a PCI multiport serial card. dmesg shows the device as: "Comtrol Corporation RocketPort PCI 16-port Serial" rev 0x01 at pci1 dev 1 function 0 not configured bye, Jan Index: pci/pcidevs

diff: fix missing include guard in dev/biovar.h

2018-12-19 Thread Jan Klemkow
Hi, I run into double definition problems because of a missing include guard in dev/biovar.h. The diff below should fix that issue. Bye, Jan Index: sys/dev/biovar.h === RCS file: /cvs/src/sys/dev/biovar.h,v retrieving revision

Re: diff: ftpd(8): fix for sign-compare compiler warnings

2018-12-06 Thread Jan Klemkow
On Tue, Nov 27, 2018 at 09:03:15AM +0100, Theo Buehler wrote: > On Sun, Nov 25, 2018 at 12:32:23AM +0100, Jan Klemkow wrote: > > This diff fixes some -Wsign-compare compiler warnings in ftpd(8) by > > using the right types for 'i' and 'len'. One warning is left, but I > >

diff: ftpd(8): fix for sign-compare compiler warnings

2018-11-24 Thread Jan Klemkow
Hi, This diff fixes some -Wsign-compare compiler warnings in ftpd(8) by using the right types for 'i' and 'len'. One warning is left, but I don't see that it's fixable without suppressing the warning by a cast of len to size_t. And casting might be controversial in this case?!

Re: diff: Fix send(2) EACCES mistake

2018-11-10 Thread Jan Klemkow
On Sat, Nov 10, 2018 at 11:22:48AM +0100, Claudio Jeker wrote: > On Fri, Nov 09, 2018 at 03:49:32PM -0700, Alexander Bluhm wrote: > > On Fri, Nov 09, 2018 at 09:03:20PM +0100, Jan Klemkow wrote: > > > On Fri, Nov 09, 2018 at 12:36:20PM -0700, Alexander Bluhm wrote: > >

Re: diff: Fix send(2) EACCES mistake

2018-11-09 Thread Jan Klemkow
On Fri, Nov 09, 2018 at 12:36:20PM -0700, Alexander Bluhm wrote: > On Fri, Nov 09, 2018 at 08:24:47PM +0100, Jan Klemkow wrote: > > Perfect, I also think its more intuitive to get a "permission denied" > > in case of a pf(4) block then a "Host is unreachable".

Re: diff: Fix send(2) EACCES mistake

2018-11-09 Thread Jan Klemkow
On Fri, Nov 09, 2018 at 06:57:16PM +0100, Claudio Jeker wrote: > On Fri, Nov 09, 2018 at 06:09:34PM +0100, Jan Klemkow wrote: > > I printed the code path below to make it easier to review the diff. > > While I was following the code path again, I found an inconsistency > &g

Re: diff: Fix send(2) EACCES mistake

2018-11-09 Thread Jan Klemkow
On Tue, Oct 30, 2018 at 07:13:24AM +, Jason McIntyre wrote: > On Mon, Oct 29, 2018 at 11:55:52PM +0100, Jan Klemkow wrote: > > On Sun, Oct 28, 2018 at 10:58:34PM +, Jason McIntyre wrote: > > > On Sun, Oct 28, 2018 at 09:40:33PM +0100, Jan Klemkow wrote: > > >

Re: diff: Fix send(2) EACCES mistake

2018-10-29 Thread Jan Klemkow
On Sun, Oct 28, 2018 at 10:58:34PM +, Jason McIntyre wrote: > On Sun, Oct 28, 2018 at 09:40:33PM +0100, Jan Klemkow wrote: > > Unlike the manpage saids or one might think , sendto(2) sets errno to > > EHOSTUNREACH instead of EACCES in cases of blocking by pf(4) or not > &g

diff: Fix send(2) EACCES mistake

2018-10-28 Thread Jan Klemkow
Hi, Unlike the manpage saids or one might think , sendto(2) sets errno to EHOSTUNREACH instead of EACCES in cases of blocking by pf(4) or not enabled broadcasts. Finally I ran into both cases and think, its time to fix this issue. The diff suggests a new explanation that should cover all error

Re: inteldrm(4): uvm write-combining support

2018-10-28 Thread Jan Klemkow
On Sat, Oct 27, 2018 at 12:31:48PM +0200, Mark Kettenis wrote: > > Date: Sat, 27 Oct 2018 17:16:57 +1100 > > From: Jonathan Gray > > > > On Fri, Oct 26, 2018 at 09:47:51PM +0200, Mark Kettenis wrote: > > > Diff below adds support to uvm to create wtite-combining mappings and > > > uses this to

Re: Add acpipci(4) on amd64

2018-10-23 Thread Jan Klemkow
Hi Mark, On Tue, Oct 23, 2018 at 07:32:16PM +0200, Mark Kettenis wrote: > > Date: Tue, 23 Oct 2018 18:40:42 +0200 > > From: Jan Klemkow > > On Mon, Oct 22, 2018 at 09:45:06PM +0200, Mark Kettenis wrote: > > > Diff below adds an acpipci(4) driver on amd64. For

Re: Add acpipci(4) on amd64

2018-10-23 Thread Jan Klemkow
Hi Mark, On Mon, Oct 22, 2018 at 09:45:06PM +0200, Mark Kettenis wrote: > Diff below adds an acpipci(4) driver on amd64. For now the main > purpose of this driver is to make the PCI-specific _OSC calls to > advertise the functionality we support. Most notably this advertises > support for PCIE

diff: ndp(8): hostname lookup via /etc/ethers

2018-10-22 Thread Jan Klemkow
Hi, The following diff adds the option -e to ndp(8), which resolved printed hostnames via /etc/ethers. You are able to recognise hosts with IPv6 auto privacy extension addresses on local IPv6 routers. Also hosts inside of a yp(8) domain are able to lookup their neighbors via the shared

fix: unveil(2) error handling

2018-08-30 Thread Jan Klemkow
Hi, I found a little bug in the unveil(2) error handling. After blocking unveil(2) by unveil(NULL, NULL), an additional unveil(2) call sets errno to EINVAL instead of EPERM as the manpage saids: EPERM An attempt to increase permissions was made, or the path was not accessible, or

diff: add USB ANT-m Stick via uscom(4)

2018-08-09 Thread Jan Klemkow
Hi, the following diff adds support for an USB ANT+ receiver which is used to communicate with wireless fitness tracking devices. The USB device appears as a serial interface. I just add the device ID to the existing uscom(4) driver and enabled it in GENERIC. I don't know why it was

Re: diff: add if group table to snmpd

2018-05-18 Thread Jan Klemkow
On Mon, May 14, 2018 at 09:21:13PM +0200, Jan Klemkow wrote: > On Mon, May 14, 2018 at 06:53:20PM +0100, Stuart Henderson wrote: > > On 2018/05/14 17:59, Jan Klemkow wrote: > > > The following diff adds an interface group table to the OpenBSD MIBs and > > > the OpenSNMPd

Re: [patch] httpd: add tls client certificate authentication

2018-05-16 Thread Jan Klemkow
Hi Jack, On Wed, May 16, 2018 at 05:32:56PM +0930, Jack Burton wrote: > I figured that if we can agree on this much, so httpd can be used for > the authentication-only case (which is all non-fastcgi sites would want) > straight away, that's be a good first step -- then we can come back and >

Re: diff: add if group table to snmpd

2018-05-14 Thread Jan Klemkow
Hi Stuart, On Mon, May 14, 2018 at 06:53:20PM +0100, Stuart Henderson wrote: > On 2018/05/14 17:59, Jan Klemkow wrote: > > The following diff adds an interface group table to the OpenBSD MIBs and > > the OpenSNMPd. The new snmp table helps to keep track of the demote > > v

diff: add if group table to snmpd

2018-05-14 Thread Jan Klemkow
Hi, The following diff adds an interface group table to the OpenBSD MIBs and the OpenSNMPd. The new snmp table helps to keep track of the demote values of more complex carp setups. To iterate directly through all interface groups, the diff has to extent ioctl interface by a new command

Re: diff: cu(1): add secure kiosk mode + stricter pledge

2017-12-03 Thread Jan Klemkow
On Sat, Dec 02, 2017 at 08:37:34PM +0100, Jan Klemkow wrote: > On Sat, Dec 02, 2017 at 08:17:15PM +0100, Jan Klemkow wrote: > > On Fri, Dec 01, 2017 at 04:17:42PM -0700, Theo de Raadt wrote: > > > So two comments: Calling this thing by the right name (escape), > > >

Re: diff: cu(1): add secure kiosk mode + stricter pledge

2017-12-02 Thread Jan Klemkow
On Sat, Dec 02, 2017 at 08:17:15PM +0100, Jan Klemkow wrote: > On Fri, Dec 01, 2017 at 04:17:42PM -0700, Theo de Raadt wrote: > > So two comments: Calling this thing by the right name (escape), > > would allow you to search other programs which have similar functions, > &g

Re: diff: cu(1): add secure kiosk mode + stricter pledge

2017-12-02 Thread Jan Klemkow
On Fri, Dec 01, 2017 at 04:17:42PM -0700, Theo de Raadt wrote: > > The diff adds the option -k (for kiosk mode) > > Congratulations, you win some sort of prize. That is the worst-named > option I have seen in more than a decade. Thanks. :-) > Good idea though, but I think we have better

diff: cu(1): add secure kiosk mode + stricter pledge

2017-12-01 Thread Jan Klemkow
Hi, I run cu(1) as ssh forced command for other users on my machine. This allows them to reach the serial port of their machines over mine. To prevent them of doing filesystem operations or further command executions I implement this diff. The diff adds the option -k (for kiosk mode) to cu(1)

Re: tftpd(8): diff for ip path rewrite

2017-10-27 Thread Jan Klemkow
On Wed, Oct 25, 2017 at 04:54:01PM +, Jeremie Courreges-Anglas wrote: > On Tue, Oct 24 2017, Jeremie Courreges-Anglas <j...@wxcvbn.org> wrote: > > On Mon, Oct 23 2017, Jan Klemkow <j.klem...@wemelug.de> wrote: > >> On Sun, Oct 22, 2017 at 09:32:54PM +,

Re: tftpd(8): diff for ip path rewrite

2017-10-23 Thread Jan Klemkow
On Sun, Oct 22, 2017 at 09:32:54PM +, Jeremie Courreges-Anglas wrote: > On Sat, Oct 21 2017, Jan Klemkow <j.klem...@wemelug.de> wrote: > > On Fri, Oct 20, 2017 at 12:04:41PM +, Jeremie Courreges-Anglas wrote: > >> On Fri, Oct 20 2017, Sebastien Marie &

Re: tftpd(8): diff for ip path rewrite

2017-10-21 Thread Jan Klemkow
On Fri, Oct 20, 2017 at 12:04:41PM +, Jeremie Courreges-Anglas wrote: > On Fri, Oct 20 2017, Sebastien Marie <sema...@online.fr> wrote: > > On Thu, Oct 19, 2017 at 08:58:12PM +0200, Jan Klemkow wrote: > >> + char nfilename[PATH_MAX]; > >> + > >

Re: tftpd(8): diff for ip path rewrite

2017-10-19 Thread Jan Klemkow
On Thu, Oct 19, 2017 at 09:36:50AM +, Jeremie Courreges-Anglas wrote: > On Wed, Oct 18 2017, Jan Klemkow <j.klem...@wemelug.de> wrote: > > On Wed, Oct 18, 2017 at 08:37:48PM +, Jason McIntyre wrote: > >> On Wed, Oct 18, 2017 at 10:25:13PM +0200, Jan Klemkow wrot

Re: tftpd(8): diff for ip path rewrite

2017-10-18 Thread Jan Klemkow
On Wed, Oct 18, 2017 at 08:37:48PM +, Jason McIntyre wrote: > On Wed, Oct 18, 2017 at 10:25:13PM +0200, Jan Klemkow wrote: > > This diff adds an option for client IP address path prefixes to the > > tftpd(8). First, I used the -r rewrite socket for this, but... > > >

tftpd(8): diff for ip path rewrite

2017-10-18 Thread Jan Klemkow
Hi, This diff adds an option for client IP address path prefixes to the tftpd(8). First, I used the -r rewrite socket for this, but... If you use the rewrite socket feature, the tftpd(8) will exit with an error when the rewrite socket is closed. A reopen of the socket is not possible, if its

Re: [diff] httpd: tls client cert & CRL checks

2017-07-29 Thread Jan Klemkow
Hi Jack, On Fri, Jul 28, 2017 at 02:05:34AM +0930, Jack Burton wrote: > On Thu, 27 Jul 2017 13:10:14 +0200 > > > But, I found a bug in the part of the FastCGI variables. The > > following condition is always false. > > > > > Index: usr.sbin/httpd/server_fcgi.c > > >

Re: [diff] httpd: tls client cert & CRL checks

2017-07-27 Thread Jan Klemkow
Hi Jack, On Fri, Jul 21, 2017 at 06:33:43PM +0930, Jack Burton wrote: > Thoughts? I've tested your diff. The main feature looks fine to me. TLS connections with and with out Clients certs, as well as with and without certificate revocation lists seams to work. Also, the tests are passing.

Re: diff: add missing rtm_send to nd6

2017-06-08 Thread Jan Klemkow
Hi Martin, On Thu, Jun 08, 2017 at 09:44:37AM +0200, Martin Pieuchot wrote: > On 08/06/17(Thu) 00:47, Jan Klemkow wrote: > > This diff adds a missing routing message to the neighbor discovery code. > > The message informs the userland about new reachable IPv6 nodes on the > &g

diff: add missing rtm_send to nd6

2017-06-07 Thread Jan Klemkow
Hi, This diff adds a missing routing message to the neighbor discovery code. The message informs the userland about new reachable IPv6 nodes on the network. The IPv6 network stack acts more like the IPv4 port by this diff. Now, the behavior is like arpcache() in netinet/if_ether.c on line 653.

snmpd: remove unused variables

2017-05-31 Thread Jan Klemkow
Hi, This diff removes two local variables which are never used. bye, Jan Index: trap.c === RCS file: /cvs/src/usr.sbin/snmpd/trap.c,v retrieving revision 1.29 diff -u -p -r1.29 trap.c --- trap.c 21 Apr 2017 13:46:15 -

Re: httpd: proposed patch to add TLS client certificate support

2017-03-30 Thread Jan Klemkow
Hi Jack, I'm not a developer (just a contributor), but I worked on httpd client certs a year ago, too. (https://marc.info/?t=14528592613=1=2) I got a private response from a developer, who had an own similar diff in preparation. He told me that is better to name configuration option

fix: cy(4) debug format strings

2017-02-01 Thread Jan Klemkow
Hi, the kernel does not compile with option CY_DEBUG because of several format string mistakes. This diff fixes them. It compiles on i386 and amd64 without any errors. bye, Jan Index: cy.c === RCS file:

<    1   2   3   >