session leakage in httpd

2015-08-09 Thread Arto Jonsson
Hi, while testing the -current (I also see the issue on 5.7) httpd with a fuzzer I noticed that some HTTP requests result in the session not closing properly. I've attached inline a Python script that should demostrate the issue. I've tested the issue locally and from adjacent network. After

Re: print time_t with %lld in last(1)

2014-04-15 Thread Arto Jonsson
ping On Sun, Mar 23, 2014 at 07:31:11PM +0200, Arto Jonsson wrote: Index: last.c === RCS file: /cvs/src/usr.bin/last/last.c,v retrieving revision 1.39 diff -u -p -r1.39 last.c --- last.c22 Aug 2013 04:43:40 - 1.39

print time_t with %lld in last(1)

2014-03-23 Thread Arto Jonsson
Index: last.c === RCS file: /cvs/src/usr.bin/last/last.c,v retrieving revision 1.39 diff -u -p -r1.39 last.c --- last.c 22 Aug 2013 04:43:40 - 1.39 +++ last.c 27 Feb 2014 13:55:22 - @@ -266,8 +266,8 @@

security(8): check for nobody in /etc/ftpusers

2014-03-23 Thread Arto Jonsson
Or should this check removed completely? Index: security === RCS file: /cvs/src/libexec/security/security,v retrieving revision 1.23 diff -u -p -r1.23 security --- security21 Mar 2013 09:37:37 - 1.23 +++ security23

fix ntpd.8 rfc authors

2014-02-12 Thread Arto Jonsson
University of Delaware mixup. Index: ntpd.8 === RCS file: /cvs/src/usr.sbin/ntpd/ntpd.8,v retrieving revision 1.36 diff -u -p -r1.36 ntpd.8 --- ntpd.8 4 Oct 2013 14:28:16 - 1.36 +++ ntpd.8 12 Feb 2014 14:37:13

Use explicit_bzero in login_*

2014-02-05 Thread Arto Jonsson
Index: login_chpass/login_chpass.c === RCS file: /cvs/src/libexec/login_chpass/login_chpass.c,v retrieving revision 1.16 diff -u -p -r1.16 login_chpass.c --- login_chpass/login_chpass.c 4 Dec 2012 02:24:47 - 1.16 +++

Re: new queue support for systat(1)

2013-11-26 Thread Arto Jonsson
On Thu, Nov 21, 2013 at 12:35:43PM +0200, Arto Jonsson wrote: Hi, the following adds new queue support for systat(1). Both old and new queues are shown in the same display (newqs are shown first). Majority of the code taken from pfctl. For new queues the BW field only shows the target

new queue support for systat(1)

2013-11-21 Thread Arto Jonsson
Hi, the following adds new queue support for systat(1). Both old and new queues are shown in the same display (newqs are shown first). Majority of the code taken from pfctl. For new queues the BW field only shows the target bandwidth (no burst info for example). Index: pftop.c

Re: remove some altq references from manuals

2013-11-01 Thread Arto Jonsson
On Fri, Nov 01, 2013 at 10:45:16AM +, Stuart Henderson wrote: On 2013/10/31 21:06, Arto Jonsson wrote: Index: usr.bin/systat/systat.1 === RCS file: /cvs/src/usr.bin/systat/systat.1,v retrieving revision 1.96 diff -u -p

remove some altq references from manuals

2013-10-31 Thread Arto Jonsson
Index: sbin/iked/iked.conf.5 === RCS file: /cvs/src/sbin/iked/iked.conf.5,v retrieving revision 1.25 diff -u -p -r1.25 iked.conf.5 --- sbin/iked/iked.conf.5 16 Jul 2013 09:45:28 - 1.25 +++ sbin/iked/iked.conf.5 19

fix typo in ltrace usage

2013-06-05 Thread Arto Jonsson
Index: ktrace.c === RCS file: /cvs/src/usr.bin/ktrace/ktrace.c,v retrieving revision 1.25 diff -u -r1.25 ktrace.c --- ktrace.c1 Jun 2013 09:57:58 - 1.25 +++ ktrace.c5 Jun 2013 07:55:58 - @@ -215,7 +215,7 @@ {

Re: add nl(1)

2013-05-28 Thread Arto Jonsson
ping Updated diff. I removed the int width handling and modified the separator printing based on your comment. Index: Makefile === RCS file: /cvs/src/usr.bin/Makefile,v retrieving revision 1.129 diff -u -p -r1.129 Makefile

Re: add nl(1)

2013-05-20 Thread Arto Jonsson
On Wed, May 15, 2013 at 06:16:55AM -0600, Todd C. Miller wrote: I've taken your diff and merged some useful bits from FreeBSD. Specifically, the use of getline() and multibyte support for the -d option. I also made the functions non-static (though I don't think that is such a big deal) and

Re: add nl(1)

2013-05-15 Thread Arto Jonsson
On Wed, May 15, 2013 at 06:16:55AM -0600, Todd C. Miller wrote: I've taken your diff and merged some useful bits from FreeBSD. Specifically, the use of getline() and multibyte support for the -d option. I asked stsp@ about the multibyte support yesterday and it was his opinion that it's not

Re: add nl(1)

2013-05-15 Thread Arto Jonsson
On Wed, May 15, 2013 at 07:52:30AM -0600, Todd C. Miller wrote: If that's the case, can't we just do: if (donumber) { (void)printf(format, width, line); line += incr; (void)fputs(sep, stdout); } else { (void)printf(%*s, width, ); }

Re: off by one in vi(1)

2013-05-12 Thread Arto Jonsson
On Sat, May 11, 2013 at 05:33:20PM -0600, Todd C. Miller wrote: Good catch, I know folks who have hit this bug but I was never able to reproduce it. Moving the isblank() check should be safe since trailing blanks are trimmed earlier on so we won't exit the loop prematurely. I see you didn't

Re: add nl(1)

2013-05-10 Thread Arto Jonsson
On Fri, May 10, 2013 at 08:04:57AM +0100, Stuart Henderson wrote: If we do use this implementation, then pascal@'s version from 2011 added some fixes from FreeBSD, http://comments.gmane.org/gmane.os.openbsd.tech/25740 I'll take a closer look at this and freebsd's code later today. There's one

Re: add nl(1)

2013-05-10 Thread Arto Jonsson
On Fri, May 10, 2013 at 08:04:57AM +0100, Stuart Henderson wrote: On 2013/05/10 13:18, Damien Miller wrote: On Wed, 8 May 2013, Ted Unangst wrote: On Tue, Apr 30, 2013 at 18:57, Arto Jonsson wrote: Taken from netbsd with minor modifications. Comments? I don't think you've

Re: add nl(1)

2013-05-08 Thread Arto Jonsson
On Thu, May 09, 2013 at 01:13:49AM +0200, Marc Espie wrote: On Wed, May 08, 2013 at 04:50:16PM -0400, Ted Unangst wrote: On Tue, Apr 30, 2013 at 18:57, Arto Jonsson wrote: Taken from netbsd with minor modifications. Comments? I don't think you've received much feedback. I don't know how

add nl(1)

2013-04-30 Thread Arto Jonsson
Taken from netbsd with minor modifications. Comments? Index: Makefile === RCS file: /cvs/src/usr.bin/Makefile,v retrieving revision 1.129 diff -u -p -r1.129 Makefile --- Makefile15 Mar 2013 06:01:41 - 1.129 +++ Makefile

RFC: add nl(1)

2012-12-22 Thread Arto Jonsson
Hi, this patch adds nl(1) from netbsd which, if I've understood correctly, is required by posix 2008. I've made the following changes to the code from netbsd: * use strtonum * getprogname() - __progname * remove old RCID * use __dead * clean up includes For the manual: * remove .Pp before .Bl

rs(1) segmentation fault fix

2012-12-03 Thread Arto Jonsson
Hi, noticed this on -current (dated Dec 2) amd64: $ who | rs Segmentation fault (core dumped) $ jot -r 100 | rs 10 10 Segmentation fault (core dumped) I traced it to v1.10 of rs.c: http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/rs/rs.c.diff?r1=1.9;r2=1.10;f=h Index: rs.c

Re: upstream vendors and why they can be really harmful

2012-11-06 Thread Arto Jonsson
On Tue, Nov 06, 2012 at 01:38:32PM +0100, Marc Espie wrote: Basically, we have a pattern, mostly observed with kde (and a bit with gnome) which is really harmful for us. ... Relevant LWN.net article: http://lwn.net/Articles/520892/

Use .Lk instead of .Pa in URLs

2012-07-27 Thread Arto Jonsson
ditto Index: gnu/usr.sbin/sendmail/sendmail/sendmail.8 === RCS file: /cvs/src/gnu/usr.sbin/sendmail/sendmail/sendmail.8,v retrieving revision 1.34 diff -u -r1.34 sendmail.8 --- gnu/usr.sbin/sendmail/sendmail/sendmail.8 17 May 2011

unsigned = 0 comparisons

2012-06-25 Thread Arto Jonsson
Hi, a couple of = 0 comparisons on unsigned integers. These refer to Bitrig commits 171e1f9d and 72337965 respectively. Index: sys/arch/amd64/amd64/machdep.c === RCS file: /cvs/src/sys/arch/amd64/amd64/machdep.c,v retrieving

Re: unsigned = 0 comparisons

2012-06-25 Thread Arto Jonsson
On Mon, Jun 25, 2012 at 07:23:44PM +0100, Nigel Taylor wrote: In place of else if (powerlevel = 30 powerlevel 60) could use else if (powerlevel 60) Thanks. Updated patch below. Index: sys/arch/amd64/amd64/machdep.c

Re: unsigned = 0 comparisons

2012-06-25 Thread Arto Jonsson
are now incorrect. So if a commit id is referenced it should be referenced in a branch that doesn't get rebased (probably master in this case). -- Arto Jonsson

Re: unsigned = 0 comparisons

2012-06-25 Thread Arto Jonsson
On Mon, Jun 25, 2012 at 01:47:18PM -0600, Theo de Raadt wrote: Like, who cares about about commit id's. Projects are just people working together. A project didn't come up with that diff. A person did. When we say where something came from, we do it by giving credit, not by referencing

Re: grep: use queue(3)

2012-02-19 Thread Arto Jonsson
On Sat, Feb 18, 2012 at 01:23:36PM -0800, Philip Guenther wrote: On Sat, Feb 18, 2012 at 12:20 PM, Arto Jonsson ajons...@kapsi.fi wrote: Use queue(3) macros instead of own internal queue implementation. No functional change. ... -typedef struct queue { - B B B struct queue B *next

Minor morse(6) patch

2012-02-18 Thread Arto Jonsson
Make the lookup tables const. Index: morse.c === RCS file: /cvs/src/games/morse/morse.c,v retrieving revision 1.14 diff -u -r1.14 morse.c --- morse.c 27 Oct 2009 23:59:26 - 1.14 +++ morse.c 18 Feb 2012 16:47:27 -

Minor fixes for bs(6) manual

2011-07-04 Thread Arto Jonsson
Hi, some minor fixes in bs(6) manual: - use `Ds' for indentation - re-order the arguments list so its order matches SYNOPSIS Index: games/bs/bs.6 === RCS file: /cvs/src/games/bs/bs.6,v retrieving revision 1.13 diff -u -r1.13 bs.6