On Mon, Jun 25, 2012 at 01:47:18PM -0600, Theo de Raadt wrote:
> Like, who cares about about commit id's.
>
> Projects are just people working together. A project didn't come up
> with that diff. A person did.
>
> When we say where something came from, we do it by giving credit, not
> by referencing some thing which will go away.
Agreed, updated:
Remove >= 0 comparisons on unsigned integers.
Diff by oga at nicotinebsd org
Index: sys/arch/amd64/amd64/machdep.c
===================================================================
RCS file: /cvs/src/sys/arch/amd64/amd64/machdep.c,v
retrieving revision 1.155
diff -u -r1.155 machdep.c
--- sys/arch/amd64/amd64/machdep.c 4 Jun 2012 15:19:47 -0000 1.155
+++ sys/arch/amd64/amd64/machdep.c 25 Jun 2012 18:38:30 -0000
@@ -1652,7 +1652,7 @@
return 1;
/* Low memory used for various bootstrap things */
- if (addr >= 0 && addr < avail_start)
+ if (addr < avail_start)
return 1;
/*
Index: sys/dev/ic/malo.c
===================================================================
RCS file: /cvs/src/sys/dev/ic/malo.c,v
retrieving revision 1.93
diff -u -r1.93 malo.c
--- sys/dev/ic/malo.c 3 Jul 2011 21:35:38 -0000 1.93
+++ sys/dev/ic/malo.c 25 Jun 2012 18:38:31 -0000
@@ -2216,9 +2216,9 @@
bzero(body, sizeof(*body));
body->action = htole16(1);
- if (powerlevel >= 0 && powerlevel < 30)
+ if (powerlevel < 30)
body->supportpowerlvl = htole16(5); /* LOW */
- else if (powerlevel >= 30 && powerlevel < 60)
+ else if (powerlevel < 60)
body->supportpowerlvl = htole16(10); /* MEDIUM */
else
body->supportpowerlvl = htole16(15); /* HIGH */
