Hi,

a couple of >= 0 comparisons on unsigned integers. These refer to Bitrig
commits 171e1f9d and 72337965 respectively.

Index: sys/arch/amd64/amd64/machdep.c
===================================================================
RCS file: /cvs/src/sys/arch/amd64/amd64/machdep.c,v
retrieving revision 1.155
diff -u -r1.155 machdep.c
--- sys/arch/amd64/amd64/machdep.c      4 Jun 2012 15:19:47 -0000       1.155
+++ sys/arch/amd64/amd64/machdep.c      25 Jun 2012 17:28:29 -0000
@@ -1652,7 +1652,7 @@
                return 1;
 
        /* Low memory used for various bootstrap things */
-       if (addr >= 0 && addr < avail_start)
+       if (addr < avail_start)
                return 1;
 
        /*
Index: sys/dev/ic/malo.c
===================================================================
RCS file: /cvs/src/sys/dev/ic/malo.c,v
retrieving revision 1.93
diff -u -r1.93 malo.c
--- sys/dev/ic/malo.c   3 Jul 2011 21:35:38 -0000       1.93
+++ sys/dev/ic/malo.c   25 Jun 2012 17:28:30 -0000
@@ -2216,7 +2216,7 @@
 
        bzero(body, sizeof(*body));
        body->action = htole16(1);
-       if (powerlevel >= 0 && powerlevel < 30)
+       if (powerlevel < 30)
                body->supportpowerlvl = htole16(5);     /* LOW */
        else if (powerlevel >= 30 && powerlevel < 60)
                body->supportpowerlvl = htole16(10);    /* MEDIUM */

Reply via email to