Re: uvideo(4) new quirk flag UVIDEO_FLAG_NOATTACH

2021-04-05 Thread Marcus Glocker
On Mon, Apr 05, 2021 at 11:27:10PM +0200, Mark Kettenis wrote: [...] > > > > How common is it to explain the system behavior in cases like this? > > > > Would it be less surprising (generate less misc@ traffic) if we printed > > > > a note explaining why the camera was skipped? > > > > > > I

Re: uvideo(4) new quirk flag UVIDEO_FLAG_NOATTACH

2021-04-05 Thread Marcus Glocker
On Mon, Apr 05, 2021 at 07:30:43AM -0700, Greg Steuck wrote: > OK gnezdo with a usability question inline. Thanks. See below. > Marcus Glocker writes: > > > martijn@ has recently reported that in his machine he has two cams > > of which one is doing IR, which i

Re: Add /dev/video0 to fbtab

2021-04-04 Thread Marcus Glocker
Thanks for your feedback Matthias. Unfortunately there wasn't too much acceptance for this diff from the community, so it's unlikely that it will make it in to the tree. Cheers, Marcus On Sat, 3 Apr 2021 10:25:58 +0200 Matthias Schmidt wrote: > Hi, > > * Marcus Glocker wrote: > &

Re: uvideo(4) new quirk flag UVIDEO_FLAG_NOATTACH

2021-04-04 Thread Marcus Glocker
me out :-) > > martijn@ > > On Mon, 2021-03-15 at 08:35 +0100, Marcus Glocker wrote: > > martijn@ has recently reported that in his machine he has two cams > > of which one is doing IR, which isn't really supported by uvideo(4). > > This IR device attaches always f

Re: sdmmc(4) off-by-one on boundary check

2021-03-25 Thread Marcus Glocker
On Wed, Mar 24, 2021 at 09:23:22PM +0100, Mark Kettenis wrote: > > Date: Wed, 24 Mar 2021 20:58:48 +0100 > > From: Marcus Glocker > > > > On Tue, Mar 23, 2021 at 09:52:42AM -0600, Theo de Raadt wrote: > > > > > Mark Kettenis wrote: > > >

Re: sdmmc(4) off-by-one on boundary check

2021-03-24 Thread Marcus Glocker
On Wed, Mar 24, 2021 at 02:05:27PM -0600, Theo de Raadt wrote: > Marcus Glocker wrote: > > > On Tue, Mar 23, 2021 at 09:52:42AM -0600, Theo de Raadt wrote: > > > > > Mark Kettenis wrote: > > > > >

Re: sdmmc(4) off-by-one on boundary check

2021-03-24 Thread Marcus Glocker
On Tue, Mar 23, 2021 at 09:52:42AM -0600, Theo de Raadt wrote: > Mark Kettenis wrote: > > > > > Index: sys/dev/sdmmc/sdmmc_scsi.c > > > > === > > > > RCS file: /cvs/src/sys/dev/sdmmc/sdmmc_scsi.c,v > > > > retrieving revision 1.59

Re: sdmmc(4) off-by-one on boundary check

2021-03-23 Thread Marcus Glocker
On Tue, Mar 23, 2021 at 08:29:06AM -0600, Theo de Raadt wrote: > Marcus Glocker wrote: > > > Index: sys/dev/sdmmc/sdmmc_scsi.c > > === > > RCS file: /cvs/src/sys/dev/sdmmc/sdmmc_scsi.c,v > > retrievin

sdmmc(4) off-by-one on boundary check

2021-03-23 Thread Marcus Glocker
I recently got a Raspberry Pi 3 Model B Plus (Rev 1.3). After installing current the first thing during boot which I get is: ... starting network reordering libraries: done. starting early daemons: syslogd pflogd ntpd. starting RPC daemons:. savecore: no core dump bcmsdhost0: transfer timeout!

uvideo(4) new quirk flag UVIDEO_FLAG_NOATTACH

2021-03-15 Thread Marcus Glocker
martijn@ has recently reported that in his machine he has two cams of which one is doing IR, which isn't really supported by uvideo(4). This IR device attaches always first as uvideo0, so he needs to swap that regularly with his working cam which by default attaches to uvideo1. I came up with a

Re: Add /dev/video0 to fbtab

2021-02-26 Thread Marcus Glocker
On Thu, Feb 25, 2021 at 10:36:02PM +0100, Marcus Glocker wrote: > On Thu, Feb 25, 2021 at 09:14:06PM +, Stuart Henderson wrote: > > > On 2021/02/25 22:02, Marcus Glocker wrote: > > > On Thu, Feb 25, 2021 at 08:00:32PM +, Stuart Henderson wrote: > > > >

Re: Add /dev/video0 to fbtab

2021-02-25 Thread Marcus Glocker
On Thu, Feb 25, 2021 at 09:14:06PM +, Stuart Henderson wrote: > On 2021/02/25 22:02, Marcus Glocker wrote: > > On Thu, Feb 25, 2021 at 08:00:32PM +, Stuart Henderson wrote: > > > > > On 2021/02/25 20:10, Marcus Glocker wrote: > > > > We had t

Re: Add /dev/video0 to fbtab

2021-02-25 Thread Marcus Glocker
On Thu, Feb 25, 2021 at 08:00:32PM +, Stuart Henderson wrote: > On 2021/02/25 20:10, Marcus Glocker wrote: > > We had this discussion recently when fbtab(5) for xenodm(1) was fixed > > 6 weeks ago, but we didn't come to an agreement yet. tb@ asked me the > > same quest

Re: Add /dev/video0 to fbtab

2021-02-25 Thread Marcus Glocker
On Thu, Feb 25, 2021 at 09:34:45PM +0100, Mark Kettenis wrote: > > Date: Thu, 25 Feb 2021 20:10:00 +0100 > > From: Marcus Glocker > > > > We had this discussion recently when fbtab(5) for xenodm(1) was fixed > > 6 weeks ago, but we didn't come to an agreement y

Add /dev/video0 to fbtab

2021-02-25 Thread Marcus Glocker
We had this discussion recently when fbtab(5) for xenodm(1) was fixed 6 weeks ago, but we didn't come to an agreement yet. tb@ asked me the same question yesterday whether we can add video(1) to fbtab to avoid manual chown of /dev/video0, which I think a lot of people do today. Therefore here

Re: Back-out USB data toggle fix

2021-02-15 Thread Marcus Glocker
On Sun, Feb 14, 2021 at 03:34:11PM +, Mikolaj Kucharski wrote: > On Sun, Feb 14, 2021 at 03:22:28PM +0100, Marcus Glocker wrote: > > Unfortunately I'm seeing more and more USB device breakages reported > > the last few days related to the USB data toggle fix which we did >

Re: Back-out USB data toggle fix

2021-02-14 Thread Marcus Glocker
On Sun, Feb 14, 2021 at 04:43:17PM +, Stuart Henderson wrote: > On 2021/02/14 15:22, Marcus Glocker wrote: > > Unfortunately I'm seeing more and more USB device breakages reported > > the last few days related to the USB data toggle fix which we did > > commit 2-3 weeks a

Back-out USB data toggle fix

2021-02-14 Thread Marcus Glocker
Unfortunately I'm seeing more and more USB device breakages reported the last few days related to the USB data toggle fix which we did commit 2-3 weeks ago. Since I can't reproduce the issue here with my USB gear, it's very difficult for me to pin point the issue. Therefore I think we should

Re: video(4) multiple opens

2021-02-13 Thread Marcus Glocker
On Sat, Feb 13, 2021 at 10:45:17AM +0100, Claudio Jeker wrote: > On Sat, Feb 13, 2021 at 10:26:48AM +0100, Marcus Glocker wrote: > > On Sat, Feb 13, 2021 at 08:30:04AM +0100, Claudio Jeker wrote: > > > > > On Fri, Feb 12, 2021 at 10:59:05PM +0100, Jeremie Courreges-Angl

Re: video(4) multiple opens

2021-02-13 Thread Marcus Glocker
On Sat, Feb 13, 2021 at 08:30:04AM +0100, Claudio Jeker wrote: > On Fri, Feb 12, 2021 at 10:59:05PM +0100, Jeremie Courreges-Anglas wrote: > > On Wed, Feb 10 2021, Martin Pieuchot wrote: > > > > [...] > > > > > Which fields is the new lock protecting? Why isn't the KERNEL_LOCK() > > > enough?

Re: apu2e4

2021-02-11 Thread Marcus Glocker
My boot.conf was renamed to boot.conf.off in the PXE server. Idiot. Thanks tb@ for the hint :-) Sorry for the noise. On Thu, Feb 11, 2021 at 04:07:02PM +0100, Marcus Glocker wrote: > Is there anyone out there using an apu2e4? > > I just received an APU2E4 / GX-412TC 4GB &

apu2e4

2021-02-11 Thread Marcus Glocker
Is there anyone out there using an apu2e4? I just received an APU2E4 / GX-412TC 4GB https://www.pcengines.ch/apu2e4.htm I can't boot any recent kernel on it, not through USB nor through PXEBOOT. I tried amd64/i386, snapshot, 6.8, 6.6, and all cause the apu to reboot after the entry point

video(4) multiple opens

2021-02-09 Thread Marcus Glocker
jca@ has recently committed a change to video(4) to allow the same process to do multiple opens on the same video device to satisfy certain applications, and start to go in to the V4L2 "1.1.4 Multiple Opens" specification direction as described here:

Re: Use correct config descriptor in ugen_set_config

2021-02-04 Thread Marcus Glocker
On Thu, Feb 04, 2021 at 10:28:42PM +0100, Thomas Jeunet wrote: > On Wed, Feb 03, 2021 at 08:30:42PM +0100, Marcus Glocker wrote: > > On Sun, Jan 31, 2021 at 07:05:29PM +0100, Thomas Jeunet wrote: > > > > > Hello tech, > > > > > > in ugen_set_config

Re: usbhidctl: efault

2021-02-03 Thread Marcus Glocker
On Fri, Jan 29, 2021 at 08:16:27AM +0100, Anton Lindqvist wrote: > Hi, > While running usbhidctl on my USB mouse it occasionally fails as > follows: > > # usbhidctl -f /dev/wsmouse2 > usbhidctl: USB_GET_REPORT (probably not supported by device): Bad > address > > The EFAULT

Re: Use correct config descriptor in ugen_set_config

2021-02-03 Thread Marcus Glocker
On Sun, Jan 31, 2021 at 07:05:29PM +0100, Thomas Jeunet wrote: > Hello tech, > > in ugen_set_config, the cached config descriptor (ugen.c:213) is > obsolete after the call to usbd_set_config_no (ugen.c:220). Use a > refreshed value so the next loop account for the correct number of > interfaces.

Re: uhidpp(4): logitech hid++ device driver

2021-02-02 Thread Marcus Glocker
On Tue, Feb 02, 2021 at 07:55:17PM +0100, Anton Lindqvist wrote: [...] > > > However, it would ease development by getting this in and continue > > > development in tree. Anyone willing to ok? > > > > The reason why I'm currently reluctant to ok this is because of the > > uhidev_set_intr() part

Re: uhidpp(4): logitech hid++ device driver

2021-02-02 Thread Marcus Glocker
On Tue, Feb 02, 2021 at 08:23:29AM +0100, Anton Lindqvist wrote: > On Sat, Jan 30, 2021 at 01:18:07PM +0200, Ville Valkonen wrote: > > On Sat, 2021-01-30 at 08:36 +0100, Anton Lindqvist wrote: > > > On Fri, Jan 29, 2021 at 10:15:05PM +0200, Ville Valkonen wrote: > > > > Hi, > > > > > > > > I

Re: search usbd_interfaces in case of non-compliant device

2021-01-28 Thread Marcus Glocker
On Thu, Jan 28, 2021 at 02:38:04PM +, Edd Barrett wrote: > On Thu, Jan 28, 2021 at 09:56:14AM +, Edd Barrett wrote: > > > > Here's a revised diff that always searches the array, instead of first > trying the expected index. Everyone agreed that this makes for simpler > code, and that

Re: search usbd_interfaces in case of non-compliant device

2021-01-26 Thread Marcus Glocker
On Tue, Jan 26, 2021 at 08:56:29PM +, Edd Barrett wrote: > Hi, > > I've recently come across a uaudio device which doesn't work in OpenBSD: > > uaudio2 at uhub0 port 1 configuration 1 interface 3 "E+ Corp. DAC Audio" rev > 1.10/0.01 addr 2 > uaudio2: class v1, full-speed, async, channels:

Re: New ujoy(4) device for USB gamecontrollers

2021-01-22 Thread Marcus Glocker
On Fri, Jan 22, 2021 at 01:52:24PM -0700, Thomas Frohwein wrote: > On Fri, Jan 22, 2021 at 02:26:31PM -0500, Bryan Steele wrote: > > On Fri, Jan 22, 2021 at 07:00:57PM +0100, Marcus Glocker wrote: > > [...] > > > > > > Considering the hid_is_coll

Re: New ujoy(4) device for USB gamecontrollers

2021-01-22 Thread Marcus Glocker
On Fri, 15 Jan 2021 22:41:13 +0100 Marcus Glocker wrote: > On Fri, 15 Jan 2021 11:37:47 -0500 > Bryan Steele wrote: > > > On Fri, Jan 15, 2021 at 06:23:01AM -0700, Thomas Frohwein wrote: > > > On Sat, Jan 09, 2021 at 10:16:16AM +0100, Marcus Glocker wrote: > &

Re: ims: claim to be a touchpad

2021-01-21 Thread Marcus Glocker
On Wed, 20 Jan 2021 21:42:21 -0600 joshua stein wrote: > There are no i2c-connected mice and ims(4) will always be a > touchpad/touchscreen/stylus that just doesn't meet the requirements > of imt(4). > > Presenting it as WSMOUSE_TYPE_TOUCHPAD makes the X server set it up > as a separate

Re: ugen(4) and uhidev(4) data toggle problem

2021-01-17 Thread Marcus Glocker
Thanks for testing this Greg. On Sat, 16 Jan 2021 16:10:26 -0800 Greg Steuck wrote: > Hi Marcus, > > Marcus Glocker writes: > > > There are a few threads going on related to problems with ugen(4) > > and uhidev(4) devices on xhci(4). This is related to the is

Re: New ujoy(4) device for USB gamecontrollers

2021-01-15 Thread Marcus Glocker
On Fri, 15 Jan 2021 11:37:47 -0500 Bryan Steele wrote: > On Fri, Jan 15, 2021 at 06:23:01AM -0700, Thomas Frohwein wrote: > > On Sat, Jan 09, 2021 at 10:16:16AM +0100, Marcus Glocker wrote: > > > On Thu, Jan 07, 2021 at 08:20:35PM +0100, Marcus Glocker wrote: > > >

Re: New ujoy(4) device for USB gamecontrollers

2021-01-15 Thread Marcus Glocker
On Fri, 15 Jan 2021 06:23:01 -0700 Thomas Frohwein wrote: > On Sat, Jan 09, 2021 at 10:16:16AM +0100, Marcus Glocker wrote: > > On Thu, Jan 07, 2021 at 08:20:35PM +0100, Marcus Glocker wrote: > > > > > > I have heard from others who tried the diff that the PS4 &g

ugen(4) and uhidev(4) data toggle problem

2021-01-15 Thread Marcus Glocker
There are a few threads going on related to problems with ugen(4) and uhidev(4) devices on xhci(4). This is related to the issue patrick@ already explained; while ehci(4) can save the last data toggle state, xhci(4) resets it on every open/close cycle, getting out of sync with the device. This

Re: hid_is_collection() sync with NetBSD

2021-01-11 Thread Marcus Glocker
On Sun, 10 Jan 2021 00:04:21 +0100 Marcus Glocker wrote: > On Sat, 9 Jan 2021 21:51:03 +0100 (CET) > Mark Kettenis wrote: > > > > Date: Sat, 9 Jan 2021 10:38:20 +0100 > > > From: Marcus Glocker > > > > > > I have not much clue about HID, but when

Re: [PATCH] Reduce case duplication in kern_sysctl

2021-01-10 Thread Marcus Glocker
On Sat, 09 Jan 2021 14:39:53 -0800 Greg Steuck wrote: > Thanks for the reviews! > > Marcus Glocker writes: > > > On Sat, 9 Jan 2021 22:09:06 +0100 > > Marcus Glocker wrote: > > If you could fix the switch() indentation in a separate commit (as > >

Re: hid_is_collection() sync with NetBSD

2021-01-09 Thread Marcus Glocker
On Sat, 9 Jan 2021 21:51:03 +0100 (CET) Mark Kettenis wrote: > > Date: Sat, 9 Jan 2021 10:38:20 +0100 > > From: Marcus Glocker > > > > I have not much clue about HID, but when we did some testing for the > > new ujoy(4) driver it turned out that the PS4 cont

Re: [PATCH] Reduce case duplication in kern_sysctl

2021-01-09 Thread Marcus Glocker
On Sat, 9 Jan 2021 22:09:06 +0100 Marcus Glocker wrote: > On Sat, 09 Jan 2021 13:06:36 -0800 > Greg Steuck wrote: > > > Thanks Todd for reviewing these boring patches! > > > > Todd C. Miller writes: > > > > > Updated diff looks good to me. OK

Re: [PATCH] Reduce case duplication in kern_sysctl

2021-01-09 Thread Marcus Glocker
On Sat, 09 Jan 2021 13:06:36 -0800 Greg Steuck wrote: > Thanks Todd for reviewing these boring patches! > > Todd C. Miller writes: > > > Updated diff looks good to me. OK millert@ but it would be good > > to get feedback from Marcus too. > > Sure thing, I'll wait till tomorrow then? > >

hid_is_collection() sync with NetBSD

2021-01-09 Thread Marcus Glocker
I have not much clue about HID, but when we did some testing for the new ujoy(4) driver it turned out that the PS4 controller doesn't get handled correctly by hid.c:hid_is_collection(). This made me peek in to the NetBSD code where I could find an update in this function. Syncing it up makes the

Re: New ujoy(4) device for USB gamecontrollers

2021-01-09 Thread Marcus Glocker
On Thu, Jan 07, 2021 at 08:20:35PM +0100, Marcus Glocker wrote: > > I have heard from others who tried the diff that the PS4 controller is > > causing problems with the way it attaches. I ordered one to trial-and- > > error this myself at home. Could you share output of

Re: New ujoy(4) device for USB gamecontrollers

2021-01-07 Thread Marcus Glocker
On Thu, 7 Jan 2021 10:20:34 -0700 Thomas Frohwein wrote: > On Wed, Jan 06, 2021 at 10:48:58PM +0100, Marcus Glocker wrote: > > [...] > > > The implementation as such looks fine to me. > > But I quickly gave the diff a spin before on amd64 using my PS > > controll

Re: New ujoy(4) device for USB gamecontrollers

2021-01-06 Thread Marcus Glocker
On Mon, Dec 28, 2020 at 05:03:14PM -0700, Thomas Frohwein wrote: > Hi, > > This is a diff to propose a new device type for USB gamecontrollers, > 'ujoy'. > > Rationale > - > > Since the tightening of security around USB devices, USB > gamecontrollers that generally attach to the

Re: video(4) multiple opens

2021-01-06 Thread Marcus Glocker
On Tue, Jan 05, 2021 at 11:54:31PM +0100, Jeremie Courreges-Anglas wrote: > > I hit a weird failure with firefox and BigBlueButton > (https://bigbluebutton.org/) where firefox can't use my webcam. > video(1) works, same for other webrtc sites in firefox, eg meet.jit.si. > ktrace shows that a

Re: /dev/video* permissions

2020-12-29 Thread Marcus Glocker
On Tue, Dec 29, 2020 at 11:09:44PM +0100, Mark Kettenis wrote: > > Date: Tue, 29 Dec 2020 15:24:58 +0100 > > From: Marcus Glocker > > > > Now that we have a switch in place with kern.video.record which requires > > initial root access to enable video reco

/dev/video* permissions

2020-12-29 Thread Marcus Glocker
Now that we have a switch in place with kern.video.record which requires initial root access to enable video recording, I want propose the idea of making the /dev/video* devices accessible to users who are a member of the 'video' group: lrwxr-xr-x 1 root wheel 6 Dec 29 12:38

Re: kern.video.record man page updates

2020-12-29 Thread Marcus Glocker
On Tue, 29 Dec 2020 14:40:09 +0100 Sebastian Benoit wrote: > ok. > > maybe add a line to current.html so that people are not surprised > that their video is no longer working after upgrade. Looks like sthen@ was already there :-) > /Benno > > > Marcus Glocker(mar...@

Re: kern.video.record - part 2

2020-12-25 Thread Marcus Glocker
/video*. By that we require initial root access to enable video recording, but can then permit non-root accounts for video access. On Wed, 16 Dec 2020 15:57:20 + Laurence Tratt wrote: > On Wed, Dec 16, 2020 at 03:50:54PM +0100, Marcus Glocker wrote: > > Hello Marcus, > &g

Re: xhci zero length transfers 'leak' one transfer buffer count

2020-12-23 Thread Marcus Glocker
On Wed, 23 Dec 2020 17:35:36 +0100 Patrick Wildt wrote: > Am Wed, Dec 23, 2020 at 10:44:21AM +0100 schrieb Marcus Glocker: > > On Wed, 23 Dec 2020 09:47:44 +0100 > > Marcus Glocker wrote: > > > > > On Tue, 22 Dec 2020 20:55:41 +0100 > > > Marcus Glock

Re: xhci zero length transfers 'leak' one transfer buffer count

2020-12-23 Thread Marcus Glocker
On Wed, 23 Dec 2020 09:47:44 +0100 Marcus Glocker wrote: > On Tue, 22 Dec 2020 20:55:41 +0100 > Marcus Glocker wrote: > > > > > Did you consider incrementing xx->ntrb instead? > > > > >That doesn't work either, because the status completion

Re: xhci zero length transfers 'leak' one transfer buffer count

2020-12-23 Thread Marcus Glocker
On Tue, 22 Dec 2020 20:55:41 +0100 Marcus Glocker wrote: > > > Did you consider incrementing xx->ntrb instead? > > >That doesn't work either, because the status completion code needs > >xx->ntrb to be correct for the data TD to be handled correctly. > >In

Re: xhci zero length transfers 'leak' one transfer buffer count

2020-12-22 Thread Marcus Glocker
> > Did you consider incrementing xx->ntrb instead? >That doesn't work either, because the status completion code needs >xx->ntrb to be correct for the data TD to be handled correctly. >Incrementing xx->ntrb means the number of TRBs for the data TD is >incorrect, since it includes the (optional)

kern.video.record - part 2

2020-12-16 Thread Marcus Glocker
Hi, In September Laurence Tratt came up with a diff to implement an kern.video.record switch for sysctl(8). The implementation was only for uvideo(4), and hence we wanted to lift that up to the video(4) level, but we were not able to get a good implementation together back then. I reviewed this

Re: delays in sensors thread

2020-12-11 Thread Marcus Glocker
On Fri, Dec 11, 2020 at 10:01:35AM +0100, Alexandre Ratchov wrote: > On Fri, Dec 11, 2020 at 09:07:45AM +0100, Marcus Glocker wrote: > > > > After doing some deeper analyzes in to asmc_wait() I agree to that. > > Something seems to go fundamental wrong there.

Re: delays in sensors thread

2020-12-11 Thread Marcus Glocker
On Thu, Dec 10, 2020 at 06:06:26PM -0300, Martin Pieuchot wrote: > On 10/12/20(Thu) 21:40, Alexandre Ratchov wrote: > > On Thu, Dec 10, 2020 at 05:27:16PM +0100, Marcus Glocker wrote: > > > Hi All, > > > > > > I recently started to play around with uvideo(4) a

delays in sensors thread

2020-12-10 Thread Marcus Glocker
Hi All, I recently started to play around with uvideo(4) and uaudio(4) on my amd64 iMacs. There I quickly noticed regular freezes when streaming USB video or audio. On some of those machines it was very frequent, like every few seconds the video or audio stream did freeze for ~1s, then resume,

Re: Fan Management Framework

2020-11-28 Thread Marcus Glocker
would actually > offer in any way (as most of today's laptops -- including Apple > MacBook macOS ones -- are completely unusable on the lap due to the > terrible thermal profiles and a seeming lack of temperature-based > control options for their active cooling components). > > Chee

Fan Management Framework

2020-11-27 Thread Marcus Glocker
sofs/cd9660/cd9660_node.ccd9660 Index: sys/dev/fan.c === RCS file: sys/dev/fan.c diff -N sys/dev/fan.c --- /dev/null 1 Jan 1970 00:00:00 - +++ sys/dev/fan.c 27 Nov 2020 16:13:54 - @@ -0,0 +1,229 @@ +/* $OpenBSD$ */ + +/* +

Re: RFC: kern.video.record

2020-10-24 Thread Marcus Glocker
On Sat, Oct 24, 2020 at 01:17:05PM -0600, Theo de Raadt wrote: > Seems better. > > Toggling the behaviour while video occurs should be tested, to make > sure it matches expectations. Right, works already for read(2) but for mmap(2) we need to move the check to the VIDIOC_DQBUF ioctl(2) then. I

Re: RFC: kern.video.record

2020-10-24 Thread Marcus Glocker
On Sat, Oct 24, 2020 at 11:34:07AM -0600, Theo de Raadt wrote: > Marcus Glocker wrote: > > > On Sun, Sep 27, 2020 at 05:57:51PM +0100, Laurence Tratt wrote: > > > > > On Sun, Sep 13, 2020 at 09:23:36AM +0100, Laurence Tratt wrote: > > > > > &g

Re: RFC: kern.video.record

2020-10-24 Thread Marcus Glocker
On Sun, Sep 27, 2020 at 05:57:51PM +0100, Laurence Tratt wrote: > On Sun, Sep 13, 2020 at 09:23:36AM +0100, Laurence Tratt wrote: > > > Since I recently opened my big fat mouth and suggested that > > "kern.video.record" (analogous to kern.audio.record) might be a good idea, I > > decided to put

Re: [PATCH] Add USB Product ID for Logitech Webcam Pro 9000

2020-10-17 Thread Marcus Glocker
On Sat, 17 Oct 2020 14:26:49 +0100 Raf Czlonka wrote: > Ping. It's committed, thanks. > On Sun, Oct 11, 2020 at 11:33:21AM BST, Raf Czlonka wrote: > > Hi all, > > > > I just dug a Logitech Webcam Pro 9000 (for Business) out. > > > > After a quick test, it seems to be working just fine but

Re: acpiapplesmc(4)

2020-09-12 Thread Marcus Glocker
On Sat, 12 Sep 2020 10:28:23 +0200 (CEST) Mark Kettenis wrote: > > Date: Sat, 12 Sep 2020 10:00:13 +0200 > > From: Marcus Glocker > > > > On Sat, 12 Sep 2020 09:34:18 +0200 (CEST) > > Mark Kettenis wrote: > > > > > > Date: Sat, 12 Sep

Re: acpiapplesmc(4)

2020-09-12 Thread Marcus Glocker
On Sat, 12 Sep 2020 09:34:18 +0200 (CEST) Mark Kettenis wrote: > > Date: Sat, 12 Sep 2020 09:20:26 +0200 > > From: Marcus Glocker > > > > On Fri, 11 Sep 2020 23:18:56 +0200 (CEST) > > Mark Kettenis wrote: > > > > > > Date: Fri, 11 Sep

Re: acpiapplesmc(4)

2020-09-12 Thread Marcus Glocker
On Fri, 11 Sep 2020 23:18:56 +0200 (CEST) Mark Kettenis wrote: > > Date: Fri, 11 Sep 2020 17:42:23 +0200 > > From: Marcus Glocker > > > > On Thu, 10 Sep 2020 23:44:38 +0200 > > Joerg Jung wrote: > > > > > Don’t give up so quickly ;) > &g

Re: acpiapplesmc(4)

2020-09-11 Thread Marcus Glocker
On Thu, 10 Sep 2020 23:44:38 +0200 Joerg Jung wrote: > Don’t give up so quickly ;) > let’s try to make the driver work on your iMac, send me dmesg and > sysctl hw output please. > > Your idea of converting it to ACPI is the right thing to do anyways, > would be nice to get this working. Here

Re: acpiapplesmc(4)

2020-09-10 Thread Marcus Glocker
On Thu, 10 Sep 2020 23:07:15 +0200 Joerg Jung wrote: > > Am 07.09.2020 um 20:52 schrieb Mark Kettenis > > : > >> Date: Mon, 7 Sep 2020 19:59:13 +0200 > >> From: Marcus Glocker > >> On Mon, 7 Sep 2020 19:25:00 +0200 (CEST) > >> Mark Kettenis

Re: acpiapplesmc(4)

2020-09-10 Thread Marcus Glocker
On Mon, 7 Sep 2020 21:39:55 +0200 Marcus Glocker wrote: > On Mon, 7 Sep 2020 20:50:20 +0200 (CEST) > Mark Kettenis wrote: > > > > Date: Mon, 7 Sep 2020 19:59:13 +0200 > > > From: Marcus Glocker > > > > > > On Mon, 7 Sep 2020 19:

Re: acpiapplesmc(4)

2020-09-07 Thread Marcus Glocker
On Mon, 7 Sep 2020 20:50:20 +0200 (CEST) Mark Kettenis wrote: > > Date: Mon, 7 Sep 2020 19:59:13 +0200 > > From: Marcus Glocker > > > > On Mon, 7 Sep 2020 19:25:00 +0200 (CEST) > > Mark Kettenis wrote: > > > > > > Date: Mon, 7 Se

Re: acpiapplesmc(4)

2020-09-07 Thread Marcus Glocker
On Mon, 7 Sep 2020 19:25:00 +0200 (CEST) Mark Kettenis wrote: > > Date: Mon, 7 Sep 2020 12:02:15 -0500 > > From: joshua stein > > > > On Mon, 07 Sep 2020 at 06:58:01 +0200, Marcus Glocker wrote: > > > This is an initial driver for the Apple System Managemen

acpiapplesmc(4)

2020-09-06 Thread Marcus Glocker
Sep 2020 04:54:57 - @@ -0,0 +1,63 @@ +.\"$OpenBSD$ +.\" +.\" Copyright (c) 2020 Marcus Glocker +.\" +.\" Permission to use, copy, modify, and distribute this software for any +.\" purpose with or without fee is hereby granted, provided that t

usbd_get_cdesc() malloc(size)/free(,size) sanity

2020-08-28 Thread Marcus Glocker
Since we can't always rely on wTotalLength to be correct, use the variable which has been used to malloc(9) cdesc to free(9) it again, instead of freeing wTotalLength. usbd_get_cdesc() already has the feature built-in to return the length it has used to malloc(9) cdesc. OK? Index: ugen.c

Re: video -c: showing auto white balance temperature

2020-08-23 Thread Marcus Glocker
On Sun, 23 Aug 2020 08:59:10 +0100 Laurence Tratt wrote: > On Sun, Aug 23, 2020 at 09:17:57AM +0200, Marcus Glocker wrote: > > Hello Marcus, > > > Sorry for the delay - I'm back to business mode and need to take > > care about naive project managers with cra

Re: video -c: showing auto white balance temperature

2020-08-23 Thread Marcus Glocker
wrote: > On Sat, Aug 08, 2020 at 11:29:41PM +0200, Marcus Glocker wrote: > > Hello Marcus, > > >>>> One other thing has occurred to me -- but can be done in a > >>>> future patch -- is that we probably want to be able to do: > >>>> >

Re: sdmmc(4): add UHS-I support

2020-08-22 Thread Marcus Glocker
On Sat, 22 Aug 2020 14:09:53 +0200 (CEST) Mark Kettenis wrote: > > Date: Mon, 17 Aug 2020 12:57:58 +0200 (CEST) > > From: Mark Kettenis > > > > > Date: Sun, 16 Aug 2020 19:32:03 +0200 (CEST) > > > From: Mark Kettenis > > > > > > The diff below adds support for higher speeds as supported by

ubcmtp* at uhidev? ?

2020-08-20 Thread Marcus Glocker
Is ubcmtp(4) really attaching to uhidev(4)? I only can see it attaching to uhub(4). Do I miss something? Index: sys/dev/usb/ubcmtp.c === RCS file: /cvs/src/sys/dev/usb/ubcmtp.c,v retrieving revision 1.21 diff -u -p -u -p -r1.21

radeondrm(4) timing issue

2020-08-14 Thread Marcus Glocker
Hi, Recently I took over the old iMac11,2 of my son, and what else to do with it other than installing OpenBSD and see what happens. The first thing which happened after the installation was that the screen remained dark after the radeondrm(4) KMS initialization. After some painful debugging,

Re: video -c: showing auto white balance temperature

2020-08-08 Thread Marcus Glocker
Hello Laurie, On Sat, 8 Aug 2020 21:56:08 +0100 Laurence Tratt wrote: > On Sat, Aug 08, 2020 at 09:30:18PM +0200, Marcus Glocker wrote: > > Hello Marcus, > > >> I like your patch, which is better than my original! My only very > >> minor comment is whether we mi

Re: pms(4): disable parity checking for specific elantech fw

2020-08-08 Thread Marcus Glocker
On Sat, 08 Aug 2020 17:08:01 +0200 sxv...@firemail.cc wrote: > So I recently installed OpenBSD on an EeePC 900HD with an Elantech v1 > touchpad (fw_version 0x20022). > This specific fw version for some reason sends inverted parity bits > on a cold boot, returning to normal after suspend & resume.

Re: video -c: showing auto white balance temperature

2020-08-08 Thread Marcus Glocker
On Sat, 8 Aug 2020 15:13:47 +0100 Laurence Tratt wrote: > On Sat, Aug 08, 2020 at 02:45:16PM +0200, Marcus Glocker wrote: > > Hello Marcus, > > > For now how about adding the according auto control id to our > > dev_ctrls structure? In a n

Re: video -c: showing auto white balance temperature

2020-08-08 Thread Marcus Glocker
Hello Laurie, On Wed, 5 Aug 2020 21:42:18 +0100 Laurence Tratt wrote: > Following Marcus's commit of video(1) changes, the attached patch > crudely solves the "-c output is misleading for > white_balance_temperature" because we conflate > auto_white_balance_temperature and

Don't check pointers against 0

2020-08-05 Thread Marcus Glocker
Reported by Peter J. Philipp. OK? Index: sys/netinet/udp_usrreq.c === RCS file: /cvs/src/sys/netinet/udp_usrreq.c,v retrieving revision 1.260 diff -u -p -u -p -r1.260 udp_usrreq.c --- sys/netinet/udp_usrreq.c1 Aug 2020 23:41:56

xhci(4): fix for usbd_start_next: error=13

2020-07-31 Thread Marcus Glocker
When playing around with uvideo(4) devices I'm quite regular hitting the error message in the subject when closing the device. The problem seems to be some false return code ordering in xhci_device_isoc_start(): if (sc->sc_bus.dying || xp->halted) return (USBD_IOERROR); /* Why would you

Re: usbd_abort_pipe(); usbd_close_pipe; dance

2020-07-31 Thread Marcus Glocker
On Fri, 31 Jul 2020 11:59:45 +0200 Gerhard Roth wrote: > Hi Marcus, > > On 2020-07-31 11:22, Marcus Glocker wrote: > > Maybe I'm missing something here. > > > > But is there any specific reason why the most of our USB drivers are > > calling usbd_abort_pi

usbd_abort_pipe(); usbd_close_pipe; dance

2020-07-31 Thread Marcus Glocker
Maybe I'm missing something here. But is there any specific reason why the most of our USB drivers are calling usbd_abort_pipe() right before usbd_close_pipe()? Since usbd_close_pipe() already will call usbd_abort_pipe() if the pipe isn't empty, as documented in the man page: DESCRIPTION

Re: Add ability to set control values with video(1)

2020-07-30 Thread Marcus Glocker
Hi Laurie, Thanks for testing and feedback! On Thu, 30 Jul 2020 08:07:56 +0100 Laurence Tratt wrote: > On Wed, Jul 29, 2020 at 10:52:31PM +0200, Marcus Glocker wrote: > > Hello Marcus, > > > Slightly adapted diff; Negative numbers can happen on controls. > > This

Re: Add ability to set control values with video(1)

2020-07-29 Thread Marcus Glocker
On Wed, 29 Jul 2020 07:45:52 +0200 Marcus Glocker wrote: > On Sat, 25 Jul 2020 18:27:45 +0100 > Laurence Tratt wrote: > > > On Sat, Jul 25, 2020 at 10:27:15AM -0600, Theo de Raadt wrote: > > > > Hello Theo, > > > > > My primary conce

Re: Add ability to set control values with video(1)

2020-07-28 Thread Marcus Glocker
On Sat, 25 Jul 2020 18:27:45 +0100 Laurence Tratt wrote: > On Sat, Jul 25, 2020 at 10:27:15AM -0600, Theo de Raadt wrote: > > Hello Theo, > > > My primary concern is about a user changing settings which then > > persist past close. > > > > Upon re-open, how do they know what mode they are in?

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-28 Thread Marcus Glocker
On Tue, 28 Jul 2020 11:42:43 +0200 Martin Pieuchot wrote: > On 26/07/20(Sun) 16:23, Marcus Glocker wrote: > > On Sun, 26 Jul 2020 13:27:34 + > > sc.dy...@gmail.com wrote: > > > > > On 2020/07/26 10:54, Marcus Glocker wrote: > > > > On Sat

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-26 Thread Marcus Glocker
On Sun, 26 Jul 2020 13:27:34 + sc.dy...@gmail.com wrote: > On 2020/07/26 10:54, Marcus Glocker wrote: > > On Sat, 25 Jul 2020 20:31:44 + > > sc.dy...@gmail.com wrote: > > > >> On 2020/07/25 18:10, Marcus Glocker wrote: > >>> On Su

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-26 Thread Marcus Glocker
On Sat, 25 Jul 2020 20:31:44 + sc.dy...@gmail.com wrote: > On 2020/07/25 18:10, Marcus Glocker wrote: > > On Sun, Jul 19, 2020 at 02:12:21PM +, sc.dy...@gmail.com wrote: > > > >> On 2020/07/19 11:25, Marcus Glocker wrote: > >>> On Sun, 19

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-25 Thread Marcus Glocker
On Sun, Jul 19, 2020 at 02:12:21PM +, sc.dy...@gmail.com wrote: > On 2020/07/19 11:25, Marcus Glocker wrote: > > On Sun, 19 Jul 2020 02:25:30 + > > sc.dy...@gmail.com wrote: > > > >> hi, > >> > >> It works on AMD Bolton xHCI (78141022),

Re: Add ability to set control values with video(1)

2020-07-25 Thread Marcus Glocker
On Sat, Jul 25, 2020 at 10:27:15AM -0600, Theo de Raadt wrote: > Matthieu Herrb wrote: > > > On Sat, Jul 25, 2020 at 09:17:24AM -0600, Theo de Raadt wrote: > > > Marcus Glocker wrote: > > > > > > > Instead of introducing the CLI parameter contro

Re: Add ability to set control values with video(1)

2020-07-24 Thread Marcus Glocker
On Fri, 24 Jul 2020 15:13:19 +0100 Laurence Tratt wrote: > On Thu, Jul 23, 2020 at 09:56:39PM +0200, Marcus Glocker wrote: > > Hello Marcus, > > > We read the current value of the white balance temperature auto > > control (since this gets set correctly during the re

Re: Add ability to set control values with video(1)

2020-07-23 Thread Marcus Glocker
Hi Laurie, On Thu, 23 Jul 2020 21:07:26 +0100 Laurence Tratt wrote: > On Thu, Jul 23, 2020 at 09:56:39PM +0200, Marcus Glocker wrote: > > Hello Marcus, > > > We read the current value of the white balance temperature auto > > control (since this gets set correctly dur

Re: Add ability to set control values with video(1)

2020-07-23 Thread Marcus Glocker
On Wed, 22 Jul 2020 21:52:27 +0100 Laurence Tratt wrote: > On Wed, Jul 22, 2020 at 10:23:19PM +0200, Marcus Glocker wrote: > > Hello Marcus, > > > I've tested this here as well in the meantime by leaving > > mmap_init() on its original location (doesn't get in

Re: Add ability to set control values with video(1)

2020-07-22 Thread Marcus Glocker
Hello Laurie, On Tue, 21 Jul 2020 21:18:15 +0100 Laurence Tratt wrote: > On Tue, Jul 21, 2020 at 09:01:26PM +0200, Marcus Glocker wrote: > > Hello Marcus, > > Thanks for the comments! Again, I agree with all of them with a > couple of comments: > > > I'm a bit c

  1   2   >