Re: vmd/vmctl load/reload/reset

On Wed, Oct 12, 2016 at 02:06:35PM +0200, Reyk Floeter wrote: > On Wed, Oct 12, 2016 at 01:44:25PM +0200, Reyk Floeter wrote: > > Hi, > > > > vmctl reload is currently broken, the attached diff fixes it and > > re-introduces the semantics that originally came from iked: > > > > - load/reload

Re: systat(1) hostname

On Wed, Oct 12, 2016 at 03:20:00PM +0200, Otto Moerbeek wrote: > simple diff to show the hostname on the second line. OK? OK bluhm@ > > BTW, batch mode doesn't function here as expected. Need to look into that, > > -Otto > > Index: main.c >

Re: let head(1) understand `-' as stdin

> > > The diff below makes head(1) recognize `-' > > > as a name for the standard input, > > > as many other utilities do. On Oct 11 23:55:26, schwa...@usta.de wrote: > > Do standards permit that extension? > > POSIX neither requires nor forbids it, but encourages consistency > among all the

/usr/src beforeinstall: make prereq as BUILDUSER

Several people noticed that a few files from libstdc++-v3 in /usr/obj end up being owned by root, namely: c++config.h gthr.h gthr-single.h gthr-posix.h gthr-tpf.h gthr-default.h The problem is that they are regenerated by root when beforeinstall does 'make includes' directly from

Re: let head(1) understand `-' as stdin

>> > > The diff below makes head(1) recognize `-' >> > > as a name for the standard input, >> > > as many other utilities do. > >On Oct 11 23:55:26, schwa...@usta.de wrote: >> > Do standards permit that extension? >> >> POSIX neither requires nor forbids it, but encourages consistency >> among

Re: let head(1) understand `-' as stdin

> Let me clarify the idea. > If a filter recognizes '-' as a name for stdin, > then stdin can be one of the _multiple_ files being processed. > Filters that do not recognize '-' as a name, on the other hand, > only process stdin if it is the _only_ input. I understand that - is convenient, but

Re: let head(1) understand `-' as stdin

On Oct 12 23:23:18, t...@math.ethz.ch wrote: > > Let me clarify the idea. > > If a filter recognizes '-' as a name for stdin, > > then stdin can be one of the _multiple_ files being processed. > > Filters that do not recognize '-' as a name, on the other hand, > > only process stdin if it is the

enforce zero options

Some programs in bin/ and usr.bin/ use the following idiom to make sure that there are no options present: while ((ch = getopt(argc, argv, "")) != -1) switch (ch) { case '?': default: usage();

vxlan payload fixup

After some additional consideration I think I can improve upon my previous diff. Pull-up of the Ethernet header can and should be made conditional: since an Ethernet header requires 2 byte alignment, any position within a real life mbuf is a valid one so unless there's not enough data in the

remove locale from logname(1)

Why does logname(1) need to setlocale? Jan Index: logname.c === RCS file: /cvs/src/usr.bin/logname/logname.c,v retrieving revision 1.9 diff -u -p -r1.9 logname.c --- logname.c 9 Oct 2015 01:37:08 - 1.9 +++

Re: hide iwn firmware error log

On Tue, Oct 11, 2016 at 11:32:27PM +0200, Jan Stary wrote: > On Oct 06 12:46:21, s...@stsp.name wrote: > > Disable the detailed fatal firmware error log in iwn(4) by default. > > These are my iwm errors of today > on a Dell Latitude E5570. > I sure don't know what to do with them, > but I'm glad

vmd/vmctl load/reload/reset

Hi, vmctl reload is currently broken, the attached diff fixes it and re-introduces the semantics that originally came from iked: - load/reload just reloads the configuration without clearing any running configuration. This way you can start vmd with a few configured vms, terminate one vm, and

Re: opencvs - use correct size when creating h_table

On Wed, Jun 22, 2016 at 12:23:38PM +0200, Joris Vink wrote: > Don't allocate the length of a pointer but rather the > entire size of the struct hash_head data structure > when creating the h_table array. > RCS file: /cvs/src/usr.bin/cvs/hash.c,v > > - htable->h_table = xcalloc(hsize,

switchd(8): add flow_mod validation

This diff teaches switchd(8) how to validate flow_mod messages, more specifically the flow instructions and actions. The oxm validations were already implemented so we get them for free here. ok? Index: sys/net/ofp.h === RCS file:

Re: vmd/vmctl load/reload/reset

On Wed, Oct 12, 2016 at 02:06:35PM +0200, Reyk Floeter wrote: > On Wed, Oct 12, 2016 at 01:44:25PM +0200, Reyk Floeter wrote: > > Hi, > > > > vmctl reload is currently broken, the attached diff fixes it and > > re-introduces the semantics that originally came from iked: > > > > - load/reload

Re: enforce zero options

On Oct 12 15:00:23, j...@wxcvbn.org wrote: > Jan Stary writes: > > > Some programs in bin/ and usr.bin/ use the following idiom > > to make sure that there are no options present: > > > > while ((ch = getopt(argc, argv, "")) != -1) > > switch (ch) { > >

Re: enforce zero options

On Wed, Oct 12, 2016 at 03:53:17PM +0200, Jan Stary wrote: > I don't get it: why do we need to handle -- > in utils which take no options and no arguments? Are you sure they will never handle options in the future? Joerg

Re: crontab(5): document -q flag in command

Ingo Schwarze writes: > Hi Jeremie, > > Jeremie Courreges-Anglas wrote on Wed, Oct 12, 2016 at 03:19:13PM +0200: >> Wouter Clarie writes: > >>> The -q flag for the command in a crontab(5) entry was introduced >>> in revision 1.8 of src/usr.sbin/cron/entry.c

Re: enforce zero options

Jan Stary writes: > Some programs in bin/ and usr.bin/ use the following idiom > to make sure that there are no options present: > > while ((ch = getopt(argc, argv, "")) != -1) > switch (ch) { > case '?': > default: >

Re: crontab(5): document -q flag in command

Hi Jeremie, Jeremie Courreges-Anglas wrote on Wed, Oct 12, 2016 at 03:19:13PM +0200: > Wouter Clarie writes: >> The -q flag for the command in a crontab(5) entry was introduced >> in revision 1.8 of src/usr.sbin/cron/entry.c back in 2001, >> but never documented. > Good

Re: vmd/vmctl load/reload/reset

On Wed, Oct 12, 2016 at 01:44:25PM +0200, Reyk Floeter wrote: > Hi, > > vmctl reload is currently broken, the attached diff fixes it and > re-introduces the semantics that originally came from iked: > > - load/reload just reloads the configuration without clearing any > running configuration.

switchd(8): implement the setconfig message

This diff teaches switchd(8) how to send the set_config message for OpenFlow 1.3.5. We need this to set the default miss_send_len to a value greater than zero so we can receive packets from the switch(4) with the payload. ok? Index: ofp13.c

Document ripd/ripctl -s

As noted by Sebastien Leclerc in http://marc.info/?l=openbsd-bugs=147560563030465=2 Copied almost verbatim from ospfd/ospfctl. ok? Index: usr.sbin/ripctl/ripctl.8 === RCS file: /d/cvs/src/usr.sbin/ripctl/ripctl.8,v retrieving

Re: cdce(4): Remove zaurus specific code

> Date: Tue, 11 Oct 2016 23:03:59 +0200 > From: Frederic Cambus > > On Fri, Oct 07, 2016 at 06:02:35PM +0200, Mark Kettenis wrote: > > > > It seems there are still some leftovers from the zaurus port removal. > > > > > > Comments? OK? > > > > Not ok. This is support for the

PING: Re: logname turd polish

Hi Ted, please just commit this patch you sent out back in July. The old, verbose style keeps confusing people, see for example Jan Stary's recent messages to tech@. I guess you just overlooked my OK. There was no opposition when you put this on tech@. Yours, Ingo Ingo Schwarze wrote on Fri,

Re: crontab(5): document -q flag in command

Wouter Clarie writes: > The -q flag for the command in a crontab(5) entry was introduced in revision > 1.8 of src/usr.sbin/cron/entry.c back in 2001, but never documented. Good catch. > (Sorry, I'm no hero with mdoc, so not sure if the markup is correct.) I'm no mdoc here

Fix bpf_catchpacket comment

This function doesn't return whether listeners should be woken up, it calls bpf_wakeup as needed. ok? Index: bpf.c === RCS file: /d/cvs/src/sys/net/bpf.c,v retrieving revision 1.149 diff -u -p -p -u -r1.149 bpf.c --- bpf.c

systat(1) hostname

Hi, simple diff to show the hostname on the second line. OK? BTW, batch mode doesn't function here as expected. Need to look into that, -Otto Index: main.c === RCS file: /cvs/src/usr.bin/systat/main.c,v retrieving

Re: let head(1) understand `-' as stdin

Ingo Schwarze writes: > Hi, > > Theo de Raadt wrote on Tue, Oct 11, 2016 at 01:35:34PM -0600: >> jca@ wrote: >>> Jan Stary writes: > The diff below makes head(1) recognize `-' as a name for the standard input, as many other utilities do. > >>>

Re: patch: netstat -P - mention allowkmem

On Tue, Oct 11, 2016 at 11:40:10PM -0400, David Hill wrote: > Hello - > > netstat -P now requires kern.allowkmem to be set. OK bluhm@ > > Index: netstat.1 > === > RCS file: /cvs/src/usr.bin/netstat/netstat.1,v > retrieving

Re: crontab(5): document -q flag in command

Whitespace between the -q and the command is optional, not required. - todd Index: crontab.5 === RCS file: /cvs/src/usr.sbin/cron/crontab.5,v retrieving revision 1.33 diff -u -p -u -r1.33 crontab.5 --- crontab.5 30 Jan 2014

Re: crontab(5): document -q flag in command

Hi Todd, Todd C. Miller wrote on Wed, Oct 12, 2016 at 10:06:07AM -0600: > Whitespace between the -q and the command is optional, not required. No, according to my reading of the code and my testing, it is required. The code say: case 'q': e->flags |= DONT_LOG;

tcpdump: decode Large BGP Communities

This patch adds support to tcpdump(8) to decode Large BGP Communities in human readable form. Example: [ snip ] BGP (UPDATE: (Path attributes: (ORIGIN[T] IGP) (AS_PATH[T] 65000) (NEXT_HOP[T] pxtr-2.meerval.net) (COMMUNITIES[OT] 666:666

Re: tcpdump: decode Large BGP Communities

On 2016/10/12 18:44, Job Snijders wrote: > This patch adds support to tcpdump(8) to decode Large BGP > Communities in human readable form. > > Example: > > [ snip ] BGP (UPDATE: (Path attributes: (ORIGIN[T] IGP) > (AS_PATH[T] 65000) > (NEXT_HOP[T]

Re: signify(1): make comments optional

Theo de Raadt: > You'll break other people's compatility without a thought. > > You only care about yourself. > > Yeah, that much is clear. Theo, your insults are pointless. But your concerns are not. I don't want to break anything. I think that if something is useful enough for others one can

Re: signify(1): make comments optional

> Theo de Raadt: > > You'll break other people's compatility without a thought. > > > > You only care about yourself. > > > > Yeah, that much is clear. > > Theo, your insults are pointless. But your concerns are not. > I don't want to break anything. I think that if something is useful > enough

Re: signify(1): make comments optional

Theo de Raadt: > Ivan, you bothered to write the diff and reply quite a few times, but > you waived all the concerns aside. This was just my opinion on this. Nothing less, nothing more. > Don't post diffs you don't want to defend. Should I defend? I posted it because I want to share. > You

Re: signify(1): make comments optional

Theo de Raadt: > That is why you are trying to push changes into an established > ecosystem, WITHOUT JUSTIFICATION. Your only justification was > "because I want to do so". Read this tread carefully and you'll see that I don't *push* anything. I don't consider one lonely patch on tech@ as

Re: signify(1): make comments optional

> > That is why you are trying to push changes into an established > > ecosystem, WITHOUT JUSTIFICATION. Your only justification was > > "because I want to do so". > > Read this tread carefully and you'll see that I don't *push* anything. I > don't consider one lonely patch on tech@ as pushing.

Re: signify(1): make comments optional

> > > That is why you are trying to push changes into an established > > > ecosystem, WITHOUT JUSTIFICATION. Your only justification was > > > "because I want to do so". > > > > Read this tread carefully and you'll see that I don't *push* anything. I > > don't consider one lonely patch on tech@

Re: crontab(5): document -q flag in command

Hi Todd, Todd C. Miller wrote on Wed, Oct 12, 2016 at 10:35:05AM -0600: > On Wed, 12 Oct 2016 18:32:42 +0200, Ingo Schwarze wrote: >> So, OK to commit my version? > OK, Committed, thanks for checking. > though that seems like a bug in the crontab parser. NetBSD has the same code and

Re: logname turd polish

Hi, Todd C. Miller wrote on Wed, Oct 12, 2016 at 09:57:07AM -0600: > On Wed, 12 Oct 2016 15:03:04 +0200, Ingo Schwarze wrote: >> please just commit this patch you sent out back in July. >> The old, verbose style keeps confusing people, >> see for example Jan Stary's recent messages to tech@. >>

Re: PING: Re: logname turd polish

On Wed, 12 Oct 2016 15:03:04 +0200, Ingo Schwarze wrote: > please just commit this patch you sent out back in July. > The old, verbose style keeps confusing people, > see for example Jan Stary's recent messages to tech@. > I guess you just overlooked my OK. > There was no opposition when you put

Re: /usr/src beforeinstall: make prereq as BUILDUSER

On Wed, Oct 12, 2016 at 10:30:26PM +0200, Theo Buehler wrote: > Several people noticed that a few files from libstdc++-v3 in /usr/obj > end up being owned by root, namely: > > c++config.h gthr.h gthr-single.h gthr-posix.h gthr-tpf.h gthr-default.h > > The problem is that they are regenerated by

Re: systat(1) hostname

Theo de Raadt wrote: > > On Wed, Oct 12, 2016 at 03:20:00PM +0200, Otto Moerbeek wrote: > > > simple diff to show the hostname on the second line. OK? > > > > OK bluhm@ > > > > > > > > BTW, batch mode doesn't function here as expected. Need to look into that, > > I hoped this would look more