Update stale comment in

2020-05-20 Thread Visa Hankala
The header contains an outdated comment about headers and and should be updated. The comment is not fully consistent with the syslog(3) manual page because the manual does mention . However, the header's point still seems valid. OK? Index: sys/syslog.h

{plus,}67.html: fix link crontab(5)

2020-05-20 Thread Martin Vahlensieck
Hey there! Otherwise it's going to crontab(1). Best, Martin Index: 67.html === RCS file: /cvs/www/67.html,v retrieving revision 1.77 diff -u -p -r1.77 67.html --- 67.html 19 May 2020 18:21:41 - 1.77 +++ 67.html 20

opensmtpd: properly use getsockname and getpeername

2020-05-20 Thread Leah Neukirchen
Hi, in src/usr.sbin/smtpd/mta_session.c 1.124 two bugs are introduced: - getsockname/getpeername are passed a struct sockaddr, too small to hold an IPv6 address. - sa_len is uninitialized. Detected thanks to -fstack-protector on Void Linux, which killed it immediately after connecting to the

Remove references to lang/node from port-modules(5)

2020-05-20 Thread Fabian Müller-Knapp
As node.port.mk is long gone, this patch removes references to lang/node from port-modules(5) revision 1.5 date: 2015/10/24 02:46:47; author: abieber; state: dead; lines: +1 -1; commitid: ed5E7Ght7haAuPfD; Finally update node to the latest version, lots of

fix pppx(4) with net/ifq.c rev 1.38

2020-05-20 Thread Vitaliy Makkoveev
I got splassert with pppx(4) and net/ifq.c rev 1.38 raised by NET_ASSERT_LOCKED() in netinet/ip_output.c:113 and underlaying routines. net/ifq.c rev 1.38 is not in snapshot yet so you need to checkout and build kernel to reproduce. dmesg begin splassert: ip_output: want 2 have 0

Re: /etc/netstart fails with apostrophes in SSIDs set up at install time

2020-05-20 Thread Klemens Nanni
On Mon, May 04, 2020 at 06:34:51PM +0200, Klemens Nanni wrote: > On Mon, May 04, 2020 at 06:24:49PM +0200, Klemens Nanni wrote: > > On Mon, May 04, 2020 at 05:49:26PM +0300, bsdlis...@gmail.com wrote: > > > Say I have a SSID like "Mike's". If I set it up at install time, at the > > > first boot

Diff for www:FAQ4

2020-05-20 Thread bsd
Hi, Here a diff for www page: FAQ4 Do you accept to modify this FAQ4 to add the SHA256 URL? Right? Index: faq/faq4.html === RCS file: /cvs/www/faq/faq4.html,v retrieving revision 1.535 diff -u -r1.535 faq4.html ---

Re: Add CAVEATS to ldom.conf(5) man page

2020-05-20 Thread Ingo Schwarze
Hi Jason, Jason McIntyre wrote on Wed, May 20, 2020 at 06:38:18AM +0100: > i'm fine with the text, but does it really warrant a CAVEATS section? it > sounds like it should just be part of "this is how it works" text. I may not be the best person to judge this, but as far as i understand, this

Re: vldcp(4/sparc64), magma(4) and spif(4) kqfilter

2020-05-20 Thread Martin Pieuchot
On 20/05/20(Wed) 12:18, Mark Kettenis wrote: > > Date: Wed, 20 May 2020 11:33:24 +0200 > > From: Martin Pieuchot > > > > Diff below implements kqfilter for the 3 remaining drivers in the tree, > > that I could find, supporting poll(2) but not kqueue(2). > > > > magma(4) and spif(4) call

Re: Add CAVEATS to ldom.conf(5) man page

2020-05-20 Thread Klemens Nanni
On Wed, May 20, 2020 at 02:01:34PM +0200, Ingo Schwarze wrote: > Now, maybe, some manual page somewhere might say something like > "this program uses .Pa /dev/ldom* device nodes (or .Xr ldom 4 devices) > to do foobar; make sure you have enough of those". Judging from > commands like > >$ man

Re: Add CAVEATS to ldom.conf(5) man page

2020-05-20 Thread Theo de Raadt
Kurt Mosiejczuk wrote: > I suppose we could look at having ldomctl throw a warning if there are not > enough ldom and ttyV devices for the configuration file presented. Maybe it can test access to the required resources as it starts up.

Re: Removing old video drivers

2020-05-20 Thread Dirk Praet
OpenBSD's model and philosophy match both my requirements and expectations perfectly, Theo. I'm just not too fond of stuff unexpectedly breaking - admittedly because I missed out on this specific thread -, but for which Stuart's tip is an excellent mitigation indeed. Kind regards, Dirk --

Re: Add CAVEATS to ldom.conf(5) man page

2020-05-20 Thread Kurt Mosiejczuk
On Wed, May 20, 2020 at 09:24:20AM -0600, Theo de Raadt wrote: > Kurt Mosiejczuk wrote: > > > Seems reasonable, what about adopting vmd(8) CAVEATS for ldomd(8)? > > > Running out of devices with more guests can be nasty do debug. > > Here's an attempt at doing that. There isn't a man page for

Re: Add CAVEATS to ldom.conf(5) man page

2020-05-20 Thread Kurt Mosiejczuk
On Wed, May 20, 2020 at 09:35:39AM -0600, Theo de Raadt wrote: > Kurt Mosiejczuk wrote: > > I suppose we could look at having ldomctl throw a warning if there are not > > enough ldom and ttyV devices for the configuration file presented. > Maybe it can test access to the required resources as

Re: Block device poll(2) vs kqueue(2)

2020-05-20 Thread Martin Pieuchot
On 20/05/20(Wed) 12:28, Mark Kettenis wrote: > > Date: Wed, 20 May 2020 11:42:32 +0200 > > From: Martin Pieuchot > > > > Diff below fixes an incoherency between poll(2) and kqueue(2) when it > > comes to non-character devices. It makes spec_kqfilter() behaves like > > spec_poll(): returns

diff: uvm: fix unitialized var and simplify code in km_alloc()

2020-05-20 Thread Jan Klemkow
Hi, The function km_alloc() returns the uninitialized local variable sva if pgl is empty. It seems to be not possible in the current condition of the code, but I'm not sure if this is guaranteed. Thus, I would prefer to initialize sva with zero. It also seems to be unnecessary to loop over the

Re: Add CAVEATS to ldom.conf(5) man page

2020-05-20 Thread Theo de Raadt
Kurt Mosiejczuk wrote: > On Mon, May 18, 2020 at 08:12:00PM +0200, Klemens Nanni wrote: > > On Mon, May 18, 2020 at 01:20:07PM -0400, Kurt Mosiejczuk wrote: > > > Learning how LDOMs work on this T4-1 and we only create 8 devices > > > (each /dev/ldom* and /dev/ttyV*) by default. The

httpd diff (fixes single instance of XHTML-style element)

2020-05-20 Thread Andras Farkas
Hello! Today I noticed, when looking at an autoindex page on my own website, that despite the page being HTML (as evidenced by being used rather than further down, and also by the page being served as text/html) there was a single instance of an XHTML-style element: Notice the second to last

Re: iked(8): AES_GCM ciphers for IKE

2020-05-20 Thread Remi Locherer
On Fri, May 15, 2020 at 01:59:35AM +0200, Tobias Heider wrote: > On Thu, May 14, 2020 at 10:47:52PM +0200, Tobias Heider wrote: > > On Thu, May 14, 2020 at 10:07:30PM +0200, Tobias Heider wrote: > > > Hi, > > > > > > currently iked(8) supports AES-GCM only for ESP. > > > The diff below adds the

Re: Block device poll(2) vs kqueue(2)

2020-05-20 Thread Christian Weisgerber
On 2020-05-20, Martin Pieuchot wrote: > - FreeBSD doesn't allow opening block devices in devfs_open(), so > only character devices seem to support poll(2) and kqueue(2). FreeBSD doesn't have block devices anymore. -- Christian "naddy" Weisgerber

[PATCH] wsconsctl mouse.scaling

2020-05-20 Thread johnc
Ulf pointed out that you could scale the mouse speed with the cryptic: wsconsctl mouse.param=0:401,1:401 Looking into it more, wsconsctl already has a floating point version of this that sets both X and Y values, but it only shows up and functions if you have a touchpad, not a mouse: wsconsctl

Re: [PATCH] pipex(4): rework PPP input

2020-05-20 Thread Vitaliy Makkoveev
On Wed, May 20, 2020 at 04:08:01AM +0300, Sergey Ryazanov wrote: > 2 Hi Vitaliy, > > On Tue, May 19, 2020 at 12:11 PM Vitaliy Makkoveev > wrote: > > On Mon, May 04, 2020 at 10:03:40PM +0300, Sergey Ryazanov wrote: > > > Split checks from frame accepting with header removing in the common > > >

Re: Correcty reloading unresolved host in syslogd @Conf lines

2020-05-20 Thread sven falempin
On Mon, May 18, 2020 at 5:31 AM Alexander Bluhm wrote: > On Sat, May 16, 2020 at 07:23:37PM -0400, sven falempin wrote: > > This was looked at before. > > Did not get through. > > The posted diff was not my final solution. But yes, the issue was > forgotten. So I would suggest this. > > When

Re: httpd diff (fixes single instance of XHTML-style element)

2020-05-20 Thread Anthony J. Bentley
Hi Andras, Andras Farkas writes: > Today I noticed, when looking at an autoindex page on my own website, > that despite the page being HTML (as evidenced by being used > rather than further down, and also by the page being served as > text/html) there was a single instance of an XHTML-style

include interface name in rad error message

2020-05-20 Thread Claudio Jeker
In my syslog I have this: rad[83563]: RA from non link local address :: now it would be splendid to know on which of the 4 interfaces rad is operating on this happened. So here is a diff doing that. -- :wq Claudio Index: engine.c

Re: pppx(4): avoid direct usage of pxi owned session.

2020-05-20 Thread Martin Pieuchot
On 14/05/20(Thu) 15:53, Vitaliy Makkoveev wrote: > Each `struct pppx_if' holds it's own `pipex_session' and this session is > used directly within ifnet's related handlers pppx_if_start() and > pppx_if_output(). I don't see a problem with keeping a reference on a pipex_session inside the softc.

vldcp(4/sparc64), magma(4) and spif(4) kqfilter

2020-05-20 Thread Martin Pieuchot
Diff below implements kqfilter for the 3 remaining drivers in the tree, that I could find, supporting poll(2) but not kqueue(2). magma(4) and spif(4) call seltrue() so their diff is trivial. This change is required to be able to switch poll(2) and select(2) to use the *kqfilter() handlers on

MFS & kqfilter

2020-05-20 Thread Martin Pieuchot
When it comes to MFS, most of the declared `vop_*' functions are never called. This is due to the fact that the corresponding FFS functions are used instead. So the diff below explicitly documents that `vop_kqfilter' isn't missing and is instead not used, just like `vop_poll'. Ok? Index:

pty(4) ICANON kqueue fix

2020-05-20 Thread Martin Pieuchot
One of the conditions checked by ptcpoll() in order to determine if writing is possible is missing from the equivalent kqueue filter. Diff below fixes that, ok? Index: kern/tty_pty.c === RCS file: /cvs/src/sys/kern/tty_pty.c,v

Re: vldcp(4/sparc64), magma(4) and spif(4) kqfilter

2020-05-20 Thread Mark Kettenis
> Date: Wed, 20 May 2020 11:33:24 +0200 > From: Martin Pieuchot > > Diff below implements kqfilter for the 3 remaining drivers in the tree, > that I could find, supporting poll(2) but not kqueue(2). > > magma(4) and spif(4) call seltrue() so their diff is trivial. > > This change is required

Block device poll(2) vs kqueue(2)

2020-05-20 Thread Martin Pieuchot
Diff below fixes an incoherency between poll(2) and kqueue(2) when it comes to non-character devices. It makes spec_kqfilter() behaves like spec_poll(): returns "true" when applied to any non-character device. ok? Index: kern/spec_vnops.c

Kill czttypoll()

2020-05-20 Thread Martin Pieuchot
Kill commented out poll routine, ok? Index: dev/pci/cz.c === RCS file: /cvs/src/sys/dev/pci/cz.c,v retrieving revision 1.23 diff -u -p -r1.23 cz.c --- dev/pci/cz.c11 Mar 2020 15:51:15 - 1.23 +++ dev/pci/cz.c

Re: include interface name in rad error message

2020-05-20 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.05.20 09:12:23 +0200: > In my syslog I have this: > rad[83563]: RA from non link local address :: > now it would be splendid to know on which of the 4 interfaces rad is > operating on this happened. So here is a diff doing that. ok > > -- >

Re: Block device poll(2) vs kqueue(2)

2020-05-20 Thread Mark Kettenis
> Date: Wed, 20 May 2020 11:42:32 +0200 > From: Martin Pieuchot > > Diff below fixes an incoherency between poll(2) and kqueue(2) when it > comes to non-character devices. It makes spec_kqfilter() behaves like > spec_poll(): returns "true" when applied to any non-character device. > > ok?