Re: ping graphical display

2021-02-20 Thread Remi Locherer
On February 19, 2021 8:56:31 PM UTC, Stuart Henderson wrote: >Canvassing opinions on having . and ! this way around. I'm using . for >response, ! for no response, which makes more sense to me but it's been >pointed out that it's the opposite of what cisco does so it might >confuse >some people.

fix ospf6d.conf example

2021-03-26 Thread Remi Locherer
Hi, danj@ noticed that our ospf6d.conf example is using multiple areas. In the man page of ospf6d we state that multi area support is not available. The daemon accepts such a config but does not do the right thing if I remember correctly. OK to change the example to use just one area? Remi Inde

syslog regress and libressl

2020-03-04 Thread Remi Locherer
I noticed that some regress test fail since February 7: - run-args-server-tls-reconnect.pl - run-args-server-tls-tcp.pl - run-args-tls-cipher-null.pl (http://bluhm.genua.de/regress/results/regress-ot6.html) It is related to changes in LibreSSL. Is this intended? Should the regress tests be adapt

Re: ospf6d: bring ospf6d closer to ospfd

2020-03-28 Thread Remi Locherer
On Sat, Mar 21, 2020 at 05:25:45PM +0100, Denis Fondras wrote: > Biggest chunk is rework of rde_asext_get()/rde_asext_put(). > Also change get_net_link() and get_rtr_link() to work like ospfd couterpart. Reads good to me and I didn't spot any issues running tests with it. One question: why "if 0"

Re: ospf6d: update to connected routes

2020-04-05 Thread Remi Locherer
On Wed, Apr 01, 2020 at 08:50:45PM +0200, Denis Fondras wrote: > Handle connected routes as ospfd(8) does. > > (diff to ospf6d and ospf6ctl) OK remi@ > > Index: ospf6ctl/ospf6ctl.c > === > RCS file: /cvs/src/usr.sbin/ospf6ctl/ospf6

tcpdump: print nhrp packets

2020-04-13 Thread Remi Locherer
286 @@ +/* $OpenBSD:$ */ + +/* + * Copyright (c) 2020 Remi Locherer + * + * Permission to use, copy, modify, and distribute this software for any + * purpose with or without fee is hereby granted, provided that the above + * copyright notice and this permission notice appear in all copies. + *

Re: tcpdump: print nhrp packets

2020-04-14 Thread Remi Locherer
On Tue, Apr 14, 2020 at 01:49:32PM +1000, David Gwynne wrote: > > > > On 13 Apr 2020, at 19:03, Remi Locherer wrote: > > > > Hi, > > > > I recently looked into NHRP (RFC 2332) and noticed that our tcpdump does > > not have a printer for

Re: ospf6d: remove IMSG_IFADD

2020-05-16 Thread Remi Locherer
On Thu, May 14, 2020 at 04:10:42PM +0200, Denis Fondras wrote: > IMSG_IFADD is never used, wipe it. In ospfd we have IMSG_RECONF_IFACE for this. Once we start adding reload functionality we can bring that over to ospf6d. OK remi@ > > Index: ospf6d.h > ===

Re: ospf6d: remove IMSG_IFDELETE

2020-05-16 Thread Remi Locherer
On Thu, May 14, 2020 at 08:10:55PM +0200, Denis Fondras wrote: > Following https://marc.info/?l=openbsd-tech&m=158946552515632&w=2, when > IMSG_IFADD is removed, IMSG_IFDELETE becomes useless... OK remi@ > > Index: kroute.c > === >

Re: ospf6d: remove F_IFACE_AVAIL

2020-05-17 Thread Remi Locherer
On Sat, May 16, 2020 at 08:17:28PM +0200, Denis Fondras wrote: > This information is never used/checked. > ok remi@ > Index: kroute.c > === > RCS file: /cvs/src/usr.sbin/ospf6d/kroute.c,v > retrieving revision 1.63 > diff -u -p -r1.

Re: mcx(4) checksum offload

2020-05-19 Thread Remi Locherer
On Tue, May 19, 2020 at 08:48:17AM +1000, Jonathan Matthew wrote: > So far I've completely ignored offloads in the ethernet drivers I've > written, but on having a quick look at the documentation I found that > mcx(4) checksum offload is extremely easy to use, and some simple testing > suggests tha

Re: iked(8): AES_GCM ciphers for IKE

2020-05-20 Thread Remi Locherer
On Fri, May 15, 2020 at 01:59:35AM +0200, Tobias Heider wrote: > On Thu, May 14, 2020 at 10:47:52PM +0200, Tobias Heider wrote: > > On Thu, May 14, 2020 at 10:07:30PM +0200, Tobias Heider wrote: > > > Hi, > > > > > > currently iked(8) supports AES-GCM only for ESP. > > > The diff below adds the EN

Re: ospf6d: change the way interfaces are handled

2020-06-03 Thread Remi Locherer
On Sat, May 30, 2020 at 04:37:43PM +0200, Denis Fondras wrote: > This diff updates how ospf6d(8) handles interfaces. > It is now in line with what ospfd(8) does. > > Last step before enabling reload. > > Tested against Mikrotik and Zebra implementations. > > Warning: it changes the default behav

netstat -R: list rdomains with associated ifs and tables

2020-06-08 Thread Remi Locherer
Hi, to my knowledge there is no easy way to list all active rdomains or routing tables. Other platforms have "show vrf" or similar commands for an overview. Here is my attempt at such a view for OpenBSD: twister ..in/netstat$ obj/netstat -R Rdomain 0 Interfaces: lo0 iwm0 re0 enc0 pflog0 Ro

Re: netstat -R: list rdomains with associated ifs and tables

2020-06-08 Thread Remi Locherer
On Mon, Jun 08, 2020 at 10:10:17PM +0200, Remi Locherer wrote: > Hi, > > to my knowledge there is no easy way to list all active rdomains or > routing tables. Other platforms have "show vrf" or similar commands > for an overview. > > Here is my attempt at such a

Re: netstat -R: list rdomains with associated ifs and tables

2020-06-09 Thread Remi Locherer
On Tue, Jun 09, 2020 at 09:17:31AM +0200, Claudio Jeker wrote: > On Tue, Jun 09, 2020 at 08:44:42AM +0200, Remi Locherer wrote: > > On Mon, Jun 08, 2020 at 10:10:17PM +0200, Remi Locherer wrote: > > > Hi, > > > > > > to my knowledge there is no eas

Re: netstat -R: list rdomains with associated ifs and tables

2020-06-10 Thread Remi Locherer
On Tue, Jun 09, 2020 at 10:02:06AM +0200, Remi Locherer wrote: > On Tue, Jun 09, 2020 at 09:17:31AM +0200, Claudio Jeker wrote: > > On Tue, Jun 09, 2020 at 08:44:42AM +0200, Remi Locherer wrote: > > > On Mon, Jun 08, 2020 at 10:10:17PM +0200, Remi Locherer wrote: > > > &

Re: netstat -R: list rdomains with associated ifs and tables

2020-06-11 Thread Remi Locherer
On Wed, Jun 10, 2020 at 11:44:17PM +0100, Stuart Henderson wrote: > It's useful information, I like it. (I preferred it with the route > count, but I agree, it's hard on the system if there's a full DFZ > table). > > One thing though - > > > twister ..in/netstat$ obj/netstat -R > > Rdomain 0 > >

Re: netstat -R: list rdomains with associated ifs and tables

2020-06-11 Thread Remi Locherer
On Wed, Jun 10, 2020 at 11:47:49PM +0200, Sebastian Benoit wrote: > Remi Locherer(remi.loche...@relo.ch) on 2020.06.10 22:16:36 +0200: > > On Tue, Jun 09, 2020 at 10:02:06AM +0200, Remi Locherer wrote: > > > On Tue, Jun 09, 2020 at 09:17:31AM +0200, Claudio Jeker wrote: >

Re: ldpd engine process exits with pledge "cpath"

2020-06-20 Thread Remi Locherer
On Fri, Jun 19, 2020 at 02:43:00PM +0100, Ricardo Mestre wrote: > mea culpa, but I'd rather just remove the unlink of the socket. > > OK? Diff reads OK to me. We had the same discussion in 2018 for ripd: https://marc.info/?l=openbsd-tech&m=154101413029926&w=2 Note to self: ospfd should get the

Re: wg(4) ipv6 ospf6d

2021-08-26 Thread Remi Locherer
On Wed, Aug 25, 2021 at 10:29:36PM +0100, Stuart Henderson wrote: > On 2021/08/25 13:33, Daniel Jakots wrote: > > On Wed, 25 Aug 2021 18:02:11 +0100, Stuart Henderson > > wrote: > > > > > If I manually configure a link-local the interface is successfully > > > added. > > > > > > Anyone have an i

Re: ospf6d: depend on

2018-07-11 Thread Remi Locherer
On Wed, Jul 11, 2018 at 02:59:30PM +0200, Florian Riehm wrote: > Hi, > > successfully tested. I like the feature! Thanks! > Some (mostly cosmetic) comments inline. I fixed them. Updated diff below. > Index: ospfe.c > === > RCS fil

ospf6d: add support for rdomains

2018-07-11 Thread Remi Locherer
Hi, This adds rdomain support to ospf6d. It works the same as in ospfd. OK? Remi Index: ospf6ctl/ospf6ctl.c === RCS file: /cvs/src/usr.sbin/ospf6ctl/ospf6ctl.c,v retrieving revision 1.48 diff -u -p -r1.48 ospf6ctl.c --- ospf6ctl/o

Re: LACP Administrative Knobs

2018-08-10 Thread Remi Locherer
On 2018-08-09 03:53, Carlos Cardenas wrote: On Mon, Aug 06, 2018 at 08:18:23PM -0700, Carlos Cardenas wrote: Howdy. Attached is a patch from my work that started at g2k18 on adding administrative knobs to our LACP driver. The driver now has a new ioctl (SIOCxTRUNKOPTS), which for now only has

ospfd: prevent additional ospfd from starting

2018-08-21 Thread Remi Locherer
Hi tech, recently we had a short outage in our network. A script started an additional ospfd instance because the -n flag for config test was missing. What then happend was not nice: - The new ospfd unlinked the control socket of the first ospfd - The new ospfd removed all routes from the first o

Re: ospfd: prevent additional ospfd from starting

2018-08-21 Thread Remi Locherer
On Tue, Aug 21, 2018 at 05:54:18PM +0100, Stuart Henderson wrote: > On 2018/08/21 17:16, Remi Locherer wrote: > > Hi tech, > > > > recently we had a short outage in our network. A script started an > > additional > > ospfd instance because the -n flag for config

Re: ospfd: prevent additional ospfd from starting

2018-08-24 Thread Remi Locherer
On Fri, Aug 24, 2018 at 08:58:12AM +0200, Claudio Jeker wrote: > On Wed, Aug 22, 2018 at 12:12:10AM +0200, Remi Locherer wrote: > > On Tue, Aug 21, 2018 at 05:54:18PM +0100, Stuart Henderson wrote: > > > On 2018/08/21 17:16, Remi Locherer wrote: > > > > Hi tech, >

Re: ospfd: prevent additional ospfd from starting

2018-08-27 Thread Remi Locherer
On Fri, Aug 24, 2018 at 12:21:31PM +0200, Remi Locherer wrote: > On Fri, Aug 24, 2018 at 08:58:12AM +0200, Claudio Jeker wrote: > > On Wed, Aug 22, 2018 at 12:12:10AM +0200, Remi Locherer wrote: > > > On Tue, Aug 21, 2018 at 05:54:18PM +0100, Stuart Henderson wrote: > >

Re: ospfd: prevent additional ospfd from starting

2018-08-28 Thread Remi Locherer
On Tue, Aug 28, 2018 at 07:56:43AM +0200, Claudio Jeker wrote: > On Mon, Aug 27, 2018 at 11:33:19PM +0200, Remi Locherer wrote: > > On Fri, Aug 24, 2018 at 12:21:31PM +0200, Remi Locherer wrote: > > > On Fri, Aug 24, 2018 at 08:58:12AM +0200, Claudio Jeker wrote: [ snip ] >

ospf6d: prevent additional ospf6d from starting

2018-08-31 Thread Remi Locherer
Hi, this is the adaption of the recent ospfd commit to ospf6d. Early in the startup the main process checks if another process is listening on the control socket and exits if that is the case. Otherwise the master process opens the control socket and passes it on to the ospf engine. OK? Remi

ospfd: pledge parent process

2018-09-01 Thread Remi Locherer
Hi, Since slaacd is able to use pledge in the parent process I thought it may be possible for ospfd too. It works fine until ospfd gets reloaded. At this point it uses setsockopt to set the priority filter on the routing socket. Since I could not find a promise for this I extended wroute. Does t

Re: ospfd: pledge parent process

2018-09-01 Thread Remi Locherer
On Sat, Sep 01, 2018 at 10:38:09PM +0200, Sebastian Benoit wrote: > Remi Locherer(remi.loche...@relo.ch) on 2018.09.01 21:53:21 +0200: > > Hi, > > > > Since slaacd is able to use pledge in the parent process I thought it may > > be possible for ospfd too. > > &

Re: ospfd: pledge parent process

2018-09-02 Thread Remi Locherer
On Sun, Sep 02, 2018 at 08:05:55AM +0200, Remi Locherer wrote: > On Sat, Sep 01, 2018 at 10:38:09PM +0200, Sebastian Benoit wrote: > > Remi Locherer(remi.loche...@relo.ch) on 2018.09.01 21:53:21 +0200: > > > Hi, > > > > > > Since slaacd is able to use pledge in

Re: ospfd: pledge parent process

2018-09-02 Thread Remi Locherer
On Sat, Sep 01, 2018 at 10:38:09PM +0200, Sebastian Benoit wrote: > Remi Locherer(remi.loche...@relo.ch) on 2018.09.01 21:53:21 +0200: > > Hi, > > > > Since slaacd is able to use pledge in the parent process I thought it may > > be possible for ospfd too. > > &

Re: OpenBGPd Feature Request / Question if the Feature Request

2018-09-22 Thread Remi Locherer
On Sat, Sep 22, 2018 at 08:22:52AM +0100, Tom Smyth wrote: > OpenBGPd Feature Request / Question if the Feature Request > is something the community would use ? > > Background, > Ideally we would run full tables so that we have visibility > on reachibility of a prefix via a transit provider, > >

unveil ospfd's parent proc

2018-10-26 Thread Remi Locherer
Hi, this restricts ospfd's parent process to only read it's config file (reload) and unlink the control socket on exit. I added unveil after the setup of the control socket is done since chmod is used in control_init. OK? Remi Index: ospfd.c

Re: unveil ospfd's parent proc

2018-10-26 Thread Remi Locherer
2018 5:26:06 PM GMT+02:00, Remi Locherer > wrote: > >Hi, > > > >this restricts ospfd's parent process to only read it's config file > >(reload) > >and unlink the control socket on exit. I added unveil after the setup > >of > >the contr

Re: unveil ospfd's parent proc

2018-10-27 Thread Remi Locherer
On Fri, Oct 26, 2018 at 10:19:01AM -0600, Theo de Raadt wrote: > Remi Locherer wrote: > > > On Fri, Oct 26, 2018 at 06:01:40PM +0200, Florian Obser wrote: > > > This breaks usage of the "include" keyword. Something that all the > > > parse.y daemon

Re: unveil ospfd's parent proc

2018-10-28 Thread Remi Locherer
!= NULL) { > SIMPLEQ_REMOVE_HEAD(&ospfd_conf->redist_list, entry); > free(r); > > On 15:58 Sun 28 Oct , Florian Obser wrote: > > Sorry, I'm on a phone. The diff context looks like the control FD is > > already open at this point

Re: unveil ospfd's parent proc

2018-10-28 Thread Remi Locherer
gt; event_dispatch(); > > > > ospfd_shutdown(); > > @@ -308,7 +313,6 @@ ospfd_shutdown(void) > > msgbuf_clear(&iev_rde->ibuf.w); > > close(iev_rde->ibuf.fd); > > > > - control_cleanup(ospfd_conf->csock); > > whi

Re: unveil ospfd's parent proc

2018-10-28 Thread Remi Locherer
2018 11:25:58 PM GMT+02:00, Remi Locherer > wrote: > >On Fri, Oct 26, 2018 at 10:19:01AM -0600, Theo de Raadt wrote: > >> Remi Locherer wrote: > >> > >> > On Fri, Oct 26, 2018 at 06:01:40PM +0200, Florian Obser wrote: > >> > > This breaks us

unveil ospf6d's parent proc

2018-10-29 Thread Remi Locherer
Hi, ospf6d does not support reloading so its parent proc does not need filesystem access with the exception of the control socket cleanup on exit. Once we teach it how to reload the config it is easy to unveil "/" readonly as I just did for ospfd. OK? Remi cvs diff: Diffing . Index: ospf6d.c =

Re: disable fs access on ripd

2018-10-30 Thread Remi Locherer
On Tue, Oct 30, 2018 at 03:20:35PM +, Ricardo Mestre wrote: > Hi, > > After all files are opened ripd(8) can have the fs access disabled just before > each process main loop. Its 2 childs already run under chroot, but since they > are still not pledged at least they have no way to read/write/c

Re: disable fs access on ripd

2018-10-30 Thread Remi Locherer
On Tue, Oct 30, 2018 at 10:54:10AM -0600, Theo de Raadt wrote: > Remi Locherer wrote: > > > On Tue, Oct 30, 2018 at 03:20:35PM +, Ricardo Mestre wrote: > > > Hi, > > > > > > After all files are opened ripd(8) can have the fs access disabled just &g

Re: disable fs access on ripd

2018-11-03 Thread Remi Locherer
On Tue, Oct 30, 2018 at 05:31:04PM +, Ricardo Mestre wrote: > clearly an oversight due to looking at too many daemons at the same > time. since the only thing ripd needs to do is unlink the socket I think > we can remove control_cleanup, even though I'd rather do this > introducing pledge, but

Re: unveil dhclient (privileged process)

2018-11-05 Thread Remi Locherer
On Mon, Nov 05, 2018 at 12:30:08PM +, Ricardo Mestre wrote: > Hi, > > dhclient(8)'s privileged process cannot be pledged yet due to some route > related sysctl(2)'s, but it seems it only needs to access two files. One is > /etc/resolv.conf with write/create permissions and saved_argv[0] (usual

ripd.conf man page fix

2018-11-10 Thread Remi Locherer
Hi, the default for triggered-updates is no. OK? Remi cvs diff: Diffing . Index: ripd.conf.5 === RCS file: /cvs/src/usr.sbin/ripd/ripd.conf.5,v retrieving revision 1.15 diff -u -p -r1.15 ripd.conf.5 --- ripd.conf.5 18 Jun 2018 06:

ripd.conf: allow interface without { }

2018-11-10 Thread Remi Locherer
Hi, ripd wants curly braces for interface blocks even if no parameters are specified. This is inconsistent with other daemons and a bit annoying. Below diff makes ripd accepting interface if0 without { } afterwards. The example in the man page shows the interface statement with and withou

Re: ripd.conf: allow interface without { }

2018-11-11 Thread Remi Locherer
On Sun, Nov 11, 2018 at 09:48:38AM +0100, Claudio Jeker wrote: > On Sat, Nov 10, 2018 at 09:17:57PM +0100, Remi Locherer wrote: > > Hi, > > > > ripd wants curly braces for interface blocks even if no parameters are > > specified. This is inconsistent with other

prevent bgpd from starting when control socket already used

2018-11-11 Thread Remi Locherer
Hi, I heard from two devs that started a 2nd bgpd by accident (forgot -n for a config check) which then caused downtime. Below diff adds a check to bgpd similar to the one we have now in ospfd and ospf6d: if another process is listening on the control socket bgpd exits. The situation is a bit di

Re: prevent bgpd from starting when control socket already used

2018-11-12 Thread Remi Locherer
On Mon, Nov 12, 2018 at 08:12:37AM +0100, Claudio Jeker wrote: > On Sun, Nov 11, 2018 at 04:40:54PM -0700, Theo de Raadt wrote: > > Makes sense to me, I suppose. > > > > Isn't another approach to swap the opening of the sockets? > > > > Or why does failure to control :179 sockets not stop startup

Re: prevent bgpd from starting when control socket already used

2018-11-18 Thread Remi Locherer
Hi, from the discussion I understand nobody rejects the functionality. To ease the review here again the diff (with incorporated feedback from anton@ (redundant parens)). Any comments or OKs? Remi cvs diff: Diffing . Index: bgpd.c ==

Re: prevent bgpd from starting when control socket already used

2018-11-19 Thread Remi Locherer
On Mon, Nov 19, 2018 at 09:45:55AM +0100, Claudio Jeker wrote: > On Sun, Nov 18, 2018 at 11:40:40PM +0100, Remi Locherer wrote: > > Hi, > > > > from the discussion I understand nobody rejects the functionality. > > > > To ease the review here again the diff

Re: be more strict when parsing netmasks for IPv6

2018-12-05 Thread Remi Locherer
On Wed, Dec 05, 2018 at 09:22:22AM +0100, Claudio Jeker wrote: > When parsing a network mask into prefixlen be more paranoid and make sure > no value bigger then 128 is returned. In general this should never happen > but if it does the result can be bad. > > This is for bgpd but there are other us

Re: be more strict when parsing netmasks for IPv6

2018-12-06 Thread Remi Locherer
On Thu, Dec 06, 2018 at 03:24:52PM +0100, Claudio Jeker wrote: > On Wed, Dec 05, 2018 at 11:53:48PM +0100, Remi Locherer wrote: > > On Wed, Dec 05, 2018 at 09:22:22AM +0100, Claudio Jeker wrote: > > > When parsing a network mask into prefixlen be more paranoid and make sure >

ospfd: fib-priority

2018-12-10 Thread Remi Locherer
Hi, below patch adds "fib-priority" to ospfd.conf which allows to set a custom priority to routes. 32 is still the default if not set. Changing the priority with a reload is also supported. A discussion about the feature can be found here: https://marc.info/?l=openbsd-tech&m=138360663119816&w=2

Re: ospfd/ospf6d, interfaces in log messages

2021-11-03 Thread Remi Locherer
On Tue, Nov 02, 2021 at 05:27:11PM +, Stuart Henderson wrote: > I've recently started seeing a number of flaps with ospfd/ospf6d > with invalid seq nums / "seq num mismatch, bad flags" logged. > Not quite sure what's going yet as they must be occurring on > various local switched segments on on

Re: rdomain.4: route -T takes an rtable, not rdomain

2020-07-30 Thread Remi Locherer
On Thu, Jul 30, 2020 at 04:08:01AM +0200, Klemens Nanni wrote: > Multiple rtables may exist in the default rdomain (0), that is their > corresponding rdomains/lo(4) interfaces do not have to exist. > > This demonstrates it; first, nothing but default, so route(8) fails: > > # netstat -R >

Re: top: filter by routing table

2020-08-23 Thread Remi Locherer
On Sat, Aug 22, 2020 at 05:20:56PM -0600, Todd C. Miller wrote: > This looks good to me but I've refrained from commenting simply > because I don't use rtables at all myself. Can we get some feedback > from people who actually use rtables? > > - todd > I like the feature and it works as advert

Re: top: filter by routing table

2020-08-23 Thread Remi Locherer
On Sun, Aug 23, 2020 at 10:45:14PM +0200, Klemens Nanni wrote: > On Sun, Aug 23, 2020 at 10:39:21PM +0200, Remi Locherer wrote: > > I like the feature and it works as advertised. > > > > It would be nice to have a column that displays the rtable id of > > each process

Re: top: toggle routing tables

2020-08-25 Thread Remi Locherer
On Tue, Aug 25, 2020 at 09:34:55AM +0200, Klemens Nanni wrote: > On Mon, Aug 24, 2020 at 12:52:46AM +0200, Klemens Nanni wrote: > > Add `t' to swap the WAIT column with RTABLE (and vice versa); WAIT > > is wide enough to fit RTABLE, somewhat adds additional value to STATE > > and seems therefore m

Re: ospf6d: use ROUTE_FLAGFILTER

2020-09-02 Thread Remi Locherer
On Wed, Sep 02, 2020 at 03:23:28PM +1000, Jonathan Matthew wrote: > Like ospfd, ospf6d can use ROUTE_FLAGFILTER to opt out of receiving messages > relating to L2 and broadcast routes on its routing socket. We've been running > this for a week or so with no problems. > > ok? ok remi@ > > Index:

ospf(6)d: do not unlink the control socket

2020-09-15 Thread Remi Locherer
In 2018 we discussed that it is OK when ripd leaves its control socket laying around: https://marc.info/?l=openbsd-tech&m=154101413029926&w=2 When mestre@ adapted ldpd in June this year I was reminded to also adapt ospfd and ospf6d for consistent. OK? Remi Index: ospfd/control.c ==

Re: rdomain.4: add netstat -R example

2020-09-22 Thread Remi Locherer
On Tue, Sep 22, 2020 at 08:54:31PM +0200, Klemens Nanni wrote: > It's handy and otherwise easily missed when reading up on routing > domains and tables; wording taken from netstat(1) as is. > > Not listing pgrep(1)'s `-T' because examples don't have to be exhaustive > and ps(1) is already demonst

Re: rdomain.4: on removing rtables

2020-09-22 Thread Remi Locherer
On Tue, Sep 22, 2020 at 10:03:29PM +0200, Klemens Nanni wrote: > We have never been able to remove an rtable; until claudio moved them > explicitly with rtable_l2set() in if_loop.c:loop_clone_destroy(), i.e. > > revision 1.90 > date: 2020/01/08 09:09:10; author: claudio; state: Exp

Re: fix: ospf6d(8): wrong intra area announcement

2020-10-04 Thread Remi Locherer
On Fri, Oct 02, 2020 at 02:01:09AM +0200, Jan Klemkow wrote: > Hi, > > The new intra area db entry has to be saved into the tree before > orig_intra_area_prefix_lsas() is called. If not, the ospf6d will not > announce the new intra area db for a newly learned link from another > ospf router of th

Re: ospfd: allow specifying area by number as well as id

2019-05-28 Thread Remi Locherer
Hi David, are you going to commit this? Remi On Thu, May 16, 2019 at 11:14:55PM +0200, Remi Locherer wrote: > On Thu, May 16, 2019 at 09:39:37AM +0200, Sebastian Benoit wrote: > > > > > > > > Remi Locherer(remi.loche...@relo.ch) on 2019.05.15 23:15:03 +0200: >

ospf6d: conf_clear_redist_list

2019-06-08 Thread Remi Locherer
Clear unused redist_list the same way as in ospfd. OK? Remi Index: ospf6d.h === RCS file: /cvs/src/usr.sbin/ospf6d/ospf6d.h,v retrieving revision 1.39 diff -u -p -r1.39 ospf6d.h --- ospf6d.h29 Dec 2018 16:04:31 - 1.39

ospfd: point-to-point on ethernet interfaces

2019-06-23 Thread Remi Locherer
Diff below adds to ospfd point to point support for Ethernet interfaces. I successfully tested this against Junos and FastIron. I first made the key word in the config "point-to-point". But then I changed to "type p2p". The later would allow for "type nbma" or "type p2mp" should we implement these

Re: ospfd: point-to-point on ethernet interfaces

2019-07-02 Thread Remi Locherer
ping On Mon, Jun 24, 2019 at 12:33:16AM +0200, Remi Locherer wrote: > Diff below adds to ospfd point to point support for Ethernet interfaces. > I successfully tested this against Junos and FastIron. > > I first made the key word in the config "point-to-point". But then I

Re: ospfd: point-to-point on ethernet interfaces

2019-07-04 Thread Remi Locherer
ck route the BSD is announcing. Thank you for testing! Can you send me your ospfd.conf, the output from ospfd -dv and the output from tcpdump showing the ospf traffic? > On 24/06/2019 01:33, Remi Locherer wrote: > > Diff below adds to ospfd point to point support for Ethernet interfaces.

ospfd: improve logging when sendig packets fail

2019-07-14 Thread Remi Locherer
Hi, I'd like to improve ospfd's logging when sending a packet fails. I got a debug output from a ospfd user which contains "send packet: error ...". I guess ospfd failed to send an ls ack. With below diff applied it would be clear which packet could not be sent and to which neighbor. OK? Remi

Re: tpmr(4): 802.1Q Two-Port MAC Relay

2019-07-30 Thread Remi Locherer
On Tue, Jul 30, 2019 at 01:36:59PM +1000, David Gwynne wrote: > a Two-Port MAC Relay is basically a cut down bridge(4). it only supports > two ports, and unconditionally relays packets between those ports > instead of doing learning or anything like that. > > i've been trying to get a redundant pa

ospfd: check dst addr for hello packets

2019-08-11 Thread Remi Locherer
When ospfd receives a hello packet it takes the src IP address and updates the address in its neighbor struct for the given router id unconditionally. In the case of broadcast interfaces this is not a problem: find_iface() checks that the src address is from the same subnet as the receiving interf

ospfd: warn when a neighbor changes its ip address

2019-08-11 Thread Remi Locherer
I'd like to get a notification when a neighbor changes the src IP address for hello packets. Either it is a planned change or something bad happens in the network. OK? Remi Index: hello.c === RCS file: /cvs/src/usr.sbin/ospfd/hello

Re: Attach Hyper-V guest services to VMBus 4.0

2019-10-05 Thread Remi Locherer
Hi Mike, On Tue, Oct 01, 2019 at 12:25:35AM +0200, Mike Belopuhov wrote: > > > Hi, > > I've got a verbal report that Hyper-V guest services aren't attached > on modern Windows 10 systems so I believe we should get this one-liner > in before 6.6. > > FreeBSD revision 349856 adds another define

Re: Attach Hyper-V guest services to VMBus 4.0

2019-10-05 Thread Remi Locherer
On Tue, Oct 01, 2019 at 12:25:35AM +0200, Mike Belopuhov wrote: > > > Hi, > > I've got a verbal report that Hyper-V guest services aren't attached > on modern Windows 10 systems so I believe we should get this one-liner > in before 6.6. > > FreeBSD revision 349856 adds another define for VMBus

Re: Attach Hyper-V guest services to VMBus 4.0

2019-10-05 Thread Remi Locherer
On Sat, Oct 05, 2019 at 03:19:08PM +0200, Mike Belopuhov wrote: > > Remi Locherer writes: > > > On Tue, Oct 01, 2019 at 12:25:35AM +0200, Mike Belopuhov wrote: > >> > >> > >> Hi, > >> > >> I've got a verbal report that Hyper-V

ospfd: type p2p

2019-10-25 Thread Remi Locherer
Hi tech@, earlier this year I sent a diff that allowed to change an interface from broadcast to point-to-point. https://marc.info/?l=openbsd-tech&m=156132923203704&w=2 It turned out that this was not sufficient. It made the adjacency come up in p2p mode (no selection of DR or BDR) but didn't set

pf: drop tcp packet when syn AND fin flags are set

2022-03-13 Thread Remi Locherer
Hi, When pf processes a TCP packet with SYN and FIN flags set, it removes the FIN flag and continuous processing it. I propose we change that and let pf drop such a packet. I don't see any legit use for combining these two flags in the same packet. Henning added this comment 7 years ago: XXX

Re: pf: drop tcp packet when syn AND fin flags are set

2022-03-14 Thread Remi Locherer
On Mon, Mar 14, 2022 at 01:27:14AM +0100, Alexander Bluhm wrote: > On Sun, Mar 13, 2022 at 11:24:33PM +0100, Remi Locherer wrote: > > Hi, > > > > When pf processes a TCP packet with SYN and FIN flags set, it removes > > the FIN flag and continuous processing it. I

ospfd: depend on interface (new feature)

2018-02-03 Thread Remi Locherer
Hi This adds a new feature to ospfd: depend on interface. A ospfd.conf using it looks like this: --%<-- redistribute default depend on carp0 area 0.0.0.0 { interface em2 { depend on carp0 } [...] } --%<-- This router would send out the default route and the em2 network with defa

Re: ospfd: depend on interface (new feature)

2018-02-04 Thread Remi Locherer
On Sun, Feb 04, 2018 at 05:19:59AM +0100, Claudio Jeker wrote: > On Sun, Feb 04, 2018 at 12:42:22AM +0100, Remi Locherer wrote: > > Hi > > > > This adds a new feature to ospfd: depend on interface. > > > > A ospfd.conf using it looks like this: > > > &

Re: ospf6d only needs AF_INET6 route messages

2018-02-08 Thread Remi Locherer
On Thu, Feb 08, 2018 at 11:52:01AM +0100, Sebastian Benoit wrote: > can someone confirm that ospf6d still works with this change? > > oks? ospf6d works as before with this change. It also matches what ospfd does. OK remi@ > > (benno_ospf6d_kroute.diff) > > diff --git usr.sbin/ospf6d/kroute.c

Re: ospfd getting confused about who is DR

2018-02-16 Thread Remi Locherer
On Fri, Feb 09, 2018 at 03:39:43AM +0100, Claudio Jeker wrote: > On netsplits it can happen that on join multiple ospfd end up as DR. > In my case with 3 routers the one cut off stays DR even though the rest of > the network already has a DR and BDR. > > Looking into this it seems that in some cas

Re: ospfd: depend on interface (new feature)

2018-04-20 Thread Remi Locherer
On 2018-04-20 14:46, Kapetanakis Giannis wrote: On 04/02/18 01:42, Remi Locherer wrote: Hi This adds a new feature to ospfd: depend on interface. A ospfd.conf using it looks like this: --%<-- redistribute default depend on carp0 area 0.0.0.0 { interface em2 { depend on ca

Re: ospfd: depend on interface (new feature)

2018-04-20 Thread Remi Locherer
On 2018-04-20 15:39, Kapetanakis Giannis wrote: On 20/04/18 16:20, Remi Locherer wrote: On 2018-04-20 14:46, Kapetanakis Giannis wrote: While it does the job for local connected/static networks (on the router), it doesn't do it for forwarded routes which I learn from remote OSPF ro

Re: dwiic(4) fix

2018-05-22 Thread Remi Locherer
On Tue, May 22, 2018 at 05:43:01PM +0200, Mark Kettenis wrote: > > Date: Mon, 21 May 2018 17:25:47 -0700 > > From: Mike Larkin > > > > On Mon, May 21, 2018 at 12:44:47PM +0200, Mark Kettenis wrote: > > > The diff below fixes I2C_OP_WRITE_WITH_STOP operations. Currently we > > > run the read comp

Re: ospf6d/parse.y : fix line count

2018-06-03 Thread Remi Locherer
On Sat, Jun 02, 2018 at 10:33:07PM +0200, Denis Fondras wrote: > Applying otto@'s diff to ospf6d. > Fixes an off-by-one line count when using include statements. > > Ok ? I applied your diff and verified that the line number for errors in included files is now correct. ok remi@ > > Index: pars

Re: ospfd/parse.y : fix line count

2018-06-03 Thread Remi Locherer
On Sat, Jun 02, 2018 at 10:33:11PM +0200, Denis Fondras wrote: > Applying otto@'s diff to ospfd. > Fixes an off-by-one line count when using include statements. > > Ok ? I applied your diff and verified that the line number for errors in included files is now correct. ok remi@ > > Index: parse

ospf6ctl sh data intra : print metric

2018-06-05 Thread Remi Locherer
Hi, this adds "Metric: " to the output of "ospf6ctl show database intra". It looks like this: -- LS age: 1152 LS Type: Intra Area (Prefix) Link State ID: 1.0.0.0

ospf6ctl.8 - document missing database filters

2018-06-05 Thread Remi Locherer
Hi, the ospf6ctl manual misses two database filters. OK? Remi Index: ospf6ctl.8 === RCS file: /cvs/src/usr.sbin/ospf6ctl/ospf6ctl.8,v retrieving revision 1.11 diff -u -p -r1.11 ospf6ctl.8 --- ospf6ctl.8 5 Nov 2017 17:45:02 -

ospf6d: fix metric for intra area prefix LSAs

2018-06-05 Thread Remi Locherer
Hi, RfC 5340 says that for intra area prefix LSAs metric should be set to 0 in case of point-to-multipoint or loopback interfaces. Otherwise metric should be set to the value of the interfaces output cost. ospf6d currently sends intra area prefix LSAs *always* with metric 0. Below diff fixes th

Re: ospf6d: fix metric for intra area prefix LSAs

2018-06-06 Thread Remi Locherer
On Wed, Jun 06, 2018 at 09:01:49AM +0200, Claudio Jeker wrote: > On Wed, Jun 06, 2018 at 08:06:30AM +0200, Remi Locherer wrote: > > Hi, > > > > RfC 5340 says that for intra area prefix LSAs metric should be set to 0 > > in case of point-to-multipoint or loopback i

ospf6d: fix resending LSAs on if change

2018-06-11 Thread Remi Locherer
Hi, ospf6d does not resend LSAs when a carp interface goes into backup state. This is unfortunate since other routers may still use the route to the backup router or they even do ECMP and send traffic to the master and backup. This minimal diff adds braces to fix it: Index: rde.c ==

ospf6d: MAX_METRIC for carp backup interfaces

2018-06-11 Thread Remi Locherer
Hi, ospfd sends LSAs with MAX_METRIC for carp interfaces in state backup. This does the same for ospf6d. While here also document how ospf6d treats carp interfaces. OK? Remi Index: ospf6d.conf.5 === RCS file: /cvs/src/usr.sbin/o

ospfd: deal with /etc/netstart, changes of netmask and dest_addr

2018-06-17 Thread Remi Locherer
Hi, in some circumstances ospfd behaves not the way a user would expect and it's not easy understand how to recover. With below diff ospfd recovers automatically from the following three cases. 1) netstart When someone runs the netstart script on a running system it most likely assigns the alrea

Re: ospfd: deal with /etc/netstart, changes of netmask and dest_addr

2018-06-19 Thread Remi Locherer
On Tue, Jun 19, 2018 at 03:59:24PM +0100, Stuart Henderson wrote: > On 2018/06/18 08:53, Remi Locherer wrote: > > Index: ospfd.h > > === > > RCS file: /cvs/src/usr.sbin/ospfd/ospfd.h,v > > retrieving re

Re: ospfd: deal with /etc/netstart, changes of netmask and dest_addr

2018-06-24 Thread Remi Locherer
On Fri, Jun 22, 2018 at 12:25:40AM +0200, Jeremie Courreges-Anglas wrote: > On Tue, Jun 19 2018, Remi Locherer wrote: > > On Tue, Jun 19, 2018 at 03:59:24PM +0100, Stuart Henderson wrote: > >> On 2018/06/18 08:53, Remi Locherer wrote: >

ospf6d: remove unneded log_setverbose()

2018-07-09 Thread Remi Locherer
later on it is set with: log_setverbose(ospfd_conf->opts & OSPFD_OPT_VERBOSE); OK? Index: ospf6d.c === RCS file: /cvs/src/usr.sbin/ospf6d/ospf6d.c,v retrieving revision 1.35 diff -u -p -r1.35 ospf6d.c --- ospf6d.c5 Nov 2017 16:5

  1   2   3   >