Re: [Thunar-dev] How to use the eject function

2008-01-09 Thread Tino Keitel
On Wed, Dec 12, 2007 at 09:36:04 +0100, Benedikt Meurer wrote: Yves-Alexis Perez wrote: I can confirm that I have no Eject button in the shortcuts pane without the patch, and and Eject button with the patch. Committed. Bug Brian to fix xfdesktop as well. Are there patches against

Re: [Thunar-dev] How to use the eject function

2008-01-09 Thread Tino Keitel
On Wed, Jan 09, 2008 at 18:36:27 +0100, Yves-Alexis Perez wrote: On Wed, Jan 09, 2008 at 01:22:34PM +, Tino Keitel wrote: On Wed, Dec 12, 2007 at 09:36:04 +0100, Benedikt Meurer wrote: Yves-Alexis Perez wrote: I can confirm that I have no Eject button in the shortcuts pane

Re: [Thunar-dev] How to use the eject function

2008-01-09 Thread Tino Keitel
On Wed, Jan 09, 2008 at 19:40:22 +0100, Tino Keitel wrote: On Wed, Jan 09, 2008 at 18:36:27 +0100, Yves-Alexis Perez wrote: On Wed, Jan 09, 2008 at 01:22:34PM +, Tino Keitel wrote: On Wed, Dec 12, 2007 at 09:36:04 +0100, Benedikt Meurer wrote: Yves-Alexis Perez wrote: I can

Re: [Thunar-dev] How to use the eject function

2008-01-09 Thread Brian J. Tarricone
Yves-Alexis Perez wrote: By the way (and this is a new thread I guess), for some devices it's ok to have eject and umount. The only one I'm thinking of is RW CD/DVD where if the cd is mounted you can't blank it. Now you want to unmount it but you can only eject it, so you do that and reinsert

Re: [Thunar-dev] How to use the eject function

2007-12-12 Thread Benedikt Meurer
Yves-Alexis Perez wrote: I can confirm that I have no Eject button in the shortcuts pane without the patch, and and Eject button with the patch. Committed. Bug Brian to fix xfdesktop as well. Are there patches against 4.4.2?

Re: [Thunar-dev] How to use the eject function

2007-12-12 Thread Jean-François Wauthy
On Wed, 2007-12-12 at 01:18 +0100, Tino Keitel wrote: Btw., the 4.4.2 version is missing in Bugzilla. It's there now. -- Jean-François Wauthy [EMAIL PROTECTED] signature.asc Description: This is a digitally signed message part ___ Thunar-dev

Re: [Thunar-dev] How to use the eject function

2007-12-12 Thread Tino Keitel
On Wed, Dec 12, 2007 at 01:18:46 +0100, Tino Keitel wrote: On Tue, Dec 11, 2007 at 15:44:36 -0800, Brian J. Tarricone wrote: Tino Keitel wrote: On Tue, Dec 11, 2007 at 20:31:34 +0100, Benedikt Meurer wrote: Tino Keitel wrote: I can confirm that I have no Eject button in the shortcuts

Re: [Thunar-dev] How to use the eject function

2007-12-12 Thread Tino Keitel
On Wed, Dec 12, 2007 at 10:16:11 -0800, Brian J. Tarricone wrote: [...] P.S. Also, what happens for the Floppy Drive icon? Sounds pretty confusing to have an Eject menu item that -- physically -- appears to do nothing (unless you're on an old Mac). When your floppy device HAL entry

Re: [Thunar-dev] How to use the eject function

2007-12-12 Thread Brian J. Tarricone
Tino Keitel wrote: Hi Brian, what do you think about the patch? It does not hurry for Xfce itself, but the Debian maintainers wait for a comment to decide if this fix can be included in the 4.4.2 build for Debian. Functionally it looks ok (haven't tested it; just glanced at the patch). I

Re: [Thunar-dev] How to use the eject function

2007-12-12 Thread Yves-Alexis Perez
On mer, 2007-12-12 at 10:16 -0800, Brian J. Tarricone wrote: I do have issues with using the term Eject here. It makes sense for optical or tape drives, but not really for (e.g.) USB flash drives. Somebody just told me that vfat fs are not totally sync()ed at umount, that you needed to send

[Thunar-dev] How to use the eject function

2007-12-11 Thread Tino Keitel
Hi, the changelog for Thunar 0.9.0 mentions this: --- Use the correct HAL property to determine whether a given volume or device requires eject (Bug #3119). --- As I

Re: [Thunar-dev] How to use the eject function

2007-12-11 Thread Benedikt Meurer
Tino Keitel wrote: Hi, the changelog for Thunar 0.9.0 mentions this: --- Use the correct HAL property to determine whether a given volume or device requires eject (Bug #3119).

Re: [Thunar-dev] How to use the eject function

2007-12-11 Thread Tino Keitel
On Tue, Dec 11, 2007 at 09:29:24 +0100, Benedikt Meurer wrote: [...] Hm, there seems to be an error in thunar-shortcuts-view.c. The Eject Volume action is only added for discs. Try the attached patch. Thanks for the quick reply, I'll try the patch and report back. Regards, Tino

Re: [Thunar-dev] How to use the eject function

2007-12-11 Thread Tino Keitel
On Tue, Dec 11, 2007 at 09:29:24 +0100, Benedikt Meurer wrote: [...] Hm, there seems to be an error in thunar-shortcuts-view.c. The Eject Volume action is only added for discs. Try the attached patch. While looking at the source, I wondered if the same patch is necessary for

Re: [Thunar-dev] How to use the eject function

2007-12-11 Thread Benedikt Meurer
Tino Keitel wrote: On Tue, Dec 11, 2007 at 09:29:24 +0100, Benedikt Meurer wrote: [...] Hm, there seems to be an error in thunar-shortcuts-view.c. The Eject Volume action is only added for discs. Try the attached patch. While looking at the source, I wondered if the same patch is

Re: [Thunar-dev] How to use the eject function

2007-12-11 Thread Benedikt Meurer
Tino Keitel wrote: I can confirm that I have no Eject button in the shortcuts pane without the patch, and and Eject button with the patch. Committed. Bug Brian to fix xfdesktop as well. Regards, Tino Benedikt ___ Thunar-dev mailing list

Re: [Thunar-dev] How to use the eject function

2007-12-11 Thread Tino Keitel
On Tue, Dec 11, 2007 at 20:31:34 +0100, Benedikt Meurer wrote: Tino Keitel wrote: I can confirm that I have no Eject button in the shortcuts pane without the patch, and and Eject button with the patch. Committed. Bug Brian to fix xfdesktop as well. I patched xfdesktop in a minimal way

Re: [Thunar-dev] How to use the eject function

2007-12-11 Thread Tino Keitel
On Wed, Dec 12, 2007 at 00:38:55 +0100, Tino Keitel wrote: On Tue, Dec 11, 2007 at 20:31:34 +0100, Benedikt Meurer wrote: Tino Keitel wrote: I can confirm that I have no Eject button in the shortcuts pane without the patch, and and Eject button with the patch. Committed. Bug Brian to

Re: [Thunar-dev] How to use the eject function

2007-12-11 Thread Brian J. Tarricone
Tino Keitel wrote: On Tue, Dec 11, 2007 at 20:31:34 +0100, Benedikt Meurer wrote: Tino Keitel wrote: I can confirm that I have no Eject button in the shortcuts pane without the patch, and and Eject button with the patch. Committed. Bug Brian to fix xfdesktop as well. I patched xfdesktop in

Re: [Thunar-dev] How to use the eject function

2007-12-11 Thread Tino Keitel
On Tue, Dec 11, 2007 at 15:44:36 -0800, Brian J. Tarricone wrote: Tino Keitel wrote: On Tue, Dec 11, 2007 at 20:31:34 +0100, Benedikt Meurer wrote: Tino Keitel wrote: I can confirm that I have no Eject button in the shortcuts pane without the patch, and and Eject button with the patch.

Re: [Thunar-dev] How to use the eject function

2007-12-11 Thread Tino Keitel
On Wed, Dec 12, 2007 at 01:18:46 +0100, Tino Keitel wrote: Done. It's bug #3738. ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev