[twdev] Re: Controlling plugin order

[Matthew Lauber]

Finally tracked it down.  It seems like there's a bug in ordering plugins 
when one has a plugin-priority and the other doesn't.  I've thrown a PR up 
for the fix here.  https://github.com/Jermolene/TiddlyWiki5/pull/3113  
@Jeremy, can you take a look?

Matt

On Monday, February 12, 2018 at 10:48:12 AM UTC-5, Matthew Lauber wrote:
>
> So, I found this code 
> , 
> and tried setting the `plugin-priority` field on my plugin, but it doesn't 
> seem to affect the ordering.  However, renaming my plugin from 
> $:/plugins/mklauber/... to $:/zzz/plugins/mklauber/... does, which says to 
> me it's an ordering issue.  Anyone familiar with that code, or better able 
> to explain plugin ordering?
> does.
>
> On Sunday, February 11, 2018 at 6:43:02 PM UTC-5, Matthew Lauber wrote:
>>
>> I've got some tweaks I like on all my wikis (breakpoint, story river 
>> width, etc).  I tried to pack them into a plugin so I can move them from 
>> wiki to wiki easily, but what I discovered is that once I pack them into 
>> the plugin, they no longer work.  I can see them inside the plugin, so what 
>> I think is happening is that my preference plugin is being loaded before 
>> the theme plugin itself, and thus the theme overwrites my tweaks.  
>>
>> Can anyone shed light on what controls plugin load order?
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/02fc8b40-6f9b-4ef3-9e38-a669e77f6f8b%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[twdev] Re: Controlling plugin order

[Matthew Lauber]

So, I found this code 
, 
and tried setting the `plugin-priority` field on my plugin, but it doesn't 
seem to affect the ordering.  However, renaming my plugin from 
$:/plugins/mklauber/... to $:/zzz/plugins/mklauber/... does, which says to 
me it's an ordering issue.  Anyone familiar with that code, or better able 
to explain plugin ordering?
does.

On Sunday, February 11, 2018 at 6:43:02 PM UTC-5, Matthew Lauber wrote:
>
> I've got some tweaks I like on all my wikis (breakpoint, story river 
> width, etc).  I tried to pack them into a plugin so I can move them from 
> wiki to wiki easily, but what I discovered is that once I pack them into 
> the plugin, they no longer work.  I can see them inside the plugin, so what 
> I think is happening is that my preference plugin is being loaded before 
> the theme plugin itself, and thus the theme overwrites my tweaks.  
>
> Can anyone shed light on what controls plugin load order?
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/fa82086c-804c-4f21-9207-7ea357d183f3%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[twdev] Re: Controlling plugin order

[Matthew Lauber]

I'm actually not editing the stylesheets, but the configuration tiddler 
itself. (e.g. $:/themes/tiddlywiki/vanilla/metrics/storywidth)  But I'll 
look at put a list-after on my plugin, see if I can control plugin-order 
via that.  Thanks!


On Monday, February 12, 2018 at 12:00:09 AM UTC-5, Simon Huber wrote:
>
> Hello Matthew,
>
> this could be because TW loads the stylesheet before the vanilla base 
> stylesheet, so that the latter overrides your styles. I had that problem, 
> too
>
> For me it worked adding the field "list-after" with this content: 
> $:/themes/tiddlywiki/vanilla/base
>
> Simon
>
> Am Montag, 12. Februar 2018 00:43:02 UTC+1 schrieb Matthew Lauber:
>>
>> I've got some tweaks I like on all my wikis (breakpoint, story river 
>> width, etc).  I tried to pack them into a plugin so I can move them from 
>> wiki to wiki easily, but what I discovered is that once I pack them into 
>> the plugin, they no longer work.  I can see them inside the plugin, so what 
>> I think is happening is that my preference plugin is being loaded before 
>> the theme plugin itself, and thus the theme overwrites my tweaks.  
>>
>> Can anyone shed light on what controls plugin load order?
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/037830ee-d7d1-40b6-9421-3630ee22fa34%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[twdev] Re: Controlling plugin order

[Simon Huber]

Hello Matthew,

this could be because TW loads the stylesheet before the vanilla base 
stylesheet, so that the latter overrides your styles. I had that problem, 
too

For me it worked adding the field "list-after" with this content: 
$:/themes/tiddlywiki/vanilla/base

Simon

Am Montag, 12. Februar 2018 00:43:02 UTC+1 schrieb Matthew Lauber:
>
> I've got some tweaks I like on all my wikis (breakpoint, story river 
> width, etc).  I tried to pack them into a plugin so I can move them from 
> wiki to wiki easily, but what I discovered is that once I pack them into 
> the plugin, they no longer work.  I can see them inside the plugin, so what 
> I think is happening is that my preference plugin is being loaded before 
> the theme plugin itself, and thus the theme overwrites my tweaks.  
>
> Can anyone shed light on what controls plugin load order?
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/eb75f2e0-7ac8-455c-bf3c-1811b367d56e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.