DO NOT REPLY [Bug 18650] - Exception while processing a JAR file

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18650

Exception while processing a JAR file

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Blocker |Major
 Status|RESOLVED|REOPENED
 Resolution|INVALID |
Version|4.1.18  |4.1.27



--- Additional Comments From [EMAIL PROTECTED]  2003-08-05 06:52 ---
This may not be a bug per se, but is an unfriendly error message.  It is caused 
by an incorrect  entry.  I've replicated this using Tomcat 4.1.27.  Do 
the following:

1. Create a lib directory under %TOMCAT_HOME%\webapps\examples\WEB-INF and copy 
a jar into it (I used ant.jar, version 1.5.2).

2. Change the value of the path of the example application server.xml, change:



to



(ie - remove the leading slash).

3. Start tomcat.  Watch the examples log, here's what I get:

2003-08-05 06:46:15 WebappLoader[examples]: Deploying class repositories to 
work directory C:\programs\jakarta-tomcat-4.1.27
\work\Standalone\localhost\examples
2003-08-05 06:46:15 WebappLoader[examples]: Deploy class files /WEB-INF/classes 
to C:\programs\jakarta-tomcat-4.1.27\bin\..\webapps\examples\WEB-INF\classes
2003-08-05 06:46:15 WebappLoader[examples]: Deploy JAR /WEB-INF/lib/ant.jar to 
C:\programs\jakarta-tomcat-4.1.27\bin\..\webapps\examples\WEB-INF\lib\ant.jar
2003-08-05 06:46:15 WebappLoader[examples]: Reloading checks are enabled for 
this Context
2003-08-05 06:46:16 ContextConfig[examples] Exception processing JAR at 
resource path /WEB-INF/lib/ant.jar
javax.servlet.ServletException: Exception processing JAR at resource path /WEB-
INF/lib/ant.jar
at org.apache.catalina.startup.ContextConfig.tldScanJar
(ContextConfig.java:930)
at org.apache.catalina.startup.ContextConfig.tldScan
(ContextConfig.java:868)
at org.apache.catalina.startup.ContextConfig.start
(ContextConfig.java:647)
at org.apache.catalina.startup.ContextConfig.lifecycleEvent
(ContextConfig.java:243)
at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent
(LifecycleSupport.java:166)
at org.apache.catalina.core.StandardContext.start
(StandardContext.java:3568)
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1188)
at org.apache.catalina.core.StandardHost.start(StandardHost.java:738)
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1188)
at org.apache.catalina.core.StandardEngine.start
(StandardEngine.java:347)
at org.apache.catalina.core.StandardService.start
(StandardService.java:497)
at org.apache.catalina.core.StandardServer.start
(StandardServer.java:2190)
at org.apache.catalina.startup.Catalina.start(Catalina.java:512)
at org.apache.catalina.startup.Catalina.execute(Catalina.java:400)
at org.apache.catalina.startup.Catalina.process(Catalina.java:180)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:203)
- Root Cause -
java.io.FileNotFoundException
at org.apache.naming.resources.DirContextURLConnection.getInputStream
(DirContextURLConnection.java:344)
at sun.net.www.protocol.jar.URLJarFile.retrieve(URLJarFile.java:161)
at sun.net.www.protocol.jar.URLJarFile.getJarFile(URLJarFile.java:42)
at sun.net.www.protocol.jar.JarFileFactory.get(JarFileFactory.java:78)
at sun.net.www.protocol.jar.JarURLConnection.connect
(JarURLConnection.java:85)
at sun.net.www.protocol.jar.JarURLConnection.getJarFile
(JarURLConnection.java:69)
at org.apache.catalina.startup.ContextConfig.tldScanJar
(ContextConfig.java:906)
at org.apache.catalina.startup.ContextConfig.tldScan
(ContextConfig.java:868)
at org.apache.catalina.startup.ContextConfig.start
(ContextConfig.java:647)
at org.apache.catalina.startup.ContextConfig.lifecycleEvent
(ContextConfig.java:243)
at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent
(LifecycleSupport.java:166)
at org.apache.catalina.core.StandardContext.start
(StandardContext.java:3568)
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1188)
at org.apache.catalina.core.StandardHost.start(StandardHost.jav

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java ApplicationDispatcher.java ApplicationHttpRequest.java

[remm]

remm2003/08/05 06:22:03

  Modified:catalina/src/share/org/apache/catalina/core
ApplicationContext.java ApplicationDispatcher.java
ApplicationHttpRequest.java
  Log:
  - Fix for three related bugs.
  - Bug 22013: The wrapped request must actually override
getRequestDispatcher. Thanks to Stephane Riviere for the test case.
  - Bug 4690: Fix for cross context sessions scoping (previously, the visible
session would be the one from the context which first recieved the request).
  - Fix ServletContext.getContext(...) when using the root context. (but the spec 
should
really be modified so that it says that only exact matches of the target context
are allowed).
  
  Revision  ChangesPath
  1.14  +7 -5  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationContext.java
  
  Index: ApplicationContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationContext.java,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- ApplicationContext.java   12 Jun 2003 22:06:30 -  1.13
  +++ ApplicationContext.java   5 Aug 2003 13:22:03 -   1.14
  @@ -286,7 +286,9 @@
   String contextPath = context.getPath();
   if (!contextPath.endsWith("/"))
   contextPath = contextPath + "/";
  -if ((contextPath.length() > 0) && (uri.startsWith(contextPath))) {
  +if ((contextPath.length() > 1) && 
  +((uri.equals(context.getPath())) 
  + || (uri.startsWith(contextPath {
   return (this);
   }
   
  
  
  
  1.22  +13 -7 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java
  
  Index: ApplicationDispatcher.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java,v
  retrieving revision 1.21
  retrieving revision 1.22
  diff -u -r1.21 -r1.22
  --- ApplicationDispatcher.java23 Jul 2003 07:51:33 -  1.21
  +++ ApplicationDispatcher.java5 Aug 2003 13:22:03 -   1.22
  @@ -996,10 +996,16 @@
   ServletRequest wrapper = null;
   if ((current instanceof ApplicationHttpRequest) ||
   (current instanceof HttpRequest) ||
  -(current instanceof HttpServletRequest))
  -wrapper = new ApplicationHttpRequest((HttpServletRequest) current);
  -else
  +(current instanceof HttpServletRequest)) {
  +// Compute a crossContext flag
  +HttpServletRequest hcurrent = (HttpServletRequest) current;
  +boolean crossContext = 
  +!(context.getPath().equals(hcurrent.getContextPath()));
  +wrapper = new ApplicationHttpRequest
  +(hcurrent, context, crossContext);
  +} else {
   wrapper = new ApplicationRequest(current);
  +}
   if (previous == null)
   outerRequest = wrapper;
   else
  
  
  
  1.11  +128 -5
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java
  
  Index: ApplicationHttpRequest.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- ApplicationHttpRequest.java   25 Jun 2003 19:39:09 -  1.10
  +++ ApplicationHttpRequest.java   5 Aug 2003 13:22:03 -   1.11
  @@ -72,10 +72,16 @@
   import java.util.Iterator;
   import java.util.Set;
   import java.util.Map;
  +
  +import javax.servlet.RequestDispatcher;
   import javax.servlet.http.HttpServletRequest;
   import javax.servlet.http.HttpServletRequestWrapper;
  +import javax.servlet.http.HttpSession;
  +
  +import org.apache.catalina.Context;
   import org.apache.catalina.Globals;
   import org.apache.catalina.HttpRequest;
  +import org.apache.catalina.Session;
   import org.apache.catalina.util.Enumerator;
   import org.apache.catalina.util.RequestUtil;
   import org.apache.catalina.util.StringManager;
  @@ -130,9 +136,12 @@
*
* @param request The servlet request being wrapped
*/
  -public ApplicationHttpRequest(HttpServletRequest request) {
  +public ApplicationHttpRequest(HttpServletRequest request, Context context,
  +  boolean crossContext) {
   
   super(request);
  +this.context = context;
  +this.crossContext = crossContext;
   setRequest(request);
   
   }
  @@ -142,12 +151,25 @@
   
   
   /**
  + * The context for 

DO NOT REPLY [Bug 22183] New: - Copy of Jasper in WEB-INF confuses Tomcat

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22183

Copy of Jasper in WEB-INF confuses Tomcat

   Summary: Copy of Jasper in WEB-INF confuses Tomcat
   Product: Tomcat 4
   Version: 4.1.27
  Platform: All
OS/Version: All
Status: NEW
  Severity: Critical
  Priority: Other
 Component: Jasper 2
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Hi,

today all my JSP pages got messed up. The WEB-INF/lib directory of another
web-application contained Jasper as a JAR.
That bad thing is, that this doesn't only mess up one web-application, but all
web-application on the server!

When i say that my JSP-pages got messed up, i mean that the outbut of tags and
other stuff summed up and mixed. Instead of having the intended HTML-code i got
additional fragments of other JSP-pages. I can't tell how this can happen, but
it did.

I guess this is some kind of classloader/classpath issue. Would be good to have
this solved.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22141] New: - response wrapper not being used in filtering an error-page

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22141

response wrapper not being used in filtering an error-page

   Summary: response wrapper not being used in filtering an error-
page
   Product: Tomcat 4
   Version: 4.1.27
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Connector:Coyote HTTP/1.1
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I have written a simple compression filter that provides a response wrapper as 
a stand-in for the 'real' response object, using HttpServletResponseWrapper as 
its superclass.  I gzip the response data before it is sent to the client.

This response wrapper is being used for all requests to the web-app EXCEPT 
those which trigger a 404 -- I have mapped an error-page to 404.  In that case, 
org.apache.coyote.tomcat4.CoyoteResponseFacade is being used instead of the 
resonse wrapper object.  The log file shows an IllegalStateException: 
getOutputStream() has already been called for this response -- this is 
generated by /jsp/404.jsp's implementation servlet.

NOTE that pointing browser directly at /jsp/404.jsp results in correct 
behavior, i.e., the response wrapper is being used.

web.xml:
filter-mapping set to /*
error-page error-code is 404
error-page location is /jsp/404.jsp

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22130] - Tomcat VM not shutdown successfull as jk2 JMX handler is active

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22130

Tomcat VM not shutdown successfull as jk2 JMX handler is active





--- Additional Comments From [EMAIL PROTECTED]  2003-08-05 12:04 ---
Maybe it is caused by mx4j's connectors using non-daemon threads. If you do a
thread dump (CTRL+BREAK on Windown, kill -3 on Unix), you can see which threads
are daemon, and which are not.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20369] - When load a jsp page multiple times, the content falls out of place

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20369

When load a jsp page multiple times, the content falls out of place

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME



--- Additional Comments From [EMAIL PROTECTED]  2003-08-05 21:00 ---
We'll need a test case and a how-to to reproduce this.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: window close session invalidate

[Martin Algesten]

This is a user question and should be posted on the tomcat-user list.

On a side note, the session is maintained either by a session cookie or 
by a session id at the end of each request. The server will keep your 
session going for the time specified in the web.xml. If the client 
"forgets" all about the session id by closing the browser down, then 
the session is dead (even if it is still on the server until it 
expires). Hard to say why your popup doesn't work. One idea could be to 
make sure the session is going already in the "root" window.

Martin

On Wednesday, August 6, 2003, at 07:48 AM, Paul Wallace wrote:

Also, I was under the impression that 'session' is good for the amount
of time specified in your configuration file, or until
session.invalidate();  is called?
Thanks

Paul.

That is according to the spec, The session only lives for the time of
the
application,closing your browser window, means that you are ending your
application
Filip

-Original Message-
From: Paul Wallace [mailto:[EMAIL PROTECTED]
Sent: Tuesday, August 05, 2003 9:01 PM
To: Tomcat Developers List
Subject: window close session invalidate
Dear all,
May someone enlighten me on why my session is being invalidated
when I close a browser window? I am doing this in one of two ways -
the
application close icon on the top right of the window, or a simple:

CLOSE

Does anyone have any experience of this? The session is being killed
and
thus so is my app. I will submit this query to the user list, but
thought it appropriate for this list as I am getting the same result
from multiple instances of TC on different servers, implying it is not
a
configuration issue as first suspected.

Thanks

Paul.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: tomcat-5.0.5 cannot access jar resources in WEB-INF/lib but o nly unzipped in WEB-INF/classes

[Harmsen, Jan]

Remy Maucherat wrote:
>
> I did examine the Eclipse code, and it is invalid (you must 
> not attempt 
> to access other CL controlled resources based on another URL 
> which was 
> returned by the CL).
>
Hi Remy,

What you say sounds reasonable to me as a user of the eclipse
code, looks like the developers of eclipse emf did not think
of the problems such an access method can cause. Unfortunately
EMF is a base for other APIs like XSD ...

> However, I did add a workaround in the CL which makes your test case 
> work, but which has a performance penalty on first access to a JAR. I 
> think avoiding resource leak is more important.
> 

Thanks a lot !! I agree.

Best regards,

Jan

DO NOT REPLY [Bug 22151] - ThreadPool OutOfMemoryException

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22151

ThreadPool OutOfMemoryException





--- Additional Comments From [EMAIL PROTECTED]  2003-08-06 08:38 ---

Perhaps a silly question, but have you tried to run Tomcat on its own without your own 
code 
deployed?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [OT] New job

[Costin Manolache]

Remy Maucherat wrote:

> This is OT, sorry.
> 
> I've accepted a position of Consultant at the JBoss Group, where I will
> help maintain the JBoss / Tomcat integration (which has become
> especially important since their decision to use Tomcat as their default
> servlet container in the upcoming JBoss releases), spend a significant
> amount of time working on Tomcat (as before), and provide commercial
> support / consulting / training on Tomcat.
> 
> So the cool part is that my Tomcat work is funded again :)

Great !!! 


Isn't it nice to be able to do some open source as part of your day job ?
:-)

Costin



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Fwd: Re: Tomcat and LDAP Issues

[Tim Funk]

I got eager and saw you bug update yesterday and applied a patch to 4.1 last 
night. Here's a link to the PATCH email:

http://marc.theaimsgroup.com/?l=tomcat-dev&m=106004487327965&w=2

The commit also does a null pointer check on the getMessage() to fix a 
related bug and also avoids doing the toString().

As for bug 20518 - did this seem right? It seemed like an innocent fix. (But 
they are the ones that seem to cause the most trouble)

IIRC, the only two bugs left I know of is:
1) The CLIENT-CERT one which I wish not to do but rather leave to someone to 
Extend JNDIRealm. (But if someone else wants to commit it - I won't care)
2) Enhancement request for IPlanet since in a non-user binding the SHA1 check 
isn't compatible with the way tomcat generates a hash. I have a patch on my 
own from another project that might fix this. (If I can find the code)

AFAIK - All other JNDIRealm bugs are fixed or enhancements. If you can test 
from 4.1 and give me the OK - I can port the patch to 5. (I know I committed 
in the wrong order :( ,  but did it on the hope that the patch had a better 
chance of being tested)

-Tim



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Cannot load /usr/local/apache/libexec/mod_webapp.so

[jean-frederic clere]

Sunny Lin wrote:
To whom it may concerns,

I successfully built the web modules, but had error when do the 
configtest as followed,

Syntax error on line 205 of /usr/local/apache/conf/httpd.conf:
Cannot load /usr/local/apache/libexec/mod_webapp.so into server: 
ld.so.1: /usr/local/apache/bin/httpd: fatal: relocation error: file 
/usr/local/apache/libexec/mod_webapp.so: symbol __moddi3: referenced 
symbol not found

The configuration on the server is Solaris 8 x86 and Apache 1.3.27.
mod_webapp is deprecated. Try with mod_jk2 or mod_jk.

Thanks,





Sunny Lin
Analyst/Programmer
ACS, CSUSB
(909) 880-7266
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

fix for jakarta-tomcat-connectors-4.1.27-src

[Mike Bethune]

sorry if it's known already, but I didn't see it in the dev mailing list archives
(not subscribed on the list, pls send any responses to me directly, thanks)


--- jk/native/common/jk_uri_worker_map.c.orig Tue Aug  5 16:20:48 2003
+++ jk/native/common/jk_uri_worker_map.c Tue Aug  5 16:20:53 2003
@@ -489,7 +489,7 @@ char *map_uri_to_worker(jk_uri_worker_ma
 unsigned i;
 unsigned best_match = -1;
 unsigned longest_match = 0;
-char * clean_uri = jk_pool_strdup(&uw_map->tp,uri);;
+char *clean_uri = jk_pool_strdup(&uw_map->tp,uri);
 char *url_rewrite = strstr(clean_uri, JK_PATH_SESSION_IDENTIFIER);
 if(url_rewrite) {


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22133] - Scoping conflict for generated fragment helpers

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22133

Scoping conflict for generated fragment helpers





--- Additional Comments From [EMAIL PROTECTED]  2003-08-06 10:32 ---
Well, my patch resolves the issue for this particular call to #getJspContext(). In 
general all 
unqualified method calls that resolve to methods in both SimpleTagSupport and 
JspFragmentHelper will be flagged by the 1.3.1 compiler. Looks like 'getParentTag()' 
might be 
another candidate. Will check out.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 16144] - NullPointerException in JDBCRealm when password is null

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16144

NullPointerException in JDBCRealm when password is null

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2003-08-07 01:12 ---


*** This bug has been marked as a duplicate of 7116 ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22263] - autodeploy conflicts with manager undeploy/deploy cycle

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22263

autodeploy conflicts with manager undeploy/deploy cycle

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-08-08 22:00 ---
This has either been fixed or is invalid (and updating was not working correctly
with 5.0.6). Extra context restarts may occur (something which I consider
acceptable).

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: System.out refs

[Costin Manolache]

Tim Funk wrote:

> When I was looking at o.a.c.core.ApplicationDispatcher.java, I noticed it
> used 2 different logging styles:
> 
> - Commons Logging
> - log() which tries to use context.getLogger(), and if null uses
> System.out
> 
> Shouldn't the log() method use commons-logging if context.getLogger()
> returns null?

Yes, it should.

Well, IMO the context logging should use commons-logging :-)


> Bonus q: If anything uses System.out (including printStackTrace()) and
> commons-logging is available - all System.outs should be converted to
> commons-logging calls?

Yes.

Costin

> 
> Are there any situations where using System.out is OK?
> 
> 
> -Tim



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 6279] - Resubmit to j_security_check mistakenly fetches a page of that name

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6279

Resubmit to j_security_check mistakenly fetches a page of that name

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2003-08-06 15:39 ---
Since people have emailed me directly several times to ask what happened to this
bug, I did a bit of digging. There has been some recent discussion on tomcat-dev:

The 'authenticated but not authorized' case is discussed again here:
http://nagoya.apache.org/eyebrowse/ReadMsg?listId=46&msgNo=58450

An alternate patch for the problem from Jeff Tulley, which also redirects to
error pages:
http://nagoya.apache.org/eyebrowse/ReadMsg?listId=46&msgNo=58547
Remy said of this one: "I won't commit this to TC 4.1.x at this time; I'll give
it a try in TC 5, and see how it works."

Remy gives a good explanation of whats potentially wrong with the patches
attached to this bug here:
http://nagoya.apache.org/eyebrowse/ReadMsg?listName=46&msgId=716594

However, Jeff's patch has been applied in TC5 - forwarding is now the default:
http://cvs.apache.org/viewcvs.cgi/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/authenticator/FormAuthenticator.java.diff?r1=1.2&r2=1.3&diff_format=h

Since the bug is fixed in TC5, and Remy has already indicated that it will not
be going into 4.1.x, I am closing this bug report as WONTFIX. I know other bugs
were marked as duplicates of this, so if anyone else on the cc list strenuously
objects please feel free to reopen it.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22236] - JNDI Realm authentication to Novell eDirectory via LDAP

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22236

JNDI Realm authentication to Novell eDirectory via LDAP





--- Additional Comments From [EMAIL PROTECTED]  2003-08-08 12:53 ---
addAttributeValues() has the ability to return null on certain conditions.

Then later in getRoles(), if debug >=2, then the list returned by 
addAttributeValues is iterated for debug reasons.

The temporary workaround is keep debug < 2. (Ick :( )

Patch to be made soon which will check for null while in the debug statement.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22146] - TC 5.0.6 problems loading an a persisted session.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22146

TC 5.0.6 problems loading an a persisted session.





--- Additional Comments From [EMAIL PROTECTED]  2003-08-08 14:30 ---
I can reproduce this, but failed to fix the bug.
I added traces in CustomObjectInputStream, and while there's a (normal) CNFE for
[Ltest$EKey;, it loads correctly test$EKey. The behavior is in every way
identical between TC 4.1.x and 5.0.x (at least for what I could see), and yet I
couldn't reproduce the bug with Tomcat 4.1.x.
If someone could help, or has ideas, that would be cool :)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: DO NOT REPLY [Bug 22268] New: -Admin truncates user password in 32 characters

[苗启广]

ÔÚ 2003-08-09 05:11:00 ÄúдµÀ£º
>of you ? Could you tell me ? Thanks~~
>DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
>RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
>.
>ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
>INSERTED IN THE BUG DATABASE.
>
>http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22268
>
>Admin truncates user password in 32 characters
>
>   Summary: Admin truncates user password in 32 characters
>   Product: Tomcat 4
>   Version: 4.1.27
>  Platform: Macintosh
>OS/Version: MacOS X
>Status: NEW
>  Severity: Minor
>  Priority: Other
> Component: Webapps:Administration
>AssignedTo: [EMAIL PROTECTED]
>ReportedBy: [EMAIL PROTECTED]
>
>
>In 'Edit Existing User Properties' screen, the password field has
>only 32 chars long.
>So, if we set Admin webapp to use SHA digest, editing user properties
>from this screen makes password information collapsed,
>because SHA digest has always 40 chars long.
>
>-
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]
>
>
 mqg

- SOUVENIR --- .
| Souvenir of China |
| A Good Place for You  |
`--> http://www.souvenirchina.com -'
mailto:[EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Breaking the build

[Tim Funk]

I don't know if there are any build from scratch scripts out there, I am sure 
there is because of the nightly build process. I wanted a script that pulls 
everything from scratch and does a full build so I can test that occasionally 
for myself.

Attached (hopefully) is a shell script. I've only tested it in cygwin but it 
should work fine in any sh compatible *nix. (The script is very simple and 
anyone with minimal shell experience can easily tweak this)

When you run this script it will create a subdirectory called "buildtc5" and 
use that as a starting point for pulling everything from cvs and use the 
"download" task to put everything in buildtc5/includes as well as the 
checkout task to pull the rest of the source dependences. The only 
prerequisites to running the script are
- JAVA_HOME must be defined and you need jdk1.4
- ANT_HOME must be defined
- cvs must be in your PATH

WARNING: This script uses the anonymous cvs to pull everything and tries to 
append to $HOME/.cvspass the anonymous userid password combo.

Summary:
to build tc5 from source
- plop the attachment in some empty directory
- run it and wait
- to clean up - "rm -fr buildtc5"
-Tim

#!/bin/sh

# This works with jdk 1.4 only
# Before running - you need the following environment variables
#
# JAVA_HOME - Uor java installation
# ANT_HOME - Where ANT is located
#
# Ant might also need the Netcomponents.jar or whatever
# jar is needed to allow the ftp (or get?) task to work.
#
# If you have a proxy server then I have no clue.

cygwin=false
case "`uname`" in
CYGWIN*) cygwin=true;;
esac


# Check for JAVA_HOME
if [ "Z" = "Z$JAVA_HOME" ] ;
then
   echo "Where is JAVA_HOME!"
   exit 1
fi

# Check for ANT_HOME
if [ "Z" = "Z$ANT_HOME" ] ;
then
   echo "Where is ANT_HOME!"
   exit 1
fi


# Check for ANT_HOME
if [ "Z" = "Z$ANT_HOME" ] ;
then
   echo "Where is ANT_HOME!"
   exit 1
fi


# Woo hoo - The environment looks right

echo "Using ANT_HOME=$ANT_HOME"
echo "Using JAVA_HOME=$JAVA_HOME"
echo "Putting everything in `pwd`/buildtc5"
echo "Downloaded dependencies go into `pwd`/buildtc5/includes"


mkdir -p buildtc5/includes
if [ 0 != $? ];
then
echo "making subdirs failed!"
exit 1
fi

BASE_PATH=`pwd`/buildtc5/includes
if $cygwin; then
  BASE_PATH=`cygpath --path --windows "$BASE_PATH"`
fi


cd buildtc5

echo "Getting jakarta-tomcat-5"


# Sad attempt to automagically log you into CVS so
# you can use cvs

grep 'pserver:[EMAIL PROTECTED]' $HOME/.cvspass >>/dev/null

if [ 0 != $? ];
then
  echo "Altering  $HOME/.cvspass so you are logged in!"
  echo ':pserver:[EMAIL PROTECTED]:/home/cvspublic Ay=0=h> $HOME/.cvspass
fi

cvs -q -d :pserver:[EMAIL PROTECTED]:/home/cvspublic co jakarta-tomcat-5

if [ 0 != $? ];
then
  echo "Checkout failed. Hopefully there is a reason above."
  exit 1
fi


cd jakarta-tomcat-5

###
# Create build.properties so we have the correct base path
###
echo "base.path=$BASE_PATH" > build.properties

$ANT_HOME/bin/ant download checkout deploy

if [ 0 != $? ];
then
  echo "Dammit! Build failed. Hopefully there is a reason above."
  exit 1
fi

echo "All done! Hopefully all is well."

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

JSP include

[Marc Baumgartner]

Hello all,

I want to fix a bug in the JSPReader of the Cocoon-Project. It would be 
helpfull for me if someone could explain me how the tomcat handles the 
jsp:include and jsp:forward tag.

For example, I have foo.jsp and bar.jsp:

foo



bar
hello

How is the location of the file bar constructed by tomcat? 
Which methods of HttpServletRequest are used? 

Thanks in advanced.

Regards,
Marc

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Xerces location and bug

[Jean-Francois Arcand]

Hi,

I've just realized that when you install Tomcat 5 from a fresh 
workspace, Xerces is not copied under common/endorsed. I don't remember 
what was the decision regarding Xerces. Have we decide to completely 
remove it? If yes, then we shoud remove the dependency in 
build.properties and unpdate the RELEASE-NOTES. What was the decision?

Also, when turning xml validation on with Xerces, all app throw the 
following:

SEVERE: Parse Error at line 5 column 10: cvc-elt.1: Cannot find the 
declaration of element 'web-app'.
org.xml.sax.SAXParseException: cvc-elt.1: Cannot find the declaration of 
element 'web-app'.
at 
org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown 
Source)
at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown Source)
at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
Source)
at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
Source)

I'm gonna investigate and try to come with a fix before sunday

Thanks,

-- Jeanfrancois

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 7116] - JDBC realm doesn't handle NULLpasswords

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7116

JDBC realm doesn't handle NULLpasswords

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2003-08-07 01:12 ---
*** Bug 15164 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Error starting Embedded.main() in 4.1.27

[John Fowler]

Hi all,

I've been having trouble tracking down a problem using
the org.apache.catalina.startup.Embedded class in
4.1.27. Whenever I try to start it I get the following
stack trace.

I've been having no trouble using Embedded under
4.0.6; but I'd like to move up to 4.1 to get the
latest fixes.   In any case, I went back to try the
main method of the Embedded class to see if that still
worked and I get the same trace when running it under
4.1.27 (Embedded.main() works fine in 4.0.6). It
appears to be failing when it reads the conf/web.xml
page. It's as if the parser is configured differently
from Embedded than when running standalone Catalina (I
have no problem running Catalina standalone).

java.lang.NullPointerException
at
org.apache.commons.digester.ObjectCreateRule.begin(ObjectCreateRule.j
ava:252)
at
org.apache.commons.digester.Rule.begin(Rule.java:200)
at
org.apache.commons.digester.Digester.startElement(Digester.java:1273)

at
org.apache.xerces.parsers.AbstractSAXParser.startElement(Unknown
Sour
ce)
at
org.apache.xerces.impl.dtd.XMLDTDValidator.startElement(Unknown
Sourc
e)
at
org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanStartElemen
t(Unknown Source)
at
org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContent
Dispatcher.dispatch(Unknown Source)
at
org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Un
known Source)
at
org.apache.xerces.parsers.XML11Configuration.parse(Unknown
Source)
at
org.apache.xerces.parsers.DTDConfiguration.parse(Unknown
Source)
at
org.apache.xerces.parsers.XMLParser.parse(Unknown
Source)
at
org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown
Source)
at
org.apache.commons.digester.Digester.parse(Digester.java:1548)
at
org.apache.catalina.startup.ContextConfig.applicationConfig(ContextCo
nfig.java:282)
at
org.apache.catalina.startup.ContextConfig.start(ContextConfig.java:63
9)
at
org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfi
g.java:243)
at
org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(Lifecycl
eSupport.java:166)
at
org.apache.catalina.core.StandardContext.start(StandardContext.java:3
568)
at
org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1188)

at
org.apache.catalina.core.StandardHost.start(StandardHost.java:738)
at
org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1188)

at
org.apache.catalina.core.StandardEngine.start(StandardEngine.java:347
)
at
org.apache.catalina.startup.Embedded.addEngine(Embedded.java:464)
at
org.apache.catalina.startup.Embedded.main(Embedded.java:1109)

I just can't make any sense of it. Any help would be
appreciated. If it's a config problem, the I apologize
in advance for polluting this list with that type of
issue.

Thanks,  John

__
Do you Yahoo!?
Yahoo! SiteBuilder - Free, easy-to-use web site design software
http://sitebuilder.yahoo.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Jikes 1.18 JSP compiler support broken in TC 4.1.27

[Chris Brown]

Hi,

I tried switching to Jikes with Tomcat release 4.1.27 (LE-JDK1.4), and it
would appear that the version of "ant.jar" you use internally in Tomcat to
compile JSP pages is out of date with regards to the latest versions of
Jikes (which have been around for a while now).

The Javac Ant task is specifying an "-encoding" option for Jikes, which
Jikes is refusing.  I'm using "Jikes Compiler - Version 1.18 - 21 November
2002" (according to the "jikes -version" command) on Win2000.  See below for
Jasper's output.

I have no problem using Jikes standalone, or with Ant 1.5.3's Javac task
(outside of Tomcat).

I'm using Sun's JDK 1.4.2 on Win2000 SP4.

Hope this helps,
Chris B.



org.apache.jasper.JasperException: Unable to compile class for JSP

An error occurred at line: -1 in the jsp file: null

Generated servlet error:
[javac] Compiling 1 source file
[javac] use: jikes [options] [EMAIL PROTECTED] file.java...
[javac] For more help, try -help or -version.
[javac] Error: The option "-encoding" is unsupported in this build.



 at
org.apache.jasper.compiler.DefaultErrorHandler.javacError(DefaultErrorHandle
r.java:130)
 at
org.apache.jasper.compiler.ErrorDispatcher.javacError(ErrorDispatcher.java:2
93)
 at org.apache.jasper.compiler.Compiler.generateClass(Compiler.java:353)
 at org.apache.jasper.compiler.Compiler.compile(Compiler.java:370)
 at
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:4
73)
 at
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:1
90)
 at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:295)
 at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:241)



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java

[remm]

remm2003/08/09 12:54:47

  Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
  Log:
  - Fix tests failures.
  - Fix array init.
  
  Revision  ChangesPath
  1.81  +5 -4  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
  
  Index: StandardContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
  retrieving revision 1.80
  retrieving revision 1.81
  diff -u -r1.80 -r1.81
  --- StandardContext.java  9 Aug 2003 19:04:29 -   1.80
  +++ StandardContext.java  9 Aug 2003 19:54:47 -   1.81
  @@ -646,7 +646,7 @@
*  this application has started, or after it has been stopped
*/
   public Object[] getApplicationLifecycleListeners() {
  -return (applicationEventListenersObjects);
  +return (applicationLifecycleListenersObjects);
   }
   
   
  @@ -658,7 +658,7 @@
* @param listeners The set of instantiated listener objects.
*/
   public void setApplicationLifecycleListeners(Object listeners[]) {
  -applicationEventListenersObjects = listeners;
  +applicationLifecycleListenersObjects = listeners;
   }
   
   
  @@ -3523,7 +3523,8 @@
   for (int i = 0; i < results.length; i++) {
   if ((results[i] instanceof ServletContextAttributeListener)
   || (results[i] instanceof ServletRequestAttributeListener)
  -|| (results[i] instanceof ServletRequestListener)) {
  +|| (results[i] instanceof ServletRequestListener)
  +|| (results[i] instanceof HttpSessionAttributeListener)) {
   eventListeners.add(results[i]);
   }
   if ((results[i] instanceof ServletContextListener)
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22146] - TC 5.0.6 problems loading an a persisted session.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22146

TC 5.0.6 problems loading an a persisted session.





--- Additional Comments From [EMAIL PROTECTED]  2003-08-08 17:28 ---
Thanks !!

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util CustomObjectInputStream.java

[remm]

remm2003/08/08 09:56:40

  Modified:catalina/src/share/org/apache/catalina/util
CustomObjectInputStream.java
  Log:
  - Using Class.forName, which somehow fixes the test case for bug 22146.
  
  Revision  ChangesPath
  1.2   +17 -14
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/CustomObjectInputStream.java
  
  Index: CustomObjectInputStream.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/CustomObjectInputStream.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- CustomObjectInputStream.java  18 Jul 2002 16:47:45 -  1.1
  +++ CustomObjectInputStream.java  8 Aug 2003 16:56:40 -   1.2
  @@ -74,9 +74,9 @@
* class loader for this web application.  This allows classes defined only
* with the web application to be found correctly.
*
  - * @@author Craig R. McClanahan
  - * @@author Bip Thelin
  - * @@version $Revision$, $Date$
  + * @author Craig R. McClanahan
  + * @author Bip Thelin
  + * @version $Revision$, $Date$
*/
   
   public final class CustomObjectInputStream
  @@ -88,13 +88,14 @@
*/
   private ClassLoader classLoader = null;
   
  +
   /**
* Construct a new instance of CustomObjectInputStream
*
  - * @@param stream The input stream we will read from
  - * @@param classLoader The class loader used to instantiate objects
  + * @param stream The input stream we will read from
  + * @param classLoader The class loader used to instantiate objects
*
  - * @@exception IOException if an input/output error occurs
  + * @exception IOException if an input/output error occurs
*/
   public CustomObjectInputStream(InputStream stream,
  ClassLoader classLoader)
  @@ -104,18 +105,20 @@
   this.classLoader = classLoader;
   }
   
  +
   /**
* Load the local class equivalent of the specified stream class
* description, by using the class loader assigned to this Context.
*
  - * @@param classDesc Class description from the input stream
  + * @param classDesc Class description from the input stream
*
  - * @@exception ClassNotFoundException if this class cannot be found
  - * @@exception IOException if an input/output error occurs
  + * @exception ClassNotFoundException if this class cannot be found
  + * @exception IOException if an input/output error occurs
*/
   public Class resolveClass(ObjectStreamClass classDesc)
   throws ClassNotFoundException, IOException {
  -
  -return (classLoader.loadClass(classDesc.getName()));
  +return Class.forName(classDesc.getName(), false, classLoader);
   }
  +
  +
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[GUMP] Build Failure - Tomcat 3.x

[Craig McClanahan]

This email is autogenerated from the output from:



Buildfile: build.xml

detect:

uptodate:

msg.ant15:
 [echo] Detected Ant 1.5

msg.jdk12:
 [echo] Detected JDK1.2

msg.jsse:
 [echo] Detected JSSE

msg.jmx:
 [echo] Detected JMX

msg.jmxtools:
 [echo] Detected JMX TOOLS

msg.puretls:

msg.commons-dbcp:
 [echo] Detected commons-DBCP and required jars

msg.jtc:

msg.jtc.util:
 [echo] tomcat-util.jar is up to date

msg.log4j:

init:

prepare.dirs:
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/conf
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/conf/auto
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/classes
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/apps
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/container
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/common
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/logs
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/bin
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/doc
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/webapps
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/modules
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat/build/tomcat/native
 [copy] Copying 10 files to /home/rubys/jakarta/jakarta-tomcat/build/tomcat/bin
 [copy] Copying 1 file to /home/rubys/jakarta/jakarta-tomcat/build/tomcat/bin
 [copy] Copying 18 files to /home/rubys/jakarta/jakarta-tomcat/build/tomcat/conf
 [copy] Copying 44 files to /home/rubys/jakarta/jakarta-tomcat/build/tomcat/doc
 [copy] Copying 85 files to /home/rubys/jakarta/jakarta-tomcat/build/tomcat/native
 [copy] Copying 1 file to /home/rubys/jakarta/jakarta-tomcat/build/tomcat
 [copy] Copying 1 file to /home/rubys/jakarta/jakarta-tomcat/build/tomcat
 [copy] Copying 1 file to 
/home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/container
 [copy] Copying 1 file to /home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/apps
 [copy] Copying 1 file to 
/home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/common
 [copy] Copying 1 file to 
/home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/common


 [move] Moving 4 files to /home/rubys/jakarta/jakarta-tomcat/build/tomcat/bin

prepare.jaxp101:

include.jaxp:

prepare.jaxp11:

prepare.xerces:

prepare.xerces2:

prepare.xml-parser:

prepare.jaxp:

prepare:

dep.tomcat-util:

tomcat_util:
[javac] Compiling 47 source files to 
/home/rubys/jakarta/jakarta-tomcat/build/tomcat/classes
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -deprecation for details.
  [jar] Building jar: 
/home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/common/core_util.jar
 [copy] Copying 2 files to 
/home/rubys/jakarta/jakarta-tomcat/build/tomcat/lib/common

BUILD FAILED
/home/rubys/jakarta/jakarta-tomcat/build.xml:467: Warning: Could not find file 
/home/rubys/jakarta/jakarta-commons/commons-logging-1.0.2/commons-logging-api.jar to 
copy.

Total time: 12 seconds

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Please confirm soln: [Bug 22226] Tomcat throws JasperExceptioninstead of NumberFormatException when parameter can't convert to bean property

[Tim Funk]

The spec says for :
"A conversion failure leads to an error, whether at translation time or 
requesttime."

From a compliance point of view, it looks like tomcat is OK that is throws a 
JasperException.

But from a user (web developer) point of view, I would think this sucks. But 
am I correct that this is not a bug? (So I can resolve as invalid)

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6

-Tim



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ContainerBase.java

[jfarcand]

jfarcand2003/08/07 16:46:18

  Modified:catalina/src/share/org/apache/catalina/core
ContainerBase.java
  Log:
  Fix :
  
  SEVERE: Error registering null
  javax.management.MBeanRegistrationException: nested exception is 
java.lang.NullPointerException
  java.lang.NullPointerException
  at 
org.apache.catalina.core.ContainerBase.preRegister(ContainerBase.java:1499)
  
  when an invalid web.xml is deployed and the digester throw an exception.
  
  Revision  ChangesPath
  1.27  +4 -0  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ContainerBase.java
  
  Index: ContainerBase.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ContainerBase.java,v
  retrieving revision 1.26
  retrieving revision 1.27
  diff -u -r1.26 -r1.27
  --- ContainerBase.java29 Jul 2003 00:09:42 -  1.26
  +++ ContainerBase.java7 Aug 2003 23:46:18 -   1.27
  @@ -1496,6 +1496,10 @@
 ObjectName name) throws Exception {
   oname=name;
   mserver=server;
  +if (name == null ){
  +return null;
  +}
  +
   domain=name.getDomain();
   
   type=name.getKeyProperty("type");
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

which method gets called first listener.sessionDestroyed() or session.invalidate()

[dutta_kaushik]

Hi All,

I have written a Http Session Listener for logging
session termination event.

In my listener I am trying to get user related data by calling getSession() then
getAttribute() method. Here I am always getting an exception saying 
IllegalStateException
: Session is already
invalidated.

Could you please tell me why session is getting invalidated before calling
listener.sessionDestroyed(..) method.

Thanks,

Kaushik Dutta

This mail was scanned by Interscan Virus Wall of Mailserver2 at SNR, TCS, Chennai

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 21366] - A JSP-Servlet translation bug

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21366

A JSP-Servlet translation bug

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-08-10 10:04 ---
It has been determined that using Xerces solves this problem. If you're using
the JDK 1.4 edition of Tomcat 4, you could be impacted.
Also, Tomcat 5 will include Xerces 2 again as a result of this bug (please
complain if you disagree with that).
The bug itself is invalid (it is not a Tomcat bug). Many thanks to Eric for
investigating the issue.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime JspFragmentHelper.java

[luehe]

luehe   2003/08/08 16:25:11

  Modified:jasper2/src/share/org/apache/jasper/runtime
JspFragmentHelper.java
  Log:
  Adapt to javax.servlet.jsp.tagext.JspFragment, which has changed from an interface 
to an abstract class
  
  Revision  ChangesPath
  1.6   +4 -4  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime/JspFragmentHelper.java
  
  Index: JspFragmentHelper.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime/JspFragmentHelper.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- JspFragmentHelper.java28 Oct 2002 18:16:21 -  1.5
  +++ JspFragmentHelper.java8 Aug 2003 23:25:11 -   1.6
  @@ -83,7 +83,7 @@
* @author Mark Roth
*/
   public abstract class JspFragmentHelper 
  -implements JspFragment 
  +extends JspFragment 
   {
   
   protected int discriminator;
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22226] - Tomcat throws JasperException instead of NumberFormatException when parameter can't convert to bean property

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6

Tomcat throws JasperException instead of NumberFormatException when parameter can't 
convert to bean property

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-08-08 17:37 ---
I feel your pain but according to the spec, this is not a bug. Making a
suggestion to the spec team (jsp-spec-comments at eng.sun.com) would be the best
solution at this point for future versions of the spec.

http://marc.theaimsgroup.com/?l=tomcat-dev&m=106036342911204&w=2

To work around this issue, I recommend asking the tomcat-user list for advice.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-servletapi-5/jsr152/src/share/javax/servlet/jsp/tagext JspFragment.java SimpleTag.java SimpleTagSupport.java TagInfo.java

[kinman]

kinman  2003/08/08 15:27:40

  Modified:jsr152/src/share/javax/servlet/jsp/tagext JspFragment.java
SimpleTag.java SimpleTagSupport.java TagInfo.java
  Log:
  - Patch by Mark Roth:
  
  The patch includes an API update from the JSP 2.0 specification.
  
  jsr152/src/share/javax/servlet/jsp/tagext/SimpleTag.java:
   - Clarified javadocs for setJspContext()
  
  jsr152/src/share/javax/servlet/jsp/tagext/SimpleTagSupport.java:
   - Clarified javadocs for setJspContext()
  
  jsr152/src/share/javax/servlet/jsp/tagext/TagInfo.java:
   - Corrected error in constructor javadoc for JSP 1.1 TLD
  
  jsr152/src/share/javax/servlet/jsp/tagext/JspFragment.java:
   - Changed to an abstract class
   - Added getJspContext() method
  
  Revision  ChangesPath
  1.6   +10 -3 
jakarta-servletapi-5/jsr152/src/share/javax/servlet/jsp/tagext/JspFragment.java
  
  Index: JspFragment.java
  ===
  RCS file: 
/home/cvs/jakarta-servletapi-5/jsr152/src/share/javax/servlet/jsp/tagext/JspFragment.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- JspFragment.java  18 Dec 2002 18:35:37 -  1.5
  +++ JspFragment.java  8 Aug 2003 22:27:40 -   1.6
  @@ -66,7 +66,7 @@
* The definition of the JSP fragment must only contain template 
* text and JSP action elements.  In other words, it must not contain
* scriptlets or scriptlet expressions.  At translation time, the 
  - * container generates an implementation of the JspFragment interface
  + * container generates an implementation of the JspFragment abstract class
* capable of executing the defined fragment.
* 
* A tag handler can invoke the fragment zero or more times, or 
  @@ -85,7 +85,7 @@
*
* @since 2.0
*/
  -public interface JspFragment {
  +public abstract class JspFragment {
   
   /**
* Executes the fragment and directs all output to the given Writer,
  @@ -104,7 +104,14 @@
* @throws java.io.IOException If there was an error writing to the 
* stream.
*/
  -public void invoke( java.io.Writer out )
  +public abstract void invoke( java.io.Writer out )
   throws javax.servlet.jsp.JspException, java.io.IOException;
  +
  +/**
  + * Returns the JspContext that is bound to this JspFragment.
  + *
  + * @return The JspContext used by this fragment at invocation time.
  + */
  +public JspContext getJspContext();
   
   }
  
  
  
  1.8   +3 -2  
jakarta-servletapi-5/jsr152/src/share/javax/servlet/jsp/tagext/SimpleTag.java
  
  Index: SimpleTag.java
  ===
  RCS file: 
/home/cvs/jakarta-servletapi-5/jsr152/src/share/javax/servlet/jsp/tagext/SimpleTag.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- SimpleTag.java12 May 2003 16:52:10 -  1.7
  +++ SimpleTag.java8 Aug 2003 22:27:40 -   1.8
  @@ -153,8 +153,9 @@
   public JspTag getParent();
   
   /**
  - * Stores the provided JSP context in the protected 
  - * jspContext field.
  + * Called by the container to provide this tag handler with
  + * the JspContext for this invocation.
  + * An implementation should save this value.
* 
* @param pc the page context for this invocation
* @see Tag#setPageContext
  
  
  
  1.9   +3 -2  
jakarta-servletapi-5/jsr152/src/share/javax/servlet/jsp/tagext/SimpleTagSupport.java
  
  Index: SimpleTagSupport.java
  ===
  RCS file: 
/home/cvs/jakarta-servletapi-5/jsr152/src/share/javax/servlet/jsp/tagext/SimpleTagSupport.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- SimpleTagSupport.java 16 May 2003 02:39:00 -  1.8
  +++ SimpleTagSupport.java 8 Aug 2003 22:27:40 -   1.9
  @@ -131,8 +131,9 @@
   }
   
   /**
  - * Stores the provided JSP context in the protected 
  - * jspContext field.
  + * Stores the provided JSP context in the private jspContext field.
  + * Subclasses can access the JspContext via 
  + * getJspContext().
* 
* @param pc the page context for this invocation
* @see SimpleTag#setJspContext
  
  
  
  1.7   +1 -1  
jakarta-servletapi-5/jsr152/src/share/javax/servlet/jsp/tagext/TagInfo.java
  
  Index: TagInfo.java
  ===
  RCS file: 
/home/cvs/jakarta-servletapi-5/jsr152/src/share/javax/servlet/jsp/tagext/TagInfo.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- TagInfo.java  31 Mar 2003 17:52:26 -  1.6
  +++ TagInfo.java  8 Aug 2003 22:27:40 -   1.7
  @@ -92,7 +92,7 @@
   public static final String B

DO NOT REPLY [Bug 22277] - SMAP LineInfo entries with an outputStartLine of 0

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22277

SMAP LineInfo entries with an outputStartLine of 0

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Blocker |Major



--- Additional Comments From [EMAIL PROTECTED]  2003-08-10 08:41 ---
I have applied your workaround.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20675] - Tomcat is not compliant with the JSP 1.2 specification.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20675

Tomcat is not compliant with the JSP 1.2 specification.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2003-08-09 05:58 ---


*** This bug has been marked as a duplicate of 20674 ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Embedded tomcat with HTTPS

[Bill Barker]

I'm going to assume that you're using 4.1.x.  In this case, you are using
the wrong Factory.  You want something like:

  Connector httpsConnector = embeddedTomcat.createConnector(null,

configuration.getHttpsPort(), true);
  CoyoteServerSocketFactory serverSocketFactory =

(CoyoteServerSocketFactory)httpsConnector.getFactory();
  serverSocketFactory.setKeystoreFile(configuration.getKeystoreFile());
  serverSocketFactory.setKeystorePass("antares");

- Original Message - 
From: "Wesley Hall" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Sunday, August 10, 2003 1:23 PM
Subject: Embedded tomcat with HTTPS


> Hello,
>   Myself and a collegue are currently working on an open source
> application, part of which involves embedding a servlet engine. I have
read
> through some tutorials and the API docs for tomcat and began development
of
> a class structure to provide this.
>
> I have, however come across a problem with my https connector. I currently
> have code that looks like this..
>
> Connector httpsConnector = embeddedTomcat.createConnector(null,
> configuration.getHttpsPort(), true);
> httpsConnector.setScheme("https");
> SSLServerSocketFactory serverSocketFactory = new SSLServerSocketFactory();
> serverSocketFactory.setKeystoreFile(configuration.getKeystoreFile());
> serverSocketFactory.setKeystorePass("antares");
> httpsConnector.setFactory(serverSocketFactory);
> embeddedTomcat.addConnector(httpsConnector);
> connectors.add(httpsConnector);
>
> configuration is a instance of a simple bean, getHttpsPort() returns 443,
> getKeystoreFile() returns the path to the keystore (generated as per the
> SSL-Howto doc). The location of the keystore is validated elsewhere in the
> code using a File object and a call to .isFile() and .canRead(), both of
> which return true when running this code.
>
> However... i am finding that although http://localhost:443 works
perfectly,
> https://localhost leaves the browser (MSIE) whirring away for 30 seconds
or
> so before displaying 'cannot find server'. With the former i get plenty of
> information in the logs but the latter adds nothing at all to the logs,
> making this problem very difficult to debug. I can change the keystore
pass
> to any value and there is no appreciable difference.
>
> Im happy to provide any more information as required...
>
> Would a kind sameritan type point me in the write direction as to what may
> be causing this issue?
>
> Regards Wesley I. Hall.
>
> P.S. I thought long and hard on whether this belonged on dev or user, but
> since we are discussing actually class structure i finally decided that
dev
> would probably be more appropriate. If i was wrong on that descision, you
> have my sincere apologies.
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>

This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication in 
error, please notify us immediately by e-mail and then delete all copies of this 
message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the 
Internet is not secure. Do not send confidential or sensitive information, such as 
social security numbers, account numbers, personal identification numbers and 
passwords, to us via ordinary (unencrypted) e-mail.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22293] - JasperLoader prepends fixed package name

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22293

JasperLoader prepends fixed package name





--- Additional Comments From [EMAIL PROTECTED]  2003-08-11 10:55 ---
This will not be implemented in 4.1.x (too big a change). I considered
backporting from 5.0.x for a long time, but chose not to do it.
Despite you not liking it, you should rely on web application reloading:
automatic JSP recompilation on access is extremely expensive performance wise,
while a programmatic (or automatic if you update the web.xml) webapp reload does
not have any performance impact. Your solution is just plain bad, and will not
be encouraged or supported (but I'm willing to apply a patch for bug 22294 if it
still exists in Tomcat 5.0.x).

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspC.java

[luehe]

luehe   2003/08/09 12:03:15

  Modified:jasper2/src/share/org/apache/jasper JspC.java
  Log:
  Replaced message with more meaningful warning
  
  Revision  ChangesPath
  1.53  +8 -5  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java
  
  Index: JspC.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java,v
  retrieving revision 1.52
  retrieving revision 1.53
  diff -u -r1.52 -r1.53
  --- JspC.java 9 Aug 2003 13:08:18 -   1.52
  +++ JspC.java 9 Aug 2003 19:03:15 -   1.53
  @@ -1023,8 +1023,11 @@
   for (int i = 0; i < libs.length; i++) {
   if( libs[i].length() <5 ) continue;
   String ext=libs[i].substring( libs[i].length() - 4 );
  -if( ! ".jar".equalsIgnoreCase( ext )) {
  -System.out.println("XXX bad jar " + libs[i]);
  +if (! ".jar".equalsIgnoreCase(ext)) {
  +if (".tld".equalsIgnoreCase(ext)) {
  +log.warn("TLD files should not be placed in "
  + + "/WEB-INF/lib");
  +}
   continue;
   }
   try {
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 21616] - Upload fails under iis5-jk2 and not under tomcat alone

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21616

Upload fails under iis5-jk2 and not under tomcat alone





--- Additional Comments From [EMAIL PROTECTED]  2003-08-11 18:17 ---
I've ran into this too. This: 
http://www.mail-archive.com/[EMAIL PROTECTED]/msg06868.html
fixed it for me. If you want the recompiled dll just send me an email
([EMAIL PROTECTED]).

Btw, if you're using iis for ntlm authentication only you might want to
try this: http://jcifs.samba.org.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22300] New: - Classloader problem when digester jar is in common/lib as well

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22300

Classloader problem when digester jar is in common/lib as well

   Summary: Classloader problem when digester jar is in common/lib
as well
   Product: Tomcat 4
   Version: 4.1.27
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Under certain circumstances it may be desirable to have a digester jar in
common/lib. Because of the well know class loader hierarchy Tomcat prefers the
digester jar in common/lib over server/lib on startup. The classes digester
tries to build from the XML are accessible over the server/lib class loader
only. Its standard class loader is the one from common/lib though. Thus it can
not find those classes resulting in the following exception:

Catalina.start: java.lang.ClassNotFoundException:
org.apache.catalina.core.StandardServer
java.lang.ClassNotFoundException: org.apache.catalina.core.StandardServer
at org.apache.commons.digester.Digester.createSAXException(Digester.java:2540)
at org.apache.commons.digester.Digester.createSAXException(Digester.java:2566)
at org.apache.commons.digester.Digester.startElement(Digester.java:1276)
at org.apache.crimson.parser.Parser2.maybeElement(Parser2.java:1535)
at org.apache.crimson.parser.Parser2.parseInternal(Parser2.java:534)
at org.apache.crimson.parser.Parser2.parse(Parser2.java:318)
at org.apache.crimson.parser.XMLReaderImpl.parse(XMLReaderImpl.java:442)
at org.apache.commons.digester.Digester.parse(Digester.java:1548)
at org.apache.catalina.startup.Catalina.start(Catalina.java:449)
at org.apache.catalina.startup.Catalina.execute(Catalina.java:400)
at org.apache.catalina.startup.Catalina.process(Catalina.java:180)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:203)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22279] - [PATCH] Typo fixes for various parts in Tomcat-FAQ

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22279

[PATCH] Typo fixes for various parts in Tomcat-FAQ





--- Additional Comments From [EMAIL PROTECTED]  2003-08-10 10:52 ---
Created an attachment (id=7719)
Fix typos in classnotfound.xml

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22279] New: - [PATCH] Typo fixes for various parts in Tomcat-FAQ

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22279

[PATCH] Typo fixes for various parts in Tomcat-FAQ

   Summary: [PATCH] Typo fixes for various parts in Tomcat-FAQ
   Product: Tomcat 4
   Version: Unknown
  Platform: Other
   URL: http://jakarta.apache.org//tomcat/faq/
OS/Version: Other
Status: NEW
  Severity: Enhancement
  Priority: Other
 Component: Webapps:Documentation
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Patches below fix several simple typos in the indicated FAQ pages.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse JSSEKeyManager.java JSSE14SocketFactory.java

[luehe]

luehe   2003/08/11 11:12:29

  Modified:util/java/org/apache/tomcat/util/net/jsse
JSSE14SocketFactory.java
  Added:   util/java/org/apache/tomcat/util/net/jsse
JSSEKeyManager.java
  Log:
  Added support for specifying alias name for server keypair and cert
  chain, to be used by the server to authenticate itself to SSL clients
  
  Revision  ChangesPath
  1.8   +30 -12
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSE14SocketFactory.java
  
  Index: JSSE14SocketFactory.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSE14SocketFactory.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- JSSE14SocketFactory.java  9 Aug 2003 17:17:17 -   1.7
  +++ JSSE14SocketFactory.java  11 Aug 2003 18:12:29 -  1.8
  @@ -56,6 +56,7 @@
* [Additional notices, if required by prior licensing conditions]
*
*/ 
  +
   package org.apache.tomcat.util.net.jsse;
   
   import java.io.*;
  @@ -64,6 +65,7 @@
   import java.security.SecureRandom;
   import javax.net.ssl.SSLContext;
   import javax.net.ssl.KeyManager;
  +import javax.net.ssl.X509KeyManager;
   import javax.net.ssl.KeyManagerFactory;
   import javax.net.ssl.TrustManager;
   import javax.net.ssl.TrustManagerFactory;
  @@ -84,6 +86,7 @@
* @author Costin Manolache
* @author Stefan Freyr Stefansson
* @author EKR -- renamed to JSSESocketFactory
  + * @author Jan Luehe
*/
   public class JSSE14SocketFactory  extends JSSESocketFactory {
   
  @@ -97,27 +100,32 @@
   void init() throws IOException {
   try {
   
  -String clientAuthStr = (String)attributes.get("clientauth");
  +String clientAuthStr = (String) attributes.get("clientauth");
   if (clientAuthStr != null){
   clientAuth = Boolean.valueOf(clientAuthStr).booleanValue();
   }
   
   // SSL protocol variant (e.g., TLS, SSL v3, etc.)
  -String protocol = (String)attributes.get("protocol");
  -if (protocol == null) protocol = defaultProtocol;
  +String protocol = (String) attributes.get("protocol");
  +if (protocol == null) {
  +protocol = defaultProtocol;
  +}
   
   // Certificate encoding algorithm (e.g., SunX509)
  -String algorithm = (String)attributes.get("algorithm");
  -if (algorithm == null) algorithm = defaultAlgorithm;
  +String algorithm = (String) attributes.get("algorithm");
  +if (algorithm == null) {
  +algorithm = defaultAlgorithm;
  +}
   
  -String keystoreType = (String)attributes.get("keystoreType");
  +String keystoreType = (String) attributes.get("keystoreType");
   if (keystoreType == null) {
   keystoreType = defaultKeystoreType;
   }
   
   // Create and init SSLContext
   SSLContext context = SSLContext.getInstance(protocol); 
  -context.init(getKeyManagers(keystoreType, algorithm),
  +context.init(getKeyManagers(keystoreType, algorithm,
  +(String) attributes.get("keyAlias")),
getTrustManagers(keystoreType),
new SecureRandom());
   
  @@ -138,16 +146,26 @@
* Gets the initialized key managers.
*/
   protected KeyManager[] getKeyManagers(String keystoreType,
  -  String algorithm)
  +  String algorithm,
  +  String keyAlias)
   throws Exception {
   
  +KeyManager[] kms = null;
  +
   String keystorePass = getKeystorePassword();
   
   KeyManagerFactory kmf = KeyManagerFactory.getInstance(algorithm);
   kmf.init(getKeystore(keystoreType, keystorePass),
keystorePass.toCharArray());
   
  -return kmf.getKeyManagers();
  +kms = kmf.getKeyManagers();
  +if (keyAlias != null) {
  +for(int i=0; ihttp://www.apache.org/)."
   *Alternately, this acknowlegement may appear in the software itself,
   *if and wherever such third-party acknowlegements normally appear.
   *
   * 4. The names "The Jakarta Project", "Tomcat", and "Apache Software
   *Foundation" must not be used to endorse or promote products derived
   *from this software without prior written permission. For written 
   *permission, please contact [EMAIL PROTECTED]
   *
   * 5. Products derived from this software may not be called "Apache"
   *nor may "Apache" appear in their names without prior written
   *permission of the Apache Group.
 

problem with tomcat servlet

[Chris]

I typed in a simple servlet example from the book "Tomcat Kick Start" (Sams).
 Basically I put the html and servlet class as follow:

$CATALINA/webapps/mybasic_servlet/CurrencyForm.html
$CATALINA/webapps/mybasic_servlet/WEB-INF/classes/CurrencyConverter.class

When I start Tomcat, and access: http://localhost:8080/mybasic_servlet/CurrencyForm.html
and type a number in the text input and submit, the browser returns a 404
error

The requested resource (/mybasic_servlet/servlet/CurrencyConverter) is
not available.

If I add a web.xml file to $CATALINA/webapps/mybasic_servlet/WEB-INF/, and
the web.xml uses 
   
    Currency Converter
    /convert
    

and changes my html to  
Now after restarting Tomcat, and access: http://localhost:8080/mybasic_servlet/CurrencyForm.html
and type a number in the text input an submit, this time the servlet gets
triggered.


I have enclosed the files and would really apprceciate if someone explain
this 404 error to me.

Thanks in advance.

-chris





http://java.sun.com/dtd/web-app_2_3.dtd";>



Currency Converter

This is a simple web application with an HTML form passing
a single parameter (amount of dollars) to a servlet for conversion.



Currency Converter
CurrencyConverter

		
rate
0.65



	
Currency Converter
/convert


	
Currency Converter
*.con


 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22294] - JSPC class name doesn't match Jasper

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22294

JSPC class name doesn't match Jasper

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2003-08-11 22:30 ---


*** This bug has been marked as a duplicate of 22293 ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 21366] - A JSP-Servlet translation bug

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21366

A JSP-Servlet translation bug





--- Additional Comments From [EMAIL PROTECTED]  2003-08-10 09:15 ---
Yes, you're right. Xerces would be there because of Ant during a precompilation,
so it works then.
This bug is basically the first good reason I've seen for bundling back Xerces 2.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Access a servlet instance from a valve

[Stephan Hartmann]

Hi,

i have written an access log valve (in fact it is a copy of the
JDBCAccessLogValve, but cause that one is final, i could not derive from
it). I use it inside the context of a webapp. Now i want to access an
instance of a servlet inside of this context.
Is this possible somehow?

Thanks,
Stephan


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] 5.0.7 stability rating

[Jean-Francois Arcand]

Remy Maucherat wrote:

Jean-Francois Arcand wrote:

Remy Maucherat wrote:


[X ] Alpha
[ ] Beta

Please vote :)

Add comments if needed. 


(1) Xerces validation doesn't work (seems the way we load the DTD is 
incorrect, producing the current error...but wait, we never know with 
Xerces ;-) ). Since validation was by default supported in 4.x, I'm 
considering this a regression.
(2) When ContextConfig was refactored, TldConfig was created but it 
is impossible right now to turn on xml validation (the implementation 
is missing). Knowing how it may sometimes create the proper TLD, I 
think the functionality needs to be implemented.

I'm working on (1) ( (2) will be easy once (1) is fixed) now and hope 
to have something soon.


Great, I don't care about either ;-) 
lol :-)

None of this is critical for a beta (off by default, and it is so slow 
you'd have to be crazy to enable it). 
Then I'm crazy :-) (to debug Xerces yes I'm crazy)



I don't understand what you mean in (2): TLD validation is not 
implemented ? 
I mean it is impossible to turn on xml validation ( the getter/setter 
are not implemented, so the default value is always set to false ). 
Costin's re-factoring was too agressive :-)

-- Jeanfrancois



Remy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler PageDataImpl.java

[kinman]

kinman  2003/08/11 17:52:50

  Modified:jasper2/src/share/org/apache/jasper/compiler
PageDataImpl.java
  Log:
  - When including a JSP document (written in the XML syntax),
in the resulting XML View of the translation unit the
root element of the included segment must have the default
namespace reset to "".
  
  Revision  ChangesPath
  1.32  +19 -3 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/PageDataImpl.java
  
  Index: PageDataImpl.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/PageDataImpl.java,v
  retrieving revision 1.31
  retrieving revision 1.32
  diff -u -r1.31 -r1.32
  --- PageDataImpl.java 11 May 2003 22:54:47 -  1.31
  +++ PageDataImpl.java 12 Aug 2003 00:52:50 -  1.32
  @@ -271,6 +271,7 @@
private StringBuffer buf;
private Compiler compiler;
private String jspIdPrefix;
  + private boolean resetDefaultNS = false;
   
// Current value of jsp:id attribute
private int jspId;
  @@ -295,7 +296,12 @@
appendXmlProlog();
appendTag(n);
} else {
  + boolean resetDefaultNSSave = resetDefaultNS;
  + if (n.isXmlSyntax()) {
  + resetDefaultNS = true;
  + }
visitBody(n);
  + resetDefaultNS = resetDefaultNSSave;
}
}
   
  @@ -400,11 +406,15 @@
   }
   
public void visit(Node.CustomTag n) throws JasperException {
  + boolean resetDefaultNSSave = resetDefaultNS;
appendTag(n);
  + resetDefaultNS = resetDefaultNSSave;
}
   
public void visit(Node.UninterpretedTag n) throws JasperException {
  + boolean resetDefaultNSSave = resetDefaultNS;
appendTag(n);
  + resetDefaultNS = resetDefaultNSSave;
}
   
public void visit(Node.JspText n) throws JasperException {
  @@ -690,10 +700,16 @@
 */
attrs = n.getNonTaglibXmlnsAttributes();
len = (attrs == null) ? 0 : attrs.getLength();
  + boolean defaultNSSeen = false;
for (int i=0; i

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11Http11Protocol.java

[Remy Maucherat]

[EMAIL PROTECTED] wrote:
luehe   2003/08/11 14:44:49
  +public void setProtocols(String k) {
  +setAttribute("protocols", k);
  +}
  +
This probably should be "sslProtocols", no ?

Remy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspC.java

[remm]

remm2003/08/12 12:29:26

  Modified:jasper2/src/share/org/apache/jasper JspC.java
  Log:
  - Beautify the insertion of the XML fragment.
  
  Revision  ChangesPath
  1.56  +8 -3  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java
  
  Index: JspC.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java,v
  retrieving revision 1.55
  retrieving revision 1.56
  diff -u -r1.55 -r1.56
  --- JspC.java 12 Aug 2003 19:11:45 -  1.55
  +++ JspC.java 12 Aug 2003 19:29:26 -  1.56
  @@ -641,12 +641,17 @@
   while (true) {
   String line2 = fragmentReader.readLine();
   if (line2 == null) {
  +writer.println();
   break;
   }
   writer.println(line2);
   }
   writer.println(insertEndMarker);
  +writer.println();
   
  +for (int i = 0; i < pos; i++) {
  +writer.print(" ");
  +}
   writer.println(line.substring(pos));
   
   while (true) {
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Tomcat-5.0.7 - FileLogger of Embedded attempts two start() callsand fails on the second.

[Remy Maucherat]

Wesley Hall wrote:

To demonstrate this problem, i have created a subclass of FileLogger with
the start() method overriden to print a stack whenever it is called. The
result is this...
java.lang.Exception: Start has been called
at
org.antares.tomcat.TomcatService$TestFileLogger.start(TomcatService.java:312
)
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1113)
at org.apache.catalina.core.StandardEngine.start(StandardEngine.java:502)
at org.apache.catalina.startup.Embedded.start(Embedded.java:1026)
at org.antares.tomcat.TomcatService.start(TomcatService.java:236)
at org.antares.tomcat.TomcatService.main(TomcatService.java:324)
java.lang.Exception: Start has been called
at
org.antares.tomcat.TomcatService$TestFileLogger.start(TomcatService.java:312
)
at
org.apache.catalina.core.StandardContext.start(StandardContext.java:3926)
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1127)
at org.apache.catalina.core.StandardHost.start(StandardHost.java:792)
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1127)
at org.apache.catalina.core.StandardEngine.start(StandardEngine.java:502)
at org.apache.catalina.startup.Embedded.start(Embedded.java:1026)
at org.antares.tomcat.TomcatService.start(TomcatService.java:236)
at org.antares.tomcat.TomcatService.main(TomcatService.java:324)
As you can see, there is only one call to Embedded.start but this results in
two calls attempting to start the logger.
The second call causes the Logger to throw a LifecycleException and the
server fails to start. The only solution i can find so far is not adding the
logger in the first place.
This wasnt a problem in 4.1.27.
Your logger seems associated with both the host and the engine (and it 
gets started by both, of course). Setting the logger to the engine only 
would work ok (it's not your fault, Embedded does it for you in 
createContext, which is incorrect; somehow, it doesn't do it in createHost).

Can you test and debug this further ?

Remy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup TldConfig.java

[jfarcand]

jfarcand2003/08/12 09:15:52

  Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
   catalina/src/share/org/apache/catalina/startup
TldConfig.java
  Log:
  Add support for Tld validation (also fix bug 21917: TldConfig.java does not set 
SystemId). Validation only works with Crimson right now.
  
  Revision  ChangesPath
  1.83  +3 -1  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
  
  Index: StandardContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
  retrieving revision 1.82
  retrieving revision 1.83
  diff -u -r1.82 -r1.83
  --- StandardContext.java  10 Aug 2003 09:47:33 -  1.82
  +++ StandardContext.java  12 Aug 2003 16:15:52 -  1.83
  @@ -3956,6 +3956,8 @@
   // Read tldListeners. XXX Option to disable
   TldConfig tldConfig = new TldConfig();
   tldConfig.setContext(this);
  +tldConfig.setXmlValidation(((StandardHost) 
getParent()).getXmlValidation());
  +tldConfig.setXmlNamespaceAware(((StandardHost) 
getParent()).getXmlNamespaceAware());
   try {
   tldConfig.execute();
   } catch (Exception ex) {
  
  
  
  1.15  +52 -28
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/TldConfig.java
  
  Index: TldConfig.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/TldConfig.java,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- TldConfig.java28 Jul 2003 22:57:41 -  1.14
  +++ TldConfig.java12 Aug 2003 16:15:52 -  1.15
  @@ -94,7 +94,7 @@
   import org.apache.commons.digester.Digester;
   import org.xml.sax.SAXNotRecognizedException;
   import org.xml.sax.SAXNotSupportedException;
  -
  +import org.xml.sax.InputSource;
   /**
* Startup event listener for a Context that configures the properties
* of that Context, and the associated defined servlets.
  @@ -149,6 +149,44 @@
   
   // - Public Methods
   
  + /**
  + * Set the validation feature of the XML parser used when
  + * parsing xml instances.
  + * @param xmlValidation true to enable xml instance validation
  + */
  +public void setXmlValidation(boolean xmlValidation){
  +this.xmlValidation = xmlValidation;
  +}
  +
  +/**
  + * Get the server.xml  attribute's xmlValidation.
  + * @return true if validation is enabled.
  + *
  + */
  +public boolean getXmlValidation(){
  +return xmlValidation;
  +}
  +
  +/**
  + * Get the server.xml  attribute's xmlNamespaceAware.
  + * @return true if namespace awarenes is enabled.
  + *
  + */
  +public boolean getXmlNamespaceAware(){
  +return xmlNamespaceAware;
  +}
  +
  +
  +/**
  + * Set the namespace aware feature of the XML parser used when
  + * parsing xml instances.
  + * @param xmlNamespaceAware true to enable namespace awareness
  + */
  +public void setXmlNamespaceAware(boolean xmlNamespaceAware){
  +this.xmlNamespaceAware=xmlNamespaceAware;
  +}
  +
  +
   public boolean isRescan() {
   return rescan;
   }
  @@ -177,6 +215,7 @@
   return result;
   }
   
  +
   /**
* Scan for and configure all tag library descriptors found in this
* web application.
  @@ -458,7 +497,7 @@
   
   JarFile jarFile = null;
   String name = null;
  -InputStream inputStream = null;
  +InputSource inputSource = null;
   
   String jarPath = file.getAbsolutePath();
   
  @@ -477,10 +516,9 @@
   if (log.isTraceEnabled()) {
   log.trace("  Processing TLD at '" + name + "'");
   }
  -inputStream = jarFile.getInputStream(entry);
  -tldScanStream(inputStream);
  -inputStream.close();
  -inputStream = null;
  +inputSource = new InputSource(jarFile.getInputStream(entry));
  +tldScanStream(inputSource);
  +inputSource = null;
   name = null;
   }
   } catch (Exception e) {
  @@ -494,13 +532,6 @@
 e);
   }
   } finally {
  -if (inputStream != null) {
  -try {
  -inputStream.close();
  -} catch (Throwable t) {
  -// Ignore
  -}
  -}
 

cvs commit: jakarta-tomcat-catalina/webapps/admin/WEB-INF web.xml

[remm]

remm2003/08/12 12:41:11

  Modified:webapps/admin/WEB-INF web.xml
  Log:
  - Remove useless "insert here" marker.
  
  Revision  ChangesPath
  1.8   +0 -2  jakarta-tomcat-catalina/webapps/admin/WEB-INF/web.xml
  
  Index: web.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/admin/WEB-INF/web.xml,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- web.xml   18 Mar 2003 10:48:14 -  1.7
  +++ web.xml   12 Aug 2003 19:41:11 -  1.8
  @@ -95,8 +95,6 @@
   2
 
   
  -   
  -
 
 
   action
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/ROOT/WEB-INF web.xml

[remm]

remm2003/08/12 12:40:38

  Modified:webapps/ROOT/WEB-INF web.xml
  Log:
  - Remove useless "insert here" marker.
  
  Revision  ChangesPath
  1.4   +0 -2  jakarta-tomcat-catalina/webapps/ROOT/WEB-INF/web.xml
  
  Index: web.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/ROOT/WEB-INF/web.xml,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- web.xml   15 Feb 2003 22:31:17 -  1.3
  +++ web.xml   12 Aug 2003 19:40:38 -  1.4
  @@ -10,6 +10,4 @@
Welcome to Tomcat
 
   
  -   
  -
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[VOTE] 5.0.7 stability rating

[Remy Maucherat]

[ ] Alpha
[ ] Beta

Please vote :)

Add comments if needed.

Note 1: A note will be added about the need to disable smap generation 
in case of an error in SmapStratum during compilation. Other than this 
problem, I believe this build to be of good overall quality.

Note 2: As far as I am concerned, the 5.0.7 build is feature complete 
(ie, my TODO list is empty). I will now focus on tweaks and bugs. This 
probably means a slower release cycle (assuming this build is voted as 
beta). If anyone has ideas about new items, I think it's safe to say 
it's now or never (at least for the initial 5.0.x release) ;-)

Note 3: I'll be away with little internet connectivity between 08/13 and 
08/19 (included). If this vote could be wrapped up *before* I leave, it 
would be good, but it's not essential, so I don't want people to rush 
and skimp on testing (changing 5.0.7 from alpha to beta and making the 
necessary announcements should be simple enough).

Note 4: 4.1.x went to beta at 4.1.7 (5.0.x's codebase was then created 
from that tag). It is an interesting coincidence. However, I feel like 
5.0.x is considerably more stable than 4.1.x was at this stage (not very 
surprising, with brand new connectors and rewritten Jasper for 4.1.x), 
and I don't feel any particular urge to create a branch either ;-)

Remy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Jasper: TagHandlerPool for each Page and TagHandlerPoolFactory

[Michael Pearce]

Hello all.

I was just looking over the code generated by Jasper in Tomcat 4.1.27.  For
my  tag, the following code is generated for the page:

  public baseLayout_jsp() {
_jspx_tagPool_c_url_value = new
org.apache.jasper.runtime.TagHandlerPool();
  }

Is there any reason that there is a separate pool created for each page?  It
would seem like it would be more efficient (i.e. less Tag Objects created)
if there was a single pool.

After looking at the latest CVS source, it looks like the Jasper generated
code may have changed to something more like:
  public baseLayout_jsp() {
_jspx_tagPool_c_url_value =
org.apache.jasper.runtime.TagHandlerPool.getTagHandlerPool(config);
  }

It appears that the instantiation code has been moved inside of
TagHandlerPool.  Unfortunately, there is still no control over the
TagHandlerPool instantiation by an outside Tag Pool.  I think it would be
better to specify a "tagpoolFactoryClassName" instead of "tagpoolClassName".
Being able to only specify the "tagpoolClassName" does not provide as much
flexibility (since a new TagpoolHandler is always created with a call to
getTagHandlerPool(ServletConfig)).  This way, the TagHandlerPoolFactory
could decide if it wants to always create new TagHandlerPool Objects (as the
current implementation does) or re-use the same TagHandlerPool (which I
would like to implement).

The Factory would be simple:

/*
* Implementions should specify a public no-args constructor.
*/
public interface TagHandlerPoolFactory {
  TagHandlerPool getTagHandlerPool(config);
}

A static instance of TagHandlerPoolFactory could be created in
TagHandlerPool and used for each call to
TagHandlerPool.getTagHandlerPool(ServletConfig).

-mike


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22300] - Classloader problem when digester jar is in common/lib as well

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22300

Classloader problem when digester jar is in common/lib as well





--- Additional Comments From [EMAIL PROTECTED]  2003-08-11 13:53 ---
Created an attachment (id=7751)
Proposed patch, setting digester class loader to the one from server/lib

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse JSSE13SocketFactory.java

[remm]

remm2003/08/12 05:01:27

  Modified:util/java/org/apache/tomcat/util/net/jsse
JSSE13SocketFactory.java
  Log:
  - Fix the build. Please do ant clean; ant after modifying any interface
or superclass (or after any big commit). Thanks.
  
  Revision  ChangesPath
  1.2   +6 -1  
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSE13SocketFactory.java
  
  Index: JSSE13SocketFactory.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSE13SocketFactory.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- JSSE13SocketFactory.java  18 Jul 2003 05:26:45 -  1.1
  +++ JSSE13SocketFactory.java  12 Aug 2003 12:01:27 -  1.2
  @@ -155,7 +155,12 @@
   sslProxy = context.getServerSocketFactory();
   
   // Determine which cipher suites to enable
  -enabledCiphers = getEnabledCiphers(sslProxy.getSupportedCipherSuites());
  +String requestedCiphers = (String)attributes.get("ciphers");
  +if (requestedCiphers != null) {
  +enabledCiphers = getEnabledCiphers
  +(requestedCiphers,
  + sslProxy.getSupportedCipherSuites());
  +}
   
   } catch(Exception e) {
   if( e instanceof IOException )
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Resend: Tomcat 4.1.24 & JVM 1.4.2 security hole?

[Jeff Tulley]

Verified on Win XP as well.  Using that flag fixes the problem.  Thanks
for making that connection!  

Jeff Tulley  ([EMAIL PROTECTED])
(801)861-5322
Novell, Inc., The Leading Provider of Net Business Solutions
http://www.novell.com

>>> [EMAIL PROTECTED] 8/12/03 7:02:01 PM >>>
Oups I've missed the discussion . There is a 1.4.2 bug found by Remy 
(and reported in bugtraq as 4895132. I'm not sure you can access the 
bug). The workaround is to add the following property when starting
Tomcat:

-Dsun.io.useCanonCaches=false

Can you try it and see if that fixe the problem (I don't have a winXX)?


-- Jeanfrancois


Jeff Tulley wrote:

>The user list has been busy lately discussing a possible security
hole,
>but only 1/3 of the people in the thread could see the problem.  I
>finally got to where I could see it using Tomcat 4.1.24 and JVM
1.4.2,
>but NOT with JVM 1.4.1.
>
>The vulnerability is that if you stick a "%20" on the end of a .jsp
>url, you get the source.
>
>I forgot to mention the platforms where this has been seen.  I have
>seen this with Sun's JVM 1.4.2 on Windows XP, and now I just verified
>that it also exists on NetWare's JVM 1.4.2 (built on Sun's source
code
>base, so not surprising)  It might exist on other 1.4.2
implementations,
>but I am not sure. 
>
>I also just verified this on Tomcat 4.1.18 and 4.1.26 as well.
>
>For some reason I see it better with the example jsp's -
>/examples/jsp/num/numbguess.jsp%20 for instance.  But, you can tell
the
>problem is going to be there if, when you add the "%20" to the .jsp
>name, you don't get a 404.  This is all going directly to port 8080,
so
>no native connector is involved.
>
>Jeff Tulley  ([EMAIL PROTECTED])
>(801)861-5322
>Novell, Inc., The Leading Provider of Net Business Solutions
>http://www.novell.com 
>
>-
>To unsubscribe, e-mail: [EMAIL PROTECTED] 
>For additional commands, e-mail: [EMAIL PROTECTED] 
>
>
>  
>


-
To unsubscribe, e-mail: [EMAIL PROTECTED] 
For additional commands, e-mail: [EMAIL PROTECTED] 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup Embedded.java

[remm]

remm2003/08/12 02:04:09

  Modified:catalina/src/share/org/apache/catalina/startup Embedded.java
  Log:
  - Remove extra setLogger call in createContext.
  
  Revision  ChangesPath
  1.9   +1 -2  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/Embedded.java
  
  Index: Embedded.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/Embedded.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- Embedded.java 16 Jul 2003 00:18:11 -  1.8
  +++ Embedded.java 12 Aug 2003 09:04:08 -  1.9
  @@ -646,7 +646,6 @@
   context.setDebug(debug);
   context.setDocBase(docBase);
   context.setPath(path);
  - context.setLogger(logger);
   
   ContextConfig config = new ContextConfig();
   config.setDebug(debug);
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20663] - Cannot shutdown Tomcat gracefully

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20663

Cannot shutdown Tomcat gracefully





--- Additional Comments From [EMAIL PROTECTED]  2003-08-12 15:33 ---
when using tomcat also with SSL under Port 8443, it now happens also with Redhat 9

also watch out, if my below script has DOS linefeeds and you try to execute
under Linux, you get
: bad interpreter: No such file or directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] New committer: Eric Carmichael

[Jean-Francois Arcand]

+1.

If he like Xerces, he can jump on that side too ;-)

-- Jeanfrancois

Remy Maucherat wrote:

I'd like to nominate Eric Carmichael as a committer on the Tomcat 
project. Eric has been steadily supplying quality patches to the new 
Jasper which will implement the JSP 2.0 specification, and has helped 
fix outstanding bug reports. He plans to continue contributing in the 
future.

He has my +1.

Remy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Bug 19867

[Bill Barker]

- Original Message -
From: "Mark Thomas" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Monday, August 11, 2003 3:23 PM
Subject: RE: Bug 19867


> I have been looking into
>
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19867
>
> and have a couple of questions.
>
> The error seen in this report is a result of specifying CLIENT-CERT
> authentication without specifying a user-data-constraint. This causes a
NPE
> because the sslSupport attribute of the http11Processor object is null.
>
> I have looked at the servlet spec (2.3 and the draft of 2.4) and, based on
the
> 2.4 draft, the user-data-constraint is not mandatory (end of SRV.12.8) and
the
> use of CLIENT-CERT requires SSL (SRV.12.5.4). With this in mind, my first
> question is:
>
> 1. If a user wants to use CLIENT-CERT should they have to specify a
> user-data-constraint or should tomcat automatically apply SSL to the
resources
> in the web resource collection specified in the security constraint when
the
> auth constraint is CLIENT-CERT? Having read the spec, I can't figure out
what
> should happen.

Having CLIENT-CERT imply a transport-guarantee sounds like a nice idea.
However, it would violate section 12.8 of the current draft of the 2.4 spec.
If the spec changes, then we could add it as a feature.  If you feel
strongly about this, then [EMAIL PROTECTED] is the place to
write.

>
> Regardless of the answer to the above, if CLIENT-CERT is specified,
> user-data-constraint is set to CONFIDENTIAL and there are no valid certs
on the
> client a number of exceptions get thrown by tomcat. This brings me to my
> remaining question:
>
> 2. Not having a matching certificate is equivalent to getting the password
> wrong. Therefore, shouldn't tomcat behave in a similar way (no exceptions,
> return a 403 to the client) rather than throwing the exceptions?

SSL doesn't work that way.  If the client's cert can't be validated, then
the connection is just dropped, so there is no way to send anything back to
the client.  If the certificate is valid, but not a known user, then Tomcat
treats it the same way that it would Basic or Form.

This isn't that big of an issue, for the simple reason that browsers
generally don't give you the option to re-select a cert once you've chosen
one.  You're stuck having to close the browser and start all over again.

>
> With some guidance on the above, assuming that some code changes will be
> required, I'll set about writing a patch.
>
> Note: Although the bug is reported against 4.1.24, the same behaviour is
seen
> with the latest 4.x.x and 5.x.x
>
> Regards,
>
> Mark
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>

This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication in 
error, please notify us immediately by e-mail and then delete all copies of this 
message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the 
Internet is not secure. Do not send confidential or sensitive information, such as 
social security numbers, account numbers, personal identification numbers and 
passwords, to us via ordinary (unencrypted) e-mail.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22293] - JSPC class name doesn't match Jasper

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22293

JSPC class name doesn't match Jasper





--- Additional Comments From [EMAIL PROTECTED]  2003-08-12 02:29 ---
the above patch does have a problem with loading the classes when a package is
specified, so is not suitable for general purpose usage at the moment.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: WebAppClassLoader, debug level

[Ias]

See http://210.216.114.100/linotype/news/39/ .

Hoping this would help you,

Ias. 

> 
> -Original Message-
> From: Oliver Wulff [mailto:[EMAIL PROTECTED] 
> Sent: Tuesday, August 12, 2003 10:02 PM
> To: [EMAIL PROTECTED]
> 
> 
> 
> 
> 
> How can I increase the debug level of the webappclassloader? 
> I set the attribute debug of the context and set a FileLogger:
> 
>   reloadable="true" crossContext="true"> 
>   prefix="localhost_bere_log." suffix=".txt"
>   timestamp="true"/>
> 
> 
> But the log events weren't logged as I expected. I'm 
> interested in checking which class has been loaded by which 
> classloader.
> 
> 
> 
> 
> 
> 
> *** BITTE BEACHTEN *** Diese 
> Nachricht (wie auch allfallige Anhange dazu) beinhaltet 
> moglicherweise vertrauliche oder gesetzlich geschutzte Daten 
> oder Informationen. Zum Empfang derselben ist (sind) 
> ausschliesslich die
> genannte(n) Person(en) bestimmt. Falls Sie diese Nachricht 
> irrtumlicherweise erreicht hat, sind Sie hoflich gebeten, 
> diese unter Ausschluss jeder Reproduktion zu zerstoren und 
> die absendende Person umgehend zu benachrichtigen. Vielen 
> Dank fur Ihre Hilfe.
> 
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20738] - Session variable returns null in non-SSL page

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20738

Session variable returns null in non-SSL page

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME



--- Additional Comments From [EMAIL PROTECTED]  2003-08-12 19:07 ---
I have tested this on 4.1.24, 4.1.x-HEAD and 5.x.x-HEAD and cannot reproduce 
it.
If you can provide a more detailed test case (eg a war that exhibits the 
problem) I would be happy to look at it again.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler SmapStratum.java

[remm]

remm2003/08/12 09:19:52

  Modified:jasper2/src/share/org/apache/jasper/compiler
SmapStratum.java
  Log:
  - Don't merge SMAP entries in the outptStartLines aren't consecutive
(note: the input numbers are still incorrect, for example when using a tag
invocation and it has been extracted out of the main _jspService).
  
  Revision  ChangesPath
  1.8   +7 -5  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/SmapStratum.java
  
  Index: SmapStratum.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/SmapStratum.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- SmapStratum.java  10 Aug 2003 08:35:39 -  1.7
  +++ SmapStratum.java  12 Aug 2003 16:19:52 -  1.8
  @@ -208,7 +208,7 @@
* Combines consecutive LineInfos wherever possible
*/
   public void optimizeLineSection() {
  -
  +
   //Incorporate each LineInfo into the previous LineInfo's 
   //outputLineIncrement, if possible
   int i=0;
  @@ -216,15 +216,17 @@
   LineInfo li = (LineInfo)lineData.get(i);
   LineInfo liNext = (LineInfo)lineData.get(i+1);
   if (liNext.inputStartLine == li.inputStartLine
  - && liNext.inputLineCount==1
  -  && li.inputLineCount==1) {
  -li.setOutputLineIncrement(liNext.outputStartLine - 
li.outputStartLine + liNext.outputLineIncrement);
  +&& liNext.inputLineCount==1
  +&& li.inputLineCount==1
  +&& liNext.outputStartLine == li.outputStartLine + 
li.inputLineCount*li.outputLineIncrement) {
  +li.setOutputLineIncrement
  +(liNext.outputStartLine - li.outputStartLine + 
liNext.outputLineIncrement);
   lineData.remove(i+1);
   } else {
   i++; 
   }
   }
  -
  +
   //Incorporate each LineInfo into the previous LineInfo's
   //inputLineCount, if possible
   i=0;
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Resend: Tomcat 4.1.24 & JVM 1.4.2 security hole?

[Jean-Francois Arcand]

Oups I've missed the discussion . There is a 1.4.2 bug found by Remy 
(and reported in bugtraq as 4895132. I'm not sure you can access the 
bug). The workaround is to add the following property when starting Tomcat:

-Dsun.io.useCanonCaches=false

Can you try it and see if that fixe the problem (I don't have a winXX)? 

-- Jeanfrancois

Jeff Tulley wrote:

The user list has been busy lately discussing a possible security hole,
but only 1/3 of the people in the thread could see the problem.  I
finally got to where I could see it using Tomcat 4.1.24 and JVM 1.4.2,
but NOT with JVM 1.4.1.
The vulnerability is that if you stick a "%20" on the end of a .jsp
url, you get the source.
I forgot to mention the platforms where this has been seen.  I have
seen this with Sun's JVM 1.4.2 on Windows XP, and now I just verified
that it also exists on NetWare's JVM 1.4.2 (built on Sun's source code
base, so not surprising)  It might exist on other 1.4.2 implementations,
but I am not sure. 

I also just verified this on Tomcat 4.1.18 and 4.1.26 as well.

For some reason I see it better with the example jsp's -
/examples/jsp/num/numbguess.jsp%20 for instance.  But, you can tell the
problem is going to be there if, when you add the "%20" to the .jsp
name, you don't get a 404.  This is all going directly to port 8080, so
no native connector is involved.
Jeff Tulley  ([EMAIL PROTECTED])
(801)861-5322
Novell, Inc., The Leading Provider of Net Business Solutions
http://www.novell.com 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util Enumerator.java

[luehe]

luehe   2003/08/12 12:56:53

  Modified:catalina/src/share/org/apache/catalina/util Enumerator.java
  Log:
  - Fixed logic so that iterator actually gets cloned when "clone" is set to
TRUE.
  - Replaced LinkedList with more efficient ArrayList.
  
  Revision  ChangesPath
  1.3   +8 -8  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/Enumerator.java
  
  Index: Enumerator.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/Enumerator.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- Enumerator.java   29 Apr 2003 21:51:51 -  1.2
  +++ Enumerator.java   12 Aug 2003 19:56:53 -  1.3
  @@ -69,7 +69,7 @@
   import java.util.Enumeration;
   import java.util.Iterator;
   import java.util.List;
  -import java.util.LinkedList;
  +import java.util.ArrayList;
   import java.util.Map;
   import java.util.NoSuchElementException;
   
  @@ -139,11 +139,11 @@
   public Enumerator(Iterator iterator, boolean clone) {
   
   super();
  -if (clone) {
  +if (!clone) {
   this.iterator = iterator;
   } else {
  -List list = new LinkedList();
  -while(iterator.hasNext()) {
  +List list = new ArrayList();
  +while (iterator.hasNext()) {
   list.add(iterator.next());
   }
   this.iterator = list.iterator();   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Bug Report - 4.1.27 Race Condition

[Remy Maucherat]

Wesley Hall wrote:
Hello,

I have found a small bug during my work embedding the tomcat server into our
application.
When a secure connector is added to an instance of Embedded, and embedded is
startd and stopped several times in quick succession (which is part of our
test framework) a race condition occurs.
Sometimes i am presented with an exception with a root cause of...

Caused by: LifecycleException: Coyote connector has not been started
at org.apache.coyote.tomcat4.CoyoteConnector.stop(CoyoteConnector.java:1199)
at org.apache.catalina.startup.Embedded.stop(Embedded.java:1030)
(NOTE: This exception is thrown after a call to the start method of Embedded
has been made and connectors added)
Other times the test is successful. Sometimes (although a little more rare
than these two outcomes), I recieve an 'Address already in use', which seems
to be the inverse of the exception above, and occurs on a call to start()
after a stop() has already been made.
Placing a Thread.sleep(x) between start/stop attempts seems to increase the
likelyhood of the test being successful and increasing the interval increase
the percentage of successful test runs until upon reaching an interval of
75ms the success rate becomes 100%.
Unless there's a major unexpected flaw and I missed something, I do 
believe that the shutdown is synchronous if you use the stop method 
(using the shutdown socket is not synchronous, but it's another 
problem). That means that something, somehwere, is being shutdown 
asynchronously related to SSL, be it at the OS level or at the JDK 
level. Given that SSL uses a non trivial amount of resources, which also 
take a significant amount of time to allocate, I'm not completely 
surprised by what you see.

As your next paragraph states, it would be useful to double check in the 
Tomcat code, but I don't expect you would find much. I believe it's 
rather straightforward code.

IMO, you should make a quick pass looking for an obvious flaw, then go 
with a 100ms delay. Unless you have to restart the embedded TC every 2s, 
I think it should be acceptable.

It seems there is a race condition in starting up or shutting down of
Embedded vs The secure connector. Sometimes Embedded.start() will return
before the connector has been started and the same with Embedded.stop().
Unfortunatly, i cannot seem to locate the Coyote source to verify this.
It's part of the source distribution, in the j-t-connectors directory.

Presumably, this issue is pretty minor as the only circumstance i can see
where someone will be running stops and starts in quick succession is a
contrived test case, but i thought i would bring it to your attention
anyway.
Remy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources messages.properties messages_es.properties messages_fr.properties messages_ja.properties

[kinman]

kinman  2003/08/14 17:06:10

  Modified:jasper2/src/share/org/apache/jasper/compiler
JspDocumentParser.java
   jasper2/src/share/org/apache/jasper/resources
messages.properties messages_es.properties
messages_fr.properties messages_ja.properties
  Log:
  - Spec has been changed to allow for include-prelude and include-coda in
jsp-config.
  
  Revision  ChangesPath
  1.65  +35 -17
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspDocumentParser.java
  
  Index: JspDocumentParser.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspDocumentParser.java,v
  retrieving revision 1.64
  retrieving revision 1.65
  diff -u -r1.64 -r1.65
  --- JspDocumentParser.java11 Aug 2003 21:11:07 -  1.64
  +++ JspDocumentParser.java15 Aug 2003 00:06:09 -  1.65
  @@ -149,18 +149,6 @@
   inStream,
   isTagFile,
   directivesOnly);
  -
  - // It's an error to have a prelude or a coda associated with
  - // a JSP document
  - if (!jspDocParser.pageInfo.getIncludePrelude().isEmpty()) {
  - String file = (String) jspDocParser.pageInfo.getIncludePrelude().get(0);
  - jspDocParser.err.jspError("jsp.error.prelude.xml", path, file);
  - }
  - if (!jspDocParser.pageInfo.getIncludeCoda().isEmpty()) {
  - String file = (String) jspDocParser.pageInfo.getIncludeCoda().get(0);
  - jspDocParser.err.jspError("jsp.error.coda.xml", path, file);
  - }
  -
Node.Nodes pageNodes = null;
   
try {
  @@ -171,8 +159,10 @@
dummyRoot.setJspConfigPageEncoding(jspConfigPageEnc);
dummyRoot.setIsEncodingSpecifiedInProlog(isEncodingSpecifiedInProlog);
jspDocParser.current = dummyRoot;
  -
  - if (parent != null) {
  + if (parent == null) {
  + jspDocParser.addInclude(dummyRoot,
  + jspDocParser.pageInfo.getIncludePrelude());
  + } else {
jspDocParser.isTop = false;
}
   
  @@ -192,6 +182,11 @@
// Parse the input
saxParser.parse(jspDocParser.inputSource, jspDocParser);
   
  + if (parent == null) {
  + jspDocParser.addInclude(dummyRoot,
  + jspDocParser.pageInfo.getIncludeCoda());
  + }
  +
// Create Node.Nodes from dummy root
pageNodes = new Node.Nodes(dummyRoot);
   
  @@ -202,6 +197,29 @@
}
   
return pageNodes;
  +}
  +
  +/*
  + * Processes the given list of included files.
  + *
  + * This is used to implement the include-prelude and include-coda
  + * subelements of the jsp-config element in web.xml
  + */
  +private void addInclude(Node parent, List files) throws SAXException {
  + if (files != null) {
  + Iterator iter = files.iterator();
  + while (iter.hasNext()) {
  + String file = (String) iter.next();
  + AttributesImpl attrs = new AttributesImpl();
  + attrs.addAttribute("", "file", "file", "CDATA", file);
  +
  + // Create a dummy Include directive node
  + Node includeDir = new Node.IncludeDirective(attrs, 
  +null, // XXX
  +parent);
  + processIncludeDirective(file, includeDir);
  + }
  + }
   }
   
   /*
  
  
  
  1.131 +1 -3  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages.properties
  
  Index: messages.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages.properties,v
  retrieving revision 1.130
  retrieving revision 1.131
  diff -u -r1.130 -r1.131
  --- messages.properties   14 Aug 2003 21:16:52 -  1.130
  +++ messages.properties   15 Aug 2003 00:06:09 -  1.131
  @@ -388,8 +388,6 @@
   jsp.error.variable.either.name=Either name-given or name-from-attribute attribute 
must be specified in a variable directive
   jsp.error.variable.both.name=Cannot specified both name-given or 
name-from-attribute attributes in a variable directive
   jsp.error.variable.alias=Both or none of the name-from-attribute and alias 
attributes can be specified in a variable directive
  -jsp.error.prelude.xml=The JSP document {0} has a prelude ({1}) associated with it
  -jsp.error.coda.xml=The JSP document {0} has a coda ({1}) associated with it
   jsp.error.attribute.null_name=Null attribu

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteResponse.java

[Bill Barker]

- Original Message -
From: <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Tuesday, August 12, 2003 5:13 PM
Subject: cvs commit:
jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5
CoyoteResponse.java


> luehe   2003/08/12 17:13:43
>
>   Modified:catalina/src/share/org/apache/coyote/tomcat5
> CoyoteResponse.java
>   Log:
>   Optimizations:
>
>   - Bugtraq 4730584 ("HttpResponseBase should create date format only
> when needed")
>
>   - Bugtraq 4701695 ("avoid reformatting constant Expires header on every
> request")

The CoyoteResponse is a pretty long-living object.  I wouldn't expect that
this will speed Tomcat up at all once it has been running for a while.

This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication in 
error, please notify us immediately by e-mail and then delete all copies of this 
message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the 
Internet is not secure. Do not send confidential or sensitive information, such as 
social security numbers, account numbers, personal identification numbers and 
passwords, to us via ordinary (unencrypted) e-mail.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

WebAppClassLoader, debug level

[Oliver Wulff]

How can I increase the debug level of the webappclassloader? I set the
attribute debug of the context and set a FileLogger:





But the log events weren't logged as I expected. I'm interested in checking
which class has been loaded by which classloader.






*** BITTE BEACHTEN ***
Diese Nachricht (wie auch allfällige Anhänge dazu) beinhaltet
möglicherweise vertrauliche oder gesetzlich geschützte Daten oder
Informationen. Zum Empfang derselben ist (sind) ausschliesslich die
genannte(n) Person(en) bestimmt. Falls Sie diese Nachricht
irrtümlicherweise erreicht hat, sind Sie höflich gebeten, diese unter
Ausschluss jeder Reproduktion zu zerstören und die absendende Person
umgehend zu benachrichtigen. Vielen Dank für Ihre Hilfe.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22236] - JNDI Realm authentication to Novell eDirectory via LDAP

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22236

JNDI Realm authentication to Novell eDirectory via LDAP

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
 Status|RESOLVED|REOPENED
 Resolution|FIXED   |



--- Additional Comments From [EMAIL PROTECTED]  2003-08-12 21:45 ---
I've been running into the same problem.  Coincidentally, also using Novell
eDirectory.  Perhaps Novell is unique in returning roles with null attributes?

I have a user, it belonged to a group called intranet.  I was able to
authenticate an application using this role.  Then my Novell admin added the
user to a new group, and I started getting the NPE.  Turns out the second group
I was added to returns null attributes.

I got around the NPE a while back by adding that null check, but I think the
right thing to do is to modify the addAttributeValues method to return the
original "values" argument that was passed to the method.  In my case, the null
values on the second role returned in my SearchResults were causing the whole
list to be nullified, and I couldn't authenticate even though the intranet role
was found.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 19799] - Tomcat dies after being up for a while (complains about maxThreads)

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19799

Tomcat dies after being up for a while (complains about maxThreads)





--- Additional Comments From [EMAIL PROTECTED]  2003-08-13 07:18 ---
Please submit a test case. If what you say is true, and is caused by Tomcat,
then it should be reproduceable.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22266] - Keep template text together with mappedfile="true"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22266

Keep template text together with mappedfile="true"





--- Additional Comments From [EMAIL PROTECTED]  2003-08-13 18:43 ---
There is no doubt that concatenating contiguous template texts into one improves
the runtime performance and I am not too worry about spending extra time during
compilation, since I believe web applications should be deployed precompiled.

My suggestion for a separate pass was motivated by the design principle to keep
the modules simple and direct.  The current compiler is made up of a number of
passes, driven by the common data structure (Node and PageInof etc).  I'd like
to keep Parser only doing the basic parsing, but leaves the optimizations to
other passes.  Not only will it be easier for debugging and maintenance,
switching on and off such optimizations will also made easier.

Like I said, this no big deal, so I'll leave the patch in for now.  Anyway,
thanks for contributing to improve Jasper, and don't let slight disagreements
like this prevent you from making more contributions in the future.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22388] - TC 5.0.7 Startup Exception

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22388

TC 5.0.7 Startup Exception

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|TC 5.0.6 Startup Exception  |TC 5.0.7 Startup Exception

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22390] New: - init() method called twice

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22390

init() method called twice

   Summary: init() method called twice
   Product: Tomcat 4
   Version: 4.1.27
  Platform: All
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Servlet & JSP API
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


A servlet's init() (without ServletConfig as argument) method is called twice if
it is loaded on startup. It seemed the servlet class is loaded twice. I have a
static variable which is instantiated in the init(). The second time init() is
called, it is still null.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Fwd: Re: security hole on windows tomcat?

[Reshat Sabiq]

If the bug was caused by adding %20 to a page/folder in URL, then i 
didn't reproduce it in Tomcat 5. I got 404 (the only bad thing is that 
404's don't appear to be customizable with error-page directives in 
web.xml).
What would be a good list to watch for these kinds of bugs in Tomcat?

Thanks.

Paul Sundling wrote:

Yes, adding

-Dsun.io.useCanonCaches=false

to the tomcat seemed to fix the security hole I discovered on my 
4.1.24 tomcat on Windows XP using JDK 1.4.2.  Great job finding a 
solution.  It's a testament to open source and cooperation.  
Fortunately it's JSP source it's showing and people should have 
anything worth seeing in their servlets or EJBs anyway. :) 
Paul Sundling

Jeff Tulley wrote:

I just wanted to make sure you saw this -- Jeanfrancois made the
connection that this issue has a known workaround, so you don't have to
backrev your JVM if you don't want to.
I tried this on Windows XP and NetWare and it worked in both places...

Jeff Tulley  ([EMAIL PROTECTED])
(801)861-5322
Novell, Inc., The Leading Provider of Net Business Solutions
http://www.novell.com
 

[EMAIL PROTECTED] 8/12/03 7:08:50 PM >>>
  

Sorry I've just realize this thread may be related to bugtraq #4895132
(thanks to Jeff for the wake up mail on tomcat-dev ;-) ). The
workaround is to add the following property when starting Tomcat:
-Dsun.io.useCanonCaches=false

Can someone try it and let me know if it change something. If this is 
not working, then point me to a very simple test case and I will file a

new bugtraq bug.

-- Jeanfrancois

Eric J. Pinnell wrote:

 

I think at this point this might be a worthwile canidate for Sun's
bugparade.  At least get it on their radars (if they don't know about
  
it
 

already).  It's interesting that the bug doesn't show up in Tomcat
  
4.1.27.
 

When 1.4.2 was released 4.1.24 was the latest stable build.

Regardless the JDK/appserver/whatever should never puke it's guts and
  
spit
 

out the source code when it gets a request it doesn't know how to
  
deal
 

with.  Upon failure it should result in some kind of error.  Sun
  
might
 

care about this...

-e

On Tue, 12 Aug 2003, Jeff Tulley wrote:



  

It is highly possible that this is dependent on the JVM you have
installed.  I actually finally WAS able to see this on Windows XP,


but
 

only if Tomcat was running on JVM 1.4.2.  The problem did NOT happen
with 1.4.1.  Of course, JVM version is the one item I left off of my
"poll" in my email below.  :)
I'm trying to verify this on other OS's and track down what the


actual
 

problem is.

But, if you run Tomcat on JVM 1.4.2, verify if you have this


problem.
 

Jeff Tulley  ([EMAIL PROTECTED])
(801)861-5322
Novell, Inc., The Leading Provider of Net Business Solutions
http://www.novell.com
 


[EMAIL PROTECTED] 8/12/03 4:10:53 PM >>>
   
  

Tomcat 4.0.6 on Win2K via direct connection to Tomcat on localhost


via
 

either port 8080 or port 80 - pages return fine without the %20
suffix,
always return http 404 with the suffix.
Murray
-Original Message-
From: Jeff Tulley [mailto:[EMAIL PROTECTED] Sent: Wednesday, 13 
August 2003 02:41
To: [EMAIL PROTECTED] Subject: RE: security hole on 
windows tomcat?

So this issue is confusing.  It seems that indeed there IS an issue,
though most cannot see a problem.
Talking to some people off-list, it seems that some think it is a


JK2
 

/
workers2.properties issue.  But I'm pretty sure that others have


seen
 

this going directly to port 8080.
We probably need to take a quick poll:
If you have seen this security problem of being able to view JSP
source, in what scenario(s)?
Tomcat version
OS version
Directly to Tomcat ("8080") or through Apache - JK or JK2?
(If you've seen the problem, please include your workers or
workers2.properties file, with a .txt extension)
Browser version(s)
url's where this was seen or not seen
If you have seen this in multiple scenarios, and not in others,


please
 

list each separately.

I have NOT seen it in the following scenarios:

Tomcat 4.1.18, 4.1.24, 4.1.26, 4.1.27
Windows 2000 5.00.2195 Service Pack 4
Directly to port 8080
Internet Explorer 6.0.2800.1106 with all security patches up to date
I tried  http://(url):8080/index.jsp%20
Tomcat 4.1.18, 4.1.24, 4.1.26, fairly standard distributions (only
adding one JNDIRealm beyond the default config)
Novell NetWare 6.5
Directly to port 8080, and through Apache - mod_jk.nlm
Internet Explorer 6.0.2800.1106 with all security patches up to date
I tried  http://(url):8080/index.jsp%20 and
https://(url)/tomcat/admin/index.jsp%20
Hopefully this mail gets through; I haven't been seeing my emails


show
 

up on tomcat-user for some reason (I un/resubscribed today...)

It would be really good to get to the bottom of this!

Jeff Tulley  ([EMAIL PROTECTED])
(801)861-5322
Novell, Inc., The Leading Provider of Net Business Solutions
http://www.novell.com
 


[EMAIL PROTECTED] 8/12/03 6:02:55 AM 

DO NOT REPLY [Bug 22266] - Keep template text together with mappedfile="true"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22266

Keep template text together with mappedfile="true"





--- Additional Comments From [EMAIL PROTECTED]  2003-08-13 02:09 ---
Unfortunately I've thrown out the actual numbers I got in the performance 
testing I did (all on a 1 GHz Windows XP laptop), but the salient results were 
as follows:
1) The patch made Tomcat faster at compiling and serving pages with a 
preponderance of HTML tags versus JSP tags (the lookahead does take some extra 
time, but is more than made up if the lookahead results in one less node to be 
traversed later).  With the patch in place, Tomcat compiled and served 
index.html from the jsp-examples webapp (renamed to index.jsp, obviously) 
about 9% faster than without the patch.
2) On balance, however, the patch made Tomcat slower at compiling and serving 
pages.  At least, when I tested against the jsp-examples webapp (with 
index.jsp renamed back to index.html so it wasn't part of the test), time to 
compile and serve was about 2% slower.
3) I couldn't find any difference in serving compiled pages with the patch in 
place (I thought there might be a small improvement because the patch shrinks 
the .class files).

Based on those numbers, I decided not to submit the patch as an option 
configurable separately from mappedfile, or as a non-configurable 
enhancement.  But since the mappedfile documentation said it was intended for 
debugging, I thought the performance hit was acceptable.

I didn't test your idea of a separate pass through the parsed nodes, but I did 
test code that, when about to create a new TemplateText node, checked to see 
if the previous node was also a TemplateText node, and if so, just appended 
its text to the previous node's (the ideas being that anything that conserved 
nodes might improve performance, and that I didn't like duplicating logic from 
another part of the Parser, either).  But that was noticeably slower (I've 
forgotten the numbers entirely) than the patch I submitted.

Anyway, I submitted the patch as an enhancement, so I can't complain if it 
gets implemented differently or not at all.  The above is just to help folks 
make an informed decision.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20098] - RequestDispatcher.include() in a jsp prints it's contents before any of the parents jsp's content is printed

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20098

RequestDispatcher.include() in a jsp prints it's contents before any of the parents 
jsp's content is printed





--- Additional Comments From [EMAIL PROTECTED]  2003-08-13 14:27 ---


I had a similar problem in the past. The behaviour your seing is (perhaps strangely) 
according to 
spec (the included buffer being flushed before the includers buffer).

If you want to make this work with request dispatchers, make sure you do a out.flush 
before 
including the second page (that is what the flush="true" means in the jsp:include tag).

Martin

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [Q] Different handling tagfiles and normal tags classes

[Jan Luehe]

Torsten,

see JSP.8.3 ("Semantics of Tag Files"), 3rd bullet:

  For each invocation to the tag, the JSP Context Wrapper must present a
  clean page scope containing no initial elements. All scopes other than
  the page scope must be identical to those in the Invoking JSP Context
  and must be modified accordingly when updates are made to those scopes
  in the JSP Context Wrapper. Any modifications to the page scope,
  however, must not affect the Invoking JSP Context.
Hope this helps.

Jan

Torsten Fohrer wrote:
Tagfiles and tags get a jspcontext from the container at runtime. 
Tags get directly a normal pagecontext reference from the current jsp page. 
TagFiles instead get a wrapper around the pagecontext that wraps all 
set/get/findAttribute for the page scope to a local set of stored
attributes. 
When i declare an attribute in jsp with page scope, i never see it in a tag
file, but i see it in a 'normal' tag.

Interesting files: 
  org.apache.jasper.runtime.JspContextWrapper -> see
getAttribute(String)/getAttribute(String/int)
  org.apache.jasper.compiler.Generator -> search for setJspContext

Is there a reason why, i don't know? 

Best greeting 
 Torsten Fohrer

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[5] Jasper currently requires a 1.4 JVM

[Bill Barker]

o.a.j.compiler.JspUtil.makeJavaPackage currently is calling String.split.
This means that you currently can't use Jasper (at least for compiling) with
a 1.3.x JVM.  Since Tomcat isn't a J2EE 1.4 container I can't see any
justification in the spec for not supporting 1.3.x JVMs.  However, since I
don't spend a lot of my time with Jasper, I'd thought that I should get the
opinions of people that do before hacking away ;-).  The two ways I can see
to go are:

1) Introduce a JdkCompat (similar to o.a.t.u.compat, but in Jasper since I
can't see making Jasper depend on j-t-c).  Pluses:  People using 1.4 JVMs
get all the benefits of String.split.  Minuses: Requires a new package with
two new classes.

2) Simply re-code makeJavaPackage to only use APIs from 1.3.x and higher.
Basically switch Pluses and Minuses above.

Of course, I'm willing to do the grunt-work to implement this.  My personal
preference is for 1), but if anyone has a better idea I'm open to that as
well.

Comments/Opinions/Flames?

This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication in 
error, please notify us immediately by e-mail and then delete all copies of this 
message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the 
Internet is not secure. Do not send confidential or sensitive information, such as 
social security numbers, account numbers, personal identification numbers and 
passwords, to us via ordinary (unencrypted) e-mail.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] New committer: Eric Carmichael

[Jan Luehe]

+1. I second what Kin-Man said. :)

Jan

Remy Maucherat wrote:
I'd like to nominate Eric Carmichael as a committer on the Tomcat 
project. Eric has been steadily supplying quality patches to the new 
Jasper which will implement the JSP 2.0 specification, and has helped 
fix outstanding bug reports. He plans to continue contributing in the 
future.

He has my +1.

Remy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Resend: Tomcat 4.1.24 & JVM 1.4.2 security hole?

[Laurent Blume]

Jeff Tulley wrote:

Verified on Win XP as well.  Using that flag fixes the problem.  Thanks
for making that connection!  
I've still got the problem when using the mod_jk2 connector.

I'm using Tomcat 4.1.27 w/ patch on Windows 2000 SP4, behind an Apache 
2.0.47 web server, with the J2SE 1.4.2.
The mod_jk2 binary I'm using comes from Tomcat 4.1.24 (I built it from 
source).

I added those keys in thr registry for the Tomcat service, and restarted it:
Windows Registry Editor Version 5.00
[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\Apache Tomcat 
4.1\Parameters]
"JVM Option Count"=dword:0005
"JVM Option Number 3"="-Dfile.encoding=ISO-8859-1"
"JVM Option Number 4"="-Dsun.io.useCanonCaches=false"

When I access Tomcat directly using port 8080, the option does work, and 
*.jsp%20 returns a 404.

However, when accessing the same through Apache, I still get the JSP code:
[13/Aug/2003:13:54:16 +0200] xx.xx.xx.xx TLSv1 DHE-RSA-AES256-SHA "GET 
/myApp/index.jsp%20 HTTP/1.1" 1534

Did I miss something?

TIA,

Laurent

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22277] - IllegalArgumentException in setOutputLineIncrement()

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22277

IllegalArgumentException in setOutputLineIncrement()





--- Additional Comments From [EMAIL PROTECTED]  2003-08-13 07:15 ---
I believe Remy's commit from earlier today ("Don't merge SMAP entries in the 
outptStartLines aren't consecutive") fixes the IllegalArgumentException 
problem (thanks, Remy!).  If that's right (I've tested it, but then I tested 
my original patch as well, so I'm not taking that as a guarantee), it means my 
workaround patch can be removed without IllegalArgumentException recurring.  
On the other hand the workaround patch also keeps the outputStartLine=0 
LineInfos out of the SMAP, so taking it out before we've fixed the root cause 
of outputStartLine=0 could be considered a regression, on the grounds that an 
incorrect SMAP is worse than an incomplete one.

Also, if Jasper were to start SMAPping page directives, then

TemplateText

would generate an IllegalArgumentException if it weren't for Remy's fix.  This 
means that IllegalArgumentException is a bug in its own right, and not just a 
side effect of the outputStartLine=0 problem.  So to keep things clear, I 
think we should use this ticket to track IllegalArgumentException only, and 
open new tickets as needed to track outputStartLine=0.

I'll close this ticket in a few days if there are no objections to this 
approach, and no reason to doubt Remy's commit.  If someone else wants to 
close it sooner, that's fine with me.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse JSSE13SocketFactory.java JSSE14SocketFactory.java JSSESocketFactory.java

[billbarker]

billbarker2003/08/12 22:29:08

  Modified:util/java/org/apache/tomcat/util/net/jsse
JSSE13SocketFactory.java JSSE14SocketFactory.java
JSSESocketFactory.java
  Log:
  Moving the new protocols logic to the 14 Factory.
  
  This feature isn't supported (at least in the public interface) in JSSE 1.0.x.  Now 
you can still use SSL with a 1.3.x JVM.  I didn't attempt to dig into the com.sun.** 
to see if there is a hidden implementation there.
  
  Revision  ChangesPath
  1.3   +8 -0  
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSE13SocketFactory.java
  
  Index: JSSE13SocketFactory.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSE13SocketFactory.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- JSSE13SocketFactory.java  12 Aug 2003 12:01:27 -  1.2
  +++ JSSE13SocketFactory.java  13 Aug 2003 05:29:08 -  1.3
  @@ -168,4 +168,12 @@
   throw new IOException(e.getMessage());
   }
   }
  +protected String[] getEnabledProtocols(SSLServerSocket socket,
  +String requestedProtocols){
  + return null;
  +}
  +protected void setEnabledProtocols(SSLServerSocket socket, 
  +  String [] protocols){
  +}
  +
   }
  
  
  
  1.10  +47 -0 
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSE14SocketFactory.java
  
  Index: JSSE14SocketFactory.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/jsse/JSSE14SocketFactory.java,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- JSSE14SocketFactory.java  11 Aug 2003 21:46:41 -  1.9
  +++ JSSE14SocketFactory.java  13 Aug 2003 05:29:08 -  1.10
  @@ -61,8 +61,10 @@
   
   import java.io.*;
   import java.net.*;
  +import java.util.Vector;
   import java.security.KeyStore;
   import java.security.SecureRandom;
  +import javax.net.ssl.SSLServerSocket;
   import javax.net.ssl.SSLContext;
   import javax.net.ssl.KeyManager;
   import javax.net.ssl.X509KeyManager;
  @@ -188,5 +190,50 @@
   }
   
   return tms;
  +}
  +protected void setEnabledProtocols(SSLServerSocket socket, String []protocols){
  + if (protocols != null) {
  +socket.setEnabledProtocols(protocols);
  +}
  +}
  +
  +protected String[] getEnabledProtocols(SSLServerSocket socket,
  +String requestedProtocols){
  + String[] supportedProtocols = socket.getSupportedProtocols();
  +
  +String[] enabledProtocols = null;
  +
  +if (requestedProtocols != null) {
  +Vector vec = null;
  +int fromIndex = 0;
  +int index = requestedProtocols.indexOf(',', fromIndex);
  +while (index != -1) {
  +String protocol
  += requestedProtocols.substring(fromIndex, index).trim();
  +/*
  + * Check to see if the requested protocol is among the
  + * supported protocols, i.e., may be enabled
  + */
  +for (int i=0; supportedProtocols != null
  + && i

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler JspUtil.java

[billbarker]

billbarker2003/08/13 22:02:53

  Modified:jasper2/src/share/org/apache/jasper/compiler JspUtil.java
  Log:
  Fixing my own bugs ;-)
  
  The previous commit worked for the one place that split is currently used, but 
breaks if when you attempt a more general case.
  
  Revision  ChangesPath
  1.44  +4 -4  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspUtil.java
  
  Index: JspUtil.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspUtil.java,v
  retrieving revision 1.43
  retrieving revision 1.44
  diff -u -r1.43 -r1.44
  --- JspUtil.java  14 Aug 2003 04:36:25 -  1.43
  +++ JspUtil.java  14 Aug 2003 05:02:53 -  1.44
  @@ -971,7 +971,7 @@
   String comp = path.substring(start,pos);
   comps.add(comp);
   }
  -start = pos +1;
  +start = pos + pat.length();
   pos = path.indexOf(pat,start);
   }
   if( start < path.length()) {
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 19965] - mod_jk2 connection fails, "workerEnv.init() create slot epStat.0 failed"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19965

mod_jk2 connection fails, "workerEnv.init() create slot epStat.0 failed"





--- Additional Comments From [EMAIL PROTECTED]  2003-08-14 22:45 ---
Maybe it helps to add the following to the workers2.properties file:

[shm]
file=/programme/net/apache/logs/shm.file
size=1048576

Daniel Frey

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

something wrong in apache tomcat load balancing configuration

[Thutkawkorapin, Jessada]

Hi

   I'm currently testing the Load-Balancing & Failover possibilities of Tomcat and i came to the conclusion that something goes wrong with the Failback...  I've installed tomcat#1, tomcat#2 and apache in the same server with this environment-  Win 2000 Pro OS-  tomcat 4.1.27-  Apache 1.3.26-  mod_jk-1.3.26.dll Talking about load-balancing, everthing is Ok. Requests to dynamic pages are processed by both Tomcat servers according to the lbFactor (50/50)

 

Then I stop server #2.The next HTTP request takes a few seconds to be proceed. I guess this is normal, since the load-balancer has to analyse the situation and determine that server #2 is no more available. The problem is that when I re-start the 2nd server, load-balancer ignore it and requests are still proceed 100% by server #1. I have to re-start the Apache/HTTP server to make the load-balancing working again...

 

Do you think there is something else to configure to be sure that the load-balancer determine servers availability on the fly ?

 

ps. I also attach the necessary
configuration file with this email

 

thanx

 

Jessada

 






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22439] - NPE compiling JSP Document

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22439

NPE compiling JSP Document

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-08-14 22:16 ---
This is a regression from 5.0.6, and has been fixed in the head branch.  To
getaround it, either use 5.0.6 or the nightly build.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: something wrong in apache tomcat load balancing configuration

[Mladen Turk]

From: Thutkawkorapin, Jessada
Sent: Thursday, August 14, 2003 1:13 PM
To: [EMAIL PROTECTED]
Subject: something wrong in apache tomcat load balancing configuration


The problem is that when I re-start the 2nd server, load-balancer ignore

it and requests are still proceed 100% by server #1.


Be patient!
After a few minutes you'll see the second instance operational too.

MT.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime BodyContentImpl.java

[luehe]

luehe   2003/08/14 15:11:12

  Modified:jasper2/src/share/org/apache/jasper/runtime
BodyContentImpl.java
  Log:
  Fixed buffer realloc when writing single char
  
  Revision  ChangesPath
  1.9   +1 -1  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime/BodyContentImpl.java
  
  Index: BodyContentImpl.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime/BodyContentImpl.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- BodyContentImpl.java  14 Jan 2003 01:56:05 -  1.8
  +++ BodyContentImpl.java  14 Aug 2003 22:11:12 -  1.9
  @@ -106,7 +106,7 @@
} else {
ensureOpen();
if (nextChar >= bufferSize) {
  - reAllocBuff (0);
  + reAllocBuff (1);
}
cb[nextChar++] = (char) c;
}
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22397] New: - Compiler warnings

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22397

Compiler warnings

   Summary: Compiler warnings
   Product: Tomcat 4
   Version: 4.1.27
  Platform: Sun
OS/Version: Solaris
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Connector:Coyote JK 2
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


gcc 3.2.2 (64 bit mode) gives these warnings:

   [so]
/local/src/jakarta-tomcat-connectors-4.1.27-src/jk/native2/server/apache2/mod_jk2.c:197:
warning: missing initializer
   [so]
/local/src/jakarta-tomcat-connectors-4.1.27-src/jk/native2/server/apache2/mod_jk2.c:197:
warning: (near initialization for `jk2_cmds[

   [so]
/local/src/jakarta-tomcat-connectors-4.1.27-src/jk/native2/common/jk_vm_default.c:449:77:
warning: backslash and newline separated by space

   [so]
/local/src/jakarta-tomcat-connectors-4.1.27-src/jk/native2/common/jk_channel_apr_socket.c:
In function `jk2_channel_apr_open':
   [so]
/local/src/jakarta-tomcat-connectors-4.1.27-src/jk/native2/common/jk_channel_apr_socket.c:229:
warning: left-hand operand of comma expression has no effect
   [so]
/local/src/jakarta-tomcat-connectors-4.1.27-src/jk/native2/common/jk_channel_apr_socket.c:229:
warning: left-hand operand of comma expression has no effect
   [so]
/local/src/jakarta-tomcat-connectors-4.1.27-src/jk/native2/common/jk_channel_apr_socket.c:258:
warning: left-hand operand of comma expression has no effect
   [so]
/local/src/jakarta-tomcat-connectors-4.1.27-src/jk/native2/common/jk_channel_apr_socket.c:258:
warning: left-hand operand of comma expression has no effect

   [so]
/local/src/jakarta-tomcat-connectors-4.1.27-src/jk/native2/common/jk_worker_status.c:
In function `jk2_worker_status_displayStat':
   [so]
/local/src/jakarta-tomcat-connectors-4.1.27-src/jk/native2/common/jk_worker_status.c:118:
warning: comparison between signed and unsigned


   [so]
/local/src/jakarta-tomcat-connectors-4.1.27-src/jk/native2/common/jk_vm_default.c:449:77:
warning: backslash and newline separated by space

   [so]
/local/src/jakarta-tomcat-connectors-4.1.27-src/jk/native2/common/jk_channel_apr_socket.c:
In function `jk2_channel_apr_open':
   [so]
/local/src/jakarta-tomcat-connectors-4.1.27-src/jk/native2/common/jk_channel_apr_socket.c:229:
warning: left-hand operand of comma expression has no effect
   [so]
/local/src/jakarta-tomcat-connectors-4.1.27-src/jk/native2/common/jk_channel_apr_socket.c:229:
warning: left-hand operand of comma expression has no effect
   [so]
/local/src/jakarta-tomcat-connectors-4.1.27-src/jk/native2/common/jk_channel_apr_socket.c:258:
warning: left-hand operand of comma expression has no effect
   [so]
/local/src/jakarta-tomcat-connectors-4.1.27-src/jk/native2/common/jk_channel_apr_socket.c:258:
warning: left-hand operand of comma expression has no effect

   [so]
/local/src/jakarta-tomcat-connectors-4.1.27-src/jk/native2/common/jk_worker_status.c:118:
warning: comparison between signed and unsigned

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]