Re: [PATCH] Re: SSI Servlet has big problems

2002-07-02 Thread Bill Barker
You're right. It should have been -r TOMCAT_4_1_2 (which checks out fine for me). - Original Message - From: Dan Sandberg [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Monday, July 01, 2002 6:06 PM Subject: Re: [PATCH] Re: SSI Servlet has big problems Hi Bill

Re: [PATCH] Re: SSI Servlet has big problems

2002-07-01 Thread Paul Speed
(Resending from my older address in hopes that it will help avoid some confusion.) Hmmm... This is what I get for ignoring the list for a while. ;) Note: I completely rewrote the SSI support in 4.x HEAD and had Bip apply the patches (Amy also did some patching) for exactly the same reasons

Re: [PATCH] Re: SSI Servlet has big problems

2002-07-01 Thread Dan Sandberg
Yes, let's merge them together. How do I get to the code that you fixed? Were the test cases in CVS? I'd say lets get all the test cases setup, and see where my code fails your tests. Then we can use your code wherever functionality is missing. I thought I had checked out the head

Re: [PATCH] Re: SSI Servlet has big problems

2002-07-01 Thread Paul Speed
Dan Sandberg wrote: Yes, let's merge them together. How do I get to the code that you fixed? Were the test cases in CVS? It's all in CVS. If you checkout the source code from some time in December you should get it all back in util and util/ssi. It looks like my last check-in was on

Re: [PATCH] Re: SSI Servlet has big problems

2002-07-01 Thread Dan Sandberg
Ugh this is painful. I'll checkout your stuff within the next few days. If the architecture looks good and does have significantly greater functionality I will merge my changes into your code. I also fixed the included variable problem and the nested include problems. The conditional stuff

Re: [PATCH] Re: SSI Servlet has big problems

2002-07-01 Thread Dan Sandberg
I'm trying to checkout an old version of tomcat with the following command: [dan@oogie tmp]$ cvs co -D 4 months ago jakarta-tomcat-4.0 And I'm getting the following error: Core dumped; preserving /tmp/cvs-serv41751 on server. CVS locks may need cleaning up. My version is (on Linux):

Re: [PATCH] Re: SSI Servlet has big problems

2002-07-01 Thread Paul Speed
(resending from my progeeks.com address to avoid being filtered/delayed by moderation.) Don't know... have you tried an absolute date or is 4 months ago just an example for the list's benefit. Any date in feb/april should be sufficiently late enough. Hope it works, -Paul Dan Sandberg wrote:

Re: [PATCH] Re: SSI Servlet has big problems

2002-07-01 Thread Paul Speed
(resending from my progeeks.com address to avoid being filtered/delayed by moderation.) Dan Sandberg wrote: Ugh this is painful. I'll checkout your stuff within the next few days. If the architecture looks good and does have significantly greater functionality I will merge my changes

Re: [PATCH] Re: SSI Servlet has big problems

2002-07-01 Thread Dan Sandberg
I tried an absolute date first. April didn't work. Does this work on your end? have even had CVS directories in it with sticky tags already set... ie: keeping me from easily getting the latest without checking out the whole source tree from scratch. Hmm. That is a possibility. Definitely

Re: [PATCH] Re: SSI Servlet has big problems

2002-07-01 Thread Bill Barker
: SSI Servlet has big problems I'm trying to checkout an old version of tomcat with the following command: [dan@oogie tmp]$ cvs co -D 4 months ago jakarta-tomcat-4.0 And I'm getting the following error: Core dumped; preserving /tmp/cvs-serv41751 on server. CVS locks may need cleaning up

Re: [PATCH] Re: SSI Servlet has big problems

2002-07-01 Thread Dan Sandberg
work. You could also add the files back from the Attic, since it's a completely different directory. - Original Message - From: Dan Sandberg [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Monday, July 01, 2002 4:25 PM Subject: Re: [PATCH] Re: SSI Servlet has big

[PATCH] Re: SSI Servlet has big problems

2002-05-17 Thread Dan Sandberg
Hi everyone. Here are more changes to the SSI code. I have a test case ( comparing SSI behavior to Apache by using .shtml files in different tomcat webapps / apache directories ) which I have not included because I'm not sure where to put manual test cases like this. If there is an