Re: [Toybox] strlower() bug

2024-05-22 Thread enh via Toybox
On Tue, May 14, 2024 at 2:58 PM Rob Landley wrote: > > > > On 5/14/24 12:12, enh wrote: > > On Tue, May 14, 2024 at 1:04 PM Rob Landley wrote: > >> > >> On 5/14/24 07:10, enh wrote: > >> > macOS tests seem to be broken since this commit? > &g

Re: [Toybox] awk (was: strlower() bug)

2024-05-22 Thread enh via Toybox
interesting docs, thanks! i see you're already running the one-true-awk test suite, which was the only suggestion i would have had, and you're running it against "all the awks", which is even better than what i had in mind :-) On Tue, May 14, 2024 at 10:37 PM Ray Gardner wrote: > > On Fri, May

Re: [Toybox] [PATCH] netcat: clarify documentation.

2024-05-22 Thread enh via Toybox
On Wed, May 22, 2024 at 2:30 AM Rob Landley wrote: > > On 5/20/24 07:06, enh via Toybox wrote: > > "Collate" means "sort", but -O is like -o other than buffering. > > It means "group". (The dictionary says "gather or arrange in the proper &

Re: [Toybox] microcom.c discarding data due to TCSAFLUSH

2024-05-20 Thread enh via Toybox
On Mon, May 20, 2024 at 10:43 AM Yi-Yo Chiang wrote: > > Found this out today when comparing captured logs. Every time I connect to a > pty the first few hundreds of bytes seem to always be missing. > I then traced to this line >

Re: [Toybox] [PATCH] xputs: Do flush

2024-05-20 Thread enh via Toybox
On Sun, May 19, 2024 at 10:56 PM Rob Landley wrote: > > On 5/18/24 21:53, Yi-Yo Chiang wrote: > > What I wanted to address with this patch are: > > > > 1. Fix this line of > > xputs() > > https://github.com/landley/toybox/blob/master/toys/net/microcom.c#L113 > > The prompt text is not flushed

[Toybox] [PATCH] netcat: clarify documentation.

2024-05-20 Thread enh via Toybox
"Collate" means "sort", but -O is like -o other than buffering. --- toys/net/netcat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) 0001-netcat-clarify-documentation.patch Description: Binary data ___ Toybox mailing list

Re: [Toybox] netcat -f bug

2024-05-15 Thread enh via Toybox
On Sat, May 11, 2024 at 3:12 AM Yi-Yo Chiang via Toybox wrote: > > > > On Sat, May 11, 2024 at 1:30 AM Rob Landley wrote: >> >> What's your use case triggering this patch? Because without that, I go off on >> various design tangents, as seen below: > > > I just wanted some tool to communicate

Re: [Toybox] strlower() bug

2024-05-14 Thread enh via Toybox
On Tue, May 14, 2024 at 1:04 PM Rob Landley wrote: > > On 5/14/24 07:10, enh wrote: > > macOS tests seem to be broken since this commit? > > > > FAIL: find strlower edge case > > echo -ne '' | touch aⱥ; find . -iname aȺ > > --- expected

Re: [Toybox] I'm aware landley.net is saying "site.not found".

2024-05-14 Thread enh via Toybox
seems to be working again now... On Mon, May 13, 2024 at 11:55 PM Rob Landley wrote: > > That dreamhost server migration they did? (The recent "only 2 years old" > version > thread?) Does not seem to have correctly updated the DNS record. Of the domain > they manage for me. > > Dreamhost

Re: [Toybox] strlower() bug

2024-05-14 Thread enh via Toybox
macOS tests seem to be broken since this commit? FAIL: find strlower edge case echo -ne '' | touch aⱥ; find . -iname aȺ --- expected 2024-05-10 17:32:56.0 + +++ actual 2024-05-10 17:32:56.0 + @@ -1 +0,0 @@ -./aⱥ On Wed, May 8, 2024 at

[Toybox] [PATCH] find: use S_ISREG() rather than inlining it.

2024-05-10 Thread enh via Toybox
--- toys/posix/find.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) 0001-find-use-S_ISREG-rather-than-inlining-it.patch Description: Binary data ___ Toybox mailing list Toybox@lists.landley.net

Re: [Toybox] unshare/nsenter and flags

2024-05-02 Thread enh via Toybox
On Thu, May 2, 2024 at 6:17 PM Rob Landley wrote: > > On 5/2/24 13:14, enh via Toybox wrote: > > another googler wanted a host unshare(1) for some testing... i added > > that, and they complained that although the docs say > > > > -r Become root (map curren

[Toybox] unshare/nsenter and flags

2024-05-02 Thread enh via Toybox
another googler wanted a host unshare(1) for some testing... i added that, and they complained that although the docs say -r Become root (map current euid/egid to 0/0, implies -U) (--map-root-user) it seems like -r _doesn't_ actually imply -U in practice (and they seemed to have strace

Re: [Toybox] nproc(1)

2024-05-02 Thread enh via Toybox
(to be fair, i was shocked the first time i had to deal with an Android device where these weren't both the same...) On Thu, May 2, 2024 at 9:18 AM enh wrote: > > /facepalm > > maybe move your hand-written version into portability just for musl, > and everyone with a working

Re: [Toybox] nproc(1)

2024-05-02 Thread enh via Toybox
/facepalm maybe move your hand-written version into portability just for musl, and everyone with a working libc just uses sysconf()? On Tue, Apr 30, 2024 at 8:26 PM Rob Landley wrote: > > On 4/29/24 16:56, enh via Toybox wrote: > > isn't nproc(1) just a call to sysconf(3)

[Toybox] nproc(1)

2024-04-29 Thread enh via Toybox
isn't nproc(1) just a call to sysconf(3) with either _SC_NPROCESSORS_ONLN for regular behavior, or _SC_NPROCESSORS_CONF for --all? that works fine for macOS too... ___ Toybox mailing list Toybox@lists.landley.net

Re: [Toybox] [PATCH] readelf: Zero Pad -S section numbers (More scriptable through cut/awk)

2024-04-26 Thread enh via Toybox
but this isn't what anyone else's readelf does... so now anyone scripting has _two_ problems. (or a bug, if they've only tested against toybox.) honestly, if you're scripting, you should switch to llvm-readelf and its less-machine-unreadable alternative output format instead. On Thu, Apr 25,

Re: [Toybox] [PATCH] xxd: -d Decimal Lables flag, Don't cap at one file

2024-04-22 Thread enh via Toybox
On Mon, Apr 22, 2024 at 2:23 PM Oliver Webb wrote: > > > On Sat, Apr 20, 2024 at 7:38 PM Oliver Webb via Toybox > > toybox@lists.landley.net wrote: > > > > xxd also runs on average about 5 times slower than vim xxd, this is > > > because of read reading 16 bytes at a time, also not hard to fix,

[Toybox] [PATCH] xxd: buffer input via stdio.

2024-04-22 Thread enh via Toybox
--- toys/other/xxd.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) 0001-xxd-buffer-input-via-stdio.patch Description: Binary data ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net

Re: [Toybox] [PATCH] xxd: -d Decimal Lables flag, Don't cap at one file

2024-04-22 Thread enh via Toybox
On Sat, Apr 20, 2024 at 7:38 PM Oliver Webb via Toybox wrote: > > Looking at xxd, I noticed that the -b[inary] flag wasn't there, > Having some facility to print binary is nice, but since printf > doesn't have anything in built for it implementing it isn't hard, > but it looks _ugly_. Which is

Re: [Toybox] today in "shut up, gnu!"

2024-04-15 Thread enh via Toybox
i'd been deliberately _not_ sending you https://www.phoronix.com/news/GNU-Coreutils-9.5-Released for fear of winding you up :-) On Sat, Apr 13, 2024 at 7:34 AM Rob Landley wrote: > > On 4/12/24 13:24, enh via Toybox wrote: > > ~/aosp-main-with-phones$ find external/ -name NO

[Toybox] today in "shut up, gnu!"

2024-04-12 Thread enh via Toybox
~/aosp-main-with-phones$ find external/ -name NOTICE -type l -maxdepth 2 find: warning: you have specified the global option -maxdepth after the argument -name, but global options are not positional, i.e., -maxdepth affects tests specified before it as well as those specified after it. Please

Re: [Toybox] [PATCH] timeout.test: reduce flake.

2024-04-12 Thread enh via Toybox
ow I'm at texas linuxfest doing sleep deprived talk > prep > for tomorrow...) > > On 4/8/24 15:28, enh via Toybox wrote: > > A (presumably overloaded) CI server saw the `exit 0` test time out. > > Given that several of these tests should just fail immediately, > > having a

[Toybox] [PATCH] timeout.test: reduce flake.

2024-04-08 Thread enh via Toybox
A (presumably overloaded) CI server saw the `exit 0` test time out. Given that several of these tests should just fail immediately, having a huge timeout isn't even a bad thing --- if we had a bug that caused us to report the correct status, but not until the timeout had _also_ expired, this would

[Toybox] tail test failures?

2024-04-08 Thread enh via Toybox
looks like the github CI has been red for ubuntu and macOS since april 5th? this revert fixes the current failing test: [master 8368f8f9] Revert "Enforce min/max for % input type (time in seconds w/millisecond granularity)." but that just gets me a different failing test, so it's obviously a

Re: [Toybox] utf8towc(), stop being defective on null bytes

2024-04-08 Thread enh via Toybox
On Sun, Apr 7, 2024 at 7:43 AM Oliver Webb via Toybox wrote: > > On Sunday, April 7th, 2024 at 03:54, Rob Landley wrote: > > > As for moving it again someday, unnecessarily moving files is churn that > > makes > > the history harder to see, and lib/*.c has never been a strict division > >

[Toybox] more gnu nonsense: cp -n

2024-04-01 Thread enh via Toybox
hadn't seen this one before... cp: warning: behavior of -n is non-portable and may change in future; use --update=none instead (consider me skeptical that a system without -n is going to have --update=none...) ___ Toybox mailing list

Re: [Toybox] [PATCH] Clean up xz a good amount

2024-03-29 Thread enh via Toybox
On Fri, Mar 29, 2024 at 3:50 PM Oliver Webb wrote: > > > > ah, crap, that's another thing to put on the riscv64 to-do list... > > > (thanks for bringing that to light!) > > > > so, TIL that upstream already added a risc-v bcj implementation... > > I always thought that the xz decompresser we use

Re: [Toybox] [PATCH] Clean up xz a good amount

2024-03-29 Thread enh via Toybox
On Wed, Feb 28, 2024 at 9:13 AM enh wrote: > > On Tue, Feb 27, 2024 at 8:34 PM Rob Landley wrote: > > > > On 2/27/24 21:27, Oliver Webb wrote: > > > 2 are help text, do_xzcat was due to replacing the case statement for > > > error handling with a array

[Toybox] [PATCH] inotifyd: enable line buffering.

2024-03-27 Thread enh via Toybox
Since the point here is to get a notification for every event, and there's one line per event, line buffering is the right choice. --- toys/other/inotifyd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) 0001-inotifyd-enable-line-buffering.patch Description: Binary data

Re: [Toybox] hexdump tests.

2024-03-27 Thread enh via Toybox
On Wed, Mar 27, 2024 at 6:22 AM Rob Landley wrote: > > On 3/25/24 10:42, enh wrote: > > On Sun, Mar 24, 2024 at 1:40 AM Rob Landley wrote: > >> > >> On 3/22/24 15:02, enh wrote: > >> >> > CANONICALIZE_SPACE_IF_RUNNING_HOST_VERSION=1? so we trus

Re: [Toybox] Poke about the bc.c cleanup patches I submitted a while ago

2024-03-27 Thread enh via Toybox
On Wed, Mar 27, 2024 at 6:22 AM Rob Landley wrote: > > Yesterday I did NOT spend all my energy reading email, and instead got > https://landley.net/bin/toolchains updated with a musl 1.2.5 and or1k and > riscv > in the list, and that seems to have fixed the sh2eb build break as well > (although

Re: [Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-27 Thread enh via Toybox
On Wed, Mar 27, 2024 at 6:47 AM Rob Landley wrote: > > On 3/25/24 20:24, enh wrote: > > But "dpkg-query -S $(which $NAME)" is pretty easy to do the mapping > > yourself on > > debian... > > > > > > (yeah, though i suspect anyone

Re: [Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-25 Thread enh via Toybox
On Sun, Mar 24, 2024 at 1:12 AM Rob Landley wrote: > On 3/22/24 10:26, enh wrote: > > On Fri, Mar 22, 2024 at 8:24 AM enh wrote: > >> (tbh, just merging "lsb" into "other" would be a step forwards. wtf > >> is/was "lsb" anyway? and w

Re: [Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-25 Thread enh via Toybox
On Sun, Mar 24, 2024 at 12:45 AM Rob Landley wrote: > On 3/22/24 10:24, enh wrote: > > On Thu, Mar 21, 2024 at 8:45 PM Rob Landley wrote: > >> Anyway, toys/android basically meant (to me), "commands that come from > and are > >> maintained by Elliott which I

Re: [Toybox] hexdump tests.

2024-03-25 Thread enh via Toybox
On Sun, Mar 24, 2024 at 1:40 AM Rob Landley wrote: > > On 3/22/24 15:02, enh wrote: > >> > CANONICALIZE_SPACE_IF_RUNNING_HOST_VERSION=1? so we trust ourselves but > >> > no-one > >> > else? :-) > >> > >> I _don't_ trust myself, and I'm

Re: [Toybox] hexdump tests.

2024-03-22 Thread enh via Toybox
On Mon, Mar 18, 2024 at 6:04 AM Rob Landley wrote: > > On 3/15/24 16:24, enh wrote: > > Sure, but that said some tests _DO_ care about the exact amount of > > whitespace > > (are columns aligned), or tabs vs spaces. > > > > i know what you mean,

[Toybox] [PATCH] restorecon: use FLAG() macro for readability.

2024-03-22 Thread enh via Toybox
--- toys/android/restorecon.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) 0001-restorecon-use-FLAG-macro-for-readability.patch Description: Binary data ___ Toybox mailing list Toybox@lists.landley.net

Re: [Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-22 Thread enh via Toybox
On Fri, Mar 22, 2024 at 8:24 AM enh wrote: > > On Thu, Mar 21, 2024 at 8:45 PM Rob Landley wrote: > > > > On 3/17/24 14:52, Oliver Webb wrote: > > > On Thursday, March 14th, 2024 at 12:04, enh wrote: > > >> at a high level, it does seem l

Re: [Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-22 Thread enh via Toybox
On Thu, Mar 21, 2024 at 8:45 PM Rob Landley wrote: > > On 3/17/24 14:52, Oliver Webb wrote: > > On Thursday, March 14th, 2024 at 12:04, enh wrote: > >> at a high level, it does seem like many/most people interpret "pending" as > >> "almost done

Re: [Toybox] [PATCH] mount: avoid deferencing NULL.

2024-03-21 Thread enh via Toybox
yeah, that looks neater anyway, and seems to work. thanks! On Wed, Mar 20, 2024 at 5:56 PM Rob Landley wrote: > > On 3/20/24 16:07, enh via Toybox wrote: > > I don't know why I wasn't seeing this yesterday > > Because /sys was mounted, so readfile() returned a string

[Toybox] [PATCH] Reduce ifconfig test flake.

2024-03-21 Thread enh via Toybox
I have no excuse for deflaking _one_ of the MTU tests but not the other. I have no one to blame but myself that I'm back here today... --- tests/ifconfig.test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) 0001-Reduce-ifconfig-test-flake.patch Description: Binary data

Re: [Toybox] [PATCH] more.c: More stuff, down cursor key scrolls down. Also stuff about less

2024-03-20 Thread enh via Toybox
On Wed, Mar 20, 2024 at 4:08 PM Rob Landley wrote: > On 3/20/24 11:56, Oliver Webb wrote: > > On Wednesday, March 20th, 2024 at 11:39, Rob Landley > wrote: > >> More never had the ability to go backwards, less did. Different command. > > > >>From the more help text you get when you press "h": >

[Toybox] [PATCH] mount: avoid deferencing NULL.

2024-03-20 Thread enh via Toybox
I don't know why I wasn't seeing this yesterday, but I can't _not_ see it today: newfstatat(AT_FDCWD, "/dev/block/loop6", {st_mode=S_IFBLK|0600, st_rdev=makedev(7, 48), ...}, 0) = 0 openat(AT_FDCWD, "/sys/block/loop48/loop/backing_file", O_RDONLY) = -1 ENOENT (No such file or directory) ---

Re: [Toybox] [PATCH] more.c: More stuff, down cursor key scrolls down. Also stuff about less

2024-03-20 Thread enh via Toybox
On Wed, Mar 20, 2024 at 9:38 AM Rob Landley wrote: > On 3/20/24 00:02, Oliver Webb via Toybox wrote: > > I spotted the more implementation in pending. Looking at it, it's > missing quite a lot of stuff, > > Such as the ability to go back in a file. > > More never had the ability to go backwards,

Re: [Toybox] mount option to show what a loopback mount is backed by?

2024-03-19 Thread enh via Toybox
On Tue, Mar 19, 2024 at 9:13 AM Rob Landley wrote: > On 3/18/24 20:16, enh via Toybox wrote: > > mount currently shows something like: > > > > /dev/block/loop86 on /apex/com.android.hardware.tetheroffload@1 type > ext4 > > (ro,dirsync,seclabel,nodev,noatime) &g

[Toybox] mount option to show what a loopback mount is backed by?

2024-03-18 Thread enh via Toybox
mount currently shows something like: /dev/block/loop86 on /apex/com.android.hardware.tetheroffload@1 type ext4 (ro,dirsync,seclabel,nodev,noatime) but often the user wants to know what "loop86" refers to. and it's unlikely they know to look in /sys/block/loop*/loop/backing_file. afaik, though,

Re: [Toybox] interesting new (?) env(1) options

2024-03-18 Thread enh via Toybox
to be clear, i actually just meant a quick way to search the toybox help --- a way to ask toybox "which of your commands have something to do with $x". not an actual "grep the man pages". (which i don't think *needs* a precomputed database in 2024, even if it did in 1994. tbh, i'm pretty sure aix

Re: [Toybox] [PATCH] readelf: fix -n for x86-64 ibt/shstk notes.

2024-03-15 Thread enh via Toybox
n't decoding, but _not_ with a note that contains two things (which was the "real" bug that made things go off the rails). i'll keep prodding the toolchain folks for ideas, and i'll let you know if i actually manage. > On 3/14/24 19:08, enh via Toybox wrote: > > I couldn't work out how

Re: [Toybox] interesting new (?) env(1) options

2024-03-15 Thread enh via Toybox
On Fri, Mar 15, 2024 at 3:43 PM Rob Landley wrote: > On 3/15/24 16:27, enh wrote: > > That said, I'm not implementing --longopts without a short opt until > somebody > > comes to me with a use case. And then I would come up with short > options. Also, > >

Re: [Toybox] interesting new (?) env(1) options

2024-03-15 Thread enh via Toybox
On Fri, Mar 15, 2024 at 2:22 PM Rob Landley wrote: > On 3/15/24 13:40, enh via Toybox wrote: > > i've never noticed these before: > > > >--block-signal[=SIG] > > block delivery of SIG signal(s) to COMMAND > > > >--defau

Re: [Toybox] hexdump tests.

2024-03-15 Thread enh via Toybox
On Fri, Mar 15, 2024 at 2:06 PM Rob Landley wrote: > On 3/15/24 09:58, enh wrote: > > On Thu, Mar 14, 2024 at 9:25 PM Rob Landley wrote: > > > I could make ours do that, or I could export NOSPACE=1 at the start o > the test > > > (since each one runs as a child p

[Toybox] interesting new (?) env(1) options

2024-03-15 Thread enh via Toybox
i've never noticed these before: --block-signal[=SIG] block delivery of SIG signal(s) to COMMAND --default-signal[=SIG] reset handling of SIG signal(s) to the default --ignore-signal[=SIG] set handling of SIG signal(s) to do nothing

Re: [Toybox] hexdump tests.

2024-03-15 Thread enh via Toybox
On Thu, Mar 14, 2024 at 9:25 PM Rob Landley wrote: > Following up on commit cab0b6653827, the hexdump test suite is weird. For > example, the first test has "simple\\n" when it means "simple\n" (which > nevertheless somehow works for reasons I am loathe to examine at the > moment, and > I have a

[Toybox] [PATCH] readelf: fix -n for x86-64 ibt/shstk notes.

2024-03-14 Thread enh via Toybox
I couldn't work out how to get gcc to actually produce such a thing, but /bin/dbxtool on my debian box right now has them. The big mistake here is that GNU property notes' data is always 8-byte aligned, so we needed to skip that. That lets us get rid of the existing loop termination hack to skip

Re: [Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-14 Thread enh via Toybox
at a high level, it does seem like many/most people interpret "pending" as "almost done" (he says, being part of the problem himself, having several pending things building and shipping on all Android devices) whereas in actual fact it can mean anything from "yeah, actually pretty much done" to

Re: [Toybox] [PATCH] watch: flush the buffer each round.

2024-03-12 Thread enh via Toybox
On Tue, Mar 12, 2024 at 8:45 AM Rob Landley wrote: > > Hello from Minneapolis: https://mstdn.jp/@landley/112078501045637288 > > Still _really_ fried from my move, but at least chipping away at the email > backlog... at least it's the same timezone :-) > On 3/11/24 12:27, enh

[Toybox] [PATCH] watch: fix initial output.

2024-03-11 Thread enh via Toybox
The first character of the first line of child output, the first time the child is run, was being shown as the last character of the header because of the use of a not-yet-set variable. --- toys/other/watch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Toybox] [PATCH] watch: flush the buffer each round.

2024-03-11 Thread enh via Toybox
On Fri, Mar 8, 2024 at 5:43 PM Rob Landley wrote: > > I remember when the xprintf() family would do a flush and check for errors > each > write. That's why code like: > > dprintf(1, "%c", pad if (width) xputs(ss+(width>ctimelen ? 0 : width-1)); > if (yy>=3) dprintf(1,

[Toybox] [PATCH] ping: opt in to line buffering.

2024-03-08 Thread enh via Toybox
--- toys/net/ping.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) 0001-ping-opt-in-to-line-buffering.patch Description: Binary data ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net

[Toybox] [PATCH] watch: flush the buffer each round.

2024-03-08 Thread enh via Toybox
--- toys/other/watch.c | 1 + 1 file changed, 1 insertion(+) 0001-watch-flush-the-buffer-each-round.patch Description: Binary data ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net

Re: [Toybox] [PATCH] vi.c: Backspace to merge lines when at beginning, get_endline is no more, cleanup

2024-03-07 Thread enh via Toybox
(fwiw, i've had lots of "why isn't this more like vim?" complaints, and this specific backspace behavior was one of them. i didn't know about this myself either. like MS Word i suspect vim is one of those products where everyone only uses 5%, but we all use a different 5%...) On Thu, Mar 7, 2024,

Re: [Toybox] [PATCH] clear.c: Clear scrollback buffer on non-vte (gnome based) terminals

2024-03-06 Thread enh via Toybox
On Tue, Mar 5, 2024 at 11:49 PM Rob Landley wrote: > > On 3/5/24 18:31, enh via Toybox wrote: > >> We have a 7-10 year support horizon, How many terminal escape protocols > >> have been relevant > >> in the last 10 years: One. The story is the same for UTF8 and

Re: [Toybox] [PATCH] clear.c: Clear scrollback buffer on non-vte (gnome based) terminals

2024-03-05 Thread enh via Toybox
On Tue, Mar 5, 2024 at 4:01 PM Oliver Webb via Toybox wrote: > > (Yes, I did read "I believe there is no point in continuing this > conversation.", > but there are still some questions and statements I feel the need to respond > to) > > On Tuesday, March 5th, 2024 at 16:32, Mouse > wrote: > >

Re: [Toybox] find(1) -name vs -wholename

2024-03-05 Thread enh via Toybox
On Mon, Mar 4, 2024 at 6:09 PM Rob Landley wrote: > > On 3/4/24 18:03, enh wrote: > > On Mon, Mar 4, 2024 at 3:31 PM Rob Landley wrote: > >> > >> On 3/4/24 12:19, enh via Toybox wrote: > >> > obviously the patch is trivial, but i can't think of a

Re: [Toybox] find(1) -name vs -wholename

2024-03-04 Thread enh via Toybox
On Mon, Mar 4, 2024 at 3:31 PM Rob Landley wrote: > > On 3/4/24 12:19, enh via Toybox wrote: > > obviously the patch is trivial, but i can't think of an existing > > toybox tool that has one of these "you're holding it wrong" errors, > > but this is one th

[Toybox] find(1) -name vs -wholename

2024-03-04 Thread enh via Toybox
obviously the patch is trivial, but i can't think of an existing toybox tool that has one of these "you're holding it wrong" errors, but this is one that i do find useful: ~/aosp-main-with-phones/prebuilts/gcc/linux-x86/host/x86_64-linux-glibc2.17-4.8$ find . -name bits/syscall.h find: warning:

Re: [Toybox] [PATCH] Minor formatting and cleanup in getopt.c

2024-03-01 Thread enh via Toybox
On Thu, Feb 29, 2024 at 5:03 PM Rob Landley wrote: > > On 2/28/24 18:23, Oliver Webb via Toybox wrote: > > I've been looking at some of the other pending commands, And found a getopt > > implementation from 2017 by AOSP. > > Looking at the source code, it doesn't seem unclean, nor overly large

Re: [Toybox] buffer sizes

2024-02-29 Thread enh via Toybox
On Thu, Feb 29, 2024 at 9:42 AM Rob Landley wrote: > > > > On 2/28/24 17:02, enh wrote: > > On Wed, Feb 28, 2024 at 1:33 PM Rob Landley wrote: > >> > >> On 2/28/24 13:14, enh via Toybox wrote: > >> > just fyi if you don't follow the coreut

Re: [Toybox] buffer sizes

2024-02-28 Thread enh via Toybox
On Wed, Feb 28, 2024 at 1:33 PM Rob Landley wrote: > > On 2/28/24 13:14, enh via Toybox wrote: > > just fyi if you don't follow the coreutils list, > > Sadly, I am still subscribed to that because: > > https://lists.gnu.org/archive/html/coreutils/2023-08/msg00100.ht

[Toybox] buffer sizes

2024-02-28 Thread enh via Toybox
just fyi if you don't follow the coreutils list, i see that they're looking at moving up from 128KiB to 256KiB buffers (but without saying how _much_ "more performance" that gets them, nor what exactly "modern hardware" means). (don't get me wrong --- this is definitely a tricky one. bionic and

Re: [Toybox] [PATCH] Clean up xz a good amount

2024-02-28 Thread enh via Toybox
On Wed, Feb 28, 2024 at 10:28 AM Rob Landley wrote: > > On 2/28/24 11:13, enh wrote: > > On Tue, Feb 27, 2024 at 8:34 PM Rob Landley wrote: > >> > static size_t bcj_x86(struct xz_dec_bcj *s, char *buf, size_t size) > >> > @@ -639,6 +640,20 @@ enum xz_ret

Re: [Toybox] [PATCH] Clean up xz a good amount

2024-02-28 Thread enh via Toybox
On Tue, Feb 27, 2024 at 8:34 PM Rob Landley wrote: > > On 2/27/24 21:27, Oliver Webb wrote: > > 2 are help text, do_xzcat was due to replacing the case statement for error > > handling with a array > > If I had to guess, xz_dec_run or xz_dec_bcj_reset > > > > It was the case statement I stripped

Re: [Toybox] [PATCH] POSIX's unexpand command

2024-02-23 Thread enh via Toybox
the BSD man page is (as so often) a lot less useless than the GNU one: https://man.freebsd.org/cgi/man.cgi?query=unexpand On Fri, Feb 23, 2024 at 6:27 PM Oliver Webb via Toybox wrote: > > Browsing through list archives from 2020, I found a mention of the unexpand > command (in POSIX) > > From

Re: [Toybox] Thoughts on seperating shell dependencies and MAYFORK commands?

2024-02-21 Thread enh via Toybox
On Wed, Feb 21, 2024 at 6:08 AM Rob Landley wrote: > > On 2/20/24 19:41, enh wrote: > >> The SHELL won't do it, because the shell cares fairly deeply about what is > >> and > >> isn't a child process. In fact pipelines have implicit ( ) around each > >>

Re: [Toybox] Thoughts on seperating shell dependencies and MAYFORK commands?

2024-02-20 Thread enh via Toybox
On Tue, Feb 20, 2024 at 10:41 AM Rob Landley wrote: > > On 2/19/24 13:40, Oliver Webb via Toybox wrote: > > When doing "make sh", scripts/single.sh looks for MAYFORK commands to pull > > in as builtin's > > Which means any command that is declared with MAYFORK is automatically > > included into

[Toybox] [PATCH] top -b: add missing flush.

2024-02-07 Thread enh via Toybox
We need to flush after each batch in batch mode. (Found by inspection, looking for sleeps similar to the vmstat one.) --- toys/posix/ps.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) 0001-top-b-add-missing-flush.patch Description: Binary data

[Toybox] [PATCH] vmstat: fix buffering.

2024-02-06 Thread enh via Toybox
--- toys/other/vmstat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) From 360f5f9a04391cd36ab5523265db9b9efd657139 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Tue, 6 Feb 2024 11:12:15 -0800 Subject: [PATCH] vmstat: fix buffering. --- toys/other/vmstat.c | 2 +- 1 file changed,

Re: [Toybox] wc -L

2024-02-05 Thread enh via Toybox
huh, i'd never heard of this (and it's not used in any of the code i have access to), but debian shows it's used a bit: https://codesearch.debian.net/search?q=wc%5C+-L=0 On Mon, Feb 5, 2024 at 9:09 AM Rob Landley wrote: > > Who was it who asked for wc -L again? Because here's what the debian

Re: [Toybox] [PATCH] memeater: consume a given amount of memory.

2024-01-31 Thread enh via Toybox
On Fri, Jan 26, 2024 at 4:10 PM enh wrote: > > > On Thu, Jan 25, 2024 at 10:00 PM Rob Landley wrote: > >> On 1/25/24 17:46, enh wrote: >> > On Wed, Jan 24, 2024 at 11:56 PM Rob Landley wrote: >> > Should the mlock() be optional? (Maybe -m? Or

Re: [Toybox] incorrect output from grep -w --color

2024-01-31 Thread enh via Toybox
iginal reproducer. > > Peter > > On Wed, Jan 31, 2024 at 10:08 AM enh wrote: > > > > pcc: that's merged in AOSP now, so let me know if that fixes everything > for you (so i can update the _host_ prebuilts before anyone hits this > there). > > > > On Tue, Jan 30, 20

Re: [Toybox] incorrect output from grep -w --color

2024-01-31 Thread enh via Toybox
pcc: that's merged in AOSP now, so let me know if that fixes everything for you (so i can update the _host_ prebuilts before anyone hits this there). On Tue, Jan 30, 2024 at 2:57 PM Rob Landley wrote: > On 1/22/24 21:09, Rob Landley wrote: > > On 1/17/24 18:57, Rob Landley wrote: > >> On

Re: [Toybox] CONFIG_TOYBOX_ZHELP

2024-01-30 Thread enh via Toybox
On Sat, Jan 20, 2024 at 2:52 PM Rob Landley wrote: > On 1/19/24 19:49, enh wrote: > > On Fri, Jan 19, 2024 at 10:13 AM Rob Landley wrote: > >> Creating the binaries isn't a big deal, it's just two .config files. I > couldn't > >> speak to the selinux labels a

Re: [Toybox] CONFIG_TOYBOX_ZHELP

2024-01-30 Thread enh via Toybox
On Fri, Jan 19, 2024 at 5:49 PM enh wrote: > On Fri, Jan 19, 2024 at 10:13 AM Rob Landley wrote: > > > > On 1/16/24 19:22, enh wrote: > > > On Sat, Jan 13, 2024 at 12:38 PM Rob Landley wrote: > > >> On 1/12/24 14:25, enh via Toybox wrote: > > >

Re: [Toybox] [PATCH] memeater: consume a given amount of memory.

2024-01-26 Thread enh via Toybox
On Thu, Jan 25, 2024 at 10:00 PM Rob Landley wrote: > On 1/25/24 17:46, enh wrote: > > On Wed, Jan 24, 2024 at 11:56 PM Rob Landley wrote: > > Should the mlock() be optional? (Maybe -m? Or for backwards > compatibility keep > > it the default and -M to _not_ lock?

Re: [Toybox] [PATCH] memeater: fixes.

2024-01-26 Thread enh via Toybox
On Fri, Jan 26, 2024 at 3:41 PM Rob Landley wrote: > On 1/26/24 11:28, enh via Toybox wrote: > > The ULONG_MAX turns into -1 here, which isn't what was intended. > > Ah. That one ONLY works on 32 bit. Oops. > (yeah, sorry, i realized after sending my patch that my LP64 bigotry

Re: [Toybox] [PATCH] Various help fixes.

2024-01-26 Thread enh via Toybox
) On Fri, Jan 26, 2024 at 2:54 AM Rob Landley wrote: > On 1/25/24 13:51, enh wrote: > > ping? (one of these [grep] came up again today...) > > I moved my local changes out of the way to apply it, and they MOSTLY made > it > back. I only have to manually fix up: > > p

[Toybox] [PATCH] grep: add missing flags to usage line.

2024-01-26 Thread enh via Toybox
Since this is my second attempt over a fairly short period of time, I'm not 100% confident this is really all of them -- and this casts doubt on the other toys I checked too! -- but until the machines take over this task, meatbots like me will have to keep trying... --- toys/posix/grep.c | 2 +-

[Toybox] [PATCH] memeater: fixes.

2024-01-26 Thread enh via Toybox
The ULONG_MAX turns into -1 here, which isn't what was intended. I'll avoid the bikeshed of the least worst full fix and take half the range which is plenty for my purposes. Also fix the array indexing to not segfault. --- toys/other/memeater.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Toybox] [PATCH] memeater: consume a given amount of memory.

2024-01-25 Thread enh via Toybox
On Wed, Jan 24, 2024 at 11:56 PM Rob Landley wrote: > On 1/24/24 15:47, enh via Toybox wrote: > > feel free to push back that "this is too Android-specific"... > > It's no sillier than devmem. > > You can't malloc more than a long so I'm switching the type to un

Re: [Toybox] [PATCH] Various help fixes.

2024-01-25 Thread enh via Toybox
ping? (one of these [grep] came up again today...) On Fri, Dec 15, 2023 at 7:06 AM enh wrote: > yeah, i was sure that was going to happen ... i just didn't know *which* > ones would conflict with your local changes. (and thought that sending you > a separate change for each file was

Re: [Toybox] [PATCH] memeater: consume a given amount of memory.

2024-01-24 Thread enh via Toybox
of toolbox). On Wed, Jan 24, 2024 at 1:46 PM enh wrote: > This seems to be a popular reinvention. There are three different > variants in the Android tree, and at least another independent one > (intended for Android) on github. > > This is the minimal intersection of them all, whi

[Toybox] [PATCH] memeater: consume a given amount of memory.

2024-01-24 Thread enh via Toybox
This seems to be a popular reinvention. There are three different variants in the Android tree, and at least another independent one (intended for Android) on github. This is the minimal intersection of them all, which will hopefully still be useful. (It's very close to the system/extras/ Android

[Toybox] xvdaemon

2024-01-24 Thread enh via Toybox
none of the three existing callers to this function does the chdir() mentioned here... ``` // daemonize via vfork(). Does not chdir("/"), caller should do that first // note: restarts process from command_main() void xvdaemon(void) ``` was there even a reason why you wanted that in the caller?

[Toybox] [PATCH] docs: stop referring to xflush() after its removal.

2024-01-22 Thread enh via Toybox
--- www/code.html | 1 - 1 file changed, 1 deletion(-) From 8921c9672a32f7f2e67f8c3bd57fd1bf298abb55 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Mon, 22 Jan 2024 16:06:24 -0800 Subject: [PATCH] docs: stop referring to xflush() after its removal. --- www/code.html | 1 - 1 file changed,

[Toybox] [PATCH] xwrap: implement xputs() like xputc().

2024-01-22 Thread enh via Toybox
Obviously I could have gone the other direction and made xputc() use xferror() like xputs() did, but given that xferror() is only used in vi, and not obviously meaningful there, I'm assuming that xferror() probably won't last... Also remove an obsolete comment that applied to xflush() but not

Re: [Toybox] CONFIG_TOYBOX_ZHELP

2024-01-19 Thread enh via Toybox
On Fri, Jan 19, 2024 at 10:13 AM Rob Landley wrote: > > On 1/16/24 19:22, enh wrote: > > On Sat, Jan 13, 2024 at 12:38 PM Rob Landley wrote: > >> On 1/12/24 14:25, enh via Toybox wrote: > >> > thanks for keeping the uncompressed path! > >> > >

Re: [Toybox] CONFIG_TOYBOX_ZHELP

2024-01-16 Thread enh via Toybox
On Sat, Jan 13, 2024 at 12:38 PM Rob Landley wrote: > > On 1/12/24 14:25, enh via Toybox wrote: > > this will hardly come as a surprise to you, but just fyi, i _haven't_ > > enabled this for AOSP, > > Understood. You weren't really the audience, it's more a "p

[Toybox] CONFIG_TOYBOX_ZHELP

2024-01-12 Thread enh via Toybox
this will hardly come as a surprise to you, but just fyi, i _haven't_ enabled this for AOSP, (a) to avoid building deflate.c (which would make it harder to recognize if we accidentally stopped using "real" zlib[1]), and (b) because we check in the generated files, and i'm not likely to check in a

Re: [Toybox] Impact of global struct size

2024-01-08 Thread enh via Toybox
On Fri, Jan 5, 2024 at 10:45 PM Rob Landley wrote: > > On 1/2/24 16:58, Ray Gardner wrote: > > On Mon, Jan 1, 2024 at 1:39 PM Rob Landley wrote: > >> ... [ a very long and detailed reply ] ... > > > > Rob, thank you for the "GIANT INFODUMP", and I mean that sincerely. It > > took me a while to

  1   2   3   4   5   6   7   8   9   10   >