Re: [U-Boot] [PATCH 1/3] arm: socfpga: Remove unused FPGA feature from gen5 SPL

2017-07-27 Thread Chee, Tien Fong
On Kha, 2017-07-27 at 11:37 +0200, Marek Vasut wrote: > On 07/27/2017 11:21 AM, Chee, Tien Fong wrote: > > > > On Kha, 2017-07-27 at 10:21 +0200, Marek Vasut wrote: > > > > > > On 07/27/2017 06:36 AM, tien.fong.c...@intel.com wrote: > > > > > > > > > > > > From: Tien Fong Chee

[U-Boot] [PATCH 1/2] board: sama5d2_xplained: Move setting ethaddr to common

2017-07-27 Thread Wenyou Yang
The code to set ethernet mac address can be shared by other boards, so move such code to board/$(VENDOR)/common directory. Signed-off-by: Wenyou Yang --- arch/arm/mach-at91/include/mach/at91_common.h | 2 + board/atmel/common/Makefile | 8

Re: [U-Boot] [PATCH v5 00/20] dm: tegra: Move nyan-big, jetson-tk1, beaver to livetree

2017-07-27 Thread Simon Glass
Hi Stephen, On 25 July 2017 at 15:24, Stephen Warren wrote: > On 07/25/2017 08:29 AM, Simon Glass wrote: >> >> This moves four entire boards to use a live device tree as an example of >> the impact. > > ... >> >> This series is available at u-boot-dm/livet-working >> >>

Re: [U-Boot] [PATCH RESEND] ahci: dm: Fix memory allocation for uclass private data

2017-07-27 Thread Simon Glass
Hi, On 19 July 2017 at 04:57, Jean-Jacques Hiblot wrote: > Allocate manually the uclass private data in ahci_init_dm(). Don't do this > in the declaration of the scsi uclass driver with > .per_device_auto_alloc_size because it is AHCI specific. > > Signed-off-by: Jean-Jacques

Re: [U-Boot] [PATCH 1/2] sandbox: remove os_putc() and os_puts()

2017-07-27 Thread Simon Glass
On 16 July 2017 at 22:08, Masahiro Yamada wrote: > They are unused since commit d8c6fb8cedbc ("sandbox: Drop special > case console code for sandbox"). > > Signed-off-by: Masahiro Yamada > --- > > arch/sandbox/cpu/os.c | 11

Re: [U-Boot] [PATCH v2 2/7] efi_loader: implement multiple event support

2017-07-27 Thread Simon Glass
Hi, On 18 July 2017 at 12:17, Heinrich Schuchardt wrote: > Up to now the boot time supported only a single event. > This patch now allows four events. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > add TPL constants > consider

Re: [U-Boot] [PATCH v3 05/15] usb: hub: Add a new API to test if a hub device is root hub

2017-07-27 Thread Simon Glass
On 19 July 2017 at 07:51, Bin Meng wrote: > Sometimes we need know if a given hub device is root hub or not. > Add a new API to test this. This removes the xHCI driver's own > version is_root_hub() and change to use the new API. > > While we are here, remove the

Re: [U-Boot] [PATCH 2/6] ARM: at91: spl: Add mck function to lower rate while switching

2017-07-27 Thread Simon Glass
Hi Wenyou, On 20 July 2017 at 02:12, Wenyou Yang wrote: > Refer to the commit 70f8c8316ad(PMC: add new mck function to lower > rate while switching) from AT91Bootstrap. > > While switching to a lower clock source, we must switch the clock > source first instead of

Re: [U-Boot] [PATCH] dm: ofnode: change return type of dev_read_prop() to opaque pointer

2017-07-27 Thread Simon Glass
On 16 July 2017 at 21:18, Masahiro Yamada wrote: > DT property values can be strings as well as integers. This is why > of_get_property/fdt_getprop returns an opaque pointer. > > Signed-off-by: Masahiro Yamada > --- > >

Re: [U-Boot] [PATCH 6/6] board: atmel: Add SAMA5D27 SOM1 EK board

2017-07-27 Thread Simon Glass
Hi Wenyou, On 20 July 2017 at 02:13, Wenyou Yang wrote: > From: Wenyou Yang > > The SAMA5D27-SiP (System in Package) integrates the SAMA5D2 > with 1Gbit DDR2-SDRAM in a single package. > > The SAMA5D27 SOM1 embeds a 64Mbit QSPI flash, KSZ8081

Re: [U-Boot] [PATCH 1/6] ARM: at91: spl: Adjust switching to oscillator for SAMA5D2

2017-07-27 Thread Simon Glass
On 20 July 2017 at 02:12, Wenyou Yang wrote: > As said in 29.5.7 section of SAMA5D2 datasheet, before switching to > the crystal oscillator, a check must be carried out to ensure that > the oscillator is present and that its freqency is valid. > > Signed-off-by: Wenyou

Re: [U-Boot] [PATCH v5 00/20] dm: tegra: Move nyan-big, jetson-tk1, beaver to livetree

2017-07-27 Thread Simon Glass
Hi Lukasz, On 26 July 2017 at 02:41, Ɓukasz Majewski wrote: > Hi Simon > >> This moves four entire boards to use a live device tree as an example of >> the impact. > > > I've grepp'ed the ./doc directory and couldn't find any info regarding > "livetree" feature. > > From patches,

Re: [U-Boot] [PATCH 4/6] ARM: at91: mach: Add missing defines of MPDDRC

2017-07-27 Thread Simon Glass
On 20 July 2017 at 02:13, Wenyou Yang wrote: > Add missing defines of Multiport DDR-SDRAM Controller (MPDDRC). > > Signed-off-by: Wenyou Yang > --- > > arch/arm/mach-at91/include/mach/atmel_mpddrc.h | 4 > 1 file changed, 4

Re: [U-Boot] [PATCH] board: sama5d2_xplained: Make SPL work on spiflash

2017-07-27 Thread Simon Glass
On 20 July 2017 at 02:28, Wenyou Yang wrote: > Because before switching to a lower clock source, we must switch > the clock source first instead of last. So before configuring the > PMC_MCKR register, invoke at91_mck_init_down() first. > > As said in datasheet, the the

Re: [U-Boot] [PATCH v9 04/10] usb: phy: Add STi USB2 PHY

2017-07-27 Thread Simon Glass
On 18 July 2017 at 06:31, wrote: > From: Patrice Chotard > > This is the generic phy driver for the picoPHY ports > used by USB2/1.1 controllers. It is found on STiH407 SoC > family from STMicroelectronics. > > Signed-off-by: Patrice Chotard

Re: [U-Boot] [PATCH v9 07/10] usb: dwc3: Add dwc3 glue driver support for STi

2017-07-27 Thread Simon Glass
On 18 July 2017 at 06:31, wrote: > From: Patrice Chotard > > This patch adds the ST glue logic to manage the DWC3 HC > on STiH407 SoC family. It configures the internal glue > logic and syscfg registers. > > Part of this code been extracted from

Re: [U-Boot] [PATCH 10/14] dm: mmc: sunxi: Add support for driver model

2017-07-27 Thread Simon Glass
Hi Maxime, On 17 July 2017 at 03:26, Maxime Ripard wrote: > Hi Simon, > > On Fri, Jul 14, 2017 at 07:47:45AM -0600, Simon Glass wrote: >> On 5 July 2017 at 14:14, Maxime Ripard >> wrote: >> > On Wed, Jul 05, 2017 at 04:57:40PM

Re: [U-Boot] [PATCH 3/6] ARM: at91: spl: Add boot device for boot from QSPI

2017-07-27 Thread Simon Glass
On 20 July 2017 at 02:13, Wenyou Yang wrote: > Add the boot device for booting from the QSPI flash. > > Signed-off-by: Wenyou Yang > --- > > arch/arm/mach-at91/spl.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH 2/2] console: simplify puts()

2017-07-27 Thread Simon Glass
Hi Masahiro, On 16 July 2017 at 22:08, Masahiro Yamada wrote: > Current puts() and putc() have similar #ifdef / if() conditionals. > Make puts() iterate over putc() to avoid code duplication. > > Signed-off-by: Masahiro Yamada > ---

Re: [U-Boot] [PATCH 4/5] dm: ofnode: rename dev_read_prop() to dev_get_property()

2017-07-27 Thread Simon Glass
Hi Masahiro, On 16 July 2017 at 21:29, Masahiro Yamada wrote: > Hi Simon, > > 2017-07-14 23:20 GMT+09:00 Simon Glass : >> Hi Masahiro, >> >> On 13 July 2017 at 20:38, Masahiro Yamada >> wrote: >>> Hi Simon, >>>

Re: [U-Boot] [PATCH v11 10/10] usb: host: ohci-generic: add generic PHY support

2017-07-27 Thread Simon Glass
On 24 July 2017 at 05:46, wrote: > From: Patrice Chotard > > Extend ohci-generic driver with generic PHY framework > > Signed-off-by: Patrice Chotard > --- > v11:_ fix issue reported by Patrick DELAUNAY, Generic PHY

Re: [U-Boot] [PATCH v11 07/10] usb: host: ehci-generic: add generic PHY support

2017-07-27 Thread Simon Glass
On 24 July 2017 at 05:46, wrote: > From: Patrice Chotard > > Extend ehci-generic driver with generic PHY framework > > Signed-off-by: Patrice Chotard > --- > v11:_ fix issue reported by Patrick DELAUNAY, Generic PHY

Re: [U-Boot] [PATCH v2 46/56] rockchip: rk3368: add DRAM controller driver with DRAM initialisation

2017-07-27 Thread Simon Glass
Hi Philipp, On 26 July 2017 at 04:40, Philipp Tomsich wrote: > This adds a DRAM controller driver for the RK3368 and places it in > drivers/ddr/rockchip (where the other DM-enabled DRAM controller > drivers for rockchip devices should also be moved

Re: [U-Boot] [PATCH v2 54/56] rockchip: board: lion-rk3368: add support for the RK3368-uQ7

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > The RK3368-uQ7 (codenamed 'Lion') is a micro-Qseven (40mm x 70mm, > MXM-230 edge connector compatible with the Qseven specification) > form-factor system-on-module based on the octo-core Rockchip RK3368. >

Re: [U-Boot] [PATCH v2 50/56] rockchip: spl: make spl-boot-order code reusable (split from rk3399)

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > In order to reuse the support for the u-boot,spl-boot-order property > from the rk3399, we split it into a reusable module that can be > included by the SPL code for any of our boards. > > Signed-off-by:

Re: [U-Boot] [PATCH v2 17/56] spl: Kconfig: split SYS_MALLOC_SIMPLE for TPL and SPL

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > As include/malloc.h already checks for SYS_MALLOC_SIMPLE using the > CONFIG_IS_ENABLED macro, we need to move to having separate entries > as we switch to fully separate configuration for SPL and TPL. > >

Re: [U-Boot] [PATCH v2 37/56] rockchip: clk: rk3368: implement DPLL (DRAM PLL) support

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > To implement a TPL stage (incl. its DRAM controller setup) for the > RK3368, we'll want to configure the DPLL (DRAM PLL). > > This commit implements setting the DPLL (CLK_DDR) and provides PLL >

Re: [U-Boot] [PATCH v2 51/56] rockchip: rk3368: spl: add SPL support

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > Adds SPL support for the RK3368 (assuming that our TPL stage has > initialised DRAM and set up the memory firewall). > > Signed-off-by: Philipp Tomsich > > --- > >

Re: [U-Boot] [PATCH v2 49/56] rockchip: rk3368: spl: add TPL support

2017-07-27 Thread Simon Glass
Hi Philipp, On 26 July 2017 at 04:40, Philipp Tomsich wrote: > This adds the TPL support for the RK3368, including the u-boot-tpl.lds. > > Signed-off-by: Philipp Tomsich > > --- > > Changes in v2: > - copies the enum

Re: [U-Boot] [PATCH v2 21/56] drivers: spl: consistently use the $(SPL_TPL_) macro

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > To simplify drivers/Makefile a bit when using TPL/SPL, we consistently > use the $(SPL_TPL_) macro to test for drivers that have separate > configuration symbols for the full U-boot, SPL and TPL stages. >

Re: [U-Boot] [PATCH v2 18/56] lib: spl: differentiate between TPL and SPL for libfdt/of_control/of_platdata

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > This splits the compilation of code modules for TPL and SPL for > OF_CONTROL (and related) features between TPL and SPL. The typical > use-case of this is a TPL stage that uses OF_PLATDATA at TPL and >

Re: [U-Boot] [PATCH v2 45/56] rockchip: Makefile: streamline SPL/TPL configuration

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > Handling TPL and SPL in the Makefile for mach-rockchip was based on > nested if checks and/or if-else-if paths. This can be simplified and > made more readable by using $(SPL_TPL_) and by introducing >

[U-Boot] [PATCH] configs: sama5d4_xplained: Fix input clock for debug UART

2017-07-27 Thread Wenyou Yang
Fix the UART input clock for the early debug UART, it should be 100MHz, instead of 88MHz. Signed-off-by: Wenyou Yang --- configs/sama5d4_xplained_mmc_defconfig | 2 +- configs/sama5d4_xplained_nandflash_defconfig | 2 +-

Re: [U-Boot] [PATCH v2 13/56] spl: dm: use CONFIG_IS_ENABLED to test for the DM option

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > Even though there's now a TPL_DM configuration option, the spl logic > still checks for SPL_DM and thus does not pick up the proper config > option. > > This introduces the use of CONFIG_IS_ENABLED(DM) in

Re: [U-Boot] [PATCH v2 48/56] rockchip: rk3368: spl: enable SPL_FRAMEWORK in rk3368_common.h

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > To build TPL and SPL stages for the RK3368, we will also need to > enable the SPL_FRAMEWORK. > > Signed-off-by: Philipp Tomsich > > Version-changes: 2 > - dropped

Re: [U-Boot] [PATCH v2 20/56] spl: add TPL_DRIVER_MISC_SUPPORT option

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > This adds the TPL_DRIVER_MISC_SUPPORT option to allow activation of > DRIVER_MISC_SUPPORT for devices that need it in the TPL stage. > > Signed-off-by: Philipp Tomsich

Re: [U-Boot] [PATCH v2 42/56] rockchip: clk: rk3368: mark 'priv' __maybe_unused in rk3368_clk_set_rate()

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > With the clock support in rk3368_clk_set_rate() conditionalized on > various feature definitions, 'priv' can remain unused (e.g. in the > SPL build when only MMC is enabled). > > Signed-off-by: Philipp

Re: [U-Boot] [PATCH v2 53/56] rockchip: spi: enable support for the rk_spi driver for the RK3368

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > For the RK3368, we can reuse the SPI driver (although we'll have to > eventually investigate whether it can be merged with the > designware_spi.c driver) also used for the RK3288 and RK3399. > This adds the

Re: [U-Boot] [RFC PATCH] Convert ARCH_OMAP2PLUS boards' CONFIG_SYS_TEXT_BASE to Kconfig

2017-07-27 Thread Lokesh Vutla
On 7/27/2017 10:33 AM, Adam Ford wrote: > This converts the following to Kconfig: >CONFIG_SYS_TEXT_BASE > > I left the header file data intact (for now), but I tested this on the > omap3_logic_defconfig and am3517_evm_defconfig without any errors. I did this > partially because I wanted

Re: [U-Boot] [PATCH v2 19/56] spl: consistently use $(SPL_TPL_) to select features for SPL and TPL builds

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > To allow for a finer-grained control of features for TPL and SPL > builds all modules/boot-methods/etc. need to be consistently selected > based on the $(SPL_TPL_) macros. > > This allows splitting the

Re: [U-Boot] [PATCH v2 47/56] rockchip: dts: rk3368: add DMC node in rk3368.dtsi

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > For full SPL support, including DRAM initialisation, we need a few > nodes from the DTS: this commit adds the DMC (DRAM controller) node, > the service_msch (memory scheduler) node and marks GRF, PMUGRF and

Re: [U-Boot] [PATCH v2 24/56] rockchip: rk3368: mkimage: add support for the RK3368

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > This commit adds support for RK3368 SoC in mkimage. > > Signed-off-by: Philipp Tomsich > --- > > Changes in v2: None > > tools/rkcommon.c | 1 + > 1 file changed, 1

Re: [U-Boot] [PATCH v2 32/56] rockchip: pinctrl: rk3368: move IOMUX bit-definitions to pinctrl driver

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > There is no real reason to keep the bit-definitions for the IOMUX in > the grf header file (which defines the register layout of the GRF block): > these should only be used by our pinctrl driver (with the

Re: [U-Boot] [PATCH v2 41/56] rockchip: clk: rk3368: add support for GMAC (SLCK_MAC) clock

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > To enable the GMAC on the RK3368, we need to set up the clocking > appropriately to generate a tx_clk for the MAC. > > This adds an implementation that implements the use of the <_gmac> > clock (i.e. an

Re: [U-Boot] [PATCH v2 39/56] rockchip: clk: rk3368: implement MMC/SD clock reparenting

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > The original clock support for MMC/SD cards on the RK3368 suffered > from a tendency to select a divider less-or-equal to the the one > giving the requested clock-rate: this can lead to higher-than-expected

Re: [U-Boot] [PATCH v2 00/34] env: Move environment code to use location drivers

2017-07-27 Thread Simon Glass
Hi Masahiro, On 25 July 2017 at 22:51, Masahiro Yamada wrote: > Hi Simon, > > > 2017-07-24 12:19 GMT+09:00 Simon Glass : >> The environment code is ripe for improvement in various ways. It has lots >> of duplication and inconsistencies between

Re: [U-Boot] [PATCH v2 38/56] rockchip: clk: rk3368: define DMA1_SRST_REQ and DMA2_SRST_REQ

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > On he RK3368, we need to temporarily disable security on the DMA > engines during TPL and SPL to allow the MMC host to DMA into DRAM. To > do so, we need to reset the two DMA engines, which in turn requires

Re: [U-Boot] [PATCH v2 11/56] spl: dm: Kconfig: split CLK support for SPL and TPL

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > Introduce TPL_CLK to allow finer-grained selection of TPL features > for feature-rich (i.e. DM-based) TPL stages. > > Signed-off-by: Philipp Tomsich > --- > > Changes

Re: [U-Boot] [PATCH v2 26/56] rockchip: rk3368: spl: define COUNTER_FREQUENCY to 24MHz

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > The BootROM of the RK3368 Boot ROM does not initialise cntfrq_el0. > This change defines COUNTER_FREQUENCY, which is used by the AArch64 init > code in arch/arm/cpu/armv8/start.S to set up cntfrq_el0. > > If

Re: [U-Boot] [PATCH v2 55/56] rockchip: board: puma-rk3399: fix warnings in puma_rk3399/fit_spl_atf.its

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > The ITS file generated warnings due to @ designations in the naming > which cause DTC to complain as follows: > Warning (unit_address_vs_reg): Node /images/uboot@1 has a unit name, but no > reg property >

Re: [U-Boot] [PATCH v2 31/56] rockchip: pinctrl: rk3368: add support for configuring the MMC pins

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > The RK3368 has two SD/MMC controllers that can be used from U-Boot > both during SPL and for booting an OS from the full bootloader stage. > While both are configured to (mostly) sensible settings from the

Re: [U-Boot] [PATCH v2 33/56] rockchip: pinctrl: rk3368: add SPI support

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > To implement pinctrl support for the RK3368, we need to add the > bit-definitions to configure the IOMUX and tie these into the > pinctrl framework. This also adds the mapping from the IRQ# back > onto the

Re: [U-Boot] [PATCH v2 29/56] rockchip: rk3368: grf: use shifted-constants

2017-07-27 Thread Simon Glass
Hi Philipp, On 26 July 2017 at 04:40, Philipp Tomsich wrote: > The RK3368 GRF header was still defines with a shifted-mask but with > non-shifted function selectors for the IOMUX defines. As the RK3368 > support is still fresh enough to allow a quick

Re: [U-Boot] [PATCH v2 28/56] rockchip: rk3368: syscon: MSCH/PMUGRF/GRF support for OF_PLATDATA

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > The RK3368 has both a limited SPL size (just 0x7000 bytes) and the > added challenge of booting in AArch64, which increases the code size > for SPL (particularily when using the LP64 programming model). For

Re: [U-Boot] [PATCH v2 15/56] armv8: spl: Support separate stack for TPL

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > To allow a TPL and SPL to run from different addresses/memories, we > need to split setup of the TPL and SPL stacks. To do so, we introduce > CONFIG_TPL_STACK (not listed in Kconfig) which can be used to

Re: [U-Boot] [PATCH v2 04/56] rockchip: back-to-bootrom: split BACK_TO_BOOTROM for TPL/SPL

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > The back-to-bootrom option is rather unfortunately named > CONFIG_ROCKCHIP_SPL_BACK_TO_BOOTROM > instead of > CONFIG_SPL_ROCKCHIP_BACK_TO_BOOTROM > > To make is selectable through

Re: [U-Boot] [PATCH v2 25/56] rockchip: rk3368: pmugrf: add definitions for os_reg[0..3]

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > On the RK3368 we use a TPL-stage similar to Rockchip's DDR init > (i.e. it initialises DRAM, leaves some info for the next stage and > returns to the BootROM). To allow compatibility with Rockchip's DDR >

Re: [U-Boot] [PATCH v2 05/56] rockchip: back-to-bootrom: simplify the #ifdef-check for LIBGENERIC in TPL/SPL

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > With the finer-grained control over LIBGENERIC_SUPPORT for TPL/SPL (i.e. > with the newly introduced distinction between TPL_LIBGENERIC_SUPPORT and > SPL_LIBGENERIC_SUPPORT), we can simplify the #ifdef-check

Re: [U-Boot] [PATCH v2 12/56] spl: dm: Kconfig: split OF_CONTROL and OF_PLATDATA between SPL and TPL

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > For the RK3368, we want to use OF_PLATDATA in TPL, but full OF_CONTROL > in SPL: this requires the introduction of a new family of > configuration options to decouple SPL_OF_CONTROL and SPL_OF_PLATDATA >

Re: [U-Boot] [PATCH v2 30/56] rockchip: pinctrl: rk3368: add GMAC (RGMII only) support

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > To add GMAC (Gigabit Ethernet) support (limited to RGMII only at this > point), we need support for additional pin-configuration. This commit > adds the pinctrl support for GMAC in RGMII mode: > * adds a

Re: [U-Boot] [PATCH v2 34/56] rockchip: clk: rk3368: implement bandwidth adjust for PLLs

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > The RK3368 TRM recommends to configure the bandwith adjustment (CON2) > for PLLs to NF/2. This implements this for all reconfigurations of > PLLs and removes the 'has_bwadj' flag (as the RK3368 always has

Re: [U-Boot] [PATCH v2 56/56] rockchip: board: puma_rk3399: rename ATF firmware

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:41, Philipp Tomsich wrote: > From: Klaus Goger > > prefix the bl31 firmware needed to build uboot.itb so it can coexist in > the build area with ATFs from other boards (i.e. lion_rk3368) > >

Re: [U-Boot] [PATCH v2 07/56] spl: dm: Kconfig: split REGMAP/SYSCON support for TPL from SPL

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > This change introduces TPL variants of the REGMAP and SYSCON config > options (i.e. TPL_REGMAP and TPL_SYSCON in analogy to SPL_REGMAP and > SPL_SYSCON) in preparation of a finer-grained feature selection

Re: [U-Boot] [PATCH v2 40/56] rockchip: clk: rk3368: support configuring the DRAM PLL (from TPL)

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > As part of the DRAM initialisation process (running as part of the TPL > stage) on the RK3368, we need to set up the DRAM PLL. > > This implements support for configuring the PLL to for 1200, 1332 or > 1600

Re: [U-Boot] [PATCH v2 44/56] net: gmac_rockchip: Add support for the RK3368 GMAC

2017-07-27 Thread Simon Glass
Hi Philipp, On 26 July 2017 at 04:40, Philipp Tomsich wrote: > The GMAC in the RK3368 once again is identical to the incarnation in > the RK3288 and the RK3399, except for where some of the configuration > and control registers are located in the GRF. > >

Re: [U-Boot] [PATCH v2 43/56] rockchip: clk: rk3368: add support for configuring the SPI clocks

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > As SPI support may be useful in the boot-flow, this adds support for > configuring the SPI controller's clocks in the RK3368 clock driver. > > Signed-off-by: Philipp Tomsich

Re: [U-Boot] [PATCH v2 22/56] rockchip: Makefile: allow selective inclusion of sdram_common.o from TPL/SPL/U-Boot

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > The utility functions in sdram_common.c will be useful both for some > SPL implementations (and if unused, the linked will discard these > anyway) and for the full U-Boot stage. > > This changes selects

Re: [U-Boot] [PATCH v2 35/56] rockchip: clk: rk3368: support OF_PLATDATA for the RK3368 clk driver

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > With the RK3368's limited TPL size, we'll want to use OF_PLATFDATA for > the SPL stage. This implements support for OF_PLATDATA in the clock > driver for the RK3368. > > Signed-off-by: Philipp Tomsich

Re: [U-Boot] [PATCH v2 23/56] rockchip: rk3368: improve Kconfig text for the RK3368

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > The RK3368 option in Kconfig referred to the RK3328 (copy-and-paste) > and had a few typos and unnecessarily used UTF-8 characters. While > fixing this, I also reformatted and further clarified the text >

Re: [U-Boot] [PATCH v2 08/56] spl: dm: Kconfig: SPL_RAM depends on SPL_DM

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > This commit models the dependency from SPL_RAM to SPL_DM in Kconfig. > > Signed-off-by: Philipp Tomsich > --- > > Changes in v2: None > > drivers/ram/Kconfig | 2 +- >

Re: [U-Boot] [PATCH v2 52/56] rockchip: rk3368: spl: mark SPL and TPL as supported for ROCKCHIP_RK3368

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > With SPL and TPL support for the RK3368 in place, mark SPL and TPL as > supported from Kconfig for the RK3368. As this is primarily tested on > the RK3368-uQ7, we'll leave it to board's individual defconfig

Re: [U-Boot] [PATCH v2 09/56] spl: dm: Kconfig: introduce TPL_RAM (in analogy to SPL_RAM)

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > To allow finer grained selection of features for TPL, we introduce > TPL_RAM (in analogy to SPL_RAM). > > Signed-off-by: Philipp Tomsich > --- > > Changes in v2: None

Re: [U-Boot] [PATCH v2 03/56] rockchip: back-to-bootrom: add 'back-to-bootrom' support for AArch64

2017-07-27 Thread Simon Glass
Hi Philipp, On 26 July 2017 at 04:40, Philipp Tomsich wrote: > The back-to-bootrom support for Rockchip is equivalent to an > (assembly) implementation of setjmp/longjmp (i.e. it saves the > stack-pointer, link-register and callee-saved registers). Up until

Re: [U-Boot] [PATCH v2 36/56] rockchip: clk: rk3368: do not change CPLL/GPLL before returning to BROM

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > The RK3368 has a somewhat temperamental BootROM (which I learned the > hard way) when it comes to reconfiguring the CPLL and GPLL (in fact, > experiments show that changing the GPLL broke things for me,

Re: [U-Boot] [PATCH v2 10/56] spl: dm: Kconfig: SPL_CLK depens on SPL_DM

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > SPL_CLK should also depend on SPL_DM (and not just on CLK). > Add the additional dependency. > > Signed-off-by: Philipp Tomsich > --- > > Changes in v2: None > >

Re: [U-Boot] [PATCH v2 02/56] spl: configure 'return to bootrom' separately for SPL and TPL

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > On the RK3368, we want our TPL to use the 'return to bootrom' boot > method (to have the bootrom load up the SPL stage) and then continue > with different boot methods (MMC, SPI, etc.) from SPL. > > This

Re: [U-Boot] [PATCH v2 27/56] rockchip: rk3368: spl: add memory layout for TPL and SPL

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > For the RK3368, we use a multi-stage boot-process consisting of the > following: > 1. TPL: initalises DRAM, returns to boot-ROM (which then loads >the next stage and transfers control to it) >

Re: [U-Boot] [PATCH v2 06/56] spl: dm: Kconfig: use more specific prereqs for SPL_REGMAP and SPL_SYSCON

2017-07-27 Thread Simon Glass
On 26 July 2017 at 04:40, Philipp Tomsich wrote: > SPL_REGMAP and SPL_SYSCON were marked as depending on DM, when a > stricter dependency of SPL_DM was possible. This commit makes the > prereq more specific. > > Signed-off-by: Philipp Tomsich

Re: [U-Boot] [PATCH] rockchip: timer: make register sizes explicit

2017-07-27 Thread Simon Glass
On 14 July 2017 at 10:09, Philipp Tomsich wrote: > We are about to reuse the rockchip timer (header file) for 64bit ARMv8 > chips, so it seems a good time to make the register sizes explicit by > changing from 'unsigned int' to 'u32'. > > Signed-off-by:

Re: [U-Boot] [PATCH] rockchip: efuse: dm: change to use dev_read_addr

2017-07-27 Thread Simon Glass
On 14 July 2017 at 10:09, Philipp Tomsich wrote: > This changes the rockchip-efuse driver to use dev_read_addr instead of > devfdt_get_addr. > > Signed-off-by: Philipp Tomsich > --- > > drivers/misc/rockchip-efuse.c |

Re: [U-Boot] [PATCH] rockchip: rk3399: enable SPL_SERIAL_SUPPORT and SPL_DRIVERS_MISC via Kconfig

2017-07-27 Thread Simon Glass
On 14 July 2017 at 08:29, Philipp Tomsich wrote: > SPL_SERIAL_SUPPORT and SPL_DRIVERS_MISC were previously enabled through > rk3399_common.h. This change implies these options through Kconfig. > > These need to always be active for the RK3399, as follows: >

Re: [U-Boot] [RFC PATCH 1/9] mx6: Add board mx6memcal for use in validating DDR

2017-07-27 Thread Eric Nelson
Hi Fabio, On Fri, Jul 14, 2017 at 12:01 PM, Fabio Estevam wrote: > Hi Eric, > > On Fri, Jul 14, 2017 at 2:58 PM, Eric Nelson wrote: > > > I set this aside because I wasn't able to get the "return to > > RBL" code working and figured I'd try to

Re: [U-Boot] [PATCH 3/5] configs: Replace deprecated Micrel defines with PHY_MICREL_KSZ90X1

2017-07-27 Thread Alex
On 07/27/2017 03:12 PM, Joe Hershberger wrote: On Fri, Jul 7, 2017 at 1:36 PM, Alexandru Gagniuc wrote: These boards will now use the ksz90x1 driver instead of the mess in ksz8xxx. This change is needed before the two drivers can be fully separated. Signed-off-by:

Re: [U-Boot] [RFC 10/10] efi_loader: support load_image() from a file-path

2017-07-27 Thread Rob Clark
On Thu, Jul 27, 2017 at 5:38 PM, Rob Clark wrote: > Previously we only supported the case when the EFI application loaded > the image into memory for us. But fallback.efi does not do this. > > Signed-off-by: Rob Clark > --- >

Re: [U-Boot] [PATCH 5/5] net: phy: Hide Micrel KSZ9021 and KSZ9031 Kconfig options

2017-07-27 Thread Joe Hershberger
On Fri, Jul 7, 2017 at 1:37 PM, Alexandru Gagniuc wrote: > The correct option is PHY_MICREL_KSZ90X1, but some configs still > select the 9021 and 9031 options, which are deprecated. > > Signed-off-by: Alexandru Gagniuc Acked-by: Joe Hershberger

Re: [U-Boot] [PATCH 04/51] net: phy: marvell: Fix style violations

2017-07-27 Thread Joe Hershberger
On Fri, Jul 14, 2017 at 7:54 AM, Mario Six wrote: > Fix some style violations in the Marvell PHY driver. > > Signed-off-by: Mario Six Acked-by: Joe Hershberger ___ U-Boot mailing list

Re: [U-Boot] [PATCH 4/5] net: phy: micrel: Remove ksz90x1 drivers from micrel_ksz8xxx

2017-07-27 Thread Joe Hershberger
On Fri, Jul 7, 2017 at 1:36 PM, Alexandru Gagniuc wrote: > There should be no longer be any ksz9000 users that pick up the PHY > driver from ksz8xxx, so remove ksz9000 remnants from there. > > Signed-off-by: Alexandru Gagniuc Acked-by: Joe Hershberger

Re: [U-Boot] [PATCH 3/5] configs: Replace deprecated Micrel defines with PHY_MICREL_KSZ90X1

2017-07-27 Thread Joe Hershberger
On Fri, Jul 7, 2017 at 1:36 PM, Alexandru Gagniuc wrote: > These boards will now use the ksz90x1 driver instead of the mess in > ksz8xxx. This change is needed before the two drivers can be fully > separated. > > Signed-off-by: Alexandru Gagniuc Would

Re: [U-Boot] [PATCH 2/5] net: phy: micrel: Separate KSZ9000 drivers from KSZ8000 drivers

2017-07-27 Thread Joe Hershberger
On Fri, Jul 7, 2017 at 1:36 PM, Alexandru Gagniuc wrote: > The KS8721BL and KSZ9021 PHYs are software-incompatible, yet they > share the same ID. Drivers for bothe PHYs cannot safely coexist, so > the solution was to use #ifdefs to select between the two drivers. > > As a

Re: [U-Boot] [PATCH 1/5] net: phy: Remove duplicate Kconfig selection for Micrel KSZ9021

2017-07-27 Thread Joe Hershberger
On Fri, Jul 7, 2017 at 1:36 PM, Alexandru Gagniuc wrote: > --- > drivers/net/phy/Kconfig | 8 > 1 file changed, 8 deletions(-) Acked-by: Joe Hershberger ___ U-Boot mailing list

Re: [U-Boot] [PATCH] net: usb: r8152: fix "duplicate 'const' declaration specifier"

2017-07-27 Thread Joe Hershberger
On Sun, Jun 25, 2017 at 3:47 PM, Philipp Tomsich wrote: > After upgrading to GCC 7.1, the duplicate const specifies in the > r8152 driver trigger the following build warnings with buildman > (observed on a 'buildman rockchip' test):: >

Re: [U-Boot] [ PATCH v3] net: move Broadcom SF2 driver to Kconfig

2017-07-27 Thread Joe Hershberger
On Mon, Jul 10, 2017 at 4:05 PM, Steve Rae wrote: > From: Suji Velupillai > > move to Kconfig: > CONFIG_BCM_SF2_ETH > CONFIG_BCM_SF2_ETH_DEFAULT_PORT > CONFIG_BCM_SF2_ETH_GMAC > > Also modified defconfigs of all

[U-Boot] [RFC 10/10] efi_loader: support load_image() from a file-path

2017-07-27 Thread Rob Clark
Previously we only supported the case when the EFI application loaded the image into memory for us. But fallback.efi does not do this. Signed-off-by: Rob Clark --- lib/efi_loader/efi_boottime.c | 91 --- 1 file changed, 76

Re: [U-Boot] [PATCH] net: tftp: silence a subscript above array bounds compile time warning

2017-07-27 Thread Joe Hershberger
On Wed, Jun 28, 2017 at 2:56 PM, Vladimir Zapolskiy wrote: > For strncpy() select a minimal string length of destination and source > strings, here DEFAULT_NAME_LEN is preferable to MAX_LEN. > > Due to the NUL-terminated contents of default_string the change is > a noop, however

Re: [U-Boot] [PATCH] drivers/net/phy/fixed: do not overwrite addr

2017-07-27 Thread Joe Hershberger
On Tue, Jun 6, 2017 at 7:35 AM, Christian Gmeiner wrote: > phy_device_create(..) sets the addr of phy_device with a sane value. > There is no need overwrite it. > > Signed-off-by: Christian Gmeiner Acked-by: Joe Hershberger

[U-Boot] [RFC 08/10] efi_loader: refactor boot device and loaded_image handling

2017-07-27 Thread Rob Clark
Get rid of the hacky fake boot-device and duplicate device-path constructing (which needs to match what efi_disk and efi_net do). Instead convert over to use efi_device_path helpers to construct device-paths, and use that to look up the actual boot device. Also, extract out a helper to plug

[U-Boot] [RFC 06/10] efi_loader: use proper device-paths for partitions

2017-07-27 Thread Rob Clark
Also, create disk objects for the disk itself, in addition to the partitions. (UEFI terminology is a bit confusing, a "disk" object is really a partition.) This helps grub properly identify the boot device since it is trying to match up partition "disk" object with it's parent device. Now

[U-Boot] [RFC 02/10] efi: fill in disk signature bits of hard drive device path.

2017-07-27 Thread Rob Clark
From: Peter Jones EFI client programs need the signature information from the partition table to determine the disk a partition is on, so we need to fill that in here. Signed-off-by: Peter Jones --- disk/part_dos.c| 12 +--- disk/part_efi.c

[U-Boot] [RFC 09/10] efi_loader: add file/filesys support

2017-07-27 Thread Rob Clark
fallback.efi (and probably other things) use UEFI's simple-file-system protocol and file support to search for OS's to boot. Signed-off-by: Rob Clark --- fs/fs.c | 21 ++ include/efi.h | 2 + include/efi_api.h

[U-Boot] [RFC 07/10] efi_loader: use proper device-paths for net

2017-07-27 Thread Rob Clark
Signed-off-by: Rob Clark --- include/efi_loader.h | 2 +- lib/efi_loader/efi_net.c | 24 +++- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/include/efi_loader.h b/include/efi_loader.h index f09d0a8003..c5cc15fc4c 100644 ---

  1   2   3   >