Re: [U-Boot] [PATCH v1] rtc: rewrite isl1208 to support DM

2018-03-18 Thread Dr. Philipp Tomsich
> On 18 Mar 2018, at 18:35, Klaus Goger > wrote: > > Adds devicemodel support to the ISL1208 driver. > This patch drops the non-dm API as no board was using it anyway. > Also add it to Kconfig. > > Signed-off-by: Klaus Goger

[U-Boot] [PULL] Please pull u-boot-rockchip

2018-03-13 Thread Dr. Philipp Tomsich
Tom, Please pull the following changes (rebased from what was previously our next-branch) from u-boot-rockchip/master. The respective run on TravisCI is https://travis-ci.org/ptomsich/u-boot-rockchip/builds/352948410. Thanks, Philipp. The following changes since commit

Re: [U-Boot] [PATCH v2] rockchip: i2c: enable new I2C controller for rk3066 and rk3188

2018-02-26 Thread Dr. Philipp Tomsich
Alexander, Sorry for being a bother. See below for two comments. Cheers, Phil. > On 26 Feb 2018, at 18:42, Alexander Kochetkov wrote: > > rk3066 and rk3188 has two I2C controller implementations. > Current I2C driver wan't work with legacy implementation. > Switching

Re: [U-Boot] [PATCH v4 08/12] doc: TEE: Add documentation describing TEE in u-boot

2018-02-26 Thread Dr. Philipp Tomsich
> On 26 Feb 2018, at 16:26, Andrew F. Davis <a...@ti.com> wrote: > > On 02/26/2018 09:06 AM, Bryan O'Donoghue wrote: >> >> >> On 26/02/18 14:56, Dr. Philipp Tomsich wrote: >>> Now, I am confused. >> >> Fair enough. >> >> In m

Re: [U-Boot] [PATCH v4 08/12] doc: TEE: Add documentation describing TEE in u-boot

2018-02-26 Thread Dr. Philipp Tomsich
Bryan, > On 26 Feb 2018, at 15:39, Bryan O'Donoghue <bryan.odonog...@linaro.org> wrote: > > > > On 26/02/18 13:53, Dr. Philipp Tomsich wrote: >>> + To identify this type of image to u-boot you should use mkimage like >>> this: >>> + >>&g

Re: [U-Boot] [PATCH v4 08/12] doc: TEE: Add documentation describing TEE in u-boot

2018-02-26 Thread Dr. Philipp Tomsich
> On 26 Feb 2018, at 13:36, Bryan O'Donoghue wrote: > > This patch adds a brief description of TEE in u-boot. > > It gives a basic introduction, description of image generation with mkimage > plus the various ways u-boot can install or chainload a TEE. > > Methods

[U-Boot] Moving the rk_board_late_init() hook to a device-model based implementation.

2018-02-26 Thread Dr. Philipp Tomsich
Simon & Kever, We have the rk_board_late_init() hook for the Rockchip boards and I’d like to convert these to some sort of device-model based implementation. Here’s what I’d propose as a minimal implementation: 1. Introduce a new UCLASS_BOARD 2. Trigger on the top-level ‘compatible’

Re: [U-Boot] [PATCH] rockchip: clk: rk3188: update dpll settings to make EMAC work

2018-02-26 Thread Dr. Philipp Tomsich
Kever, please review. Thanks, Philipp. > On 26 Feb 2018, at 12:27, Alexander Kochetkov wrote: > > The patch set dpll settings for 300MHz to values used by binary > blob[1]. With new values dpll still generate 300MHz clock, but > EMAC work. Probably with new values dpll

Re: [U-Boot] [PATCH] NET: designware: fix clock enable

2018-02-26 Thread Dr. Philipp Tomsich
> On 6 Feb 2018, at 15:12, Eugeniy Paltsev wrote: > > After commit ba1f966725223 "net: designware: add clock support" > we got NET broken on axs101 and axs103 platforms. > > Some clock don't support gating so their clock drivers don't > implement .enable/.disable

Re: [U-Boot] [PATCH v2 1/2] core: add uclass_get_device_by_phandle_id() api

2018-02-26 Thread Dr. Philipp Tomsich
Kever, > On 26 Feb 2018, at 04:07, Kever Yang wrote: > > Hi Simon, > > > On 02/25/2018 11:54 PM, Simon Glass wrote: >> Hi Kever, >> >> On 23 February 2018 at 19:08, Kever Yang wrote: >>> Hi Simon, >>> >>> >>> On 02/12/2018 10:35 PM,

Re: [U-Boot] [PATCH] rockchip: i2c: enable I2C inside GRF for rk3066 and rk3188

2018-02-26 Thread Dr . Philipp Tomsich
Simon, please take a look and advise whether you want this as a reset-driver and have us adding auto-processing of resets to the initial bind/probe/init cycle. Thanks, Philipp. > On 26 Feb 2018, at 10:43, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: &g

Re: [U-Boot] [PATCH] rockchip: i2c: enable I2C inside GRF for rk3066 and rk3188

2018-02-26 Thread Dr. Philipp Tomsich
Simon, please take a look and advise whether you want this as a reset-driver and have us adding auto-processing of resets to the initial bind/probe/init cycle. Thanks, Philipp. > On 26 Feb 2018, at 10:43, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: &g

Re: [U-Boot] [PATCH] rockchip: i2c: enable I2C inside GRF for rk3066 and rk3188

2018-02-26 Thread Dr. Philipp Tomsich
Alexander, > On 26 Feb 2018, at 10:25, Alexander Kochetkov wrote: > > Hello, Philipp! > >> >> What exactly are you trying to configure here? >> >> Do you need to bring these out of reset, is this some IO config or >> are these clock gates? Note that if it’s any of

Re: [U-Boot] [PATCH v2 1/2] rockchip: rk3288: Add TPL_LDSCRIPT

2018-02-26 Thread Dr. Philipp Tomsich
Kever, Cleaning this up will be great. Once ready, we can merge this onto next … Regards, Philipp. > On 26 Feb 2018, at 07:26, Kever Yang wrote: > > > I prefer to share the TPL script between all Rockchip SoCs, > > and put this at arch/arm/mach-rockchip/. > > I

Re: [U-Boot] [PATCH] core: do not fail in device_probe() when clk set default fail

2018-02-25 Thread Dr. Philipp Tomsich
> On 25 Feb 2018, at 11:24, Kever Yang wrote: > > Assigned clocks are widely used in kernel, but not in U-Boot yet, > many U-Boot clock driver do not have the API while dts port from kernel > have "assigned-clocks" node. > > Just give a warning now instead of a

[U-Boot] [PULL] Please pull u-boot-rockchip/master

2018-02-25 Thread Dr. Philipp Tomsich
Tom, we have additional fixes ready for you: * the TPL-build process for the Vyasa board was fixed by Jagan (by providing the correct TEXT_BASE) * a regression on Ethernet for the RK3399 and RK3368 has been resolved by adding support for its clocks * a regression on PMIC

Re: [U-Boot] [PATCH 0/5] rockchip: video: migrate RK3399 w/ HDMI to livetree

2018-02-23 Thread Dr. Philipp Tomsich
Tom et al., I’d like to see this bug fix included in 2018.03, but don’t want to take the decision on my own: - some of this should have come via Anatolij’s tree - if touches ofnode.h/c and also needs a change by Kever that Simon reviewed (and noted that test cases should also

Re: [U-Boot] [PATCH] rockchip: i2c: enable I2C inside GRF for rk3066 and rk3188

2018-02-23 Thread Dr. Philipp Tomsich
> On 20 Feb 2018, at 09:43, Alexander Kochetkov wrote: > > In order to make I2C work on rk3066 and rk3188 boards GFR > must be updated. The commit message does not really tell me what the change is… …see below for a couple questions. > > Signed-off-by: Alexander

Re: [U-Boot] [PATCH v2 0/9] rockchip: rk3288-vyasa: dts fixes/additions

2018-02-23 Thread Dr. Philipp Tomsich
> On 23 Feb 2018, at 16:29, Jagan Teki <jagannadh.t...@gmail.com> wrote: > > > > On 23-Feb-2018 8:53 PM, "Dr. Philipp Tomsich" > <philipp.toms...@theobroma-systems.com > <mailto:philipp.toms...@theobroma-systems.com>> wrote: >

Re: [U-Boot] [PATCH v2 0/9] rockchip: rk3288-vyasa: dts fixes/additions

2018-02-23 Thread Dr. Philipp Tomsich
> On 23 Feb 2018, at 16:17, Jagan Teki wrote: > > Philipp, > > On Wed, Feb 14, 2018 at 9:26 PM, Jagan Teki > wrote: >> Series add new dts nodes like gmac, usb, io_domains and fixed existing >> regulator,

Re: [U-Boot] [U-Boot, v4, 07/11] spl: add support to booting with OP-TEE

2018-02-21 Thread Dr. Philipp Tomsich
Bryan, > On 21 Feb 2018, at 04:27, Bryan O'Donoghue <bryan.odonog...@linaro.org> wrote: > > On 19/02/18 15:44, Tom Rini wrote: >> On Fri, Feb 02, 2018 at 04:56:57PM +0100, Dr. Philipp Tomsich wrote: >>> Bryan, >>> >>>> On 2 Feb 2018, at

Re: [U-Boot] [PATCH] rockchip: add text_offset to kernel_addr_r on aarch64 platforms

2018-02-19 Thread Dr. Philipp Tomsich
> On 19 Feb 2018, at 08:02, Klaus Goger > wrote: > > Booting a aarch64 Linux kernel requires the image to be placed > text_offset bytes from a 2MB aligned address. > See https://www.kernel.org/doc/Documentation/arm64/booting.txt > > booti_setup() takes care

Re: [U-Boot] rk3288: broken boot

2018-02-14 Thread Dr. Philipp Tomsich
> On 14 Feb 2018, at 11:47, Jagan Teki <jagannadh.t...@gmail.com> wrote: > > On Wed, Feb 14, 2018 at 5:38 AM, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com > <mailto:philipp.toms...@theobroma-systems.com>> wrote: >> Jagan, >> >>

Re: [U-Boot] rk3288: broken boot

2018-02-13 Thread Dr. Philipp Tomsich
Jagan, > On 13 Feb 2018, at 13:20, Jagan Teki <jagannadh.t...@gmail.com> wrote: > > On Tue, Feb 13, 2018 at 5:29 PM, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: >> I verified the build for evb-rk3288_defconfig and everything looks f

[U-Boot] [PULL] Please pull from u-boot-rockchip/master

2018-02-13 Thread Dr. Philipp Tomsich
Tom, I have one fix and one clean-up ready for you to pull. The travis-run for this can be found at https://travis-ci.org/ptomsich/u-boot-rockchip/builds/340911706 Thanks, Philipp. The following changes since commit ebdb098c67c8fa1e9eb3d4e2f6a6a380fc222188: Prepare v2018.03-rc2 (2018-02-12

Re: [U-Boot] rk3288: broken boot

2018-02-13 Thread Dr. Philipp Tomsich
30: e59ff014ldr pc, [pc, #20] ; 0x4c 34: e59ff014ldr pc, [pc, #20] ; 0x50 38: e59ff014ldr pc, [pc, #20] ; 0x54 3c: e59ff014ldr pc, [pc, #20] ; 0x58 > On 13 Feb 2018, at 12:15, Dr. Philipp Tomsich >

Re: [U-Boot] About convert to LIVE DT

2018-02-13 Thread Dr. Philipp Tomsich
Kever, > On 13 Feb 2018, at 09:04, Kever Yang wrote: > > Simon, > > > On 02/12/2018 10:35 PM, Simon Glass wrote: >> Hi Kever, >> >> On 4 February 2018 at 18:00, Kever Yang wrote: >>> >>> On 02/04/2018 09:40 PM, Simon Glass wrote:

Re: [U-Boot] rk3288: broken boot

2018-02-13 Thread Dr. Philipp Tomsich
Jagan, The boot0-header should insert the additional 4 bytes needed… the resulting input format to mkimage is thus compatible with how the ddr.bin images by Rockchip where originally formatted (i.e. prepadded). See arch/arm/include/asm/arch-rockchip/boot0.h for the insertion of these additional

Re: [U-Boot] [RESENT PATCH 1/2] core: add uclass_get_device_by_phandle_id() api

2018-02-08 Thread Dr. Philipp Tomsich
> On 8 Feb 2018, at 14:13, Kever Yang wrote: > > Add api for who can not get phandle from a device property. > > Signed-off-by: Kever Yang Reviewed-by: Philipp Tomsich See below for comments. >

Re: [U-Boot] [PATCH] rockchip: pwm: convert to use live dt

2018-02-08 Thread Dr. Philipp Tomsich
> On 8 Feb 2018, at 14:15, Kever Yang wrote: > > use live dt api to get base addr > > Signed-off-by: Kever Yang Acked-by: Philipp Tomsich Reviewed-by: Philipp Tomsich

Re: [U-Boot] [PATCH] spl: fit: move fdt_record_loadable out of ARCH_FIXUP_FDT_MEMORY guard

2018-02-06 Thread Dr. Philipp Tomsich
Tom, Do you plan to apply this or should I include it into my next pull-request? Thanks, Philipp. > On 2 Feb 2018, at 16:00, Michal Simek wrote: > > On 2.2.2018 12:01, Philipp Tomsich wrote: >> The fdt_record_loadable()-function was wedged between other functions >>

Re: [U-Boot] [U-Boot, v4, 07/11] spl: add support to booting with OP-TEE

2018-02-02 Thread Dr. Philipp Tomsich
Bryan, > On 2 Feb 2018, at 16:37, Bryan O'Donoghue <bryan.odonog...@linaro.org> wrote: > > > > On 02/02/18 15:02, Dr. Philipp Tomsich wrote: >> Where do we stand on this: can we reuse IH_TYPE_TEE, will be use >> IH_TYPE_OPTEE or will there be a new IH_TYPE_OP

Re: [U-Boot] [U-Boot, v4, 07/11] spl: add support to booting with OP-TEE

2018-02-02 Thread Dr. Philipp Tomsich
> On 25 Jan 2018, at 11:09, Bryan O'Donoghue wrote: > > On 18/01/18 11:21, Bryan O'Donoghue wrote: >> On 18/01/18 01:31, Kever Yang wrote: >>> I don't think we can reuse IH_TYPE_TEE, it use a optee.img type create by >>> mkimage and it seem use more then one cpu. >>

Re: [U-Boot] [PATCH 06/15] spl: fit: implement recording of loadables into /fit-images

2018-02-02 Thread Dr. Philipp Tomsich
> On 1 Feb 2018, at 08:51, Michal Simek <mon...@monstr.eu> wrote: > > On 18.1.2018 14:17, Dr. Philipp Tomsich wrote: >> Michal, >> >>> On 18 Jan 2018, at 13:56, Michal Simek <mon...@monstr.eu> wrote: >>> >>> Hi Phili

Re: [U-Boot] [PATCH 1/1] rockchip: gpio: remove dead code

2018-01-30 Thread Dr. Philipp Tomsich
> On 31 Jan 2018, at 00:45, Heinrich Schuchardt wrote: > > In the following statements > if (a) return a; if (a) return c; > the second return can never be executed. > > Identified by cppcheck. > > Signed-off-by: Heinrich Schuchardt Acked-by: Philipp

Re: [U-Boot] [U-Boot,v2,4/5] clk: implement clk_set_defaults()

2018-01-28 Thread Dr. Philipp Tomsich
> On 28 Jan 2018, at 18:21, Michael Nazzareno Trimarchi > <mich...@amarulasolutions.com> wrote: > > Hi > > > > On 28 Jan. 2018 6:15 pm, "Dr. Philipp Tomsich" > <philipp.toms...@theobroma-systems.com > <mailto:philipp.toms...@theobroma-

Re: [U-Boot] [U-Boot,v2,4/5] clk: implement clk_set_defaults()

2018-01-28 Thread Dr. Philipp Tomsich
Michael, > On 28 Jan 2018, at 17:54, Michael Nazzareno Trimarchi > wrote: > > Hi > > > > On 28 Jan. 2018 5:50 pm, "Philipp Tomsich" > > wrote: > > Linux uses the properties

[U-Boot] [PULL] Please pull u-boot-rockchip

2018-01-28 Thread Dr. Philipp Tomsich
Tom, Here’s the changes to the rockchip tree for this iteration (and I expect us to generate a few bug-fixes in the stabilisation phase), just in time for rc1. The key change in in this merge window is improved support for the GMAC across the various Rockchip SOCs and moving the clock-selection

Re: [U-Boot] [PATCH 2/4] usb: gadget: dwc2: Fix warning over 32bit vs 64bit targets

2018-01-27 Thread Dr. Philipp Tomsich
> On 27 Jan 2018, at 20:56, Tom Rini wrote: > > On Sat, Jan 27, 2018 at 08:52:43PM +0100, Marek Vasut wrote: >> On 01/27/2018 08:48 PM, Tom Rini wrote: >>> When we have a driver that is used on both 32bit and 64bit targets and >>> we are talking about address space we cannot

Re: [U-Boot] [PATCH] spl: add option to disable SPL banner output

2018-01-25 Thread Dr. Philipp Tomsich
> On 25 Jan 2018, at 18:37, Lukasz Majewski wrote: > > From: Anatolij Gustschin > > Selecting this option will reduce SPL boot time by approx. 6 ms > (e. g. with 70 bytes long banner string at 115200 baud). > > Signed-off-by: Anatolij Gustschin >

Re: [U-Boot] [PATCH] spl: use different BOARD_INIT MACRO for spl and tpl

2018-01-20 Thread Dr. Philipp Tomsich
> On 20 Jan 2018, at 11:00, Kever Yang wrote: > > SPL and TPL may not always need spl_board_init() at the same time. > > Signed-off-by: Kever Yang Reviewed-by: Philipp Tomsich

Re: [U-Boot] [PATCH 06/15] spl: fit: implement recording of loadables into /fit-images

2018-01-18 Thread Dr. Philipp Tomsich
Michal, > On 18 Jan 2018, at 13:56, Michal Simek wrote: > > Hi Philipp, > > > 2017-09-13 21:29 GMT+02:00 Philipp Tomsich > : > If a FDT was loaded (e.g. to append it to U-Boot image), we store it's > address and record information for

Re: [U-Boot] [PATCH 0/9] Add new OPTEE bootm support to u-boot

2018-01-15 Thread Dr. Philipp Tomsich
> On 15 Jan 2018, at 13:03, Peng Fan <van.free...@gmail.com> wrote: > > On Mon, Jan 15, 2018 at 11:29:41AM +0100, Dr. Philipp Tomsich wrote: >> >>> On 15 Jan 2018, at 11:24, Dr. Philipp Tomsich >>> <philipp.toms...@theobroma-systems.com> wrote: &g

Re: [U-Boot] [PATCH 0/9] Add new OPTEE bootm support to u-boot

2018-01-15 Thread Dr. Philipp Tomsich
> On 15 Jan 2018, at 05:39, Kever Yang wrote: > > Hi Bryan, > > On 01/12/2018 10:52 PM, Bryan O'Donoghue wrote: >> This series adds a new OPTEE bootable image type to u-boot, which is >> directly bootable with the bootm command. >> >> There is already a TEE image

Re: [U-Boot] [PATCH 0/9] Add new OPTEE bootm support to u-boot

2018-01-15 Thread Dr. Philipp Tomsich
> On 15 Jan 2018, at 11:24, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > >> >> On 15 Jan 2018, at 05:39, Kever Yang <kever.y...@rock-chips.com> wrote: >> >> Hi Bryan, >> >> On 01/12/2018 10:52 PM, Bryan O'

Re: [U-Boot] [RESEND PATCH v2 2/4] clk: clk_fixed_rate: Fix style violation

2018-01-15 Thread Dr. Philipp Tomsich
Tom, > On 15 Jan 2018, at 11:06, Mario Six wrote: > > Fix a mis-indented function call in clk_fixed_rate.c A general question: do we want to have such gardening commits create an additional indirection in our history for people using git-blame frequently (e.g. I usually use

Re: [U-Boot] [PATCH 2/3] rockchip: Add RV1108 SPL support

2018-01-12 Thread Dr. Philipp Tomsich
See below for comments and requested changes. > On 12 Jan 2018, at 03:45, zhihuan he wrote: > > add rv1108 set for supporting spl. > > Signed-off-by: zhihuan he > --- > > arch/arm/mach-rockchip/Kconfig| 2 + >

Re: [U-Boot] [PATCH 3/3] rockchip: updata the style of reporting sdram cap

2018-01-12 Thread Dr. Philipp Tomsich
See below for requested changes. > On 12 Jan 2018, at 03:51, zhihuan he wrote: > > updata the style of reporting sdram capacity to uboot > > Signed-off-by: zhihuan he > --- > > arch/arm/mach-rockchip/rv1108/rv1108.c | 30 ++

Re: [U-Boot] [PATCH 1/3] rockchip: add rv1108 sdram driver

2018-01-12 Thread Dr. Philipp Tomsich
Please split this into multiple patches; e.g.: - the CRU changes are not SDRAM related - same goes for the GRF changes for GPIOs The DRAM driver header file is essentially the same that was added in sdram_rk322x.h with the key difference that 'dfitphywrdatalat’ is exposed in the

[U-Boot] [PULL] Please pull from u-boot-rockchip/master

2018-01-09 Thread Dr. Philipp Tomsich
Hi Tom, the below request is for some Rockchip-related changes that had missed the previous merge window and had been queued up in my next-branch. Travis-CI report at https://travis-ci.org/ptomsich/u-boot-rockchip/builds/326751040 Regards, Philipp. The following changes since commit

Re: [U-Boot] [U-Boot, v2, 16/18] clk: rockchip: Add rk322x gamc clock support

2018-01-08 Thread Dr. Philipp Tomsich
David, As discussed last week (off-list), I implemented infrastructure-support for the 'assigned-clocks', 'assigned-clock-parents' and 'assigned-clock-rates’ properties in the DTS … and validated on the RK3399. For my work-in-progress tree, see the ‘assigned-clocks-wip’ branch at:

[U-Boot] "Reset" values for clksel_con registers in clk_rk3399.c:rkclk_init()

2018-01-04 Thread Dr. Philipp Tomsich
Kever, I came across an odd question in clk_rk3399.c while implementing the reparenting (for assigned-clock-parents) that I today discussed with David Wu… looks like the following code is supposed to restore the reset values to 3 registers, but both the NDA-version of the TRM and the public

Re: [U-Boot] [PATCH 2/2] rockchip: firefly-rk3399: enable SPL_ATF_NO_PLATFORM_PARAM

2018-01-04 Thread Dr. Philipp Tomsich
Michal, > On 4 Jan 2018, at 08:56, Michal Simek wrote: > > Hi Kever, > > On 3.1.2018 03:34, Kever Yang wrote: >> Hi Philipp, >> >> >> On 01/03/2018 04:16 AM, Philipp Tomsich wrote: >>> The Rockchip-released ATF for the Firefly apparently (i.e. Kever >>> reported this) does

Re: [U-Boot] [U-Boot, v3, 07/11] spl: add support to booting with OP-TEE

2018-01-04 Thread Dr. Philipp Tomsich
> On 4 Jan 2018, at 04:51, Kever Yang wrote: > > > > On 01/03/2018 01:20 AM, Philipp Tomsich wrote: >> >> >> On Tue, 19 Dec 2017, Kever Yang wrote: >> >>> OP-TEE is an open source trusted OS, in armv7, its loading and >>> running are like this: >>> loading: >>> -

Re: [U-Boot] [PULL] Please pull u-boot-rockchip/master

2018-01-03 Thread Dr. Philipp Tomsich
Travis-CI result: https://travis-ci.org/ptomsich/u-boot-rockchip/builds/324578340 > On 3 Jan 2018, at 18:07, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > > Tom, > > As mentioned earlier, we had another round of last-minute stabilis

[U-Boot] [PULL] Please pull u-boot-rockchip/master

2018-01-03 Thread Dr. Philipp Tomsich
Tom, As mentioned earlier, we had another round of last-minute stabilisation fixes in-flight for the Rockchip tree. Here’s the (hopefully final) pull-request with these fixes for inclusion in 2018.1, which includes the following changes: (a) a config adjustment for the RK3368-uQ7 (Lion)

Re: [U-Boot] [PATCH 2/2] rockchip: firefly-rk3399: enable SPL_ATF_NO_PLATFORM_PARAM

2018-01-03 Thread Dr. Philipp Tomsich
Kever, > On 3 Jan 2018, at 03:34, Kever Yang wrote: > > Hi Philipp, > > On 01/03/2018 04:16 AM, Philipp Tomsich wrote: >> The Rockchip-released ATF for the Firefly apparently (i.e. Kever >> reported this) does not tolerate a FDT being passed as the platform >>

Re: [U-Boot] [PATCH V2] Convert CONFIG_USB_MUSB_OMAP2PLUS et al to Kconfig

2018-01-02 Thread Dr. Philipp Tomsich
> On 2 Jan 2018, at 15:35, Andreas Färber wrote: > > Am 02.01.2018 um 15:29 schrieb Andrew F. Davis: >> On 12/29/2017 10:10 AM, Adam Ford wrote: >>> On Fri, Dec 29, 2017 at 10:04 AM, Andreas Färber wrote: Hi, Am 29.12.2017 um 16:52 schrieb

[U-Boot] [PULL] Please pull u-boot-rockchip/master

2018-01-01 Thread Dr. Philipp Tomsich
Tom, We have two minor config-fixes for the upcoming release on the Rockchip side for you. Travis-CI (prior to the rebase): https://travis-ci.org/ptomsich/u-boot-rockchip/builds/322304850 I expect to send another pull-request later this week with two more stabilisation fixes (RK3368-uQ7

Re: [U-Boot] [PATCH] Convert CONFIG_TWL4030_USB et al to Kconfig

2017-12-29 Thread Dr. Philipp Tomsich
> On 29 Dec 2017, at 16:32, Adam Ford wrote: > > This converts the following to Kconfig: > CONFIG_TWL4030_USB > CONFIG_OMAP_USB_PHY > CONFIG_ROCKCHIP_USB2_PHY Please split this into three distinct commits, converting each of these PHY changes in a separate patch.

Re: [U-Boot] [PATCH v4 1/2] drivers/reset: support rockchip reset drivers

2017-12-19 Thread Dr. Philipp Tomsich
Kever, while this version has finally fixed the build errors for the rockchip-targets, it still causes major build failures for other target families: see https://travis-ci.org/ptomsich/u-boot-rockchip/builds/318128281 The new driver still appears to be built for the failing boards.

[U-Boot] [PULL] Please pull u-boot-rockchip/master

2017-12-18 Thread Dr. Philipp Tomsich
Tom, there’s a few stabilisation fixes and documentation/packaging improvements on u-boot-rockchip/master for you for merge/pull. A matching Travis CI run is at https://travis-ci.org/ptomsich/u-boot-rockchip/builds/318163689 Cheers, Philipp. The following changes since commit

Re: [U-Boot] [U-Boot,v2] rockchip: update boot0 hook

2017-12-17 Thread Dr. Philipp Tomsich
Kever, > On 15 Dec 2017, at 16:58, Philipp Tomsich > wrote: > >> Rockchip SoCs only need boot0 hook at SPL, and the U-Boot proper do not >> need it. >> >> The very beginning of U-Boot proper is different between armv7 and armv8: >> armv7 start with

Re: [U-Boot] [PATCH v3 1/2] drivers/reset: support rockchip reset drivers

2017-12-15 Thread Dr. Philipp Tomsich
Kever, > On 15 Dec 2017, at 10:02, Kever Yang wrote: > > From: Elaine Zhang > > Create driver to support all Rockchip SoCs soft reset. > Example of usage: > i2c driver: > ret = reset_get_by_name(dev, "i2c", _ctl); > if (ret) { >

Re: [U-Boot] [PATCH 2/2] disk: part: use common api to lookup part driver

2017-12-15 Thread Dr. Philipp Tomsich
> On 15 Dec 2017, at 03:34, Kever Yang <kever.y...@rock-chips.com> wrote: > > Hi Philipp, > > > On 12/14/2017 05:53 PM, Dr. Philipp Tomsich wrote: >> Kever, >> >>> On 14 Dec 2017, at 07:39, Kever Yang <kever.y...@rock-chips.com> wrote: >&

Re: [U-Boot] [PATCH] spl: atf: fix the plat_params

2017-12-15 Thread Dr. Philipp Tomsich
Kever, If you need/want to disable this, could you make this conditional on a new Kconfig option? That way we can disable it for those boards that still ship with an old ATF (note that passing NULL also broke the upstream ATF for quite a number of versions…). Alternatively, you could add a

Re: [U-Boot] rk3288: broken boot

2017-12-15 Thread Dr. Philipp Tomsich
Jagan, > On 15 Dec 2017, at 08:08, Jagan Teki wrote: > > Hi Philipp/Kever, > > Issue observed on rk3288 TPL supported board (vyasa), worked on > previous release v2017.11. What exactly is the issue (“broken boot” is not very specific)? > Tried to bisect but i

Re: [U-Boot] [PATCH 2/2] disk: part: use common api to lookup part driver

2017-12-14 Thread Dr. Philipp Tomsich
Kever, > On 14 Dec 2017, at 07:39, Kever Yang wrote: > > Do not need to scan disk every time when we get part info > by name. How does this interact with USB devices? I.e.: what happens, when you get the partition-info for a usb drive, then change the attached usb

[U-Boot] [PULL] Please pull u-boot-rockchip

2017-12-08 Thread Dr . Philipp Tomsich
Tom, this week has been quiet in the Rockchip tree: I only have a change to a snprintf format-string for restoring consistency with Linux. Travis-CI results are available at https://travis-ci.org/ptomsich/u-boot-rockchip/builds/313435652 Thanks, Philipp. The following changes since

Re: [U-Boot] [U-Boot, v2, 1/2] drivers/reset: support rockchip reset drivers

2017-12-08 Thread Dr. Philipp Tomsich
> On 8 Dec 2017, at 14:27, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > >> >> On 4 Dec 2017, at 02:04, Kever Yang <kever.y...@rock-chips.com >> <mailto:kever.y...@rock-chips.com>> wrote: >> >> Philipp, >

Re: [U-Boot] [U-Boot, v2, 1/2] drivers/reset: support rockchip reset drivers

2017-12-08 Thread Dr. Philipp Tomsich
> On 4 Dec 2017, at 02:04, Kever Yang <kever.y...@rock-chips.com> wrote: > > Philipp, > > > On 11/29/2017 03:49 AM, Dr. Philipp Tomsich wrote: >> Kever, >> >> This series causes build-breakage (even outside of the rockchip targets)... >> Se

Re: [U-Boot] [PATCH] rockchip: rk3399-puma: preserve leading zeros in serial#

2017-12-07 Thread Dr. Philipp Tomsich
> On 7 Dec 2017, at 16:20, Jakob Unterwurzacher > wrote: > > Linux preserves leading zeros in /proc/cpuinfo, so we > should as well. > > Otherwise we have the situation that > /sys/firmware/devicetree/base/serial-number > and /proc/cpuinfo disagree

Re: [U-Boot] [PATCH] arm: Make gcc 6.0 or later a hard requirement now.

2017-12-05 Thread Dr. Philipp Tomsich
> On 4 Dec 2017, at 20:02, Stephen Warren wrote: > > On 12/02/2017 06:12 PM, Tom Rini wrote: >> Move the warning to an error as we have been promising would happen in >> this release. > > Oh. This has broken my U-Boot build/test system. I guess it's entirely my > fault

Re: [U-Boot] [PULL] Please pull u-boot-rockchip/master

2017-12-01 Thread Dr. Philipp Tomsich
/rk3128_common.h create mode 100644 include/dt-bindings/clock/rk3128-cru.h > On 1 Dec 2017, at 22:47, Tom Rini <tr...@konsulko.com> wrote: > > On Fri, Dec 01, 2017 at 07:00:36PM +0100, Dr. Philipp Tomsich wrote: > >> Tom, >> >> Another set of changes on u-

[U-Boot] Should we reorganise arch/arm/dts into arch/arm/dts/?

2017-12-01 Thread Dr. Philipp Tomsich
Tom, As one of my colleagues noticed, the list of files in arch/arm/dts grows with every release. How about splitting this into subdirectories for each SOC vendor (e.g. arch/arm/dts//) to reduce the clutter? If this sounds like a good idea, let me know and I’ll start rearranging the

[U-Boot] [PULL] Please pull u-boot-rockchip/master

2017-12-01 Thread Dr. Philipp Tomsich
Tom, Another set of changes on u-boot-rockchip is ready for your tree. This includes support for the RK3128, documentation updates and convenience changes for some of our boards. Thanks, Philipp. The following changes since commit 9804d88630cdb22f5f0ace05ac05942928410fd9: Merge branch

Re: [U-Boot] [U-Boot, 1/3] rockchip: boot mode: parse adc channel from dts

2017-11-29 Thread Dr . Philipp Tomsich
[Getting Simon's email-address right, helps…] Simon, could you comment on this one from a general U-Boot architecture and DM-maintainer perspective? Thanks, Philipp. > On 29 Nov 2017, at 10:50, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com > <mailto:philipp.to

Re: [U-Boot] [U-Boot, 1/3] rockchip: boot mode: parse adc channel from dts

2017-11-29 Thread Dr. Philipp Tomsich
Simon, could you comment on this one from a general U-Boot architecture and DM-maintainer perspective? Thanks, Philipp. > On 29 Nov 2017, at 10:50, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > > >> On 29 Nov 2017, at 07:34, Andy Yan

Re: [U-Boot] [U-Boot, 1/3] rockchip: boot mode: parse adc channel from dts

2017-11-29 Thread Dr. Philipp Tomsich
> On 29 Nov 2017, at 07:34, Andy Yan wrote: > > Hi Philipp: > > > On 2017年11月28日 21:59, Philipp Tomsich wrote: >> +sjg >> >> On Tue, 28 Nov 2017, Andy Yan wrote: >> >>> Most the current rockchip based boards use adc channel >>> 1 detect the download key, but there

Re: [U-Boot] [U-Boot, v2, 1/2] drivers/reset: support rockchip reset drivers

2017-11-28 Thread Dr. Philipp Tomsich
Kever, This series causes build-breakage (even outside of the rockchip targets)... See https://travis-ci.org/ptomsich/u-boot-rockchip/builds/308522589 Please fix and resubmit. Also: did you test this using buildman or travis? Thanks, Philipp. > On 28 Nov 2017, at 11:06, Philipp Tomsich >

Re: [U-Boot] [PATCH v2 1/2] power: regulator: add driver for the FAN53555 family

2017-11-27 Thread Dr. Philipp Tomsich
> On 27 Nov 2017, at 04:07, Simon Glass <s...@chromium.org> wrote: > > Hi Philipp, > > On 26 November 2017 at 07:10, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: >> >>> On 26 Nov 2017, at 12:38, Simon Glass <s...@chromium

Re: [U-Boot] [PATCH 1/2] rockchip: rk3399-puma: add code to allow forcing a power-on reset

2017-11-27 Thread Dr. Philipp Tomsich
> On 27 Nov 2017, at 18:10, Simon Glass wrote: > > Hi Philipp, > > On 26 November 2017 at 16:22, Philipp Tomsich > wrote: >> The reset circuitry in the RK3399 only resets 'almost all logic' when >> a software reset is performed. To

Re: [U-Boot] [U-Boot, RESEND, 2/2] rockchip: clk: add device_bind_driver_to_node for reset driver

2017-11-27 Thread Dr. Philipp Tomsich
> On 27 Nov 2017, at 11:15, Kever Yang wrote: > > Philipp, > > > On 11/22/2017 06:55 AM, Philipp Tomsich wrote: >> >> >> On Fri, 3 Nov 2017, Kever Yang wrote: >> >>> From: Elaine Zhang >>> >>> all rockchip socs add

[U-Boot] [PULL] Please pull u-boot-rockchip/master

2017-11-26 Thread Dr. Philipp Tomsich
Tom, Please pull u-boot-rockchip/master. This finally merges the SPL-changes for improved ATF support that had been in the works since 2 merge-windows ago. Plus, there’s a few fixes to platform-support (e.g. pinctrl on the RK3399) and for some recently merged patches that had unexpected

Re: [U-Boot] [PATCH v2 1/2] power: regulator: add driver for the FAN53555 family

2017-11-26 Thread Dr. Philipp Tomsich
> On 26 Nov 2017, at 12:38, Simon Glass wrote: > > Hi Philipp, > > On 22 November 2017 at 14:13, Philipp Tomsich > wrote: >> This adds a driver for the FAN53555 family of regulators. >> >> While these devices support a 'normal' and

Re: [U-Boot] U-Boot proper(not SPL) relocate option

2017-11-26 Thread Dr. Philipp Tomsich
> On 26 Nov 2017, at 14:44, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > > >> On 26 Nov 2017, at 12:38, Simon Glass <s...@chromium.org> wrote: >> >> Hi Philipp, >> >> On 25 November 2017 at 16:31, Dr. Phi

Re: [U-Boot] U-Boot proper(not SPL) relocate option

2017-11-26 Thread Dr. Philipp Tomsich
> On 26 Nov 2017, at 12:38, Simon Glass <s...@chromium.org> wrote: > > Hi Philipp, > > On 25 November 2017 at 16:31, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com > <mailto:philipp.toms...@theobroma-systems.com>> wrote: >> Hi, >

Re: [U-Boot] sun50i blocking SPL changes

2017-11-25 Thread Dr. Philipp Tomsich
> On 26 Nov 2017, at 01:06, André Przywara <andre.przyw...@arm.com> wrote: > > On 25/11/17 23:35, Dr. Philipp Tomsich wrote: >> Jagan, >> >> I resolved this by introducing a new Kconfig that affects what functionality >> is included in spl_fit.c; howeve

Re: [U-Boot] sun50i blocking SPL changes

2017-11-25 Thread Dr. Philipp Tomsich
hilipp. > On 24 Nov 2017, at 21:42, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > >> >> On 24 Nov 2017, at 21:36, Jagan Teki <ja...@amarulasolutions.com> wrote: >> >> On Sat, Nov 25, 2017 at 1:17 AM, Dr. Philipp Tomsich >>

Re: [U-Boot] U-Boot proper(not SPL) relocate option

2017-11-25 Thread Dr. Philipp Tomsich
Hi, > On 25 Nov 2017, at 23:34, Simon Glass wrote: > > +Tom, Masahiro, Philipp > > Hi, > > On 22 November 2017 at 03:27, Wolfgang Denk wrote: >> Dear Kever Yang, >> >> In message you wrote: >>> >>> I can

Re: [U-Boot] sun50i blocking SPL changes

2017-11-24 Thread Dr. Philipp Tomsich
> On 24 Nov 2017, at 21:36, Jagan Teki <ja...@amarulasolutions.com> wrote: > > On Sat, Nov 25, 2017 at 1:17 AM, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: >> Jagan, Maxime & Tom, >> >> I have a couple of changes to spl_fit.

[U-Boot] sun50i blocking SPL changes

2017-11-24 Thread Dr. Philipp Tomsich
Jagan, Maxime & Tom, I have a couple of changes to spl_fit.c queued that we need to get merged to fix some issues for ATF support on Rockchip platforms. However, due to internal alignment before the ARMv8 vectors, this breaks the sun50i builds (all exceeding their SPL size by up to approx.

Re: [U-Boot] [U-Boot, 10/15] rockchip: dts: rk3399-puma: add /config/arm-trusted-firmware, reset-gpio property

2017-11-23 Thread Dr. Philipp Tomsich
> On 23 Nov 2017, at 15:51, Philipp Tomsich > wrote: > >> With the ATF capable of accessing the FDT passed to the next stage, >> we can specify configuration items for the ATF in the /config path. >> >> This adds the arm-trusted-firmware,reset-gpio that

Re: [U-Boot] [PATCH v3 1/3] usb: hub: identify the hub-device to usb_hub_reset_devices

2017-11-22 Thread Dr. Philipp Tomsich
> On 22 Nov 2017, at 17:23, Marek Vasut wrote: > > On 11/22/2017 05:15 PM, Philipp Tomsich wrote: >> When usb_hub_reset_devices is called, it should be passed both an >> indicator which hub it should operate on and what port number (local >> to that hub) should be reset. >> >>

Re: [U-Boot] [PATCH v2 1/3] usb: hub: identify the hub-device to usb_hub_reset_devices

2017-11-22 Thread Dr. Philipp Tomsich
> On 22 Nov 2017, at 16:59, Marek Vasut wrote: > > On 11/22/2017 04:57 PM, Philipp Tomsich wrote: >> When usb_hub_reset_devices is called, it should be passed both an >> indicator which hub it should operate on and what port number (local >> to that hub) should be reset. > > Why

[U-Boot] [PULL] Please pull from u-boot-rockchip/master

2017-11-22 Thread Dr. Philipp Tomsich
Tom, Please pull from u-boot-rockchip/master. The associated Travis run (prior to a final rebase) is at https://travis-ci.org/ptomsich/u-boot-rockchip/builds/305523168. Thanks, Philipp. The following changes since commit 16fa2eb95172e63820ee5f3d4052f3362a6de84e: ARM: dra7: Kconfig: Add

Re: [U-Boot] [U-Boot, v3, 3/3] rockchip: check download key before bootup

2017-11-21 Thread Dr. Philipp Tomsich
Andy, > On 21 Nov 2017, at 02:02, Andy Yan wrote: > > Hi Philipp: > > > On 2017年11月20日 22:51, Philipp Tomsich wrote: >> >> >> On Wed, 11 Oct 2017, Andy Yan wrote: >> >>> Enter download mode if the download key pressed. >>> >>> Signed-off-by: Andy Yan

Re: [U-Boot] [U-Boot, v3, 1/3] rockchip: make boot_mode related codes reused across all platforms

2017-11-21 Thread Dr. Philipp Tomsich
Andy, > On 21 Nov 2017, at 01:48, Andy Yan wrote: > > Hi Philipp: > > > On 2017年11月20日 22:50, Philipp Tomsich wrote: >> >> >> On Wed, 11 Oct 2017, Andy Yan wrote: >> >>> setup_boot_mode function use the same logic but different >>> mode register address across all

Re: [U-Boot] [U-Boot,V9,1/4] usb: rockchip: add the rockusb gadget

2017-11-20 Thread Dr. Philipp Tomsich
Kever & Eddie, > On 2 Oct 2017, at 12:51, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > > +Kever, +Eddie > > Kever & Eddie, > >> On 2 Oct 2017, at 12:41, Marek Vasut <ma...@denx.de> wrote: >> >> On 10/02/2

Re: [U-Boot] [PATCH 1/2] usb: xhci: implement FEAT_POWER hook for switching regulators for ports

2017-11-17 Thread Dr. Philipp Tomsich
> On 17 Nov 2017, at 14:19, Bin Meng <bmeng...@gmail.com> wrote: > > Hi Philipp, > > On Fri, Nov 17, 2017 at 5:43 PM, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: >> Bin, >> >> On 17 Nov 2017, at 10:27, Bin Me

<    1   2   3   4   5   >