Re: [PATCH 2/2] net: eth-phy: prevent undesired de-assertion of phy-reset on request

2022-03-01 Thread Joe Hershberger
cause undesired affects if reset timings are not properly > met. > > Configure the gpio with GPIOD_IS_OUT_ACTIVE so that reset is kept active > (reset asserted) to avoid this. > > Cc: Sean Anderson > Signed-off-by: Tim Harvey Acked-by: Joe Hershberger

Re: [PATCH 1/2] net: fec: prevent undesired de-assertion of phy-reset on request

2022-03-01 Thread Joe Hershberger
cause undesired affects if reset timings are not properly > met. > > Configure the gpio with GPIOD_IS_OUT_ACTIVE so that reset is kept active > (reset asserted) to avoid this. > > Cc: Sean Anderson > Signed-off-by: Tim Harvey Acked-by: Joe Hershberger

Re: [PATCH v2 1/2] env: allow environment to be amended from control dtb

2021-04-21 Thread Joe Hershberger
the DTB should no longer be applied, one simply needs to delete the > fdt_env_path variable; that can even be done automatically by > including a > > fdt_env_path = ""; > > property in the DTB node. > > Reviewed-by: Simon Glass > Signed-off-by: Rasmus Villemoes Cool addition. Acked-by: Joe Hershberger

Re: [PATCH v2 2/2] sandbox: add test of CONFIG_ENV_IMPORT_FDT

2021-04-21 Thread Joe Hershberger
On Wed, Apr 21, 2021 at 4:07 AM Rasmus Villemoes wrote: > > Check that a variable defined in /config/environment is found in the > run-time environment, and that clearing fdt_env_path from within that > node works. > > Reviewed-by: Simon Glass > Signed-off-by: Rasmus Vill

Re: [PATCH] MAINTAINERS: Add maintainer to network subsystem

2021-02-01 Thread Joe Hershberger
TAINERS > +++ b/MAINTAINERS > @@ -893,6 +893,7 @@ F: arch/nds32/ > > NETWORK > M: Joe Hershberger > +M: Ramon Fried > S: Maintained > T: git https://gitlab.denx.de/u-boot/custodians/u-boot-net.git > F: drivers/net/ > -- > 2.29.2 > Acked-by: Joe Hershberger

Re: [PATCH] net: sun8i-emac: Allow all RGMII PHY modes

2021-01-14 Thread Joe Hershberger
On Wed, Jan 13, 2021 at 4:43 PM André Przywara wrote: > > On 30/11/2020 17:23, Heinrich Schuchardt wrote: > > Hi Joe, > > > On 11/16/20 10:46 AM, Andre Przywara wrote: > >> So far all GBit users of the sun8i-emac driver were using the "rgmii" > >> PHY mode, even though this turns out to be mostly

Re: [PATCH 1/1] env: typo enougth

2020-10-30 Thread Joe Hershberger
On Fri, Oct 30, 2020 at 12:11 AM Heinrich Schuchardt wrote: > > %s/enougth/enough/ > > Signed-off-by: Heinrich Schuchardt Acked-by: Joe Hershberger

Re: [PATCH V2] net: smc911x: Automatically Update ethaddr with MAC

2020-09-28 Thread Joe Hershberger
et. > > Signed-off-by: Adam Ford Acked-by: Joe Hershberger

Re: [RFC PATCH] tools: env: Add an option to have an empty default environment

2020-08-14 Thread Joe Hershberger
particular target. Rather than > trying to have a set of defaults that work for every target add a config > option to make the default environment completely empty. > > Signed-off-by: Chris Packham Acked-by: Joe Hershberger

Re: [PULL] u-boot-sh/net

2020-07-27 Thread Joe Hershberger
On Mon, Jul 27, 2020 at 5:40 AM Marek Vasut wrote: > > More networking DM conversion (this is the last driver). > Any news on Joe ? Sorry, guys, I'm back home in Texas now and have had a lot going on keeping me swamped. I aim to get caught up soon. Any idea how accurate my patchwork queue is?

Re: [PATCH 02/13] net: rtl8139: Rework eeprom_delay() macro

2020-04-16 Thread Joe Hershberger
> > Signed-off-by: Marek Vasut > Cc: Joe Hershberger Acked-by: Joe Hershberger

Re: [PATCH 01/13] net: rtl8139: Register macro cleanup

2020-04-16 Thread Joe Hershberger
ge. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger Acked-by: Joe Hershberger

Re: [PATCH 01/12] net: ks8851: Replace malloc()+memset() with calloc()

2020-04-16 Thread Joe Hershberger
gt; return code. > > Signed-off-by: Marek Vasut > Cc: Eugen Hristev > Cc: Joe Hershberger Acked-by: Joe Hershberger

Re: zynq_z_turn_defconfig: broken networking

2020-04-07 Thread Joe Hershberger
.c ? > > >>> The Ethernet PHY doesn't work in Linux too with the similar error > > >>> message. > > >> > > >> Did you validate any golden images that phy is fine? > > > > > > Yes, I did. There was microsd card supplied with the b

Re: [PATCH] net: phy: micrel: ksz8061 implement errata 80000688A fix

2020-03-30 Thread Joe Hershberger
Signed-off-by: Bryan O'Donoghue Acked-by: Joe Hershberger

Re: [PATCH] net: macb: Fix incorrect write function name when MACB_ZYNQ is enabled.

2020-03-30 Thread Joe Hershberger
B_MCF’? > writel((value), (port)->regs + MACB_##reg) > ^ > > It has been caused by changing macros name by commit below. > > Fixes: 6c636514d499 ("net: macb: sync header definitions as taken from Linux") > Signed-off-by: Michal Simek Acked-by: Joe Hershberger

Re: [PATCH] [RFC] net: smc911x: Drop the standalone EEPROM example

2020-03-17 Thread Joe Hershberger
Hi Tom, On Tue, Mar 17, 2020 at 7:59 PM Tom Rini wrote: > > On Tue, Mar 17, 2020 at 07:54:51PM -0500, Joe Hershberger wrote: > > On Tue, Mar 17, 2020 at 1:55 PM Tom Rini wrote: > > > > > > On Tue, Mar 17, 2020 at 07:53:58PM +0100, Marek Vasut wrote: > > &g

Re: [PATCH 02/14] drivers: net: ldpaa: add support for probing based on the DTS

2020-03-17 Thread Joe Hershberger
On Thu, Mar 12, 2020 at 11:26 AM Ioana Ciornei wrote: > > When CONFIG_DM_ETH is enabled DPAA2 network interfaces will now probe > based on DTS nodes with the "fsl,qoriq-mc-dpmac" compatible. > In this case, transform the ldpaa_eth driver into a UCLASS_ETH driver > and reuse the

Re: [PATCH 01/14] drivers: net: add Layerscape mEMAC MDIO driver

2020-03-17 Thread Joe Hershberger
On Thu, Mar 12, 2020 at 11:24 AM Ioana Ciornei wrote: > > Add a driver for the MDIO interface integrated in the mEMAC (Multi-rate > Ethernet Media Access Controller) and the Fman 10G Ethernet MACs. > > Signed-off-by: Ioana Ciornei > --- > drivers/net/Kconfig | 7 ++ >

Re: [PATCH] [RFC] net: smc911x: Drop the standalone EEPROM example

2020-03-17 Thread Joe Hershberger
to DM real hard. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Tom Rini Acked-by: Joe Hershberger

Re: [PATCH 12/12] net: smc911x: Add DM support

2020-03-17 Thread Joe Hershberger
On Sun, Mar 15, 2020 at 12:01 PM Marek Vasut wrote: > > Add support for U-Boot DM and DT probing. Furthermore, build the > SMC911x standalone EEPROM example only for the non-DM case, as it > is not converted yet. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger

Re: [PATCH 11/12] net: smc911x: Split non-DM specific bits from common code

2020-03-17 Thread Joe Hershberger
On Sun, Mar 15, 2020 at 12:01 PM Marek Vasut wrote: > > Split network handling functions into non-DM specific parts and > common code in preparation for conversion to DM. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Masahiro Yamada Acked-by: Joe Hershberger

Re: [PATCH 10/12] net: smc911x: Clean up the status handling in smc911x_recv()

2020-03-17 Thread Joe Hershberger
On Sun, Mar 15, 2020 at 12:01 PM Marek Vasut wrote: > > Invest the status handling logic in smc911x_recv(), to make the > function easier to read, no functional change. Invest -> Invert > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Masahiro Yamada > ---

Re: [PATCH 09/12] net: smc911x: Pass around driver private data

2020-03-16 Thread Joe Hershberger
On Sun, Mar 15, 2020 at 12:01 PM Marek Vasut wrote: > > Introduce a private data structure for this driver with embedded > struct eth_device and pass it around. This prepares the driver to > work with both DM and non-DM systems. > > Signed-off-by: Marek Vasut > Cc:

Re: [PATCH 08/12] net: smc911x: Convert IO accessors to {read, write}{w, l}()

2020-03-16 Thread Joe Hershberger
On Sun, Mar 15, 2020 at 12:00 PM Marek Vasut wrote: > > Convert the IO accessors to standard ones instead of using volatile > void pointers, as those do not cover all the bus access details. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Masahiro Yamada Acked-by: Joe Hershberger

Re: [PATCH 07/12] net: smc911x: Drop weak alias from 32bit accessors

2020-03-16 Thread Joe Hershberger
n decide better. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Masahiro Yamada Acked-by: Joe Hershberger

Re: [PATCH 06/12] net: smc911x: Inline all functions from header file

2020-03-16 Thread Joe Hershberger
M example, however that one has to be rewritten > anyway, roughly such that the SMC911x driver would expose DM EEPROM > interface and the standalone example would use that. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Masahiro Yamada Acked-by: Joe Hershberger

Re: [PATCH 05/12] net: smc911x: Fix potential memleak() in init fail path

2020-03-16 Thread Joe Hershberger
gned-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Masahiro Yamada Acked-by: Joe Hershberger

Re: [PATCH 02/12] net: smc911x: Replace malloc()+memset() with calloc()

2020-03-16 Thread Joe Hershberger
On Sun, Mar 15, 2020 at 12:00 PM Marek Vasut wrote: > > Replace combination of malloc()+memset() with calloc() as the behavior > is exactly the same and the amount of code is reduced. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Masahiro Yamada Acked-by: Joe Hershberger

Re: [PATCH 01/12] net: smc911x: Remove pkt_data_{push,pull}

2020-03-16 Thread Joe Hershberger
On Sun, Mar 15, 2020 at 11:59 AM Marek Vasut wrote: > > These functions are never used and are likely a pre-DM remnant > from times long past, just remove them. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Masahiro Yamada Acked-by: Joe Hershberger

Re: [PATCH] net: eth-uclass: Do not return error when no MAC is found

2020-03-11 Thread Joe Hershberger
On Tue, Mar 10, 2020 at 1:34 PM Fabio Estevam wrote: > > Hi Joe, > > On Tue, Mar 10, 2020 at 2:45 PM Joe Hershberger > wrote: > > > I tried to apply this but it breaks the unit tests. I guess you didn't > > try "ut dm" in sandbox? > > > > ht

Re: [PATCH v2 00/12] phy: atheros: dt bindings and cleanup

2020-03-10 Thread Joe Hershberger
Hi Michael, On Tue, Jan 7, 2020 at 5:07 AM Michael Walle wrote: > > Hi all, > > Am 2019-12-05 23:57, schrieb Michael Walle: > > [RESEND because I've forgot to add the mailinglist. Sorry!] > > > > This patch series superseeds the following two: > > From Vladimir Oltean > >

Re: [PATCH] net: eth-uclass: Do not return error when no MAC is found

2020-03-10 Thread Joe Hershberger
Hi Fabio, On Thu, Jan 9, 2020 at 12:29 PM Fabio Estevam wrote: > > On some i.MX8QXP MEK boards with no MAC address stored, the following > hang is seen: > > Error: ethernet@5b04 address not set. > > (Board hangs) > > One way to avoid this issue is to select CONFIG_NET_RANDOM_ETHADDR, so >

Re: [PATCH] net: phy: dp83867: Add SGMII mode type switching

2020-03-05 Thread Joe Hershberger
n done in mainline Linux by > commit a2111c460c0c ("net: phy: dp83867: Add documentation for SGMII mode > type") > and by commit 507ddd5c0d47 ("net: phy: dp83867: Add SGMII mode type > switching") > > Signed-off-by: Michal Simek Acked-by: Joe Hershberger

Re: [PATCH v2] net: phy: add XFI, USXGMII types to is_10g_interface() helper

2020-03-05 Thread Joe Hershberger
Marginean Acked-by: Joe Hershberger

Re: [PATCH] net: eth-uclass: Do not return error when no MAC is found

2020-03-05 Thread Joe Hershberger
ot correct: > > Error: ethernet@5b04 address not set. > > Error: ethernet@5b04 address 00:00:00:00:00:00 illegal value > eth0: ethernet@5b04 > Error: ethernet@5b04 address 00:00:00:00:00:00 illegal value > > Signed-off-by: Fabio Estevam Acked-by: Joe Hershberger

Re: [PATCH] net: phy: Fix overlong PHY timeout

2020-03-05 Thread Joe Hershberger
easing from the typical 4 seconds to over three minutes. > > Adjust the timeout counter evaluation by that factor of 50 to bring the > timeout back to the intended value. > > Signed-off-by: Andre Przywara Acked-by: Joe Hershberger

Re: [PATCH] doc: net: Rewrite network driver documentation

2020-03-05 Thread Joe Hershberger
original text at the end, to help > understanding old drivers. Add some hints on how to port drivers over. > > This also uses the opportunity to reformat the document in reST, on the > way moving it into doc/driver-model and adding it into the structure > there. > > Signed-off-by: Andr

Re: [PATCH 1/2] drivers: net: phy: aquantia: drop XGMII as a valid system interface proto

2020-03-05 Thread Joe Hershberger
hiculita > Signed-off-by: Alex Marginean Acked-by: Joe Hershberger

Re: [PATCH 2/2] drivers: net: phy: aquantia: make it less verbose

2020-03-05 Thread Joe Hershberger
On Wed, Dec 4, 2019 at 7:42 AM Alex Marginean wrote: > > The driver now unconditionally prints some information that's not > universally useful. Replace printf with debug. > > Signed-off-by: Alex Marginean Acked-by: Joe Hershberger

Re: [PATCH v2 12/12] phy: atheros: consolidate {ar8031|ar8035}_config()

2020-03-05 Thread Joe Hershberger
On Thu, Dec 5, 2019 at 5:05 PM Michael Walle wrote: > > The two functions are now exactly the same, remove one of them. > > Signed-off-by: Michael Walle Acked-by: Joe Hershberger

Re: [PATCH v2 11/12] phy: atheros: ar8035: remove static clock config

2020-03-05 Thread Joe Hershberger
breaks your board it probably > depends on the clock output of your Atheros AR8035 PHY. Please have a > look at doc/device-tree-bindings/net/phy/atheros.txt. You need to set > "clk-out-frequency = <12500>" because that value was the hardcoded > value until this commit. &g

Re: [PATCH v2 10/12] phy: atheros: add device tree bindings and config

2020-03-05 Thread Joe Hershberger
s commit adds support to > switch the internal LDO to 1.8V. > > Signed-off-by: Michael Walle Acked-by: Joe Hershberger

Re: [PATCH v2 09/12] phy: atheros: move delay config to common function

2020-03-05 Thread Joe Hershberger
On Thu, Dec 5, 2019 at 5:03 PM Michael Walle wrote: > > Signed-off-by: Michael Walle Acked-by: Joe Hershberger

Re: [PATCH v2 08/12] phy: atheros: introduce debug read and write functions

2020-03-05 Thread Joe Hershberger
On Thu, Dec 5, 2019 at 5:00 PM Michael Walle wrote: > > Provide functions to read and write the Atheros debug registers. > > Signed-off-by: Michael Walle Acked-by: Joe Hershberger

Re: [PATCH v2 06/12] phy: atheros: fix AR8021 PHY ID mask

2020-03-05 Thread Joe Hershberger
On Thu, Dec 5, 2019 at 5:02 PM Michael Walle wrote: > > The upper bits are all the OUI. > > Signed-off-by: Michael Walle Acked-by: Joe Hershberger

Re: [U-Boot] [PATCH] net: eth-uclass: Remove warning about ROM MAC address

2020-02-09 Thread Joe Hershberger
ren's and Fabio's point of view here and I'm > > > in favor of merging this patch or if preferred, change the printf() to > > > debug(). > > > > > > Reviewed-by: Frieder Schrempf > > > > Any feedback, please? Traditionally the env was the source of truth for the MAC, so using the ROM was a fall-back if the env didn't have one. But times change, I guess. I'll pull this into my next PR. Acked-by: Joe Hershberger

Re: [PATCH 1/1] net: tftp: use correct printf codes

2020-01-05 Thread Joe Hershberger
On Wed, Jan 1, 2020 at 4:16 PM Heinrich Schuchardt wrote: > > When printing unsigned numbers use %u. > > Signed-off-by: Heinrich Schuchardt Acked-by: Joe Hershberger

Re: [PATCH] drivers: net: bcm-sf2: pass -1 to phy_connect()

2019-12-20 Thread Joe Hershberger
. > > Signed-off-by: Alex Marginean > Cc: Jiandong Zheng Acked-by: Joe Hershberger

Re: [PATCH] net: dwc_eth_qos: Pass -1 to phy_connect() to scan for all PHYs

2019-12-18 Thread Joe Hershberger
On Wed, Dec 18, 2019 at 12:49 AM Marek Vasut wrote: > > PHY address 0 is a valid PHY address, to scan for all PHYs, pass -1 to > phy_connect(). Passing 0 used to work before be accident, but does no > longer. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > C

Re: [U-Boot] [PATCH] net/phy: Fix phy_connect() for phy addr 0

2019-12-18 Thread Joe Hershberger
On Tue, Dec 17, 2019 at 11:55 PM Marek Vasut wrote: > > On 12/18/19 3:06 AM, Joe Hershberger wrote: > > On Tue, Dec 17, 2019 at 1:04 PM Marek Vasut wrote: > >> > >> On 12/17/19 7:47 PM, Joe Hershberger wrote: > >>> On Tue, Dec 17, 2019 at 11:46 AM Marek

Re: [U-Boot] [PATCH] net/phy: Fix phy_connect() for phy addr 0

2019-12-17 Thread Joe Hershberger
On Tue, Dec 17, 2019 at 1:04 PM Marek Vasut wrote: > > On 12/17/19 7:47 PM, Joe Hershberger wrote: > > On Tue, Dec 17, 2019 at 11:46 AM Marek Vasut wrote: > >> > >> On 12/17/19 5:25 PM, Joe Hershberger wrote: > >>> Hi Marek, > >> > >&

Re: [U-Boot] [PATCH] net/phy: Fix phy_connect() for phy addr 0

2019-12-17 Thread Joe Hershberger
On Tue, Dec 17, 2019 at 11:46 AM Marek Vasut wrote: > > On 12/17/19 5:25 PM, Joe Hershberger wrote: > > Hi Marek, > > Hi Joe, > > > On Tue, Dec 17, 2019 at 1:39 AM Marek Vasut wrote: > >> > >> On 11/7/19 9:04 PM, Joe Hershberger wrote: > &g

Re: [U-Boot] [PATCH] net/phy: Fix phy_connect() for phy addr 0

2019-12-17 Thread Joe Hershberger
Hi Marek, On Tue, Dec 17, 2019 at 1:39 AM Marek Vasut wrote: > > On 11/7/19 9:04 PM, Joe Hershberger wrote: > > On Thu, Nov 7, 2019 at 1:16 PM Tom Rini wrote: > >> > >> On Tue, Nov 05, 2019 at 04:05:11AM +, Priyanka Jain wrote: > >> > >>> F

Re: [PATCH 1/1] common: remove duplicate typedef for uchar

2019-12-10 Thread Joe Hershberger
gt; > Fixes: 37db55b7e9db ("linux/types.h: fix typo unchar") > Signed-off-by: Heinrich Schuchardt Reviewed-by: Joe Hershberger

Re: Pull request: u-boot-net.git master

2019-12-09 Thread Joe Hershberger
Hi Tom, On Mon, Dec 9, 2019 at 4:49 PM Tom Rini wrote: > > On Mon, Dec 09, 2019 at 09:51:32AM -0600, Joe Hershberger wrote: > > > Hi Tom, > > > > Between dropping the superceeded atheros series and applying your nfs trim > > patch, things appear to be all good

Re: [U-Boot] [PATCH 1/9] phy: atheros: introduce debug read and write functions

2019-12-09 Thread Joe Hershberger
lle wrote: > > > > Hi Joe, Hi Tom, > > > > > > > > Am 2019-12-05 16:55, schrieb Joe Hershberger: > > > > > Hi Michael, > > > > > > > > > > On Fri, Oct 25, 2019 at 7:28 PM Michael Walle > > > > > wrote: > > &g

Re: [U-Boot] [PATCH] phy: atheros: add some debug output

2019-12-09 Thread Joe Hershberger
Hi Michael, On Sun, Oct 27, 2019 at 3:38 PM Michael Walle wrote: > > The network driver has to set the PHY node correctly. If that is not the > case, ar803x_of_init() will fail. Add some debugging output. > > If the device tree binding is not working for you have a look at the >

Re: [PATCH] net: nfs: Only link in NFS code outside of SPL builds

2019-12-08 Thread Joe Hershberger
On Thu, Dec 5, 2019 at 6:36 PM Tom Rini wrote: > > While we have networking use cases within SPL we do not support loading > files via NFS at this point in time. Disable calling nfs_start() so > that the NFS related code can be garbage collected at link time. > > Cc: Joe Her

Re: [U-Boot] [PATCH] cmd: pxe: Increase maximum path length

2019-12-05 Thread Joe Hershberger
ally manifest's itself. > > Signed-off-by: Ben Wolsieffer We'll try it and see if it blows any memory limits. Acked-by: Joe Hershberger > > --- > > cmd/pxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cmd/pxe.c b/cmd/pxe.c > index 20

Re: [U-Boot] [PATCH v2 1/1] net: avoid address-of-packed-member error

2019-12-05 Thread Joe Hershberger
On Thu, Dec 5, 2019 at 1:19 AM Heinrich Schuchardt wrote: > > On 11/6/19 12:07 AM, Joe Hershberger wrote: > > On Tue, Nov 5, 2019 at 5:49 AM Heinrich Schuchardt > > wrote: > >> > >> sandbox_defconfig does not compile using GCC 9.2.1: > >> > >&g

Re: [U-Boot] [PATCH 1/9] phy: atheros: introduce debug read and write functions

2019-12-05 Thread Joe Hershberger
Hi Michael, On Fri, Oct 25, 2019 at 7:28 PM Michael Walle wrote: > > Provide functions to read and write the Atheros debug registers. > > Signed-off-by: Michael Walle This series is adding too much size to several of the boards' SPL it seems.

Re: [U-Boot-Custodians] [ANN] U-Boot v2020.01-rc4 released

2019-12-03 Thread Joe Hershberger
Hey Tom, On Tue, Dec 3, 2019 at 11:05 AM Tom Rini wrote: > > On Tue, Dec 03, 2019 at 10:45:44AM -0600, Joe Hershberger wrote: > > Hi Tom, > > > > On Mon, Dec 2, 2019 at 9:11 PM Tom Rini wrote: > > > > > > Hey all, > > > > > > It's r

Re: [U-Boot-Custodians] [ANN] U-Boot v2020.01-rc4 released

2019-12-03 Thread Joe Hershberger
Hi Tom, On Mon, Dec 2, 2019 at 9:11 PM Tom Rini wrote: > > Hey all, > > It's release day and here is v2020.01-rc4. Yes, I'm still working on > fixing all of the issues that pop up as I get the MTD clean-up series > ready to go. In fact, what I need to do at this point is grab the > handful of

Re: [U-Boot] [RESEND PATCH] net: tftp: Fix tftp store address check in store_block()

2019-12-02 Thread Joe Hershberger
Hi Bin, On Sun, Dec 1, 2019 at 7:46 PM Bin Meng wrote: > > Hi Joe, > > On Wed, Nov 20, 2019 at 5:54 AM Joe Hershberger > wrote: > > > > On Sat, Nov 16, 2019 at 12:20 AM Bin Meng wrote: > > > > > > During testing of qemu-riscv32 with a 2GiB

Re: [U-Boot] [PATCH] net: tftp: Fix too small block size

2019-11-29 Thread Joe Hershberger
oying and > slow over serial links. > > Set the default block size in Kconfig back to the value it had before. > > This improves TFTP performance from 2.8 MB/s to 6.9 MB/s on a Pine64. > > Fixes: b618b3707633 ("net: Convert CONFIG_TFTP_BLOCKSIZE to Kconfig&q

Re: [U-Boot] [PATCH] net: ftgmac100: align RX/TX descriptors on ARCH_DMA_MINALIGN

2019-11-29 Thread Joe Hershberger
On Thu, Nov 28, 2019 at 6:37 AM Cédric Le Goater wrote: > > Fixes: e766849713ff ("net: ftgmac100: convert the RX/TX descriptor arrays") > Signed-off-by: Cédric Le Goater Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@

Re: [U-Boot] [PATCH] net: phy: micrel: make sure the factory test bit is cleared

2019-11-29 Thread Joe Hershberger
pull-up, the factory test mode should be cleared by manually writing a 0 > (according to the datasheet). > Create another ksz8081_config function to handle this case. > > Suggested-by: Antoine Tenart > Signed-off-by: Nicolas Ferre Acked-by: Joe Hershberger __

Re: [U-Boot] [PATCH] net: phy: aquantia: wait for phy init sequence to finish

2019-11-29 Thread Joe Hershberger
On Mon, Oct 14, 2019 at 9:27 AM Florin Chiculita wrote: > > Aquantia quad-phys may take longer to initialize. This commit adds > a polling mechanism for a global alarm bit that tells if phy init > sequence is completed. > > Signed-off-by: Florin Chiculita Acked-b

Re: [U-Boot] [PATCH 9/9] phy: atheros: consolidate {ar8031|ar8035}_config()

2019-11-29 Thread Joe Hershberger
On Fri, Oct 25, 2019 at 7:29 PM Michael Walle wrote: > > The two functions are now exactly the same, remove one of them. > > Signed-off-by: Michael Walle Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://l

Re: [U-Boot] [PATCH 8/9] phy: atheros: ar8035: remove static clock config

2019-11-29 Thread Joe Hershberger
breaks your board it probably > depends on the clock output of your Atheros AR8035 PHY. Please have a > look at doc/device-tree-bindings/net/phy/atheros.txt. You need to set > "clk-out-frequency = <12500>" because that value was the hardcoded > value until this commit. &g

Re: [U-Boot] [PATCH 7/9] phy: atheros: Add device tree bindings and config

2019-11-29 Thread Joe Hershberger
s commit adds support to > switch the internal LDO to 1.8V. > > Signed-off-by: Michael Walle Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 6/9] phy: atheros: fix delay configuration

2019-11-29 Thread Joe Hershberger
or PHY_INTERFACE_MODE_RGMII_ID mode. > > Signed-off-by: Michael Walle Either the offending dts's are already updated or they will be when this breaks them. It's been 6 months. Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 4/9] phy: atheros: ar8035: use phy_{read|write}_mmd()

2019-11-29 Thread Joe Hershberger
On Fri, Oct 25, 2019 at 7:31 PM Michael Walle wrote: > > Signed-off-by: Michael Walle Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 5/9] phy: atheros: don't overwrite debug register values

2019-11-29 Thread Joe Hershberger
On Fri, Oct 25, 2019 at 7:30 PM Michael Walle wrote: > > Instead of doing a hard write, do a read-modify-write. > > Signed-off-by: Michael Walle Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.d

Re: [U-Boot] [PATCH 3/9] phy: atheros: ar8035: remove extra delay config

2019-11-29 Thread Joe Hershberger
board you probably have > a wrong PHY interface mode. You probably want the > PHY_INTERFACE_MODE_RGMII_TXID or PHY_INTERFACE_MODE_RGMII_ID mode. > > Signed-off-by: Michael Walle Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists

Re: [U-Boot] [PATCH 2/9] phy: atheros: move delay config to common function

2019-11-29 Thread Joe Hershberger
On Fri, Oct 25, 2019 at 7:28 PM Michael Walle wrote: > > Signed-off-by: Michael Walle Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 1/9] phy: atheros: introduce debug read and write functions

2019-11-29 Thread Joe Hershberger
On Fri, Oct 25, 2019 at 7:28 PM Michael Walle wrote: > > Provide functions to read and write the Atheros debug registers. > > Signed-off-by: Michael Walle Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://l

Re: [U-Boot] [PATCH] phy: atheros: add some debug output

2019-11-29 Thread Joe Hershberger
adds it to the fsl_enetc driver: > https://patchwork.ozlabs.org/patch/1184523/ > > Signed-off-by: Michael Walle Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] net: eth-uclass: ignore unavailable devices

2019-11-29 Thread Joe Hershberger
er of available devices. The return value is only used in > spl_net to decide whether there are any devices to boot from. So > returning only available devices is also more correct in that case. > > Signed-off-by: Michael Walle Acked-by: Joe Hershberger ___

Re: [U-Boot] [PATCH 2/2] net: macb: let miiphy_read/_write pass arbitrary addresses

2019-11-29 Thread Joe Hershberger
On Wed, Oct 2, 2019 at 2:46 PM Josef Holzmayr wrote: > > This allows passing arbitrary addresses through macb_miiphy_read and > macb_miiphy_write, therefore enabling the mii command to access > all mdio bus devices instead of only the defined phy. > > Signed-off-by: Josef Holzma

Re: [U-Boot] [PATCH 1/2] net: macb: explicitly pass phy_adr to mdio read and write

2019-11-29 Thread Joe Hershberger
extended according to the Linux kernel > equivalent. > > Signed-off-by: Josef Holzmayr Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] net: phy: Increase link up delay in genphy_update_link()

2019-11-29 Thread Joe Hershberger
> the delay in the link check look from 1 to 50 ms and moving it below the > BMSR register read fixes this issue, resulting in a stable ethernet > traffic, even after initial link autonogotiation. > > Signed-off-by: Stefan Roese > Cc: Weijie Gao > Cc: Joe Hershb

Re: [U-Boot] [PATCH] net: rtl8169: Support RTL-8168c/8111c

2019-11-29 Thread Joe Hershberger
ogrammed after the DMA descriptors > have been set up, so make sure that happens by adding an entry to the > chip information table. > > Signed-off-by: Thierry Reding Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v4 5/5] net: mvpp2: MVPP2 now needs MVMDIO

2019-11-29 Thread Joe Hershberger
On Thu, Aug 15, 2019 at 5:09 PM wrote: > > From: Nevo Hed > > Changes to mvpp2.c require the MVMDIO module which in turn uses > DM_MDIO. > > Signed-off-by: Nevo Hed Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boo

Re: [U-Boot] [PATCH v4 4/5] net: mvpp2: use new MVMDIO driver

2019-11-29 Thread Joe Hershberger
driver that is based on a more universal > mdio-uclass implementation. > > Signed-off-by: Nevo Hed Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v4 3/5] arm: dts: armada-cp110-*dtsi: add xmdio nodes

2019-11-29 Thread Joe Hershberger
in Marvels own repo bump it > to 0x200 (512) bytes but I did not see the reasoning for that. > > https://github.com/MarvellEmbeddedProcessors/u-boot-marvell/commit/4d932b4. > > Also added device-name attributes to prevent ambiguity in the `mdio` > command. > > Sig

Re: [U-Boot] [PATCH v4 2/5] net: mvpp2: mark phy as invalid in case of missing appropriate driver

2019-11-29 Thread Joe Hershberger
on MCBIN board. > > nhed: added NULL deref test. > > Signed-off-by: Grzegorz Jaszczyk > Reviewed-by: Igal Liberman > Tested-by: Igal Liberman > Signed-off-by: Nevo Hed Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v4 1/5] net: mvpp2x: fix traffic stuck after PHY start error

2019-11-29 Thread Joe Hershberger
tiation. > > Signed-off-by: Stefan Chulski > Reviewed-by: Igal Liberman > Tested-by: Igal Liberman Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/6] net: introduce DSA class for Ethernet switches

2019-11-29 Thread Joe Hershberger
Hi Alex, On Mon, Nov 25, 2019 at 9:54 AM Alex Marginean wrote: > > DSA stands for Distributed Switch Architecture and it covers switches that > are connected to the CPU through an Ethernet link and generally use frame > tags to pass information about the source/destination ports to/from CPU. >

Re: [U-Boot] [PATCH] drivers: net: fsl_enetc: register internal MDIO bus

2019-11-29 Thread Joe Hershberger
t; > Signed-off-by: Alex Marginean Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 3/3] drivers: net: fsl_enetc_mdio: return with time-out if HW is stuck

2019-11-29 Thread Joe Hershberger
here forever > and freeze U-Boot. > > Signed-off-by: Alex Marginean Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 1/3] drivers: net: fsl_enetc: Add 2.5Gbps to supported link speeds

2019-11-29 Thread Joe Hershberger
On Thu, Nov 14, 2019 at 10:59 AM Alex Marginean wrote: > > The original code enabled link speeds up to 1Gbps, but the interface can > go up to 2.5G, enable that speed to in PHY AN mask. > > Signed-off-by: Alex Marginean Acked-by:

Re: [U-Boot] [PATCH 2/3] drivers: net: fsl_enetc: move PCS and PHY config to probe

2019-11-29 Thread Joe Hershberger
t; > Signed-off-by: Alex Marginean Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 11/11] drivers: net: fsl_enetc: use XFI, USXGMII interface type macros

2019-11-29 Thread Joe Hershberger
On Thu, Nov 14, 2019 at 10:31 AM Alex Marginean wrote: > > Apply 10G PCS init for USXGMII, XFI interface types. > > Signed-off-by: Alex Marginean Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.d

Re: [U-Boot] [PATCH v3 10/11] doc: bindings: Aquantia PHY node binding

2019-11-29 Thread Joe Hershberger
On Thu, Nov 14, 2019 at 10:34 AM Alex Marginean wrote: > > A couple of optional properties have been introduced for Aquantia PHY > allowing the driver to set up wiring related configuration points that > are otherwise driven by firmware. > > Signed-off-by: Alex Margine

Re: [U-Boot] [PATCH v3 09/11] doc: bindings: add bindings document for PHY nodes

2019-11-29 Thread Joe Hershberger
Marginean Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 08/11] drivers: net: aquantia: check system interface too when checking for link up

2019-11-29 Thread Joe Hershberger
ntia_link_is_up instead, which checks both system and line side on > gen 2/3 PHYs to avoid losing the 1st packet. > > Signed-off-by: Alex Marginean Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 07/11] drivers: net: aquantia: set SMBus addr based on DT property

2019-11-29 Thread Joe Hershberger
roperty used > to change SMBus address if needed. > > Signed-off-by: Alex Marginean Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 06/11] drivers: net: aquantia: set MDI reversal based on DT property

2019-11-29 Thread Joe Hershberger
t; > Signed-off-by: Alex Marginean Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

  1   2   3   4   5   6   7   8   9   10   >