Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-04 Thread Fabio Estevam
Hi Tim, On 04/10/2022 13:50, Tim Harvey wrote: Fabio, I just sent a v5 before seeing this. I think all we are waiting for on this series is for Vladimir to ok the dt changes as I believe I have finally done the right thing there now. If I need to do a v6 I'll add this in, otherwise I'll send

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-04 Thread Tim Harvey
On Tue, Oct 4, 2022 at 9:47 AM Fabio Estevam wrote: > > Hi Tim, > > On Tue, Oct 4, 2022 at 1:25 PM Fabio Estevam wrote: > > > > Hi Tim, > > > > On Tue, Oct 4, 2022 at 12:26 PM Tim Harvey wrote: > > > > > Fabio, > > > > > > Thanks for testing this. I'll submit a v5 shortly with your rb tag and >

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-04 Thread Fabio Estevam
Hi Tim, On Tue, Oct 4, 2022 at 1:25 PM Fabio Estevam wrote: > > Hi Tim, > > On Tue, Oct 4, 2022 at 12:26 PM Tim Harvey wrote: > > > Fabio, > > > > Thanks for testing this. I'll submit a v5 shortly with your rb tag and > > support for 6320: > > Thanks for including the 6320 model! > > > Was

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-04 Thread Fabio Estevam
Hi Tim, On Tue, Oct 4, 2022 at 12:26 PM Tim Harvey wrote: > Fabio, > > Thanks for testing this. I'll submit a v5 shortly with your rb tag and > support for 6320: Thanks for including the 6320 model! > Was there an error path you found in drivers/net/mv88e6xxx.c that > should print an error to

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-04 Thread Tim Harvey
On Mon, Oct 3, 2022 at 5:39 PM Fabio Estevam wrote: > > Hi Tim, > > On Mon, Oct 3, 2022 at 9:23 PM Tim Harvey wrote: > > > Where are you setting your active port? By default eth0 is active and > > thats the cpu uplink. If you have a network connection on lan3 port > > you would need to 'setenv

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-03 Thread Fabio Estevam
Hi Tim, On Mon, Oct 3, 2022 at 9:23 PM Tim Harvey wrote: > Where are you setting your active port? By default eth0 is active and > thats the cpu uplink. If you have a network connection on lan3 port > you would need to 'setenv ethact lan3'. It works now: both 'dhcp' and 'tftp' commands are

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-03 Thread Tim Harvey
On Mon, Oct 3, 2022 at 5:15 PM Fabio Estevam wrote: > > On Mon, Oct 3, 2022 at 8:46 PM Fabio Estevam wrote: > > > The switch I am using is a mv88e6320. > > > > I instrumented the code a bit and I notice that I am not able to read > > the switch ID. > > > > mv88e6xxx_get_switch_id() fails because

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-03 Thread Fabio Estevam
On Mon, Oct 3, 2022 at 8:46 PM Fabio Estevam wrote: > The switch I am using is a mv88e6320. > > I instrumented the code a bit and I notice that I am not able to read > the switch ID. > > mv88e6xxx_get_switch_id() fails because mv88e6xxx_port_read() returns 0x. This was caused by the wrong

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-03 Thread Fabio Estevam
Hi Tim, On Mon, Oct 3, 2022 at 8:39 PM Tim Harvey wrote: > Fabio, > > I'm not sure why your configuration is behaving differently and think > you'll have to instrument code to help understand it. > > Here is the chain of events I see on my imx6q fec <-> mv88e6085 configuration: The switch I am

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-03 Thread Tim Harvey
On Mon, Oct 3, 2022 at 3:35 PM Fabio Estevam wrote: > > On 03/10/2022 16:09, Tim Harvey wrote: > > > Right - so it looks like the 'net: fec: add support for DM_MDIO' patch > > is not doing its job to probe the mdio bus and ports. > > > > Is CONFIG_DM_MDIO enabled and is dm_fec_bind_mdio returning

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-03 Thread Fabio Estevam
On 03/10/2022 16:09, Tim Harvey wrote: Right - so it looks like the 'net: fec: add support for DM_MDIO' patch is not doing its job to probe the mdio bus and ports. Is CONFIG_DM_MDIO enabled and is dm_fec_bind_mdio returning successfully? Yes, for both. Is CONFIG_DM_ETH_PHY enabled? I

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-03 Thread Tim Harvey
On Mon, Oct 3, 2022 at 11:40 AM Fabio Estevam wrote: > > Hi Tim, > > On Mon, Oct 3, 2022 at 3:22 PM Tim Harvey wrote: > > > With CONFIG_CMD_NET=y what does 'net list' show? > > > > I have the following (with network attached to lan4 port) > > Net: MV88E61XX eth0: ethernet@2188000, eth1: lan4,

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-03 Thread Fabio Estevam
Hi Tim, On Mon, Oct 3, 2022 at 3:22 PM Tim Harvey wrote: > With CONFIG_CMD_NET=y what does 'net list' show? > > I have the following (with network attached to lan4 port) > Net: MV88E61XX eth0: ethernet@2188000, eth1: lan4, eth2: lan3, eth3: lan2, > eth > 4: lan1 > Hit any key to stop

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-03 Thread Tim Harvey
On Mon, Oct 3, 2022 at 10:13 AM Fabio Estevam wrote: > > Hi Tim, > > On Wed, Sep 28, 2022 at 4:37 PM Tim Harvey wrote: > > > diff --git a/configs/gwventana_gw5904_defconfig > > b/configs/gwventana_gw5904_defconfig > > index 8c6baf0ae5e2..33b57c5a1c5d 100644 > > ---

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-03 Thread Fabio Estevam
Hi Tim, On Wed, Sep 28, 2022 at 4:37 PM Tim Harvey wrote: > diff --git a/configs/gwventana_gw5904_defconfig > b/configs/gwventana_gw5904_defconfig > index 8c6baf0ae5e2..33b57c5a1c5d 100644 > --- a/configs/gwventana_gw5904_defconfig > +++ b/configs/gwventana_gw5904_defconfig > @@ -111,11

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-09-28 Thread Tim Harvey
On Wed, Sep 28, 2022 at 12:56 PM Fabio Estevam wrote: > > Hi Tim, > > On Wed, Sep 28, 2022 at 4:37 PM Tim Harvey wrote: > > > > Add MV88E61XX DSA support: > > - update dt: U-Boot dsa driver requires different device-tree syntax > >than the linux driver in order to link the dsa ports to the

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-09-28 Thread Fabio Estevam
Hi Tim, On Wed, Sep 28, 2022 at 4:37 PM Tim Harvey wrote: > > Add MV88E61XX DSA support: > - update dt: U-Boot dsa driver requires different device-tree syntax >than the linux driver in order to link the dsa ports to the mdio bus. Shouldn't the U-Boot dts version