Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

2008-07-10 Thread Michal Simek
Hi Ricardo, > Hi Michael > > Sorry to hear that. I have tried to give all my best and follow the > style of the ml300 board, which was the closest board to mine. > On FPGAs board I think that it is not a horrible idea to follow this > style. Maybe you should consider to create an FPGA branch,

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

2008-07-10 Thread Ricardo
Hello Wolfgang Lets find a solution to support ML507 on u-boot (and make my work availiable to more people). I am completly with you about the low quality of the xilinx-adapted code. I am using it for two things: i2c and ethernet, but the board can perfetly work without them. The i2c code can b

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

2008-07-10 Thread Wolfgang Denk
Dear Ricardo, in message <[EMAIL PROTECTED]> you wrote: > > Sorry to hear that. I have tried to give all my best and follow the > style of the ml300 board, which was the closest board to mine. > On FPGAs board I think that it is not a horrible idea to follow this > style. Maybe you should cons

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

2008-07-10 Thread Ricardo
Hi Michael Sorry to hear that. I have tried to give all my best and follow the style of the ml300 board, which was the closest board to mine. On FPGAs board I think that it is not a horrible idea to follow this style. Maybe you should consider to create an FPGA branch, where the generic drivers

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

2008-07-10 Thread Michal Simek
Hi Ricardo, I read your patches in your weird style. These style of patches never go to mainline. You use xilinx generated files which is currently use only with ml300. For example look at your xparameters.h there are a lot of values which are not used. If you want to add ml507 to mainline U-BO

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

2008-07-10 Thread Wolfgang Denk
In message <[EMAIL PROTECTED]> you wrote: > > I wanted the four parts to have the same subject, to easy the But this makes no sense, especiall when you add "1/4" to the subject. > handling of the files. The first submition was 4 .bz2 dependent > files... But later on the evening I have prepare

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

2008-07-10 Thread Ricardo
Hello Wolfgang I wanted the four parts to have the same subject, to easy the handling of the files. The first submition was 4 .bz2 dependent files... But later on the evening I have prepared 8 different INdependent patches following the guidelines on the u-boot site. Sorry for the mess. I have s

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

2008-07-10 Thread Wolfgang Denk
In message <[EMAIL PROTECTED]> you wrote: > > And Part 4 Could you please explain why the subject says part 1, and the message body says part 4 ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

2008-07-10 Thread Wolfgang Denk
In message <[EMAIL PROTECTED]> you wrote: > > Any comment will be very welcomed. > > PS: I have divided the patch in four parts for the mailing list Soerry, I can neither read nor apply this conveniently: > Content-Type: application/x-bzip2; name=ml507_1_of_4.diff.bz2 > Content-Transfer-Encoding

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

2008-07-10 Thread Ricardo
And Part 4 On Thu, Jul 10, 2008 at 6:07 PM, Ricardo <[EMAIL PROTECTED]> wrote: > Part 3 > > On Thu, Jul 10, 2008 at 6:07 PM, Ricardo <[EMAIL PROTECTED]> wrote: >> Part 2 >> >> On Thu, Jul 10, 2008 at 6:06 PM, Ricardo <[EMAIL PROTECTED]> wrote: >>> Hi List: >>> >>> This is my first contribution t

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

2008-07-10 Thread Ricardo
Part 3 On Thu, Jul 10, 2008 at 6:07 PM, Ricardo <[EMAIL PROTECTED]> wrote: > Part 2 > > On Thu, Jul 10, 2008 at 6:06 PM, Ricardo <[EMAIL PROTECTED]> wrote: >> Hi List: >> >> This is my first contribution to u-boot. I have ported u-boot to the >> ML507 Board by Xilinx. >> http://www.xilinx.com/pro

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

2008-07-10 Thread Ricardo
Part 2 On Thu, Jul 10, 2008 at 6:06 PM, Ricardo <[EMAIL PROTECTED]> wrote: > Hi List: > > This is my first contribution to u-boot. I have ported u-boot to the > ML507 Board by Xilinx. > http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm > > This boards includes an FPGA Virtex 5 FX with

[U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

2008-07-10 Thread Ricardo
Hi List: This is my first contribution to u-boot. I have ported u-boot to the ML507 Board by Xilinx. http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm This boards includes an FPGA Virtex 5 FX with an embedded PowerPC 440. The port supports: -Virtex 5 ppc440x5 -XIlinx Interrup