Re: [U-Boot-Users] How to port u-boot to newest Intel x86 embedded system?

2008-11-23 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:26 Sun 23 Nov , xuchun wrote:
 Hi,
 
 I want use u-boot as  boot loader in new product. But I found there is
 only one board type(sc520) in u-boot source code(u-boot-1.3.3). The CPU
 in this board is quite old. We use Intel Core in our project. Do u-boot
 have any plan to port to newest x86 chips?

Hi,

Actually Graeme Russ is updating the x86 support, and do not thing il
will to much to add your cpu in the x86 arch.

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] pxa 270

2008-11-08 Thread Jean-Christophe PLAGNIOL-VILLARD
On 15:06 Sat 08 Nov , Gaechter, Stefan wrote:
hello,
 
does somebody have experience with the uboot loader and a compulab
CM-X270?
 
heare the link to the board:
http://www.compulab.co.il/x270/html/x270-cm-data***.htm
 
we have big problems with the compulab bootloader armmoon and we get a
very bad support from compulab.
the problem is that often after a software reset the armoon hang and the
only wai to get the board working is a hardware reset.
 
so we are looking do find a new solution with an other bootloader.
 
but we have now experience with uboot, so we are happy about all the
informations we get.
does somebody have experience with uboot and the compulab pxa270 board?
is another pxa270 board aviable to take a look at the uboot sources to get
a good start?

you could take a look on the trizepsiv board.

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 1/1] Re-Submit: Add support for ATMEL AT91SAM9G20EK board.

2008-11-04 Thread Jean-Christophe PLAGNIOL-VILLARD
On 10:17 Tue 29 Jul , Hong Xu wrote:
 From 8e7f74804f86c25639f4009ba14fd6c1affe5ee6 Mon Sep 17 00:00:00 2001
 From: Hong Xu [EMAIL PROTECTED]
 Date: Tue, 29 Jul 2008 09:23:47 +0800
 Subject: [PATCH 1/1] Add support for ATMEL AT91SAM9G20EK board.
 
 This patch add support for ATMEL AT91SAM9G20EK board.
 - Per J's request, this patch's based on branch for-1.3.5
 - Per *'s suggestion, remove the *big* #ifdef
 - Per Ben's suggestion, don't touch net/eth.c, move code to board init part.
 
 Thanks
 BR,
 Eric
 
 Signed-off-by: Hong Xu [EMAIL PROTECTED]
 ---
  Makefile  |2 +
  board/atmel/at91sam9g20ek/Makefile|   57 +++
  board/atmel/at91sam9g20ek/at91sam9g20ek.c |  257 
 +
  board/atmel/at91sam9g20ek/config.mk   |1 +
  board/atmel/at91sam9g20ek/led.c   |   64 +++
  board/atmel/at91sam9g20ek/nand.c  |   79 +
  board/atmel/at91sam9g20ek/partition.c |   40 +
  drivers/net/macb.c|   14 +-
  include/asm-arm/arch-at91/hardware.h  |2 +-
  include/configs/at91sam9g20ek.h   |  202 ++
  10 files changed, 709 insertions(+), 9 deletions(-)
  create mode 100644 board/atmel/at91sam9g20ek/Makefile
  create mode 100644 board/atmel/at91sam9g20ek/at91sam9g20ek.c
  create mode 100644 board/atmel/at91sam9g20ek/config.mk
  create mode 100644 board/atmel/at91sam9g20ek/led.c
  create mode 100644 board/atmel/at91sam9g20ek/nand.c
  create mode 100644 board/atmel/at91sam9g20ek/partition.c
  create mode 100644 include/configs/at91sam9g20ek.h

Do you have any plan to send a rebase version?

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor

2008-10-31 Thread Jean-Christophe PLAGNIOL-VILLARD
On 16:29 Fri 31 Oct , Jens Gehrlein wrote:
 Jean-Christophe PLAGNIOL-VILLARD schrieb:
 On 11:33 Tue 08 Jul , Jens Gehrlein wrote:
 Signed-off-by: Jens Gehrlein [EMAIL PROTECTED]
 ---

 Fixed two bugs:
 a) added NFS mount option rw to default environment
 b) added prefix $(obj) in front of .depend in Makefile. Thank you Magnus 
 for catching that.


  MAINTAINERS   |4  MAKEALL
|1  Makefile  |3  
 board/tqc/tqma31/Makefile |   48 
  board/tqc/tqma31/config.mk|2  
 board/tqc/tqma31/lowlevel_init.S  |  375 
 +
  board/tqc/tqma31/tqma31.c |   95 
  board/tqc/tqma31/u-boot.lds   |   72 ++
  include/asm-arm/arch-mx31/mx31-regs.h |   42 
  include/configs/TQMA31.h  |  271 
  10 files changed, 913 insertions(+), 0 deletions(-)
  create mode 100644 board/tqc/tqma31/Makefile
  create mode 100644 board/tqc/tqma31/config.mk
  create mode 100644 board/tqc/tqma31/lowlevel_init.S
  create mode 100644 board/tqc/tqma31/tqma31.c
  create mode 100644 board/tqc/tqma31/u-boot.lds
  create mode 100644 include/configs/TQMA31.h

 Do you have any plan to send a rebase patch?

 I suppose in Q1/2009. It depends on our customer and on
 my workload with other projects.

 But could you possibly consider
 [U-Boot-Users] [PATCH 01/10 v2] [ARM] MXC: insert bus busy check in  
 i2c_probe from 2008-07-08 04:20 PM ?
 IMO it's independent of the other patches.

is it the only one?
 Thank you for asking.

 It's curious: always, when replying to your e-mails, my e-mail address
 appears in the To field instead of your address.
 Do the others have this problem, too? (Thunderbird 2.0.0.14 on Linux)
I use mutt and I receve the e-mail with your e-mail address as sender

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor

2008-10-31 Thread Jean-Christophe PLAGNIOL-VILLARD
On 10:10 Fri 31 Oct , Ben Warren wrote:
 Magnus Lilja wrote:
 It's curious: always, when replying to your e-mails, my e-mail address
 appears in the To field instead of your address.
 Do the others have this problem, too? (Thunderbird 2.0.0.14 on Linux)
   
 I use mutt and I receve the e-mail with your e-mail address as sender
 

 I have the same problem when replying to Jean-Christphe's replies. For
 some reason the reply-to field is set when JC posts a reply and I
 suppose that messes up Thunderbird/gmail etc.

 As an example, the email I'm replying to now has reply-to: set to
 [EMAIL PROTECTED] and [EMAIL PROTECTED]

 Follow ups from other people don't have the reply-to: field. So my
 guess is that JC's mutt adds that.

   
 I noticed the same thing when doing a reply-all to one of JC's e-mails.   
 It put my address in 'To'.  I using Thunderbird with IMAP connection to  
 Gmail.  I've seen with both Windows and Linux versions of Thunderbird.


I do nothing special in mutt I just use it for several years

and it's the first time some one report me this problem

If someone known why please tell us

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor

2008-10-27 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:33 Tue 08 Jul , Jens Gehrlein wrote:
 Signed-off-by: Jens Gehrlein [EMAIL PROTECTED]
 ---
 
 Fixed two bugs:
 a) added NFS mount option rw to default environment
 b) added prefix $(obj) in front of .depend in Makefile. Thank you Magnus for 
 catching that.
 
 
  MAINTAINERS   |4 
  MAKEALL   |1 
  Makefile  |3 
  board/tqc/tqma31/Makefile |   48 
  board/tqc/tqma31/config.mk|2 
  board/tqc/tqma31/lowlevel_init.S  |  375 
 +
  board/tqc/tqma31/tqma31.c |   95 
  board/tqc/tqma31/u-boot.lds   |   72 ++
  include/asm-arm/arch-mx31/mx31-regs.h |   42 
  include/configs/TQMA31.h  |  271 
  10 files changed, 913 insertions(+), 0 deletions(-)
  create mode 100644 board/tqc/tqma31/Makefile
  create mode 100644 board/tqc/tqma31/config.mk
  create mode 100644 board/tqc/tqma31/lowlevel_init.S
  create mode 100644 board/tqc/tqma31/tqma31.c
  create mode 100644 board/tqc/tqma31/u-boot.lds
  create mode 100644 include/configs/TQMA31.h

Do you have any plan to send a rebase patch?

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH]:Enable 2D Engine in SM501!

2008-10-24 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:11 Fri 01 Aug , Ryan CHEN wrote:
 Hi all,
 This patch is part 2 for [PATCH:Enable 2D Engine in SM501]. New macro 
 CONFIG_SM501_ENABLE_2DENGINE be included to specify codes what enable SM501 
 2D engine. The macro need be declared in config header file.
 Why does it need to enable 2D engine? The reason is most of framebuffer 
 contents need be moved in VRAM when screen scrolls up. The work be done by 
 software in current U-Boot for SM501. The patch is to enable 2D engine to do 
 it by hardware without CPU interference.  
 
 Signed-off-by: Ryan Chen [EMAIL PROTECTED]
Do you plan to send a rebase patch?

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] ads5121: support for running from memory

2008-10-24 Thread Jean-Christophe PLAGNIOL-VILLARD
On 21:55 Thu 25 Sep , Nikita V. Youshchenko wrote:
 commit 599e6d1ff1fbab0abda4ef685f6078c4d2f1d2eb
 Author: Nikita V. Youshchenko [EMAIL PROTECTED]
 Date:   Tue Sep 2 07:51:05 2008 +0400
 
 ads5121: support for running from memory
 
 This patch makes it possible to start u-boot from memory on ads5121 board.
 
 It does two simple things:
 - skips initialization of memory controller if already running from 
 memory,
 - helps u-boot to find it's environment in flash when CFG_MONITOR_BASE 
 does
   not point to u-boot flash address.
 
 Signed-off-by: Nikita V. Youshchenko [EMAIL PROTECTED]
 
Could you rebase it against current HEAD?

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] Compilation problem for TI3430 board.

2008-10-17 Thread Jean-Christophe PLAGNIOL-VILLARD
On 22:44 Thu 16 Oct , Radha Krishna wrote:
 Hi,
 
 I have downloaded U-boot and trying to compile it for the Target 
 omap3430sdp_config. 
Where do you download it?
it's not a mainline board
 
 Using commands 
 
 Step 0: make distclean
 
 Step 1: make CROSS_COMPILE=arm-none-linux-gnueabi- omap3430sdp_config
 
 Step 2: make CROSS_COMPILE=arm-none-linux-gnueabi-
 
 I had problem in the compilation.
 
As said Ben please be more specific

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] SD support for more than 128MB in u-boot1.3.1

2008-10-16 Thread Jean-Christophe PLAGNIOL-VILLARD
On 19:03 Thu 31 Jul , Naveen Kumar GADDIPATI wrote:
 Hi,
 
 Processor is arm926ejs based ST processor.
 I'm facing problem in supporting SD Card of size more than 128MB.
 SD Card is able to detect,but failing in reading boot sector info of the SD 
 block.
 
 Is their any limitation for FAT16 in uboot 1.3.1?
 
 One more thing,Is FAT32 support is present in uboot 1.3.1?If their any patch 
 for FAT32 in u-boot,please respond.
sorry to came back so late.

IIRC the current FAT32 implementation do have a problem about dynamic block
There is a thread and an analysis on the ML archive that could help you.

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 3/3] sh: Renesas RSK+ 7203 board support

2008-08-30 Thread Jean-Christophe PLAGNIOL-VILLARD
 +# published by the Free Software Foundation; either version 2 of
 +# the License, or (at your option) any later version.
 +#
 +# This program is distributed in the hope that it will be useful,
 +# but WITHOUT ANY WARRANTY; without even the implied warranty of
 +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 +# GNU General Public License for more details.
 +#
 +# You should have received a copy of the GNU General Public License
 +# along with this program; if not, write to the Free Software
 +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 +# MA 02111-1307 USA
 +
 +include $(TOPDIR)/config.mk
 +
 +LIB  = lib$(BOARD).a
 +
 +OBJS := rsk7203.o
 +SOBJS:= lowlevel_init.o
 +
 +$(LIB):  $(OBJS) $(SOBJS)
 + $(AR) crv $@ $(OBJS) $(SOBJS)
please use $(ARFLAGS) insteaf of crv

and you forget to add $(obj).depend in lib depend

btw: I will be good to create a Renesas vendor dir
 +clean:
 + rm -f $(SOBJS) $(OBJS)
 +
 +distclean:   clean
 + rm -f $(LIB) core *.bak .depend
 +
 +#
 +

Please replave with

 + $(CC) -M $(CPPFLAGS) $(SOBJS:.o=.S) $(OBJS:.o=.c)  $@
 +
 +-include .depend
# defines $(obj).depend target
include $(SRCTREE)/rules.mk

sinclude $(obj).depend

 +++ b/board/rsk7203/config.mk
 @@ -0,0 +1,28 @@
 +#
 +# Copyright (C) 2007,2008 Nobuhiro Iwamatsu
 +# Copyright (C) 2008 Renesas Solutions Corp.
 +#
 +# u-boot/board/rsk7203/config.mk
 +#
 +# This program is free software; you can redistribute it and/or
 +# modify it under the terms of the GNU General Public License as
 +# published by the Free Software Foundation; either version 2 of
 +# the License, or (at your option) any later version.
 +#
 +# This program is distributed in the hope that it will be useful,
 + mov.l FRQCR_D,r0
 + mov.w r0,@r1
 +
 + /* ConfigureBusAndMemory */
Please use Tab for indent for the following asm lines
 +init_bsc_cs0:
 +mov.l   PCCRL4_A,r1
 +mov.l   PCCRL4_D1,r0
 +mov.w   r0,@r1
 +
 +mov.l   PECRL1_A,r1
 +mov.l   PECRL1_D1,r0
 +mov.w   r0,@r1
 +
 +mov.l CMNCR_A,r1
 +mov.l CMNCR_D,r0
 +mov.l r0,@r1
 +
 +mov.l SC0BCR_A,r1
 +mov.l SC0BCR_D,r0
 +mov.l r0,@r1
 +
 +mov.l CS0WCR_A,r1
 +mov.l CS0WCR_D,r0
 +mov.l r0,@r1
 +
 +init_bsc_cs1:
 +mov.l   PECRL4_A,r1
 +mov.l   PECRL4_D1,r0
 +mov.w   r0,@r1
 +
 +mov.l CS1WCR_A,r1
 +mov.l CS1WCR_D,r0
 +mov.l r0,@r1
 +
 +init_sdram:
 + mov.l   PCCRL2_A,r1
 + mov.l   PCCRL2_D,r0
 + mov.w   r0,@r1
 +
 + mov.l   PCCRL4_A,r1
 + mov.l   PCCRL4_D2,r0
 + mov.w   r0,@r1
 +
 +mov.l   PCCRL1_A,r1
 + mov.l   PCCRL1_D,r0
 +mov.w   r0,@r1
 +
 +mov.l   PCCRL3_A,r1
 + mov.l   PCCRL3_D,r0
 +mov.w   r0,@r1
 +
 + mov.l CS3BCR_A,r1
 + mov.l CS3BCR_D,r0
 + mov.l r0,@r1
 +
 + mov.l CS3WCR_A,r1
 + mov.l CS3WCR_D,r0
 + mov.l r0,@r1
 +
 + mov.l SDCR_A,r1
 + mov.l SDCR_D,r0
 + mov.l r0,@r1
 +
 + mov.l RTCOR_A,r1
 + mov.l RTCOR_D,r0
 + mov.l r0,@r1
 +
 + mov.l RTCSR_A,r1
 + mov.l RTCSR_D,r0
 + mov.l r0,@r1
 +
 +/* wait 200us */
 +mov.l   REPEAT_D,r3
 +mov #0,r2
 +repeat0:
 +add #1,r2
 +cmp/hs  r3,r2
 +bf  repeat0
 +nop
 +
 + mov.l SDRAM_MODE, r1
 + mov   #0,r0
 + mov.l r0, @r1
 +
 + nop
 + rts
 +
 + .align 4
 +
 +CCR1_A: .long CCR1
 +CCR1_D: .long 0x090B
 +PCCRL4_A:.long 0xFFFE3910
 +PCCRL4_D0:   .long 0x
 +PECRL4_A:.long 0xFFFE3A10
 +PECRL4_D0:   .long 0x
 +PECRL3_A:.long 0xFFFE3A12
 +PECRL3_D:.long 0x
 +PEIORL_A:.long 0xFFFE3A06
 +PEIORL_D0:   .long 0x1C00
 +PEIORL_D1:   .long 0x1C02
 +PCIORL_A:.long 0xFFFE3906
 +PCIORL_D:.long 0x4000
 +PFCRH2_A:.long 0xFFFE3A8C
 +PFCRH2_D:.long 0x
 +PFCRH3_A:.long 0xFFFE3A8A
 +PFCRH3_D:.long 0x
 +PFCRH1_A:.long 0xFFFE3A8E
 +PFCRH1_D:.long 0x
 +PFIORH_A:.long 0xFFFE3A84
 +PFIORH_D:.long 0x0729
 +PECRL1_A:.long 0xFFFE3A16
 +PECRL1_D0:   .long 0x0033
 +
 +
 +WTCSR_A: .long 0xFFFE
 +WTCSR_D0:.long 0xA518
 +WTCSR_D1:.long 0xA51D
 +WTCNT_A: .long 0xFFFE0002
 +WTCNT_D: .long 0x5A84
 +FRQCR_A: .long 0xFFFE0010
 +FRQCR_D: .long 0x0104
 +
 +PCCRL4_D1:   .long 0x0010
 +PECRL1_D1:   .long 0x0133
 +
 +CMNCR_A: .long 0xFFFC
 +CMNCR_D: .long 0x1810
 +SC0BCR_A:.long 0xFFFC0004
 +SC0BCR_D:.long 0x1400
 +CS0WCR_A:.long 0xFFFC0028
 +CS0WCR_D:.long 0x0B41
 +PECRL4_D1:   .long 0x0100
 +CS1WCR_A:.long 0xFFFC002C
 +CS1WCR_D:.long 0x0B01
 +PCCRL4_D2:   .long 0x0011
 +PCCRL3_A:.long 0xFFFE3912
 +PCCRL3_D:.long 0x0011
 +PCCRL2_A:.long 0xFFFE3914
 +PCCRL2_D:.long 0x
 +PCCRL1_A:.long 0xFFFE3916
 +PCCRL1_D:.long 0x1010
 

Re: [U-Boot-Users] [PATCH 1/3] sh: Add support SH2/SH2A which is CPU of Renesas Technology

2008-08-30 Thread Jean-Christophe PLAGNIOL-VILLARD
 +# modify it under the terms of the GNU General Public License as
 +# published by the Free Software Foundation; either version 2 of
 +# the License, or (at your option) any later version.
 +#
 +# This program is distributed in the hope that it will be useful,
 +# but WITHOUT ANY WARRANTY; without even the implied warranty of
 +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 +# GNU General Public License for more details.
 +#
 +# You should have received a copy of the GNU General Public License
 +# along with this program; if not, write to the Free Software
 +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 +# MA 02111-1307 USA
 +#
 +
 +include $(TOPDIR)/config.mk
 +
 +LIB  = $(obj)lib$(CPU).a
 +
 +START= start.o
 +OBJS = cpu.o interrupts.o watchdog.o time.o # cache.o
 +
 +all: .depend $(START) $(LIB)
please use $(obj).depend
 +
 +$(LIB):  $(OBJS)
 + $(AR) crv $@ $(OBJS)
please replace crv by $(ARFLAGS)
 +
 +#
 +
 +.depend: Makefile $(START:.o=.S) $(OBJS:.o=.c)
 + $(CC) -M $(CFLAGS) $(START:.o=.S) $(OBJS:.o=.c)  $@
 +
 +sinclude .depend
please replace with

# defines $(obj).depend target
include $(SRCTREE)/rules.mk

sinclude $(obj).depend

 +
 +#
 diff --git a/cpu/sh2/cache.c b/cpu/sh2/cache.c
 new file mode 100644
 index 000..d7ac2a5
 --- /dev/null
 +++ b/cpu/sh2/cache.c
 @@ -0,0 +1,112 @@
 +/*
 + * (C) Copyright 2007
 + * Yoshihiro Shimoda [EMAIL PROTECTED]
 + *
 + * Copyright (C) 2007, 2008 Nobobuhiro Iwamatsu [EMAIL PROTECTED]
 + * Copyright (C) 2008 Renesas Solutions Corp.
 + *
 + * See file CREDITS for list of people who contributed to this
 + * project.
 + *
 + * This program is free software; you can redistribute it and/or
 + * modify it under the terms of the GNU General Public License as
 + * published by the Free Software Foundation; either version 2 of
 + * the License, or (at your option) any later version.
 + *
 + * This program is distributed in the hope that it will be useful,
 + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 + * GNU General Public License for more details.
 + *
 + * You should have received a copy of the GNU General Public License
 + * along with this program; if not, write to the Free Software
 + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 + * MA 02111-1307 USA
 + */
 +
 +#include common.h
 +#include command.h
 +#include asm/processor.h
 +#include asm/io.h
 +
 +/*
 + * Jump to P2 area.
 + * When handling TLB or caches, we need to do it from P2 area.
 + */
 +#define jump_to_P2()\
 +  do {\
 +unsigned long __dummy;   \
 +__asm__ __volatile__(\
 + mov.l  1f, %0\n\t \
 + or %1, %0\n\t \
 + jmp@%0\n\t\
 +  nop\n\t  \
 + .balign 4\n   \
 + 1: .long 2f\n \
 + 2:\
 + : =r (__dummy)   \
 + : r (0x2000));\
 +  } while (0)
 +
please use tab instead of space
 +/*
 + * Back to P1 area.
 + */
 +#define back_to_P1()\
 +  do {\
 +unsigned long __dummy;  \
 +__asm__ __volatile__(   \
 + nop;nop;nop;nop;nop;nop;nop\n\t   \
 + mov.l  1f, %0\n\t \
 + jmp@%0\n\t\
 +  nop\n\t  \
 + .balign 4\n   \
 + 1: .long 2f\n \
 + 2:\
 + : =r (__dummy)); \
 +  } while (0)
please use tab instead of space
 +
 +#define CACHE_VALID   1
  ^^^
 +#define CACHE_UPDATED 2
^
whitespace
 +
 +static inline void cache_wback_all(void)
 +{
 + unsigned long addr, data, i, j;
 +
 + jump_to_P2();
 + for (i = 0; i  CACHE_OC_NUM_ENTRIES; i++) {
 + for (j = 0; j  CACHE_OC_NUM_WAYS; j++) {
 + addr = CACHE_OC_ADDRESS_ARRAY
 + | (j  CACHE_OC_WAY_SHIFT)
 + | (i  CACHE_OC_ENTRY_SHIFT);
 + data = inl(addr);
 + if (data  CACHE_UPDATED) {
 + data = ~CACHE_UPDATED;
 + outl(data, addr);
 + }
 + }
 + }
 + back_to_P1();
 +}
 +
 +
 +#define CACHE_ENABLE  0
   ^^
 +#define CACHE_DISABLE 1
^

Re: [U-Boot-Users] [PATCH v2] sh: Renesas R0P7785LC0011RL board support

2008-08-30 Thread Jean-Christophe PLAGNIOL-VILLARD
On 19:09 Wed 16 Jul , Yoshihiro Shimoda wrote:
 This board has SH7785, 512MB DDR2-SDRAM, NOR Flash,
 Graphic, Ethernet, USB, SD, RTC, and I2C controller.
 
 This patch supports the following functions:
  - 128MB DDR2-SDRAM (29-bit address mode only)
  - NOR Flash
  - USB host
  - Ethernet
 
 Signed-off-by: Yoshihiro Shimoda [EMAIL PROTECTED]
 ---
 
 PATCH v2 :
  - fix the Makefile.
  - remove unnecessary #define.
  - add README for this board.
  - change the directory name from r0p7785lc0011rl to sh7785lcr.
  - fix compile warning in rtl8169_mac.c and selfcheck.c.
 
  MAINTAINERS |1 +
  MAKEALL |1 +
  Makefile|5 +
  board/sh7785lcr/Makefile|   42 +
  board/sh7785lcr/config.mk   |   26 +++
  board/sh7785lcr/lowlevel_init.S |  318 +++
  board/sh7785lcr/rtl8169.h   |   58 +++
  board/sh7785lcr/rtl8169_mac.c   |  349 
 +++
  board/sh7785lcr/selfcheck.c |  173 +++
  board/sh7785lcr/sh7785lcr.c |   51 ++
  board/sh7785lcr/u-boot.lds  |   97 +++
  doc/README.sh7785lcr|   83 +
  include/configs/sh7785lcr.h |  167 +++
  13 files changed, 1371 insertions(+), 0 deletions(-)
  create mode 100644 board/sh7785lcr/Makefile
  create mode 100644 board/sh7785lcr/config.mk
  create mode 100644 board/sh7785lcr/lowlevel_init.S
  create mode 100644 board/sh7785lcr/rtl8169.h
  create mode 100644 board/sh7785lcr/rtl8169_mac.c
  create mode 100644 board/sh7785lcr/selfcheck.c
  create mode 100644 board/sh7785lcr/sh7785lcr.c
  create mode 100644 board/sh7785lcr/u-boot.lds
  create mode 100644 doc/README.sh7785lcr
  create mode 100644 include/configs/sh7785lcr.h
 
 diff --git a/MAINTAINERS b/MAINTAINERS
 index a3d70b1..b6f7002 100644
 --- a/MAINTAINERS
 +++ b/MAINTAINERS
 @@ -731,6 +731,7 @@ Mark Jonas [EMAIL PROTECTED]
  Yoshihiro Shimoda [EMAIL PROTECTED]
 
   MS7720SESH7720
 + R0P77850011RL   SH7785
 
  Yusuke Goda [EMAIL PROTECTED]
 
 diff --git a/MAKEALL b/MAKEALL
 index 9f80b3d..a37b503 100755
 --- a/MAKEALL
 +++ b/MAKEALL
 @@ -753,6 +753,7 @@ LIST_sh4=\
   r7780mp \
   r2dplus \
   sh7763rdp   \
 + sh7785lcr   \
  
 
  LIST_sh=\
 diff --git a/Makefile b/Makefile
 index ac3f98f..648a032 100644
 --- a/Makefile
 +++ b/Makefile
 @@ -2955,6 +2955,11 @@ sh7763rdp_config  :   unconfig
   @echo #define CONFIG_SH7763RDP 1  $(obj)include/config.h
   @./mkconfig -a $(@:_config=) sh sh4 sh7763rdp
 
 +sh7785lcr_config  :   unconfig
 + @ include/config.h
 + @echo #define CONFIG_SH7785LCR 1  include/config.h
 + @./mkconfig -a $(@:_config=) sh sh4 sh7785lcr
please use $(MKCONFIG)

btw why not create renesas vendor dir
 +
  #
  # SPARC
  #
 diff --git a/board/sh7785lcr/Makefile b/board/sh7785lcr/Makefile
 new file mode 100644
 index 000..e948ba1
 --- /dev/null
 +++ b/board/sh7785lcr/Makefile
 @@ -0,0 +1,42 @@
 +#
 +# Copyright (C) 2008  Yoshihiro Shimoda [EMAIL PROTECTED]
 +#
 +# This program is free software; you can redistribute it and/or
 +# modify it under the terms of the GNU General Public License as
 +# published by the Free Software Foundation; either version 2 of
 +# the License, or (at your option) any later version.
 +#
 +# This program is distributed in the hope that it will be useful,
 +# but WITHOUT ANY WARRANTY; without even the implied warranty of
 +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 +# GNU General Public License for more details.
 +#
 +# You should have received a copy of the GNU General Public License
 +# along with this program; if not, write to the Free Software
 +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 +# MA 02111-1307 USA
 +
 +include $(TOPDIR)/config.mk
 +
 +LIB  = lib$(BOARD).a
 +
 +COBJS:= sh7785lcr.o selfcheck.o rtl8169_mac.o
 +SOBJS:= lowlevel_init.o
 +
 +$(LIB):  $(COBJS) $(SOBJS)
 + $(AR) $(ARFLAGS) $@ $(COBJS) $(SOBJS)
please add $(obj).depend in LIB dependancy
 +
 +clean:
 + rm -f $(SOBJS) $(OBJS)
 +
 +distclean:   clean
 + rm -f $(LIB) core *.bak $(obj).depend
 +
 +#
 +
 +.depend: Makefile $(SOBJS:.o=.S) $(OBJS:.o=.c)
 + $(CC) -M $(CPPFLAGS) $(SOBJS:.o=.S) $(OBJS:.o=.c)  $@
 +
 +-include .depend
please replace with

# defines $(obj).depend target
include $(SRCTREE)/rules.mk

sinclude $(obj).depend

 +
 +#
 + MacBitDtSet(1);
 + MacBitDtSet(0);
 + MacBitDtSet(0);
 + break;
 + case MAC_EEP_EWDS:
 + 

Re: [U-Boot-Users] [PATCH] fix USB devices with multiple configurations

2008-08-28 Thread Jean-Christophe PLAGNIOL-VILLARD
On 00:11 Thu 10 Jul , Wolfgang Denk wrote:
 In message [EMAIL PROTECTED] you wrote:
  
  This patch fixes bugs in usbdcore*.c related to the use of devices
  with multiple configurations.
  
  The original code made mistakes about the meaning of configuration value and
  configuration index, and the resulting off-by-one errors resulted in:
  
  * SET_CONFIGURATION always selected the first configuration, no matter what
wValue is being passed.
  * GET_DESCRIPTOR/CONFIGURATION always returned the descriptor for the first
configuration (index 0).
  
  Signed-off-by: Harald Welte [EMAIL PROTECTED]
 
 Markus, are you going to add this to the USB repo any time soon?
 
 Or you could just ACK it (if you think so) and tell me to pick up
 directly.
Any news about this patch?

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 4/4] ARM DaVinci: Standardize names of directories/files

2008-08-27 Thread Jean-Christophe PLAGNIOL-VILLARD
On 15:10 Fri 11 Jul , Hugo Villeneuve wrote:
 ARM DaVinci: Standardize names of directories/files.
 
 Signed-off-by: Hugo Villeneuve [EMAIL PROTECTED]
 
 ---
 
  Makefile   |2 +-
  board/davinci/{dv-evm = dvevm}/Makefile   |2 +-
  board/davinci/{dv-evm = dvevm}/board_init.S   |0 
  board/davinci/{dv-evm = dvevm}/config.mk  |0 
  board/davinci/{dv-evm/dv_board.c = dvevm/dvevm.c} |0 
  board/davinci/{dv-evm = dvevm}/u-boot.lds |0 
  board/davinci/schmoogie/Makefile   |2 +-
  .../davinci/schmoogie/{dv_board.c = schmoogie.c}  |0 
  board/davinci/sonata/Makefile  |2 +-
  board/davinci/sonata/{dv_board.c = sonata.c}  |0 
  10 files changed, 4 insertions(+), 4 deletions(-)
 
Applied to u-boot-arm with merge
please check

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 3/4] ARM DaVinci: Move common functions to board/davinci/common

2008-08-27 Thread Jean-Christophe PLAGNIOL-VILLARD
On 15:10 Fri 11 Jul , Hugo Villeneuve wrote:
 ARM DaVinci: Move common functions to board/davinci/common.
 
 Signed-off-by: Hugo Villeneuve [EMAIL PROTECTED]
 
 ---
 
  board/davinci/common/Makefile  |   53 
  board/davinci/common/misc.c|  126 
  board/davinci/common/misc.h|   32 +++
  board/davinci/common/psc.c |  117 ++
  board/davinci/common/psc.h |   28 +++
  board/davinci/dv-evm/dv_board.c|  129 --
  board/davinci/schmoogie/dv_board.c |  103 ++-
  board/davinci/sffsdr/sffsdr.c  |  158 
 
  board/davinci/sonata/dv_board.c|  122 +++-
  9 files changed, 404 insertions(+), 464 deletions(-)
 
Applied to u-boot-arm

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] Add support for OMAP5912 and OMAP16xx to usbdcore_omap1510.c

2008-08-27 Thread Jean-Christophe PLAGNIOL-VILLARD
On 18:59 Sat 26 Jul , Hunter, Jon wrote:
 Add support to drivers/usb/usbdcore_omap1510.c for OMAP5912 and OMAP16xx 
 devices.
 
 Signed-off-by: Jon Hunter [EMAIL PROTECTED]
 ---
  drivers/usb/usbdcore_omap1510.c |   27 ---
  1 files changed, 24 insertions(+), 3 deletions(-)
 
 diff --git a/drivers/usb/usbdcore_omap1510.c b/drivers/usb/usbdcore_omap1510.c
 index 84bb936..61c0d3b 100644
 --- a/drivers/usb/usbdcore_omap1510.c
 +++ b/drivers/usb/usbdcore_omap1510.c
 @@ -28,7 +28,7 @@
Applyinf failled

error: patch failed: drivers/usb/usbdcore_omap1510.c:28
error: drivers/usb/usbdcore_omap1510.c: patch does not apply
Using index info to reconstruct a base tree...
error: patch failed: drivers/usb/usbdcore_omap1510.c:1109
error: drivers/usb/usbdcore_omap1510.c: patch does not apply
Did you hand edit your patch?
It does not apply to blobs recorded in its index.
Cannot fall back to three-way merge.

Could you send a V2 rebase on the current tree?

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] Merged serial_pl010.c and serial_pl011.c.

2008-08-24 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:25 Fri 18 Jul , Andreas Engel wrote:
 They only differ in the init function.
 This also adds the missing watchdog support for the PL011.
 
 Signed-off-by: Andreas Engel [EMAIL PROTECTED]
 ---
  drivers/serial/Makefile   |3 +-
  drivers/serial/serial_pl011.c |  161 
 -
  drivers/serial/{serial_pl010.c = serial_pl01x.c} |   83 +--
  drivers/serial/{serial_pl011.h = serial_pl01x.h} |0 
  4 files changed, 69 insertions(+), 178 deletions(-)
  delete mode 100644 drivers/serial/serial_pl011.c
  rename drivers/serial/{serial_pl010.c = serial_pl01x.c} (66%)
  rename drivers/serial/{serial_pl011.h = serial_pl01x.h} (100%)
 
Could you send an update version against current HEAD?

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] Resubmit : [PATCH] Correct ARM Versatile Timer Initialization

2008-08-11 Thread Jean-Christophe PLAGNIOL-VILLARD
On 06:30 Mon 04 Aug , Gururaja Hebbar K R wrote:
 - According to ARM Dual-Timer Module (SP804) TRM (ARM DDI0271), 
  -- Timer Value Register @ TIMER Base + 4 is Read-only. 
  -- Prescale Value (Bits 3-2 of TIMER Control register) 
   can only be one of 00,01,10. 11 is undefined.
 
 Signed-off-by: Gururaja Hebbar [EMAIL PROTECTED]
 ---
  cpu/arm926ejs/versatile/timer.c |3 +--
  1 files changed, 1 insertions(+), 2 deletions(-)
 
 diff --git a/cpu/arm926ejs/versatile/timer.c b/cpu/arm926ejs/versatile/timer.c
 index 32872d2..9659b67 100644
 --- a/cpu/arm926ejs/versatile/timer.c
 +++ b/cpu/arm926ejs/versatile/timer.c
 @@ -50,8 +50,7 @@ static ulong lastdec;
  int timer_init (void)
  {
   *(volatile ulong *)(CFG_TIMERBASE + 0) = CFG_TIMER_RELOAD;  /* 
 TimerLoad */
 - *(volatile ulong *)(CFG_TIMERBASE + 4) = CFG_TIMER_RELOAD;  /* 
 TimerValue */
 - *(volatile ulong *)(CFG_TIMERBASE + 8) = 0x8C;
 + *(volatile ulong *)(CFG_TIMERBASE + 8) = 0x80;

according to datasheet for the register TimerXControl

we are supposed to not modify the bits [31:8] and [4]

so we are suppose to read the register and modify only the others
register.

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH v2 1/2] i.MX31: Fix IOMUX related typos

2008-08-11 Thread Jean-Christophe PLAGNIOL-VILLARD
On 21:43 Sun 03 Aug , Magnus Lilja wrote:
 Correct the names of some IOMUX macros.
 
 Signed-off-by: Magnus Lilja [EMAIL PROTECTED]
 ---
 No changes from first version.
 
  board/imx31_litekit/imx31_litekit.c   |2 +-
  board/imx31_phycore/imx31_phycore.c   |4 ++--
  board/mx31ads/mx31ads.c   |2 +-
  include/asm-arm/arch-mx31/mx31-regs.h |4 ++--
  4 files changed, 6 insertions(+), 6 deletions(-)
 
applied to u-boot-arm

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 3/7 v6] ARM: Add arm1176 core with S3C6400 SoC

2008-08-09 Thread Jean-Christophe PLAGNIOL-VILLARD
 +
 +void dcache_disable (void)
 +{
 + ulong reg;
 +
 + reg = read_p15_c1 ();
 + cp_delay ();
 + reg = ~C1_DC;
 + write_p15_c1 (reg);
why not  as the other implementation?
 + write_p15_c1 (reg  ~C1_DC);
 +}
 +
 +int dcache_status (void)
 +{
 + return (read_p15_c1 ()  C1_DC) != 0;
 +}
 +
 +/* flush I/D-cache */
 +static void cache_flush (void)
 +{
 + /* invalidate both caches and flush btb */
 + asm (mcr p15, 0, %0, c7, c7, 0: :r (0));
 + /* mem barrier to sync things */
 + asm (mcr p15, 0, %0, c7, c10, 4: :r (0));
 +}
 +  * The timer is set to wrap after 100s, at 66MHz this obviously
 +  * happens after 10,000,000 ticks. A long variable can thus
 +  * keep values up to 40,000s, i.e., 11 hours. This should be
 +  * enough for most uses:-) Possible optimizations: select a
 +  * binary-friendly frequency, e.g., 1ms / 128. Also calculate
 +  * the prescaler automatically for other PCLK frequencies.
 +  */
 + /* Set timer frequency to 500KHz, at 66MHz we get prescaler=132  255 */
 + timers-TCFG0 = PRESCALER  8;
 + if (timer_load_val == 0) {
 + /*
 +  * for 10 ms clock period @ PCLK with 4 bit divider = 1/2 and
 +  * prescaler = 16. Should be 10390 @33.25MHz and 15625 @ 50 MHz
 +  */
 + timer_load_val = get_PCLK() / PRESCALER * (100 / 4); /* 100s */
 + /*printf(Calculated %lu timer_load_val\n, timer_load_val);*/
please remove if not need
 + timers-TCFG1 = (timers-TCFG1  ~0xf) | 0x2;
 + }
 +
please add some empty line to be more readable
 + /* load value for 10 ms timeout */
 + lastdec = timers-TCNTB4 = timer_load_val;
 + /* auto load, manual update of Timer 4 */
 + timers-TCON = (timers-TCON  ~0x0070) | TCON_4_AUTO |
 + TCON_4_UPDATE;
 + /* auto load, start Timer 4 */
 + timers-TCON = (timers-TCON  ~0x0070) | TCON_4_AUTO | COUNT_4_ON;
 + timestamp = 0;
 +
 + return 0;
 +}
 +
 +/*
 + * timer without interrupts
 + */
 +
 +/*
 + * This function is derived from PowerPC code (read timebase as long long).
 + * On ARM it just returns the timer value.
 + */
 +unsigned long long get_ticks(void)
 +{
 + ulong now = read_timer();
 +
 + if (lastdec = now) {
 + /* normal mode */
 +#define MPLL 1
 +#define EPLL 2
 +
 +/* - 
 */
 +/*
 + * NOTE: This describes the proper use of this file.
 + *
 + * CONFIG_SYS_CLK_FREQ should be defined as the input frequency of the PLL.
 + *
 + * get_FCLK(), get_HCLK(), get_PCLK() and get_UCLK() return the clock of
 + * the specified bus in HZ.
 + */
 +/* - 
 */
 +
 +static ulong get_PLLCLK(int pllreg)
please not uppercase
 +{
 + ulong r, m, p, s;
 +
 + if (pllreg == APLL)
 + r = APLL_CON_REG;
 + else if (pllreg == MPLL)
 + r = MPLL_CON_REG;
 + else if (pllreg == EPLL)
 + r = EPLL_CON0_REG;
 + else
 + hang();
please move to switch implementation
 +
 + m = (r  16)  0x3ff;
 + p = (r  8)  0x3f;
 + s = r  0x7;
 +
 + return m * (CONFIG_SYS_CLK_FREQ / (p * (1  s)));
 +}
 +
 +/* return ARMCORE frequency */
 +ulong get_ARMCLK(void)
please not uppercase
 +{
 + ulong div;
 +
 + div = CLK_DIV0_REG;
 +
 + return get_PLLCLK(APLL) / ((div  0x7) + 1);
 +}
 +
 +/* return FCLK frequency */
 +ulong get_FCLK(void)
please not uppercase
 +{
 + return get_PLLCLK(APLL);
 +}
 +
 +/* return HCLK frequency */
 +ulong get_HCLK(void)
please not uppercase
 +{
 + ulong fclk;
 +
 + uint hclkx2_div = ((CLK_DIV0_REG  9)  0x7) + 1;
 + uint hclk_div = ((CLK_DIV0_REG  8)  0x1) + 1;
 +
 + /*
 +  * Bit 7 exists on s3c6410, and not on s3c6400, it is reserved on
 +  * s3c6400 and is always 0, and it is indeed running in ASYNC mode
 +  */
 + if (OTHERS_REG  0x80)
 + fclk = get_FCLK();  /* SYNC Mode*/
 + else
 + fclk = get_PLLCLK(MPLL);/* ASYNC Mode   */
 +
 + return fclk / (hclk_div * hclkx2_div);
 +}
 +
 +/* return PCLK frequency */
 +ulong get_PCLK(void)
please not uppercase
 +{
 + ulong fclk;
 + uint hclkx2_div = ((CLK_DIV0_REG  9)  0x7) + 1;
 + uint pre_div = ((CLK_DIV0_REG  12)  0xf) + 1;
 +
 + if (OTHERS_REG  0x80)
 + fclk = get_FCLK();  /* SYNC Mode*/
 + else
 + fclk = get_PLLCLK(MPLL);/* ASYNC Mode   */
 +
 + return fclk / (hclkx2_div * pre_div);
 +}
 +
 +/* return UCLK frequency */
 +ulong get_UCLK(void)
please not uppercase
 +{
 + return get_PLLCLK(EPLL);
 +}
 +
 +int print_cpuinfo(void)
 +{
 + printf(\nCPU: [EMAIL PROTECTED], get_ARMCLK() / 100);
 + printf( Fclk = %luMHz, Hclk = %luMHz, Pclk = %luMHz ,
 +get_FCLK() / 100, get_HCLK() / 

Re: [U-Boot-Users] [PATCH 5/7 v6] serial: add S3C64XX serial driver

2008-08-09 Thread Jean-Christophe PLAGNIOL-VILLARD
 + u32 reg;
 + u32 pclk_ratio = get_PCLK() / gd-baudrate;
 + int i;
 +
IMHO it's still obscur
 + /* PCLK / (16 * baudrate) - 1 */
 + reg = pclk_ratio / 16 - 1;
 + /* i = pclk_ratio % 16 */
 + i = pclk_ratio - (reg + 1) * 16;
 +
 + uart-UBRDIV = reg;
 + uart-UDIVSLOT = udivslot[i];
 +
 + for (i = 0; i  100; i++)
 + barrier();
 +}

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 7/7 v6] ARM: Add support for S3C6400 based SMDK6400 board

2008-08-09 Thread Jean-Christophe PLAGNIOL-VILLARD
On 21:42 Wed 06 Aug , Guennadi Liakhovetski wrote:
 SMDK6400 can only boot U-Boot from NAND-flash. This patch adds a nand_spl
 driver for it too. The board can also boot from the NOR flash, but due to
 hardware limitations it can only address 64KiB on it, which is not enough
 for U-Boot. Based on the original sources by Samsung for U-Boot 1.1.6.
 
 Signed-off-by: Guennadi Liakhovetski [EMAIL PROTECTED]
 ---
 
 Changes since v5: adjust the configuration to more precisely desribe NAND 
 ECC layout.
 
  MAKEALL|1 +
  Makefile   |   17 ++
please add your entry in MAINTAINERS
  board/samsung/smdk6400/Makefile|   54 +
  board/samsung/smdk6400/config.mk   |   30 +++
  board/samsung/smdk6400/lowlevel_init.S |  316 
 
  board/samsung/smdk6400/smdk6400.c  |  130 
  board/samsung/smdk6400/u-boot-nand.lds |   62 ++
  include/configs/smdk6400.h |  306 +++
  nand_spl/board/samsung/smdk6400/Makefile   |  106 ++
  nand_spl/board/samsung/smdk6400/config.mk  |   40 
  nand_spl/board/samsung/smdk6400/u-boot.lds |   61 ++
  11 files changed, 1123 insertions(+), 0 deletions(-)
  create mode 100644 board/samsung/smdk6400/Makefile
  create mode 100644 board/samsung/smdk6400/config.mk
  create mode 100644 board/samsung/smdk6400/lowlevel_init.S
  create mode 100644 board/samsung/smdk6400/smdk6400.c
  create mode 100644 board/samsung/smdk6400/u-boot-nand.lds
  create mode 100644 include/configs/smdk6400.h
  create mode 100644 nand_spl/board/samsung/smdk6400/Makefile
  create mode 100644 nand_spl/board/samsung/smdk6400/config.mk
  create mode 100644 nand_spl/board/samsung/smdk6400/u-boot.lds

 +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 +# GNU General Public License for more details.
 +#
 +# You should have received a copy of the GNU General Public License
 +# along with this program; if not, write to the Free Software
 +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 +# MA 02111-1307 USA
 +#
 +
 +include $(TOPDIR)/config.mk
 +
 +LIB  = $(obj)lib$(BOARD).a
 +
 +COBJS:= smdk6400.o
 +SOBJS:= lowlevel_init.o
 +OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS))
 +
 +$(LIB):  $(obj).depend $(OBJS)
 + $(AR) crv $@ $(OBJS)
 +

please keep this Makefile as other new style

ex from atmel board

include $(TOPDIR)/config.mk

LIB = $(obj)lib$(BOARD).a

COBJS-y += at91cap9adk.o
COBJS-y += led.o
COBJS-y += partition.o
COBJS-$(CONFIG_CMD_NAND) += nand.o

SRCS:= $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
OBJS:= $(addprefix $(obj),$(COBJS-y))
SOBJS   := $(addprefix $(obj),$(SOBJS))

$(LIB): $(obj).depend $(OBJS) $(SOBJS)
$(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS)

clean:
rm -f $(SOBJS) $(OBJS)

distclean:  clean
rm -f $(LIB) core *.bak $(obj).depend

#

# defines $(obj).depend target
include $(SRCTREE)/rules.mk

sinclude $(obj).depend

#
 diff --git a/board/samsung/smdk6400/config.mk 
 b/board/samsung/smdk6400/config.mk
 new file mode 100644
 index 000..298d387
 --- /dev/null
 +++ b/board/samsung/smdk6400/config.mk
 @@ -0,0 +1,30 @@
 +#
 +# (C) Copyright 2002
 +# Gary Jennejohn, DENX Software Engineering, [EMAIL PROTECTED]
 +# David Mueller, ELSOFT AG, [EMAIL PROTECTED]
 +#
 +# (C) Copyright 2008
 +# Guennadi Liakhovetki, DENX Software Engineering, [EMAIL PROTECTED]
 +#
 +# SAMSUNG SMDK6400 board with mDirac3 (ARM1176) cpu
 +#
 +# see http://www.samsung.com/ for more information on SAMSUNG
 +
 +# On SMDK6400 we use the 64 MB SDRAM bank at
 +#
 +# 0x5000 to 0x5800
 +#
 +# Linux-Kernel is expected to be at 0x50008000, entry 0x50008000
 +#
 +# we load ourselves to 0x57e0 without MMU
 +# with MMU, load address is changed to 0xc7e0
 +#
 +# download area is 0x5000c000
 +
 +sinclude $(OBJTREE)/board/$(BOARDDIR)/config.tmp
 +
 +ifndef CONFIG_NAND_SPL
 +TEXT_BASE = $(RAM_TEXT)
 +else
 +TEXT_BASE = 0
 +endif
 +check_syncack:
 + ldr r1, [r0, #OTHERS_OFFSET]
 + ldr r2, =0xf00
 + and r1, r1, r2
 + cmp r1, #0xf00
 + bne check_syncack
 +#else/* ASYNC Mode */
please use .rept
 + nop
 + nop
 + nop
 + nop
 + nop
 +
and please be carefull with whitespaces
 index 000..77fd2c8
 --- /dev/null
 +++ b/board/samsung/smdk6400/smdk6400.c
 @@ -0,0 +1,130 @@
 +/*
 +static inline void delay(unsigned long loops)
 +{
 + __asm__ volatile (1:\n subs %0, %1, #1\n
 +   bne 1b
 +   : =r (loops) : 0 (loops));
 +}
 +
 +/*
 + * Miscellaneous platform dependent initialisations
 + */
 +
 +{
 + nand_probe(CFG_NAND_BASE);
 + if (nand_dev_desc[0].ChipID != NAND_ChipID_UNKNOWN)
 + print_size(nand_dev_desc[0].totlen, 

[U-Boot-Users] [PATCH V2] mx31: move freescale's mx31 boards to vendor board dir

2008-08-07 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
remove imx31_phycore which is from phytec
 Makefile   |4 ++--
 board/{ = freescale}/imx31_litekit/Makefile   |0 
 board/{ = freescale}/imx31_litekit/config.mk  |0 
 .../{ = freescale}/imx31_litekit/imx31_litekit.c  |0 
 .../{ = freescale}/imx31_litekit/lowlevel_init.S  |0 
 board/{ = freescale}/imx31_litekit/u-boot.lds |0 
 board/{ = freescale}/mx31ads/Makefile |0 
 board/{ = freescale}/mx31ads/config.mk|0 
 board/{ = freescale}/mx31ads/lowlevel_init.S  |0 
 board/{ = freescale}/mx31ads/mx31ads.c|0 
 board/{ = freescale}/mx31ads/u-boot.lds   |   10 +-
 11 files changed, 7 insertions(+), 7 deletions(-)
 rename board/{ = freescale}/imx31_litekit/Makefile (100%)
 rename board/{ = freescale}/imx31_litekit/config.mk (100%)
 rename board/{ = freescale}/imx31_litekit/imx31_litekit.c (100%)
 rename board/{ = freescale}/imx31_litekit/lowlevel_init.S (100%)
 rename board/{ = freescale}/imx31_litekit/u-boot.lds (100%)
 rename board/{ = freescale}/mx31ads/Makefile (100%)
 rename board/{ = freescale}/mx31ads/config.mk (100%)
 rename board/{ = freescale}/mx31ads/lowlevel_init.S (100%)
 rename board/{ = freescale}/mx31ads/mx31ads.c (100%)
 rename board/{ = freescale}/mx31ads/u-boot.lds (90%)

diff --git a/Makefile b/Makefile
index 3179c67..39c65f5 100644
--- a/Makefile
+++ b/Makefile
@@ -2666,13 +2666,13 @@ apollon_config  : unconfig
@echo CONFIG_ONENAND_U_BOOT = y  $(obj)include/config.mk
 
 imx31_litekit_config   : unconfig
-   @$(MKCONFIG) $(@:_config=) arm arm1136 imx31_litekit NULL mx31
+   @$(MKCONFIG) $(@:_config=) arm arm1136 imx31_litekit freescale mx31
 
 imx31_phycore_config   : unconfig
@$(MKCONFIG) $(@:_config=) arm arm1136 imx31_phycore NULL mx31
 
 mx31ads_config : unconfig
-   @$(MKCONFIG) $(@:_config=) arm arm1136 mx31ads NULL mx31
+   @$(MKCONFIG) $(@:_config=) arm arm1136 mx31ads freescale mx31
 
 omap2420h4_config  : unconfig
@$(MKCONFIG) $(@:_config=) arm arm1136 omap2420h4 NULL omap24xx
diff --git a/board/imx31_litekit/Makefile 
b/board/freescale/imx31_litekit/Makefile
similarity index 100%
rename from board/imx31_litekit/Makefile
rename to board/freescale/imx31_litekit/Makefile
diff --git a/board/imx31_litekit/config.mk 
b/board/freescale/imx31_litekit/config.mk
similarity index 100%
rename from board/imx31_litekit/config.mk
rename to board/freescale/imx31_litekit/config.mk
diff --git a/board/imx31_litekit/imx31_litekit.c 
b/board/freescale/imx31_litekit/imx31_litekit.c
similarity index 100%
rename from board/imx31_litekit/imx31_litekit.c
rename to board/freescale/imx31_litekit/imx31_litekit.c
diff --git a/board/imx31_litekit/lowlevel_init.S 
b/board/freescale/imx31_litekit/lowlevel_init.S
similarity index 100%
rename from board/imx31_litekit/lowlevel_init.S
rename to board/freescale/imx31_litekit/lowlevel_init.S
diff --git a/board/imx31_litekit/u-boot.lds 
b/board/freescale/imx31_litekit/u-boot.lds
similarity index 100%
rename from board/imx31_litekit/u-boot.lds
rename to board/freescale/imx31_litekit/u-boot.lds
diff --git a/board/mx31ads/Makefile b/board/freescale/mx31ads/Makefile
similarity index 100%
rename from board/mx31ads/Makefile
rename to board/freescale/mx31ads/Makefile
diff --git a/board/mx31ads/config.mk b/board/freescale/mx31ads/config.mk
similarity index 100%
rename from board/mx31ads/config.mk
rename to board/freescale/mx31ads/config.mk
diff --git a/board/mx31ads/lowlevel_init.S 
b/board/freescale/mx31ads/lowlevel_init.S
similarity index 100%
rename from board/mx31ads/lowlevel_init.S
rename to board/freescale/mx31ads/lowlevel_init.S
diff --git a/board/mx31ads/mx31ads.c b/board/freescale/mx31ads/mx31ads.c
similarity index 100%
rename from board/mx31ads/mx31ads.c
rename to board/freescale/mx31ads/mx31ads.c
diff --git a/board/mx31ads/u-boot.lds b/board/freescale/mx31ads/u-boot.lds
similarity index 90%
rename from board/mx31ads/u-boot.lds
rename to board/freescale/mx31ads/u-boot.lds
index 49713d4..c379460 100644
--- a/board/mx31ads/u-boot.lds
+++ b/board/freescale/mx31ads/u-boot.lds
@@ -37,11 +37,11 @@ SECTIONS
  /* WARNING - the following is hand-optimized to fit within*/
  /* the sector layout of our flash chips!  XXX FIXME XXX   */
 
- cpu/arm1136/start.o   (.text)
- board/mx31ads/libmx31ads.a(.text)
- lib_arm/libarm.a  (.text)
- net/libnet.a  (.text)
- drivers/mtd/libmtd.a  (.text)
+ cpu/arm1136/start.o   (.text)
+ board/freescale/mx31ads/libmx31ads.a  (.text)
+ lib_arm/libarm.a  (.text)
+ net/libnet.a  (.text)
+ drivers/mtd/libmtd.a  (.text)
 
  . = DEFINED(env_offset

Re: [U-Boot-Users] [PATCH 3/7 v6] ARM: Add arm1176 core with S3C6400 SoC

2008-08-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:03 Thu 07 Aug , Jens Gehrlein wrote:
 Wolfgang Denk schrieb:
  In message [EMAIL PROTECTED] you wrote:
  That's what we've been doing so far:
 
- ls -l include/s3c*
-rw-rw-r-- 1 wd wd 21763 Dec  9  2007 include/s3c2400.h
-rw-rw-r-- 1 wd wd  7629 Dec  9  2007 include/s3c2410.h
-rw-rw-r-- 1 wd wd 38129 Oct 13  2007 include/s3c24x0.h
  Sorry, don't understand. So is it okay, that these files reside in the 
  include directory or not?
  
  Unless you want to submit a clenaup patch for many existing
  processors, yes.
  
  What is your suggestion instead?
 
 It was just a question to read your opinion. Personally, I can live with 
 it. I thought, CPU specific header files had to go to the 
 include/asm-arch/arch-cpu directory.

Currently the kernel start move to move it to
include/arch/asm

I'll prefer to use this

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH V3] mx31: move freescale's mx31 board to vendor board dir

2008-08-07 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
remove miss match freescale board

Freescale Zoom™ i.MX31 LITEKIT

 Makefile  |2 +-
 board/{ = freescale}/mx31ads/Makefile|0 
 board/{ = freescale}/mx31ads/config.mk   |0 
 board/{ = freescale}/mx31ads/lowlevel_init.S |0 
 board/{ = freescale}/mx31ads/mx31ads.c   |0 
 board/{ = freescale}/mx31ads/u-boot.lds  |   10 +-
 6 files changed, 6 insertions(+), 6 deletions(-)
 rename board/{ = freescale}/mx31ads/Makefile (100%)
 rename board/{ = freescale}/mx31ads/config.mk (100%)
 rename board/{ = freescale}/mx31ads/lowlevel_init.S (100%)
 rename board/{ = freescale}/mx31ads/mx31ads.c (100%)
 rename board/{ = freescale}/mx31ads/u-boot.lds (90%)

diff --git a/Makefile b/Makefile
index cccd544..c57f21a 100644
--- a/Makefile
+++ b/Makefile
@@ -2672,7 +2672,7 @@ imx31_phycore_config  : unconfig
@$(MKCONFIG) $(@:_config=) arm arm1136 imx31_phycore NULL mx31
 
 mx31ads_config : unconfig
-   @$(MKCONFIG) $(@:_config=) arm arm1136 mx31ads NULL mx31
+   @$(MKCONFIG) $(@:_config=) arm arm1136 mx31ads freescale mx31
 
 omap2420h4_config  : unconfig
@$(MKCONFIG) $(@:_config=) arm arm1136 omap2420h4 NULL omap24xx
diff --git a/board/mx31ads/Makefile b/board/freescale/mx31ads/Makefile
similarity index 100%
rename from board/mx31ads/Makefile
rename to board/freescale/mx31ads/Makefile
diff --git a/board/mx31ads/config.mk b/board/freescale/mx31ads/config.mk
similarity index 100%
rename from board/mx31ads/config.mk
rename to board/freescale/mx31ads/config.mk
diff --git a/board/mx31ads/lowlevel_init.S 
b/board/freescale/mx31ads/lowlevel_init.S
similarity index 100%
rename from board/mx31ads/lowlevel_init.S
rename to board/freescale/mx31ads/lowlevel_init.S
diff --git a/board/mx31ads/mx31ads.c b/board/freescale/mx31ads/mx31ads.c
similarity index 100%
rename from board/mx31ads/mx31ads.c
rename to board/freescale/mx31ads/mx31ads.c
diff --git a/board/mx31ads/u-boot.lds b/board/freescale/mx31ads/u-boot.lds
similarity index 90%
rename from board/mx31ads/u-boot.lds
rename to board/freescale/mx31ads/u-boot.lds
index 49713d4..c379460 100644
--- a/board/mx31ads/u-boot.lds
+++ b/board/freescale/mx31ads/u-boot.lds
@@ -37,11 +37,11 @@ SECTIONS
  /* WARNING - the following is hand-optimized to fit within*/
  /* the sector layout of our flash chips!  XXX FIXME XXX   */
 
- cpu/arm1136/start.o   (.text)
- board/mx31ads/libmx31ads.a(.text)
- lib_arm/libarm.a  (.text)
- net/libnet.a  (.text)
- drivers/mtd/libmtd.a  (.text)
+ cpu/arm1136/start.o   (.text)
+ board/freescale/mx31ads/libmx31ads.a  (.text)
+ lib_arm/libarm.a  (.text)
+ net/libnet.a  (.text)
+ drivers/mtd/libmtd.a  (.text)
 
  . = DEFINED(env_offset) ? env_offset : .;
  common/environment.o(.text)
-- 
1.5.6.2


-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] *** PROBABLY SPAM *** [PATCH] common/cmd_load.c - Minor Code Style update code cleanup

2008-08-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:13 Thu 07 Aug , Gururaja Hebbar K R wrote:
 - os_data_header Variable is a carry over feature
 unused. So removed all instance of this variable
  - Minor Code Style Update
 
 
 Signed-off-by: Gururaja Hebbar [EMAIL PROTECTED]

os_data_head is never used anywhere

Ack-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 4/7 v6] USB: Add support for OHCI controller on S3C6400

2008-08-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 17:56 Thu 07 Aug , Markus Klotzbücher wrote:
 Guennadi Liakhovetski [EMAIL PROTECTED] writes:
 
  Notice: USB on S3C6400 currently works _only_ with switched off MMU. One 
  could
  try to enable the MMU, but map addresses 1-to-1, and disable data cache, 
  then
  it should work too and we could still profit from instruction cache.
 
  Signed-off-by: Guennadi Liakhovetski [EMAIL PROTECTED]
 Acked-by: Markus Klotzbuecher [EMAIL PROTECTED]
 
 I can't apply this to the USB custodian repository without the rest of
 the patchset being applied. I'm also fine if the ARM custodian picks
 this one up.
I'll do.

Thanks for the Ack

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH] mx31: move freescale's mx31 boards to vendor board dir

2008-08-06 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
 Makefile   |6 +++---
 board/{ = freescale}/imx31_litekit/Makefile   |0 
 board/{ = freescale}/imx31_litekit/config.mk  |0 
 .../{ = freescale}/imx31_litekit/imx31_litekit.c  |0 
 .../{ = freescale}/imx31_litekit/lowlevel_init.S  |0 
 board/{ = freescale}/imx31_litekit/u-boot.lds |0 
 board/{ = freescale}/imx31_phycore/Makefile   |0 
 board/{ = freescale}/imx31_phycore/config.mk  |0 
 .../{ = freescale}/imx31_phycore/imx31_phycore.c  |0 
 .../{ = freescale}/imx31_phycore/lowlevel_init.S  |0 
 board/{ = freescale}/imx31_phycore/u-boot.lds |0 
 board/{ = freescale}/mx31ads/Makefile |0 
 board/{ = freescale}/mx31ads/config.mk|0 
 board/{ = freescale}/mx31ads/lowlevel_init.S  |0 
 board/{ = freescale}/mx31ads/mx31ads.c|0 
 board/{ = freescale}/mx31ads/u-boot.lds   |   10 +-
 16 files changed, 8 insertions(+), 8 deletions(-)
 rename board/{ = freescale}/imx31_litekit/Makefile (100%)
 rename board/{ = freescale}/imx31_litekit/config.mk (100%)
 rename board/{ = freescale}/imx31_litekit/imx31_litekit.c (100%)
 rename board/{ = freescale}/imx31_litekit/lowlevel_init.S (100%)
 rename board/{ = freescale}/imx31_litekit/u-boot.lds (100%)
 rename board/{ = freescale}/imx31_phycore/Makefile (100%)
 rename board/{ = freescale}/imx31_phycore/config.mk (100%)
 rename board/{ = freescale}/imx31_phycore/imx31_phycore.c (100%)
 rename board/{ = freescale}/imx31_phycore/lowlevel_init.S (100%)
 rename board/{ = freescale}/imx31_phycore/u-boot.lds (100%)
 rename board/{ = freescale}/mx31ads/Makefile (100%)
 rename board/{ = freescale}/mx31ads/config.mk (100%)
 rename board/{ = freescale}/mx31ads/lowlevel_init.S (100%)
 rename board/{ = freescale}/mx31ads/mx31ads.c (100%)
 rename board/{ = freescale}/mx31ads/u-boot.lds (90%)

diff --git a/Makefile b/Makefile
index 3179c67..30d02b0 100644
--- a/Makefile
+++ b/Makefile
@@ -2666,13 +2666,13 @@ apollon_config  : unconfig
@echo CONFIG_ONENAND_U_BOOT = y  $(obj)include/config.mk
 
 imx31_litekit_config   : unconfig
-   @$(MKCONFIG) $(@:_config=) arm arm1136 imx31_litekit NULL mx31
+   @$(MKCONFIG) $(@:_config=) arm arm1136 imx31_litekit freescale mx31
 
 imx31_phycore_config   : unconfig
-   @$(MKCONFIG) $(@:_config=) arm arm1136 imx31_phycore NULL mx31
+   @$(MKCONFIG) $(@:_config=) arm arm1136 imx31_phycore freescale mx31
 
 mx31ads_config : unconfig
-   @$(MKCONFIG) $(@:_config=) arm arm1136 mx31ads NULL mx31
+   @$(MKCONFIG) $(@:_config=) arm arm1136 mx31ads freescale mx31
 
 omap2420h4_config  : unconfig
@$(MKCONFIG) $(@:_config=) arm arm1136 omap2420h4 NULL omap24xx
diff --git a/board/imx31_litekit/Makefile 
b/board/freescale/imx31_litekit/Makefile
similarity index 100%
rename from board/imx31_litekit/Makefile
rename to board/freescale/imx31_litekit/Makefile
diff --git a/board/imx31_litekit/config.mk 
b/board/freescale/imx31_litekit/config.mk
similarity index 100%
rename from board/imx31_litekit/config.mk
rename to board/freescale/imx31_litekit/config.mk
diff --git a/board/imx31_litekit/imx31_litekit.c 
b/board/freescale/imx31_litekit/imx31_litekit.c
similarity index 100%
rename from board/imx31_litekit/imx31_litekit.c
rename to board/freescale/imx31_litekit/imx31_litekit.c
diff --git a/board/imx31_litekit/lowlevel_init.S 
b/board/freescale/imx31_litekit/lowlevel_init.S
similarity index 100%
rename from board/imx31_litekit/lowlevel_init.S
rename to board/freescale/imx31_litekit/lowlevel_init.S
diff --git a/board/imx31_litekit/u-boot.lds 
b/board/freescale/imx31_litekit/u-boot.lds
similarity index 100%
rename from board/imx31_litekit/u-boot.lds
rename to board/freescale/imx31_litekit/u-boot.lds
diff --git a/board/imx31_phycore/Makefile 
b/board/freescale/imx31_phycore/Makefile
similarity index 100%
rename from board/imx31_phycore/Makefile
rename to board/freescale/imx31_phycore/Makefile
diff --git a/board/imx31_phycore/config.mk 
b/board/freescale/imx31_phycore/config.mk
similarity index 100%
rename from board/imx31_phycore/config.mk
rename to board/freescale/imx31_phycore/config.mk
diff --git a/board/imx31_phycore/imx31_phycore.c 
b/board/freescale/imx31_phycore/imx31_phycore.c
similarity index 100%
rename from board/imx31_phycore/imx31_phycore.c
rename to board/freescale/imx31_phycore/imx31_phycore.c
diff --git a/board/imx31_phycore/lowlevel_init.S 
b/board/freescale/imx31_phycore/lowlevel_init.S
similarity index 100%
rename from board/imx31_phycore/lowlevel_init.S
rename to board/freescale/imx31_phycore/lowlevel_init.S
diff --git a/board/imx31_phycore/u-boot.lds 
b/board/freescale/imx31_phycore/u-boot.lds
similarity index 100%
rename from board/imx31_phycore/u-boot.lds
rename to board/freescale/imx31_phycore/u-boot.lds
diff --git a/board/mx31ads/Makefile b/board/freescale

Re: [U-Boot-Users] [PATCH RFC 5/5] i.MX31: Add basic support for Freescale's i.MX31 PDK board.

2008-08-06 Thread Jean-Christophe PLAGNIOL-VILLARD
On 14:19 Wed 06 Aug , Magnus Lilja wrote:
 Add support for NAND and ethernet on the Freescale i.MX31 PDK (a.k.a.
 3DS) board.
 
 Booting from NAND is not supported yet so U-boot relies on some other
 initial boot loader to set up SDRAM and clocks and copying U-boot to SDRAM.
 
 Signed-off-by: Magnus Lilja [EMAIL PROTECTED]
 ---
  MAKEALL   |1 +
  Makefile  |3 +
  board/mx31pdk/Makefile|   53 
  board/mx31pdk/config.mk   |1 +
  board/mx31pdk/lowlevel_init.S |   30 +++
  board/mx31pdk/mx31pdk.c   |   76 +
  board/mx31pdk/u-boot.lds  |   59 +
  include/configs/mx31pdk.h |  186 
 +
  8 files changed, 409 insertions(+), 0 deletions(-)
 
 diff --git a/MAKEALL b/MAKEALL
 index ee83cca..ac2d3a8 100755
 --- a/MAKEALL
 +++ b/MAKEALL
 @@ -515,6 +515,7 @@ LIST_ARM11=  \
   imx31_litekit   \
   imx31_phycore   \
   mx31ads \
 + mx31pdk \
  
  
  #
 diff --git a/Makefile b/Makefile
 index cb8c0f5..40bd9e1 100644
 --- a/Makefile
 +++ b/Makefile
 @@ -2683,6 +2683,9 @@ imx31_phycore_config: unconfig
  mx31ads_config   : unconfig
   @$(MKCONFIG) $(@:_config=) arm arm1136 mx31ads NULL mx31
  
 +mx31pdk_config   : unconfig
 + @$(MKCONFIG) $(@:_config=) arm arm1136 mx31pdk NULL mx31
 +
I've just send a patch to move all freescale's mx31 board to vendor dir

so please replace with 
+mx31pdk_config : unconfig
+   @$(MKCONFIG) $(@:_config=) arm arm1136 mx31pdk freescale mx31
+
  omap2420h4_config: unconfig
   @$(MKCONFIG) $(@:_config=) arm arm1136 omap2420h4 NULL omap24xx
  
 diff --git a/board/mx31pdk/Makefile b/board/mx31pdk/Makefile
and move your board to 
board/freescale/mx31pdk/

 diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h
 new file mode 100644
 index 000..d1f44ab
 --- /dev/null
 +++ b/include/configs/mx31pdk.h
 @@ -0,0 +1,186 @@
 +/*
 + * (C) Copyright 2008 Magnus Lilja [EMAIL PROTECTED]
 + *
 + * (C) Copyright 2004
 + * Texas Instruments.
 + * Richard Woodruff [EMAIL PROTECTED]
 + * Kshitij Gupta [EMAIL PROTECTED]
 + *
 + * Configuration settings for the Freescale i.MX31 PDK board.
 + *
 + * See file CREDITS for list of people who contributed to this
 + * project.
 + *
 + * This program is free software; you can redistribute it and/or
 + * modify it under the terms of the GNU General Public License as
 + * published by the Free Software Foundation; either version 2 of
 + * the License, or (at your option) any later version.
 + *
 + * This program is distributed in the hope that it will be useful,
 + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.   See the
 + * GNU General Public License for more details.
 + *
 + * You should have received a copy of the GNU General Public License
 + * along with this program; if not, write to the Free Software
 + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 + * MA 02111-1307 USA
 + */
 +
 +#ifndef __CONFIG_H
 +#define __CONFIG_H
 +
 +#include asm/arch/mx31-regs.h
 +
 + /* High Level Configuration Options */
 +#define CONFIG_ARM1136   1/* This is an arm1136 CPU core */
 +#define CONFIG_MX31  1/* in a mx31 */
 +#define CONFIG_MX31_HCLK_FREQ2600
 +#define CONFIG_MX31_CLK3232768
 +
 +#define CONFIG_MX31_NAND 1
 +
 +#define CONFIG_DISPLAY_CPUINFO
 +#define CONFIG_DISPLAY_BOARDINFO
 +
 +/* Temporarily disabled */
 +#if 0
 +#define CONFIG_OF_LIBFDT 1
 +#define CONFIG_FIT   1
 +#define CONFIG_FIT_VERBOSE   1
 +#endif
so please remove
 +
 +#define CONFIG_CMDLINE_TAG   1/* enable passing of ATAGs */
 +#define CONFIG_SETUP_MEMORY_TAGS 1
 +#define CONFIG_INITRD_TAG1
 +
 +/*
 + * Size of malloc() pool
 + * An extra 128kbyte is needed for the NAND Bad Block table.
 + */
 +#define CFG_MALLOC_LEN   (CFG_ENV_SIZE + 128 * 1024 + 128 * 1024)
 +#define CFG_GBL_DATA_SIZE128  /* bytes reserved for initial data */
 +
 +/*
 + * Hardware drivers
 + */
 +
 +#define CONFIG_MX31_UART 1
 +#define CFG_MX31_UART1   1
 +
 +#define CONFIG_HARD_SPI  1
 +#define CONFIG_MXC_SPI   1
 +#define CONFIG_MXC_SPI_IFACE 1
 +
 +#define CONFIG_RTC_MC13783   1
 +
 +/* allow to overwrite serial and ethaddr */
 +#define CONFIG_ENV_OVERWRITE
 +#define CONFIG_CONS_INDEX1
 +#define CONFIG_BAUDRATE  115200
 +#define CFG_BAUDRATE_TABLE   {9600, 19200, 38400, 57600, 115200}
 +
 +/***
 + * Command definition
 + ***/
 +
 +#include config_cmd_default.h
 +
 +/* No support for NAND boot for i.MX31 PDK 

[U-Boot-Users] [PATCH] mvbc_p: Fix problem with '#if (CONFIG_CMD_KGDB)'

2008-08-02 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
 include/configs/MVBC_P.h |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/configs/MVBC_P.h b/include/configs/MVBC_P.h
index 48f427e..8c8a445 100644
--- a/include/configs/MVBC_P.h
+++ b/include/configs/MVBC_P.h
@@ -40,7 +40,7 @@
 #define CONFIG_MISC_INIT_R 1
 
 #define CFG_CACHELINE_SIZE 32
-#if (CONFIG_CMD_KGDB)
+#ifdef (CONFIG_CMD_KGDB)
 #define CFG_CACHELINE_SHIFT5
 #endif
 
@@ -268,7 +268,7 @@
 #define CFG_PROMPT_HUSH_PS2 
 #undef CFG_LONGHELP
 #define CFG_PROMPT = 
-#if (CONFIG_CMD_KGDB)
+#ifdef (CONFIG_CMD_KGDB)
 #define CFG_CBSIZE 1024
 #else
 #define CFG_CBSIZE 256
-- 
1.5.6.2


-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH] nios2: fix phys_addr_t and phys_size_t support

2008-08-02 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
 cpu/nios2/interrupts.c|1 +
 include/asm-nios2/types.h |3 +++
 2 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/cpu/nios2/interrupts.c b/cpu/nios2/interrupts.c
index aeb5b65..ec5db31 100644
--- a/cpu/nios2/interrupts.c
+++ b/cpu/nios2/interrupts.c
@@ -27,6 +27,7 @@
 
 #include nios2.h
 #include nios2-io.h
+#include asm/types.h
 #include asm/io.h
 #include asm/ptrace.h
 #include common.h
diff --git a/include/asm-nios2/types.h b/include/asm-nios2/types.h
index f13d8bd..ea859c0 100644
--- a/include/asm-nios2/types.h
+++ b/include/asm-nios2/types.h
@@ -52,6 +52,9 @@ typedef unsigned long long u64;
 /* Dma addresses are 32-bits wide.  */
 
 typedef u32 dma_addr_t;
+
+typedef unsigned long phys_addr_t;
+typedef unsigned long phys_size_t;
 #endif /* __KERNEL__ */
 
 #endif /* __ASM_NIOS2_TYPES_H */
-- 
1.5.6.2


-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH] Fix remaining build issues with MPC8xx FADS boards.

2008-08-02 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
 include/configs/FADS860T.h  |2 +-
 include/configs/MPC86xADS.h |2 +-
 include/configs/MPC885ADS.h |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/configs/FADS860T.h b/include/configs/FADS860T.h
index 18de6b0..38295c4 100644
--- a/include/configs/FADS860T.h
+++ b/include/configs/FADS860T.h
@@ -38,7 +38,7 @@
 #define CONFIG_DRAM_50MHZ  1
 #define CONFIG_SDRAM_50MHZ  1
 
-#include fads.h
+#include ../../board/fads/fads.h
 
 #ifdef USE_REAL_FLASH_VALUES
 /*
diff --git a/include/configs/MPC86xADS.h b/include/configs/MPC86xADS.h
index e0e8554..233a8d1 100644
--- a/include/configs/MPC86xADS.h
+++ b/include/configs/MPC86xADS.h
@@ -41,7 +41,7 @@
 #define CONFIG_DRAM_50MHZ   1
 #define CONFIG_SDRAM_50MHZ  1
 
-#include fads.h
+#include ../../board/fads/fads.h
 
 #define CFG_OR5_PRELIM 0x8110  /* 64Kbyte address space */
 #define CFG_BR5_PRELIM (CFG_PHYDEV_ADDR | BR_PS_8 | BR_V)
diff --git a/include/configs/MPC885ADS.h b/include/configs/MPC885ADS.h
index 1867c5b..f4d1842 100644
--- a/include/configs/MPC885ADS.h
+++ b/include/configs/MPC885ADS.h
@@ -27,7 +27,7 @@
 
 #define CONFIG_SDRAM_50MHZ  1
 
-#include fads.h
+#include ../../board/fads/fads.h
 
 #define CFG_OR5_PRELIM 0x8110  /* 64Kbyte address space */
 #define CFG_BR5_PRELIM (CFG_PHYDEV_ADDR | BR_PS_8 | BR_V)
-- 
1.5.6.2


-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH] nios2/sysid: fix printf warning

2008-08-02 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
 cpu/nios2/sysid.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/cpu/nios2/sysid.c b/cpu/nios2/sysid.c
index b5a2959..697ed03 100644
--- a/cpu/nios2/sysid.c
+++ b/cpu/nios2/sysid.c
@@ -40,7 +40,7 @@ void display_sysid (void)
stamp = readl (sysid-timestamp);
localtime_r (stamp, t);
asctime_r (t, asc);
-   printf (SYSID : %08x, %s, readl (sysid-id), asc);
+   printf (SYSID : %08lx, %s, readl (sysid-id), asc);
 
 }
 
-- 
1.5.6.2


-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH] drivers/serial: Move conditional compilation to Makefile for CONFIG_* macros

2008-08-02 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
Need to build nios2

I've prefer to move conditional compilation to Makefile instead of
you move an include in xuartlite. Which is not related to nios2.

I've choose to only move the CONFIG_ and merge the CFG_ in a second step during 
the next merge
 drivers/serial/Makefile   |   12 ++--
 drivers/serial/atmel_usart.c  |3 ---
 drivers/serial/mcfuart.c  |3 ---
 drivers/serial/s3c4510b_uart.c|4 
 drivers/serial/serial_max3100.c   |4 
 drivers/serial/serial_xuartlite.c |4 
 drivers/serial/usbtty.c   |5 -
 7 files changed, 6 insertions(+), 29 deletions(-)

diff --git a/drivers/serial/Makefile b/drivers/serial/Makefile
index c9e797e..de6fbab 100644
--- a/drivers/serial/Makefile
+++ b/drivers/serial/Makefile
@@ -25,18 +25,18 @@ include $(TOPDIR)/config.mk
 
 LIB:= $(obj)libserial.a
 
-COBJS-y += atmel_usart.o
-COBJS-y += mcfuart.o
+COBJS-$(CONFIG_ATMEL_USART) += atmel_usart.o
+COBJS-$(CONFIG_MCFUART) += mcfuart.o
 COBJS-y += ns9750_serial.o
 COBJS-y += ns16550.o
-COBJS-y += s3c4510b_uart.o
+COBJS-$(CONFIG_DRIVER_S3C4510_UART) += s3c4510b_uart.o
 COBJS-y += serial.o
-COBJS-y += serial_max3100.o
+COBJS-$(CONFIG_MAX3100_SERIAL) += serial_max3100.o
 COBJS-y += serial_pl010.o
 COBJS-y += serial_pl011.o
-COBJS-y += serial_xuartlite.o
+COBJS-$(CONFIG_XILINX_UARTLITE) += serial_xuartlite.o
 COBJS-y += serial_sh.o
-COBJS-y += usbtty.o
+COBJS-$(CONFIG_USB_TTY) += usbtty.o
 
 COBJS  := $(COBJS-y)
 SRCS   := $(COBJS:.o=.c)
diff --git a/drivers/serial/atmel_usart.c b/drivers/serial/atmel_usart.c
index f35b997..f3b146c 100644
--- a/drivers/serial/atmel_usart.c
+++ b/drivers/serial/atmel_usart.c
@@ -17,7 +17,6 @@
  */
 #include common.h
 
-#ifdef CONFIG_ATMEL_USART
 #include asm/io.h
 #include asm/arch/clk.h
 #include asm/arch/memory-map.h
@@ -96,5 +95,3 @@ int serial_tstc(void)
 {
return (usart3_readl(CSR)  USART3_BIT(RXRDY)) != 0;
 }
-
-#endif /* CONFIG_ATMEL_USART */
diff --git a/drivers/serial/mcfuart.c b/drivers/serial/mcfuart.c
index 5eb4f45..a1fcd05 100644
--- a/drivers/serial/mcfuart.c
+++ b/drivers/serial/mcfuart.c
@@ -29,8 +29,6 @@
 
 #include common.h
 
-#ifdef CONFIG_MCFUART
-
 #include asm/immap.h
 #include asm/uart.h
 
@@ -130,4 +128,3 @@ void serial_setbrg(void)
 
uart-ucr = UART_UCR_RX_ENABLED | UART_UCR_TX_ENABLED;
 }
-#endif /* CONFIG_MCFUART */
diff --git a/drivers/serial/s3c4510b_uart.c b/drivers/serial/s3c4510b_uart.c
index ddcd591..aa378e1 100644
--- a/drivers/serial/s3c4510b_uart.c
+++ b/drivers/serial/s3c4510b_uart.c
@@ -45,8 +45,6 @@
 
 #include common.h
 
-#ifdef CONFIG_DRIVER_S3C4510_UART
-
 #include asm/hardware.h
 #include s3c4510b_uart.h
 
@@ -212,5 +210,3 @@ void serial_puts (const char *s)
uart-m_ctrl.bf.sendBreak = 0;
 
 }
-
-#endif
diff --git a/drivers/serial/serial_max3100.c b/drivers/serial/serial_max3100.c
index 0611fc1..4abc271 100644
--- a/drivers/serial/serial_max3100.c
+++ b/drivers/serial/serial_max3100.c
@@ -26,8 +26,6 @@
 #include common.h
 #include watchdog.h
 
-#ifdef CONFIG_MAX3100_SERIAL
-
 DECLARE_GLOBAL_DATA_PTR;
 
 /**/
@@ -298,5 +296,3 @@ int serial_tstc(void)
 void serial_setbrg(void)
 {
 }
-
-#endif
diff --git a/drivers/serial/serial_xuartlite.c 
b/drivers/serial/serial_xuartlite.c
index 74546ce..00d0eaa 100644
--- a/drivers/serial/serial_xuartlite.c
+++ b/drivers/serial/serial_xuartlite.c
@@ -27,8 +27,6 @@
 #include config.h
 #include asm/io.h
 
-#ifdef CONFIG_XILINX_UARTLITE
-
 #define RX_FIFO_OFFSET 0 /* receive FIFO, read only */
 #define TX_FIFO_OFFSET 4 /* transmit FIFO, write only */
 #define STATUS_REG_OFFSET  8 /* status register, read only */
@@ -77,5 +75,3 @@ int serial_tstc(void)
 {
return (in_be32((u32 *) UARTLITE_STATUS)  SR_RX_FIFO_VALID_DATA);
 }
-
-#endif /* CONFIG_MICROBLZE */
diff --git a/drivers/serial/usbtty.c b/drivers/serial/usbtty.c
index 2bc5c3c..e738c56 100644
--- a/drivers/serial/usbtty.c
+++ b/drivers/serial/usbtty.c
@@ -23,8 +23,6 @@
 
 #include common.h
 
-#ifdef CONFIG_USB_TTY
-
 #include circbuf.h
 #include devices.h
 #include usbtty.h
@@ -1007,6 +1005,3 @@ void usbtty_poll (void)
udc_irq();
 
 }
-
-
-#endif
-- 
1.5.6.2


-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH] qemu_mips: update README to follow qemu update about default machine

2008-08-01 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
 doc/README.qemu_mips |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/doc/README.qemu_mips b/doc/README.qemu_mips
index 476c5e6..c9ac3f3 100644
--- a/doc/README.qemu_mips
+++ b/doc/README.qemu_mips
@@ -15,4 +15,4 @@ create image:
 # dd of=flash bs=1k count=4k if=/dev/zero
 # dd of=flash bs=1k conv=notrunc if=u-boot.bin
 start it:
-# qemu-system-mips -pflash flash -monitor null -nographic
+# qemu-system-mips -M mips -pflash flash -monitor null -nographic
-- 
1.5.6.2


-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] RFC: mailing list transfer

2008-08-01 Thread Jean-Christophe PLAGNIOL-VILLARD
 
 Do you think this is a reasonable plan? Any hints, ideas, tips?
As everyone agree, it's a great idea

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 1/1] FAT Bare Partition Support

2008-08-01 Thread Jean-Christophe PLAGNIOL-VILLARD
 
Telling the truth it seems that I've used this function during debug in
fact at a deeper look it seems it disappeared from the code a part the
definition.
Ok I'm going to fix the problem and re-submit.
 
Any update about the re-submit patch?

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH] apollon: fix build out of tree

2008-07-31 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
 Makefile   |4 +-
 onenand_ipl/board/apollon/Makefile |   41 +--
 2 files changed, 31 insertions(+), 14 deletions(-)

diff --git a/Makefile b/Makefile
index 369bbd7..f33aad5 100644
--- a/Makefile
+++ b/Makefile
@@ -346,10 +346,9 @@ $(U_BOOT_NAND):$(NAND_SPL) $(obj)u-boot.bin 
$(obj)include/autoconf.mk
cat $(obj)nand_spl/u-boot-spl-16k.bin $(obj)u-boot.bin  
$(obj)u-boot-nand.bin
 
 $(ONENAND_IPL):$(VERSION_FILE) $(obj)include/autoconf.mk
-   $(MAKE) -C $(obj)onenand_ipl/board/$(BOARDDIR) all
+   $(MAKE) -C onenand_ipl/board/$(BOARDDIR) all
 
 $(U_BOOT_ONENAND): $(ONENAND_IPL) $(obj)u-boot.bin 
$(obj)include/autoconf.mk
-   $(MAKE) -C $(obj)onenand_ipl/board/$(BOARDDIR) all
cat $(obj)onenand_ipl/onenand-ipl-2k.bin $(obj)u-boot.bin  
$(obj)u-boot-onenand.bin
cat $(obj)onenand_ipl/onenand-ipl-4k.bin $(obj)u-boot.bin  
$(obj)u-boot-flexonenand.bin
 
@@ -2664,6 +2663,7 @@ zylonite_config :
 
 apollon_config : unconfig
@mkdir -p $(obj)include
+   @mkdir -p $(obj)onenand_ipl/board/apollon
@echo #define CONFIG_ONENAND_U_BOOT  $(obj)include/config.h
@$(MKCONFIG) $(@:_config=) arm arm1136 apollon NULL omap24xx
@echo CONFIG_ONENAND_U_BOOT = y  $(obj)include/config.mk
diff --git a/onenand_ipl/board/apollon/Makefile 
b/onenand_ipl/board/apollon/Makefile
index f10ed02..6d04379 100644
--- a/onenand_ipl/board/apollon/Makefile
+++ b/onenand_ipl/board/apollon/Makefile
@@ -1,6 +1,5 @@
 
 include $(TOPDIR)/config.mk
-include $(TOPDIR)/include/config.mk
 include $(TOPDIR)/onenand_ipl/board/$(BOARDDIR)/config.mk
 
 LDSCRIPT= $(TOPDIR)/onenand_ipl/board/$(BOARDDIR)/u-boot.onenand.lds
@@ -9,8 +8,11 @@ AFLAGS += -DCONFIG_ONENAND_IPL
 CFLAGS += -DCONFIG_ONENAND_IPL
 OBJCLFAGS += --gap-fill=0x00
 
-SOBJS  = start.o low_levelinit.o
-COBJS  = apollon.o onenand_read.o onenand_boot.o
+SOBJS  := start.o
+SOBJS  += start.o
+COBJS  := apollon.o
+COBJS  += onenand_read.o
+COBJS  += onenand_boot.o
 
 SRCS   := $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c))
 OBJS   := $(addprefix $(obj),$(SOBJS) $(COBJS))
@@ -35,27 +37,39 @@ $(onenandobj)onenand-ipl.bin:   $(onenandobj)onenand-ipl
 $(onenandobj)onenand-ipl:  $(OBJS)
cd $(LNDIR)  $(LD) $(LDFLAGS) $$UNDEF_SYM $(__OBJS) \
-Map $(onenandobj)onenand-ipl.map \
-   -o $(onenandobj)onenand-ipl
+   -o $@
 
 # create symbolic links from common files
 
 # from cpu directory
 $(obj)start.S:
-   rm -f $(obj)start.S
-   ln -s $(SRCTREE)/cpu/$(CPU)/start.S $(obj)start.S
+   @rm -f $@
+   ln -s $(SRCTREE)/cpu/$(CPU)/start.S $@
 
 # from onenand_ipl directory
 $(obj)onenand_ipl.h:
-   rm -f $(obj)onenand_ipl.h
-   ln -s $(SRCTREE)/onenand_ipl/onenand_ipl.h $(obj)onenand_ipl.h
+   @rm -f $@
+   ln -s $(SRCTREE)/onenand_ipl/onenand_ipl.h $@
 
 $(obj)onenand_boot.c:  $(obj)onenand_ipl.h
-   rm -f $(obj)onenand_boot.c
-   ln -s $(SRCTREE)/onenand_ipl/onenand_boot.c $(obj)onenand_boot.c
+   @rm -f $@
+   ln -s $(SRCTREE)/onenand_ipl/onenand_boot.c $@
 
 $(obj)onenand_read.c:  $(obj)onenand_ipl.h
-   rm -f $(obj)onenand_read.c
-   ln -s $(SRCTREE)/onenand_ipl/onenand_read.c $(obj)onenand_read.c
+   @rm -f $@
+   ln -s $(SRCTREE)/onenand_ipl/onenand_read.c $@
+
+ifneq ($(OBJTREE), $(SRCTREE))
+$(obj)apollon.c:
+   @rm -f $@
+   ln -s $(SRCTREE)/onenand_ipl/board/$(BOARDDIR)/apollon.c $@
+
+$(obj)low_levelinit.S:
+   @rm -f $@
+   ln -s $(SRCTREE)/onenand_ipl/board/$(BOARDDIR)/low_levelinit.S $@
+endif
+
+#
 
 $(obj)%.o: $(obj)%.S
$(CC) $(AFLAGS) -c -o $@ $
@@ -63,6 +77,9 @@ $(obj)%.o:$(obj)%.S
 $(obj)%.o: $(obj)$.c
$(CC) $(CFLAGS) -c -o $@ $
 
+# defines $(obj).depend target
 include $(SRCTREE)/rules.mk
 
 sinclude $(obj).depend
+
+#
-- 
1.5.6


-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH] nand_spl: clean up Makefile

2008-07-31 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
need Scott Wood patch  * NAND: $(obj)-qualify ecc.h in kilauea NAND boot 
Makefile.

 nand_spl/board/amcc/acadia/Makefile  |   51 
 nand_spl/board/amcc/bamboo/Makefile  |   39 --
 nand_spl/board/amcc/canyonlands/Makefile |   34 ++--
 nand_spl/board/amcc/kilauea/Makefile |   45 ++---
 nand_spl/board/amcc/sequoia/Makefile |   52 +
 5 files changed, 123 insertions(+), 98 deletions(-)

diff --git a/nand_spl/board/amcc/acadia/Makefile 
b/nand_spl/board/amcc/acadia/Makefile
index 931f04b..23f76be 100644
--- a/nand_spl/board/amcc/acadia/Makefile
+++ b/nand_spl/board/amcc/acadia/Makefile
@@ -29,8 +29,15 @@ LDFLAGS  = -Bstatic -T $(LDSCRIPT) -Ttext $(TEXT_BASE) 
$(PLATFORM_LDFLAGS)
 AFLAGS += -DCONFIG_NAND_SPL
 CFLAGS += -DCONFIG_NAND_SPL
 
-SOBJS  = start.o resetvec.o cache.o
-COBJS  = gpio.o nand_boot.o nand_ecc.o memory.o ndfc.o pll.o
+SOBJS  := cache.o
+SOBJS  += resetvec.o
+SOBJS  += start.o
+COBJS  := gpio.o
+COBJS  += memory.o
+COBJS  += nand_boot.o
+COBJS  += nand_ecc.o
+COBJS  += ndfc.o
+COBJS  += pll.o
 
 SRCS   := $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c))
 OBJS   := $(addprefix $(obj),$(SOBJS) $(COBJS))
@@ -53,54 +60,54 @@ $(nandobj)u-boot-spl.bin:   $(nandobj)u-boot-spl
 $(nandobj)u-boot-spl:  $(OBJS)
cd $(LNDIR)  $(LD) $(LDFLAGS) $(__OBJS) \
-Map $(nandobj)u-boot-spl.map \
-   -o $(nandobj)u-boot-spl
+   -o $@
 
 $(nandobj)System.map:  $(nandobj)u-boot-spl
@$(NM) $ | \
grep -v '\(compiled\)\|\(\.o$$\)\|\( [aUw] 
\)\|\(\.\.ng$$\)\|\(LASH[RL]DI\)' | \
-   sort  $(nandobj)System.map
+   sort  $@
 
 # create symbolic links for common files
 
 # from cpu directory
 $(obj)cache.S:
-   @rm -f $(obj)cache.S
-   ln -s $(SRCTREE)/cpu/ppc4xx/cache.S $(obj)cache.S
+   @rm -f $@
+   ln -s $(SRCTREE)/cpu/ppc4xx/cache.S $@
 
 $(obj)gpio.c:
-   @rm -f $(obj)gpio.c
-   ln -s $(SRCTREE)/cpu/ppc4xx/gpio.c $(obj)gpio.c
+   @rm -f $@
+   ln -s $(SRCTREE)/cpu/ppc4xx/gpio.c $@
 
 $(obj)ndfc.c:
-   @rm -f $(obj)ndfc.c
-   ln -s $(SRCTREE)/cpu/ppc4xx/ndfc.c $(obj)ndfc.c
+   @rm -f $@
+   ln -s $(SRCTREE)/cpu/ppc4xx/ndfc.c $@
 
 $(obj)resetvec.S:
-   @rm -f $(obj)resetvec.S
-   ln -s $(SRCTREE)/cpu/ppc4xx/resetvec.S $(obj)resetvec.S
+   @rm -f $@
+   ln -s $(SRCTREE)/cpu/ppc4xx/resetvec.S $@
 
 $(obj)start.S:
-   @rm -f $(obj)start.S
-   ln -s $(SRCTREE)/cpu/ppc4xx/start.S $(obj)start.S
+   @rm -f $@
+   ln -s $(SRCTREE)/cpu/ppc4xx/start.S $@
 
 # from board directory
 $(obj)memory.c:
-   @rm -f $(obj)memory.c
-   ln -s $(SRCTREE)/board/amcc/acadia/memory.c $(obj)memory.c
+   @rm -f $@
+   ln -s $(SRCTREE)/board/amcc/$(BOARDDIR)/memory.c $@
 
 $(obj)pll.c:
-   @rm -f $(obj)pll.c
-   ln -s $(SRCTREE)/board/amcc/acadia/pll.c $(obj)pll.c
+   @rm -f $@
+   ln -s $(SRCTREE)/board/amcc/$(BOARDDIR)/pll.c $@
 
 # from nand_spl directory
 $(obj)nand_boot.c:
-   @rm -f $(obj)nand_boot.c
-   ln -s $(SRCTREE)/nand_spl/nand_boot.c $(obj)nand_boot.c
+   @rm -f $@
+   ln -s $(SRCTREE)/nand_spl/nand_boot.c $@
 
 # from drivers/mtd/nand directory
 $(obj)nand_ecc.c:
-   @rm -f $(obj)nand_ecc.c
-   ln -s $(SRCTREE)/drivers/mtd/nand/nand_ecc.c $(obj)nand_ecc.c
+   @rm -f $@
+   ln -s $(SRCTREE)/drivers/mtd/nand/nand_ecc.c $@
 
 #
 
diff --git a/nand_spl/board/amcc/bamboo/Makefile 
b/nand_spl/board/amcc/bamboo/Makefile
index e1c1467..14b55e6 100644
--- a/nand_spl/board/amcc/bamboo/Makefile
+++ b/nand_spl/board/amcc/bamboo/Makefile
@@ -29,8 +29,13 @@ LDFLAGS  = -Bstatic -T $(LDSCRIPT) -Ttext $(TEXT_BASE) 
$(PLATFORM_LDFLAGS)
 AFLAGS += -DCONFIG_NAND_SPL
 CFLAGS += -DCONFIG_NAND_SPL
 
-SOBJS  = start.o init.o resetvec.o
-COBJS  = nand_boot.o nand_ecc.o ndfc.o sdram.o
+SOBJS  := init.o
+SOBJS  += resetvec.o
+SOBJS  += start.o
+COBJS  := nand_boot.o
+COBJS  += nand_ecc.o
+COBJS  += ndfc.o
+COBJS  += sdram.o
 
 SRCS   := $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c))
 OBJS   := $(addprefix $(obj),$(SOBJS) $(COBJS))
@@ -52,42 +57,42 @@ $(nandobj)u-boot-spl.bin:   $(nandobj)u-boot-spl
 $(nandobj)u-boot-spl:  $(OBJS)
cd $(LNDIR)  $(LD) $(LDFLAGS) $(__OBJS) \
-Map $(nandobj)u-boot-spl.map \
-   -o $(nandobj)u-boot-spl
+   -o $@
 
 # create symbolic links for common files
 
 # from cpu directory
 $(obj)ndfc.c:
-   @rm -f $(obj)ndfc.c
-   ln -s $(SRCTREE)/cpu/ppc4xx/ndfc.c $(obj)ndfc.c
+   @rm -f $@
+   ln -s $(SRCTREE)/cpu/ppc4xx/ndfc.c $@
 
 $(obj)resetvec.S:
-   @rm -f $(obj)resetvec.S
-   ln -s $(SRCTREE)/cpu/ppc4xx/resetvec.S $(obj)resetvec.S
+   @rm

[U-Boot-Users] [PATCH] apollon: fix build out of tree

2008-07-31 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
 Makefile   |4 +-
 onenand_ipl/board/apollon/Makefile |   42 ---
 2 files changed, 31 insertions(+), 15 deletions(-)

diff --git a/Makefile b/Makefile
index 369bbd7..f33aad5 100644
--- a/Makefile
+++ b/Makefile
@@ -346,10 +346,9 @@ $(U_BOOT_NAND):$(NAND_SPL) $(obj)u-boot.bin 
$(obj)include/autoconf.mk
cat $(obj)nand_spl/u-boot-spl-16k.bin $(obj)u-boot.bin  
$(obj)u-boot-nand.bin
 
 $(ONENAND_IPL):$(VERSION_FILE) $(obj)include/autoconf.mk
-   $(MAKE) -C $(obj)onenand_ipl/board/$(BOARDDIR) all
+   $(MAKE) -C onenand_ipl/board/$(BOARDDIR) all
 
 $(U_BOOT_ONENAND): $(ONENAND_IPL) $(obj)u-boot.bin 
$(obj)include/autoconf.mk
-   $(MAKE) -C $(obj)onenand_ipl/board/$(BOARDDIR) all
cat $(obj)onenand_ipl/onenand-ipl-2k.bin $(obj)u-boot.bin  
$(obj)u-boot-onenand.bin
cat $(obj)onenand_ipl/onenand-ipl-4k.bin $(obj)u-boot.bin  
$(obj)u-boot-flexonenand.bin
 
@@ -2664,6 +2663,7 @@ zylonite_config :
 
 apollon_config : unconfig
@mkdir -p $(obj)include
+   @mkdir -p $(obj)onenand_ipl/board/apollon
@echo #define CONFIG_ONENAND_U_BOOT  $(obj)include/config.h
@$(MKCONFIG) $(@:_config=) arm arm1136 apollon NULL omap24xx
@echo CONFIG_ONENAND_U_BOOT = y  $(obj)include/config.mk
diff --git a/onenand_ipl/board/apollon/Makefile 
b/onenand_ipl/board/apollon/Makefile
index f10ed02..1f996a4 100644
--- a/onenand_ipl/board/apollon/Makefile
+++ b/onenand_ipl/board/apollon/Makefile
@@ -1,6 +1,5 @@
 
 include $(TOPDIR)/config.mk
-include $(TOPDIR)/include/config.mk
 include $(TOPDIR)/onenand_ipl/board/$(BOARDDIR)/config.mk
 
 LDSCRIPT= $(TOPDIR)/onenand_ipl/board/$(BOARDDIR)/u-boot.onenand.lds
@@ -9,8 +8,11 @@ AFLAGS += -DCONFIG_ONENAND_IPL
 CFLAGS += -DCONFIG_ONENAND_IPL
 OBJCLFAGS += --gap-fill=0x00
 
-SOBJS  = start.o low_levelinit.o
-COBJS  = apollon.o onenand_read.o onenand_boot.o
+SOBJS  := low_levelinit.o
+SOBJS  += start.o
+COBJS  := apollon.o
+COBJS  += onenand_read.o
+COBJS  += onenand_boot.o
 
 SRCS   := $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c))
 OBJS   := $(addprefix $(obj),$(SOBJS) $(COBJS))
@@ -34,28 +36,39 @@ $(onenandobj)onenand-ipl.bin:   $(onenandobj)onenand-ipl
 
 $(onenandobj)onenand-ipl:  $(OBJS)
cd $(LNDIR)  $(LD) $(LDFLAGS) $$UNDEF_SYM $(__OBJS) \
-   -Map $(onenandobj)onenand-ipl.map \
-   -o $(onenandobj)onenand-ipl
+   -Map [EMAIL PROTECTED] -o $@
 
 # create symbolic links from common files
 
 # from cpu directory
 $(obj)start.S:
-   rm -f $(obj)start.S
-   ln -s $(SRCTREE)/cpu/$(CPU)/start.S $(obj)start.S
+   @rm -f $@
+   ln -s $(SRCTREE)/cpu/$(CPU)/start.S $@
 
 # from onenand_ipl directory
 $(obj)onenand_ipl.h:
-   rm -f $(obj)onenand_ipl.h
-   ln -s $(SRCTREE)/onenand_ipl/onenand_ipl.h $(obj)onenand_ipl.h
+   @rm -f $@
+   ln -s $(SRCTREE)/onenand_ipl/onenand_ipl.h $@
 
 $(obj)onenand_boot.c:  $(obj)onenand_ipl.h
-   rm -f $(obj)onenand_boot.c
-   ln -s $(SRCTREE)/onenand_ipl/onenand_boot.c $(obj)onenand_boot.c
+   @rm -f $@
+   ln -s $(SRCTREE)/onenand_ipl/onenand_boot.c $@
 
 $(obj)onenand_read.c:  $(obj)onenand_ipl.h
-   rm -f $(obj)onenand_read.c
-   ln -s $(SRCTREE)/onenand_ipl/onenand_read.c $(obj)onenand_read.c
+   @rm -f $@
+   ln -s $(SRCTREE)/onenand_ipl/onenand_read.c $@
+
+ifneq ($(OBJTREE), $(SRCTREE))
+$(obj)apollon.c:
+   @rm -f $@
+   ln -s $(SRCTREE)/onenand_ipl/board/$(BOARDDIR)/apollon.c $@
+
+$(obj)low_levelinit.S:
+   @rm -f $@
+   ln -s $(SRCTREE)/onenand_ipl/board/$(BOARDDIR)/low_levelinit.S $@
+endif
+
+#
 
 $(obj)%.o: $(obj)%.S
$(CC) $(AFLAGS) -c -o $@ $
@@ -63,6 +76,9 @@ $(obj)%.o:$(obj)%.S
 $(obj)%.o: $(obj)$.c
$(CC) $(CFLAGS) -c -o $@ $
 
+# defines $(obj).depend target
 include $(SRCTREE)/rules.mk
 
 sinclude $(obj).depend
+
+#
-- 
1.5.6


-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 6/7] NAND: add NAND driver for s3c64xx

2008-07-31 Thread Jean-Christophe PLAGNIOL-VILLARD
 +/*
 + * (C) Copyright 2006 DENX Software Engineering
 + *
 + * See file CREDITS for list of people who contributed to this
 + * project.
 + *
 + * This program is free software; you can redistribute it and/or
 + * modify it under the terms of the GNU General Public License as
 + * published by the Free Software Foundation; either version 2 of
 + * the License, or (at your option) any later version.
 + *
 + * This program is distributed in the hope that it will be useful,
 + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 + * GNU General Public License for more details.
 + *
 + * You should have received a copy of the GNU General Public License
 + * along with this program; if not, write to the Free Software
 + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 + * MA 02111-1307 USA
 + */
 +
 +#include common.h
 +
 +#include nand.h
 +#include s3c6400.h
 +
 +#include asm/io.h
 +
 +#ifdef CONFIG_NAND_SPL
 +#define printf(arg...) do {} while (0)
 +#endif
 +
 +/* Nand flash definition values by jsgood */
 +#define S3C_NAND_CFG_HWECC
Please move to config file
 +#undef   S3C_NAND_DEBUG
please remove
 +
 +#ifdef S3C_NAND_DEBUG
 +/*
 + * Function to print out oob buffer for debugging
 + * Written by jsgood
 + */
 +static void print_oob(const char *header, struct mtd_info *mtd)
 +{
 + int i;
 + struct nand_chip *chip = mtd-priv;
 +
 + printf(%s:\t, header);
 +
 + for(i = 0; i  64; i++)
 + printf(%02x , chip-oob_poi[i]);
 +
 + printf(\n);
 +}
 +#endif /* S3C_NAND_DEBUG */
 +
 +#ifdef CONFIG_NAND_SPL
 +static u_char nand_read_byte(struct mtd_info *mtd)
 +{
 + struct nand_chip *this = mtd-priv;
add an empty line
 + return readb(this-IO_ADDR_R);
 +}
 +
 +static void nand_write_byte(struct mtd_info *mtd, u_char byte)
 +{
 + struct nand_chip *this = mtd-priv;
add an empty line
 + writeb(byte, this-IO_ADDR_W);
 +}
 +
 +static void nand_read_buf(struct mtd_info *mtd, u_char *buf, int len)
 +{
 + int i;
 + struct nand_chip *this = mtd-priv;
 +
 + for (i = 0; i  len; i++)
 + buf[i] = readb(this-IO_ADDR_R);
 +}
 +#endif
 +
 +/*
 + * This function determines whether read data is good or not.
 + * If SLC, must write ecc codes to controller before reading status bit.
 + * If MLC, status bit is already set, so only reading is needed.
 + * If status bit is good, return 0.
 + * If correctable errors occured, do that.
 + * If uncorrectable errors occured, return -1.
 + * Written by jsgood
 + */
 +static int s3c_nand_correct_data(struct mtd_info *mtd, u_char *dat,
 +  u_char *read_ecc, u_char *calc_ecc)
 +{
 + int ret = -1;
 + u_long nfestat0, nfmeccdata0, nfmeccdata1;
 + u_char err_type;
 +
 + /* SLC: Write ecc to compare */
 + nfmeccdata0 = (calc_ecc[1]  16) | calc_ecc[0];
 + nfmeccdata1 = (calc_ecc[3]  16) | calc_ecc[2];
 + writel(nfmeccdata0, NFMECCDATA0);
 + writel(nfmeccdata1, NFMECCDATA1);
 +
 + /* Read ecc status */
 + nfestat0 = readl(NFESTAT0);
 + err_type = nfestat0  0x3;
 +
 + switch (err_type) {
 + case 0: /* No error */
 + ret = 0;
 + break;
 +
 + case 1: /* 1 bit error (Correctable)
 +(nfestat0  7)  0x7ff  :error byte number
 +(nfestat0  4)  0x7:error bit number */
 + printf(S3C NAND: 1 bit error detected at byte %ld. Correcting 
 from 
 +0x%02x , (nfestat0  7)  0x7ff, dat[(nfestat0  7) 
  0x7ff]);
 + dat[(nfestat0  7)  0x7ff] ^= (1  ((nfestat0  4)  0x7));
 + printf(to 0x%02x...OK\n, dat[(nfestat0  7)  0x7ff]);
could use inline or macro to be more readable
 + ret = 1;
 + break;
 +
 + case 2: /* Multiple error */
 + case 3: /* ECC area error */
 + printf(S3C NAND: ECC uncorrectable error detected. Not 
 correctable.\n);
 + ret = -1;
 + break;
 + }
 +
 + return ret;
 +}
 +#endif /* S3C_NAND_CFG_HWECC */
 +
 +/*
 + * Board-specific NAND initialization. The following members of the
 + * argument are board-specific (per include/linux/mtd/nand.h):
 + * - IO_ADDR_R?: address to read the 8 I/O lines of the flash device
 + * - IO_ADDR_W?: address to write the 8 I/O lines of the flash device
 + * - hwcontrol: hardwarespecific function for accesing control-lines
 + * - dev_ready: hardwarespecific function for  accesing device ready/busy 
 line
 + * - enable_hwecc?: function to enable (reset)  hardware ecc generator. Must
 + *   only be provided if a hardware ECC is available
 + * - eccmode: mode of ecc, see defines
 + * - chip_delay: chip dependent delay for transfering data from array to
 + *   read regs (tR)
 + * - options: various chip options. They can partly be set to inform
 + *   nand_scan about special functionality. See the defines for further
 + *   explanation
 + * Members 

Re: [U-Boot-Users] [PATCH 5/7] serial: add s3c64xx serial driver

2008-07-31 Thread Jean-Christophe PLAGNIOL-VILLARD
On 12:54 Thu 31 Jul , Guennadi Liakhovetski wrote:
 Ported from u-boot-1.1.6 driver by Samsung.
 
 Signed-off-by: Guennadi Liakhovetski [EMAIL PROTECTED]
 ---
  drivers/serial/Makefile  |1 +
  drivers/serial/s3c64xx.c |  189 
 ++
  2 files changed, 190 insertions(+), 0 deletions(-)
  create mode 100644 drivers/serial/s3c64xx.c
 
 diff --git a/drivers/serial/Makefile b/drivers/serial/Makefile
 index c9e797e..70fe638 100644
 --- a/drivers/serial/Makefile
 +++ b/drivers/serial/Makefile
 @@ -36,6 +36,7 @@ COBJS-y += serial_pl010.o
  COBJS-y += serial_pl011.o
  COBJS-y += serial_xuartlite.o
  COBJS-y += serial_sh.o
 +COBJS-$(CONFIG_S3C64XX) += s3c64xx.o
  COBJS-y += usbtty.o
  
  COBJS:= $(COBJS-y)
 diff --git a/drivers/serial/s3c64xx.c b/drivers/serial/s3c64xx.c
 new file mode 100644
 index 000..d7e9d01
 --- /dev/null
 +++ b/drivers/serial/s3c64xx.c
 @@ -0,0 +1,189 @@
 +/*
 + * (C) Copyright 2002
 + * Gary Jennejohn, DENX Software Engineering, [EMAIL PROTECTED]
 + *
 + * This program is free software; you can redistribute it and/or modify
 + * it under the terms of the GNU General Public License as published by
 + * the Free Software Foundation; either version 2 of the License, or
 + * (at your option) any later version.
 + *
 + * This program is distributed in the hope that it will be useful,
 + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 + * GNU General Public License for more details.
 + *
 + * You should have received a copy of the GNU General Public License
 + * along with this program; if not, write to the Free Software
 + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 + *
 + */
 +
 +#include common.h
 +
 +#include s3c6400.h
 +
 +#ifdef CONFIG_SERIAL1
 +#define UART_NR  S3C64XX_UART0
 +
 +#elif defined(CONFIG_SERIAL2)
 +#define UART_NR  S3C64XX_UART1
 +
 +#elif defined(CONFIG_SERIAL3)
 +#define UART_NR  S3C64XX_UART2
 +
 +#else
 +#error Bad: you didn't configure serial ...
 +#endif
 +
 +#define barrier() asm volatile( ::: memory)
 +
 +/* See table in 31.6.11 */
 +static const int udivslot[] = {
 + 0,
 + 0x0080,
 + 0x0808,
 + 0x0888,
 + 0x,
 + 0x4924,
 + 0x4a52,
 + 0x54aa,
 + 0x,
 + 0xd555,
 + 0xd5d5,
 + 0xddd5,
 + 0x,
 + 0xdfdd,
 + 0xdfdf,
 + 0xffdf,
 +};
 +
 +void serial_setbrg(void)
 +{
 + DECLARE_GLOBAL_DATA_PTR;
 + S3C64XX_UART *const uart = S3C64XX_GetBase_UART(UART_NR);
 + u32 reg, pclk_ratio = get_PCLK() / gd-baudrate;
 + int i;
 +
 + /* PCLK / (16 * baudrate) - 1 */
 + reg = pclk_ratio / 16 - 1;
 + i = pclk_ratio - (reg + 1) * 16;
 +
 + uart-UBRDIV = reg;
 + uart-UDIVSLOT = udivslot[i];
 +
 + for (i = 0; i  100; i++)
 + barrier();
 +}
 +
 +/*
 + * Initialise the serial port with the given baudrate. The settings
 + * are always 8 data bits, no parity, 1 stop bit, no start bits.
 + *
 + */
 +int serial_init(void)
 +{
 + S3C64XX_UART *const uart = S3C64XX_GetBase_UART(UART_NR);
please do not use UPPERCASE var name and function  co
 +
 + /* reset and enable FIFOs, set triggers to the maximum */
 + uart-UFCON = 0xff;
 + uart-UMCON = 0;
 + /* 8N1 */
 + uart-ULCON = 3;
 + /* No interrupts, no DMA, pure polling */
 + uart-UCON = 5;
 +
 + serial_setbrg();
 +
 + return 0;
 +}
 +
 +/*
 + * Read a single byte from the serial port. Returns 1 on success, 0
 + * otherwise. When the function is succesfull, the character read is
 + * written into its argument c.
 + */
 +int serial_getc(void)
 +{
 + S3C64XX_UART *const uart = S3C64XX_GetBase_UART(UART_NR);
 +
 + /* wait for character to arrive */
 + while (!(uart-UTRSTAT  0x1));
 +
 + return uart-URXH  0xff;
 +}
 +
 +#ifdef CONFIG_HWFLOW
 +static int hwflow = 0;   /* turned off by default */
 +int hwflow_onoff(int on)
 +{
 + switch (on) {
 + case 0:
 + default:
 + break;  /* return current */
IMHO it's weird to have the default at top
 + case 1:
 + hwflow = 1; /* turn on */
 + break;
 + case -1:
 + hwflow = 0; /* turn off */
 + break;
 + }
 + return hwflow;
 +}
 +#endif
 +

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 4/7] USB: Add support for OHCI controller on s3c6400

2008-07-31 Thread Jean-Christophe PLAGNIOL-VILLARD
On 12:54 Thu 31 Jul , Guennadi Liakhovetski wrote:
 Notice: USB on s3c6400 currently works _only_ with switched off MMU. One could
 try to enable the MMU, but map addresses 1-to-1, and disable data cache, then
 it should work too and we could still profit from instruction cache.
 
 Signed-off-by: Guennadi Liakhovetski [EMAIL PROTECTED]
 ---
  cpu/arm1176/s3c64xx/Makefile |1 +
  cpu/arm1176/s3c64xx/usb.c|   44 
 ++
  drivers/usb/usb_ohci.c   |1 +
  3 files changed, 46 insertions(+), 0 deletions(-)
  create mode 100644 cpu/arm1176/s3c64xx/usb.c
 
 diff --git a/cpu/arm1176/s3c64xx/Makefile b/cpu/arm1176/s3c64xx/Makefile
 index 92373d8..0a1201d 100644
 --- a/cpu/arm1176/s3c64xx/Makefile
 +++ b/cpu/arm1176/s3c64xx/Makefile
 @@ -28,6 +28,7 @@ LIB = $(obj)lib$(SOC).a
  OBJS = interrupts.o
  #OBJS= nand_cp.o serial.o usb_ohci.o interrupts.o nand.o
If no need please remove put it as conditional
  COBJS-$(CONFIG_S3C6400)  += cpu_init.o speed.o
 +COBJS-$(CONFIG_USB_OHCI_NEW) += usb.o
  
  OBJS += $(COBJS-y)
  
 diff --git a/cpu/arm1176/s3c64xx/usb.c b/cpu/arm1176/s3c64xx/usb.c
 new file mode 100644
 index 000..f9dbc5e
 --- /dev/null
 +++ b/cpu/arm1176/s3c64xx/usb.c
 @@ -0,0 +1,44 @@
 +/*
 + * URB OHCI HCD (Host Controller Driver) initialization for USB on the 
 S3C64XX.
 + *
 + * Copyright (C) 2008, Guennadi Liakhovetski, DENX Software Engineering 
 [EMAIL PROTECTED]
 + *
 + * See file CREDITS for list of people who contributed to this
 + * project.
 + *
 + * This program is free software; you can redistribute it and/or
 + * modify it under the terms of the GNU General Public License as
 + * published by the Free Software Foundation; either version 2 of
 + * the License, or (at your option) any later version.
 + *
 + * This program is distributed in the hope that it will be useful,
 + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 + * GNU General Public License for more details.
 + *
 + * You should have received a copy of the GNU General Public License
 + * along with this program; if not, write to the Free Software
 + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 + * MA 02111-1307 USA
 + *
 + */
 +
 +#include common.h
 +#include s3c6400.h
 +
 +int usb_cpu_init(void)
 +{
 + OTHERS_REG |= 0x1;
 + return 0;
 +}
 +
 +int usb_cpu_stop(void)
 +{
 + OTHERS_REG = ~0x1;
 + return 0;
 +}
 +
 +void usb_cpu_init_fail(void)
 +{
 + OTHERS_REG = ~0x1;
 +}
 diff --git a/drivers/usb/usb_ohci.c b/drivers/usb/usb_ohci.c
 index fd60edb..94549a8 100644
 --- a/drivers/usb/usb_ohci.c
 +++ b/drivers/usb/usb_ohci.c
 @@ -67,6 +67,7 @@
  #endif
  
  #if defined(CONFIG_ARM920T) || \
 +defined(CONFIG_S3C6400) || \
  defined(CONFIG_S3C2400) || \
  defined(CONFIG_S3C2410) || \
  defined(CONFIG_440EP) || \
Could we find a better way than add and add more defined?

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 3/7] ARM: Add arm1176 core with s3c6400 SoC

2008-07-31 Thread Jean-Christophe PLAGNIOL-VILLARD
 +# This program is free software; you can redistribute it and/or
 +# modify it under the terms of the GNU General Public License as
 +# published by the Free Software Foundation; either version 2 of
 +# the License, or (at your option) any later version.
 +#
 +# This program is distributed in the hope that it will be useful,
 +# but WITHOUT ANY WARRANTY; without even the implied warranty of
 +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 +# GNU General Public License for more details.
 +#
 +# You should have received a copy of the GNU General Public License
 +# along with this program; if not, write to the Free Software
 +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 +# MA 02111-1307 USA
 +#
 +PLATFORM_RELFLAGS += -fno-strict-aliasing  -fno-common -ffixed-r8 \
 + -msoft-float
 +
 +# Make ARMv5 to allow more compilers to work, even though its v6.
 +PLATFORM_CPPFLAGS += -march=armv5t
could we do it dynamicly?
 +# =
 +#
 +# Supply options according to compiler version
 +#
 +# =
 +PLATFORM_CPPFLAGS +=$(call cc-option,-mapcs-32,-mabi=apcs-gnu)
 +PLATFORM_CPPFLAGS +=$(call cc-option,-mno-thumb-interwork,)
 +PLATFORM_RELFLAGS +=$(call cc-option,-mshort-load-bytes,$(call 
 cc-option,-malignment-traps,))
 diff --git a/cpu/arm1176/cpu.c b/cpu/arm1176/cpu.c
 new file mode 100644
 index 000..54228d1
 --- /dev/null
 +++ b/cpu/arm1176/cpu.c
 @@ -0,0 +1,186 @@
 +/*
 + * (C) Copyright 2004 Texas Insturments
 + *
 + * (C) Copyright 2002
 + * Sysgo Real-Time Solutions, GmbH www.elinos.com
 + * Marius Groeger [EMAIL PROTECTED]
 + *
 + * (C) Copyright 2002
 + * Gary Jennejohn, DENX Software Engineering, [EMAIL PROTECTED]
 + *
 + * See file CREDITS for list of people who contributed to this
 + * project.
 + *

 +{
 + volatile int i;
 +
 + /* Many OMAP regs need at least 2 nops  */
so please use nop
 + for (i = 0; i  100; i++);
 +}
 +
 +/* See also ARM Ref. Man. */
 +#define C1_MMU   (10)  /* mmu off/on */
 +#define C1_ALIGN (11)  /* alignment faults off/on */
 +#define C1_DC(12)  /* dcache off/on */
 +#define C1_WB(13)  /* merging write buffer on/off 
 */
 +#define C1_BIG_ENDIAN(17)  /* big endian off/on */
 +#define C1_SYS_PROT  (18)  /* system protection */
 +#define C1_ROM_PROT  (19)  /* ROM protection */
 +#define C1_IC(112) /* icache off/on */
 +#define C1_HIGH_VECTORS  (113) /* location of vectors: low/high 
 addresses */
 +#define RESERVED_1   (0xf  3)  /* must be 111b for R/W */
 +
 +int cpu_init (void)
 +{
 + return 0;
 +}
 +
 +int cleanup_before_linux (void)
 +{
 + /*
 +  * this function is called just before we call linux
 +  * it prepares the processor for linux
 +  *
 +  * we turn off caches etc ...
 +  */
 +
 + unsigned long i;
 +
 + disable_interrupts ();
 +
 + /* turn off I/D-cache */
 + asm (mrc p15, 0, %0, c1, c0, 0:=r (i));
 + i = ~(C1_DC | C1_IC);
 + asm (mcr p15, 0, %0, c1, c0, 0: :r (i));
why don't you use icache_disable() and dcache_disable()?
 +
 + /* flush I/D-cache */
 + i = 0;
 + asm (mcr p15, 0, %0, c7, c7, 0: :r (i));  /* invalidate both caches 
 and flush btb */
 + asm (mcr p15, 0, %0, c7, c10, 4: :r (i)); /* mem barrier to sync 
 things */
please implement icache_flush() and dcache_flush()
 + return 0;
 +}
 +
 +
 +++ b/cpu/arm1176/s3c64xx/Makefile
 +#include common.h
 +#include asm/proc-armv/ptrace.h
 +#include s3c6400.h
 +
 +static ulong timer_load_val;
 +
 +#define PRESCALER167
 +
 +/* macro to read the 16 bit timer */
 +static inline ulong READ_TIMER(void)
 +{
 + S3C64XX_TIMERS *const timers = S3C64XX_GetBase_TIMERS();
please do not use UPPERCASE var type and function  co
 +
 + return timers-TCNTO4;
 +}
 +
 new file mode 100644
 index 000..f28ebe8
 --- /dev/null
 +++ b/cpu/arm1176/s3c64xx/nand_cp.c
 @@ -0,0 +1,132 @@
 +/*
 + * $Id: nand_cp.c,v 1.3 2007/02/26 06:19:52 yongkal Exp $
please remove
 + *
 + * (C) Copyright 2006 Samsung Electronics
 + *
 + * See file CREDITS for list of people who contributed to this
 + * project.
 + *
 + * This program is free software; you can redistribute it and/or
 + * modify it under the terms of the GNU General Public License as
 + * published by the Free Software Foundation; either version 2 of
 + * the License, or (at your option) any later version.
 + *
 + * This program is distributed in the hope that it will be useful,
 + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 + * GNU General Public License for more details.
 + *
 + * You should have received a copy of the GNU General Public License
 + * along with this program; if not, write to the Free Software
 + * 

Re: [U-Boot-Users] U-Boot v1.3.4-rc2 released

2008-07-31 Thread Jean-Christophe PLAGNIOL-VILLARD
On 18:28 Thu 31 Jul , Michal Simek wrote:
 Hi Wolfgang,
 
 Microblaze boards are without any warnings.
Same for arm
except IXP as evertime

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] SD support for more than 128MB in u-boot1.3.1

2008-07-31 Thread Jean-Christophe PLAGNIOL-VILLARD
On 19:03 Thu 31 Jul , Naveen Kumar GADDIPATI wrote:
 Hi,
 
 Processor is arm926ejs based ST processor.
Could you be a bit more precise?
 I'm facing problem in supporting SD Card of size more than 128MB.
Ditto.
 SD Card is able to detect,but failing in reading boot sector info of the SD 
 block.
 
Log, code, etc... are welcome

Could you rebase your port against the current 1.3.4-rc2?

 One more thing,Is FAT32 support is present in uboot 1.3.1?If their any patch 
 for FAT32 in u-boot,please respond.

FAT32 is present for a long time

but IIRC: FAT32 is present in U-Boot but have somme issue

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH for STLS]: Add flash.c, ide.c and pci.c in board/st/stls/ directory!

2008-07-30 Thread Jean-Christophe PLAGNIOL-VILLARD
On 10:35 Wed 30 Jul , Ryan CHEN wrote:
 commit 7f818bb236de596c5bbcf21919625db9912b2c43
 Parent: 699f05125509249072a0b865c8d35520d97cd501
 Author: Ryan Chen [EMAIL PROTECTED]
 Date:   Wed Jul 30 06:26:36 2008 -0400
 
 Signed-off-by: Ryan Chen [EMAIL PROTECTED]
 
   new file:   board/st/stls/flash.c
Could you integrate it in the mtd support?
   new file:   board/st/stls/ide.c
   new file:   board/st/stls/pci.c
 
 diff --git a/board/st/stls/ide.c b/board/st/stls/ide.c
 new file mode 100755
 index 000..0954b3f
 --- /dev/null
 +++ b/board/st/stls/ide.c
 @@ -0,0 +1,110 @@
 +/* 
 + * Prototypes, etc. for the STMicroelectronics STLS
 + *
 + * 2008 (c) STMicroelectronics, Inc.
 + * Author: Ryan Chen [EMAIL PROTECTED]
 + *
 + * This program is free software; you can redistribute it and/or
 + * modify it under the terms of the GNU General Public License as
 + * published by the Free Software Foundation; either version 2 of
 + * the License, or (at your option) any later version.
 + *
 + * This program is distributed in the hope that it will be useful,
 + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 + * GNU General Public License for more details.
 + *
 + * You should have received a copy of the GNU General Public License
 + * along with this program; if not, write to the Free Software
 + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 + * MA 02111-1307 USA
 + */
 +#include common.h
 +#if defined (CONFIG_CMD_IDE)  defined(CONFIG_MULTI_IDE_CONTROLLER)
 +#if defined(CONFIG_VT82C686A) || defined(CONFIG_VT82C686B)
 +#include vt82c686.h
 +#endif/*defined(CONFIG_VT82C686A) || defined(CONFIG_VT82C686B)*/
 +#ifdef CFG_SATA_VIA
 +#include sata_via.h
 +#endif/* CFG_SATA_VIA */
 +#if defined(CONFIG_SATA_SIL)
 +extern int ide_sata_sil_preinit (void);
 +extern void ide_sata_sil_set_reset (int flag);
 +#endif/* CONFIG_SATA_SIL */
 +#ifdef CFG_IDE_SIL680
 +extern int ide_sil680_preinit (void);
 +extern void ide_sil680_set_reset (int flag);
please use an include instead of extern
 +#endif/* CFG_IDE_SIL680 */
 +
 +#ifdef DEBUG_IDE
 +#define PRINTF(fmt,args...)  printf (fmt ,##args)
 +#else
 +#define PRINTF(fmt,args...)
 +#endif
 +
 +extern u16 real_ide_max_buses;
 +extern u16 real_ide_max_devices;
 +extern ulong ide_bus_offset[CFG_IDE_MAXBUS];
 

please spit it into 2 files one for the ide support and one for the sata
support.

You have 2 comands CONFIG_CMD_IDE and CONFIG_CMD_SATA in u-boot for each
support.

+
 +int ide_preinit (void)
 +{
 + int l;
please be carefull whit the whitespace
 + int oldstatus = -1; 
   ^
 + int status = -1;
 + 
   ^
please remove the whitespace
 + for (l = 0; l  CFG_IDE_MAXBUS; l++) {
 + ide_bus_offset[l] = -1;
 + }
 + 
   ^
please remove the whitespace
 + /* clean them to calculate real values */
 + real_ide_max_buses = 0;
 + real_ide_max_devices = 0;
 +
 +#if defined(CONFIG_VT82C686A) || defined(CONFIG_VT82C686B)
 + status = ide_via_preinit();
 + if(!status) {
 + PRINTF(IDE: VIA IDE Controller Init Done!\n);
 + oldstatus = 0;
 + }
 +#endif/*defined(CONFIG_VT82C686A) || defined(CONFIG_VT82C686B)*/
 +#if defined(CONFIG_SATA_SIL)
 + status = ide_sata_sil_preinit();
 + if(!status) {
 + PRINTF(IDE: SIL SATA Controller Init Done!\n);
 + oldstatus = 0;
 + }
 +#endif/*CONFIG_SATA_SIL*/
 +#ifdef CFG_IDE_SIL680
 + status = ide_sil680_preinit();
 + if(!status) {
 + PRINTF(IDE: SIL680 Controller Init Done!\n);
 + oldstatus = 0;
 + }   
 ^^^
please remove the whitespace
 +#endif/* CFG_IDE_SIL680 */
 +#ifdef CFG_SATA_VIA
 + status = sata_via_preinit();
 + if(!status) {
 + PRINTF(IDE: VIA SATA Controller Init Done!\n);
 + oldstatus = 0;
 + }
 +#endif/* CFG_SATA_VIA */
 + return oldstatus;
 +}
 +
 +void ide_set_reset (int flag) 
please remove the whitespace
 +{
 +#if defined(CONFIG_VT82C686A) || defined(CONFIG_VT82C686B)
 + ide_via_set_reset (flag);
 +#endif/*defined(CONFIG_VT82C686A) || defined(CONFIG_VT82C686B)*/
 +#if defined(CONFIG_SATA_SIL)
 + ide_sata_sil_set_reset(flag);
 +#endif/*CONFIG_SATA_SIL*/
 +#ifdef CFG_IDE_SIL680
 + ide_sil680_set_reset(flag);
 +#endif/* CFG_IDE_SIL680 */
 +#ifdef CFG_SATA_VIA
 + sata_via_set_reset(flag);
 +#endif/* CFG_SATA_VIA */
 + return;
 +}
 +#endif/*CONFIG_CMD_IDE*/
 diff --git a/board/st/stls/pci.c b/board/st/stls/pci.c
 new file mode 100755
 index 000..072887d
 --- /dev/null
 +++ b/board/st/stls/pci.c
 @@ -0,0 +1,104 @@
 +/* 
 + * Prototypes, etc. for the STMicroelectronics STLS
 + *
 + * 2008 (c) STMicroelectronics, Inc.
 + * Author: Ryan Chen [EMAIL PROTECTED]
 + *
 + * This program is free software; you can redistribute it and/or
 + * modify it under the terms 

Re: [U-Boot-Users] [PATCH for STLS]: Add Makefile, config.mk and u-boot.lds.S in board/st/stls/ directory!

2008-07-30 Thread Jean-Christophe PLAGNIOL-VILLARD
On 10:17 Wed 30 Jul , Ryan CHEN wrote:
 commit d66194654186b0e82d926ce4844b73e3508397f4
 Parent: 699f05125509249072a0b865c8d35520d97cd501
 Author: Ryan Chen [EMAIL PROTECTED]
 Date:   Tue Jul 29 13:35:15 2008 -0400
 
 Signed-off-by: Ryan Chen [EMAIL PROTECTED]
 
   new file:   board/st/stls/Makefile
   new file:   board/st/stls/config.mk
   new file:   board/st/stls/u-boot.lds.S
Could you do it in the same patch where you add the board support?

with the update of the General Makefile, MAKALL and MAINTAINERS in it

Best Regards,
J.
 
 diff --git a/board/st/stls/Makefile b/board/st/stls/Makefile
 new file mode 100755
 index 000..8213838
 --- /dev/null
 +++ b/board/st/stls/Makefile
 @@ -0,0 +1,48 @@
 +#
 +# (C) Copyright 2003-2006
 +# Wolfgang Denk, DENX Software Engineering, [EMAIL PROTECTED]
 +#
 +# See file CREDITS for list of people who contributed to this
 +# project.
 +#
 +# This program is free software; you can redistribute it and/or
 +# modify it under the terms of the GNU General Public License as
 +# published by the Free Software Foundation; either version 2 of
 +# the License, or (at your option) any later version.
 +#
 +# This program is distributed in the hope that it will be useful,
 +# but WITHOUT ANY WARRANTY; without even the implied warranty of
 +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 +# GNU General Public License for more details.
 +#
 +# You should have received a copy of the GNU General Public License
 +# along with this program; if not, write to the Free Software
 +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 +# MA 02111-1307 USA
 +#
 +
 +include $(TOPDIR)/config.mk
 +
 +LIB  = $(obj)lib$(BOARD).a
 +
 +COBJS= flash.o pci.o stls_board.o ide.o
 +
 +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
 +OBJS := $(addprefix $(obj),$(COBJS))
 +SOBJS:= $(addprefix $(obj),$(SOBJS))
 +
 +$(LIB):  $(obj).depend $(OBJS) $(SOBJS) u-boot.lds
please use $(obj) for generated file in order to build it out-of-tree

 + $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS)
 +
 +u-boot.lds: u-boot.lds.S
 + $(CPP) $(CPPFLAGS) -P $^  [EMAIL PROTECTED]
 + mv -f [EMAIL PROTECTED] $@
 +

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] Error building uboot image

2008-07-30 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:52 Wed 30 Jul , Rugunda, Solo wrote:
 
 Hi
 
 I am trying to build an image for the at91rm9200 board using the command
 (make CROSS_COMPILE=arm-softfloat-linux-gnu-). It builds until a certain
 point and stops with the error message:
Could you be more specific : U-Boot version, toolchains option and
version

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 1/1] Re-Submit: Add support for ATMEL AT91SAM9G20EK board.

2008-07-29 Thread Jean-Christophe PLAGNIOL-VILLARD
On 21:57 Mon 28 Jul , Ben Warren wrote:
 Hi Hong,
 
 Thanks for all the hard work.  One more thing...
 snip
  +#if defined(CONFIG_CMD_NET)
  +int board_eth_init(bd_t *bis)
  +{
  +   return at91sam9_eth_initialize(bis);
  +}
  +#endif
 
 Here's at91sam9_eth_initialize:
 
 #if defined(CONFIG_MACB)  defined(CONFIG_CMD_NET)
 void at91sam9_eth_initialize(bd_t *bi)
 {
 macb_eth_initialize(0, (void *)AT91_BASE_EMAC, 0x00);
 }
 #endif
 
 Issues:
 1. It returns void
 2. It just calls the MACB initializer.
 
 Please change your code to:
 
 extern int macb_eth_initialize(int id, void *regs, unsigned int phy_addr);
 
 #if defined(CONFIG_MACB)  defined(CONFIG_CMD_NET)
 int board_eth_init(bd_t *bi)
 {
 return macb_eth_initialize(0, (void *)AT91_BASE_EMAC, 0x00);
 }
 #endif
 
 or something like this.  I don't know if AT91_BASE_EMAC is visible
 from this code, so you may need to modify slightly.
Can we do a cpu_eth_init instead?

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 1/1] Re-Submit: Add support for ATMEL AT91SAM9G20EK board.

2008-07-29 Thread Jean-Christophe PLAGNIOL-VILLARD
On 16:01 Tue 29 Jul , Hong Xu wrote:
 On Tue, Jul 29, 2008 at 15:25, Jean-Christophe PLAGNIOL-VILLARD
 [EMAIL PROTECTED] wrote:
  On 21:57 Mon 28 Jul , Ben Warren wrote:
  Hi Hong,
 
  Thanks for all the hard work.  One more thing...
  snip
   +#if defined(CONFIG_CMD_NET)
   +int board_eth_init(bd_t *bis)
   +{
   +   return at91sam9_eth_initialize(bis);
   +}
   +#endif
 
  Here's at91sam9_eth_initialize:
 
  #if defined(CONFIG_MACB)  defined(CONFIG_CMD_NET)
  void at91sam9_eth_initialize(bd_t *bi)
  {
  macb_eth_initialize(0, (void *)AT91_BASE_EMAC, 0x00);
  }
  #endif
 
  Issues:
  1. It returns void
  2. It just calls the MACB initializer.
 
  Please change your code to:
 
  extern int macb_eth_initialize(int id, void *regs, unsigned int phy_addr);
 
  #if defined(CONFIG_MACB)  defined(CONFIG_CMD_NET)
  int board_eth_init(bd_t *bi)
  {
  return macb_eth_initialize(0, (void *)AT91_BASE_EMAC, 0x00);
  }
  #endif
 
  or something like this.  I don't know if AT91_BASE_EMAC is visible
  from this code, so you may need to modify slightly.
  Can we do a cpu_eth_init instead?
 Not all arm926ejs series have built-in ethernet controller (e.g.
 AT91SAM9261 does not have). If we do it in cpu_eth_init, we may need
 other more #ifdef_s to distinguish. :-)
It already the case, I'll send a patch obout it

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH] at91sam9: merge ether driver to cpu_eth_init

2008-07-29 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]

diff --git a/cpu/arm926ejs/at91/ether.c b/cpu/arm926ejs/at91/ether.c
index 7e11fe4..c54f33b 100644
--- a/cpu/arm926ejs/at91/ether.c
+++ b/cpu/arm926ejs/at91/ether.c
@@ -25,10 +25,10 @@
 #include common.h
 #include asm/arch/hardware.h
 
+#if defined(CONFIG_MACB)  defined(CONFIG_CMD_NET)
 extern int macb_eth_initialize(int id, void *regs, unsigned int phy_addr);
 
-#if defined(CONFIG_MACB)  defined(CONFIG_CMD_NET)
-void at91sam9_eth_initialize(bd_t *bi)
+void cpu_eth_init(bd_t *bi)
 {
macb_eth_initialize(0, (void *)AT91_BASE_EMAC, 0x00);
 }
diff --git a/net/eth.c b/net/eth.c
index 38979aa..53c6622 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -74,7 +74,6 @@ extern int greth_initialize(bd_t *);
 extern int atngw100_eth_initialize(bd_t *);
 extern int mcffec_initialize(bd_t*);
 extern int mcdmafec_initialize(bd_t*);
-extern int at91sam9_eth_initialize(bd_t *);
 
 #ifdef CONFIG_API
 extern void (*push_packet)(volatile void *, int);
@@ -286,10 +285,6 @@ int eth_initialize(bd_t *bis)
 #if defined(CONFIG_FSLDMAFEC)
mcdmafec_initialize(bis);
 #endif
-#if defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
-defined(CONFIG_AT91SAM9263)
-   at91sam9_eth_initialize(bis);
-#endif
 
if (!eth_devices) {
puts (No ethernet found.\n);
-- 
1.5.6.2


-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] USB Uboot on OSK5912

2008-07-28 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:06 Mon 28 Jul , Hunter, Jon wrote:
  I recall that this did work with release 1.1.6, so it could be interesting
  to go back to 1.1.6 and see if it does work.
 
 
 Ok, so I did try with 1.1.6 and made the same changes to usbdcore_omap1510.c 
 and usbtty does work fine. It would be interesting to track-down where this 
 stopped working and fix this, but right now I don't have the time :-(
 
Do you try the patch that I send?

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] Add MIMC200 board - now uses board_eth_init()

2008-07-28 Thread Jean-Christophe PLAGNIOL-VILLARD
 +
 +static const struct sdram_config sdram_config = {
 +.data_bits= SDRAM_DATA_16BIT,
 +.row_bits= 13,
 +.col_bits= 9,
 +.bank_bits= 2,
 +.cas= 3,
 +.twr= 2,
 +.trc= 6,
 +.trp= 2,
 +.trcd= 2,
 +.tras= 6,
 +.txsr= 6,

please indent with tab for all files
 +/* 15.6 us */
 +.refresh_period= (156 * (SDRAMC_BUS_HZ / 1000)) / 1,
 +};
 +
 +int board_early_init_f(void)
 +{
 +/* Enable SDRAM in the EBI mux */
 +hmatrix_slave_write(EBI, SFR, HMATRIX_BIT(EBI_SDRAM_ENABLE));
 +
 +gpio_enable_ebi();
 +gpio_enable_usart1();
 +
 +// enable higher address lines for larger flash devices
please never use c++ comment style
 +gpio_select_periph_A(GPIO_PIN_PE16, 0);/* ADDR23 */
 +gpio_select_periph_A(GPIO_PIN_PE17, 0);/* ADDR24 */
 +gpio_select_periph_A(GPIO_PIN_PE18, 0);/* ADDR25 */
 +
 +// enable data flash chip select
 +gpio_select_periph_A(GPIO_PIN_PE25, 0);/* NCS2 */
 +
 +// reset phys
 +gpio_select_pio(GPIO_PIN_PE24, 0);
 +gpio_set_value(GPIO_PIN_PC18, 1);/* PHY RESET*/
 +gpio_select_pio(GPIO_PIN_PC18, GPIOF_OUTPUT);
 +
 +// GCLK0 - 10MHz clock
 +gpio_select_periph_A(GPIO_PIN_PA30,0);
please replace with tab or a simple space.
 +// GCLK1 - 25MHz clock
 +//gpio_select_periph_A(GPIO_PIN_PA31,0);
please remove dead code
 +
 +udelay(5000);
 +
 +// release phys reset
 +gpio_set_value(GPIO_PIN_PC18, 0);/* PHY RESET (Release)*/
 +
 +#if defined(CONFIG_MACB)
 +gpio_enable_macb0();
 +gpio_enable_macb1();
 +#endif
 +#if defined(CONFIG_MMC)
 +gpio_enable_mmci();
 +#endif
 +
 +return 0;
 +}
 +
 +phys_size_t initdram(int board_type)
 +{
 +unsigned long expected_size;
 +unsigned long actual_size;
 +void *sdram_base;
 +
 +sdram_base = map_physmem(EBI_SDRAM_BASE, EBI_SDRAM_SIZE, MAP_NOCACHE);
 +
 +expected_size = sdram_init(sdram_base, sdram_config);
 +actual_size = get_ram_size(sdram_base, expected_size);
 +
 +unmap_physmem(sdram_base, EBI_SDRAM_SIZE);
 +
 +if (expected_size != actual_size)
 +printf(Warning: Only %lu of %lu MiB SDRAM is working\n,
 +actual_size  20, expected_size  20);
 +
 +return actual_size;
 +}
 +
 +void board_init_info(void)
 +{
 +gd-bd-bi_phy_id[0] = 0x01;
 +gd-bd-bi_phy_id[1] = 0x03;
 +}
 +
 +/* SPI chip select control */
 +#ifdef CONFIG_ATMEL_SPI
 +#include spi.h
 +
 +int spi_cs_is_valid(unsigned int bus, unsigned int cs)
 +{
 +return bus == 0  cs == 0;
please replace by 
return (bus == 0)  (cs == 0);
 +}
 +
 +void spi_cs_activate(struct spi_slave *slave)
 +{
 +}
 +
 +void spi_cs_deactivate(struct spi_slave *slave)
 +{
 +}
 +#endif /* CONFIG_ATMEL_SPI */
 +
 +#ifdef CONFIG_CMD_NET
 +extern int macb_eth_initialize(int id, void *regs, unsigned int phy_addr);
 +
 +void board_eth_init(bd_t *bi)
 +{
 +macb_eth_initialize(0, (void *)MACB0_BASE, bi-bi_phy_id[0]);
 +macb_eth_initialize(1, (void *)MACB1_BASE, bi-bi_phy_id[1]);
 +}
 +#endif

 --- a/drivers/serial/atmel_usart.c
 +++ b/drivers/serial/atmel_usart.c
 @@ -21,6 +21,9 @@
 #include asm/io.h
 #include asm/arch/clk.h
 #include asm/arch/memory-map.h
 +#if defined(CONFIG_MIMC200_DBGLINK)
 +#include asm/arch/gpio.h
 +#endif
 
 #if defined(CONFIG_USART0)
 # define USART_ID0
 @@ -73,27 +76,67 @@ int serial_init(void)
 
 void serial_putc(char c)
 {
 +#if defined(CONFIG_MIMC200_DBGLINK)
 +// only output serial data if DEBUG link connected
 +// this is connected to PIOE_21
 +if (gpio_get_value(GPIO_PIN_PE21) == 0)
 +{
 +#endif
 +
 if (c == '\n')
 serial_putc('\r');
 
 while (!(usart3_readl(CSR)  USART3_BIT(TXRDY))) ;
 usart3_writel(THR, c);
 +
 +#if defined(CONFIG_MIMC200_DBGLINK)
 +}
 +#endif
 }
 
 void serial_puts(const char *s)
 {
 +#if defined(CONFIG_MIMC200_DBGLINK)
 +// only output serial data if DEBUG link connected
 +// this is connected to PIOE_21
 +if (gpio_get_value(GPIO_PIN_PE21) == 0)
 +{
 +#endif
 +
 while (*s)
 serial_putc(*s++);
 +
 +#if defined(CONFIG_MIMC200_DBGLINK)
 +}
 +#endif
 }
 
 int serial_getc(void)
 {
 +#if defined(CONFIG_MIMC200_DBGLINK)
 +// only get serial data if DEBUG link connected
 +// this is connected to PIOE_21
 +if (gpio_get_value(GPIO_PIN_PE21) == 1)
 +{
 +return 0;
 +}
 +#endif
 +
 while (!(usart3_readl(CSR)  USART3_BIT(RXRDY))) ;
 return usart3_readl(RHR);
 }
 
 int serial_tstc(void)
 {
 +#if defined(CONFIG_MIMC200_DBGLINK)
 +// only get serial data if DEBUG link connected
 +// this is connected to PIOE_21
 +if (gpio_get_value(GPIO_PIN_PE21) == 1)
 +{
 +return (1 == 0);
why not return 0?
 +}
 +#endif
 +
 return (usart3_readl(CSR)  USART3_BIT(RXRDY)) != 0;
 }
Could you do this with a more generic way?
Maybe not in the 

[U-Boot-Users] [PATCH] common: Move conditional compilation to Makefile

2008-07-27 Thread Jean-Christophe PLAGNIOL-VILLARD
From: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
 common/ACEX1K.c  |4 
 common/Makefile  |   42 +++---
 common/altera.c  |4 
 common/bedbug.c  |4 
 common/cmd_onenand.c |4 
 common/cyclon2.c |4 
 common/docecc.c  |4 
 common/fpga.c|4 
 common/lcd.c |4 
 common/lynxkdi.c |3 ---
 common/miiphybb.c|5 -
 common/soft_i2c.c|5 -
 common/soft_spi.c|4 
 common/spartan2.c|4 
 common/spartan3.c|4 
 common/stratixII.c   |4 
 common/usb.c |4 
 common/usb_kbd.c |5 -
 common/usb_storage.c |7 ---
 common/virtex2.c |3 ---
 common/xilinx.c  |4 
 21 files changed, 23 insertions(+), 103 deletions(-)

diff --git a/common/ACEX1K.c b/common/ACEX1K.c
index 76dc166..53677b8 100644
--- a/common/ACEX1K.c
+++ b/common/ACEX1K.c
@@ -28,8 +28,6 @@
 #include common.h/* core U-Boot definitions */
 #include ACEX1K.h/* ACEX device family */
 
-#if defined(CONFIG_FPGA)  defined(CONFIG_FPGA_ALTERA)  
defined(CONFIG_FPGA_ACEX1K)
-
 /* Define FPGA_DEBUG to get debug printf's */
 #ifdef FPGA_DEBUG
 #define PRINTF(fmt,args...)printf (fmt ,##args)
@@ -362,5 +360,3 @@ static int ACEX1K_ps_reloc (Altera_desc * desc, ulong 
reloc_offset)
return ret_val;
 
 }
-
-#endif /* CONFIG_FPGA  CONFIG_FPGA_ALTERA  CONFIG_FPGA_ACEX1K */
diff --git a/common/Makefile b/common/Makefile
index 4287108..454e844 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -28,9 +28,7 @@ LIB   = $(obj)libcommon.a
 AOBJS  =
 
 COBJS-y += main.o
-COBJS-y += ACEX1K.o
-COBJS-y += altera.o
-COBJS-y += bedbug.o
+COBJS-$(CONFIG_CMD_BEDBUG) += bedbug.o
 COBJS-y += circbuf.o
 COBJS-$(CONFIG_CMD_AMBAPP) += cmd_ambapp.o
 COBJS-y += cmd_autoscript.o
@@ -64,7 +62,18 @@ COBJS-$(CONFIG_OF_LIBFDT) += cmd_fdt.o fdt_support.o
 COBJS-$(CONFIG_CMD_FDOS) += cmd_fdos.o
 COBJS-$(CONFIG_CMD_FLASH) += cmd_flash.o
 ifdef CONFIG_FPGA
+COBJS-y += fpga.o
 COBJS-$(CONFIG_CMD_FPGA) += cmd_fpga.o
+COBJS-$(CONFIG_FPGA_SPARTAN2) += spartan2.o
+COBJS-$(CONFIG_FPGA_SPARTAN3) += spartan3.o
+COBJS-$(CONFIG_FPGA_VIRTEX2) += virtex2.o
+COBJS-$(CONFIG_FPGA_XILINX) += xilinx.o
+ifdef CONFIG_FPGA_ALTERA
+COBJS-y += altera.o
+COBJS-$(CONFIG_FPGA_ACEX1K) += ACEX1K.o
+COBJS-$(CONFIG_FPGA_CYCLON2) += cyclon2.o
+COBJS-$(CONFIG_FPGA_STRATIX_II) += stratixII.o
+endif
 endif
 COBJS-$(CONFIG_CMD_I2C) += cmd_i2c.o
 COBJS-$(CONFIG_CMD_IDE) += cmd_ide.o
@@ -80,7 +89,7 @@ COBJS-$(CONFIG_CMD_MMC) += cmd_mmc.o
 COBJS-y += cmd_nand.o
 COBJS-$(CONFIG_CMD_NET) += cmd_net.o
 COBJS-y += cmd_nvedit.o
-COBJS-y += cmd_onenand.o
+COBJS-$(CONFIG_CMD_ONENAND) += cmd_onenand.o
 COBJS-$(CONFIG_CMD_OTP) += cmd_otp.o
 ifdef CONFIG_PCI
 COBJS-$(CONFIG_CMD_PCI) += cmd_pci.o
@@ -101,11 +110,9 @@ COBJS-$(CONFIG_CMD_XIMG) += cmd_ximg.o
 COBJS-y += cmd_vfd.o
 COBJS-y += command.o
 COBJS-y += console.o
-COBJS-y += cyclon2.o
-COBJS-y += stratixII.o
 COBJS-y += devices.o
 COBJS-y += dlmalloc.o
-COBJS-y += docecc.o
+COBJS-$(CONFIG_CMD_DOC) += docecc.o
 COBJS-y += environment.o
 COBJS-y += env_common.o
 COBJS-y += env_nand.o
@@ -118,26 +125,23 @@ COBJS-y += env_nvram.o
 COBJS-y += env_nowhere.o
 COBJS-y += exports.o
 COBJS-y += flash.o
-COBJS-y += fpga.o
 COBJS-y += hush.o
 COBJS-y += kgdb.o
-COBJS-y += lcd.o
+COBJS-$(CONFIG_LCD) += lcd.o
 COBJS-y += lists.o
-COBJS-y += lynxkdi.o
+COBJS-$(CONFIG_LYNXKDI) += lynxkdi.o
 COBJS-y += memsize.o
-COBJS-y += miiphybb.o
+COBJS-$(CONFIG_BITBANGMII) += miiphybb.o
 COBJS-y += miiphyutil.o
 COBJS-y += s_record.o
 COBJS-y += serial.o
-COBJS-y += soft_i2c.o
-COBJS-y += soft_spi.o
-COBJS-y += spartan2.o
-COBJS-y += spartan3.o
+COBJS-$(CONFIG_SOFT_I2C) += soft_i2c.o
+COBJS-$(CONFIG_SOFT_SPI) += soft_spi.o
+ifdef CONFIG_CMD_USB
 COBJS-y += usb.o
-COBJS-y += usb_kbd.o
-COBJS-y += usb_storage.o
-COBJS-y += virtex2.o
-COBJS-y += xilinx.o
+COBJS-$(CONFIG_USB_STORAGE) += usb_storage.o
+endif
+COBJS-$(CONFIG_USB_KEYBOARD) += usb_kbd.o
 COBJS-y += crc16.o
 COBJS-y += xyzModem.o
 COBJS-y += cmd_mac.o
diff --git a/common/altera.c b/common/altera.c
index a2b5967..09dc0b2 100644
--- a/common/altera.c
+++ b/common/altera.c
@@ -41,8 +41,6 @@
 #define PRINTF(fmt,args...)
 #endif
 
-#if defined(CONFIG_FPGA)  defined(CONFIG_FPGA_ALTERA)
-
 /* Local Static Functions */
 static int altera_validate (Altera_desc * desc, const char *fn);
 
@@ -283,5 +281,3 @@ static int altera_validate (Altera_desc * desc, const char 
*fn)
 }
 
 /* - */
-
-#endif /* CONFIG_FPGA  CONFIG_FPGA_ALTERA */
diff --git a/common/bedbug.c b/common/bedbug.c
index 3bf1fc3..60109cf 100644
--- a/common/bedbug.c
+++ b/common/bedbug.c
@@ -2,8 +2,6 @@
 
 #include common.h
 
-#if defined(CONFIG_CMD_BEDBUG)
-
 #include linux

Re: [U-Boot-Users] [PATCH] common: Move conditional compilation to Makefile

2008-07-27 Thread Jean-Christophe PLAGNIOL-VILLARD
Please ignore wrong e-mail

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH V2] common: Move conditional compilation to Makefile

2008-07-27 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
Fix e-mail
 common/ACEX1K.c  |4 
 common/Makefile  |   42 +++---
 common/altera.c  |4 
 common/bedbug.c  |4 
 common/cmd_onenand.c |4 
 common/cyclon2.c |4 
 common/docecc.c  |4 
 common/fpga.c|4 
 common/lcd.c |4 
 common/lynxkdi.c |3 ---
 common/miiphybb.c|5 -
 common/soft_i2c.c|5 -
 common/soft_spi.c|4 
 common/spartan2.c|4 
 common/spartan3.c|4 
 common/stratixII.c   |4 
 common/usb.c |4 
 common/usb_kbd.c |5 -
 common/usb_storage.c |7 ---
 common/virtex2.c |3 ---
 common/xilinx.c  |4 
 21 files changed, 23 insertions(+), 103 deletions(-)

diff --git a/common/ACEX1K.c b/common/ACEX1K.c
index 76dc166..53677b8 100644
--- a/common/ACEX1K.c
+++ b/common/ACEX1K.c
@@ -28,8 +28,6 @@
 #include common.h/* core U-Boot definitions */
 #include ACEX1K.h/* ACEX device family */
 
-#if defined(CONFIG_FPGA)  defined(CONFIG_FPGA_ALTERA)  
defined(CONFIG_FPGA_ACEX1K)
-
 /* Define FPGA_DEBUG to get debug printf's */
 #ifdef FPGA_DEBUG
 #define PRINTF(fmt,args...)printf (fmt ,##args)
@@ -362,5 +360,3 @@ static int ACEX1K_ps_reloc (Altera_desc * desc, ulong 
reloc_offset)
return ret_val;
 
 }
-
-#endif /* CONFIG_FPGA  CONFIG_FPGA_ALTERA  CONFIG_FPGA_ACEX1K */
diff --git a/common/Makefile b/common/Makefile
index 4287108..454e844 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -28,9 +28,7 @@ LIB   = $(obj)libcommon.a
 AOBJS  =
 
 COBJS-y += main.o
-COBJS-y += ACEX1K.o
-COBJS-y += altera.o
-COBJS-y += bedbug.o
+COBJS-$(CONFIG_CMD_BEDBUG) += bedbug.o
 COBJS-y += circbuf.o
 COBJS-$(CONFIG_CMD_AMBAPP) += cmd_ambapp.o
 COBJS-y += cmd_autoscript.o
@@ -64,7 +62,18 @@ COBJS-$(CONFIG_OF_LIBFDT) += cmd_fdt.o fdt_support.o
 COBJS-$(CONFIG_CMD_FDOS) += cmd_fdos.o
 COBJS-$(CONFIG_CMD_FLASH) += cmd_flash.o
 ifdef CONFIG_FPGA
+COBJS-y += fpga.o
 COBJS-$(CONFIG_CMD_FPGA) += cmd_fpga.o
+COBJS-$(CONFIG_FPGA_SPARTAN2) += spartan2.o
+COBJS-$(CONFIG_FPGA_SPARTAN3) += spartan3.o
+COBJS-$(CONFIG_FPGA_VIRTEX2) += virtex2.o
+COBJS-$(CONFIG_FPGA_XILINX) += xilinx.o
+ifdef CONFIG_FPGA_ALTERA
+COBJS-y += altera.o
+COBJS-$(CONFIG_FPGA_ACEX1K) += ACEX1K.o
+COBJS-$(CONFIG_FPGA_CYCLON2) += cyclon2.o
+COBJS-$(CONFIG_FPGA_STRATIX_II) += stratixII.o
+endif
 endif
 COBJS-$(CONFIG_CMD_I2C) += cmd_i2c.o
 COBJS-$(CONFIG_CMD_IDE) += cmd_ide.o
@@ -80,7 +89,7 @@ COBJS-$(CONFIG_CMD_MMC) += cmd_mmc.o
 COBJS-y += cmd_nand.o
 COBJS-$(CONFIG_CMD_NET) += cmd_net.o
 COBJS-y += cmd_nvedit.o
-COBJS-y += cmd_onenand.o
+COBJS-$(CONFIG_CMD_ONENAND) += cmd_onenand.o
 COBJS-$(CONFIG_CMD_OTP) += cmd_otp.o
 ifdef CONFIG_PCI
 COBJS-$(CONFIG_CMD_PCI) += cmd_pci.o
@@ -101,11 +110,9 @@ COBJS-$(CONFIG_CMD_XIMG) += cmd_ximg.o
 COBJS-y += cmd_vfd.o
 COBJS-y += command.o
 COBJS-y += console.o
-COBJS-y += cyclon2.o
-COBJS-y += stratixII.o
 COBJS-y += devices.o
 COBJS-y += dlmalloc.o
-COBJS-y += docecc.o
+COBJS-$(CONFIG_CMD_DOC) += docecc.o
 COBJS-y += environment.o
 COBJS-y += env_common.o
 COBJS-y += env_nand.o
@@ -118,26 +125,23 @@ COBJS-y += env_nvram.o
 COBJS-y += env_nowhere.o
 COBJS-y += exports.o
 COBJS-y += flash.o
-COBJS-y += fpga.o
 COBJS-y += hush.o
 COBJS-y += kgdb.o
-COBJS-y += lcd.o
+COBJS-$(CONFIG_LCD) += lcd.o
 COBJS-y += lists.o
-COBJS-y += lynxkdi.o
+COBJS-$(CONFIG_LYNXKDI) += lynxkdi.o
 COBJS-y += memsize.o
-COBJS-y += miiphybb.o
+COBJS-$(CONFIG_BITBANGMII) += miiphybb.o
 COBJS-y += miiphyutil.o
 COBJS-y += s_record.o
 COBJS-y += serial.o
-COBJS-y += soft_i2c.o
-COBJS-y += soft_spi.o
-COBJS-y += spartan2.o
-COBJS-y += spartan3.o
+COBJS-$(CONFIG_SOFT_I2C) += soft_i2c.o
+COBJS-$(CONFIG_SOFT_SPI) += soft_spi.o
+ifdef CONFIG_CMD_USB
 COBJS-y += usb.o
-COBJS-y += usb_kbd.o
-COBJS-y += usb_storage.o
-COBJS-y += virtex2.o
-COBJS-y += xilinx.o
+COBJS-$(CONFIG_USB_STORAGE) += usb_storage.o
+endif
+COBJS-$(CONFIG_USB_KEYBOARD) += usb_kbd.o
 COBJS-y += crc16.o
 COBJS-y += xyzModem.o
 COBJS-y += cmd_mac.o
diff --git a/common/altera.c b/common/altera.c
index a2b5967..09dc0b2 100644
--- a/common/altera.c
+++ b/common/altera.c
@@ -41,8 +41,6 @@
 #define PRINTF(fmt,args...)
 #endif
 
-#if defined(CONFIG_FPGA)  defined(CONFIG_FPGA_ALTERA)
-
 /* Local Static Functions */
 static int altera_validate (Altera_desc * desc, const char *fn);
 
@@ -283,5 +281,3 @@ static int altera_validate (Altera_desc * desc, const char 
*fn)
 }
 
 /* - */
-
-#endif /* CONFIG_FPGA  CONFIG_FPGA_ALTERA */
diff --git a/common/bedbug.c b/common/bedbug.c
index 3bf1fc3..60109cf 100644
--- a/common/bedbug.c
+++ b/common/bedbug.c
@@ -2,8 +2,6 @@
 
 #include common.h
 
-#if defined(CONFIG_CMD_BEDBUG)
-
 #include linux/ctype.h
 #include bedbug/bedbug.h
 #include bedbug

[U-Boot-Users] [PATCH] Fix more printf() format warnings

2008-07-27 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
 common/cmd_flash.c |4 ++--
 drivers/usb/usbdcore.c |2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/common/cmd_flash.c b/common/cmd_flash.c
index a7f66dd..18d2250 100644
--- a/common/cmd_flash.c
+++ b/common/cmd_flash.c
@@ -342,7 +342,7 @@ int do_flerase (cmd_tbl_t *cmdtp, int flag, int argc, char 
*argv[])
puts (Bad sector specification\n);
return 1;
}
-   printf (Erase Flash Sectors %d-%d in Bank # %d ,
+   printf (Erase Flash Sectors %d-%d in Bank # %zu ,
sect_first, sect_last, (info-flash_info)+1);
rcode = flash_erase(info, sect_first, sect_last);
return rcode;
@@ -534,7 +534,7 @@ int do_protect (cmd_tbl_t *cmdtp, int flag, int argc, char 
*argv[])
puts (Bad sector specification\n);
return 1;
}
-   printf(%sProtect Flash Sectors %d-%d in Bank # %d\n,
+   printf(%sProtect Flash Sectors %d-%d in Bank # %zu\n,
p ?  : Un-, sect_first, sect_last,
(info-flash_info)+1);
for (i = sect_first; i = sect_last; i++) {
diff --git a/drivers/usb/usbdcore.c b/drivers/usb/usbdcore.c
index 808da9f..53ed669 100644
--- a/drivers/usb/usbdcore.c
+++ b/drivers/usb/usbdcore.c
@@ -552,7 +552,7 @@ struct urb *usbd_alloc_urb (struct usb_device_instance 
*device,
struct urb *urb;
 
if (!(urb = (struct urb *) malloc (sizeof (struct urb {
-   usberr ( F A T A L:  malloc(%u) FAILED,
+   usberr ( F A T A L:  malloc(%zu) FAILED,
sizeof (struct urb));
return NULL;
}
-- 
1.5.6


-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 1/1] Add support for ATMELAT91SAM9G20EKboard

2008-07-26 Thread Jean-Christophe PLAGNIOL-VILLARD
  
 
 As I see it, CONFIG_AT91 would mean that you have a 
 a certain class of peripherals which is developed for the 
 AT91 range of processors (and is used by the AVR32 as well)
 The name is probably slightly misleading, but convenient.
 
 Not having this definition, will soon mean that you have statements
 like the following:
 
 #if  defined(CONFIG_AT91RM9200) || \
 defined(CONFIG_AT91SAM9260) || \
 defined(CONFIG_AT91SAM9261) || \
 defined(CONFIG_AT91SAM9263) || \
 defined(CONFIG_AT91SAM9G10) || \
 defined(CONFIG_AT91SAM9G15) || \
 defined(CONFIG_AT91SAM9G20) || \
 defined(CONFIG_AT91SAM9G41) || \
 defined(CONFIG_AT91SAM9M10) || \
 defined(CONFIG_AT91SAM9M11) || \
 defined(CONFIG_AT91CAP9) || \
 defined(CONFIG_AT572D940)
 
 This statement will have to be updated every time a new MCU is released.
 
 Having the statment 
 #if  defined(CONFIG_AT91)
 
 should definitely reduce the maintenance of drivers.
I fully agree with Ulf, we need to have a better CONFIG, but I'm not
sure that CONFIG_AT91 is the right one

We have actually in the tree the following CPU
CONFIG_AT91CAP9
CONFIG_AT91RM9200
CONFIG_AT91SAM9260
CONFIG_AT91SAM9261
CONFIG_AT91SAM9263
CONFIG_AT91SAM9RL

and as mention Ulf are going to have more and more

maybe we can use config related to the functionnality or the sub-class
CPU
ex :
CONFIG_MACB_INCLK

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] USB Uboot on OSK5912

2008-07-26 Thread Jean-Christophe PLAGNIOL-VILLARD
On 16:46 Fri 25 Jul , Hunter, Jon wrote:
 Hello!
 
   I am working on getting USB-uboot working on OSK5912.
   from linux USB gadget device controller drivers (i.e.
   kernel/drivers/usb/gadget/) it looks like
   USB core for omap1510 and OSK5912 is same..But not sure, please confirm
 
  No idea. You will have to RTFM.
 
 RTFM indeed ;-) However, sadly TI does not always make this easy as some of 
 the documentation for these devices is only available under NDA...boo! If you 
 are having problem locating the fine manual for OMAP1510 purposes you can 
 refer to the OMAP5910 device as this is pretty much the same device. 
 Documentation for the OMAP5910 can be found here:

Due to the fact thath the documentation is under NDA and you have access
to it. Could you send a patch for it?

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] Changing u-boot relocation scheme

2008-07-26 Thread Jean-Christophe PLAGNIOL-VILLARD
On 01:57 Sat 26 Jul , Grant Likely wrote:
 On Fri, Jul 25, 2008 at 1:28 PM, kenneth johansson [EMAIL PROTECTED] wrote:
  I was afraid that what was needed was more or less a complete linker but
  it looks like if one generate the dynamic reloc table a much simpler
  linker(relocation function) is needed. Still probably a lot more complex
  than the GOT and fixup code that is just a loop over a table. We may
  need a case also ;-)
 
 The GOT relocation works.  It works really well.  As long as gcc and
 ld put the correct GOT bits into the GOT table.  It seems not all
 versions of gcc do it in the same way with the same flags.

Why not set the code depending on the GCC version?

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH] omap1510: fix usbtty support

2008-07-26 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
 drivers/serial/usbtty.c |   10 +-
 drivers/serial/usbtty.h |7 ++-
 drivers/usb/usbdcore_omap1510.c |   16 
 include/usbdcore_omap1510.h |6 +++---
 4 files changed, 26 insertions(+), 13 deletions(-)

diff --git a/drivers/serial/usbtty.c b/drivers/serial/usbtty.c
index 2bc5c3c..e6edb79 100644
--- a/drivers/serial/usbtty.c
+++ b/drivers/serial/usbtty.c
@@ -25,13 +25,13 @@
 
 #ifdef CONFIG_USB_TTY
 
+#include config.h/* If defined, override Linux identifiers with
+* vendor specific ones */
 #include circbuf.h
 #include devices.h
 #include usbtty.h
 #include usb_cdc_acm.h
 #include usbdescriptors.h
-#include config.h/* If defined, override Linux identifiers with
-* vendor specific ones */
 
 #if 0
 #define TTYDBG(fmt,args...)\
@@ -155,7 +155,7 @@ struct acm_config_desc {
/* Slave Interface */
struct usb_interface_descriptor data_class_interface;
struct usb_endpoint_descriptor
-   data_endpoints[NUM_ENDPOINTS-1] __attribute__((packed));
+   data_endpoints[NUM_ENDPOINTS-1];
 } __attribute__((packed));
 
 static struct acm_config_desc acm_configuration_descriptors[NUM_CONFIGS] = {
@@ -285,9 +285,9 @@ struct gserial_config_desc {
 
struct usb_configuration_descriptor configuration_desc;
struct usb_interface_descriptor
-   interface_desc[NUM_GSERIAL_INTERFACES] __attribute__((packed));
+   interface_desc[NUM_GSERIAL_INTERFACES];
struct usb_endpoint_descriptor
-   data_endpoints[NUM_ENDPOINTS] __attribute__((packed));
+   data_endpoints[NUM_ENDPOINTS];
 
 } __attribute__((packed));
 
diff --git a/drivers/serial/usbtty.h b/drivers/serial/usbtty.h
index 71c47bc..74098f7 100644
--- a/drivers/serial/usbtty.h
+++ b/drivers/serial/usbtty.h
@@ -36,12 +36,17 @@
 /* If no VendorID/ProductID is defined in config.h, pretend to be Linux
  * DO NOT Reuse this Vendor/Product setup with protocol incompatible devices */
 
+#ifndef CONFIG_USBD_VENDORID
 #define CONFIG_USBD_VENDORID 0x0525/* Linux/NetChip */
+#endif
 #define CONFIG_USBD_PRODUCTID_GSERIAL 0xa4a6   /* gserial */
 #define CONFIG_USBD_PRODUCTID_CDCACM  0xa4a7   /* CDC ACM */
+#ifndef CONFIG_USBD_MANUFACTURER
 #define CONFIG_USBD_MANUFACTURER Das U-Boot
+#endif
+#ifndef CONFIG_USBD_PRODUCT_NAME
 #define CONFIG_USBD_PRODUCT_NAME U_BOOT_VERSION
-
+#endif
 
 #define CONFIG_USBD_CONFIGURATION_STR TTY via USB
 
diff --git a/drivers/usb/usbdcore_omap1510.c b/drivers/usb/usbdcore_omap1510.c
index 84bb936..e51e066 100644
--- a/drivers/usb/usbdcore_omap1510.c
+++ b/drivers/usb/usbdcore_omap1510.c
@@ -452,7 +452,7 @@ static void omap1510_prepare_for_control_write_status 
(struct urb *urb)
outw (UDC_EP_Dir, UDC_EP_NUM);
 }
 
-/* udc_state_transition_up
+/* dc_state_transition_up
  * udc_state_transition_down
  *
  * Helper functions to implement device state changes. The device states and
@@ -1064,10 +1064,14 @@ void omap1510_udc_noniso_irq (void)
  */
 
 /* Called to start packet transmission. */
-void udc_endpoint_write (struct usb_endpoint_instance *endpoint)
+int udc_endpoint_write (struct usb_endpoint_instance *endpoint)
 {
-   unsigned short epnum =
-   endpoint-endpoint_address  USB_ENDPOINT_NUMBER_MASK;
+   unsigned short epnum;
+
+   if (!udc_device || !endpoint)
+   return -1;
+
+   epnum = endpoint-endpoint_address  USB_ENDPOINT_NUMBER_MASK;
 
UDCDBGA (Starting transmit on ep %x, epnum);
 
@@ -1080,7 +1084,11 @@ void udc_endpoint_write (struct usb_endpoint_instance 
*endpoint)
outw (UDC_Set_FIFO_En, UDC_CTRL);
/* deselect the endpoint FIFO */
outw (UDC_EP_Dir | epnum, UDC_EP_NUM);
+   } else {
+   return -1;
}
+
+   return 0;
 }
 
 /* Start to initialize h/w stuff */
diff --git a/include/usbdcore_omap1510.h b/include/usbdcore_omap1510.h
index 526fcd9..ecc94f7 100644
--- a/include/usbdcore_omap1510.h
+++ b/include/usbdcore_omap1510.h
@@ -168,8 +168,8 @@
 #define UDC_IN_ENDPOINT1
 #define UDC_IN_PACKET_SIZE 64
 #define UDC_INT_ENDPOINT 5
-#define UDC_INT_PKTSIZE16
-#define UDC_BULK_PKTSIZE 16
+#define UDC_INT_PACKET_SIZE 16
+#define UDC_BULK_PACKET_SIZE 16
 
 void udc_irq (void);
 /* Flow control */
@@ -177,7 +177,7 @@ void udc_set_nak(int epid);
 void udc_unset_nak (int epid);
 
 /* Higher level functions for abstracting away from specific device */
-void udc_endpoint_write(struct usb_endpoint_instance *endpoint);
+int udc_endpoint_write(struct usb_endpoint_instance *endpoint);
 
 int  udc_init (void);
 
-- 
1.5.6.2


-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based

Re: [U-Boot-Users] [PATCH] Fix duplicated flash state

2008-07-25 Thread Jean-Christophe PLAGNIOL-VILLARD
Please stop to post in HTML.
Please post in text

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH] Fix remaining CFG_CMD_ define, ifdef and comments

2008-07-25 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
 board/ids8247/ids8247.c  |2 +-
 common/cmd_bootm.c   |4 ++--
 include/configs/MVBC_P.h |4 ++--
 include/configs/m501sk.h |2 +-
 lib_sparc/board.c|4 ++--
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/board/ids8247/ids8247.c b/board/ids8247/ids8247.c
index 44fc79c..065014a 100644
--- a/board/ids8247/ids8247.c
+++ b/board/ids8247/ids8247.c
@@ -321,7 +321,7 @@ nand_init (void)
printf (%4lu MB\n, totlen 20);
 }
 
-#endif /* CFG_CMD_NAND */
+#endif /* CONFIG_CMD_NAND */
 
 #if defined(CONFIG_OF_BOARD_SETUP)  defined(CONFIG_OF_LIBFDT)
 /*
diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
index 1c0a416..4040a69 100644
--- a/common/cmd_bootm.c
+++ b/common/cmd_bootm.c
@@ -36,7 +36,7 @@
 #include lmb.h
 #include asm/byteorder.h
 
-#if (CONFIG_COMMANDS  CFG_CMD_USB)
+#if (CONFIG_CMD_USB)
 #include usb.h
 #endif
 
@@ -217,7 +217,7 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char 
*argv[])
 */
iflag = disable_interrupts();
 
-#if (CONFIG_COMMANDS  CFG_CMD_USB)
+#if (CONFIG_CMD_USB)
/*
 * turn off USB to prevent the host controller from writing to the
 * SDRAM while Linux is booting. This could happen (at least for OHCI
diff --git a/include/configs/MVBC_P.h b/include/configs/MVBC_P.h
index 04580b7..ff6f6cc 100644
--- a/include/configs/MVBC_P.h
+++ b/include/configs/MVBC_P.h
@@ -40,7 +40,7 @@
 #define CONFIG_MISC_INIT_R 1
 
 #define CFG_CACHELINE_SIZE 32
-#if (CONFIG_COMMANDS  CFG_CMD_KGDB)
+#if (CONFIG_CMD_KGDB)
 #define CFG_CACHELINE_SHIFT5
 #endif
 
@@ -268,7 +268,7 @@
 #define CFG_PROMPT_HUSH_PS2 
 #undef CFG_LONGHELP
 #define CFG_PROMPT = 
-#if (CONFIG_COMMANDS  CFG_CMD_KGDB)
+#if (CONFIG_CMD_KGDB)
 #define CFG_CBSIZE 1024
 #else
 #define CFG_CBSIZE 256
diff --git a/include/configs/m501sk.h b/include/configs/m501sk.h
index 095fdaf..060330e 100644
--- a/include/configs/m501sk.h
+++ b/include/configs/m501sk.h
@@ -105,7 +105,7 @@
 #defineCONFIG_EXTRA_ENV_SETTINGS \
unlock=yes\0
 
-#define CFG_CMD_JFFS2
+#define CONFIG_CMD_JFFS2
 #undef CONFIG_CMD_EEPROM
 #define CONFIG_CMD_NET
 #define CONFIG_CMD_RUN
diff --git a/lib_sparc/board.c b/lib_sparc/board.c
index af301c0..205a8ca 100644
--- a/lib_sparc/board.c
+++ b/lib_sparc/board.c
@@ -451,7 +451,7 @@ void board_init_f(ulong bootflag)
if ((s = getenv(bootfile)) != NULL) {
copy_filename(BootFile, s, sizeof(BootFile));
}
-#endif /* CFG_CMD_NET */
+#endif /* CONFIG_CMD_NET */
 
WATCHDOG_RESET();
 
@@ -483,7 +483,7 @@ void board_init_f(ulong bootflag)
WATCHDOG_RESET();
puts(IDE:   );
ide_init();
-#endif /* CFG_CMD_IDE */
+#endif /* CONFIG_CMD_IDE */
 
 #ifdef CONFIG_LAST_STAGE_INIT
WATCHDOG_RESET();
-- 
1.5.6


-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 1/1] Add support for ATMEL AT91SAM9G20EK board

2008-07-24 Thread Jean-Christophe PLAGNIOL-VILLARD
On 15:41 Thu 24 Jul , Hong Xu wrote:
 From 81230b02610c06fdc8a175e635851346488e3bdb Mon Sep 17 00:00:00 2001
 From: Hong Xu [EMAIL PROTECTED]
 Date: Thu, 24 Jul 2008 14:25:05 +0800
 Subject: [PATCH 1/1] Add support for ATMEL AT91SAM9G20EK board

 This patch adds support for ATMEL AT91SAM9G20EK board.
 User manual for AT91SAM9G20EK board, see
 http://www.atmel.com/dyn/resources/prod_documents/doc6413.pdf
 AT91 SAM9G20 datasheet, see
 http://www.atmel.com/dyn/resources/prod_documents/doc6384.pdf


 Signed-off-by: Hong Xu [EMAIL PROTECTED]
 ---
  Makefile  |3 +
  board/atmel/at91sam9g20ek/Makefile|   57 +++
  board/atmel/at91sam9g20ek/at91sam9g20ek.c |  250 
 +
  board/atmel/at91sam9g20ek/config.mk   |1 +
  board/atmel/at91sam9g20ek/led.c   |   64 
  board/atmel/at91sam9g20ek/nand.c  |   79 +
  board/atmel/at91sam9g20ek/partition.c |   40 +
  drivers/net/macb.c|4 +-
  include/asm-arm/arch-at91sam9/hardware.h  |2 +-
  include/configs/at91sam9g20ek.h   |  202 +++
  include/asm-arm/arch-at91sam9/hardware.h  |2 +-
  include/configs/at91sam9g20ek.h   |  202 +++
  net/eth.c |2 +-
Please rebase your code on the branch for-1.3.5 of the u-boot-at91 tree.

 --- a/drivers/net/macb.c
 +++ b/drivers/net/macb.c
 @@ -415,14 +415,14 @@ static int macb_init(struct eth_device *netdev, bd_t 
 *bd)
   /* choose RMII or MII mode. This depends on the board */
  #ifdef CONFIG_RMII
  #if defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
 -defined(CONFIG_AT91SAM9263)
 +defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20)
   macb_writel(macb, USRIO, MACB_BIT(RMII) | MACB_BIT(CLKEN));
  #else
   macb_writel(macb, USRIO, 0);
  #endif
  #else
  #if defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
 -defined(CONFIG_AT91SAM9263)
 +defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20)
   macb_writel(macb, USRIO, MACB_BIT(CLKEN));
  #else
   macb_writel(macb, USRIO, MACB_BIT(MII));
 diff --git a/net/eth.c b/net/eth.c
 index 38979aa..3f50e2b 100644
 --- a/net/eth.c
 +++ b/net/eth.c
 @@ -287,7 +287,7 @@ int eth_initialize(bd_t *bis)
   mcdmafec_initialize(bis);
  #endif
  #if defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
 -defined(CONFIG_AT91SAM9263)
 +defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20)
   at91sam9_eth_initialize(bis);
  #endif
   at91sam9_eth_initialize(bis);
  #endif

Same comment as Haavard,
Could please create a CONFIG_SOMETHING for each of this tree block of
ifdef (not neccessarely the same CONFIG)

Best Regards,
J.


-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] Add support for the hammerhead (AVR32) board

2008-07-24 Thread Jean-Christophe PLAGNIOL-VILLARD
On 16:16 Thu 24 Jul , Haavard Skinnemoen wrote:
 From: Julien May [EMAIL PROTECTED]
 
 The Hammerhead platform is built around a AVR32 32-bit microcontroller
 from Atmel.  It offers versatile peripherals, such as ethernet, usb
 device, usb host etc.
 
 The board also incooperates a power supply and is a Power over Ethernet
 (PoE) Powered Device (PD).
 
 Additonally, a Cyclone III FPGA from Altera is integrated on the board.
 The FPGA is mapped into the 32-bit AVR memory bus. The FPGA offers two
 DDR2 SDRAM interfaces, which will cover even the most exceptional need
 of memory bandwidth. Together with the onboard video decoder the board
 is ready for video processing.
 
 For more information see: http:///www.miromico.com/hammerhead
 
 Signed-off-by: Julien May [EMAIL PROTECTED]
 [EMAIL PROTECTED]: various small fixes and adaptions]
 Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED]
 ---
  MAINTAINERS |5 +
  MAKEALL |1 +
  Makefile|3 +
  board/miromico/hammerhead/Makefile  |   40 +++
  board/miromico/hammerhead/config.mk |3 +
  board/miromico/hammerhead/hammerhead.c  |  114 
  board/miromico/hammerhead/u-boot.lds|   73 +
  cpu/at32ap/at32ap700x/sm.h  |2 +-
  cpu/at32ap/cpu.c|3 +
  include/asm-avr32/arch-at32ap700x/clk.h |1 +
  include/configs/hammerhead.h|  172 
 +++
  11 files changed, 416 insertions(+), 1 deletions(-)
  create mode 100644 board/miromico/hammerhead/Makefile
  create mode 100644 board/miromico/hammerhead/config.mk
  create mode 100644 board/miromico/hammerhead/hammerhead.c
  create mode 100644 board/miromico/hammerhead/u-boot.lds
  create mode 100644 include/configs/hammerhead.h
 
 diff --git a/MAINTAINERS b/MAINTAINERS
 index cbe5c47..bcac300 100644
 --- a/MAINTAINERS
 +++ b/MAINTAINERS
 @@ -709,6 +709,11 @@ Haavard Skinnemoen [EMAIL PROTECTED]
   ATSTK1006   AT32AP7000
   ATNGW100AT32AP7000
  
 +Alex Raimondi [EMAIL PROTECTED]
 +Julien May [EMAIL PROTECTED]
IMHO, it's supposed to have only one board Maintainer
 +
 + HAMMERHEAD  AT32AP7000
 +
  #
  # SuperH Systems:#
  ##

 diff --git a/cpu/at32ap/at32ap700x/sm.h b/cpu/at32ap/at32ap700x/sm.h
 index 6492c8e..b6e4409 100644
 --- a/cpu/at32ap/at32ap700x/sm.h
 +++ b/cpu/at32ap/at32ap700x/sm.h
 @@ -21,7 +21,7 @@
  #define SM_PM_IMR0x0048
  #define SM_PM_ISR0x004c
  #define SM_PM_ICR0x0050
 -#define SM_PM_GCCTRL 0x0060
 +#define SM_PM_GCCTRL(x)  (0x0060 + 4 * x)
why do you modify? As I see it's never used.
  #define SM_RTC_CTRL  0x0080
  #define SM_RTC_VAL   0x0084
  #define SM_RTC_TOP   0x0088

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [patch 1/1] Set GD_FLG_RELOC for boards skipping relocation to RAM

2008-07-22 Thread Jean-Christophe PLAGNIOL-VILLARD
On 14:20 Tue 22 Jul , Remy Bohmer wrote:
 If CONFIG_SKIP_RELOCATE_UBOOT is set the flag GD_FLG_RELOC is usually never
 set, because relocation to RAM is actually never done by U-boot itself.
 However, several pieces of code check if this flag is set at some time.
 
 So, to make sure this flag is set on boards skipping relocation, this
 is added to the initialisation of U-boot at a moment where it is safe
 to do so.
 
 Signed-off-by: Remy Bohmer [EMAIL PROTECTED]
 ---
  lib_arm/board.c |   16 
  1 file changed, 16 insertions(+)
 
 Index: u-boot-git-almost-1.3.4/lib_arm/board.c
 ===
 --- u-boot-git-almost-1.3.4.orig/lib_arm/board.c  2008-07-21 
 11:53:23.0 +0200
 +++ u-boot-git-almost-1.3.4/lib_arm/board.c   2008-07-21 12:25:32.0 
 +0200
 @@ -233,6 +233,17 @@ static int init_func_i2c (void)
  }
  #endif
  
 +#ifdef CONFIG_SKIP_RELOCATE_UBOOT
 +/*
 + * This routine sets the relocation done flag, because even if
 + * relocation is skipped, the flag is used by other generic code.
 + */
 +static int reloc_init(void)
 +{
 + gd-flags |= GD_FLG_RELOC;
you need to return 0 at least
 +}
 +#endif
 +
  /*
   * Breathe some life into the board...
   *
 @@ -262,6 +273,11 @@ int print_cpuinfo (void); /* test-only *
  
  init_fnc_t *init_sequence[] = {
   cpu_init,   /* basic cpu dependent setup */
 +#if defined(CONFIG_SKIP_RELOCATE_UBOOT)
 + reloc_init, /* Set the relocation done flag, must
 +do this AFTER cpu_init(), but as soon
 +as possible */
 +#endif
   board_init, /* basic board dependent setup */
   interrupt_init, /* set up exceptions */
   env_init,   /* initialize environment */

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] Trouble with Make Command

2008-07-22 Thread Jean-Christophe PLAGNIOL-VILLARD
On 14:49 Tue 22 Jul , Rugunda, Solo wrote:
 Thanks Jerry and Nathan
 
 So I built the image by running the Make with the correct cross compiler
 from the uboot prompt. 
 
 The file produced is u-boot.bin.gz
u-boot.bin.gz? are you sure?
It's suppose to produce a elf u-boot and u-boot.bin.
You are suppose to burn the u-boot.bin to your flash

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] fsl-i2c: fix writes to data segment before relocation

2008-07-21 Thread Jean-Christophe PLAGNIOL-VILLARD
On 14:26 Mon 21 Jul , Timur Tabi wrote:
 Prevent i2c_init() in fsl_i2c.c from writing to the data segment before
 relocation.  Commit d8c82db4 added the ability for i2c_init() to program the
 I2C bus speed and save the value in i2c_bus_speed[], which is a global
 variable.  It is an error to write to the data segment before relocation,
 which is what i2c_init() does when it stores the bus speed in i2c_bus_speed[].
 
 Signed-off-by: Timur Tabi [EMAIL PROTECTED]
 ---
 
 Wolfgang, please apply this directly to fix the I2C bug we've been talking 
 about.
 
  drivers/i2c/fsl_i2c.c |9 +++--
  1 files changed, 7 insertions(+), 2 deletions(-)
 
 diff --git a/drivers/i2c/fsl_i2c.c b/drivers/i2c/fsl_i2c.c
 index 9f2c1ec..9d5df8a 100644
 --- a/drivers/i2c/fsl_i2c.c
 +++ b/drivers/i2c/fsl_i2c.c
 @@ -143,12 +143,15 @@ void
  i2c_init(int speed, int slaveadd)
  {
   struct fsl_i2c *dev;
 + unsigned int temp;
  
   dev = (struct fsl_i2c *) (CFG_IMMR + CFG_I2C_OFFSET);
  
   writeb(0, dev-cr);/* stop I2C controller */
   udelay(5);  /* let it shutdown in peace */
 - i2c_bus_speed[0] = set_i2c_bus_speed(dev, gd-i2c1_clk, speed);
 + temp = set_i2c_bus_speed(dev, gd-i2c1_clk, speed);
 + if (gd-flags  GD_FLG_RELOC)
Maybe a macro will more clear like
if(is_relacated())
i2c_bus_speed[0] = temp;

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTCSupport

2008-07-21 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:34 Mon 21 Jul , Gururaja Hebbar K R wrote:
 Hi,
 
Are you going to add a board which will use it?
   Right now i am using it on arm Versatile board. Should i send a
 patch 
   to that also
 
  If you do I can test it 
 
  Regards
  Peter
 
Could you please send your patch as inline, otherwise it's really
difficult to comment
use git-send-email as example

and also please read this http://www.denx.de/wiki/UBoot/Patches
and http://lwn.net/Articles/139918/

Best Regads,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] *** PROBABLY SPAM *** RE: [PATCH] (Resubmit) ADD ARM AMBA PL031 RTCSupport

2008-07-21 Thread Jean-Christophe PLAGNIOL-VILLARD
 +/* Enable RTC Start in Control register*/
 +void rtc_init(void)
 +{
 + RTC_WRITE_REG(RTC_CR,RTC_CR_MIE);
please replace by
RTC_WRITE_REG(RTC_CR, RTC_CR_MIE);
 + 
   ^
please remove this whitescpace
 + pl031_initted = 1;
 +}
 +
 +/*
 + * Reset the RTC. We set the date back to 1970-01-01.
 + */
 +void rtc_reset(void)
 +{
 + RTC_WRITE_REG(RTC_LR,0x00);
please replace by
RTC_WRITE_REG(RTC_LR, 0x00);
 + if(!pl031_initted)
 + rtc_init();
 +}
 +
 +/*
 + * Set the RTC
 +*/
 +void rtc_set(struct rtc_time *tmp)
 +{
 + unsigned long tim;
 + 
   ^
please remove this whitescpace
 + if(!pl031_initted)
 + rtc_init();
 +
 + if (tmp == NULL) {
 + puts(Error setting the date/time\n);
 + return;
 + }
 + 
   ^
please remove this whitescpace
 + /* Calculate number of seconds this incoming time represents */
 + tim = mktime(tmp-tm_year, tmp-tm_mon, tmp-tm_mday,
 + tmp-tm_hour, tmp-tm_min, tmp-tm_sec);
 +
 + RTC_WRITE_REG(RTC_LR,tim);
 +}
 +
 +/*
 + * Get the current time from the RTC
 + */
 +int rtc_get(struct rtc_time *tmp)
 +{
 + ulong tim;
 + 
   ^
please remove this whitescpace
 + if(!pl031_initted)
 + rtc_init();
 +
 + if (tmp == NULL) {
 + puts(Error getting the date/time\n);
 + return -1;
 + }
 +
 + tim = RTC_READ_REG(RTC_DR);
 + 
   ^
please remove this whitescpace
 + to_tm (tim, tmp);
 +
 + debug ( Get DATE: %4d-%02d-%02d (wday=%d)  TIME:
 %2d:%02d:%02d\n,
 + tmp-tm_year, tmp-tm_mon, tmp-tm_mday, tmp-tm_wday,
 + tmp-tm_hour, tmp-tm_min, tmp-tm_sec);
 +
 + return 0;
 +}
 +
 +#endif



-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTC Support

2008-07-17 Thread Jean-Christophe PLAGNIOL-VILLARD
Hi,

First your patch is line wrapped by your mailler.
Secondly please be care ful of the 80 chars limits and the
whitespace.

Are you going to add a board which will use it?

Best Regards,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH 0/1] vsprintf: add z and t options

2008-07-14 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
 lib_generic/vsprintf.c |   12 +---
 1 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/lib_generic/vsprintf.c b/lib_generic/vsprintf.c
index 3db6c3f..1d9b25b 100644
--- a/lib_generic/vsprintf.c
+++ b/lib_generic/vsprintf.c
@@ -262,7 +262,9 @@ int vsprintf(char *buf, const char *fmt, va_list args)
 
/* get the conversion qualifier */
qualifier = -1;
-   if (*fmt == 'h' || *fmt == 'l' || *fmt == 'q') {
+   if (*fmt == 'h' || *fmt == 'l' || *fmt == 'L' ||
+   *fmt =='Z' || *fmt == 'z' || *fmt == 't' ||
+   *fmt == 'q' ) {
qualifier = *fmt;
if (qualifier == 'l'  *(fmt+1) == 'l') {
qualifier = 'q';
@@ -355,9 +357,13 @@ int vsprintf(char *buf, const char *fmt, va_list args)
num = va_arg(args, unsigned long long);
else
 #endif
-   if (qualifier == 'l')
+   if (qualifier == 'l') {
num = va_arg(args, unsigned long);
-   else if (qualifier == 'h') {
+   } else if (qualifier == 'Z' || qualifier == 'z') {
+   num = va_arg(args, size_t);
+   } else if (qualifier == 't') {
+   num = va_arg(args, ptrdiff_t);
+   } else if (qualifier == 'h') {
num = (unsigned short) va_arg(args, int);
if (flags  SIGN)
num = (short) num;
-- 
1.5.6


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH 1/1] Fix some more printf() format issues.

2008-07-14 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
 common/cmd_flash.c |4 ++--
 drivers/usb/usbdcore.c |2 +-
 fs/jffs2/jffs2_1pass.c |4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/common/cmd_flash.c b/common/cmd_flash.c
index 9bd8074..d959c3d 100644
--- a/common/cmd_flash.c
+++ b/common/cmd_flash.c
@@ -342,7 +342,7 @@ int do_flerase (cmd_tbl_t *cmdtp, int flag, int argc, char 
*argv[])
puts (Bad sector specification\n);
return 1;
}
-   printf (Erase Flash Sectors %d-%d in Bank # %d ,
+   printf (Erase Flash Sectors %d-%d in Bank # %zu ,
sect_first, sect_last, (info-flash_info)+1);
rcode = flash_erase(info, sect_first, sect_last);
return rcode;
@@ -534,7 +534,7 @@ int do_protect (cmd_tbl_t *cmdtp, int flag, int argc, char 
*argv[])
puts (Bad sector specification\n);
return 1;
}
-   printf(%sProtect Flash Sectors %d-%d in Bank # %d\n,
+   printf(%sProtect Flash Sectors %d-%d in Bank # %zu\n,
p ?  : Un-, sect_first, sect_last,
(info-flash_info)+1);
for (i = sect_first; i = sect_last; i++) {
diff --git a/drivers/usb/usbdcore.c b/drivers/usb/usbdcore.c
index 808da9f..53ed669 100644
--- a/drivers/usb/usbdcore.c
+++ b/drivers/usb/usbdcore.c
@@ -552,7 +552,7 @@ struct urb *usbd_alloc_urb (struct usb_device_instance 
*device,
struct urb *urb;
 
if (!(urb = (struct urb *) malloc (sizeof (struct urb {
-   usberr ( F A T A L:  malloc(%u) FAILED,
+   usberr ( F A T A L:  malloc(%zu) FAILED,
sizeof (struct urb));
return NULL;
}
diff --git a/fs/jffs2/jffs2_1pass.c b/fs/jffs2/jffs2_1pass.c
index 5c1d265..3c454f6 100644
--- a/fs/jffs2/jffs2_1pass.c
+++ b/fs/jffs2/jffs2_1pass.c
@@ -1213,12 +1213,12 @@ jffs2_1pass_build_lists(struct part_info * part)
} else if (node-nodetype == 
JFFS2_NODETYPE_CLEANMARKER) {
if (node-totlen != sizeof(struct 
jffs2_unknown_node))
printf(OOPS Cleanmarker has bad size 
-   %d != %u\n, node-totlen,
+   %d != %zu\n, node-totlen,
sizeof(struct 
jffs2_unknown_node));
} else if (node-nodetype == JFFS2_NODETYPE_PADDING) {
if (node-totlen  sizeof(struct 
jffs2_unknown_node))
printf(OOPS Padding has bad size 
-   %d  %u\n, node-totlen,
+   %d  %zu\n, node-totlen,
sizeof(struct 
jffs2_unknown_node));
} else {
printf(Unknown node type: %x len %d 
-- 
1.5.6


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] Fix some more printf() format problems.

2008-07-14 Thread Jean-Christophe PLAGNIOL-VILLARD
On 09:42 Mon 14 Jul , Kumar Gala wrote:
 
 Signed-off-by: Kumar Gala [EMAIL PROTECTED]
 ---
  common/cmd_mp.c  |2 +-
  cpu/mpc85xx/mp.c |4 ++--
  2 files changed, 3 insertions(+), 3 deletions(-)
 
 diff --git a/common/cmd_mp.c b/common/cmd_mp.c
 index 26a57c5..59d0d15 100644
 --- a/common/cmd_mp.c
 +++ b/common/cmd_mp.c
 @@ -35,7 +35,7 @@ cpu_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 
   cpuid = simple_strtoul(argv[1], NULL, 10);
   if (cpuid = CONFIG_NR_CPUS) {
 - printf (Core num: %d is out of range[0..%d]\n,
 + printf (Core num: %ld is out of range[0..%d]\n,
is it not %lu? cpuid is a unsigned long.
   cpuid, CONFIG_NR_CPUS - 1);
   return 1;
   }
 diff --git a/cpu/mpc85xx/mp.c b/cpu/mpc85xx/mp.c
 index a527cf3..75ceba9 100644
 --- a/cpu/mpc85xx/mp.c
 +++ b/cpu/mpc85xx/mp.c
 @@ -50,12 +50,12 @@ int cpu_status(int nr)
 
   if (nr == id) {
   table = (u32 *)get_spin_addr();
 - printf(table base @ 0x%08x\n, table);
 + printf(table base @ 0x%08x\n, (u32)table);
why not use %p? it's a pointer.
   } else {
   table = (u32 *)get_spin_addr() + nr * NUM_BOOT_ENTRY;
   printf(Running on cpu %d\n, id);
   printf(\n);
 - printf(table @ 0x%08x:\n, table);
 + printf(table @ 0x%08x:\n, (u32)table);
same.
   printf(   addr - 0x%08x\n, table[BOOT_ENTRY_ADDR_LOWER]);
   printf(   pir  - 0x%08x\n, table[BOOT_ENTRY_PIR]);
   printf(   r3   - 0x%08x\n, table[BOOT_ENTRY_R3_LOWER]);
 -- 
 1.5.5.1
Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] Fix some more printf() format problems.

2008-07-14 Thread Jean-Christophe PLAGNIOL-VILLARD


 cpuid, CONFIG_NR_CPUS - 1);
 return 1;
 }
 diff --git a/cpu/mpc85xx/mp.c b/cpu/mpc85xx/mp.c
 index a527cf3..75ceba9 100644
 --- a/cpu/mpc85xx/mp.c
 +++ b/cpu/mpc85xx/mp.c
 @@ -50,12 +50,12 @@ int cpu_status(int nr)

 if (nr == id) {
 table = (u32 *)get_spin_addr();
 -   printf(table base @ 0x%08x\n, table);
 +   printf(table base @ 0x%08x\n, (u32)table);
 why not use %p? it's a pointer.

 do we support %p in u-boot?

yes we support it.

Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support (new version)

2008-07-14 Thread Jean-Christophe PLAGNIOL-VILLARD
On 17:26 Mon 14 Jul , Ricardo Ribalda Delgado wrote:
 -Add support to the ADT7460 Monitor Chip by Analog
 Devices.
 -Correct wrong previous coding style
 -Correct previous use of puts
please add this comment after the ---
 
 Signed-off-by: Ricardo Ribalda Delgado [EMAIL PROTECTED]
 ---
  drivers/hwmon/Makefile  |1 +
  drivers/hwmon/adt7460.c |   86 
 +++
  include/dtt.h   |3 +-
  3 files changed, 89 insertions(+), 1 deletions(-)
  create mode 100644 drivers/hwmon/adt7460.c
 
 diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
 index f09f145..7342b91 100644
 --- a/drivers/hwmon/Makefile
 +++ b/drivers/hwmon/Makefile
 @@ -37,6 +37,7 @@ COBJS-$(CONFIG_DTT_DS1775) += ds1775.o
  COBJS-$(CONFIG_DTT_LM73) += lm73.o
  COBJS-$(CONFIG_DTT_LM75) += lm75.o
  COBJS-$(CONFIG_DTT_LM81) += lm81.o
 +COBJS-$(CONFIG_DTT_ADT7460) += adt7460.o
  
  COBJS:= $(COBJS-y)
  SRCS := $(COBJS:.o=.c)
 diff --git a/drivers/hwmon/adt7460.c b/drivers/hwmon/adt7460.c
 new file mode 100644
 index 000..197d86c
 --- /dev/null
 +++ b/drivers/hwmon/adt7460.c
 @@ -0,0 +1,86 @@
 +/*   
 ^^^
please remove whitespace
 +(C) Copyright 2008
 +Ricado Ribalda-Universidad Autonoma de Madrid, [EMAIL PROTECTED]
 +This work has been supported by: Q-Technology  http://qtec.com/
 +
 +This program is free software: you can redistribute it and/or modify
 +it under the terms of the GNU General Public License as published by
 +the Free Software Foundation, either version 2 of the License, or
 +(at your option) any later version.
 +
 +This program is distributed in the hope that it will be useful,
 +but WITHOUT ANY WARRANTY; without even the implied warranty of
 +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 +GNU General Public License for more details.
 +
 +You should have received a copy of the GNU General Public License
 +along with this program.  If not, see http://www.gnu.org/licenses/.
 +*/
please use this style of comment
/*
 * .
 */
 +
 +#include common.h
 +#include i2c.h
 +#include dtt.h
 +
 +#define ADT7460_ADDRESS  0x2c
  ^
 +#define ADT7460_INVALID  128
  ^
please remove whitespace
 +#define ADT7460_CONFIG   0x40
 +#define ADT7460_REM1_TEMP0x25
 +#define ADT7460_LOCAL_TEMP   0x26
 +#define ADT7460_REM2_TEMP0x27
 +
 +
 +int dtt_get_temp(int sensor)
 +{
 + int aux;
 + u8 table[] =
 + { ADT7460_REM1_TEMP, ADT7460_LOCAL_TEMP, ADT7460_REM2_TEMP };
 +
 + if (sensor  2) {
 + puts(DTT sensor does not exist\n);
 + return -1;
 + }
 +
 + aux = dtt_read(0, table[sensor]);
 + if (aux == -1) {
 + puts(DTT temperature read failed\n);
 + return -1;
 +
Why no remove this empty line?
 + }
 +
 + return aux;
 +}
 diff --git a/include/dtt.h b/include/dtt.h
 index 34053d1..ce0fdfa 100644
 --- a/include/dtt.h
 +++ b/include/dtt.h
 @@ -32,7 +32,8 @@
  defined(CONFIG_DTT_DS1775) || \
  defined(CONFIG_DTT_LM81) || \
  defined(CONFIG_DTT_ADM1021) || \
 -defined(CONFIG_DTT_LM73)
 +defined(CONFIG_DTT_LM73) || \
 +defined(CONFIG_DTT_ADT7460)
Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] ARM pull request

2008-07-14 Thread Jean-Christophe PLAGNIOL-VILLARD
Hi,
please pull
The following changes since commit 348753d416cd2c9e7ec6520a544c8f33cf02a560:
  Kumar Gala (1):
Fix some more printf() format problems.

are available in the git repository at:

  git://git.denx.de/u-boot-arm.git master

Hugo Villeneuve (2):
  ARM DaVinci: Remove duplicate definitions of MACH_TYPE and prototype of 
i2c_init()
  ARM DaVinci: Remove extern phy_t declaration by moving code to proper 
place

 board/davinci/dv-evm/dv_board.c|9 +
 board/davinci/schmoogie/dv_board.c |9 +
 board/davinci/sffsdr/sffsdr.c  |6 +-
 board/davinci/sonata/dv_board.c|9 +
 cpu/arm926ejs/davinci/ether.c  |2 ++
 5 files changed, 6 insertions(+), 29 deletions(-)

Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 1/4] ARM DaVinci: Remove duplicate definitions of MACH_TYPE and prototype of i2c_init()

2008-07-14 Thread Jean-Christophe PLAGNIOL-VILLARD
On 15:10 Fri 11 Jul , Hugo Villeneuve wrote:
 ARM DaVinci: Remove duplicate definitions of MACH_TYPE
 and prototype of i2c_init().
 
 Signed-off-by: Hugo Villeneuve [EMAIL PROTECTED]
 
 ---
 
  board/davinci/dv-evm/dv_board.c|3 ---
  board/davinci/schmoogie/dv_board.c |3 ---
  board/davinci/sonata/dv_board.c|3 ---
  3 files changed, 0 insertions(+), 9 deletions(-)
 
Applied. Thanks.

Best regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 2/4] ARM DaVinci: Remove extern phy_t declaration by moving code to proper place

2008-07-14 Thread Jean-Christophe PLAGNIOL-VILLARD
On 15:10 Fri 11 Jul , Hugo Villeneuve wrote:
 ARM DaVinci: Remove extern phy_t declaration by moving
 code to proper place.
 
 Signed-off-by: Hugo Villeneuve [EMAIL PROTECTED]
 
 ---
 
  board/davinci/dv-evm/dv_board.c|6 +-
  board/davinci/schmoogie/dv_board.c |6 +-
  board/davinci/sffsdr/sffsdr.c  |6 +-
  board/davinci/sonata/dv_board.c|6 +-
  cpu/arm926ejs/davinci/ether.c  |2 ++
  5 files changed, 6 insertions(+), 20 deletions(-)
 
Applied. Thanks.

Best regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH] Fix some more printf() format issues.

2008-07-12 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
 board/armadillo/flash.c|2 +-
 board/delta/nand.c |2 +-
 board/integratorcp/flash.c |6 +++---
 board/mp2usb/flash.c   |2 +-
 board/versatile/flash.c|2 +-
 board/zylonite/nand.c  |2 +-
 common/cmd_flash.c |4 ++--
 common/cmd_nvedit.c|2 +-
 common/cmd_onenand.c   |4 ++--
 common/env_onenand.c   |2 +-
 cpu/pxa/mmc.c  |2 +-
 drivers/mtd/dataflash.c|2 +-
 drivers/net/smc911x.c  |4 ++--
 drivers/usb/usbdcore.c |2 +-
 fs/jffs2/jffs2_1pass.c |4 ++--
 net/net.c  |2 +-
 16 files changed, 22 insertions(+), 22 deletions(-)

diff --git a/board/armadillo/flash.c b/board/armadillo/flash.c
index 037a643..8518856 100644
--- a/board/armadillo/flash.c
+++ b/board/armadillo/flash.c
@@ -279,7 +279,7 @@ int write_buff (flash_info_t * info, uchar * src, ulong 
addr, ulong cnt)
int i, rc;
 
wp = (addr  ~1);   /* get lower word aligned address */
-   printf (Writing %d short data to 0x%p from 0x%p.\n , cnt, wp, src);
+   printf (Writing %lu short data to 0x%lx from 0x%p.\n , cnt, wp, src);
 
/*
 * handle unaligned start bytes
diff --git a/board/delta/nand.c b/board/delta/nand.c
index a635a65..5024056 100644
--- a/board/delta/nand.c
+++ b/board/delta/nand.c
@@ -254,7 +254,7 @@ static unsigned long dfc_wait_event(unsigned long event)
break;
}
if(get_delta(start)  timeout) {
-   DFC_DEBUG1(dfc_wait_event: TIMEOUT waiting for event: 
0x%x.\n, event);
+   DFC_DEBUG1(dfc_wait_event: TIMEOUT waiting for event: 
0x%lx.\n, event);
return 0xff00;
}
 
diff --git a/board/integratorcp/flash.c b/board/integratorcp/flash.c
index b653c05..59961cd 100644
--- a/board/integratorcp/flash.c
+++ b/board/integratorcp/flash.c
@@ -393,7 +393,7 @@ int flash_erase (flash_info_t * info, int s_first, int 
s_last)
*addr = (FPW) 0x00D000D0;
} else {
 #ifdef DEBUG
-   printf (Timeout,0x%08x\n, 
status);
+   printf (Timeout,0x%08lx\n, 
status);
 #else
printf(Timeout\n);
 #endif
@@ -515,7 +515,7 @@ static int write_data (flash_info_t * info, ulong dest, FPW 
data)
 
/* Check if Flash is (sufficiently) erased */
if ((*addr  data) != data) {
-   printf (not erased at %08lx (%x)\n, (ulong) addr, *addr);
+   printf (not erased at %08lx (%lx)\n, (ulong) addr, *addr);
return (2);
}
 
@@ -542,7 +542,7 @@ static int write_data (flash_info_t * info, ulong dest, FPW 
data)
 #ifdef DEBUG
*addr = (FPW) 0x00700070;
status = *addr;
-   printf(## status=0x%08x, addr=0x%08x\n, status, addr);
+   printf(## status=0x%08lx, addr=0x%p\n, status, addr);
 #endif
*addr = (FPW) 0x00500050; /* clear status register cmd 
*/
*addr = (FPW) 0x00FF00FF; /* restore read mode */
diff --git a/board/mp2usb/flash.c b/board/mp2usb/flash.c
index 89ced16..c19d445 100644
--- a/board/mp2usb/flash.c
+++ b/board/mp2usb/flash.c
@@ -426,7 +426,7 @@ static int write_data (flash_info_t *info, ulong dest, FPW 
data)
 
/* Check if Flash is (sufficiently) erased */
if ((*addr  data) != data) {
-   printf (not erased at %08lx (%lx)\n, (ulong) addr, *addr);
+   printf (not erased at %08lx (%lx)\n, (ulong) addr, (ulong) 
*addr);
return (2);
}
/*
diff --git a/board/versatile/flash.c b/board/versatile/flash.c
index ca77c8a..bbe5df7 100644
--- a/board/versatile/flash.c
+++ b/board/versatile/flash.c
@@ -476,7 +476,7 @@ static int write_data (flash_info_t * info, ulong dest, FPW 
data)
 
/* Check if Flash is (sufficiently) erased */
if ((*addr  data) != data) {
-   printf (not erased at %08lx (%x)\n, (ulong) addr, *addr);
+   printf (not erased at %08lx (%lx)\n, (ulong) addr, (ulong) 
*addr);
return (2);
}
 
diff --git a/board/zylonite/nand.c b/board/zylonite/nand.c
index aa3932a..ca16578 100644
--- a/board/zylonite/nand.c
+++ b/board/zylonite/nand.c
@@ -254,7 +254,7 @@ static unsigned long dfc_wait_event(unsigned long event)
break;
}
if(get_delta(start)  timeout) {
-   DFC_DEBUG1(dfc_wait_event: TIMEOUT waiting for event: 
0x%x.\n, event);
+   DFC_DEBUG1(dfc_wait_event: TIMEOUT waiting for event: 
0x%lx.\n, event);
return 0xff00

[U-Boot-Users] ARM tree

2008-07-12 Thread Jean-Christophe PLAGNIOL-VILLARD
Hi all,

For all arm user and developper,
I've reset the master branch of u-boot-arm with Wolfgang master.

All other branch is un-touched.

Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] Fix boot from NOR due to incorrect reset delay.

2008-07-10 Thread Jean-Christophe PLAGNIOL-VILLARD
On 23:49 Wed 09 Jul , Wolfgang Denk wrote:
 In message [EMAIL PROTECTED] you wrote:
  
  Le jeudi 22 mai 2008 à 00:15 +0200, Stelian Pop a écrit :
  AT91 RSTC registers are battery-backuped, so their values
  are not reset across power cycles. One of those registers,
  the AT91_RSTC_MR register, is being modified by U-Boot, in
  the ethernet initialisation routine, to generate a 500ms
  user reset.
  [...]
  
  It seems that the patch above has not made it in the mainline. Since
  this can cause some nasty boot problems, it would be nice to have this
  upstream for the next stable version.
 
 Jean-Christophe, is this on your queue?
 
I've send a pull requeset for this
and you applied in your tree.

Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH v2] Remove [EMAIL PROTECTED] from MAINTAINERS

2008-07-10 Thread Jean-Christophe PLAGNIOL-VILLARD
On 07:35 Thu 10 Jul , Jerry Van Baren wrote:
  +
  +Unknown / orphaned boards:
  +
  +   cradle  xscale
  +   ixdp425 xscale
  +   lubbock xscale
  +
   #
   # x86 Systems: 
  #
   #  #
 
 Would it be reasonable to add an optional tag last known maintainer 
 for orphaned boards so someone can chase it without pawing through git 
 history?  E.g.:
 
 +-
 +
 +Unknown / orphaned boards:
 +
 +Last known maintainer: Kyle Harris [EMAIL PROTECTED]
 + cradle  xscale  
 + ixdp425 xscale  
 + lubbock xscale  
 +
 
Good idea

Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] add 'license' command to u-boot?commandline

2008-07-10 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:08 Thu 10 Jul , Stefan Roese wrote:
 On Thursday 10 July 2008, Detlev Zundel wrote:
   IMHO, vim and xxd are essential programs so I'm OK with using
   xxd. OTOH, I understand some people actually prefer emacs and may have
   a problem with requiring vim to be installed.  ;-/
 
  Even though I'm an enthusiastic Emacs user, I have different reasons for
  my vote.  As far as build dependencies go, I'd like to restrict this to
  the LSB standard[1].  Xdd is not in there, so thats why I vote for the
  small C program (unless we can adapt the script and use 'od').
 
 I would prefer this C program solution too.

I would prefer this C program solution too.

Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] AT91 pull request

2008-07-10 Thread Jean-Christophe PLAGNIOL-VILLARD
Hi,
please pull
The following changes since commit 4109df6f75fc00ab7da56d286ba50149a0d16a69:
  Kim Phillips (1):
silence misc printf formatting compiler warnings

are available in the git repository at:

  git://git.denx.de/u-boot-at91.git master

Jean-Christophe PLAGNIOL-VILLARD (1):
  MAKEALL: remove duplicated at91 from ARM9 list and add LIST_at91 to arm

Sergey Lapin (1):
  DataFlash AT45DB021 support

 MAKEALL |   12 +---
 drivers/mtd/dataflash.c |   14 ++
 include/dataflash.h |1 +
 3 files changed, 16 insertions(+), 11 deletions(-)

Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 07/10] [ARM] TQMA31: adjust voltage regulators in PMIC MC13738

2008-07-09 Thread Jean-Christophe PLAGNIOL-VILLARD
On 18:11 Wed 09 Jul , Detlev Zundel wrote:
 Hi Magnus and Jens,
 
  Basically, I agree. But would you accept the current patch for now? The new
  routines and macros later could be implemented later.
 
  I don't think it's up to me to ACK or NAK this, but I can accept the
  current patch.
 
 Yes, this decision is up to the custodian.  But lets be honest here, we
 all know what we can implement this later means.  
 
 We really need to fix problems as they arise.  Especially in this case I
 don't think that it is such a significant effort to fix it now.  Fixing
 it later will only need even more effort.  
 
 Usually this effort(t-[detection time]) is an exponential function and I
 am not kidding on this.

I fully agree with you.

We need to fix this and not use a workaround which will became the
status quo.

Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor

2008-07-08 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:33 Tue 08 Jul , Jens Gehrlein wrote:
 Signed-off-by: Jens Gehrlein [EMAIL PROTECTED]
 ---
 
 Fixed two bugs:
 a) added NFS mount option rw to default environment
 b) added prefix $(obj) in front of .depend in Makefile. Thank you Magnus for 
 catching that.
 
 
  MAINTAINERS   |4 
  MAKEALL   |1 
  Makefile  |3 
  board/tqc/tqma31/Makefile |   48 
  board/tqc/tqma31/config.mk|2 
  board/tqc/tqma31/lowlevel_init.S  |  375 
 +
  board/tqc/tqma31/tqma31.c |   95 
  board/tqc/tqma31/u-boot.lds   |   72 ++
  include/asm-arm/arch-mx31/mx31-regs.h |   42 
  include/configs/TQMA31.h  |  271 
  10 files changed, 913 insertions(+), 0 deletions(-)
  create mode 100644 board/tqc/tqma31/Makefile
  create mode 100644 board/tqc/tqma31/config.mk
  create mode 100644 board/tqc/tqma31/lowlevel_init.S
  create mode 100644 board/tqc/tqma31/tqma31.c
  create mode 100644 board/tqc/tqma31/u-boot.lds
  create mode 100644 include/configs/TQMA31.h
 
 +
 +COBJS:= tqma31.o
why not use $(BOARD)?
COBJS   := $(BOARD).o
 +SOBJS:= lowlevel_init.o
 +
 +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
 +OBJS := $(addprefix $(obj),$(COBJS))
 +SOBJS:= $(addprefix $(obj),$(SOBJS))
 +
 +#elif defined CONFIG_MX31_CPU_532_MHZ
 + /* Platform clocks */
 + REG CCM_PDR0, PDR0_CSI_PODF(0x1ff)  /* camera sensor interface */   
 \
 + | PDR0_PER_PODF(8-1)/* periph. if derived from USB 
 clock */ \
 + | PDR0_HSP_PODF(4-1)/* IPU 133 MHz */   
 \
Please use tab instead of whitespace
 + | PDR0_NFC_PODF(7-1)/* NAND FC 19 MHz */
 \
Please use tab instead of whitespace
 + | PDR0_IPG_PODF(2-1)/* peripherals 66.5 MHz */  
 \
Please use tab instead of whitespace
 + | PDR0_MAX_PODF(4-1)/* AHB 133 MHz */   
 \
Please use tab instead of whitespace
 + | PDR0_MCU_PODF(1-1)/* core 532 MHz */
 + /* MCU PLL */
 + REG CCM_MPCTL, PLL_PD(1-1) | PLL_MFD(52-1) | PLL_MFI(10) | 
 PLL_MFN(12)
 +#else
 +#error Please define CPU core frequency (CONFIG_CPU_399_MHZ or 
 CONFIG_CPU_532_MHZ)!
 +#endif /* CONFIG_CPU_xxx_MHZ */
 +
 + /* Serial PLL. Default: 1, 4, 12, 1 */
 + REG CCM_SPCTL, PLL_PD(2-1) | PLL_MFD(5-1) | PLL_MFI(12) | PLL_MFN(1)
 +.endm /* init_sdram */
 +
 +
 +/* setup SDRAM on CSD0 */
 +.macro init_sdram
 + /*
 +  * Enhanced SDRAM Miscellaneous Register
 +  *  Latency Hiding Enable
 +  *  LPDDR delay line measure unit is enabled
 +  *  LPDDR Delay Line is not reset
 +  *  Enable Mobile DDR SDRAM operation
 +  *  Soft Reset is disabled
 +  */
 + REG ESDMISC, 0x0004
 +
 + /*
 +  * Enhanced SDRAM Configuration Register 0
 +  *  tXP 4 clock delay before new COMMAND issued to LPDDR
 +  *  tWTR tLPDDR WRITE to READ Command Delay = 2 clock
 +  *  tRP SDRAM Row Precharge Delay = 3 clock
 +  *  tMRD–SDRAM Load Mode Register to ACTIVE Command = 3 clock
you have a nice char here '96' in vim
 +  *  tWR SDRAM WRITE to PRECHARGE Command = 3 clock
 +  *  tRAS SDRAM ACTIVE to PRECHARGE Command = 6 clock
 +  *  tRRD ACTIVE Bank A to ACTIVE Bank B Command = 2 clock
 +  *  tCAS CAS Latency = 3 clock
 +  *  tRCD SDRAM Row to Column Delay = 3 clock
 +  *  tRC SDRAM Row Cycle Delay = 13 clocks
 +  */
 + REG ESDCFG0, 0x006ac73c
 +
 + /*
 +  * Enhanced SDRAM Control Register 0
 +  *  Enhanced SDRAM Controller Enable = 1
 +  *  SDRAM Controller Operating Mode = 001 Precharge Command
 +  *  Supervisor Protect = 0 User mode accesses are allowed to this
 +  *  chip select region
 +  *  ROW Row Address Width. = 011 14 Row Addresses
 +  *  COL Column Address Width = 01 9 Col Addresses
 +  *  DSIZ SDRAM Memory Data Width = 00 00 16-bit memory width
 +  *  aligned to D[31:16]
 +  *  SREFR SDRAM Refresh Rate  = 000 Refresh Disabled
 +  *  (bit field reset value)
 +  *  PWDT Power Down = 00 Disabled (bit field reset value) Run Mode
 +  *  FP Full Page = 0 0 Burst Length of the external memory device
 +  *  is not set to Full Page
 +  *  BL Burst Length = 0
 +  *  PRCT Precharge Timer 00 Disabled (Bit field reset value)
 +  */
 + REG ESDCTL0, 0x9220
 + REG 0x8f00, 0x12344321
 +
 +
 + /*
Please use tab instead of whitespace
 +  * Enhanced SDRAM Control Register 0
Please use tab instead of whitespace
 +  *  Enhanced SDRAM Controller 

Re: [U-Boot-Users] [PATCH 05/10] [ARM] TQMA31: add support for I2C, I2C temperature sensor and I2C-EEPROM

2008-07-08 Thread Jean-Christophe PLAGNIOL-VILLARD
  #if defined(CONFIG_DISPLAY_CPUINFO)
  int print_cpuinfo (void)
  {
 diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c
 index 6f9306f..68d2720 100644
 --- a/drivers/i2c/mxc_i2c.c
 +++ b/drivers/i2c/mxc_i2c.c
 @@ -209,4 +209,17 @@ int i2c_write(uchar chip, uint addr, int alen, uchar 
 *buf, int len)
   return 0;
  }
  
 +int i2c_get_bus_speed(void)
 +{
 + return -1;
 +}
 +
 +int i2c_set_bus_speed (unsigned int speed)
 +{
 + if (speed != CFG_I2C_SPEED)
 + return -1;
 +
 + return 0;
 +}
why do you refuse to change the i2c bus speed?
 +
  #endif /* CONFIG_HARD_I2C */
 diff --git a/include/asm-arm/arch-mx31/mx31-regs.h 
 b/include/asm-arm/arch-mx31/mx31-regs.h
 index ea15108..c0e516f 100644
 --- a/include/asm-arm/arch-mx31/mx31-regs.h
 +++ b/include/asm-arm/arch-mx31/mx31-regs.h
 @@ -168,6 +168,9 @@
  
  extern u32 mx31_get_ipg_clk(void);
  extern void mx31_gpio_mux(unsigned long mode);
 +extern void mx31_pad_ctl (u32 field, u32 val);
  
  #endif /* __ASM_ARCH_MX31_H */
 diff --git a/include/configs/TQMA31.h b/include/configs/TQMA31.h
 index 255355d..f96fd74 100644
 --- a/include/configs/TQMA31.h
 +++ b/include/configs/TQMA31.h
 @@ -154,6 +154,43 @@
  
  
  
 /***
 + * I2C
 + 
 **/
 +
 +/* Use the processor internal controller */
 +#define CONFIG_HARD_I2C
 +#define CONFIG_I2C_MXC
 +
 +/* Configure I2C1 */
 +#define CFG_I2C_MX31_PORT1
 +
 +#define CFG_I2C_SPEED10
please use tab instead of whitespace
 +#define CFG_I2C_SLAVE0
please use tab instead of whitespace
 +
 +/* Don't probe these addrs */
 +#define CFG_I2C_NOPROBES {0x00}
 +
Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 09/10] [ARM] TQMA31: add FPGA configuration flash

2008-07-08 Thread Jean-Christophe PLAGNIOL-VILLARD
  /*
   * Bank start addresses.
   * 4 x 32 MiB is the maximum for user and U-Boot code. Please adapt the list
   * as well as CFG_MAX_FLASH_BANKS to your TQM. Also consider dual die chips
   * or single die chips, e.g. one dual die chip represents two banks.
 + * The fifth bank is a separate chip for the FPGA configuration. It's
 + * controlled by chipselect 1.
   */
same commnets as patch 04
  #define CFG_FLASH_BANKS_LIST {CFG_FLASH_BASE,\
   CFG_FLASH_BASE + 32*1024*1024,  \
   CFG_FLASH_BASE + 64*1024*1024,  \
 - CFG_FLASH_BASE + 96*1024*1024}
 + CFG_FLASH_BASE + 96*1024*1024,  \
 + CS1_BASE}
  
  /* Max number of sectors on one chip */
  #define CFG_MAX_FLASH_SECT   259
 
Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor

2008-07-08 Thread Jean-Christophe PLAGNIOL-VILLARD

 Thank you very much for catching all these silly mistakes.

 A last question:
 When I want to reply all, your e-mail address doesn't appear in the  
 to-field. I have to add the address manually. Is this intended?

wierd, in the mail i'm not in the CC but in the FROM

Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH v2] net: Conditional COBJS inclusion of network drivers

2008-07-06 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:42 Sun 06 Jul , Shinya Kuribayashi wrote:
 Wolfgang Denk wrote:
  Hm... Are you absolutely sure your changes, especially the
  CONFIG_CMD_NET and even more the CONFIG_NET_MULTI related ones, do not
  cause any trouble on any systems?
 
 [...]
 
  It seems not obvious to me that your change is  really  harmless,  or
  tested.
  
  Could you please comment?
 
 Carefully reviewed as much as I could, but yes it's not fully tested.
 I only did some build tests before patch submission.
 
 I expect all board config files, which have one of the existing ethernet
 driver config, already have CONFIG_CMD_NET and CONFIG_NET_MULTI, too.
 But even if that is the case, there still might be some build breakage.
 
I've found an error on ARM, I'll send a patch about it soon.

Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] add explicit bbt creation to commandline

2008-07-06 Thread Jean-Christophe PLAGNIOL-VILLARD
On 16:04 Sun 06 Jul , Harald Welte wrote:
 [PATCH] add explicit bbt creation to commandline (nand createbbt command)
 
 This patch adds user-requested BBT creation. It includes the following 
 changes:
 
 - common/cmd_nand.c: move yes/no decision to separate function
 - do_nand: ask for confirmation for nand erase
 - do_nand: add command nand createbbt to erase NAND and create a new BBT
 
 Signed-off-by: Werner Almesberger [EMAIL PROTECTED]
 Signed-off-by: Harald Welte [EMAIL PROTECTED]
 
 ---
 
 diff --git a/common/cmd_nand.c b/common/cmd_nand.c
 index bb46f34..2f41157 100644
 --- a/common/cmd_nand.c
 +++ b/common/cmd_nand.c
 @@ -162,6 +162,17 @@ out:
   return 0;
  }
  
 +static int yes(void)
 +{
 + char c;
 +
 + c = getc();
 + if (c != 'y'  c != 'Y')
 + return 0;
 + c = getc();
 + return c == '\r' || c == '\n';
 +}
 +
It will be good to have it in a re-usable header as inline.

And why not name it as ask_confirm()?

Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] Release status - things to be done

2008-07-06 Thread Jean-Christophe PLAGNIOL-VILLARD
On 01:05 Sun 06 Jul , Wolfgang Denk wrote:
 Hi everybody,
 
 here is a summary of the current state of my processing of patches
 that have been submitted for the upcoming 1.3.4 release.
 
 As you might have noticed, I've been on vacation for the last two
 weeks, and I spent this time (intentionally) completely offline. So
 please apologize if parts of the following comments / questions have
 been obsoleted by recent events - I will try to catch up as soon as
 possible, but I think it is better to send out this summary now,
 i. e. _before_ I start reading he backlog of the last two weeks.
 
 
 Here is a list of patches I had marked as open in my list, with
 comments about their state, including comments who I consider to be
 responsible for further progress:

Thanks about it.
  2536  05/20 Sergey Lapin   [U-Boot-Users] [PATCH] DataFlash AT45DB021 
 support
  2618  05/21 Sergey Lapin Re: [U-Boot-Users] [PATCH] DataFlash 
 AT45DB021 support
  2836  05/26 Sergey Lapin   [U-Boot-Users] [AT91] Re: [PATCH] DataFlash 
 AT45DB021 support
  2840  05/26 Matt Gessner Re: [U-Boot-Users] [AT91] Re: [PATCH] 
 DataFlash AT45DB021 support
  2945  05/29 Sergey Lapin   Re: [U-Boot-Users] [AT91] Re: [PATCH] 
 DataFlash AT45DB021 support
  3371  06/05 Sergey Lapin   [U-Boot-Users] [PATCH][AT91][Re-submit] 
 DataFlash AT45DB021 support
  3923  06/17 Sergey Lapin   Re: [U-Boot-Users] [PATCH][AT91][Re-submit] 
 DataFlash AT45DB021 support
   - for AT91 custodian
  2629  05/21 Christian Eggers  [U-Boot-Users] [Patch] Configure SMC for a 
 second flash device if required
   - for AT91 custodian
 
  2649  05/22 Stelian Pop[U-Boot-Users] [PATCH] Fix boot from NOR due 
 to incorrect reset delay.
   - for AT91 custodian
Already send a pull-request about it
 
  2660  05/22 Haavard Skinnemoe  [PATCH v2] MMC: Consolidate MMC/SD command 
 definitions
   - applied
 
  2663  05/22 Haavard Skinnemoe  [U-Boot-Users] [PATCH] avr32: Fix wrong error 
 flags in atmel_mci driver
   - already applied
 
  2664  05/22 Sergey Lapin   [U-Boot-Users] [PATCH][Re-Submit] DataFlash 
 AT45DB021 support
   - for AT91 custodian
I've plan to add it for the 1.3.5 but I will do it for the 1.3.4
 
  2688  05/22 Jean-Christophe P  Re: [U-Boot-Users] [PATCH 18/26] Make 
 nand_init() return the detected NAND size
  2694  05/22 Scott Wood Re: [U-Boot-Users] [PATCH 18/26] Make 
 nand_init() return the detected NAND size
   - for AT91 custodian
drop by the author
 
 
  2786  05/24 Jean-Christophe P  [U-Boot-Users] [PATCH] MAKEALL: add at91 list
   - asked submitter for fixes / cleanup
I will send a fix patch
 
  2802  05/24 Haavard Skinnemoe  Re: [U-Boot-Users] [PATCH 06/18] avr32: Add 
 support for the ATSTK1006 board
  2803  05/24 Haavard Skinnemoe  Re: [U-Boot-Users] [PATCH 05/18] avr32: Get 
 rid of the .flashprog section
  2831  05/26 Haavard Skinnemoe  [U-Boot-Users] [PATCH] avr32: Fix theoretical 
 race in udelay()
  2833  05/26 Haavard Skinnemoe  [PATCH v4 1/3] Move definition of 
 container_of() to common.h
  2834  05/26 Haavard Skinnemoe  [PATCH v4 2/3] SPI API improvements
  2835  05/26 Haavard Skinnemoe  [PATCH v4 3/3] atmel_spi: Driver for the 
 Atmel SPI controller
   - already applied
 
  2853  05/27 Jean-Christophe P  [U-Boot-Users] [PATCH] [AT91SAM9] Fix NAND 
 FLASH timings
   - for AT91 custodian
Already send a pull-request
 
  2858  05/27 wangjiankun820624  [U-Boot-Users] MIPS: about the function of 
 the octeon_twsi_set_addr8
   - for MIPS custodian
 
  3652  06/11 Antonio R. Costa  [U-Boot-Users] [PATCH 5/6] AT572D940HF-EB 
 Support
  3653  06/11 Antonio R. Costa  [U-Boot-Users] [PATCH 6/6] AT572D940HF-EB 
 Support
  3654  06/11 Antonio R. Costa  [U-Boot-Users] [PATCH 1/3] SDHC Support for 
 AT572d940HF-EB
  3733  06/12 Ulf Samuelsson   Re: [U-Boot-Users] [PATCH 1/3] SDHC Support 
 for AT572d940HF-EB
  3735  06/12 COSTA, Antonio   Re: [U-Boot-Users] [PATCH 1/3] SDHC Support 
 for AT572d940HF-EB
  3737  06/12 Ulf Samuelsson   Re: [U-Boot-Users] [PATCH 1/3] SDHC Support 
 for AT572d940HF-EB
  3739  06/12 Jerry Van BarenRe: [U-Boot-Users] [PATCH 1/3] SDHC Support 
 for AT572d940HF-EB
  3859  06/15 Haavard Skinnemoe  Re: [U-Boot-Users] [PATCH 1/3] SDHC Support 
 for AT572d940HF-EB
  3897  06/16 [EMAIL PROTECTED]  Re: [U-Boot-Users] [PATCH 1/3] SDHC Support 
 for AT572d940HF-EB
  3899  06/17 Haavard Skinnemoe  Re: [U-Boot-Users] [PATCH 1/3] SDHC Support 
 for AT572d940HF-EB
  3740  06/12 Antonio R. Costa  [U-Boot-Users] [PATCH 1/6] AT572D940HF-EB 
 Support v2 (board folder)
  3741  06/12 Antonio R. Costa  [U-Boot-Users] [PATCH 2/2] AT572D940HF-EB 
 Support v2 (SDHC support part 2)
  3742  06/12 Antonio R. Costa  [U-Boot-Users] [PATCH 1/2] AT572D940HF-EB 
 Support v2 (SDHC support part 1)
  3743  06/12 Antonio R. Costa  [U-Boot-Users] [PATCH 3/6] AT572D940HF-EB 
 Support v2 (include files part 1)
  3744  06/12 Antonio R. Costa  [U-Boot-Users] 

Re: [U-Boot-Users] [PATCH 1/3] SDHC Support for AT572d940HF-EB

2008-07-05 Thread Jean-Christophe PLAGNIOL-VILLARD
On 00:02 Tue 17 Jun , Haavard Skinnemoen wrote:
 On Mon, 16 Jun 2008 16:13:32 -0500
 [EMAIL PROTECTED] wrote:
 
  However, I was mistaken about my code being committed into the
  official u-boot tree.  Please see my response above.
 
 Ok, I figured it must be something like that.
 
 That said, I take it this means that we have not two but _three_
 drivers for the same hardware floating around in various trees, all of
 which are forked off the original avr32 driver. I think this is another
 reason to get those drivers merged together ASAP.
 
 I also hope that we can get your MMC+ support into the common driver
 eventually, with proper attributions and copyrights of course ;-) but I
 think the merge needs to happen first.
 
 I suggest we start with the three patches I posted moving the avr32
 driver into drivers/mmc, then make the minimal set of changes necessary
 to support AT91 and Diopsis, and then start adding additional features
 from the other drivers, like MMC+ and SDHC support.
 
 The first two steps should certainly be doable in time for the next
 merge window. I suspect MMC+ and SDHC support needs more testing and
 review, but it may be doable as well.
 
 Does this sound like a good plan to everyone?

Good for me

Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH RFC] ARM: Davinci: NAND fix for large page ECC and linux compatibility

2008-06-27 Thread Jean-Christophe PLAGNIOL-VILLARD
  #endif
 +#endif
  
  static void nand_davinci_enable_hwecc(struct mtd_info *mtd, int mode)
  {
 @@ -141,12 +146,29 @@ static u_int32_t nand_davinci_readecc(st
  
  static int nand_davinci_calculate_ecc(struct mtd_info *mtd, const u_char 
 *dat, u_char *ecc_code)
  {
 +#ifdef CFG_LINUX_COMPATIBLE_ECC
 + unsigned int ecc_val = nand_davinci_readecc(mtd, 1);
 + /* squeeze 0 middle bits out so that it fits in 3 bytes */
 + unsigned int tmp = (ecc_val0x0fff)|((ecc_val0x0fff)4);
unsigned int tmp = (ecc_val  0x0fff) | ((ecc_val  0x0fff)  4);
please and space between operator

plese use the same alignement
add an empty line
 + /* invert so that erased block ecc is correct */
 + tmp = ~tmp;
 + ecc_code[0] = (u_char)(tmp);
 + ecc_code[1] = (u_char)(tmp  8);
 + ecc_code[2] = (u_char)(tmp  16);
 +#else
   u_int32_t   tmp;
   int region, n;
   struct nand_chip*this = mtd-priv;
  
   n = (this-eccmode == NAND_ECC_HW12_2048) ? 4 : 1;
  
 + u_char *read_ecc, u_char *calc_ecc)
 +{
 + struct nand_chip *chip = mtd-priv;
 + u_int32_t ecc_nand = read_ecc[0] | (read_ecc[1]  8) |
 +   (read_ecc[2]  16);
 + u_int32_t ecc_calc = calc_ecc[0] | (calc_ecc[1]  8) |
 +   (calc_ecc[2]  16);
 + u_int32_t diff = ecc_calc ^ ecc_nand;
 +
 + if (diff) {
 + if diff12)^diff)  0xfff) == 0xfff) {
please and space between operator
 + /* Correctable error */
please and space between operator
 + if ((diff(12+3))  chip-eccsize) {
 + uint8_t find_bit = 1  ((diff12)7);
please and space between operator
 + uint32_t find_byte = diff(12+3);
uint32_t find_byte = diff  15;
please and space between operator
 + dat[find_byte] ^= find_bit;
 + DEBUG (MTD_DEBUG_LEVEL0, Correcting single bit 
 ECC error at offset: %d, bit: %d\n, find_byte, find_bit);
too long please split
 + return 1;
 + } else {
 + return -1;
 + }
 + } else if (!(diff  (diff-1))) {
please and space between operator
 + /* Single bit ECC error in the ECC itself,
 +nothing to fix */
please use this style of comment
/*
 *
 */
 + DEBUG (MTD_DEBUG_LEVEL0, Single bit ECC error in 
 ECC.\n);
 + return 1;
 + } else {
 + /* Uncorrectable error */
 + DEBUG (MTD_DEBUG_LEVEL0, ECC UNCORRECTED_ERROR 1\n);
 + return -1;
   /* Set address of hardware control function */
   nand-hwcontrol = nand_davinci_hwcontrol;
 Index: u-boot-1.3.3/include/configs/davinci_dvevm.h
 ===
 --- u-boot-1.3.3.orig/include/configs/davinci_dvevm.h 2008-05-19 
 18:47:11.0 +0800
 +++ u-boot-1.3.3/include/configs/davinci_dvevm.h  2008-06-27 
 13:04:07.0 +0800
 @@ -46,6 +46,18 @@
  #define CONFIG_NOR_UART_BOOT
   */
  
 +/*
 + * Previous versions of u-boot (1.3.3 and prior) and Montavista Linux kernels
 + * generated bogus ECCs on large-page NAND. Both large and small page NAND 
 ECCs
 + * were incompatible with the Linux davinci git tree (since NAND was 
 integrated
 + * in 2.6.24).
 + * Don't turn this on if you want backwards compatibility.
 + * Do turn this on if you want u-boot to be able to read and write NAND
 + * that can be written or read by the Linux davinci git kernel.
 + *
 +#define CFG_LINUX_COMPATIBLE_ECC
 + */
please move this in README.davinci
 +

Best Regards,
J.

-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH][AT91][Re-submit] DataFlash AT45DB021 support

2008-06-26 Thread Jean-Christophe PLAGNIOL-VILLARD
On 17:21 Tue 17 Jun , Sergey Lapin wrote:
 Hi, all!
 
   On 11:06 Thu 05 Jun , Sergey Lapin wrote:
Some boards based on AT91SAM926X-EK use smaller DF chips to keep
bootstrap, u-boot and its environment, using NAND or other external
storage for kernel and rootfs. This patch adds support for
small 1024x263 chip.

Signed-off-by: Sergey Lapin [EMAIL PROTECTED]
   Scott will you handle this patch or I will do?
   
   Best Regards,
   J.
  
  It's not NAND; go ahead and take it.
  
  -Scott
 Any updates about this?
 
 Thanks a lot,
 S.
 
 
I'll take care of this patch during the next week, sorry for the delay.

Best Regards,
J.

-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] at91sam9260-ek intermittenly fails at u-boot init

2008-06-26 Thread Jean-Christophe PLAGNIOL-VILLARD
 (BTW, if Wolfgang is listening, it would be nice to have proper tags in
 git as well as releases on the ftp server for the -pre version. Since
 the merge window is closed, I guess we're up to v1.3.4-pre1 now, but
 this version tag cannot be found anywhere...)
good idea

Best  Regards,
J.

-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH V8] ARM: Add support for Lyrtech SFF-SDRboard (ARM926EJS)

2008-06-26 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:53 Wed 25 Jun , Hugo Villeneuve wrote:
 Hugo Villeneuve wrote:
  [EMAIL PROTECTED] wrote:
  ARM: This patch adds support for the Lyrtech SFF-SDR
  board, based on the TI DaVinci architecture (ARM926EJS).
  
  I haven´t heard from anyone about my patch being accepted or not.
  It´s been almost five weeks since I submitted the first version, and
  I still cannot see it in the ARM tree or U-Boot master tree.  
  
  Should I look into a specific tree to see if my patch has been
  accepted?
 
 Still no answer, who is responsible for incorporating my patch in U-Boot?
 
 Is anything missing or incorrect with the patch?
The patch is OK for me.
I'll apply it soon

Best Regards,
J.

-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


  1   2   3   4   >