Re: [uml-devel] [PATCH v3] um: Print minimum physical memory requirement

2015-04-13 Thread Richard Weinberger
On Fri, Apr 3, 2015 at 4:51 PM, Thomas Meyer tho...@m3y3r.de wrote: Print a more sensible message about the minimum physical memory requirement. Signed-off-by: Thomas Meyer tho...@m3y3r.de All of your three patches are queued for 4.1! :-) -- Thanks, //richard

Re: [uml-devel] [UM] Long loop in __getnsdayoftime() after resume from ram

2015-04-26 Thread Richard Weinberger
Am 26.04.2015 um 20:32 schrieb Richard Weinberger: On Fri, Apr 24, 2015 at 9:58 PM, Thomas Meyer tho...@m3y3r.de wrote: Any ideas? Can you give the attached patch a try? Let's see if it proves my theory. Looks like UML's clocksource needs fixing. Please give also this patch a try. I should

Re: [uml-devel] [UM] Long loop in __getnsdayoftime() after resume from ram

2015-04-26 Thread Richard Weinberger
Hi! Am 26.04.2015 um 22:57 schrieb Thomas Meyer: Am Sonntag, den 26.04.2015, 20:32 +0200 schrieb Richard Weinberger: On Fri, Apr 24, 2015 at 9:58 PM, Thomas Meyer tho...@m3y3r.de wrote: Am Montag, den 20.10.2014, 11:56 +0200 schrieb Richard Weinberger: Am 20.10.2014 um 11:51 schrieb Thomas

Re: [uml-devel] [UM] Long loop in __getnsdayoftime() after resume from ram

2015-04-26 Thread Richard Weinberger
On Fri, Apr 24, 2015 at 9:58 PM, Thomas Meyer tho...@m3y3r.de wrote: Am Montag, den 20.10.2014, 11:56 +0200 schrieb Richard Weinberger: Am 20.10.2014 um 11:51 schrieb Thomas Meyer: Hmm, does this always happen? Yes, my single core system seems to trigger this every time after resume

[uml-devel] [PATCH] um: Remove hppfs

2015-04-22 Thread Richard Weinberger
hppfs (honeypot procfs) was an attempt to use UML as honeypot. It was never stable nor in heavy use. As Al Viro and Christoph Hellwig pointed some major issues out it is better to let it die. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/Kconfig.um | 15 -- fs/Makefile

[uml-devel] Kill hppfs

2015-04-22 Thread Richard Weinberger
hch and Al found that hppfs has some serious issues[0]. As the filesystem as never marked as stable nor in heavy use we decided to rip it out. If someone is using it, speak up now. I plan to remove it in the v4.2 merge window. Now we have FUSE which can be used to implement such a filesystem in a

Re: [uml-devel] [UM] Long loop in __getnsdayoftime() after resume from ram

2015-04-27 Thread Richard Weinberger
On Mon, Apr 27, 2015 at 7:47 AM, Anton Ivanov anton.iva...@kot-begemot.co.uk wrote: On 26/04/15 22:00, Richard Weinberger wrote: Can you give the attached patch a try? Let's see if it proves my theory. Looks like UML's clocksource needs fixing. Hi Richard, I did run this for an hour

[uml-devel] [PATCH] hostfs: Use correct mask for file mode

2015-05-04 Thread Richard Weinberger
S_IFMT is obviously wrong and needs to be 0777. We're interested in the file mode, not the type. Fixes: b98b91029c (hostfs: No need to box and later unbox the file mode) Reported-by: Markus Stenberg markus.stenb...@iki.fi Signed-off-by: Richard Weinberger rich...@nod.at --- fs/hostfs

Re: [uml-devel] [PATCH] hostfs: Use correct mask for file mode

2015-05-04 Thread Richard Weinberger
Am 04.05.2015 um 15:22 schrieb Geert Uytterhoeven: On Mon, May 4, 2015 at 2:53 PM, Richard Weinberger rich...@nod.at wrote: --- a/fs/hostfs/hostfs_kern.c +++ b/fs/hostfs/hostfs_kern.c @@ -581,7 +581,7 @@ static int hostfs_create(struct inode *dir, struct dentry *dentry, umode_t mode

Re: [uml-devel] [PATCH v6] um: Add a high resolution timer subsystem

2015-05-10 Thread Richard Weinberger
Am 10.05.2015 um 16:34 schrieb Thomas Meyer: Am 10.05.2015 um 14:35 schrieb Richard Weinberger richard.weinber...@gmail.com: On Sun, May 10, 2015 at 1:14 AM, Thomas Meyer tho...@m3y3r.de wrote: Hi, Changes: - also create posix timer in stub_clone_handler() - incorporated antons remarks

Re: [uml-devel] [PATCH v6] um: Add a high resolution timer subsystem

2015-05-10 Thread Richard Weinberger
On Sun, May 10, 2015 at 1:14 AM, Thomas Meyer tho...@m3y3r.de wrote: Hi, Changes: - also create posix timer in stub_clone_handler() - incorporated antons remarks Hm, this patch does a *lot* more than the changelog says. diff --git a/arch/um/Makefile b/arch/um/Makefile index

Re: [uml-devel] [PATCH v6] um: Add a high resolution timer subsystem

2015-05-11 Thread Richard Weinberger
Am 10.05.2015 um 16:34 schrieb Thomas Meyer: Am 10.05.2015 um 14:35 schrieb Richard Weinberger richard.weinber...@gmail.com: On Sun, May 10, 2015 at 1:14 AM, Thomas Meyer tho...@m3y3r.de wrote: Hi, Changes: - also create posix timer in stub_clone_handler() - incorporated antons remarks

[uml-devel] [PATCH 5/5] um: Rework uaccess code

2015-05-11 Thread Richard Weinberger
Rework UML's uaccess code to reuse as much as possible from asm-generic/uaccess.c. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/include/asm/thread_info.h | 2 +- arch/um/include/asm/uaccess.h | 176 ++ arch/um/kernel/skas/uaccess.c

[uml-devel] [PATCH 2/5] um: Add asm/elf.h to vma.c

2015-05-11 Thread Richard Weinberger
um_vdso_addr is defined in asm/elf.h. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/x86/um/vdso/vma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/um/vdso/vma.c b/arch/x86/um/vdso/vma.c index 916cda4..237c683 100644 --- a/arch/x86/um/vdso/vma.c +++ b/arch/x86/um/vdso

[uml-devel] [PATCH 4/5] um: Add uaccess.h to ldt.c

2015-05-11 Thread Richard Weinberger
...for userspace memory access. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/x86/um/ldt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/um/ldt.c b/arch/x86/um/ldt.c index 5c0b711..9701a4f 100644 --- a/arch/x86/um/ldt.c +++ b/arch/x86/um/ldt.c @@ -6,6 +6,7 @@ #include

[uml-devel] [PATCH 3/5] um: Add uaccess.h to syscalls_64.c

2015-05-11 Thread Richard Weinberger
It's using put_user() and needs this header. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/x86/um/syscalls_64.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/um/syscalls_64.c b/arch/x86/um/syscalls_64.c index adb08eb..e655227 100644 --- a/arch/x86/um/syscalls_64.c

[uml-devel] Rework UML's uaccess code

2015-05-11 Thread Richard Weinberger
By reusing asm-generic/uaccess.h we can drop a lot of UML's ad-hoc uaccess code and make it much more straightforward. It uncovered also some header issues which got resolved. [PATCH 1/5] um: Cleanup mem_32/64.c headers [PATCH 2/5] um: Add asm/elf.h to vma.c [PATCH 3/5] um: Add uaccess.h to

[uml-devel] [PATCH 1/5] um: Cleanup mem_32/64.c headers

2015-05-11 Thread Richard Weinberger
Include only headers we really need. Signed-off-by: Richard Weinberger rich...@nod.at --- arch/x86/um/mem_32.c | 3 +-- arch/x86/um/mem_64.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/x86/um/mem_32.c b/arch/x86/um/mem_32.c index f40281e..744afdc 100644

[uml-devel] [GIT PULL] UML fixes for 4.1-rc4

2015-05-15 Thread Richard Weinberger
. Richard Weinberger (1): hostfs: Use correct mask for file mode fs/hostfs/hostfs_kern.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- One dashboard for servers and applications across Physical

[uml-devel] [GIT PULL] UML updates for 4.1

2015-04-15 Thread Richard Weinberger
Andrey Ryabinin (1): x86, UML: fix integer overflow in ELF_ET_DYN_BASE Richard Weinberger (22): hostfs: hostfs_file_open: Switch to data locking model hostfs: hostfs_file_open: Fix a fd leak in hostfs_file_open hostfs: Allow

Re: [uml-devel] [PATCH] um: Switch clocksource to hrtimers

2015-05-19 Thread Richard Weinberger
On Tue, May 19, 2015 at 6:19 PM, Anton Ivanov anton.iva...@kot-begemot.co.uk wrote: Same story. Overall works quite well, the moment I give it the dselect upgrade test the userspace hangs. Kernel continues to work - forwarding, icmp, uml_mconsole are fine. Do you know where it hangs? Maybe

Re: [uml-devel] [PATCH] um: Switch clocksource to hrtimers

2015-08-18 Thread Richard Weinberger
On Sat, Aug 15, 2015 at 6:27 PM, Anton Ivanov anton.iva...@kot-begemot.co.uk wrote: On 15/08/15 09:15, Richard Weinberger wrote: Am 09.08.2015 um 19:53 schrieb Thomas Meyer: Switch the UML clocksource from interval timers to posix interval timers and move to a monotonic timer. This fixes

Re: [uml-devel] [PATCH v2] um: Do not rely on libc to provide modify_ldt()

2015-07-28 Thread Richard Weinberger
On Mon, Jul 27, 2015 at 1:30 PM, Hans-Werner Hilse hwhi...@gmail.com wrote: Hi, Richard, might I ping you about this one? Reading other mails on this ML, I reckon' you're quite busy - no problem, it's not really critical anyway. Just want to make sure the updated patch got noticed. Thanks

Re: [uml-devel] [PATCH v2] um: Switch clocksource to hrtimers

2015-08-09 Thread Richard Weinberger
On Tue, Jul 14, 2015 at 1:45 PM, Thomas Meyer tho...@m3y3r.de wrote: Switch the UML clocksource from interval timers to posix interval timers and move to a monotonic timer. This fixes suspendresume related timer issues and improves network performance as TCP state machines are now fed with

[uml-devel] unmet direct dependencies in -next

2015-08-09 Thread Richard Weinberger
Hi! -next faces some build issues on UML because of unmet direct dependencies. Mostly due to HAS_IOMEM and I2C. warning: (MEDIA_SUBDRV_AUTOSELECT VIDEO_CX231XX INV_MPU6050_IIO) selects I2C_MUX which has unmet direct dependencies (I2C HAS_IOMEM) warning: (ST_IRQCHIP HIP04_ETH

[uml-devel] [PATCH] um: Fix kernel mode fault condition

2015-08-09 Thread Richard Weinberger
We have to exclude memory locations = PAGE_SIZE from the condition and let the kernel mode fault path catch it. Otherwise a kernel NULL pointer exception will be reported as a kernel user space access. Fixes: d2313084e2c (um: Catch unprotected user memory access) Signed-off-by: Richard Weinberger

[uml-devel] [PATCH] um: Fix waitpid() usage in helper code

2015-08-09 Thread Richard Weinberger
have to use __WALL to wait for both clone()'ed and regular childs to detect the termination before and after an execve(). Reported-and-tested-by: Thomas Meyer tho...@m3y3r.de Signed-off-by: Richard Weinberger rich...@nod.at --- arch/um/os-Linux/helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [uml-devel] uml_net zombie processes

2015-08-09 Thread Richard Weinberger
On Wed, Jul 15, 2015 at 3:58 PM, Thomas Meyer tho...@m3y3r.de wrote: Am Mittwoch, den 15.07.2015, 12:12 +0200 schrieb Richard Weinberger: On Mon, Jul 13, 2015 at 5:12 PM, Thomas Meyer tho...@m3y3r.de wrote: Am Montag, den 13.07.2015, 17:11 +0200 schrieb Richard Weinberger: Am 13.07.2015 um

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

2015-07-13 Thread Richard Weinberger
Hi! Can you please render this into a proper patch and re-send to the mailinglist? Thanks, //richard Am 13.07.2015 um 11:08 schrieb David Binderman: Hello there, [linux-4.2-rc2/arch/um/drivers/net_user.c:258]: (error) va_list 'ap' was opened but not closed by va_end(). Source code is

Re: [uml-devel] uml_net zombie processes

2015-07-13 Thread Richard Weinberger
Am 13.07.2015 um 15:58 schrieb Thomas Meyer: Am Montag, den 13.07.2015, 15:52 +0200 schrieb Richard Weinberger: On Mon, Jul 13, 2015 at 3:41 PM, Thomas Meyer tho...@m3y3r.de wrote: Hi, The uml_net network setup fails on my computer with: [ 15.93] helper_wait : waitpid process 11673

Re: [uml-devel] uml_net zombie processes

2015-07-13 Thread Richard Weinberger
On Mon, Jul 13, 2015 at 3:41 PM, Thomas Meyer tho...@m3y3r.de wrote: Hi, The uml_net network setup fails on my computer with: [ 15.93] helper_wait : waitpid process 11673 failed, errno = 10 [ 15.93] * modprobe tun * ifconfig tap0 192.168.10.1 netmask

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

2015-07-13 Thread Richard Weinberger
Am 13.07.2015 um 14:58 schrieb Geert Uytterhoeven: Hi David, On Mon, Jul 13, 2015 at 2:52 PM, David Binderman dcb...@hotmail.com wrote: Can you please render this into a proper patch and re-send to the mailinglist? I have a 100% failure rate with

Re: [uml-devel] uml_net zombie processes

2015-07-13 Thread Richard Weinberger
Am 13.07.2015 um 16:24 schrieb Thomas Meyer: Yeah. And please add a dump_stack() to figure out where it was called. I think calling dump_stack() somehow changed the errno to 25?! +extern __attribute__((regparm(0))) void dump_stack(void); Hmm, maybe the regparm(0) kills your stack.

Re: [uml-devel] uml_net zombie processes

2015-07-13 Thread Richard Weinberger
Am 13.07.2015 um 17:08 schrieb Thomas Meyer: Am Montag, den 13.07.2015, 16:41 +0200 schrieb Richard Weinberger: Am 13.07.2015 um 16:24 schrieb Thomas Meyer: Yeah. And please add a dump_stack() to figure out where it was called. I think calling dump_stack() somehow changed the errno to 25

[uml-devel] [PATCH 1/7] um: Define PTRACE_OLDSETOPTIONS

2015-10-26 Thread Richard Weinberger
...such that processes within UML can do a ptrace(PTRACE_OLDSETOPTIONS, ...) Signed-off-by: Richard Weinberger <rich...@nod.at> --- arch/um/include/asm/ptrace-generic.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/um/include/asm/ptrace-generic.h b/arch/um/include/asm/

[uml-devel] [PATCH 6/7] um: Simplify STUB_DATA loading

2015-10-26 Thread Richard Weinberger
As long STUB_DATA fits into 32bits we can use a plain mov. If it will grow at some point in future we will switch to movabsq. In any case the code is smaller and more easy to read than the current one Signed-off-by: Richard Weinberger <rich...@nod.at> --- arch/x86/um/stub_64.S | 5 +

[uml-devel] [PATCH 3/7] um: Get rid of open coded NR_SYSCALLS

2015-10-26 Thread Richard Weinberger
We can use __NR_syscall_max. Signed-off-by: Richard Weinberger <rich...@nod.at> --- arch/um/kernel/skas/syscall.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/arch/um/kernel/skas/syscall.c b/arch/um/kernel/skas/syscall.c index 64a8fe5..1683b8e 100644 --- a/a

[uml-devel] [PATCH 2/7] um: Store syscall number after syscall_trace_enter()

2015-10-26 Thread Richard Weinberger
To support changing syscall numbers we have to store it after syscall_trace_enter(). Signed-off-by: Richard Weinberger <rich...@nod.at> --- arch/um/include/shared/os.h | 1 + arch/um/kernel/skas/syscall.c | 13 +++-- arch/um/os-Linux/skas/process.c | 10 +++--- 3 files c

[uml-devel] [PATCH 5/7] um: Remove dead code from x86_64 syscall stub

2015-10-26 Thread Richard Weinberger
syscall_stub is dead code as um is using only batch_syscall_stub. Signed-off-by: Richard Weinberger <rich...@nod.at> --- arch/x86/um/stub_32.S | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/um/stub_32.S b/arch/x86/um/stub_32.S index b972649..9881680 100644 --- a/arch/x86/um/s

[uml-devel] [PATCH 7/7] um: Report host OOM more nicely

2015-10-26 Thread Richard Weinberger
If UML runs on the host side out of memory, report this condition more nicely. Signed-off-by: Richard Weinberger <rich...@nod.at> --- arch/um/kernel/tlb.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/arch/um/kernel/tlb.c b/arch/um/kernel/tlb.c

[uml-devel] [PATCH 4/7] um: Remove dead code from x86_64 syscall stub

2015-10-26 Thread Richard Weinberger
syscall_stub is dead code as um is using only batch_syscall_stub. Signed-off-by: Richard Weinberger <rich...@nod.at> --- arch/x86/um/stub_64.S | 13 - 1 file changed, 13 deletions(-) diff --git a/arch/x86/um/stub_64.S b/arch/x86/um/stub_64.S index 7160b20..a212445 100644 ---

[uml-devel] [PATCH 5/7 v2] um: Remove dead symbol from i386 syscall stub

2015-10-26 Thread Richard Weinberger
syscall_stub is nowhere used these days. Signed-off-by: Richard Weinberger <rich...@nod.at> --- This time with the correct commit message. --- arch/x86/um/stub_32.S | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/um/stub_32.S b/arch/x86/um/stub_32.S index b972649..9881680

Re: [uml-devel] [PATCH v3] um: Switch clocksource to hrtimers

2015-10-26 Thread Richard Weinberger
Hi! Am 25.10.2015 um 19:46 schrieb Anton Ivanov: > Hi List, hi Richard, > > I am going to sort out the UBD patchset next as that has no dependencies on > timer and the other stuff which is waiting in the queue behind the timers. > > That should give UML a significant boost. It is nothing

Re: [uml-devel] [uml-user] Possible ways to execute

2015-10-29 Thread Richard Weinberger
Am 29.10.2015 um 14:14 schrieb Balaco Baco: > Really!? I wish I had read that somewhere. Well, just retried with > another option that is there for me. It is one of the cases I detailed > before that end with error. > > The full execution, right now, is: > > == >

Re: [uml-devel] [uml-user] Possible ways to execute

2015-10-29 Thread Richard Weinberger
On Thu, Oct 29, 2015 at 2:21 PM, Balaco Baco <balacob...@imap.cc> wrote: > > On Thu, Oct 29, 2015, at 10:18, Richard Weinberger wrote: >> Am 29.10.2015 um 14:14 schrieb Balaco Baco: >> > Really!? I wish I had read that somewhere. Well, just retried with >> >

Re: [uml-devel] [uml-user] Website is in need of many small changes and updates?

2015-10-29 Thread Richard Weinberger
On Thu, Oct 29, 2015 at 8:46 PM, Balaco Baco wrote: >> > > >> > Really!? I wish I had read that somewhere. Well, just retried with >> > > >> > another option that is there for me. It is one of the cases I >> > > >> > detailed >> > > >> > before that end with error. >> > > >>

Re: [uml-devel] [uml-user] Any reason for a kernel thread not run after calling schedule()?

2015-10-28 Thread Richard Weinberger
On Wed, Oct 28, 2015 at 5:36 PM, Ricardo Nunes wrote: > Hi, > > I'm making a UML driver to adapt a real driver to UML and hardware > emulation. > > In this case I have a kernel thread trying to read a register, which is now > done through a netlink channel to a

Re: [uml-devel] [uml-user] IRQ support?

2015-10-22 Thread Richard Weinberger
Hi! CC'ing -devel list. On Thu, Oct 22, 2015 at 1:29 PM, Ricardo Nunes wrote: > I'm trying to use a real hardware driver inside UML and I,ve come to the IRQ > suppor part. How do you map the hardware into UML? > Right now it's failing on request_irq call, so my

Re: [uml-devel] [PATCH v2] EPOLL Interrupt Controller V2.0

2015-11-10 Thread Richard Weinberger
On Tue, Nov 10, 2015 at 7:42 PM, Anton Ivanov wrote: > Thomas Mayer found a couple of issues which crept up when porting v1 to > the newer kernels. > > It also crashes with his config - I am analyzing the differences between > that and mine to find the culrpit. > >

[uml-devel] [GIT PULL] UML updates for 4.4-rc1

2015-11-10 Thread Richard Weinberger
Weinberger * random cleanups and bug fixes all over the place Anton Ivanov (1): um: Switch clocksource to hrtimers Richard Weinberger (7): um: Define PTRACE_OLDSETOPTIONS um: Store syscall number after syscall_trace_enter

Re: [uml-devel] [PATCH] Missing includes in start up

2015-11-08 Thread Richard Weinberger
On Sun, Nov 8, 2015 at 4:18 PM, Anton Ivanov wrote: > Hi Richard, > > This is vs your tree, 4.x master branch in linus repo actually has > sys/resource.h > > Pls ignore the patch. Sorry for the trouble! I forgot to mention that linux-next is the only valid branch in my tree.

Re: [uml-devel] WARNING: CPU: 0 PID: 908 at include/linux/thread_info.h:128 sigsuspend+0xab/0xc0()

2015-11-16 Thread Richard Weinberger
Am 16.11.2015 um 12:49 schrieb Vegard Nossum: > On 11/16/2015 12:44 PM, Richard Weinberger wrote: >> Am 16.11.2015 um 10:43 schrieb Vegard Nossum: >>> Starting UML like this: >>> >>> ./vmlinux rootfstype=hostfs rw ignore_console_loglevel con=xterm

Re: [uml-devel] WARNING: CPU: 0 PID: 908 at include/linux/thread_info.h:128 sigsuspend+0xab/0xc0()

2015-11-16 Thread Richard Weinberger
Hi! Am 16.11.2015 um 10:43 schrieb Vegard Nossum: > Hi, > > Starting UML like this: > > ./vmlinux rootfstype=hostfs rw ignore_console_loglevel con=xterm > init=/bin/bash > > Results in unpredictable behaviour, most of the time an xterm flashes on > my screen but the process aborts with only

Re: [uml-devel] WARNING: CPU: 0 PID: 908 at include/linux/thread_info.h:128 sigsuspend+0xab/0xc0()

2015-11-16 Thread Richard Weinberger
Am 16.11.2015 um 12:49 schrieb Vegard Nossum: > On 11/16/2015 12:44 PM, Richard Weinberger wrote: >> Am 16.11.2015 um 10:43 schrieb Vegard Nossum: >>> Starting UML like this: >>> >>> ./vmlinux rootfstype=hostfs rw ignore_console_loglevel con=xterm

Re: [uml-devel] [PATCH v2] EPOLL Interrupt Controller V2.0

2015-11-11 Thread Richard Weinberger
On Wed, Nov 11, 2015 at 9:46 PM, Thomas Meyer wrote: > Am Montag, den 09.11.2015, 15:03 + schrieb Anton Ivanov: >> It throws a couple of harmless "epoll del fd" warnings on reboot >> which >> result the fact that disable_fd/enable_fd are not removed in the >> terminal/line

Re: [uml-devel] [PATCH v3] um: Switch clocksource to hrtimers

2015-11-02 Thread Richard Weinberger
Am 02.11.2015 um 15:30 schrieb Anton Ivanov: > On 02/11/15 10:01, Richard Weinberger wrote: >> Am 02.11.2015 um 10:53 schrieb Anton Ivanov: >>> [snip] >>> >>>>>> I'm pretty sure that you don't see the issue as your Jessy userspace >>>>&g

Re: [uml-devel] [PATCH v3] um: Switch clocksource to hrtimers

2015-11-02 Thread Richard Weinberger
Hi! Am 02.11.2015 um 09:14 schrieb Anton Ivanov: > I was testing under similar conditions (CPU pinning using taskset -c 0 on a > multicore). > > I have removed it and run some retests - I cannot reproduce the hang at this > point with my config > > I am going to run a defconfig and compare

Re: [uml-devel] [PATCH v3] um: Switch clocksource to hrtimers

2015-10-31 Thread Richard Weinberger
Am 31.10.2015 um 16:24 schrieb Thomas Meyer: > Am Samstag, den 31.10.2015, 16:21 +0100 schrieb Richard Weinberger: >> Am 31.10.2015 um 16:16 schrieb Thomas Meyer: >>> mhh. strange. I didn't see this behaviour on my machine, but my >>> machine >>> is a rare

Re: [uml-devel] [PATCH v3] um: Switch clocksource to hrtimers

2015-11-02 Thread Richard Weinberger
Am 02.11.2015 um 09:41 schrieb Anton Ivanov: > On 02/11/15 08:37, Richard Weinberger wrote: >> Hi! >> >> Am 02.11.2015 um 09:14 schrieb Anton Ivanov: >>> I was testing under similar conditions (CPU pinning using taskset -c 0 on a >>> multicore). >>>

Re: [uml-devel] [PATCH v3] um: Switch clocksource to hrtimers

2015-11-02 Thread Richard Weinberger
Am 02.11.2015 um 09:57 schrieb Anton Ivanov: > On 02/11/15 08:52, Richard Weinberger wrote: >> Am 02.11.2015 um 09:41 schrieb Anton Ivanov: >>> On 02/11/15 08:37, Richard Weinberger wrote: >>>> Hi! >>>> >>>> Am 02.11.2015 um 09:14 schrieb Anto

Re: [uml-devel] [PATCH v4] um: net: replace GFP_KERNEL with GFP_ATOMIC when spinlock is held

2015-11-06 Thread Richard Weinberger
Am 29.10.2015 um 16:30 schrieb Saurabh Sengar: > since GFP_KERNEL with GFP_ATOMIC while spinlock is held, > as code while holding a spinlock should be atomic. > GFP_KERNEL may sleep and can cause deadlock, > where as GFP_ATOMIC may fail but certainly avoids deadlockdex > f70dd54..d898f6c 100644 >

Re: [uml-devel] [PATCH v4] um: Switch clocksource to hrtimers

2015-11-06 Thread Richard Weinberger
Am 02.11.2015 um 17:16 schrieb Anton Ivanov: > Background: UML is using an obsolete itimer call for > all timers and "polls" for kernel space timer firing > in its userspace portion resulting in a long list > of bugs and incorrect behaviour(s). It also uses > ITIMER_VIRTUAL for its timer which

Re: [uml-devel] [uml-user] Building from source problems and possibilities

2015-10-30 Thread Richard Weinberger
On Fri, Oct 30, 2015 at 5:02 PM, Balaco Baco wrote: > I restarted, now I've got another kernel source (2.6.32.68), knowing > that it may be old, but it's the "newer old" for 2.6, and I hoped that > it would work. Are you an archeologist? ;-) Is there a particular reason why

Re: [uml-devel] [uml-user] Website is in need of many small changes and updates?

2015-10-30 Thread Richard Weinberger
On Fri, Oct 30, 2015 at 7:29 AM, Balaco Baco <balacob...@imap.cc> wrote: > > On Thu, Oct 29, 2015, at 16:55, Richard Weinberger wrote: >> On Thu, Oct 29, 2015 at 8:46 PM, Balaco Baco <balacob...@imap.cc> wrote: >> >> > > >> > Really!? I

Re: [uml-devel] [PATCH v3] um: Switch clocksource to hrtimers

2015-10-31 Thread Richard Weinberger
Am 31.10.2015 um 17:22 schrieb Anton Ivanov: > Richard, can you send me your config. Sure. It is basically a defconfig. > I have had it running for a couple of days before submission both under load > and idle it was doing OK. Well, what userspace did you try? I did some more tests, if

Re: [uml-devel] [PATCH v3] um: Switch clocksource to hrtimers

2015-10-31 Thread Richard Weinberger
Am 31.10.2015 um 16:44 schrieb Thomas Meyer: > Am Samstag, den 31.10.2015, 16:30 +0100 schrieb Richard Weinberger: >> Am 31.10.2015 um 16:24 schrieb Thomas Meyer: >>> Am Samstag, den 31.10.2015, 16:21 +0100 schrieb Richard Weinberger: >>>> Am 31.10.2015 um 16:16 s

Re: [uml-devel] [PATCH v3] um: Switch clocksource to hrtimers

2015-10-31 Thread Richard Weinberger
On Thu, Oct 29, 2015 at 7:23 AM, Anton Ivanov wrote: > I got the first patchset to build, it works very well on a single core > host or with CPU pinning of the UML - the performance gain is > 25%. > > However, I introduced a race somewhere along the way - it

Re: [uml-devel] [PATCH v3] um: Switch clocksource to hrtimers

2015-10-31 Thread Richard Weinberger
Am 31.10.2015 um 16:10 schrieb Thomas Meyer: > Am Samstag, den 31.10.2015, 14:54 +0100 schrieb Richard Weinberger: >> On Thu, Oct 29, 2015 at 7:23 AM, Anton Ivanov >> <anton.iva...@kot-begemot.co.uk> wrote: >>> I got the first patchset to build, it works very well

Re: [uml-devel] [PATCH v3] um: Switch clocksource to hrtimers

2015-10-31 Thread Richard Weinberger
Am 31.10.2015 um 16:16 schrieb Thomas Meyer: > mhh. strange. I didn't see this behaviour on my machine, but my machine > is a rare single core system so, likely a race condition while relaying > the timer interrupt to the userspace process. Here I can trigger it by starting UML, logging in and

Re: [uml-devel] [uml-user] Building from source problems and possibilities

2015-10-30 Thread Richard Weinberger
On Fri, Oct 30, 2015 at 8:30 PM, Richard Weinberger <richard.weinber...@gmail.com> wrote: > On Fri, Oct 30, 2015 at 5:02 PM, Balaco Baco <balacob...@imap.cc> wrote: >> I restarted, now I've got another kernel source (2.6.32.68), knowing >> that it may be old, but i

[uml-devel] [GIT PULL] UML fixes for 4.3-rc6

2015-10-19 Thread Richard Weinberger
Hilse (1): um: Do not rely on libc to provide modify_ldt() Richard Weinberger (3): um: Fix out-of-tree build um: Fix waitpid() usage in helper code um: Fix kernel mode fault condition arch/um/Makefile | 4 ++-- arch/um/kernel/trap.c | 2 +- arch/um/os-Linux

Re: [uml-devel] [PATCH] um: Switch clocksource to hrtimers

2015-10-13 Thread Richard Weinberger
On Tue, Aug 18, 2015 at 6:04 PM, Thomas Meyer <tho...@m3y3r.de> wrote: > Am 15.08.2015 10:15 vorm. schrieb Richard Weinberger <rich...@nod.at>: >> >> Am 09.08.2015 um 19:53 schrieb Thomas Meyer: >> > Switch the UML clocksource from interval timers to posix

Re: [uml-devel] [PATCH] um: umid: Use strdup to simplify code

2015-07-08 Thread Richard Weinberger
Hi Jeff, Am 08.07.2015 um 21:56 schrieb Jeff Dike: ... Nice patch elided ... I have a bit of a problem here - Christophe isn't a member of uml-devel, so Mailman is sitting on his post until it's approved by a list moderator, namely me. So far, so good, except that my uml-devel password

Re: [uml-devel] [PATCH] um: umid: Use strdup to simplify code

2015-07-08 Thread Richard Weinberger
Am 08.07.2015 um 21:15 schrieb Christophe JAILLET: Replace a malloc+strcpy by an equivalent strdup in order to improve readability. Makes sense! Turn a some spaces into a tab to be consistent with the rest of the code. Do this in an extra patch. One logical change per patch please. Thanks,

[uml-devel] [PATCH] um: Fix fpstate handling

2015-11-29 Thread Richard Weinberger
The x86 FPU cleanup changed fpstate to a plain integer. UML on x86 has to deal with that too. Signed-off-by: Richard Weinberger <rich...@nod.at> diff --git a/arch/x86/um/signal.c b/arch/x86/um/signal.c index 06934a8..e5f854c 100644 --- a/arch/x86/um/signal.c +++ b/arch/x86/um/signal.c @@

Re: [uml-devel] [GIT PULL] UML fixes for 4.4-rc5

2015-12-09 Thread Richard Weinberger
Linus, Am 09.12.2015 um 02:35 schrieb Linus Torvalds: > On Tue, Dec 8, 2015 at 1:39 PM, Richard Weinberger <rich...@nod.at> wrote: >> >> This pull request contains various bug fixes, most of them are >> fall out from the merge window. >> >> Richard W

Re: [uml-devel] [PATCH] um: fix returns without va_end

2015-12-08 Thread Richard Weinberger
On Tue, Dec 1, 2015 at 9:18 PM, Geyslan G. Bem wrote: > When using va_list ensure that va_start will be followed by va_end. > > Signed-off-by: Geyslan G. Bem > --- > arch/um/drivers/net_user.c | 10 ++ > 1 file changed, 6 insertions(+), 4

Re: [uml-devel] [PATCH] arch: um: fix error when linking vmlinux.

2015-12-08 Thread Richard Weinberger
On Wed, Nov 18, 2015 at 3:12 PM, Lorenzo Colitti wrote: > On gcc Ubuntu 4.8.4-2ubuntu1~14.04, linking vmlinux fails with: > > arch/um/os-Linux/built-in.o: In function `os_timer_create': > /android/kernel/android/arch/um/os-Linux/time.c:51: undefined reference to >

[uml-devel] [GIT PULL] UML fixes for 4.4-rc5

2015-12-08 Thread Richard Weinberger
. Geyslan G. Bem (1): um: fix returns without va_end Lorenzo Colitti (1): arch: um: fix error when linking vmlinux. Richard Weinberger (2): um: Fix get_signal() usage um: Fix fpstate handling arch/um/Makefile | 2 +- arch/um/drivers/net_user.c | 10

Re: [uml-devel] uml instance crashes when started from script

2015-12-08 Thread Richard Weinberger
Hi! Am 06.12.2015 um 16:34 schrieb Vegard Nossum: > Hi, > > I've been running into some odd crashes when starting my UML instance from > Python. This is my script: > > import subprocess > subprocess.check_call(['path/to/vmlinux', 'mem=2048M', 'rootfstype=hostfs', > 'rw', 'init=/bin/bash']) >

Re: [uml-devel] [PATCH] uml: fix hostfs mknod()

2015-12-16 Thread Richard Weinberger
Am 16.12.2015 um 21:59 schrieb Vegard Nossum: > An inverted return value check in hostfs_mknod() caused the function > to return success after handling it as an error (and cleaning up). > > It resulted in the following segfault when trying to bind() a named > unix socket: > > Pid: 198, comm:

Re: [uml-devel] IRQ handler reentrancy

2015-12-10 Thread Richard Weinberger
On Fri, Nov 20, 2015 at 1:05 PM, Anton Ivanov wrote: > I have gotten to the bottom of this. > > 1. The IRQ handler re-entrancy issue predates the timer patch. Adding a > simple guard with a WARN_ON_ONCE around the device loop in the > sig_io_handler catches it in

Re: [uml-devel] IRQ handler reentrancy

2015-12-11 Thread Richard Weinberger
Am 11.12.2015 um 07:58 schrieb Anton Ivanov: >>> 2. I cannot catch what is wrong with the current code in signal.c. When >>> I read it, it should not produce re-entrancy. But it does. >> Sorry for the delay. Until now I did not find the time to dig into that. >> Did you find the offending code in

Re: [uml-devel] IRQ handler reentrancy

2015-12-11 Thread Richard Weinberger
Am 11.12.2015 um 12:24 schrieb Anton Ivanov: > On 11/12/15 08:16, Richard Weinberger wrote: >> Am 11.12.2015 um 07:58 schrieb Anton Ivanov: >>>>> 2. I cannot catch what is wrong with the current code in signal.c. When >>>>> I read it, it should not produ

Re: [uml-devel] [PATCH] [RFC] um: define and use HAVE_LIBPCAP/HAVE_LIBVDEPLUG

2016-01-02 Thread Richard Weinberger
Am 02.01.2016 um 03:31 schrieb Vegard Nossum: > If you don't have libpcap or libvdeplug installed, you will get build > failures when compiling certain files: > > arch/um/drivers/vde_user.c:8:24: fatal error: libvdeplug.h: No such file or > directory > #include > >

Re: [uml-devel] [PATCH] um: link with -lpthread

2015-12-31 Thread Richard Weinberger
Am 31.12.2015 um 17:21 schrieb Thomas Meyer: > Am 31.12.2015 5:06 nachm. schrieb Vegard Nossum : >> >> Similarly to commit fb1770aa78a43530940d0c2dd161e77bc705bdac, with gcc 5 >> on Ubuntu and CONFIG_STATIC_LINK=y I was seeing these linker errors: > > Hi, > > Oops,

Re: [uml-devel] [PATCH] um: Fix get_signal() usage

2016-01-09 Thread Richard Weinberger
Am 09.01.2016 um 04:51 schrieb Al Viro: > On Wed, Nov 18, 2015 at 09:51:43AM +0100, Richard Weinberger wrote: >> If get_signal() returns us a signal to post >> we must not call it again, otherwise the already >> posted signal will be overridden. >> Before commit a610d6e6

Re: [uml-devel] [PATCH] um: Fix pointer cast

2015-12-22 Thread Richard Weinberger
laün <m...@digikod.net> > Cc: Jeff Dike <jd...@addtoit.com> > Cc: Richard Weinberger <rich...@nod.at> > Cc: Linus Torvalds <torva...@linux-foundation.org> > --- > arch/x86/um/signal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > d

Re: [uml-devel] [PATCH] um: Fix build error and kconfig for i386

2015-12-22 Thread Richard Weinberger
.o: In function `elf_core_write_extra_data': > (.text+0x3eef): undefined reference to `dump_emit' > > Signed-off-by: Mickaël Salaün <m...@digikod.net> > Cc: Jeff Dike <jd...@addtoit.com> > Cc: Richard Weinberger <rich...@nod.at> > --- > arch/x86/um/Kconfig | 1 + > 1 file change

Re: [uml-devel] [PATCH v2] um: Fix pointer cast

2015-12-23 Thread Richard Weinberger
m...@digikod.net> > Cc: Jeff Dike <jd...@addtoit.com> > Cc: Richard Weinberger <rich...@nod.at> > Cc: Linus Torvalds <torva...@linux-foundation.org> > Cc: Al Viro <v...@zeniv.linux.org.uk> > --- > arch/x86/um/signal.c | 2 +- > 1 file changed, 1 inse

Re: [uml-devel] [PATCH 2/2] um: Use race-free temporary file creation

2015-11-28 Thread Richard Weinberger
Am 28.11.2015 um 23:56 schrieb Mickaël Salaün: > > On 28/11/2015 23:07, Richard Weinberger wrote: >> Am 28.11.2015 um 22:32 schrieb Mickaël Salaün: >>> Open the memory mapped file with the O_TMPFILE flag when available. >>> >>> Signed-off-by: Mickaël Salaün

Re: [uml-devel] [PATCH 1/2] um: Set secure access mode for temporary file

2015-11-28 Thread Richard Weinberger
Am 28.11.2015 um 22:32 schrieb Mickaël Salaün: > Replace the default insecure mode 0777 with 0700 for temporary file. > > Prohibit other users to change the executable mapped code. Hmm, isn't the tmp file already unlinked at this stage? Thanks, //richard

Re: [uml-devel] [PATCH 2/2] um: Use race-free temporary file creation

2015-11-28 Thread Richard Weinberger
Am 28.11.2015 um 22:32 schrieb Mickaël Salaün: > Open the memory mapped file with the O_TMPFILE flag when available. > > Signed-off-by: Mickaël Salaün > --- > arch/um/os-Linux/mem.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/arch/um/os-Linux/mem.c

Re: [uml-devel] [PATCH 1/2] um: Set secure access mode for temporary file

2015-11-28 Thread Richard Weinberger
Am 28.11.2015 um 23:52 schrieb Mickaël Salaün: > > On 28/11/2015 22:40, Richard Weinberger wrote: >> Am 28.11.2015 um 22:32 schrieb Mickaël Salaün: >>> Replace the default insecure mode 0777 with 0700 for temporary file. >>> >>> Prohibit other users to chang

Re: [uml-devel] [PATCH 1/2] um: Set secure access mode for temporary file

2015-11-28 Thread Richard Weinberger
Am 29.11.2015 um 00:00 schrieb Mickaël Salaün: > > > On 28/11/2015 23:55, Richard Weinberger wrote: >> Am 28.11.2015 um 23:52 schrieb Mickaël Salaün: >>> >>> On 28/11/2015 22:40, Richard Weinberger wrote: >>>> Am 28.11.2015 um 22:32 schrieb Mickaël Sa

Re: [uml-devel] Old process in D state bug

2015-11-27 Thread Richard Weinberger
Hi! Am 26.11.2015 um 10:49 schrieb Anton Ivanov: > Hi List, hi Richard, > > While working on the EPOLL I managed to consistently reproduce and get down > to the bottom of the process in D state bug which you occasionally see with > UML. I recall asking > Richard's help on this for the first

Re: [uml-devel] [PATCH v4] um: Switch clocksource to hrtimers

2015-11-18 Thread Richard Weinberger
Am 18.11.2015 um 08:10 schrieb Lorenzo Colitti: > On Wed, Nov 18, 2015 at 4:00 PM, Anton Ivanov > wrote: >> It is. >> >> You need -lrt to link in HR timers. However, the original patch should add >> that to the library list. I need to understand why it does not in

[uml-devel] [PATCH] um: Fix get_signal() usage

2015-11-18 Thread Richard Weinberger
("pull clearing RESTORE_SIGMASK into block_sigmask()") Signed-off-by: Richard Weinberger <rich...@nod.at> --- arch/um/kernel/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/um/kernel/signal.c b/arch/um/kernel/signal.c index 57acbd6..fc8be0e 10064

Re: [uml-devel] [PATCH v4] um: Switch clocksource to hrtimers

2015-11-18 Thread Richard Weinberger
Hi! Am 18.11.2015 um 14:32 schrieb Lorenzo Colitti: > On Wed, Nov 18, 2015 at 5:06 PM, Richard Weinberger <rich...@nod.at> wrote: >> >>> That command line doesn't work, but if you remove the -lrt and put it >>> at the end of the line, it starts

Re: [uml-devel] IRQ handler reentrancy

2015-11-20 Thread Richard Weinberger
On Fri, Nov 20, 2015 at 1:05 PM, Anton Ivanov wrote: > I have gotten to the bottom of this. > > 1. The IRQ handler re-entrancy issue predates the timer patch. Adding a > simple guard with a WARN_ON_ONCE around the device loop in the > sig_io_handler catches it in

  1   2   3   4   5   6   7   8   >