Re: Use of lombok in camel codebase?

2021-11-07 Thread Otavio Rodolfo Piske
I was echoing Andrea’s question about our build having way more issues. Not about Lombok - I am not a fan of it as well. Otavio R. Piske > On Nov 7, 2021, at 20:21, Steve973 wrote: > This all becomes rather moot at the moment when Claus says, "We will not > use Lombok.". It is off the table

Re: Use of lombok in camel codebase?

2021-11-07 Thread Steve973
This all becomes rather moot at the moment when Claus says, "We will not use Lombok.". It is off the table for camel. On all of our other projects, an examination of benefits and drawbacks of Lombok is a discussion for that team. Enjoy! On Sun, Nov 7, 2021, 8:15 AM Otavio Rodolfo Piske wrote:

Re: Use of lombok in camel codebase?

2021-11-07 Thread Otavio Rodolfo Piske
I'd be interested in hearing about these problems too. Depending on what they are and if there's enough* of those, we could even create some tickets on Jira to acknowledge and track the progress. It would certainly help to fix them - supposing it's something there's consensus about. On Tue, Nov

Re: Use of lombok in camel codebase?

2021-11-07 Thread Otavio Rodolfo Piske
Personally I am not a fan of Lombok either. I do recognize there can be some (small) convenience in using it [1]. However, I think it would be better to drive our efforts towards modernizing the codebase to use features from newer Java versions (*when* the time comes). Some of these features

Re: Use of lombok in camel codebase?

2021-11-04 Thread Tadayoshi Sato
Yes, Lombok should be best for using with a Camel application, but not necessary so for the framework/library code of Camel itself. Code simplicity is great but sometimes being explicit wins over magical simplicity. As an object-oriented programmer, if we need getters/setters in the code I think

Re: Use of lombok in camel codebase?

2021-11-02 Thread Vyacheslav Boyko
Lombok have advantages and disadvantages both. With bringing reducing of annoying boilerplate it brings its "magic" of underlying code generation which could be understood only by having some level of practice using Lobmok. For example, deserialization troubles when a constructor have more

Re: Use of lombok in camel codebase?

2021-11-02 Thread Andrea Cosentino
So I wouldn't introduce Lombok Just for readability. Il mar 2 nov 2021, 22:57 Andrea Cosentino ha scritto: > Obviously this is my point of view, but technically,IMO, Lombok Is just a > lot of hype with more or less zero advantages, except readability. > > Il mar 2 nov 2021, 22:54 Andrea

Re: Use of lombok in camel codebase?

2021-11-02 Thread Andrea Cosentino
Obviously this is my point of view, but technically,IMO, Lombok Is just a lot of hype with more or less zero advantages, except readability. Il mar 2 nov 2021, 22:54 Andrea Cosentino ha scritto: > What are you mentioning is not for free. You don't see the boilerplate, > but there is no magic,

Re: Use of lombok in camel codebase?

2021-11-02 Thread Andrea Cosentino
What are you mentioning is not for free. You don't see the boilerplate, but there is no magic, you'll pay this anyway. There is no good reason for using Lombok and i don't feel disturbed by reading boilerplate code or getter/setter Il mar 2 nov 2021, 22:35 Steve973 ha scritto: > You see no

Re: Use of lombok in camel codebase?

2021-11-02 Thread Steve973
You see no advantage in getting boilerplate code for free, and keeping your beans, etc, free from accessors/mutators, no arg constructors, all arg constructors, getting a builder for free, and lots of other stuff? I can see avoiding it in a project for particular reasons, but most of the

Re: Use of lombok in camel codebase?

2021-11-02 Thread Andrea Cosentino
There is no problem with license. Personally i never find any advantage in using Lombok. Il mar 2 nov 2021, 21:23 Steve973 ha scritto: > Hello. I normally use lombok to take care of boiler plate code in projects > that I work on. I have noticed that lombok is not used in the camel code >

Re: Use of lombok in camel codebase?

2021-11-02 Thread Andrea Cosentino
What way more issues do you see in the build? Il mar 2 nov 2021, 21:44 Romain Manni-Bucau ha scritto: > Hi Steve, > > Some ASF projects use it but the IDE setup step is reducing a bit > contributions - even if I can agree camel build has way more issues - but > since lombok is far to be

Re: Use of lombok in camel codebase?

2021-11-02 Thread Romain Manni-Bucau
Hi Steve, Some ASF projects use it but the IDE setup step is reducing a bit contributions - even if I can agree camel build has way more issues - but since lombok is far to be mainstream - and it will be worse with java 17 - I guess it is part of the story there, but no legal issue AFAIK. Romain

Re: Use of lombok in camel codebase?

2021-11-02 Thread Steve973
Ok. Thanks, Claus. Do you mind explaining the rationale behind this? On Tue, Nov 2, 2021 at 4:39 PM Claus Ibsen wrote: > We will not use lombock > > > On Tue, 2 Nov 2021 at 21.23, Steve973 wrote: > > > Hello. I normally use lombok to take care of boiler plate code in > projects > > that I

Re: Use of lombok in camel codebase?

2021-11-02 Thread Claus Ibsen
We will not use lombock On Tue, 2 Nov 2021 at 21.23, Steve973 wrote: > Hello. I normally use lombok to take care of boiler plate code in projects > that I work on. I have noticed that lombok is not used in the camel code > base. Is there something about it (licensing or something else) that

Use of lombok in camel codebase?

2021-11-02 Thread Steve973
Hello. I normally use lombok to take care of boiler plate code in projects that I work on. I have noticed that lombok is not used in the camel code base. Is there something about it (licensing or something else) that makes it unsuitable for camel? I am working on something in camel-core, and