Re: Rules for invisible div and 0pt font?

2019-06-26 Thread Amir Caspi
On Jun 18, 2019, at 2:21 AM, Giovanni Bechis wrote: > >> rawbody AC_HIDDEN_FONT /font-size\s*:\s*0\s*(?:em|pt|px|%)\s*;/ >> > There is T_HIDDEN_WORD on my sandbox > (https://ruleqa.spamassassin.org/20190617-r1861495-n/T_HIDDEN_WORD/detail) > I have just committed a more generic version.

Re: Rules for invisible div and 0pt font?

2019-06-18 Thread Paul Stead
Just going from http://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/gbechis/20_html.cf?revision=1861560

Re: Rules for invisible div and 0pt font?

2019-06-18 Thread John Hardin
On Tue, 18 Jun 2019, Paul Stead wrote: On Tue, 18 Jun 2019 at 19:14, John Hardin wrote: On Tue, 18 Jun 2019, Giovanni Bechis wrote: On 6/17/19 9:14 PM, Amir Caspi wrote: There is a div here with display:none, as well as font-size:0px. The spample hits HTML_FONT_LOW_CONTRAST but does not

Re: Rules for invisible div and 0pt font?

2019-06-18 Thread Paul Stead
On Tue, 18 Jun 2019 at 20:23, Paul Stead wrote: > Also rename from T_ otherwise it will be skipped. If you drop the T_ and > omit the publish it will let QA decide if performance is good enough :) > Although not looking so good today -

Re: Rules for invisible div and 0pt font?

2019-06-18 Thread Paul Stead
On Tue, 18 Jun 2019 at 19:14, John Hardin wrote: > On Tue, 18 Jun 2019, Giovanni Bechis wrote: > > > On 6/17/19 9:14 PM, Amir Caspi wrote: > >> There is a div here with display:none, as well as font-size:0px. The > spample hits HTML_FONT_LOW_CONTRAST but does not appear to hit any rule >

Re: Rules for invisible div and 0pt font?

2019-06-18 Thread John Hardin
On Tue, 18 Jun 2019, Giovanni Bechis wrote: On 6/17/19 9:14 PM, Amir Caspi wrote: There is a div here with display:none, as well as font-size:0px. The spample hits HTML_FONT_LOW_CONTRAST but does not appear to hit any rule relating to a hidden div or tiny font. There is T_HIDDEN_WORD on

Re: Rules for invisible div and 0pt font?

2019-06-18 Thread Amir Caspi
On Jun 18, 2019, at 10:55 AM, Bill Cole wrote: > > Looking at the 2 most recent (a USPS "Informed Delivery Daily Digest" message > and Office Depot order followup) I see display:none only in inline style > attributes of block elements. e.g.: Looks like the first one is a web bug. The

Re: Rules for invisible div and 0pt font?

2019-06-18 Thread Bill Cole
On 18 Jun 2019, at 10:52, Amir Caspi wrote: Are the matches all within @media blocks like lbutlr suggested or do they occur inline within div/span/etc as well? Looking at the 2 most recent (a USPS "Informed Delivery Daily Digest" message and Office Depot order followup) I see display:none

Re: Rules for invisible div and 0pt font?

2019-06-18 Thread Amir Caspi
Are the matches all within @media blocks like lbutlr suggested or do they occur inline within div/span/etc as well? Thanks! --- Amir thumbed via iPhone > On Jun 18, 2019, at 8:42 AM, Bill Cole > wrote: > >> On 17 Jun 2019, at 15:25, @lbutlr wrote: >> >>> On Jun 17, 2019, at 1:14 PM, Amir

Re: Rules for invisible div and 0pt font?

2019-06-18 Thread Bill Cole
On 17 Jun 2019, at 15:25, @lbutlr wrote: On Jun 17, 2019, at 1:14 PM, Amir Caspi wrote: rawbody AC_HIDDEN_ELEMENT /display\s*:\s*none\s*;/ Since display:none is a pretty common method for showing and hiding elements depending on things like screen size, I would guess this is going

Re: Rules for invisible div and 0pt font?

2019-06-18 Thread Dan Malm
On 2019-06-17 21:26, Amir Caspi wrote:> On Jun 17, 2019, at 1:14 PM, Amir Caspi > wrote: >> >> rawbodyAC_HIDDEN_FONT/font-size\s*:\s*0\s*(?:em|pt|px|%)\s*;/ >> > > Actually, based on another spample (https://pastebin.com/rrU2AsVT), > let's modify this one -- the

Re: Rules for invisible div and 0pt font?

2019-06-18 Thread Giovanni Bechis
On 6/17/19 9:14 PM, Amir Caspi wrote: > Hi all, > > In reviewing today's FNs I came across the following spample: > https://pastebin.com/9QQVwUY6 > > There is a div here with display:none, as well as font-size:0px. The spample > hits HTML_FONT_LOW_CONTRAST but does not appear to hit any rule

Re: Rules for invisible div and 0pt font?

2019-06-17 Thread Amir Caspi
On Jun 17, 2019, at 2:17 PM, Amir Caspi wrote: > > rawbody AC_MEDIA_DISPLAYNONE > /@media[^{]*{[^}]*display\s*:\s*none\s*;/i > Well, urgh, this particular rule wouldn't work well since it wouldn't capture classes within the @media block. But something LIKE it. --- Amir

Re: Rules for invisible div and 0pt font?

2019-06-17 Thread Amir Caspi
On Jun 17, 2019, at 1:45 PM, @lbutlr wrote: > > Would only be active if the width of the window is 900px or less. That can > include setting a display property to hidden or not. One way of working around that, then, would be to ensure this is only within a div/span tag... Maybe something

Re: Rules for invisible div and 0pt font?

2019-06-17 Thread @lbutlr
On Jun 17, 2019, at 1:30 PM, Amir Caspi wrote: > Wouldn't that only be true for dynamic content that can actually evaluate the > screensize, and hence would require javascript? Or is there a way of doing > this with static email content? (I'm very well versed in HTML for web > browsers, but

Re: Rules for invisible div and 0pt font?

2019-06-17 Thread Amir Caspi
On Jun 17, 2019, at 1:18 PM, Antony Stone wrote: > > If this feature *is* used for screenreaders, you could be creating a false > positive trap here... You may well be right, hence the request to sandbox and see how it compares against masscheck. On Jun 17, 2019, at 1:25 PM, @lbutlr wrote:

Re: Rules for invisible div and 0pt font?

2019-06-17 Thread Amir Caspi
On Jun 17, 2019, at 1:14 PM, Amir Caspi wrote: > > rawbody AC_HIDDEN_FONT /font-size\s*:\s*0\s*(?:em|pt|px|%)\s*;/ > Actually, based on another spample (https://pastebin.com/rrU2AsVT ), let's modify this one -- the em/pt/px/% isn't required: rawbody

Re: Rules for invisible div and 0pt font?

2019-06-17 Thread @lbutlr
On Jun 17, 2019, at 1:14 PM, Amir Caspi wrote: > rawbody AC_HIDDEN_ELEMENT /display\s*:\s*none\s*;/ Since display:none is a pretty common method for showing and hiding elements depending on things like screen size, I would guess this is going to hit mostly ham. -- It was easy to

Re: Rules for invisible div and 0pt font?

2019-06-17 Thread Antony Stone
On Monday 17 June 2019 at 21:14:36, Amir Caspi wrote: > Hi all, > > In reviewing today's FNs I came across the following spample: > https://pastebin.com/9QQVwUY6 > > There is a div here with display:none, as well as font-size:0px. The > spample hits HTML_FONT_LOW_CONTRAST but does not appear

Rules for invisible div and 0pt font?

2019-06-17 Thread Amir Caspi
Hi all, In reviewing today's FNs I came across the following spample: https://pastebin.com/9QQVwUY6 There is a div here with display:none, as well as font-size:0px. The spample hits HTML_FONT_LOW_CONTRAST but does not appear to hit any rule relating to a hidden div or tiny font. Does