Re: Autolinking Relative Paths

2008-03-18 Thread Gwyn Evans
On 16/03/2008, James Carman [EMAIL PROTECTED] wrote: 3. Document the valid path syntax (and limitations) in the Wiki, WIA, etc. +1 - but it should at least be in the Wiki, though. I remember getting frustrated when seeing replies on the Tapestry lists that said Buy Kent Tong's book.

Re: Autolinking Relative Paths

2008-03-18 Thread James Carman
On 3/18/08, Gwyn Evans [EMAIL PROTECTED] wrote: On 16/03/2008, James Carman [EMAIL PROTECTED] wrote: 3. Document the valid path syntax (and limitations) in the Wiki, WIA, etc. +1 - but it should at least be in the Wiki, though. I remember getting frustrated when seeing

Autolinking Relative Paths

2008-03-16 Thread James Carman
Suppose I have a package structure like this... com.mycompany.myproject --- module1 --- page - Page1.html --- module2 --- page - Page2.html If I want to autolink from Page1.html to Page2.html, it would look like: wicket:link a href=../../module2/page/Page2.htmlClick

Re: Autolinking Relative Paths

2008-03-16 Thread Phil Grimm
That's funny, I was about to post regarding the numerous issues with wicket:link... And one suggestion I was going to give was to add support for ../packge/Page.html. I don't think it currently supports this, at least I couldn't see it from a code examination. Your only option, I believe, is to

Re: Autolinking Relative Paths

2008-03-16 Thread James Carman
On 3/16/08, Phil Grimm [EMAIL PROTECTED] wrote: That's funny, I was about to post regarding the numerous issues with wicket:link... And one suggestion I was going to give was to add support for ../packge/Page.html. I don't think it currently supports this, at least I couldn't see it from

Re: Autolinking Relative Paths

2008-03-16 Thread Phil Grimm
I think a JIRA request is appropriate. Perhaps we'll hear a confirmation from the Wicket developers. I'd add the following to the request... 1. Add support for ../ relative path resolution 2. Add support for searching the classpath (if absolute and relative search fails) -- I think this is

Re: Autolinking Relative Paths

2008-03-16 Thread James Carman
On 3/16/08, Phil Grimm [EMAIL PROTECTED] wrote: I think a JIRA request is appropriate. Perhaps we'll hear a confirmation from the Wicket developers. I'd add the following to the request... 1. Add support for ../ relative path resolution +1 - This is essential and shouldn't be very

Re: Autolinking Relative Paths

2008-03-16 Thread Igor Vaynberg
you guys do both realize that wicket:link is nothing more then convinience. it isnt really meant to support all these complex usecases. it is nice when you need to quickly include an image or link to a near by page, but nothing more then that. -igor On Sun, Mar 16, 2008 at 10:24 AM, James

Re: Autolinking Relative Paths

2008-03-16 Thread James Carman
On 3/16/08, Igor Vaynberg [EMAIL PROTECTED] wrote: you guys do both realize that wicket:link is nothing more then convinience. it isnt really meant to support all these complex usecases. it is nice when you need to quickly include an image or link to a near by page, but nothing more then

Re: Autolinking Relative Paths

2008-03-16 Thread Phil Grimm
Yeah, as a new user to Wicket, I just see it as another feature of Wicket. There's no issues with it, if all your pages are in the same package. Is that what most Wicket developers do? I agree that searching the classpath could be problematic and more involved to implement. But, the ../ support

Re: Autolinking Relative Paths

2008-03-16 Thread James Carman
On 3/16/08, James Carman [EMAIL PROTECTED] wrote: On 3/16/08, Igor Vaynberg [EMAIL PROTECTED] wrote: you guys do both realize that wicket:link is nothing more then convinience. it isnt really meant to support all these complex usecases. it is nice when you need to quickly include an

Re: Autolinking Relative Paths

2008-03-16 Thread James Carman
On 3/16/08, James Carman [EMAIL PROTECTED] wrote: In fact, I believe I already have a patch that fixes it. I'll create a JIRA and attach the patch. You folks can discuss whether it is worthy or not to make it into core. For future reference, I've created:

Re: Autolinking Relative Paths

2008-03-16 Thread Igor Vaynberg
../ syntax is just as prone to refactoring errors as the absolute path, so i dont buy that argument -igor On Sun, Mar 16, 2008 at 11:51 AM, Phil Grimm [EMAIL PROTECTED] wrote: Yeah, as a new user to Wicket, I just see it as another feature of Wicket. There's no issues with it, if all your

Re: Autolinking Relative Paths

2008-03-16 Thread Phil Grimm
Well, ../ path it's slightly more tolerant to refactoring. You can change anything that comes before the ../ without needing to touch HTML files. So Igor, do you always use absolute paths? I'm thinking that's what I'll use, since the limited relative path support only works when the current page

Re: Autolinking Relative Paths

2008-03-16 Thread Igor Vaynberg
On Sun, Mar 16, 2008 at 2:48 PM, Phil Grimm [EMAIL PROTECTED] wrote: So Igor, do you always use absolute paths? i only use wicket:link for trivial cases. for example, if one of my components needs to display an image or include a js file that lives next to it -igor