Re: Wicket ajax-enabled enclosures

2011-02-16 Thread Martin Makundi
Hi! Any thoughts about getting this into next release? It is fully backed with tests etc. so it should be easy to commit. We could provide necessary wiki update also. ** Martin 2011/2/6 Martin Makundi martin.maku...@koodaripalvelut.com: Hi Martin! We have provided a patch

Re: Wicket ajax-enabled enclosures

2011-02-16 Thread Martin Grigorov
Hi, On Wed, Feb 16, 2011 at 5:17 PM, Martin Makundi martin.maku...@koodaripalvelut.com wrote: Hi! Any thoughts about getting this into next release? It is fully backed with tests etc. so it should be easy to commit. We could provide necessary wiki update also. I took a look at it but it

Re: Wicket ajax-enabled enclosures

2011-02-16 Thread Martin Makundi
I took a look at it but it is quite a big changelist ... I think our expert in the area - Juergen - have to take a look before committing it. I also think such bigger new features should go in 1.5 only (disclaimer: I don't use 1.4 these days) It is not so big... but I am keen to hear

Re: Wicket ajax-enabled enclosures

2011-02-16 Thread Martin Grigorov
On Wed, Feb 16, 2011 at 5:29 PM, Martin Makundi martin.maku...@koodaripalvelut.com wrote: I took a look at it but it is quite a big changelist ... I think our expert in the area - Juergen - have to take a look before committing it. I also think such bigger new features should go in 1.5

Re: Wicket ajax-enabled enclosures

2011-02-16 Thread Martin Makundi
As soon as we have enough confidence it is stable enough for the most users. And this will happen as soon as you (the users start to upgrade and report problems). As you know we have limited resources and supporting more branches is hard for us. That's why I prefer to reduce the work on the

Re: Wicket ajax-enabled enclosures

2010-11-10 Thread Jeremy Thomerson
On Tue, Nov 9, 2010 at 4:27 AM, Martin Makundi martin.maku...@koodaripalvelut.com wrote: Hi! Does wicket:enclosure have capability to setOutputMarkupPlaceholderTag ? What I mean is that when I have: wicket:enclosure child=optional-field tr tdoptional content/td tdinput type=text

Wicket ajax-enabled enclosures

2010-11-09 Thread Martin Makundi
Hi! Does wicket:enclosure have capability to setOutputMarkupPlaceholderTag ? What I mean is that when I have: wicket:enclosure child=optional-field tr tdoptional content/td tdinput type=text wicket:id=optional-field//td /tr /wicket If I set it invisible via ajax I cannot set it visible

Re: Wicket ajax-enabled enclosures

2010-11-09 Thread Martin Makundi
Hi! Has this been attempted before? Would it be a good idea to go at it? Sure would help removing some boilerplate webmarkupcontainer code. Existing jira issue for this? ** Martin 2010/11/9 Martin Makundi martin.maku...@koodaripalvelut.com: Hi! Does wicket:enclosure have capability to

Re: Wicket ajax-enabled enclosures

2010-11-09 Thread Martin Grigorov
On Tue, Nov 9, 2010 at 4:39 PM, Martin Makundi martin.maku...@koodaripalvelut.com wrote: Hi! Has this been attempted before? Would it be a good idea to go at it? Sure would help removing some boilerplate webmarkupcontainer code. Existing jira issue for this? At least I haven't seen one.

Re: Wicket ajax-enabled enclosures

2010-11-09 Thread Martin Makundi
It is pretty similar syntax to wicket:message. any pointers how to implement it or if there would be some pitfalls? I understand transarent markup containers are somewhat tricky? ** Martin 2010/11/9 Martin Grigorov mgrigo...@apache.org: On Tue, Nov 9, 2010 at 4:39 PM, Martin Makundi

Re: Wicket ajax-enabled enclosures

2010-11-09 Thread Brian Topping
It's the same pattern as the last suggestion you had: 1) Generate a patch with a Quickstart that demonstrates the proposed functionality 2) Attach it to a Jira issue First impressions matter a lot, so if you post the Jira without the code, it's going to get ignored, possibly even after you