I apologize if I'm being dense, but from what I can tell storing a
Foreign in
|data| is completely safe. Clearly, storing a void* directly would not be.
you're right. very sorry for the back and forth. SET_FIELD_WRAPPED was
added
recently i think and i didn't look into what it was doing.
Committed patchset #2 manually as r21618 (presubmit successful).
https://codereview.chromium.org/293363009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21618
Author: joc...@chromium.org
Date: Tue Jun 3 06:50:46 2014 UTC
Log: First cut at run_mksnapshot action for gn
BUG=none
R=bre...@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/293363009
http://code.google.com/p/v8/source/detail?r=21618
Added:
Reviewers: Raymond Toy,
https://codereview.chromium.org/303753002/diff/40001/src/math.js
File src/math.js (right):
https://codereview.chromium.org/303753002/diff/40001/src/math.js#newcode262
src/math.js:262: }
On 2014/06/02 17:26:11, Raymond Toy wrote:
As you mentioned via email, you've
LGTM, but the test case can be a *lot* simpler. Something like
Flags: --nouse-osr
function f() {
%OptimizeFunctionOnNextCall(f, osr);
for (var i = 0; i 1000; i++);
}
f();
https://codereview.chromium.org/310773003/diff/1/src/runtime.cc
File src/runtime.cc (right):
Thank you for checking it with cross builds. LGTM.
https://codereview.chromium.org/308023007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe
Reviewers: Yang,
Message:
Hi Yang, here is one more, thx!
--Michael
Description:
%ObjectFreeze needs to exclude non-fast-path objects.
ClusterFuzz will call it with sloppy arguments and similar cases.
BUG=380049
LOG=N
R=yang...@chromium.org
Please review this at
lgtm.
https://codereview.chromium.org/315533002/diff/1/test/mjsunit/regress/regress-380049.js
File test/mjsunit/regress/regress-380049.js (right):
https://codereview.chromium.org/315533002/diff/1/test/mjsunit/regress/regress-380049.js#newcode10
test/mjsunit/regress/regress-380049.js:10:
Reviewers: adamk,
Description:
Add collection-iterator.js to BUILD.gn after r21615
LOG=n
BUG=none
TBR=ad...@chromium.org
Please review this at https://codereview.chromium.org/314623002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -1 lines):
M BUILD.gn
Looks good. Adding Jakob to reviewers.
https://codereview.chromium.org/303263010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group
Revision: 21619
Author: joc...@chromium.org
Date: Tue Jun 3 07:26:07 2014 UTC
Log: Add collection-iterator.js to BUILD.gn after r21615
LOG=n
BUG=none
TBR=ad...@chromium.org
Review URL: https://codereview.chromium.org/314623002
http://code.google.com/p/v8/source/detail?r=21619
Committed patchset #1 manually as r21619 (presubmit successful).
https://codereview.chromium.org/314623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
I am not sure why !info()-IsStub() check is triggering, but the approach
with
EmitAtUses seems much better. As Danno mentioned we would need a predicate
for
each architecture that decides if it is worthwhile to store constants in
registers.
https://codereview.chromium.org/308313002/
--
--
Done.
https://codereview.chromium.org/309623007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #2 manually as r21620 (presubmit successful).
https://codereview.chromium.org/308023007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21620
Author: jacob.bram...@arm.com
Date: Tue Jun 3 07:37:16 2014 UTC
Log: ARM64: Fix ASM_LOCATION and the like.
BUG=
R=u...@chromium.org
Review URL: https://codereview.chromium.org/308023007
http://code.google.com/p/v8/source/detail?r=21620
Modified:
Committed patchset #2 manually as r21621 (presubmit successful).
https://codereview.chromium.org/298143004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21621
Author: ma...@chromium.org
Date: Tue Jun 3 07:40:43 2014 UTC
Log: Minor cleanups trivial refactoring related to Ast.
1) Literal::IsNull, IsTrue and IsFalse were dead code, and not needed.
2) No need to use the node type constants outside the Ast; there is
Thanks, I simplified the test and added the runtime assert. Much
appreciated!
--Michael
https://codereview.chromium.org/310773003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
Revision: 21622
Author: mvstan...@chromium.org
Date: Tue Jun 3 07:45:40 2014 UTC
Log: When flag --nouse-osr is set, don't allow osr from hidden runtime
calls.
BUG=379770
R=yang...@chromium.org
LOG=N
Review URL: https://codereview.chromium.org/310773003
Committed patchset #2 manually as r21622 (presubmit successful).
https://codereview.chromium.org/310773003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
https://codereview.chromium.org/297763006/diff/20001/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):
https://codereview.chromium.org/297763006/diff/20001/src/arm/macro-assembler-arm.cc#newcode517
src/arm/macro-assembler-arm.cc:517: // TODO(mstarzinger): Dynamic
Revision: 21623
Author: hpa...@chromium.org
Date: Tue Jun 3 07:55:38 2014 UTC
Log: Tenure allocation sites only when semi-space is maximum size.
BUG=
R=mvstan...@chromium.org
Review URL: https://codereview.chromium.org/309623007
http://code.google.com/p/v8/source/detail?r=21623
Committed patchset #4 manually as r21623 (presubmit successful).
https://codereview.chromium.org/309623007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
On 2014/06/02 17:24:56, tfarina wrote:
What was the technical reason for doing this?
Could you write it in the CL description?
Is this something skia could be doing in future?
dunno about skia... updated the description
https://codereview.chromium.org/304153016/
--
--
v8-dev mailing
Committed patchset #2 manually as r21624 (presubmit successful).
https://codereview.chromium.org/315533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Actually, the right thing to do is to treat constants as normal values and
teach
the register allocator how to split constant ranges and rematerialize on
demand
without spilling. This is something that Jaro and Benedikt have thought
about
recently, and I think this is generally a cleaner way
Reviewers: Yang,
Message:
PTAL
Description:
Fix PathTracer.
When tracing, we abuse the map for marking, thereby mutating it.
HeapObject::map() takes care of recovering unabused value.
Please review this at https://codereview.chromium.org/316533002/
SVN Base:
Updates:
Cc: c...@chromium.org js...@chromium.org
Comment #3 on issue 3345 by joc...@chromium.org: i18n: Make break iterator
use optional
http://code.google.com/p/v8/issues/detail?id=3345
cira@, can you comment on this?
--
You received this message because this project is configured
Updates:
Cc: c...@chromium.org js...@chromium.org
Comment #2 on issue 3348 by joc...@chromium.org: v8 Intl doesn't handle
failure conditions
http://code.google.com/p/v8/issues/detail?id=3348
I'm somewhat ambivalent about this one. I'd rather crash if the system
wasn't configured
Updates:
Cc: joc...@chromium.org
Comment #1 on issue 3344 by joc...@chromium.org: Add
v8::V8::InitializeICUDirectory(const char *path)
http://code.google.com/p/v8/issues/detail?id=3344
The InitializeICU call in V8 was added only for testing (otherwise, e.g.,
you'd want to mmap the
https://codereview.chromium.org/296953005/diff/40001/src/debug-debugger.js
File src/debug-debugger.js (right):
https://codereview.chromium.org/296953005/diff/40001/src/debug-debugger.js#newcode491
src/debug-debugger.js:491: return %DebugGetLoadedScripts();
This change looks wrong to me. By
Updates:
Cc: joc...@chromium.org
Comment #3 on issue 3348 by joc...@chromium.org: v8 Intl doesn't handle
failure conditions
http://code.google.com/p/v8/issues/detail?id=3348
(No comment was entered for this change.)
--
You received this message because this project is configured to
On 2014/06/02 14:33:06, m.m.capewell wrote:
the representation is unknown at the point that the
forced change is introduced.
That's exactly why putting this logic into the graph builder is the wrong
approach. Any operation that needs to check the representation of HValues
should
be
Updates:
Cc: joc...@chromium.org
Comment #4 on issue 3345 by joc...@chromium.org: i18n: Make break iterator
use optional
http://code.google.com/p/v8/issues/detail?id=3345
(No comment was entered for this change.)
--
You received this message because this project is configured to
+v8-users, v8-dev is mostly for codereviews and stuff...
On Tuesday, June 3, 2014 12:45:44 AM UTC+2, Steven R. Loomis (IBM) wrote:
Hello,
I would like to contribute some changes to support i18n use.
I work on ICU at IBM, and it's my understanding that there is a CCLA sent
in already.
https://codereview.chromium.org/296953005/diff/40001/src/debug-debugger.js
File src/debug-debugger.js (right):
https://codereview.chromium.org/296953005/diff/40001/src/debug-debugger.js#newcode491
src/debug-debugger.js:491: return %DebugGetLoadedScripts();
On 2014/06/03 08:07:21, yurys wrote:
On 2014/06/03 08:01:31, Igor Sheludko wrote:
PTAL
lgtm.
https://codereview.chromium.org/316533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r21625 (presubmit successful).
https://codereview.chromium.org/304153016/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
On 2014/06/03 08:01:16, danno wrote:
Actually, the right thing to do is to treat constants as normal values and
teach
the register allocator how to split constant ranges and rematerialize on
demand
without spilling. This is something that Jaro and Benedikt have thought
about
recently, and I
Revision: 21626
Author: ish...@chromium.org
Date: Tue Jun 3 08:28:38 2014 UTC
Log: Fix PathTracer.
When tracing, we abuse the map for marking, thereby mutating it.
HeapObject::map() takes care of recovering unabused value.
R=yang...@chromium.org
Review URL:
Committed patchset #1 manually as r21626 (presubmit successful).
https://codereview.chromium.org/316533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: mvstanton,
Description:
Fix compilation on win shared and mips
TBR=mvstan...@chromium.org
LOG=n
BUG=none
Please review this at https://codereview.chromium.org/309983002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+5, -2 lines):
M
Committed patchset #1 manually as r21627 (presubmit successful).
https://codereview.chromium.org/309983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21627
Author: joc...@chromium.org
Date: Tue Jun 3 08:29:03 2014 UTC
Log: Fix compilation on win shared and mips
TBR=mvstan...@chromium.org
LOG=n
BUG=none
Review URL: https://codereview.chromium.org/309983002
http://code.google.com/p/v8/source/detail?r=21627
Modified:
Reviewers: Benedikt Meurer,
Message:
PTAL
Description:
Remove duplicate code in SetPropertyPostInterceptor
BUG=
Please review this at https://codereview.chromium.org/314673002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -16 lines):
M src/objects.cc
lgtm
https://codereview.chromium.org/314673002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2 June 2014 20:55, Hendrik Greving hendrik.greving@gmail.com wrote:
Whenever V8 has to flush the ICache on ARM, this is due to self-modifying
code. I understand this e.g. happens when we patch return points to
optimized code with calls to de-optimization runtime functions. What I
Reviewers: Hannes Payer,
Message:
PTAL
Description:
Folding of bounded dynamic size allocations with const size allocations.
Please review this at https://codereview.chromium.org/301973014/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+86, -59 lines):
M
(Marking comments done here. I'll create a new CL as this is moving away
from
the WIP state...)
https://codereview.chromium.org/231073002/diff/880002/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/231073002/diff/880002/src/ast.h#newcode852
src/ast.h:852: ForStatement(Zone*
and closing this one; the new CL is
https://codereview.chromium.org/314603004
https://codereview.chromium.org/231073002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
LGTM
https://codereview.chromium.org/308353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
On 2014/06/02 15:21:16, Yang wrote:
Looking good. I got some comments. And I would like to add mstarzinger@
for a
second opinion.
https://chromiumcodereview.appspot.com/306463002/diff/60001/src/isolate.cc
File src/isolate.cc (right):
Reviewers: rossberg,
Message:
(rossberg, this is for you)
(ulan, mstarzinger, dcarney, jochen fyi)
Here's a new version of the delay internalizing strings. I'd like another
round of comments...
cctest, mjsunit, webkit, mozilla and test262 pass. I'm planning to add more
tests for function name
On 2014/06/03 08:12:46, Yang wrote:
https://codereview.chromium.org/296953005/diff/40001/src/debug-debugger.js
File src/debug-debugger.js (right):
https://codereview.chromium.org/296953005/diff/40001/src/debug-debugger.js#newcode491
src/debug-debugger.js:491: return %DebugGetLoadedScripts();
Reviewers: Benedikt Meurer,
Description:
Rename new_space_dominator to dominator since dominators can also be in old
space.
BUG=
Please review this at https://codereview.chromium.org/312713002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+11, -13 lines):
LGTM
https://codereview.chromium.org/312713002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Revision: 21628
Author: rossb...@chromium.org
Date: Tue Jun 3 09:34:29 2014 UTC
Log: Fix test
R=bmeu...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/306353002
http://code.google.com/p/v8/source/detail?r=21628
Modified:
Committed patchset #1 manually as r21628 (tree was closed).
https://codereview.chromium.org/306353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
So, could we simply skip the cache if the debugger is not entered? I would
then set a flag on the global object of the debug context after entering
the debugger, which guards caching. Leaving the debugger would clear the
cache and clear the flag.
Since blink never enters the debugger, the mirror
Reviewers: Hannes Payer,
Message:
PTAL. This code is probably never used in practice, since
--incremental-marking
is on by default.
Description:
Remove non-incremental idle notification handler.
Please review this at https://codereview.chromium.org/315553002/
SVN Base:
lgtm
https://codereview.chromium.org/308003018/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/297763006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #2 manually as r21629 (tree was closed).
https://codereview.chromium.org/312713002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21629
Author: hpa...@chromium.org
Date: Tue Jun 3 10:40:36 2014 UTC
Log: Rename new_space_dominator to dominator since dominators can also
be in old space.
BUG=
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/312713002
lgtm
https://codereview.chromium.org/309573002/diff/1/test/mjsunit/es7/object-observe.js
File test/mjsunit/es7/object-observe.js (right):
https://codereview.chromium.org/309573002/diff/1/test/mjsunit/es7/object-observe.js#newcode225
test/mjsunit/es7/object-observe.js:225: var rec2 =
LGTM, although I don't buy the premise that this is what Blink should use.
https://codereview.chromium.org/314553002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Committed patchset #5 manually as r21630 (tree was closed).
https://codereview.chromium.org/297763006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21630
Author: bmeu...@chromium.org
Date: Tue Jun 3 10:59:11 2014 UTC
Log: Improve write barriers in optimized code.
Use a cheaper RecordWriteForMap() to update the
write barrier for maps. And skip the value check
in RecordWriteField() when we statically know that
the value
Reviewers: mvstanton,
Description:
Update include paths for gcmole
TBR=mvstan...@chromium.org
LOG=n
BUG=none
Please review this at https://codereview.chromium.org/310733005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M
Committed patchset #1 manually as r21631 (tree was closed).
https://codereview.chromium.org/310733005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21631
Author: joc...@chromium.org
Date: Tue Jun 3 11:01:35 2014 UTC
Log: Update include paths for gcmole
TBR=mvstan...@chromium.org
LOG=n
BUG=none
Review URL: https://codereview.chromium.org/310733005
http://code.google.com/p/v8/source/detail?r=21631
Modified:
On 2014/06/03 08:27:25, Alexandre Rames wrote:
On 2014/06/03 08:01:16, danno wrote:
Actually, the right thing to do is to treat constants as normal values
and
teach
the register allocator how to split constant ranges and rematerialize on
demand
without spilling. This is something that Jaro
lgtm
https://codereview.chromium.org/315553002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On Tue, Jun 3, 2014 at 1:37 PM, Yang Guo yang...@chromium.org wrote:
So, could we simply skip the cache if the debugger is not entered? I would
then set a flag on the global object of the debug context after entering
the debugger, which guards caching. Leaving the debugger would clear the
Reviewers: Hannes Payer, Igor Sheludko,
Message:
Igor: Could you please check against your repro?
Hannes: PTAL.
Description:
Visit encountered JSWeakCollection list during scavenging.
R=hpa...@chromium.org
BUG=chromium:380068
LOG=N
Please review this at
The thing is, if the debugger is not active, entering the debugger loads a
new debug context every time. You would have to re-disable the mirror cache
every time. Is that what you want?
Yang
On Tue, Jun 3, 2014 at 1:22 PM, Yury Semikhatsky yu...@chromium.org wrote:
On Tue, Jun 3, 2014 at
Reviewers: danno,
Message:
Hi Danno,
I want to temporarily skip test-serialize tests for x87 port in debug mode.
The
root cause is the same as the snapshot issue of x87 port. We will enable it
after fixing this issue.
Thanks
-Weiliang
Description:
X87: Temporarily skip cctest/test-serialize
Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r21632 (tree was closed).
Description:
Revert Reland Make 'name' property on functions configurable.
This reverts commit r21609 due to browser test failures.
TBR=mstarzin...@chromium.org
Committed:
Revision: 21632
Author: mvstan...@chromium.org
Date: Tue Jun 3 11:52:07 2014 UTC
Log: Revert Reland Make 'name' property on functions configurable.
This reverts commit r21609 due to browser test failures.
TBR=mstarzin...@chromium.org
Review URL:
Hi Michael, here is the revert, thx for the help, will let you know.
https://codereview.chromium.org/313583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Good catch, lgtm.
https://codereview.chromium.org/307363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Reviewers: mvstanton,
Description:
Version 3.27.18.1 (merged r21632)
Revert Reland Make 'name' property on functions configurable.
R=mvstan...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/310773004/
SVN Base: https://v8.googlecode.com/svn/trunk
Affected files
lgtm
https://codereview.chromium.org/310773004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 manually as r21633 (tree was closed).
https://codereview.chromium.org/310773004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21634
Author: machenb...@chromium.org
Date: Tue Jun 3 11:58:05 2014 UTC
Log: Tagging version 3.27.18.1
http://code.google.com/p/v8/source/detail?r=21634
Added:
/tags/3.27.18.1
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Right on, lgtm too.
https://codereview.chromium.org/310733005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Revision: 21633
Author: machenb...@chromium.org
Date: Tue Jun 3 11:57:48 2014 UTC
Log: Version 3.27.18.1 (merged r21632)
Revert Reland Make 'name' property on functions configurable.
R=mvstan...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/310773004
Reviewers: mvstanton,
Message:
Committed patchset #2 manually as r21635 (tree was closed).
Description:
Deopt maybe tenure allocation sites when semi-space is maximum size.
BUG=
R=mvstan...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=21635
Please review this at
Revision: 21635
Author: hpa...@chromium.org
Date: Tue Jun 3 11:59:47 2014 UTC
Log: Deopt maybe tenure allocation sites when semi-space is maximum
size.
BUG=
R=mvstan...@chromium.org
Review URL: https://codereview.chromium.org/307363002
Committed patchset #1 manually as r21636 (presubmit successful).
https://codereview.chromium.org/308353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21636
Author: joc...@chromium.org
Date: Tue Jun 3 12:01:50 2014 UTC
Log: Add dependency on buildtools repo
Currently, this adds checkdeps, in the future, this will be the place
where clang-format and gn lives.
BUG=none
R=machenb...@chromium.org
LOG=n
Review URL:
lgtm
https://codereview.chromium.org/310783003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On Tue, Jun 3, 2014 at 3:30 PM, Yang Guo yang...@chromium.org wrote:
The thing is, if the debugger is not active, entering the debugger loads a
new debug context every time.
We assume that the same debug context is reused as long as we have debug
event listener set in v8 and this matches with
Looks good, to me!
okay, lgtm.
https://codereview.chromium.org/312723004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Reviewers: danno,
Message:
Hi Danno, here is the fix we discussed. Perhaps the overflow check
is overkill
in the HStoreKeyed case? PTAL,
--Michael
Description:
Clusterfuzz identified overflow check needed in dehoisting.
BUG=380092
R=da...@chromium.org
LOG=N
Please review this at
Thanks for the review Ulan, PTAL.
https://codereview.chromium.org/304143002/diff/20001/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/304143002/diff/20001/src/factory.cc#newcode134
src/factory.cc:134: HandleConstantPoolArray
Factory::NewExtendedConstantPoolArray(
On 2014/06/02 13:14:00, mvstanton wrote:
Just as a DBC: this is great. I'm thinking to be able to use these handy
ConstantPoolArrays as elements in the feedback vector when feedback for a
particular node (say a LoadIC) would like to store code addresses as well
as
object pointers. You've
Reviewers: Jakob,
Description:
Add DEPS files and run checkdeps in presubmit check
BUG=none
R=jkumme...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/312763002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+96, -0 lines):
M DEPS
On 2014/05/29 15:54:12, rmcilroy wrote:
Given that ConstantPoolArrays can contain raw int32 or int64 values, I
think
this change is necessary to ensure we don't confuse a raw int value as a
tagged
pointer when migrating a ConstantPoolArray. PTAL.
Ping? Could you take a look please
1 - 100 of 201 matches
Mail list logo
