On 2014/06/02 15:21:16, Yang wrote:
Looking good. I got some comments. And I would like to add mstarzinger@
for a
second opinion.
https://chromiumcodereview.appspot.com/306463002/diff/60001/src/isolate.cc
File src/isolate.cc (right):
https://chromiumcodereview.appspot.com/306463002/diff/60001/src/isolate.cc#newcode1154
src/isolate.cc:1154: return false;
Can we simply return an expression?
Yes, we can. Done.
https://chromiumcodereview.appspot.com/306463002/diff/60001/src/isolate.cc#newcode1192
src/isolate.cc:1192: bool canClearMessage =
PropagatePendingExceptionToExternalTryCatch();
please name this 'can_clear_message' instead.
Done.
https://chromiumcodereview.appspot.com/306463002/diff/60001/src/isolate.cc#newcode1220
src/isolate.cc:1220: clear_pending_message();
no line break here.
Done.
On 2014/06/02 15:31:27, vsevik wrote:
https://chromiumcodereview.appspot.com/306463002/diff/60001/src/isolate.cc
File src/isolate.cc (left):
https://chromiumcodereview.appspot.com/306463002/diff/60001/src/isolate.cc#oldcode1157
src/isolate.cc:1157: if
(!is_catchable_by_javascript(pending_exception())) {
Looking at this once again I think this check is still needed.
Unfortunately you will probably need to extract another function. :(
I've reused function is Isolate::is_catchable_by_javascript. Done.
https://codereview.chromium.org/306463002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
