[v8-dev] Re: Issue 3002 in v8: Allow tick-processor.html to accept log names as querystring

2015-02-06 Thread codesite-noreply via v8-dev
Comment #3 on issue 3002 by habl...@chromium.org: Allow tick-processor.html to accept log names as querystring https://code.google.com/p/v8/issues/detail?id=3002 According to Jaroslav the tick processor was not removed. -- You received this message because this project is configured to send

[v8-dev] Re: Issue 3075 in v8: Public Version Macros

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: Accepted Labels: Priority-Low HelpWanted Comment #5 on issue 3075 by habl...@chromium.org: Public Version Macros https://code.google.com/p/v8/issues/detail?id=3075 Update was done during clean-up of issue tracker. -- You received this message because this

[v8-dev] Re: [ia32] Assembler support for internal references. (issue 900223006 by bmeu...@chromium.org)

2015-02-06 Thread dcarney
lgtm https://codereview.chromium.org/900223006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] [ia32] Assembler support for internal references. (issue 900223006 by bmeu...@chromium.org)

2015-02-06 Thread bmeurer
Reviewers: dcarney, Description: [ia32] Assembler support for internal references. BUG=v8:3872 LOG=n R=dcar...@chromium.org Please review this at https://codereview.chromium.org/900223006/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+153, -17 lines): M

[v8-dev] Re: Issue 2159 in v8: Add support for rest parameters

2015-02-06 Thread codesite-noreply via v8-dev
Comment #12 on issue 2159 by RetroModular: Add support for rest parameters https://code.google.com/p/v8/issues/detail?id=2159 According to the Chromium Dashboard there is still no active development on this ES6 feature. Could someone please keep the dashboard up-to-date because some of us

[v8-dev] Re: Issue 2189 in v8: Heap Snapshot: ObjectIds don't seem to be absolutely stable

2015-02-06 Thread codesite-noreply via v8-dev
Comment #4 on issue 2189 by habl...@chromium.org: Heap Snapshot: ObjectIds don't seem to be absolutely stable https://code.google.com/p/v8/issues/detail?id=2189 Update done during clean-up of issue tracker. -- You received this message because this project is configured to send all issue

[v8-dev] Remove unused path in FieldIndex code (issue 898283003 by da...@chromium.org)

2015-02-06 Thread danno
Reviewers: Sven Panne, Message: PTAL Description: Remove unused path in FieldIndex code Please review this at https://codereview.chromium.org/898283003/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+4, -3 lines): M src/field-index-inl.h Index:

[v8-dev] Re: X87: Double field values need sNaN - qNaN canonicalization. (issue 879693006 by chunyang....@intel.com)

2015-02-06 Thread commit-bot
Patchset 1 (id:??) landed as https://crrev.com/a3ac322a2ae0351bfad02fd188d3fe3cc0805b4d Cr-Commit-Position: refs/heads/master@{#26477} https://codereview.chromium.org/879693006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Issue 2160 in v8: Add support for default parameters

2015-02-06 Thread codesite-noreply via v8-dev
Comment #3 on issue 2160 by RetroModular: Add support for default parameters https://code.google.com/p/v8/issues/detail?id=2160 I believe it's time for this ES6 feature to be bumped up to Priority-High. The Chromium Dashboard is still flagging this feature as No active development which is

[v8-dev] Re: X87: Double field values need sNaN - qNaN canonicalization. (issue 879693006 by chunyang....@intel.com)

2015-02-06 Thread chunyang . dai
Committed patchset #1 (id:1) manually as a3ac322a2ae0351bfad02fd188d3fe3cc0805b4d (presubmit successful). https://codereview.chromium.org/879693006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: Issue 2189 in v8: Heap Snapshot: ObjectIds don't seem to be absolutely stable

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: Accepted Labels: Priority-Low Comment #3 on issue 2189 by habl...@chromium.org: Heap Snapshot: ObjectIds don't seem to be absolutely stable https://code.google.com/p/v8/issues/detail?id=2189 (No comment was entered for this change.) -- You received this

[v8-dev] Re: Issue 3002 in v8: Allow tick-processor.html to accept log names as querystring

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Labels: Type-FeatureRequest Comment #2 on issue 3002 by habl...@chromium.org: Allow tick-processor.html to accept log names as querystring https://code.google.com/p/v8/issues/detail?id=3002 (No comment was entered for this change.) -- You received this message because this

[v8-dev] Re: Issue 3651 in v8: Automated tests do not cover --cache=parse

2015-02-06 Thread codesite-noreply via v8-dev
Comment #4 on issue 3651 by culli...@amazon.com: Automated tests do not cover --cache=parse https://code.google.com/p/v8/issues/detail?id=3651 As far as I'm aware there is still somewhat of a gap in test coverage for the parser cache. The code serializer bot runs the test suite with

[v8-dev] Re: Issue 1984 in v8: ObjectLiteral getter or setter name is not restricted by strict mode restriction

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: Fixed Comment #7 on issue 1984 by a...@chromium.org: ObjectLiteral getter or setter name is not restricted by strict mode restriction https://code.google.com/p/v8/issues/detail?id=1984 Sorry it had to take three years to get this fixed. -- You received this message

[v8-dev] Enable compiling mjsunit tests as ES6 modules (issue 902263002 by ad...@chromium.org)

2015-02-06 Thread adamk
Reviewers: rossberg, Message: Not sure who the best reviewers are for the d8 and testcfg changes. CCed machenbach and yangguo, as they've both touched nearby code relatively recently. Description: Enable compiling mjsunit tests as ES6 modules Adding the line // MODULE to an mjsunit file

[v8-dev] Re: Contribution of PowerPC port (continuation of 422063005) - AIX Common1 (issue 866843003 by michael_daw...@ca.ibm.com)

2015-02-06 Thread michael_dawson
https://codereview.chromium.org/866843003/diff/40001/src/serialize.cc File src/serialize.cc (right): https://codereview.chromium.org/866843003/diff/40001/src/serialize.cc#newcode912 src/serialize.cc:912: if (rmode == RelocInfo::INTERNAL_REFERENCE) { On 2015/02/06 07:08:14, Yang wrote: I'm

[v8-dev] Re: Rename ParseSourceElements in preparser too (issue 905003003 by a...@chromium.org)

2015-02-06 Thread commit-bot
Patchset 2 (id:??) landed as https://crrev.com/8a809a9c8619c26230148b5dccab3039fe9c9b89 Cr-Commit-Position: refs/heads/master@{#26498} https://codereview.chromium.org/905003003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Rename ParseSourceElements in preparser too (issue 905003003 by a...@chromium.org)

2015-02-06 Thread commit-bot
Committed patchset #2 (id:20001) https://codereview.chromium.org/905003003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Rename ParseSourceElements in preparser too (issue 905003003 by a...@chromium.org)

2015-02-06 Thread arv
Reviewers: adamk, Message: PTAL Description: Rename ParseSourceElements in preparser too BUG=None R=adamk LOG=N Please review this at https://codereview.chromium.org/905003003/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+12, -12 lines): M src/parser.cc

[v8-dev] Re: Rename ParseSourceElements in preparser too (issue 905003003 by a...@chromium.org)

2015-02-06 Thread adamk
lgtm with some more cleanup mentioned if you feel like it. https://codereview.chromium.org/905003003/diff/1/src/preparser.h File src/preparser.h (right): https://codereview.chromium.org/905003003/diff/1/src/preparser.h#newcode1622 src/preparser.h:1622: SourceElements ParseStatementList(int

[v8-dev] Re: Contribution of PowerPC port (continuation of 422063005) - PPC opt 1 (issue 882263003 by michael_daw...@ca.ibm.com)

2015-02-06 Thread mbrandy
On 2015/02/06 07:28:00, Sven Panne wrote: https://codereview.chromium.org/882263003/diff/1/src/globals.h File src/globals.h (right): https://codereview.chromium.org/882263003/diff/1/src/globals.h#newcode77 src/globals.h:77: #define V8_OOL_CONSTANT_POOL 1 FYI (after some internal discussions):

[v8-dev] Re: Rename ParseSourceElements in preparser too (issue 905003003 by a...@chromium.org)

2015-02-06 Thread arv
PTAL cq+ if it looks good to you. https://codereview.chromium.org/905003003/diff/1/src/preparser.h File src/preparser.h (right): https://codereview.chromium.org/905003003/diff/1/src/preparser.h#newcode1622 src/preparser.h:1622: SourceElements ParseStatementList(int end_token, bool* ok); On

[v8-dev] Re: Rename ParseSourceElements in preparser too (issue 905003003 by a...@chromium.org)

2015-02-06 Thread adamk
thanks, still lgtm https://codereview.chromium.org/905003003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving

[v8-dev] Re: Rename ParseSourceElements in preparser too (issue 905003003 by a...@chromium.org)

2015-02-06 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905003003/20001 https://codereview.chromium.org/905003003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: X87: Use a trampoline stub to load the type feedback vector for CallICs (issue 905983002 by chunyang....@intel.com)

2015-02-06 Thread commit-bot
Patchset 1 (id:??) landed as https://crrev.com/27361ec6c89898f491edb9162e8a77001147562f Cr-Commit-Position: refs/heads/master@{#26502} https://codereview.chromium.org/905983002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: X87: Use a trampoline stub to load the type feedback vector for CallICs (issue 905983002 by chunyang....@intel.com)

2015-02-06 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/905983002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Update V8 DEPS. (issue 903233003 by v8-autor...@chromium.org)

2015-02-06 Thread v8-autoroll
Reviewers: Michael Achenbach (OOO), Description: Update V8 DEPS. Rolling v8/tools/clang to 5489bbf01a5292a6c44d4cad7875ba2cb4ac975b TBR=machenb...@chromium.org Please review this at https://codereview.chromium.org/903233003/ Base URL: https://chromium.googlesource.com/v8/v8@master Affected

[v8-dev] Re: Update V8 DEPS. (issue 903233003 by v8-autor...@chromium.org)

2015-02-06 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903233003/1 https://codereview.chromium.org/903233003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] X87: Remove the dependency of Zone on Isolate (issue 903183003 by chunyang....@intel.com)

2015-02-06 Thread chunyang . dai
Reviewers: Weiliang, danno, Message: PTAL. thanks Description: X87: Remove the dependency of Zone on Isolate port c7b09aac317dd810d29b82061973199b80363b65 (r26252) original commit message: Along the way: - Thread isolate parameter explicitly through code that used to rely on

[v8-dev] Re: X87: new classes: change semantics of super(...) call and add new.target to construct stub. (issue 900423002 by chunyang....@intel.com)

2015-02-06 Thread chunyang . dai
Committed patchset #1 (id:20001) manually as bd4476a6232c366cd9f7965009e3a520084abb8d (presubmit successful). https://codereview.chromium.org/900423002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: X87: new classes: change semantics of super(...) call and add new.target to construct stub. (issue 900423002 by chunyang....@intel.com)

2015-02-06 Thread commit-bot
Patchset 1 (id:??) landed as https://crrev.com/bd4476a6232c366cd9f7965009e3a520084abb8d Cr-Commit-Position: refs/heads/master@{#26500} https://codereview.chromium.org/900423002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Update V8 DEPS. (issue 903233003 by v8-autor...@chromium.org)

2015-02-06 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/903233003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Add release build checks to back reference deserialization. (issue 909493002 by yang...@chromium.org)

2015-02-06 Thread yangguo
On 2015/02/06 15:13:00, Yang wrote: I added even more checks and found a bug in the way we encode back references to large objects. It could explain the observed bug. Back references to large objects is encoded as index, but wrongly shifted by 3 bits (or 2 on 32-bit platforms). Back reference

[v8-dev] Re: X87: Remove the dependency of Zone on Isolate (issue 903183003 by chunyang....@intel.com)

2015-02-06 Thread chunyang . dai
Committed patchset #2 (id:20001) manually as 3c56b026743808157129a32c6eb4a7d7d5d3ecbc (presubmit successful). https://codereview.chromium.org/903183003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: X87: Remove the dependency of Zone on Isolate (issue 903183003 by chunyang....@intel.com)

2015-02-06 Thread commit-bot
Patchset 2 (id:??) landed as https://crrev.com/3c56b026743808157129a32c6eb4a7d7d5d3ecbc Cr-Commit-Position: refs/heads/master@{#26501} https://codereview.chromium.org/903183003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] X87: new classes: change semantics of super(...) call and add new.target to construct stub. (issue 900423002 by chunyang....@intel.com)

2015-02-06 Thread chunyang . dai
Reviewers: Weiliang, Dmitry Lomov (chromium), Message: WL. PTAL. thanks Description: X87: new classes: change semantics of super(...) call and add new.target to construct stub. port 22ce08ade63a9c4f28225db11a5b5d2726c5a8e7 (r26227) original commit message: new classes: change semantics of

[v8-dev] Re: Update V8 DEPS. (issue 903233003 by v8-autor...@chromium.org)

2015-02-06 Thread commit-bot
Patchset 1 (id:??) landed as https://crrev.com/b9e15ea3aa1d090ffa3e009581c7abc18560f180 Cr-Commit-Position: refs/heads/master@{#26499} https://codereview.chromium.org/903233003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: X87: Remove the dependency of Zone on Isolate (issue 903183003 by chunyang....@intel.com)

2015-02-06 Thread weiliang . lin
lgtm https://codereview.chromium.org/903183003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Remove the dependency of Zone on Isolate (issue 903183003 by chunyang....@intel.com)

2015-02-06 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903183003/20001 https://codereview.chromium.org/903183003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: X87: new classes: change semantics of super(...) call and add new.target to construct stub. (issue 900423002 by chunyang....@intel.com)

2015-02-06 Thread weiliang . lin
lgtm https://codereview.chromium.org/900423002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] X87: Use a trampoline stub to load the type feedback vector for CallICs (issue 905983002 by chunyang....@intel.com)

2015-02-06 Thread chunyang . dai
Reviewers: Weiliang, mvstanton, Message: WL. PTAL thanks Description: X87: Use a trampoline stub to load the type feedback vector for CallICs port 2a567faa3e7242359e29c63f8dc8c18104af0610 (r26290) original commit message: Use a trampoline stub to load the type feedback vector for CallICs.

[v8-dev] Re: X87: Use a trampoline stub to load the type feedback vector for CallICs (issue 905983002 by chunyang....@intel.com)

2015-02-06 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905983002/1 https://codereview.chromium.org/905983002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: X87: Use a trampoline stub to load the type feedback vector for CallICs (issue 905983002 by chunyang....@intel.com)

2015-02-06 Thread weiliang . lin
lgtm https://codereview.chromium.org/905983002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Issue 3345 in v8: i18n: Make break iterator use optional

2015-02-06 Thread codesite-noreply via v8-dev
Comment #12 on issue 3345 by js...@chromium.org: i18n: Make break iterator use optional https://code.google.com/p/v8/issues/detail?id=3345 Thank you for the reminder. I've just uploaded a CL at https://codereview.chromium.org/902313002/. The patch has to be a bit changed because

[v8-dev] Enclose break_iterator code with !UCONFIG_NO_BREAK_ITERATOR (issue 902313002 by js...@chromium.org)

2015-02-06 Thread jshin
Reviewers: hablich, Nebojša Ćirić, Message: PTAL. Thanks Description: Enclose break_iterator code with !UCONFIG_NO_BREAK_ITERATOR BreakIterator is not a part of the ECMA spec, yet. Some 'embedders' want to save space by not including the dictionary/code for break iterator in ICU. Include v8's

[v8-dev] Re: Issue 1890 in v8: Issues with loops and Smi arithmetic

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: Fixed Labels: Type-Bug Comment #1 on issue 1890 by habl...@chromium.org: Issues with loops and Smi arithmetic https://code.google.com/p/v8/issues/detail?id=1890 Update done during clean-up of issue tracker. A lot of stuff has happened in three years.

[v8-dev] Re: new classes: assert that constructors are not callable and rewrite 'return;' (issue 885643004 by dslo...@chromium.org)

2015-02-06 Thread commit-bot
Committed patchset #4 (id:60001) https://codereview.chromium.org/885643004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: Issue 983 in v8: Reliability stress test: Crash GC on http://dichvu.conduongtolua.com.vn/DownLevel.aspx

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: Fixed Comment #3 on issue 983 by habl...@chromium.org: Reliability stress test: Crash GC on http://dichvu.conduongtolua.com.vn/DownLevel.aspx https://code.google.com/p/v8/issues/detail?id=983 Update was done during clean-up of issue tracker. No reproducible anymore

[v8-dev] split interceptor tests off of test-api (issue 900033003 by dcar...@chromium.org)

2015-02-06 Thread verwaest
lgtm https://codereview.chromium.org/900033003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Remove unused path in FieldIndex code (issue 898283003 by da...@chromium.org)

2015-02-06 Thread svenpanne
LGTM. That's even better than the previous version, because it's blindingly obvious now that the map is for sanity checking only. https://codereview.chromium.org/898283003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message

[v8-dev] Re: Issue 3207 in v8: native context separation Fatal Error

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: Accepted Labels: Type-Bug Priority-Medium Comment #2 on issue 3207 by habl...@chromium.org: native context separation Fatal Error https://code.google.com/p/v8/issues/detail?id=3207 Update done during clean-up of issue tracker. Might point to some sort of

[v8-dev] Re: Issue 3624 in v8: Associate resource names and line numbers with code supplied via new Function

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: Accepted Labels: Type-FeatureRequest Priority-Low Comment #2 on issue 3624 by habl...@chromium.org: Associate resource names and line numbers with code supplied via new Function https://code.google.com/p/v8/issues/detail?id=3624 This update was done during

[v8-dev] Re: Issue 3485 in v8: EcmaScript internal method invariants violated in some cases

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Owner: verwa...@chromium.org Cc: rossb...@chromium.org Labels: ES5 Comment #6 on issue 3485 by rossb...@chromium.org: EcmaScript internal method invariants violated in some cases https://code.google.com/p/v8/issues/detail?id=3485 I agree that it might make

[v8-dev] Re: Issue 1507 in v8: Generate short-circuit control flow for and ||

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: Invalid Labels: Type-FeatureRequest Comment #2 on issue 1507 by habl...@chromium.org: Generate short-circuit control flow for and || https://code.google.com/p/v8/issues/detail?id=1507 Update done during clean-up of issue tracker. Closed because of issue

[v8-dev] Re: split interceptor tests off of test-api (issue 900033003 by dcar...@chromium.org)

2015-02-06 Thread commit-bot
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/2645) https://codereview.chromium.org/900033003/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Issue 2189 in v8: Heap Snapshot: ObjectIds don't seem to be absolutely stable

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: Fixed Comment #5 on issue 2189 by loi...@chromium.org: Heap Snapshot: ObjectIds don't seem to be absolutely stable https://code.google.com/p/v8/issues/detail?id=2189 (No comment was entered for this change.) -- You received this message because this project is

[v8-dev] Re: cleanup api-natives a bit (issue 901923002 by dcar...@chromium.org)

2015-02-06 Thread commit-bot
Committed patchset #2 (id:20001) https://codereview.chromium.org/901923002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: cleanup api-natives a bit (issue 901923002 by dcar...@chromium.org)

2015-02-06 Thread commit-bot
Patchset 2 (id:??) landed as https://crrev.com/e64810b5a5672f0b3a140d54986d2e02d86bb2a8 Cr-Commit-Position: refs/heads/master@{#26481} https://codereview.chromium.org/901923002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Issue 2200 in v8: Support multiple configurations with Ninja through top-level Makefile/build.ninja file

2015-02-06 Thread codesite-noreply via v8-dev
Comment #7 on issue 2200 by joc...@chromium.org: Support multiple configurations with Ninja through top-level Makefile/build.ninja file https://code.google.com/p/v8/issues/detail?id=2200 you have to set the resp. GYP_DEFINES, e.g. v8_target_arch=ia32 -- You received this message because

[v8-dev] Re: Issue 1634 in v8: Layout Test fast/js/const.html is failing

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: Invalid Comment #2 on issue 1634 by habl...@chromium.org: Layout Test fast/js/const.html is failing https://code.google.com/p/v8/issues/detail?id=1634 Update was done during clean-up of issue tracker. Bug not applicable anymore -- You received this message because

[v8-dev] Re: Issue 3124 in v8: webkit/function-apply-aliased.js test fails on simulators.

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: Accepted Labels: Priority-Low Type-Bug Comment #2 on issue 3124 by habl...@chromium.org: webkit/function-apply-aliased.js test fails on simulators. https://code.google.com/p/v8/issues/detail?id=3124 Update done during clean-up of issue tracker. -- You

[v8-dev] Re: Remove unused path in FieldIndex code (issue 898283003 by da...@chromium.org)

2015-02-06 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898283003/1 https://codereview.chromium.org/898283003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: cleanup api-natives a bit (issue 901923002 by dcar...@chromium.org)

2015-02-06 Thread verwaest
lgtm https://codereview.chromium.org/901923002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Allocate typed array for rempio2 result. (issue 866553003 by yang...@chromium.org)

2015-02-06 Thread commit-bot
Patchset 4 (id:??) landed as https://crrev.com/a44511d4131c74c6a0f9622af9ccaab83a5235bc Cr-Commit-Position: refs/heads/master@{#26482} https://codereview.chromium.org/866553003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Allocate typed array for rempio2 result. (issue 866553003 by yang...@chromium.org)

2015-02-06 Thread commit-bot
Committed patchset #4 (id:60001) https://codereview.chromium.org/866553003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: Issue 3485 in v8: EcmaScript internal method invariants violated in some cases

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: Accepted Labels: Type-Bug Priority-Low Comment #5 on issue 3485 by habl...@chromium.org: EcmaScript internal method invariants violated in some cases https://code.google.com/p/v8/issues/detail?id=3485 Update done during clean-up of issue tracker. -- You

[v8-dev] Re: Issue 3299 in v8: Implement dynamic GDB JIT interface

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: PendingFurtherInfo Owner: --- Comment #1 on issue 3299 by habl...@chromium.org: Implement dynamic GDB JIT interface https://code.google.com/p/v8/issues/detail?id=3299 Can you elaborate please why this is a bug? For me it sounds like a FR. What do you

[v8-dev] Re: Issue 3345 in v8: i18n: Make break iterator use optional

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: PendingFurtherInfo Comment #11 on issue 3345 by habl...@chromium.org: i18n: Make break iterator use optional https://code.google.com/p/v8/issues/detail?id=3345 I have not found your CL. Have you submitted the code? -- You received this message because this project

[v8-dev] Const-corrected some MachineSignature* parameters. (issue 874693006 by svenpa...@chromium.org)

2015-02-06 Thread svenpanne
Reviewers: dcarney, Description: Const-corrected some MachineSignature* parameters. Recipe: Add const to RawMachineAssembler constructor, fix breakage. Please review this at https://codereview.chromium.org/874693006/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files

[v8-dev] [turbofan] Remove global InstructionOperand caches. (issue 904693002 by dcar...@chromium.org)

2015-02-06 Thread bmeurer
Love it...LGTM https://codereview.chromium.org/904693002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving

[v8-dev] Re: [turbofan] Remove global InstructionOperand caches. (issue 904693002 by dcar...@chromium.org)

2015-02-06 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904693002/80001 https://codereview.chromium.org/904693002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: [ia32] Assembler support for internal references. (issue 900223006 by bmeu...@chromium.org)

2015-02-06 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900223006/1 https://codereview.chromium.org/900223006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: [ia32] Assembler support for internal references. (issue 900223006 by bmeu...@chromium.org)

2015-02-06 Thread commit-bot
Patchset 1 (id:??) landed as https://crrev.com/5c119485b485a5c71155501613ae3c12be2863a8 Cr-Commit-Position: refs/heads/master@{#26478} https://codereview.chromium.org/900223006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: [ia32] Assembler support for internal references. (issue 900223006 by bmeu...@chromium.org)

2015-02-06 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/900223006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Issue 3179 in v8: Closures are not inlined. They should be.

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: Accepted Labels: Type-FeatureRequest Comment #3 on issue 3179 by habl...@chromium.org: Closures are not inlined. They should be. https://code.google.com/p/v8/issues/detail?id=3179 (No comment was entered for this change.) -- You received this message because

[v8-dev] Re: new classes: assert that constructors are not callable and rewrite 'return;' (issue 885643004 by dslo...@chromium.org)

2015-02-06 Thread dslomov
Rebased + turbo deopt fix. Landing, but PTAL https://codereview.chromium.org/885643004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this

[v8-dev] Re: new classes: assert that constructors are not callable and rewrite 'return;' (issue 885643004 by dslo...@chromium.org)

2015-02-06 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885643004/40001 https://codereview.chromium.org/885643004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Remove unused path in FieldIndex code (issue 898283003 by da...@chromium.org)

2015-02-06 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/898283003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Remove unused path in FieldIndex code (issue 898283003 by da...@chromium.org)

2015-02-06 Thread commit-bot
Patchset 1 (id:??) landed as https://crrev.com/6efd03c434e0a6aa4f8e16ea3ca2bca1c2764d72 Cr-Commit-Position: refs/heads/master@{#26480} https://codereview.chromium.org/898283003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Issue 2739 in v8: v8 should do reduntant bounds check elimination for constant indexing

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: Fixed Labels: Type-FeatureRequest Comment #3 on issue 2739 by habl...@chromium.org: v8 should do reduntant bounds check elimination for constant indexing https://code.google.com/p/v8/issues/detail?id=2739 Update done during clean-up of issue tracker. -- You

[v8-dev] Re: Issue 3191 in v8: performance regression for dart2js compiled havlak benchmark

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: WorkingAsIntended Comment #4 on issue 3191 by mvstan...@chromium.org: performance regression for dart2js compiled havlak benchmark https://code.google.com/p/v8/issues/detail?id=3191 This was pretenuring, and is just part of the codebase now. -- You received this

[v8-dev] Re: cleanup api-natives a bit (issue 901923002 by dcar...@chromium.org)

2015-02-06 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901923002/20001 https://codereview.chromium.org/901923002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: new classes: assert that constructors are not callable and rewrite 'return;' (issue 885643004 by dslo...@chromium.org)

2015-02-06 Thread commit-bot
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2728) https://codereview.chromium.org/885643004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: split interceptor tests off of test-api (issue 900033003 by dcar...@chromium.org)

2015-02-06 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900033003/20001 https://codereview.chromium.org/900033003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Issue 2200 in v8: Support multiple configurations with Ninja through top-level Makefile/build.ninja file

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Cc: ma...@chromium.org Comment #6 on issue 2200 by ma...@chromium.org: Support multiple configurations with Ninja through top-level Makefile/build.ninja file https://code.google.com/p/v8/issues/detail?id=2200 (No comment was entered for this change.) -- You received this

[v8-dev] Re: Issue 3869 in v8: Turbo deoptimization fails mysteriously.

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: WorkingAsIntended Comment #1 on issue 3869 by dslo...@chromium.org: Turbo deoptimization fails mysteriously. https://code.google.com/p/v8/issues/detail?id=3869 Need to add function to src/compiler/linkage.cc -- You received this message because this project is

[v8-dev] Re: Issue 3651 in v8: Automated tests do not cover --cache=parse

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: PendingFurtherInfo Labels: Type-FeatureRequest Comment #3 on issue 3651 by habl...@chromium.org: Automated tests do not cover --cache=parse https://code.google.com/p/v8/issues/detail?id=3651 Update was done during clean-up of issue tracker. Is still FR still

[v8-dev] Re: Issue 3870 in v8: RegExp.multiline (global) accessor should probably be deleted (or properly implemented)

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Cc: a...@chromium.org erikco...@chromium.org Labels: -Area-Irregexp Comment #1 on issue 3870 by a...@chromium.org: RegExp.multiline (global) accessor should probably be deleted (or properly implemented) https://code.google.com/p/v8/issues/detail?id=3870 I vote for

[v8-dev] Re: Simplify cpu-profiler test code with help of wrappers. (issue 892953004 by loi...@chromium.org)

2015-02-06 Thread mstarzinger
LGTM with comments. https://codereview.chromium.org/892953004/diff/60001/test/cctest/test-cpu-profiler.cc File test/cctest/test-cpu-profiler.cc (right): https://codereview.chromium.org/892953004/diff/60001/test/cctest/test-cpu-profiler.cc#newcode53 test/cctest/test-cpu-profiler.cc:53: static

[v8-dev] Re: Just visit young array buffers during scavenge. (issue 904633003 by hpa...@chromium.org)

2015-02-06 Thread ulan
We could do this in one pass with a specialized Visitor. +1, that seems much better. https://codereview.chromium.org/904633003/diff/80001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/904633003/diff/80001/src/heap/heap.cc#newcode1754 src/heap/heap.cc:1754: }

[v8-dev] Re: Issue 2159 in v8: Add support for rest parameters

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Owner: caitpott...@gmail.com Cc: a...@chromium.org rossb...@chromium.org dslo...@chromium.org Comment #13 on issue 2159 by a...@chromium.org: Add support for rest parameters https://code.google.com/p/v8/issues/detail?id=2159 I updated the dashboard -- You received

[v8-dev] Re: Issue 3654 in v8: Wrong relative path to v8-platform.h in include/libplatform/libplatform.h

2015-02-06 Thread codesite-noreply via v8-dev
Comment #9 on issue 3654 by riccardo.co...@kairos3d.it: Wrong relative path to v8-platform.h in include/libplatform/libplatform.h https://code.google.com/p/v8/issues/detail?id=3654 I agree, same issue when integrating V8 in my project. If you don't want to use the relative path #include

[v8-dev] [turbofan] OSR loops assign all local variables. (issue 886733005 by tit...@chromium.org)

2015-02-06 Thread titzer
Reviewers: Michael Starzinger, Description: [turbofan] OSR loops assign all local variables. R=mstarzin...@chromium.org BUG= Please review this at https://codereview.chromium.org/886733005/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+4, -0 lines): M

[v8-dev] Re: Add hash fields to code cache header. (issue 909473002 by yang...@chromium.org)

2015-02-06 Thread jochen
lgtm https://codereview.chromium.org/909473002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Add hash fields to code cache header. (issue 909473002 by yang...@chromium.org)

2015-02-06 Thread yangguo
Reviewers: jochen (slow), Description: Add hash fields to code cache header. R=joc...@chromium.org BUG=chromium:441896 LOG=N Please review this at https://codereview.chromium.org/909473002/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+85, -24 lines): M

[v8-dev] Re: [turbofan] Remove global InstructionOperand caches. (issue 904693002 by dcar...@chromium.org)

2015-02-06 Thread commit-bot
Patchset 5 (id:??) landed as https://crrev.com/996fa7d36e4b033794a306f89aae58557e70bc8b Cr-Commit-Position: refs/heads/master@{#26479} https://codereview.chromium.org/904693002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: [turbofan] Remove global InstructionOperand caches. (issue 904693002 by dcar...@chromium.org)

2015-02-06 Thread commit-bot
Committed patchset #5 (id:80001) https://codereview.chromium.org/904693002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: Issue 3179 in v8: Closures are not inlined. They should be.

2015-02-06 Thread codesite-noreply via v8-dev
Comment #4 on issue 3179 by habl...@chromium.org: Closures are not inlined. They should be. https://code.google.com/p/v8/issues/detail?id=3179 Update done during clean-up of issue tracker. -- You received this message because this project is configured to send all issue notifications to

[v8-dev] Re: Allocate typed array for rempio2 result. (issue 866553003 by yang...@chromium.org)

2015-02-06 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866553003/60001 https://codereview.chromium.org/866553003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Issue 3278 in v8: Implement watchers for debugging

2015-02-06 Thread codesite-noreply via v8-dev
Updates: Status: Accepted Comment #6 on issue 3278 by habl...@chromium.org: Implement watchers for debugging https://code.google.com/p/v8/issues/detail?id=3278 Update done during clean-up of issue tracker. -- You received this message because this project is configured to send all

  1   2   >