https://codereview.chromium.org/1274193004/diff/40001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1274193004/diff/40001/src/parser.cc#newcode2019
src/parser.cc:2019: declaration_scope-is_strict_eval_scope() ||
On 2015/08/11 at 01:17:43, adamk wrote:
I think it
lgtm
https://codereview.chromium.org/1274193004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2015/08/11 at 21:22:13, adamk wrote:
lgtm if this passes tests, I thought we might run more tests with
--harmony on
but that seems to be only test262 (are there no test262 tests for
A.p.includes?)
Not yet; I'll poke Brian about what his policies are for test262 and stages
and
such.
On 2015/08/11 21:25:19, domenic wrote:
On 2015/08/11 at 21:22:13, adamk wrote:
lgtm if this passes tests, I thought we might run more tests with
--harmony
on
but that seems to be only test262 (are there no test262 tests for
A.p.includes?)
Not yet; I'll poke Brian about what his policies
Patchset 4 (id:??) landed as
https://crrev.com/d03191beb1888b272e51912ebc45c4e8794f2060
Cr-Commit-Position: refs/heads/master@{#30120}
https://codereview.chromium.org/1274193004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #4 (id:60001)
https://codereview.chromium.org/1274193004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Comment #3 on issue 4288 by little...@chromium.org: Lexical bindings in
eval should not escape
https://code.google.com/p/v8/issues/detail?id=4288
Fixed by https://codereview.chromium.org/1274193004/
--
You received this message because this project is configured to send all
issue
PTAL
https://codereview.chromium.org/1282093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1282093002/diff/60001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/1282093002/diff/60001/src/flag-definitions.h#newcode191
src/flag-definitions.h:191: V(harmony_block_function, harmony function
block scoping) \
How
On 2015/08/11 at 20:51:13, caitpotter88 wrote:
On 2015/08/11 20:45:19, adamk wrote:
Looks like webkit/fast/js/Object-getOwnPropertyNames is failing (you can
reproduce locally by explicitly running the webkit tests:
tools/run-tests.py webkit
Reviewers: rossberg,
Message:
What do you think?
Description:
Remove old webkit Object-getOwnPropertyNames test
This test enumerates properties on all the builtins and makes sure that
they never change. In practice, this just generates busywork when trying
to add new language features; I've
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1274193004/60001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1274193004/60001
https://codereview.chromium.org/1274193004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Comment #2 on issue 4288 by bugdro...@chromium.org: Lexical bindings in
eval should not escape
https://code.google.com/p/v8/issues/detail?id=4288#c2
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/d03191beb1888b272e51912ebc45c4e8794f2060
commit
Status: Untriaged
Owner:
CC: yang...@chromium.org
Labels: Type-Bug Priority-Medium HW-IA32 OS-Windows
New issue 4369 by kin...@chromium.org: Wrong execution result (around
computation involving Math.floor(-0), maybe?)
https://code.google.com/p/v8/issues/detail?id=4369
Version: V8
https://codereview.chromium.org/1273353003/diff/1/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/1273353003/diff/1/src/code-stubs-hydrogen.cc#newcode402
src/code-stubs-hydrogen.cc:402:
is_float32x4.IfHCompareObjectEqAndBranch(
As discussed
https://codereview.chromium.org/1284853003/diff/20001/src/heap/spaces.h
File src/heap/spaces.h (left):
https://codereview.chromium.org/1284853003/diff/20001/src/heap/spaces.h#oldcode2655
src/heap/spaces.h:2655: // Creates an old space object with a given
maximum capacity.
On 2015/08/11
Patchset 2 (id:??) landed as
https://crrev.com/a68ad56c508d98678315f00a7da0f7580524a131
Cr-Commit-Position: refs/heads/master@{#30104}
https://codereview.chromium.org/1285793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #5 (id:60001)
https://codereview.chromium.org/1281833002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 5 (id:??) landed as
https://crrev.com/2e2765a6ebfdec83188d423c24a786c96c5fa6ed
Cr-Commit-Position: refs/heads/master@{#30105}
https://codereview.chromium.org/1281833002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1282503003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/58109a2c5038fbbb208904d4edfc0a7a758928c3
Cr-Commit-Position: refs/heads/master@{#30102}
https://codereview.chromium.org/1282503003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Patchset 2 (id:??) landed as
https://crrev.com/75e43a6681e01de9422a0211f502723d23b51247
Cr-Commit-Position: refs/heads/master@{#30103}
https://codereview.chromium.org/1277353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1277353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Updates:
Status: Available
Cc: jkumme...@chromium.org ish...@chromium.org
Labels: Area-Runtime
Comment #3 on issue 4366 by habl...@chromium.org: clang/win:
runtime-atomics.cc doesn't build with -Wunused-function
https://code.google.com/p/v8/issues/detail?id=4366
(No
Comment #59 on issue 2700 by lewisw...@gmail.com: Implement arrow functions
https://code.google.com/p/v8/issues/detail?id=2700
@andy: I feel really embarassed right now. Thanks for pointing it out.
--
You received this message because this project is configured to send all
issue
lgtm
https://codereview.chromium.org/1285723003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM.
https://codereview.chromium.org/1285793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Updates:
Owner: bi...@chromium.org
Cc: brucedaw...@chromium.org
Comment #4 on issue 4366 by yang...@chromium.org: clang/win:
runtime-atomics.cc doesn't build with -Wunused-function
https://code.google.com/p/v8/issues/detail?id=4366
(No comment was entered for this change.)
Comment #61 on issue 4137 by jkumme...@chromium.org: Support elements in
the LookupIterator
https://code.google.com/p/v8/issues/detail?id=4137
#60: Sorry, I'm swamped, but it's on my list. I'll look as soon as I can.
--
You received this message because this project is configured to send
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1281833002/60001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1281833002/60001
https://codereview.chromium.org/1281833002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Hey Yang,
This reduces the number of instance types for SIMD primitives to 1 again
(otherwise we will run out of instance types at some point), and removes a
lot
of code duplication.
Please take a look.
Thanks,
Benedikt
Bill: As discussed earlier today; FYI.
Andreas: FYI
lgtm
https://codereview.chromium.org/1286653004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1273353003/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1273353003/20001
https://codereview.chromium.org/1273353003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Patchset 1 (id:??) landed as
https://crrev.com/ce519749433fd922e11c2378b03c672d09aca235
Cr-Commit-Position: refs/heads/master@{#30106}
https://codereview.chromium.org/1286653004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1286653004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Awesome. LGTM.
https://codereview.chromium.org/1282503003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
lgtm
https://codereview.chromium.org/1282503003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1284853002/ by yang...@chromium.org.
The reason for reverting is: This CL breaks MIPS (roll blocker).
Reviewers: Jarin, titzer,
Message:
Created Revert of [turbofan] Various fixes to allow unboxed doubles as
arguments
in registers and on the stack.
Description:
Revert of [turbofan] Various fixes to allow unboxed doubles as arguments in
registers and on the stack. (patchset #7 id:120001 of
lgtm
https://codereview.chromium.org/1284853002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2015/08/11 08:13:36, Yang wrote:
https://codereview.chromium.org/1264993002/diff/60001/src/debug/debug-scopes.cc
File src/debug/debug-scopes.cc (right):
https://codereview.chromium.org/1264993002/diff/60001/src/debug/debug-scopes.cc#newcode86
src/debug/debug-scopes.cc:86: HandleScopeInfo
Reviewers: Benedikt Meurer,
Description:
Remove redundant handle in ScopeIterator constructor.
R=bmeu...@chromium.org
Please review this at https://codereview.chromium.org/1286653004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -1 lines):
M
One question below.
Still, could you explain why it deadlocked?
https://codereview.chromium.org/1230303005/diff/80001/src/futex-emulation.cc
File src/futex-emulation.cc (right):
https://codereview.chromium.org/1230303005/diff/80001/src/futex-emulation.cc#newcode138
src/futex-emulation.cc:138:
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1285793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1286653004/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1286653004/1
https://codereview.chromium.org/1286653004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2015/08/11 08:52:42, Benedikt Meurer wrote:
Hey Yang,
This reduces the number of instance types for SIMD primitives to 1 again
(otherwise we will run out of instance types at some point), and removes
a lot
of code duplication.
Please take a look.
Thanks,
Benedikt
Bill: As
https://codereview.chromium.org/1273353003/diff/1/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/1273353003/diff/1/src/code-stubs-hydrogen.cc#newcode402
src/code-stubs-hydrogen.cc:402:
is_float32x4.IfHCompareObjectEqAndBranch(
Can we do an
Status: Untriaged
Owner:
CC: yang...@chromium.org, joc...@chromium.org
Labels: Type-Bug Priority-Medium Hotlist-CD
New issue 4367 by yang...@chromium.org:
webkit_unit_tests/CompositorWorkerManagerTest.CreatingSecondDuringTerminationOfFirst
crashes flakily
Patchset 2 (id:??) landed as
https://crrev.com/f4c079d450a5990639b295d40a3d1663d70412d6
Cr-Commit-Position: refs/heads/master@{#30107}
https://codereview.chromium.org/1273353003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1273353003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Reviewers: Hablich,
Description:
Version 4.5.103.22 (cherry-pick)
Merged 1e65e201894791c3bf8473728021f0e548a0543b
Merged 6ea0d55dfb9306200b86e057ac74528321ca709b
Fasterify JSObject::UnregisterPrototypeUser
Fasterify ICSlotCache
BUG=chromium:517406,chromium:517406,chromium:517778
LOG=N
Reviewers: Michael Lippautz, Michael Starzinger,
Description:
Respect old generation limit in large object space allocations.
Also remove unused max_capcity_ field in old spaces.
BUG=chromium:518028,chromium:504854
Please review this at https://codereview.chromium.org/1284853003/
Base URL:
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1281833002/40001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1281833002/40001
https://codereview.chromium.org/1281833002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Try jobs failed on following builders:
v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8552)
https://codereview.chromium.org/1281833002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Reviewers: Yang,
Description:
[simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values.
There's no need to have one InstanceType per SIMD primitive type (this
will not scale long-term). Also reduce the amount of code duplication
and make it more robust wrt adding new SIMD types.
lgtm
https://codereview.chromium.org/1284853003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2015/08/08 13:35:35, commit-bot: I haz the power wrote:
Dry run: This issue passed the CQ dry run.
lgtm.
https://codereview.chromium.org/1277353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1277353002/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1277353002/20001
https://codereview.chromium.org/1277353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2015/08/11 07:21:10, Yang wrote:
On 2015/08/08 13:35:35, commit-bot: I haz the power wrote:
Dry run: This issue passed the CQ dry run.
lgtm.
CLA check passes btw.
https://codereview.chromium.org/1277353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Comment #58 on issue 2700 by andyearn...@gmail.com: Implement arrow
functions
https://code.google.com/p/v8/issues/detail?id=2700
@lewis, #57: that is working as intended. Lexical `this` means that it is
bound to the `this` from the enclosing scope. It cannot be retargeted
using
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1285793002/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1285793002/20001
https://codereview.chromium.org/1285793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Updates:
Status: Assigned
Comment #5 on issue 4366 by yang...@chromium.org: clang/win:
runtime-atomics.cc doesn't build with -Wunused-function
https://code.google.com/p/v8/issues/detail?id=4366
(No comment was entered for this change.)
--
You received this message because this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1273353003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1273353003/1
https://codereview.chromium.org/1273353003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Committed patchset #1 (id:1) manually as
d3616887ffe09d00b48a82f1fbb1754fadcf73d5.
https://codereview.chromium.org/1282143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
On 2015/08/11 09:57:10, Jakob wrote:
lgtm
https://codereview.chromium.org/1282143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Reviewers: Michael Starzinger,
Description:
Debugger: correctly find closure to recompile eval for debugging.
R=mstarzin...@chromium.org
BUG=chromium:517592
LOG=N
Please review this at https://codereview.chromium.org/1285793002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1282503003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1282503003/1
https://codereview.chromium.org/1282503003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Awesome! LGTM
https://codereview.chromium.org/1272933004/diff/1/src/objects.cc
File src/objects.cc (left):
https://codereview.chromium.org/1272933004/diff/1/src/objects.cc#oldcode30
src/objects.cc:30: #include src/heap/objects-visiting-inl.h
yey!
https://codereview.chromium.org/1272933004/
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1284853003/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1284853003/20001
https://codereview.chromium.org/1284853003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
LGTM with nits.
https://codereview.chromium.org/1284853003/diff/20001/src/heap/spaces.h
File src/heap/spaces.h (left):
https://codereview.chromium.org/1284853003/diff/20001/src/heap/spaces.h#oldcode2655
src/heap/spaces.h:2655: // Creates an old space object with a given
maximum capacity.
nit:
https://codereview.chromium.org/1264993002/diff/60001/src/debug/debug-scopes.cc
File src/debug/debug-scopes.cc (right):
https://codereview.chromium.org/1264993002/diff/60001/src/debug/debug-scopes.cc#newcode86
src/debug/debug-scopes.cc:86: HandleScopeInfo
scope_info(shared_info-scope_info());
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1272763005/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1272763005/1
https://codereview.chromium.org/1272763005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1272933004/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1272933004/1
https://codereview.chromium.org/1272933004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Status: Untriaged
Owner:
New issue 4368 by ben.a.wh...@gmail.com: Console Autocomplete Missing for
Functional Mixins if Built on Empty Prototype
https://code.google.com/p/v8/issues/detail?id=4368
Version: 4.4.63.25 - 4.6.62
OS: OSX 10.9.5
Architecture: x64
What steps will reproduce
Reviewers: Benedikt Meurer,
Description:
Debugger: clear shared function info list when recompiling for liveedit.
R=bmeu...@chromium.org
BUG=chromium:517594
LOG=N
Please review this at https://codereview.chromium.org/1270313003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1272933004/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1272933004/20001
https://codereview.chromium.org/1272933004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1290453002/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1290453002/20001
https://codereview.chromium.org/1290453002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: Yang,
Description:
Remove grab-bag includes of v8.h from debugger.
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/1283023002/
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-fullcode
Affected files (+1, -25 lines):
M
Reviewers: Yang,
Description:
[stubs] Store typeof string on Oddballs.
First step to simplify the TypeofStub. This is similar to the
optimization that we use for ToNumber and ToString on Oddballs already.
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/1272763005/
On 2015/08/11 10:14:14, Benedikt Meurer wrote:
lgtm.
https://codereview.chromium.org/1272763005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe
LGTM.
https://codereview.chromium.org/1270313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1)
https://codereview.chromium.org/1270313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/9eea3ef5147a5e15256093fb4c36a7598d60d128
Cr-Commit-Position: refs/heads/master@{#30111}
https://codereview.chromium.org/1270313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1290453002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/a8fba0f62efdbac6dae069b0308f74ee560752ca
Cr-Commit-Position: refs/heads/master@{#30110}
https://codereview.chromium.org/1290453002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Frankly, I don't quite see why we need this, as the existing output conveys
the
same information:
[00:00|% 0|+ 0|- 0]: Done
But if you like that more explicit warning, fine, LGTM.
https://codereview.chromium.org/1281313004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: Benedikt Meurer,
Description:
Realize IWYU pattern for handles.h header.
R=bmeu...@chromium.org
Please review this at https://codereview.chromium.org/1290453002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+39, -27 lines):
M src/accessors.h
M
Reviewers: Yang,
Description:
Remove grab-bag includes of v8.h from full codegen.
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/1283653004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -18 lines):
M
Reviewers: Hablich,
Description:
Version 4.4.63.31 (cherry-pick)
Merged 1e65e201894791c3bf8473728021f0e548a0543b
Merged 6ea0d55dfb9306200b86e057ac74528321ca709b
Fasterify JSObject::UnregisterPrototypeUser
Fasterify ICSlotCache
BUG=chromium:517406,chromium:517406,chromium:517778
LOG=N
On 2015/08/11 12:09:43, Jakob wrote:
lgtm
https://codereview.chromium.org/1281613004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Hey Yang,
As discussed offline: I'm going to simplify the TypeofStub. This is the
obvious
optimization for Oddball; the next thing is to target SIMD types.
Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1272763005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Patchset 1 (id:??) landed as
https://crrev.com/a0364972fcf5383078017914cc2fe75a02889117
Cr-Commit-Position: refs/heads/master@{#30108}
https://codereview.chromium.org/1272763005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Try jobs failed on following builders:
v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4822)
https://codereview.chromium.org/1272933004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
Committed patchset #1 (id:1)
https://codereview.chromium.org/1272763005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1270313003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1270313003/1
https://codereview.chromium.org/1270313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
https://codereview.chromium.org/1284853003/diff/40001/src/heap/spaces.cc
File src/heap/spaces.cc (right):
https://codereview.chromium.org/1284853003/diff/40001/src/heap/spaces.cc#newcode2848
src/heap/spaces.cc:2848: heap()-incremental_marking()-IsStopped()
We cannot allow incremental marking
Patchset 2 (id:??) landed as
https://crrev.com/02495d54597f071cf7281864df3f89b33823
Cr-Commit-Position: refs/heads/master@{#30109}
https://codereview.chromium.org/1272933004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Love it. LGTM!
https://codereview.chromium.org/1290453002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1272933004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Committed patchset #1 (id:1) manually as
5dbf1f70f4ea251a5f4aaddbd3440b1d6c1d1c7b.
https://codereview.chromium.org/1281613004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
1 - 100 of 173 matches
Mail list logo
