[v8-dev] Re: Implement --omit, --raw_[context_]file=... for mksnapshot tool. (issue 249283002)

2014-04-24 Thread svenpanne
https://codereview.chromium.org/249283002/diff/20001/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/249283002/diff/20001/src/flag-definitions.h#newcode660 src/flag-definitions.h:660: DEFINE_bool(omit, false, Omit raw snapshot bytes in generated

[v8-dev] Re: Implement --omit, --raw_[context_]file=... for mksnapshot tool. (issue 249283002)

2014-04-24 Thread jochen
On 2014/04/24 06:59:16, Sven Panne wrote: https://codereview.chromium.org/249283002/diff/20001/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/249283002/diff/20001/src/flag-definitions.h#newcode660 src/flag-definitions.h:660: DEFINE_bool(omit,

[v8-dev] Re: Implement --omit, --raw_[context_]file=... for mksnapshot tool. (issue 249283002)

2014-04-24 Thread vogelheim
PTAL. Not sure what to do abount the flags thing, though. https://codereview.chromium.org/249283002/diff/20001/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/249283002/diff/20001/src/flag-definitions.h#newcode660 src/flag-definitions.h:660:

[v8-dev] Re: Implement --omit, --raw_[context_]file=... for mksnapshot tool. (issue 249283002)

2014-04-24 Thread svenpanne
LGTM with a nit https://codereview.chromium.org/249283002/diff/20001/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/249283002/diff/20001/src/flag-definitions.h#newcode660 src/flag-definitions.h:660: DEFINE_bool(omit, false, Omit raw snapshot bytes

[v8-dev] Re: Implement --omit, --raw_[context_]file=... for mksnapshot tool. (issue 249283002)

2014-04-24 Thread vogelheim
On 2014/04/24 11:12:43, Sven Panne wrote: LGTM with a nit https://codereview.chromium.org/249283002/diff/20001/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/249283002/diff/20001/src/flag-definitions.h#newcode660 src/flag-definitions.h:660:

[v8-dev] Re: Implement --omit, --raw_[context_]file=... for mksnapshot tool. (issue 249283002)

2014-04-24 Thread vogelheim
Committed patchset #3 manually as r20941 (presubmit successful). https://codereview.chromium.org/249283002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Implement --omit, --raw_[context_]file=... for mksnapshot tool. (issue 249283002)

2014-04-23 Thread jochen
lgtm I guess make quickcheck still passes with this? https://codereview.chromium.org/249283002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe

[v8-dev] Re: Implement --omit, --raw_[context_]file=... for mksnapshot tool. (issue 249283002)

2014-04-23 Thread Daniel Vogelheim
On Wed, Apr 23, 2014 at 5:23 PM, joc...@chromium.org wrote: lgtm I guess make quickcheck still passes with this? Indeed. -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups