Re: Travis macos job

Should be fixed now. On Thu, Mar 5, 2020 at 3:40 PM Dridi Boukelmoune wrote: > Hi, > > Can someone with knowledge of both travis and macos have a look? > > Since this build it fails to find rst2man: > > https://travis-ci.org/varnishcache/varnish-cache/builds/653055383 > > Thanks, > Dridi >

Re: [PATCH] Prefer Python 3 tools

Thanks for the PR. Makes sense. I've merged it. Best. On Tue, May 14, 2019 at 4:47 PM Klemens Nanni wrote: > The last three commits already made configure recommend installing > Python 3 packages and look for versioned executables, however with a low > priority. > > This is a problem on

Re: next VDD

It certainly will be tricky for me to attend around those dates. If it's local, however, the chances would be higher but it's outside my control :-) On Mon, Oct 8, 2018 at 6:31 PM Geoff Simmons wrote: > On 10/8/18 18:55, Federico Schwindt wrote: > > > > It might b

next VDD

Hey, It might be a bit earlier but personally knowing the where and when for the next VDD will help immensely to sort the time off at work and whatnot, especially the date. Do we have any ideas or suggestions? Best. ___ varnish-dev mailing list

Re: Springtime for VDD ?

Not sure about doing but providing there is enough notice, I'd love to attend. If there is anything I can do to help moving this forward please do let me know. On Fri, Apr 13, 2018 at 8:00 AM, Poul-Henning Kamp wrote: > A bugwash or two ago we talked about having a VDD

Re: calling for a new workspace sizing concept - Re: auto-tune ws / headroom poc

I prefer less knobs so I'm inclined to agree with Dridi's suggestion. I'd propose to make the math but keep the final workspaces' numbers as they are and bump them after the release. That would keep the footprint similar to what it is today and we could document the change in advance (and warn

Re: [master] b6d0ff8 Merge tests and reshuffle things

Not happy about hiding the error but it will do it for now. The tests are not using a hardcoded port anymore and should fail with the expected error now. Why this is a problem in sunos is beyond to me at the moment. On Fri, Jan 27, 2017 at 8:14 PM, Dridi Boukelmoune wrote: > On

Re: thoughts about vcl cleanup around (be)resp.body and abandon/synth

On Wed, Nov 30, 2016 at 9:24 AM, Dridi Boukelmoune wrote: > [..] > > While this is feasible, I sill don't understand why we would need a > de-tour over > > v_b_e just to create a synthetic body. > > The problem with using v_b_e is that you need to trick Varnish to get > there on

Re: thoughts about vcl cleanup around (be)resp.body and abandon/synth

On Tue, Nov 29, 2016 at 3:30 PM, Nils Goroll wrote: > [..] > Suggestion: > > - retire synthetic and support (un)set (be)resp.body > (not directly related to the topic, but something we should do >for consistency) > set (be)resp.body is already supported, but restricted

Re: VCL storage discussion summary

OK, all makes sense now. I will work on the PR. On Wed, Oct 12, 2016 at 9:32 AM, Poul-Henning Kamp <p...@phk.freebsd.dk> wrote: > > In message <CAJV_h0YEqgoh9b+qrBVW05CeRezr0Etq5Zkv8y4n19OxT > 15...@mail.gmail.com> > , Federico Schwindt writes: > > >In

Re: VCL storage discussion summary

a typo, we will fail the request or fallback to Transient? On Tue, Oct 11, 2016 at 9:12 PM, Poul-Henning Kamp <p...@phk.freebsd.dk> wrote: > > In message <CAJV_h0bnbgUL-P43_UyX8q_RFV06if1SjPHo21Y4g+H-ME6QcA@ > mail.gmail.com> > , Federico Schwindt writes: > >

Re: VCL storage discussion summary

Regardless of the RR, any comments or guidelines to move this forward? Should we stick to the _hint and gc in the next major release? On Mon, Oct 10, 2016 at 11:19 PM, Federico Schwindt <fg...@lodoss.net> wrote: > In my experience setups defining multiple storages are few and they u

Re: VCL storage discussion summary

that we cannot say that default means the first non-Transient storage for cache insertions. On Mon, Oct 10, 2016 at 8:23 PM, Poul-Henning Kamp <p...@phk.freebsd.dk> wrote: > > In message <CAJV_h0ZBAgQ-pknesZgE08ckL83rQ2F+ > g5px0xcd6ukqn+a...@mail.gmail.com> > ,

Re: VCL storage discussion summary

bsd.dk> wrote: > > In message rtqa686ak...@mail.gmail.com> > , Federico Schwindt writes: > > >This might be obvious but are we considering NULL a "no setting" as well > or > >only when a VMOD returns NULL? > > > >If it's the latter I ag

Re: VCL storage discussion summary

message gg88cel9uv-k7...@mail.gmail.com> > , Federico Schwindt writes: > > >Doesn't that depend on whether is a cache insertion or pass? > > > >Are we considering changing that? > > If we have NULL for stevedore and it is an insert, I would consider > making it pass

Re: VCL storage discussion summary

Doesn't that depend on whether is a cache insertion or pass? Are we considering changing that? On Mon, Oct 10, 2016 at 6:08 PM, Poul-Henning Kamp <p...@phk.freebsd.dk> wrote: > > In message cy_rr2xju87ui...@mail.gmail.com> > , Federico Schwindt writes: > > &g

Re: VCL storage discussion summary

; In message ctatgu2qwftqv...@mail.gmail.com> > , Federico Schwindt writes: > > >If setting or using a storage cannot fail I'd say kill _hint (eventually) > >and just use storage. > > > >If there is a chance of failing, I'd keep the _hint. I'd avoid having > both.

Re: VCL storage discussion summary

[ And now replying to all.. ] Hi, If setting or using a storage cannot fail I'd say kill _hint (eventually) and just use storage. If there is a chance of failing, I'd keep the _hint. I'd avoid having both. Having backend_hint and backend is confusing enough already. Regardless of the outcome,

Re: github labels

I've created all the labels now. Happy tagging! On Tue, Mar 15, 2016 at 9:23 AM, Federico Schwindt <fg...@lodoss.net> wrote: > Good idea. > > On Tue, Mar 15, 2016 at 8:56 AM, Geoff Simmons <ge...@uplex.de> wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Ha

Re: github labels

Someone with permissions have to create them though :) On Wed, Apr 13, 2016 at 6:42 PM, Poul-Henning Kamp <p...@phk.freebsd.dk> wrote: > > In message < > cajv_h0aynnefz75yhwdq6ua2nc1rb6z2wdqfibqgewfbq-g...@mail.gmail.com> > , Federico Schwindt writes: > >

Re: github labels

phk? On Tue, Mar 15, 2016 at 9:23 AM, Federico Schwindt <fg...@lodoss.net> wrote: > Good idea. > > On Tue, Mar 15, 2016 at 8:56 AM, Geoff Simmons <ge...@uplex.de> wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA256 >> >> On 03/15/2016 09

Re: Expanding VCL object support

I definitely like this and I can see a lot of places where it will become handy. What I'm not particularly keen is the xxx.var namespace. While I understand the reasoning behind and I'd like to see some kind of variable support in Varnish I'm not sure reusing the *req/*resp space is the way

Re: Varnish performance musings

Hi, I'm all for the LUT idea and I think it makes even more sense when you consider H/2. Having the same timestamp during a particular method also makes sense. I believe we only need to change now calls to use ctx->now instead of getting the time on each call but haven't looked into detail.

Re: Varnish5 builtin VCL without pipe

For the record, added my comment to the VIP at https://github.com/varnishcache/varnish-cache/wiki/VIP8:-No-pipe-in-builtin.vcl-in-V5 . On Wed, Apr 6, 2016 at 9:27 AM, Poul-Henning Kamp wrote: > Can we make builtin::vcl_recv{} look like this in Varnish5 ? > > sub vcl_recv {

Re: VTAILQ_EMPTY vs -Wparentheses-equality with clang

I think FreeBSD uses *-Wno-parentheses-equality. * Might be worth adding it (if supported). On Mon, Apr 4, 2016 at 3:57 PM, Poul-Henning Kamp <p...@phk.freebsd.dk> wrote: > > In message < > cajv_h0bcw6munhbc8qy4emhcrffdvsgipgskoustqpxxra6...@mail.gmail.com>

Re: VTAILQ_EMPTY vs -Wparentheses-equality with clang

Weird. I'm using clang 3.7 and I'm not seeing any warnings. What OS is this? On Mon, Apr 4, 2016 at 2:46 PM, Dridi Boukelmoune wrote: > Hi, > > As I said on IRC I have hit a bug while working on a VMOD and then on > Varnish itself. I thought I had seen other false-positives but

Re: github labels

Good idea. On Tue, Mar 15, 2016 at 8:56 AM, Geoff Simmons <ge...@uplex.de> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On 03/15/2016 09:29 AM, Federico Schwindt wrote: > > > > - 4.0 - 4.1 - master - more-info-needed - needs-backport > &g

Re: Patch: Use calloc instead of malloc when running out of VSM space (common_vsm.c)

In the case this would be an issue my concerns are not directly related to performance nor latency. If the configuration, either the default or modified by the user, would be oversized there could be lot of waste, which might have other side effects (as swapping). I doubt this would the case for

Re: Patch: Use calloc instead of malloc when running out of VSM space (common_vsm.c)

Incidentally, this also reminds me of something else I observed some time ago. We use calloc in many places, I do wonder how many of them do really need it. The downside of using calloc when is not really needed is that by zeroing the memory you end up with resident memory and not virtual, which

Re: New (be)req fields: path scheme and authority

Hi, As I mention to Dridi in a private irc channel, I like the idea of scheme, specially in the context of #1847. req.path is a different story. The meaning of path in HTTP/1.x and HTTP/2 has diverted AFAIU. In the former the path is just the path component of the URI, in the latter (well, the

[PATCH] Add support for REAL [+-] REAL operations

Hi, Someone on #varnish mentioned the need for this. Personally I can't think of any reason for not allowing it. Comments? OK? From be543b8ca38120bc84d25aa6fea21e56f4c06443 Mon Sep 17 00:00:00 2001 From: "Federico G. Schwindt" Date: Thu, 28 Jan 2016 18:07:56 + Subject:

Re: An Official Varnish Docker Repository

Hi Eric, It's good to finally see a docker image from the community! That said, personally if the image is official I'd expect it to be done by the people running the project. Call me paranoid but I'd feel more reassured knowing it's coming from the same source. OTOH, I don't see any issues

[PATCH] Do not send a zero Content-Length for 204 and 304

Hi, In the 304 case we were already skipping it for non-zero C-L. For 204 responses this was introduced as a side effect of 271e1c52. Comments? OK? From a764ff2612c18a5e8338c0db9827d1c7496c7b23 Mon Sep 17 00:00:00 2001 From: "Federico G. Schwindt" Date: Sun, 3 Jan 2016

[PATCH] VSB_bcat: Don't do a single char at the time

Hi, VSB_bcat calls VSB_put_byte for each char that needs to append. Since we know the length it's better to extend the buffer if needed and just memcpy the whole input. Comments? OK? diff --git a/lib/libvarnish/vsb.c b/lib/libvarnish/vsb.c index 92abdf2..ad98c8a 100644 --- a/lib/libvarnish/vsb.c

[PATCH] Ignore If-Modified-Since if we have If-None-Match

The latter takes precedence as per RFC 7232. Also if we have an I-N-M but no entity don't check I-M-S, just do a non-conditional request. Comments? OKs? From 7bb758fd81265d912c28048d7a41c4316a8d8686 Mon Sep 17 00:00:00 2001 From: "Federico G. Schwindt" Date: Sat, 12 Dec 2015

[PATCH] Use a weak comparison function for If-None-Match

As per RFC. Reorganise some of the tests to avoid duplicates. Fixes #1816. OK? Comments? From f8873ec0288ffdcc6136b12e8ab7f6d2b390fd63 Mon Sep 17 00:00:00 2001 From: "Federico G. Schwindt" Date: Wed, 9 Dec 2015 11:35:57 + Subject: [PATCH] Use a weak comparison function for

Re: IPv[46] parsing

Attached. On Wed, Nov 4, 2015 at 10:46 AM, Poul-Henning Kamp <p...@phk.freebsd.dk> wrote: > > In message < > cajv_h0zy3e4t5704qohqbnqxjgxnh1hdgmneybubfxn1jhw...@mail.gmail.com> > , Federico Schwindt writes: > > >Any comments? > > Sounds s

Re: IPv[46] parsing

Hi, As requested I've provided the details of how this currently works and my proposal. Any comments? On Wed, Oct 28, 2015 at 1:38 PM, Federico Schwindt <fg...@lodoss.net> wrote: > Hi, > > Current functionality > > > 1. If the string

Re: [PATCH] Convert arguments to strings as well

Ping. On Tue, Oct 13, 2015 at 5:14 PM, Federico Schwindt <fg...@lodoss.net> wrote: > Anyone? > > On Thu, Oct 1, 2015 at 5:36 PM, Federico Schwindt <fg...@lodoss.net> > wrote: > >> Now that 4.1 is out of the way, I'd

Re: Varnish project autumn cleaning

I agree with Lasse as well, we should keep the wiki. It might be worth exploring https://help.github.com/articles/user-organization-and-project-pages/ for the website and/or wiki. I'm happy to co-admin/root any server if required but IMO if we can avoid any maintenance by using the above it'd be

IPv[46] parsing

Hi, Here's a resume of the current situation and the proposed plan to address it. While moving from 4.0.x to 4.1 I noticed that std.ip(..., "::1") doesn't work anymore. It errors out with: IP constant '"::1"' could not be resolved to an IP address: Servname not supported for ai_socktype (Sorry

[PATCH] Expose accept_filter parameter to Linux

Now that 4.1 is out of the door I'd like to get this in, disabled by default. We can nuke it before release if required and gives people time to play with it. Comments? From ecb0e378e7d8e5ee60d9c9ef8d211ddc40f3 Mon Sep 17 00:00:00 2001 From: "Federico G. Schwindt" Date:

Re: [PATCH] Convert arguments to strings as well

Anyone? On Thu, Oct 1, 2015 at 5:36 PM, Federico Schwindt <fg...@lodoss.net> wrote: > Now that 4.1 is out of the way, I'd like to push this. > > Comments? > ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varni

Re: Adding -b (buffer size) parameter to varnishtest

Committed. Thanks for the patch Carlos! On Thu, Sep 10, 2015 at 3:50 PM, Carlos Abalde wrote: > > > On 10 Sep 2015, at 15:00, Poul-Henning Kamp wrote: > > > > > > In message

Re: [PATCH] fix phk build system

I appreciate that but I don't think the extra complexity / compilation time is needed. On Wed, Sep 16, 2015 at 2:52 PM, Poul-Henning Kamp wrote: > > In message

Re: [PATCH] Set error if callback returned < 0

7bzaj_8demrcbcly58...@mail.gmail.com>, > Federico Schwindt writes: > > > Error message will be reported as e.g. "Connection refused" instead of > simply " > > (null)". > > > > OK? > > I don't think that is helpful. > > First, we have no

Re: [PATCH] Log 'set beresp.uncacheable = true' occurrences

Since nitpicking is my name: > + VSLb(bo->vsl, SLT_Uncacheable, "Illegal Vary header"); Before this there is a SLT_Error with "Illegal 'Vary' header from backend, making this a pass.". Repeating the reason here seems redundant. > + if (bo->do_pass) { > +

Re: Adding -b (buffer size) parameter to varnishtest

All these logs use mockup servers. If you are using varnishtest against real servers the length of resulting headers are going to be much larger. Same thing will happen with a real or close to real client. I've run into this many times and I've hacked varnishtest so I'd like to see this in. Also

Re: Fix accept_filter for GNU/Linux

Diff aside looking at the code my impression is that the VTCP_filter_http() function is meant to be compiled in always so erroring out if it's not supported might be wrong here, or at least not when errno is EOPNOTSUPP/ multiple times. On 4 Sep 2015 1:35 pm, "Federico Schwindt" <fg.

Re: Fix accept_filter for GNU/Linux

On Fri, Sep 4, 2015 at 2:26 PM, Rafael Zalamena <rafae...@taghos.com.br> wrote: > Em Fri, 4 Sep 2015 13:42:40 +0100 > Federico Schwindt <fg...@lodoss.net> escreveu: > > > Diff aside looking at the code my impression is that the > VTCP_filter_http() > > functi

Re: Fix accept_filter for GNU/Linux

Hi, Actually the problem is somewhere else. The attached diff should fix it. Cheers. On Wed, Sep 2, 2015 at 10:23 PM, Rafael Zalamena wrote: > Hello, > > Varnish cache daemon is not doing 'accept_filter' for the GNU/Linux > version because of HAVE_ACCEPT_FILTER not

Re: [PATCH]: redhat startup scripts should no longer use -u user

Hi, Why not reusing VARNISH_USER and introduce VARNISH_CCGROUP instead of adding VARNISH_JAIL? Setting it to none shouldn't be an option with the stock scripts IMO. On Thu, Aug 27, 2015 at 8:05 AM, Ingvar Hagelund wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash:

Re: Fix accept_filter for GNU/Linux

And a version aligned with phk's comment (off by default). On Fri, Sep 4, 2015 at 12:15 AM, Federico Schwindt <fg...@lodoss.net> wrote: > Hi, > > Actually the problem is somewhere else. > > The attached diff should fix it. > > Cheers. > > On Wed, Sep 2, 2015 at

Re: [master] d771942 Hide backends and directors implementation details

On Mon, Aug 24, 2015 at 11:04 AM, Poul-Henning Kamp p...@phk.freebsd.dk wrote: In message cajv_h0yj-fldhr7qv0pgju1kg_xzkr_0cie3agxkxjwd2re...@mail.gmail.com , Federico Schwindt writes: [..] This pollutes cache.h and causes artificial breakages. I'd prefer, if we really want to do

[PATCH] Specify the full path of the logs

This makes easier to run multiple instances, each one writing to different files. OK? From ce03b3b44a8e19eee089a2ee50839cfa999dd911 Mon Sep 17 00:00:00 2001 From: Federico G. Schwindt fg...@lodoss.net Date: Fri, 7 Aug 2015 16:53:56 +0100 Subject: [PATCH] Specify the full path of the logs This

Re: [PATCH] Variable for vcl_dir in startup scripts

Hi Gauthier, We've discussed these on irc today and I've now removed ExecStartPre and committed your diff for the sysv init script. Thanks for the diff. Cheers. On Mon, Jul 27, 2015 at 9:38 PM, Federico Schwindt fg...@lodoss.net wrote: Seems the prestart is required for reloads. I haven't

Re: [PATCH] Kill unused session_max

Ok, thanks. Now that I know we want to keep it I will try to bring it back. On Fri, Jul 31, 2015 at 9:24 AM, Poul-Henning Kamp p...@phk.freebsd.dk wrote: In message cajv_h0zgw1dlqkscumix6pstry_qp3mlh+5tclx7rpnmfwf...@mail.gmail.com , Federico Schwindt writes: This looks like

Re: [PATCH] Remove unreachable sess_drop

Actually the AN() is not needed since the check below will trigger the assert anyway. On Mon, Jul 27, 2015 at 4:24 PM, Federico Schwindt fg...@lodoss.net wrote: SES_New() will never return NULL. Replace noop with AN(). OK? ___ varnish-dev mailing

[PATCH] Only load the default config if the env is not set

This makes it possible to use the same reload script with different systemd instances. OK? From 61490d57b3fb972b228fb7ac6084e48f9ed97065 Mon Sep 17 00:00:00 2001 From: Federico G. Schwindt fg...@lodoss.net Date: Mon, 27 Jul 2015 16:15:50 +0100 Subject: [PATCH 1/3] Only load the default config if

[PATCH] Remove unreachable sess_drop

SES_New() will never return NULL. Replace noop with AN(). OK? From da27cf3ece941fa8367052a0d36ef76b12b16262 Mon Sep 17 00:00:00 2001 From: Federico G. Schwindt fg...@lodoss.net Date: Mon, 27 Jul 2015 16:20:14 +0100 Subject: [PATCH 3/3] Remove unreachable sess_drop SES_New() will never return

[PATCH] Kill unused session_max

This looks like a relic from V3. OK? From 5df37483cb5836d63043b8b8324f0dc59d96d1eb Mon Sep 17 00:00:00 2001 From: Federico G. Schwindt fg...@lodoss.net Date: Mon, 27 Jul 2015 16:17:20 +0100 Subject: [PATCH 2/3] Kill unused session_max --- bin/varnishd/common/params.h | 3 ---

Re: [PATCH] Variable for vcl_dir in startup scripts

/var/run/varnish.pid \ -f $VARNISH_VCL_CONF \ -- 1.8.3.msysgit.0 De : Federico Schwindt [mailto:fg...@lodoss.net] Envoyé : mercredi 15 juillet 2015 20:07 À : Delacroix, Gauthier gauthier.delacr...@coreye.fr Cc : varnish-dev@varnish-cache.org; s...@redpill-linpro.com Objet : Re

Re: [PATCH] Variable for vcl_dir in startup scripts

parameters needed to make the config work in the syntax check, without including the full DAEMON_OPTS. If you finally think DAEMON_OPTS can be included in the syntax check, then I can send a really smaller patch. Gauthier De : Federico Schwindt [mailto:fg...@lodoss.net] Envoyé : jeudi 25 juin

Counters in master

Hi, Below is a summary of counters removed and renamed in master wrt 4.0 and IMO what we need to bring back for 4.1. Unless specifically mentioned they are relative to MAIN. Removed: backend_toolate - IIUC cannot happen anymore client_req_413 - unused in 4.0 fetch_close fetch_oldhttp - used to

[PATCH] Rearrange so it's lock-protected

Based on the discussion on irc. f.- From d7da751813ef8519b1ea49fd7ccf144bf62a5087 Mon Sep 17 00:00:00 2001 From: Federico G. Schwindt fg...@lodoss.net Date: Mon, 13 Jul 2015 19:36:49 +0100 Subject: [PATCH] Rearrange so it's lock-protected --- bin/varnishd/cache/cache_backend.c | 2 +- 1 file

Re: Time to retire client.identify?

, 2015 at 3:05 PM, Federico Schwindt fg...@lodoss.net wrote: Hi, The hash director needs a string now so this no longer needed. Opinions? Agreed ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish-cache.org/lists

Time to retire client.identify?

Hi, The hash director needs a string now so this no longer needed. Opinions? From 4226338a02a7791807d7b75f462001ad785659b3 Mon Sep 17 00:00:00 2001 From: Federico G. Schwindt fg...@lodoss.net Date: Wed, 1 Jul 2015 13:54:07 +0100 Subject: [PATCH] Retire client.identity The hash director needs a

Re: [PATCH] Variable for vcl_dir in startup scripts

Hi, My first inclination is to ensure that the ExecStartPre line uses the same parameters as ExecStart. So my questions is how do you set vcl_dir? Do you edit varnish.service or varnish.params? Wouldn't adding DAEMON_OPTS to ExecStartPre (and configtest) do it? On Thu, Jun 25, 2015 at 3:26

[PATCH] Rename VRT_error to VCL_synth

Hi, This is only called when doing return(synth(..)) so I believe it makes sense to call it VRT_synth (before it was done on return(error(..)) thus VRT_error). Whether we should keep the SLT_Debug is a different story IMO but logic above still applies. f.- From

[PATCH] Remove superflous debug

Hi, Remove MISS debug message - it's always followed by VCL_call MISS. f.- From 059f94f2e16224675636fa1d2e53ff6ee85e4f1f Mon Sep 17 00:00:00 2001 From: Federico G. Schwindt fg...@lodoss.net Date: Tue, 23 Jun 2015 18:47:07 +0100 Subject: [PATCH] Remove superflous debug This is always

Vmod constants

Hi, I've been wanting something like this for a while so I decided to give it a try last night after Dridi moaned about the use of somewhat magic numbers in the utf8 vmod. The result is that you can now define constants in .vcc like this: $Const TYPE name value e.g.: $Const INT CASEFOLD 0x0400

PATCH

The attached patch fixes #1724 and #1730. A test is included for the latter. I will commit them separately providing they are OK. Yes / No / Maybe ? diff --git a/bin/varnishd/cache/cache_backend.c b/bin/varnishd/cache/cache_backend.c index a02a7d8..c555e05 100644 ---

Re: [PATCH] Expose the request body length to vcl_recv{}

at 6:51 AM, Poul-Henning Kamp p...@phk.freebsd.dk wrote: In message CAJV_h0axRgUAa6TmngF_j= xodpzs+satfh7s6lnfyg++zxn...@mail.gmail.com , Federico Schwindt writes: 1. This will only set the length after std.cache_req_body(). We might want to return content-length

Re: [PATCH] Change hash_data() input type to BLOB

Updated. On Mon, Apr 20, 2015 at 9:33 PM, Poul-Henning Kamp p...@phk.freebsd.dk wrote: In message cajv_h0bcyloktmbeg8xm35z3ep_lrmwk4smdyvuuhn-nnm5...@mail.gmail.com , Federico Schwindt writes: Duh! New diff attached. Documentation and tests remaining. Something like this? I

Re: [PATCH] Change hash_data() input type to BLOB

Duh! New diff attached. Documentation and tests remaining. Something like this? Should we keep hash_data() or rename it to hash_string() or something similar? On Mon, Apr 20, 2015 at 7:55 PM, Poul-Henning Kamp p...@phk.freebsd.dk wrote: In message 4276.1429509...@critter.freebsd.dk,

[PATCH] Expose the request body length to vcl_recv{}

Another patch while on the plane. As discussed at VDD15Q1 this exposes the request body length via req.bodylen. A few open questions / observations: 1. This will only set the length after std.cache_req_body(). We might want to return content-length if std.cache_req_body() was not previously

Re: [PATCH] Allow returning abandon from vcl_backend_error{}

, Federico Schwindt fg...@lodoss.net wrote: Hi, Currently if you want to have all your error handling in a single place, i.e. vcl_synth{}, and you end up in vcl_backend_error{} you have to either return retry and then abandon in vcl_backend_fetch{} or return deliver and in vcl_deliver

[PATCH] Allow returning abandon from vcl_backend_error{}

Hi, Currently if you want to have all your error handling in a single place, i.e. vcl_synth{}, and you end up in vcl_backend_error{} you have to either return retry and then abandon in vcl_backend_fetch{} or return deliver and in vcl_deliver{} return synth. I can't think of any reason for not

Re: [master] 15ec79c Concentrate the acceptor-setup-session code.

Attached is a patch in that effect. I have no empirical evidence this will improve things but I believe Fastly and others are doing it with good results. On Sat, Mar 21, 2015 at 12:57 PM, Federico Schwindt fg...@lodoss.net wrote: Yeah, me not reading the code properly. So this could

Re: [master] 15ec79c Concentrate the acceptor-setup-session code.

not reading the code correctly, has this changed since 4.0 or it's always been one acceptor per address? On Wed, Mar 18, 2015 at 10:49 AM, Poul-Henning Kamp p...@phk.freebsd.dk wrote: In message cajv_h0awhzhjbq2u5o24fwqfknmnv73qhgw2f4r0-sxpjdq...@mail.gmail.com , Federico Schwindt

Re: [master] 15ec79c Concentrate the acceptor-setup-session code.

Is it time to consider SO_REUSEPORT in Linux? On Tue, Mar 17, 2015 at 10:19 AM, Poul-Henning Kamp p...@freebsd.org wrote: commit 15ec79cdd8b7e9c939b88364fa619c70840c184b Author: Poul-Henning Kamp p...@freebsd.org Date: Tue Mar 17 10:19:10 2015 + Concentrate the

Re: suggesting to increase timeout_req default to 7 seconds

Of course *does make me uneasy*. On Sun, Mar 15, 2015 at 10:33 PM, Federico Schwindt fg...@lodoss.net wrote: The original 3 seconds is from 1989. I don't believe that a 26 years old value is a sound argument to bump it to 7 seconds IMO. This does not mean the default is correct, however

Re: Cache_req_body patch for bug #1664

I thought we will be handling this more gracefully, e.g not just closing the connection. How is the user going to notice it needs to increase the size if it was set to something lower than needed unintentionally? Shouldn't we have a counter at the very least and/or return a 503? On Mon, Mar 9,

Re: [master] 468a047 Expose is_hit to VCL as resp.is_hit

knobs is not the way to go IMO. On Wed, Jan 7, 2015 at 12:12 AM, Federico Schwindt fg...@lodoss.net wrote: I must say I'm not very thrilled about having another variable to check whether it was a hit. How much of an issue this really is and can we fix the code so we still use obj.hits? On Wed

Re: [master] 468a047 Expose is_hit to VCL as resp.is_hit

I must say I'm not very thrilled about having another variable to check whether it was a hit. How much of an issue this really is and can we fix the code so we still use obj.hits? On Wed, Jan 7, 2015 at 12:10 AM, Federico Schwindt fg...@lodoss.net wrote: I must say I'm not very thrilled about

[PATCH] Add support to scale fields in varnishstat(1)

The following two patches add support for scaling byte fields in varnishstat(1). Fixes #1653. The first one marks byte fields as such using the uppercase variant; bytes counter becomes 'C' and bytes gauge 'G'. The second adds support to scale these byte fields using e in the ncurses interface.

heads-up: migrating to github

Hi, I appreciate this is a somewhat controversial topic so I wanted to mention it well in advance. We're planning to migrate the varnish-cache repository to github. The exact date is not defined yet and will depend on a number of factors but I don't expect this to take place before mid February

Re: [PATCH] define AS_COPY_VAR in varnish.m4 if not already defined

Looks good to me and others are doing the same, e.g. https://github.com/gdnsd/gdnsd/issues/85. On Mon, Dec 15, 2014 at 4:11 PM, Geoff Simmons ge...@uplex.de wrote: Hallo all, This patch makes it possible for autoconf 2.63b (which is the unfortunate situation on distros such as RHEL 6.5) to

Re: [PATCH 2/2] Add std.rfc1123() to convert a formatted datetime to VCL_TIME

I thought about this and decided to go for rfc1123() as time() would indicate a TIME input with .integer(), .ip() and .real(). While I agree that rfc1123() is a bit obscure it hints that the input requires some standard format. Actually I should also document the different formats supported. The

Re: [PATCH 2/2] Add std.rfc1123() to convert a formatted datetime to VCL_TIME

Talking of which, isn't this format in vtim.c %F %T,/* ISO 8601 */ Missing the T between the date and time and maybe the trailing Z? On Mon, Dec 15, 2014 at 9:50 AM, Federico Schwindt fg...@lodoss.net wrote: I thought about this and decided to go for rfc1123() as time

Re: [PATCH 2/2] Add std.rfc1123() to convert a formatted datetime to VCL_TIME

: In message cajv_h0yful+omcfckxad+d9nox__aprylk17wa4m5cm6f-x...@mail.gmail.com , Federico Schwindt writes: I thought about this and decided to go for rfc1123() as time() would indicate a TIME input with .integer(), .ip() and .real(). I simply don't grok that. The idea behind

[PATCH] Fix the iso 8601 format

As per my comment on the std.rfc1123 patch. Should it also handle the trailing Z? Comments? OK? From f42cda9d076d63745921625251720bc2cd63823b Mon Sep 17 00:00:00 2001 From: Federico G. Schwindt fg...@lodoss.net Date: Mon, 15 Dec 2014 23:17:33 + Subject: [PATCH] Fix the iso 8601 format ---

[PATCH 1/2] Permit to compare 2 times using standard operators

Useful with upcoming std.rfc1123(). See next mail. Comments? OK? From c7a307a881e48ca2ddb65e6f1cd336214ec72e8c Mon Sep 17 00:00:00 2001 From: Federico G. Schwindt fg...@lodoss.net Date: Wed, 10 Dec 2014 20:34:07 + Subject: [PATCH 1/2] Permit to compare 2 times using standard operators

[PATCH 2/2] Add std.rfc1123() to convert a formatted datetime to VCL_TIME

Depends on previous email [PATCH 1/2] Permit to compare 2 times using standard operators. Useful to check if e.g. Last-Modified is older than a given time. Comments? OK? From fe0aceadd06618b991a71a24e524c2061f5b6aac Mon Sep 17 00:00:00 2001 From: Federico G. Schwindt fg...@lodoss.net Date: Wed,

Re: [PATCH] Improve range support

And here's a minimal version without renames or removing Accept-Ranges from !200 responses. On Sun, Dec 7, 2014 at 6:19 PM, Federico Schwindt fg...@lodoss.net wrote: Hi, Someone at the SF summit mentioned this so here's a patch for handling not satisfiable ranges (error code 416) and fixing

Range support

Hi, phk asked me to summarise what's wrong with our range support. - We don't support multiple ranges (e.g. Range: bytes=0-500,5000-). This is regardless of streaming. - If streaming is enabled, the object is not in the cache, we have a range request and it doesn't specify the last-byte-pos

Re: varnish-dev@varnish-cache.org: Swap flushes all objects in cache

Hi, This looks like https://www.varnish-cache.org/trac/ticket/1539. What varnish version are you running? On Wed, Nov 19, 2014 at 11:48 AM, Anand Shah an...@rediff-inc.com wrote: Thank you Per for replying back. Under desperately low memory conditions, the out-of-memory (OOM) killer

Re: PROXY protocol revisited

Hi, I think it makes sense to make PROTO optional, falling back to current behavior if not present. Since proxy also supports IPv6 we should consider using brackets around the address for IPv6, e.g. proxy@[2001:67c:2804:1001::c21f:279b]:8081 Regarding logging, your suggestion makes sense to me.

[PATCH] make bereq.uncacheable read-only

Hi, I've been spending time writing tests for some other work I'm doing and I found bereq.uncacheable being writable, which doesn't make much sense to me. The same can be achieved setting beresp.uncacheable in vcl_backend_response or vcl_backend_error so this duplication seems unnecessary and

[PATCH] make obj.uncacheable available in deliver

Hi, Someone mentioned on irc that there is no to check whether the object was a pass (or hit-for-pass) short of adding headers in a few vcl subroutines. There is this obj.uncacheable attribute but it's only available in vcl_hit. This doesn't make much sense. vcl_hit will only be reached on hit,

  1   2   >