Re: [vchkpw] 5.4.18 release candidate

2006-12-31 Thread John Simpson
On 2006-12-29, at 1418, Sim wrote: I need this change for disable RBL check after Pop (using pop-before-smtp function): /* append the current ip address to the tmp file * using the format x.x.x.x:ALLOW,RELAYCLIENT=,RBLSMTPD=TABtimestamp */ - fprintf( fs_tmp_file,

Re: [vchkpw] 5.4.18 release candidate

2006-12-31 Thread Sim
here's a slightly better idea: have the code read a text file from ~vpopmail/etc/, or even better from an environment variable, which contains the string you wish to use for each dynamically added IP address... and if that file or variable doesn't exist, the entire write out the IP address and

Re: [vchkpw] 5.4.18 release candidate

2006-12-29 Thread John Simpson
On 2006-12-28, at 0936, Joshua Megerman wrote: OK, I did some more testing with a test cdb and tcprulescheck, and got some interesting results: I thought that the daemontools documentation stated that it takes the first match it finds period, but I misunderstood it slightly. It states that

Re: [vchkpw] 5.4.18 release candidate

2006-12-29 Thread Sim
Hi! I need this change for disable RBL check after Pop (using pop-before-smtp function): /* append the current ip address to the tmp file * using the format x.x.x.x:ALLOW,RELAYCLIENT=,RBLSMTPD=TABtimestamp */ - fprintf( fs_tmp_file, %s:allow,RELAYCLIENT=\\,RBLSMTPD=\\\t%d\n, +

Re: [vchkpw] 5.4.18 release candidate

2006-12-28 Thread Rick Widmer
Joshua Megerman wrote: I just tested and that's not what actually happens - it takes the best match. So there is one potential problem with this (though I consider it minimal) - if you have a rule that doesn't include the 'RELAYCLINET=' and/or 'RBLSMTPD=', you may end up getting denied if

Re: [vchkpw] 5.4.18 release candidate

2006-12-28 Thread Joshua Megerman
Joshua Megerman wrote: I just tested and that's not what actually happens - it takes the best match. So there is one potential problem with this (though I consider it minimal) - if you have a rule that doesn't include the 'RELAYCLINET=' and/or 'RBLSMTPD=', you may end up getting denied if

Re: [vchkpw] 5.4.18 release candidate

2006-12-26 Thread Joshua Megerman
Tom Collins wrote: On Dec 23, 2006, at 6:41 PM, Rick Widmer wrote: snip - I'll address the ALTER statement separately - Don't update the relay CDB for statically covered addresses. (extended version.) Do we have to worry about a race condition where I do my POP pickup and the relay CDB

Re: [vchkpw] 5.4.18 release candidate

2006-12-26 Thread Joshua Megerman
Tom Collins wrote: On Dec 23, 2006, at 6:41 PM, Rick Widmer wrote: - SQL backend fixes - Extend length of domain from 64 to 96 in all database backends. Add delete_spamassassin and delete_spam to the limits table. REQUIRES DATABASE STRUCTURE CHANGES! Since MySQL is the most common

Re: [vchkpw] 5.4.18 release candidate

2006-12-24 Thread Tom Collins
On Dec 23, 2006, at 6:41 PM, Rick Widmer wrote: - SQL backend fixes - Extend length of domain from 64 to 96 in all database backends. Add delete_spamassassin and delete_spam to the limits table. REQUIRES DATABASE STRUCTURE CHANGES! Since MySQL is the most common SQL backend, we should

Re: [vchkpw] 5.4.18 release candidate

2006-12-24 Thread Rick Widmer
Tom Collins wrote: On Dec 23, 2006, at 6:41 PM, Rick Widmer wrote: - SQL backend fixes - Extend length of domain from 64 to 96 in all database backends. Add delete_spamassassin and delete_spam to the limits table. REQUIRES DATABASE STRUCTURE CHANGES! Since MySQL is the most common

[vchkpw] 5.4.18 release candidate

2006-12-23 Thread Rick Widmer
I think the code for the next release is complete. From now on bug fixes should be the only thing we do before release. I am going to look at the documentation for a day or two before saying it is ready to release. The last batch of patches are from Joshua Megerman: - SQL backend fixes -