Re: [vchkpw] vpopmail 5.4.20 released

2007-08-24 Thread Joshua Megerman

> On Wednesday 22 August 2007, Rick Widmer wrote:
>> http://vpopmail.sf.net/
>>
>> 5.4.20 - released 21-Aug-07
>
> Feels odd to ask this, but in the UPGRADE document, it lists the
> "pw_domain"
> columns as requiring updates, but my databases have just "domain" in them
> except for the vpopmail table.
>
> I've upgraded them manually, but should I be re-naming the columns
> manually?
> I'd prefer not to take the plunge and ask instead. :)
>
> Moving from 5.4.17.
>
Looks like there was a bit of a disconnect early in the coding process
(well before I ever heard of vpopmail, which was in the 5.3.x era), and
only the vpopmail table has a 'pw_domain' column (to match the rest of the
password structure naming, I assume).  All of the other tables have a
'domain' column, instead.  So I made an error when I wrote the fix and
updated the UPGRADE document for 5.4.18 (I think it was that), and
incorrectly labelled the column name for vpopmail 'domain' instead of
'pw_domain'.

Thus, the relevant section of UPGRADE should really be:

ALTER TABLE `dir_control` CHANGE `domain` `domain` CHAR(96) NOT NULL;
ALTER TABLE `ip_alias_map` CHANGE domain domain CHAR(96) NOT NULL;
ALTER TABLE `lastauth` CHANGE domain domain CHAR(96) NOT NULL;
ALTER TABLE `valias` CHANGE domain domain CHAR(96) NOT NULL;
ALTER TABLE `vlog` CHANGE domain domain CHAR(96) NOT NULL;
ALTER TABLE `vpopmail` CHANGE pw_domain pw_domain CHAR(96) NOT NULL;

ALTER TABLE `limits` CHANGE domain domain CHAR(96) NOT NULL,
  ADD `disable_spamassassin` TINYINT(1) DEFAULT '0' NOT NULL AFTER
`disable_smtp`,
  ADD `delete_spam` TINYINT(1) DEFAULT '0' NOT NULL AFTER
`disable_spamassassin`;

Note that this is mostly what it said before, with the vpopmail table line
changed to pw_domain instead of domain.  Sorry I didn't catch this before
it was released...

Ideally I would think that the column names should be consistent across
the tables, but that would cause mandatory breakage, and probably should
be held back for a more major release (redo 5.5 or go to 5.6?).  At least
people will have a greater expectation of needing to read the docs
carefully on somethign bigger than a point upgrade :)

Josh

Joshua Megerman
SJGames MIB #5273 - OGRE AI Testing Division
You can't win; You can't break even; You can't even quit the game.
  - Layman's translation of the Laws of Thermodynamics
[EMAIL PROTECTED]



Re: [vchkpw] vpopmail 5.4.20 released

2007-08-23 Thread Quey

Quey wrote:
Rick ? Is this correct or should we be doing something else like Tony 
asked and renaming all domains to pw_domains ?
my bad, I was talking to Tony, I meant what Steve asked? :) ( it is 
early you know hehe)





Re: [vchkpw] vpopmail 5.4.20 released

2007-08-23 Thread Quey

Steve Cole wrote:

On Wednesday 22 August 2007, Rick Widmer wrote:
  

http://vpopmail.sf.net/

5.4.20 - released 21-Aug-07



Feels odd to ask this, but in the UPGRADE document, it lists the "pw_domain" 
columns as requiring updates, but my databases have just "domain" in them 
except for the vpopmail table.


I've upgraded them manually, but should I be re-naming the columns manually?   
I'd prefer not to take the plunge and ask instead. :)


Moving from 5.4.17.

Thanks for any help.

  


Likewise, I have the same situation, and did the same as you.  

Rick ? Is this correct or should we be doing something else like Tony 
asked and renaming all domains to pw_domains ?


Regards
Q



Re: [vchkpw] vpopmail 5.4.20 released

2007-08-22 Thread Steve Cole
On Wednesday 22 August 2007, Rick Widmer wrote:
> http://vpopmail.sf.net/
>
> 5.4.20 - released 21-Aug-07

Feels odd to ask this, but in the UPGRADE document, it lists the "pw_domain" 
columns as requiring updates, but my databases have just "domain" in them 
except for the vpopmail table.

I've upgraded them manually, but should I be re-naming the columns manually?   
I'd prefer not to take the plunge and ask instead. :)

Moving from 5.4.17.

Thanks for any help.

-- 
Cheers,
Steve  |President & Systems Administrator,  Kingston Online Services
   |URL: http://www.kos.net/   613-549-8667/613-968-7137


[vchkpw] vpopmail 5.4.20 released

2007-08-22 Thread Rick Widmer

http://vpopmail.sf.net/

5.4.20 - released 21-Aug-07

Release Notes:

Except for ldap and two new vpopmaild commands, this is entirely a bug
fix release.  Tracker items in this release:

   1765534 - vdominfo crashes with a lot of aliased domains

   1909348 - ldap patch

   A number of items that only appeared on the vpopmail list.


NOTE: the protocol of vpopmaild's mod_user command has changed.  It now
returns +OK if the command passes all validation and is ready to accept
options.  This now works the same as set_limits.  For both, you should
check for errors before you send options.
ChangeLog:

5.4.20 - Released 21-Aug-2007
Bill Shupp/Rick Widmer
- add show_error function to vpopmaild

Rick Widmer
- Make vadduser check that domain exists and user does not exist
  before prompting for password
- Add TODO file to record stuff I don't want to forget
- Add README.vdelivermail
- Add examples for delete and bounce-no-mailbox to help on
  vadddomain

Remo Mattei
- Change upgrade script to use pw_domain instead of domain in
  example code
  to change domain name field lengths.

John Simpson, Joshua Megerman, Adam Sloan
- Fix bad exit if script exists but can not be executed
- Fix missing onchange on delete of alias domain

John Simpson
- Bug fix for vuserifo - vlimits

Harm van Tilborg
- Add support to vpopmaild to retrieve used storage sizes of
  domains or users
- mod_user did not respond +OK if command is valid

Vitali Malicky (coonardoo), Ismail Yenigul
- add ldap patch [1909348]

Ronnie Karstenberg (rkarstenberg)
- vdominfo crashes with a lot of aliased domains [1765534]