Re: [vchkpw] 5.5.3 and limits are not checked
On Aug 10, 2005, at 5:32 PM, Matt Brookings wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Shane Chrisp wrote: | Im not saying that it should deny root from creating an account, but I | would think that it would at least report that the account would take | the account over the configured quota? Otherwise what is the point of | having such a system available? I would have expected an overide switch | rather than just blind creation of an account, but thats just *my* way | of thinking. Well, the other more important thing I didn't mention is that account limitations are not a function of vpopmail, but of qmailadmin. If you're going to use qmailadmin, and you want limits, stick to qmailadmin. Why even use command-line utilities? Well, the code has to exist in vdelivermail to check the account limits, why can't they be set using the command line tools, considering the rest of it is based on command line tools? It kind of has a weird feeling to it to have something in the code which only works if you use a certain program to create the accounts, while those using the standard utilities don't get to make use of those functions unless they decide to write their own scripts to handle the creation of the limits. - -- /* ~Matt Brookings <[EMAIL PROTECTED]> GnuPG Key B7B54216 ~Software developer Systems technician ~Inter7 Internet Technologies, Inc. (815)776-9465 */ -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.6 (GNU/Linux) iD8DBQFC+h4ahzYRRre1QhYRAqy+AJ9Up3tmcCwxnIBFdOuSkET0zE3nVQCeJXD3 afz8Juort17qhkRXcZ32kjg= =V9s7 -END PGP SIGNATURE- Jan-Willem Regeer This message is authored under the license which can be found at http://x-istence.com/LICENSE smime.p7s Description: S/MIME cryptographic signature
Re: [vchkpw] 5.5.3 and limits are not checked
On Wed, 2005-08-10 at 10:32 -0500, Matt Brookings wrote: > Well, the other more important thing I didn't mention is that account > limitations are not a function of vpopmail, but of qmailadmin. If > you're going to use qmailadmin, and you want limits, stick to > qmailadmin. Why even use command-line utilities? I know that the .qmailadmin-limits file was for qmailadmin, but i didnt think the limits table was created for this as well. Maybe im wrong, i dont run qmailadmin. I dont like it personally. If the limits was just for qmailadmin however, i would have expected it to be either a patch, or something in the contrib dir rather than being a compile time option in vpopmail. Currently I run a php admin console which does most tasks for me, but the vpopmaild daemon is a much better idea, which is why im moving down that path. Shane
Re: [vchkpw] 5.5.3 and limits are not checked
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Shane Chrisp wrote: | Im not saying that it should deny root from creating an account, but I | would think that it would at least report that the account would take | the account over the configured quota? Otherwise what is the point of | having such a system available? I would have expected an overide switch | rather than just blind creation of an account, but thats just *my* way | of thinking. Well, the other more important thing I didn't mention is that account limitations are not a function of vpopmail, but of qmailadmin. If you're going to use qmailadmin, and you want limits, stick to qmailadmin. Why even use command-line utilities? - -- /* ~Matt Brookings <[EMAIL PROTECTED]> GnuPG Key B7B54216 ~Software developer Systems technician ~Inter7 Internet Technologies, Inc. (815)776-9465 */ -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.6 (GNU/Linux) iD8DBQFC+h4ahzYRRre1QhYRAqy+AJ9Up3tmcCwxnIBFdOuSkET0zE3nVQCeJXD3 afz8Juort17qhkRXcZ32kjg= =V9s7 -END PGP SIGNATURE-
Re: [vchkpw] 5.5.3 and limits are not checked
On Wed, 2005-08-10 at 09:47 -0500, Matt Brookings wrote: > vadduser.c is simply a call to the vpopmail API. You would be better > to glance at the other source files to determine what's going on. > > | looks like it doesnt even check to see if there is limits associated > | with the domain and just blindly creates the account. Its not really a > > Of course. If root wishes to add a user, you think vpopmail's API > should refuse? Im not saying that it should deny root from creating an account, but I would think that it would at least report that the account would take the account over the configured quota? Otherwise what is the point of having such a system available? I would have expected an overide switch rather than just blind creation of an account, but thats just *my* way of thinking. > The vpopmail API is not structured in this way. > vpopmail has functions that perform a job, such as add a user, and > it has informational functions like reporting quota usage. There are > few, if any, functions that will refuse to perform an action due to > some sort of restraint. It's the program's job to check the > circumstances of the request, not the API. In thise case, the vadduser > binary should always be being called by the root user (or the vpopmail > user). Which comes back to what i said, vadduser doesnt check. I would have expected it to. > vhostadmin is in development, and limits checking will probably make > it's way into the domain administration later on. I understand its under development and im modifying it for my own needs. It doesnt appear that any work had been done on it for quite sometime, or there has just been no changes commited to the cvs listed on the webpage. Ive had to make a few changes to it due to the use of a couple of php5 only functions that have been used. As I said, the limits issue is not a big deal to get around as Ill modify it to call the info needed from the limits table and work from that, it just struck me as strange to have funtionality available in vpopmail which is really not being used by vpopmail at all. All in all it was just curiosity more than anything.
Re: [vchkpw] 5.5.3 and limits are not checked
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Shane Chrisp wrote: | I have been playing around with vhostadmin and the 5.5.3 version of | vpopmail/vpopmaild and i just noticed that the limits are being ignored | completely. Im not real flash with C, but a quick glance at vadduser.c vadduser.c is simply a call to the vpopmail API. You would be better to glance at the other source files to determine what's going on. | looks like it doesnt even check to see if there is limits associated | with the domain and just blindly creates the account. Its not really a Of course. If root wishes to add a user, you think vpopmail's API should refuse? The vpopmail API is not structured in this way. vpopmail has functions that perform a job, such as add a user, and it has informational functions like reporting quota usage. There are few, if any, functions that will refuse to perform an action due to some sort of restraint. It's the program's job to check the circumstances of the request, not the API. In thise case, the vadduser binary should always be being called by the root user (or the vpopmail user). | big problem as im keeping the info in mysql so i could modify vhostadmin | to check the limits there and prevent accounts being created, but i just | wondered if its something thats been missed or if its even going to be vhostadmin is in development, and limits checking will probably make it's way into the domain administration later on. - -- /* ~Matt Brookings <[EMAIL PROTECTED]> GnuPG Key B7B54216 ~Software developer Systems technician ~Inter7 Internet Technologies, Inc. (815)776-9465 */ -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.6 (GNU/Linux) iD8DBQFC+hN8hzYRRre1QhYRAm2kAJwPnbpTfp9hr6bic3uqMTL/b81ALQCfTQSs 75PTsWXJDFcF7yRdlslaLFg= =YSBK -END PGP SIGNATURE-
