Re: [vdr] small patch for vdr.c: continue even with read-only video directory
and it's important for me, that vdr cannot write anything to the video directory. Since this is important for you personaly, you want to change VDR for all users, are you serious? From my personal point of view a read only video directory with an video disk recorder doesn't make much sense. But I wouldn't deny the need, because obviously there a single user out there who does need it, strange enough ... But to change it in a global way like this is IMHO not a way to go. The correct solution would be that any user needing it, must decide and configure something. So, a kind of a switch like an OSD option or even a better way, VDR does check existence of a file in this video directory, e.g. .vdrro, something similar to .nodelete ... === Kind regards fnu ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] small patch for vdr.c: continue even with read-only video directory
On 09.03.2013 21:24, Peter Münster wrote:
Hi Klaus,
Could you please delete line 577 from vdr.c or do something similar to
let vdr continue even with read-only video directory?
vdr runs fine with this patch on my system, and it's important for me,
that vdr cannot write anything to the video directory.
(see also http://pmrb.free.fr/vdr/)
Here a small patch:
--8---cut here---start-8---
--- vdr.c.orig 2013-03-09 21:13:57.846826771 +0100
+++ vdr.c 2013-03-09 21:16:33.503521762 +0100
@@ -574,7 +574,6 @@
if (!DirectoryOk(VideoDirectory, true)) {
fprintf(stderr, vdr: can't access video directory %s\n,
VideoDirectory);
- return 2;
}
// Daemon mode:
--8---cut here---end---8---
If you prefer, I can write a better patch: stop if not readable, warn if
not writable.
I'm afraid we're too close to releasing version 2.0.0 to make such
changes now.
Besides, why don't you just use a writeable video directory and mount
your read-only directory below that? Something like
/video
/video/readonly
Klaus
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] small patch for vdr.c: continue even with read-only video directory
On Sun, Mar 10 2013, fnu wrote: Since this is important for you personaly, you want to change VDR for all users, are you serious? Yes, where is the problem? But to change it in a global way like this is IMHO not a way to go. Did you understand my suggestion? Here again: not writable: warning, not readable: exit. Is that a problem for real-life systems? The correct solution would be that any user needing it, must decide and configure something. So, a kind of a switch like an OSD option or even a better way, VDR does check existence of a file in this video directory, e.g. .vdrro, something similar to .nodelete ... Of course: why use the simple way, when there is a complex one... ;) -- Peter ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] small patch for vdr.c: continue even with read-only video directory
On Sun, Mar 10 2013, Klaus Schmidinger wrote: I'm afraid we're too close to releasing version 2.0.0 to make such changes now. No problem. I would just like to know, if you agree with such a patch (or something more elaborated). Besides, why don't you just use a writeable video directory and mount your read-only directory below that? Something like /video /video/readonly 1. I don't want, that the client VDR can write/record anything to /video. 2. I want my VDR setup to be as simple as possible. (It just works... ;) -- Peter ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] small patch for vdr.c: continue even with read-only video directory
On 10.03.2013 20:40, Peter Münster wrote: On Sun, Mar 10 2013, fnu wrote: But to change it in a global way like this is IMHO not a way to go. Did you understand my suggestion? Here again: not writable: warning, not readable: exit. Is that a problem for real-life systems? For most people read-only is a plain error? Read-only CAN for e.g. happen after an error when the filesystem is mounted with error=read-only (ignoring the runtime-case, when VDR is already running when that happens). And you may not see a warning and only notice that something went wrong after you lost a recording that didn't happen. A not starting VDR is a little more noticable than an apparrently working one that just can't record anything. So if VDR suddenly changes behaviour i can gurantee you that at least 1 person will be bitten by it. As you said you are a single person, would you think it is fair to the person that will losse a recording to have lost it because you wanted a change in behaviour that was only for yourself with no apparent gain for others? -- Matthias ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] small patch for vdr.c: continue even with read-only video directory
On Sun, Mar 10 2013, Matthias Schniedermeyer wrote: Read-only CAN for e.g. happen after an error when the filesystem is mounted with error=read-only Sorry, didn't know about such a configuration option. Therefore I agree with a somewhat more elaborated solution as mentioned by fnu. Or please just forget about my request, since I'm probably the only vdr-user with such a setup. -- Peter ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] small patch for vdr.c: continue even with read-only video directory
not writable: warning, not readable: exit. Is that a problem for real-life systems? A lot of people, myself included, don't like VDR exiting on its' own unless it's completely unavoidable (such as a crash). I'd much rather miss some recordings but have live tv available for everyone to use than have an exited VDR and hearing complaints about the tv not working until I'm able to find out and fix whatever happened to /video access. VDR should only exit when there's no other option or the user actually wants that behavior. Otherwise, it should be avoided. ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
