Re: [vdsm] new API verb: getVersionInfo()

2012-10-21 Thread Dan Kenigsberg
On Sun, Oct 21, 2012 at 02:26:44PM +0200, Peter V. Saveliev wrote: > 21.10.2012 09:23, Dan Kenigsberg kirjoitti: > > > > We should decide NOW on the format of the capabilities «bag», and never > > change it. Testing for a capability is much more reliable than checking > > a version, and rememberi

Re: [vdsm] new API verb: getVersionInfo()

2012-10-21 Thread Peter V. Saveliev
21.10.2012 09:23, Dan Kenigsberg kirjoitti: > We should decide NOW on the format of the capabilities «bag», and never > change it. Testing for a capability is much more reliable than checking > a version, and remembering which version had which capability. > > Dan. Ok, so what will we decide? 1.

Re: [vdsm] new API verb: getVersionInfo()

2012-10-21 Thread Dan Kenigsberg
On Thu, Oct 18, 2012 at 11:12:39PM +0200, Peter V. Saveliev wrote: > … > > Just to be clear: yes, I think, that getVdsCapabilities() can and should > be optimized, but as well it has quite different meaning for different > purposes. > > And what about capabilities «bag» — its format also can be a

Re: [vdsm] new API verb: getVersionInfo()

2012-10-21 Thread Dan Kenigsberg
On Fri, Oct 19, 2012 at 09:47:25AM +0200, Vinzenz Feenstra wrote: > On 10/18/2012 10:11 PM, Saggi Mizrahi wrote: > >I don't see how pyinotify is even related to storage stats. > Well I am not sure where I would have mentioned storage statistics. > >It doesn't work with NFS and is a bit flaky when i

Re: [vdsm] new API verb: getVersionInfo()

2012-10-19 Thread Vinzenz Feenstra
the proposal to fix it. - Original Message - From: "Vinzenz Feenstra" To: "Itamar Heim" Cc: "Saggi Mizrahi" , "Michal Skrivanek" , vdsm-devel@lists.fedorahosted.org Sent: Thursday, October 18, 2012 3:15:47 PM Subject: Re: [vdsm] new API verb: getVersio

Re: [vdsm] new API verb: getVersionInfo()

2012-10-18 Thread Peter V. Saveliev
… Just to be clear: yes, I think, that getVdsCapabilities() can and should be optimized, but as well it has quite different meaning for different purposes. And what about capabilities «bag» — its format also can be a subject of a change (e.g. long int bitmask ⇒ list of literals), but the version

Re: [vdsm] new API verb: getVersionInfo()

2012-10-18 Thread Adam Litke
gt; > Cc: vdsm-devel@lists.fedorahosted.org, "Michal Skrivanek" > > Sent: Thursday, October 18, 2012 4:38:16 AM Subject: > > Re: [vdsm] new API verb: getVersionInfo() > > > > On Wed, Oct 17, 2012 at 10:07:43AM -0500, Adam Litke wrote: > > > Thanks f

Re: [vdsm] new API verb: getVersionInfo()

2012-10-18 Thread Peter V. Saveliev
18.10.2012 18:03, Saggi Mizrahi kirjoitti: > currently getVdsCaps() does a lot of unrelated things most of them have no > relation to capabilites. > This was done because of HTTP overhead. Instead of calling multiple commands > we will call one that does everything. Can I please make a small no

Re: [vdsm] new API verb: getVersionInfo()

2012-10-18 Thread Saggi Mizrahi
t; , "Michal Skrivanek" > , > vdsm-devel@lists.fedorahosted.org > Sent: Thursday, October 18, 2012 3:15:47 PM > Subject: Re: [vdsm] new API verb: getVersionInfo() > > On 10/18/2012 08:34 PM, Itamar Heim wrote: > > On 10/18/2012 06:03 PM, Saggi Mizrahi wrote: > >&

Re: [vdsm] new API verb: getVersionInfo()

2012-10-18 Thread Vinzenz Feenstra
On 10/18/2012 08:34 PM, Itamar Heim wrote: On 10/18/2012 06:03 PM, Saggi Mizrahi wrote: currently getVdsCaps() does a lot of unrelated things most of them have no relation to capabilites. This was done because of HTTP overhead. Instead of calling multiple commands we will call one that does eve

Re: [vdsm] new API verb: getVersionInfo()

2012-10-18 Thread Itamar Heim
On 10/18/2012 06:03 PM, Saggi Mizrahi wrote: currently getVdsCaps() does a lot of unrelated things most of them have no relation to capabilites. This was done because of HTTP overhead. Instead of calling multiple commands we will call one that does everything. I agree with the suggestion that

Re: [vdsm] new API verb: getVersionInfo()

2012-10-18 Thread Saggi Mizrahi
-- > From: "Dan Kenigsberg" > To: "Adam Litke" > Cc: vdsm-devel@lists.fedorahosted.org, "Michal Skrivanek" > > Sent: Thursday, October 18, 2012 4:38:16 AM > Subject: Re: [vdsm] new API verb: getVersionInfo() > > On Wed, Oct 17, 2012 at 10:07:43AM

Re: [vdsm] new API verb: getVersionInfo()

2012-10-18 Thread Dan Kenigsberg
On Wed, Oct 17, 2012 at 10:07:43AM -0500, Adam Litke wrote: > Thanks for posting your idea on the list here. I like the idea of a more > fine-grained version query API. getVdsCapabilities has become too much of a > catch-all and I agree that something lighter is useful. I do think vdsm will > wa

Re: [vdsm] new API verb: getVersionInfo()

2012-10-17 Thread Adam Litke
Thanks for posting your idea on the list here. I like the idea of a more fine-grained version query API. getVdsCapabilities has become too much of a catch-all and I agree that something lighter is useful. I do think vdsm will want to add a real capabilities mechanism and it could probably go her

[vdsm] new API verb: getVersionInfo()

2012-10-17 Thread Peter V. Saveliev
… New verb proposal: getVersionInfo() Background Right now VDSM has only one possibility to discover the peer VDSM version — it is to call getVdsCapabilities(). All would be nice, but the verb does a lot of stuff, including disk I/O (rpm data query). It is a serious issue for high-loaded