Re: [vdsm] VDSM API/clientIF instance design issue

2012-06-01 Thread Dan Kenigsberg
On Fri, Jun 01, 2012 at 01:59:25PM +0800, Mark Wu wrote: On 05/31/2012 09:08 PM, Dan Kenigsberg wrote: On Thu, May 31, 2012 at 09:03:37PM +0800, Mark Wu wrote: On 05/30/2012 11:01 PM, Dan Kenigsberg wrote: On Wed, May 30, 2012 at 10:49:29PM +0800, Mark Wu wrote: Hi Guys, Recently, I has

Re: [vdsm] VDSM API/clientIF instance design issue

2012-05-31 Thread Dan Kenigsberg
On Thu, May 31, 2012 at 09:03:37PM +0800, Mark Wu wrote: On 05/30/2012 11:01 PM, Dan Kenigsberg wrote: On Wed, May 30, 2012 at 10:49:29PM +0800, Mark Wu wrote: Hi Guys, Recently, I has been working on integrate MOM into VDSM. MOM needs to use VDSM API to interact with it. But currently,

Re: [vdsm] VDSM API/clientIF instance design issue

2012-05-31 Thread Adam Litke
On Thu, May 31, 2012 at 04:08:52PM +0300, Dan Kenigsberg wrote: On Thu, May 31, 2012 at 09:03:37PM +0800, Mark Wu wrote: On 05/30/2012 11:01 PM, Dan Kenigsberg wrote: On Wed, May 30, 2012 at 10:49:29PM +0800, Mark Wu wrote: Hi Guys, Recently, I has been working on integrate MOM into

Re: [vdsm] VDSM API/clientIF instance design issue

2012-05-31 Thread Mark Wu
On 05/31/2012 09:08 PM, Dan Kenigsberg wrote: On Thu, May 31, 2012 at 09:03:37PM +0800, Mark Wu wrote: On 05/30/2012 11:01 PM, Dan Kenigsberg wrote: On Wed, May 30, 2012 at 10:49:29PM +0800, Mark Wu wrote: Hi Guys, Recently, I has been working on integrate MOM into VDSM. MOM needs to use

Re: [vdsm] VDSM API/clientIF instance design issue

2012-05-30 Thread Dan Kenigsberg
On Wed, May 30, 2012 at 10:49:29PM +0800, Mark Wu wrote: Hi Guys, Recently, I has been working on integrate MOM into VDSM. MOM needs to use VDSM API to interact with it. But currently, it requires the instance of clientIF to use vdsm API. Passing clientIF to MOM is not a good choice

Re: [vdsm] VDSM API/clientIF instance design issue

2012-05-30 Thread Saggi Mizrahi
If you don't want to add it in a parameter then you already suspect that you are doing something wrong. Using a singleton instead of passing a parameter doesn't make the dependency not there. It's just obscures it. I might not fully understand what you want to do but I think what you want is

Re: [vdsm] VDSM API/clientIF instance design issue

2012-05-30 Thread David Jaša
Do I get it right that host-side of MOM communicates with guest side over network interface? If so, why isn't it following best practices of qemu/kvm world and why it doesn't communicate over its own virtio-serial port? David Mark Wu píše v St 30. 05. 2012 v 22:49 +0800: Hi Guys, Recently,