Change in vdsm[master]: Fix detachStorageDomain for the ISO domains

2012-07-19 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: Fix detachStorageDomain for the ISO domains .. Patch Set 2: (1 inline comment) File

Change in vdsm[master]: Fix detachStorageDomain for the ISO domains

2012-07-19 Thread mgoldboi
Moran Goldboim has posted comments on this change. Change subject: Fix detachStorageDomain for the ISO domains .. Patch Set 2: Verified Verified on CI test the changes in vdsm/storage/sp.py -- To view, visit

Change in vdsm[master]: Fix detachStorageDomain for the ISO domains

2012-07-19 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Fix detachStorageDomain for the ISO domains .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6445 To unsubscribe, visit

Change in vdsm[master]: Fix detachStorageDomain for the ISO domains

2012-07-19 Thread ilvovsky
Igor Lvovsky has submitted this change and it was merged. Change subject: Fix detachStorageDomain for the ISO domains .. Fix detachStorageDomain for the ISO domains When detaching an ISO domain we should acquire the host id

Change in vdsm[master]: Split getNetworksAndVlansForBonding to handle bridge and bri...

2012-07-19 Thread ilvovsky
Igor Lvovsky has posted comments on this change. Change subject: Split getNetworksAndVlansForBonding to handle bridge and bridgeless networks .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/6143 To

Change in vdsm[master]: Refactoring and optimization of _addNetworkValidation

2012-07-19 Thread ilvovsky
Igor Lvovsky has posted comments on this change. Change subject: Refactoring and optimization of _addNetworkValidation .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/6383 To unsubscribe, visit

Change in vdsm[master]: Continue refactoring _addNetworkValidation

2012-07-19 Thread ilvovsky
Igor Lvovsky has posted comments on this change. Change subject: Continue refactoring _addNetworkValidation .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/6416 To unsubscribe, visit

Change in vdsm[master]: Basic tests for the tc module

2012-07-19 Thread roman
Roman Fenkhuber has posted comments on this change. Change subject: Basic tests for the tc module .. Patch Set 7: different kernel versions seem to have different learning intervalls for bridges. So the bridge did enter the

Change in vdsm[master]: Refactoring and optimization of _addNetworkValidation

2012-07-19 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Refactoring and optimization of _addNetworkValidation .. Patch Set 2: Verified; Looks good to me, but someone else must approve Tested with my new unit

Change in vdsm[master]: Fix typo (change socekt to socket) in libvirtvm.py and vm.py

2012-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix typo (change socekt to socket) in libvirtvm.py and vm.py .. Fix typo (change socekt to socket) in libvirtvm.py and vm.py Change-Id:

Change in vdsm[master]: Fix the KeyError exception if no 'acpiEnable' key in vm.conf...

2012-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix the KeyError exception if no 'acpiEnable' key in vm.conf. .. Fix the KeyError exception if no 'acpiEnable' key in vm.conf. When creating a VM,if

Change in vdsm[master]: Make domainMonitor.py for PEP8 compliance

2012-07-19 Thread mars
Bing Bu Cao has uploaded a new change for review. Change subject: Make domainMonitor.py for PEP8 compliance .. Make domainMonitor.py for PEP8 compliance After applied the commit 47b78ec20f82f317c16d8dc719bc12f1ff087428, one

Change in vdsm[master]: Split getNetworksAndVlansForBonding to handle bridge and bri...

2012-07-19 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Split getNetworksAndVlansForBonding to handle bridge and bridgeless networks .. Patch Set 4: Verified; Looks good to me, but someone else must approve

Change in vdsm[master]: BZ#784931 - Fixing race condition in deactivateSD().

2012-07-19 Thread Haim Ateya
Haim Ateya has posted comments on this change. Change subject: BZ#784931 - Fixing race condition in deactivateSD(). .. Patch Set 4: Verified per dpaikov validation, setting the verified field. -- To view, visit

Change in vdsm[master]: Add local storage xmlrpc functional test

2012-07-19 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Add local storage xmlrpc functional test .. Patch Set 3: i try to run those tests as developer (with make check). without running vdsm-bootstrap process i

Change in vdsm[master]: BZ#832227: vdsm-reg.conf: change vdc_host_port

2012-07-19 Thread barumuga
Bala.FA has posted comments on this change. Change subject: BZ#832227: vdsm-reg.conf: change vdc_host_port .. Patch Set 7: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5367 To

Change in vdsm[master]: Fix - bz #823565 - Gluster - Backend: Any failure of gluster...

2012-07-19 Thread barumuga
Bala.FA has posted comments on this change. Change subject: Fix - bz #823565 - Gluster - Backend: Any failure of gluster cli is not thrown as error dictionary to engine .. Patch Set 3: (3 inline comments)

Change in vdsm[master]: Make domainMonitor.py for PEP8 compliance

2012-07-19 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Make domainMonitor.py for PEP8 compliance .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: skip testPersistentBackup test, if 'vdsm' account is not cre...

2012-07-19 Thread shaohef
ShaoHe Feng has uploaded a new change for review. Change subject: skip testPersistentBackup test, if 'vdsm' account is not created .. skip testPersistentBackup test, if 'vdsm' account is not created In configNetwork moudle,

Change in vdsm[master]: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf

2012-07-19 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: BZ#837836 Change tpgt variable to identically None

2012-07-19 Thread ewarszaw
Eduardo has posted comments on this change. Change subject: BZ#837836 Change tpgt variable to identically None .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6367 To

Change in vdsm[master]: Change exception thrown by validateQemuReadable

2012-07-19 Thread smizrahi
Saggi Mizrahi has uploaded a new change for review. Change subject: Change exception thrown by validateQemuReadable .. Change exception thrown by validateQemuReadable Serializing obejcts that aren't canonical might cause issue

Change in vdsm[master]: Basic tests for the tc module

2012-07-19 Thread roman
Roman Fenkhuber has posted comments on this change. Change subject: Basic tests for the tc module .. Patch Set 9: (2 inline comments) So now this should be it. It turned out, that patch 8 did not work if the pc had no IP

Change in vdsm[master]: Support sanlock killpath for the SPM

2012-07-19 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: Support sanlock killpath for the SPM .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6385 To

Change in vdsm[master]: BZ#831528, BZ#834008, BZ#829037 - Fix validation for inter-n...

2012-07-19 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: BZ#831528, BZ#834008, BZ#829037 - Fix validation for inter-networks compatibility .. Patch Set 3: (1 inline comment) Question about a test case I

Change in vdsm[master]: Make scratchpad/before_vm_start.py compliant to pep8

2012-07-19 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: Make scratchpad/before_vm_start.py compliant to pep8 .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4578 To unsubscribe,

Change in vdsm[master]: Make before_vm_migrate_source.py compliant to pep8

2012-07-19 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: Make before_vm_migrate_source.py compliant to pep8 .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4579 To unsubscribe,

Change in vdsm[master]: Make vhostmd/after_vm_destroy.py compliant to pep8

2012-07-19 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: Make vhostmd/after_vm_destroy.py compliant to pep8 .. Patch Set 2: I would prefer that you didn't submit this (2 inline comments) I know it's in the original,

Change in vdsm[master]: Fixing pep8 in vdsm/hooks.py

2012-07-19 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: Fixing pep8 in vdsm/hooks.py .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4537 To unsubscribe, visit

Change in vdsm[master]: Fixing pep8 in vdsm/storage/iscsiadm.py

2012-07-19 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: Fixing pep8 in vdsm/storage/iscsiadm.py .. Patch Set 1: Looks good to me, but someone else must approve (1 inline comment)

Change in vdsm[master]: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf

2012-07-19 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: Change exception thrown by validateQemuReadable

2012-07-19 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: Change exception thrown by validateQemuReadable .. Patch Set 1: I would prefer that you didn't submit this (3 inline comments)

Change in vdsm[master]: Basic tests for the tc module

2012-07-19 Thread roman
Roman Fenkhuber has posted comments on this change. Change subject: Basic tests for the tc module .. Patch Set 10: No more problems with ip addresses. I think this is it. -- To view, visit http://gerrit.ovirt.org/6225 To

Change in vdsm[master]: Extend the range of Vm's niceness to allow increasing cpu sh...

2012-07-19 Thread Ryan Harper
Ryan Harper has posted comments on this change. Change subject: Extend the range of Vm's niceness to allow increasing cpu shares .. Patch Set 1: I would prefer that you didn't submit this If we're going to modify how we

Change in vdsm[master]: BZ#832227: vdsm-reg.conf: change vdc_host_port

2012-07-19 Thread jboggs
Joey Boggs has posted comments on this change. Change subject: BZ#832227: vdsm-reg.conf: change vdc_host_port .. Patch Set 7: Verified; Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: BZ#832227: vdsm-reg.conf: change vdc_host_port

2012-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#832227: vdsm-reg.conf: change vdc_host_port .. Patch Set 7: (3 inline comments) argh, how could it be that my comments have not been posted? I see that the

Change in vdsm[master]: BZ#832227: vdsm-reg.conf: change vdc_host_port

2012-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#832227: vdsm-reg.conf: change vdc_host_port .. Patch Set 7: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/5367 To

Change in vdsm[master]: Related to BZ#784931 - Removing the unused useCache paramete...

2012-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Related to BZ#784931 - Removing the unused useCache parameter. .. Patch Set 1: Verified; No score It is sad that the commit message was not fixed for almost 2

Change in vdsm[master]: Related to BZ#784931 - Removing the unused useCache paramete...

2012-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Related to BZ#784931 - Removing the unused useCache parameter. .. Related to BZ#784931 - Removing the unused useCache parameter. Intentionally (A.B.)

Change in vdsm[master]: BZ#784931 - Restore SD.validate() semantics.

2012-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#784931 - Restore SD.validate() semantics. .. Patch Set 2: Verified Copying Paikov's V+1 to here. -- To view, visit http://gerrit.ovirt.org/4955 To

Change in vdsm[master]: BZ#784931 - Restore SD.validate() semantics.

2012-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#784931 - Restore SD.validate() semantics. .. BZ#784931 - Restore SD.validate() semantics. dom.validate() should check the domain without any aging

Change in vdsm[master]: BZ#784931 - Fixing race condition in deactivateSD().

2012-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#784931 - Fixing race condition in deactivateSD(). .. Patch Set 5: Verified; Looks good to me, approved copying score, even though I haven't even look inside

Change in vdsm[master]: BZ#784931 - Fixing race condition in deactivateSD().

2012-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#784931 - Fixing race condition in deactivateSD(). .. BZ#784931 - Fixing race condition in deactivateSD(). Change-Id:

Change in vdsm[master]: Refactoring and optimization of _addNetworkValidation

2012-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Refactoring and optimization of _addNetworkValidation .. Refactoring and optimization of _addNetworkValidation Change-Id:

Change in vdsm[master]: Refactoring and optimization of _addNetworkValidation

2012-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Refactoring and optimization of _addNetworkValidation .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6383 To unsubscribe,

Change in vdsm[master]: Split getNetworksAndVlansForBonding to handle bridge and bri...

2012-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Split getNetworksAndVlansForBonding to handle bridge and bridgeless networks .. Patch Set 4: Looks good to me, approved -- To view, visit

Change in vdsm[master]: Split getNetworksAndVlansForBonding to handle bridge and bri...

2012-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Split getNetworksAndVlansForBonding to handle bridge and bridgeless networks .. Split getNetworksAndVlansForBonding to handle bridge and bridgeless

Change in vdsm[master]: Extend the range of Vm's niceness to allow increasing cpu sh...

2012-07-19 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Extend the range of Vm's niceness to allow increasing cpu shares .. Patch Set 1: Any idea on this one? http://gerrit.ovirt.org/#/c/6290 -- To view, visit

Change in vdsm[master]: Make vhostmd/after_vm_destroy.py compliant to pep8

2012-07-19 Thread wenyi
Wenyi Gao has posted comments on this change. Change subject: Make vhostmd/after_vm_destroy.py compliant to pep8 .. Patch Set 2: (2 inline comments) Thanks Saggi for reviewing the patches. Please see my inline comments.

Change in vdsm[master]: Make vhostmd/before_vm_start.py compliant to pep8

2012-07-19 Thread wenyi
Wenyi Gao has posted comments on this change. Change subject: Make vhostmd/before_vm_start.py compliant to pep8 .. Patch Set 2: Verified Built and installed, works normal. -- To view, visit http://gerrit.ovirt.org/4581 To

Change in vdsm[master]: Make before_vm_migrate_source.py compliant to pep8

2012-07-19 Thread wenyi
Wenyi Gao has posted comments on this change. Change subject: Make before_vm_migrate_source.py compliant to pep8 .. Patch Set 2: Verified Built and installed, works normally. -- To view, visit http://gerrit.ovirt.org/4579 To

Change in vdsm[master]: Make scratchpad/before_vm_start.py compliant to pep8

2012-07-19 Thread wenyi
Wenyi Gao has posted comments on this change. Change subject: Make scratchpad/before_vm_start.py compliant to pep8 .. Patch Set 2: Verified Built and installed, works normally. -- To view, visit http://gerrit.ovirt.org/4578

Change in vdsm[master]: Make scratchpad/after_vm_destroy.py compliant to pep8

2012-07-19 Thread wenyi
Wenyi Gao has posted comments on this change. Change subject: Make scratchpad/after_vm_destroy.py compliant to pep8 .. Patch Set 2: Verified Built and installed, works normally. -- To view, visit http://gerrit.ovirt.org/4577

Change in vdsm[master]: Fixing pep8 in vdsm/storage/iscsiadm.py

2012-07-19 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Fixing pep8 in vdsm/storage/iscsiadm.py .. Patch Set 1: Looks good to me, but someone else must approve (1 inline comment)

Change in vdsm[master]: Fixing pep8 in vdsm/storage/iscsiadm.py

2012-07-19 Thread mars
Bing Bu Cao has abandoned this change. Change subject: Fixing pep8 in vdsm/storage/iscsiadm.py .. Patch Set 1: Abandoned The another series of patches include this one have been merged. -- To view, visit

Change in vdsm[master]: change the code style of volume.py for PEP8 compliance

2012-07-19 Thread shaohef
ShaoHe Feng has abandoned this change. Change subject: change the code style of volume.py for PEP8 compliance .. Patch Set 4: Abandoned it was merged in pep8cleaning branch. -- To view, visit http://gerrit.ovirt.org/4496 To

Change in vdsm[master]: change the code style of libvirtev.py for PEP8 compliance

2012-07-19 Thread shaohef
ShaoHe Feng has abandoned this change. Change subject: change the code style of libvirtev.py for PEP8 compliance .. Patch Set 1: Abandoned it was merged in pep8cleaning branch. -- To view, visit http://gerrit.ovirt.org/4510

Change in vdsm[master]: change the code style of multipath.py for PEP8 compliance

2012-07-19 Thread shaohef
ShaoHe Feng has abandoned this change. Change subject: change the code style of multipath.py for PEP8 compliance .. Patch Set 2: Abandoned it was merged in pep8cleaning branch. -- To view, visit http://gerrit.ovirt.org/4511

Change in vdsm[master]: change the code style of devicemapper.py for PEP8 compliance

2012-07-19 Thread shaohef
ShaoHe Feng has abandoned this change. Change subject: change the code style of devicemapper.py for PEP8 compliance .. Patch Set 1: Abandoned it was merged in pep8cleaning branch. -- To view, visit

Change in vdsm[master]: change the code style of SecureXMLRPCServer.py for PEP8 comp...

2012-07-19 Thread shaohef
ShaoHe Feng has abandoned this change. Change subject: change the code style of SecureXMLRPCServer.py for PEP8 compliance .. Patch Set 2: Abandoned it was merged in pep8cleaning branch. -- To view, visit

Change in vdsm[master]: change the code style of BindingXMLRPC.py for PEP8 complianc...

2012-07-19 Thread shaohef
ShaoHe Feng has abandoned this change. Change subject: change the code style of BindingXMLRPC.py for PEP8 compliance .. Patch Set 1: Abandoned it was merged in pep8cleaning branch. -- To view, visit

Change in vdsm[master]: change the code style of resourceFactories.py for PEP8 compl...

2012-07-19 Thread shaohef
ShaoHe Feng has abandoned this change. Change subject: change the code style of resourceFactories.py for PEP8 compliance .. Patch Set 2: Abandoned it was merged in pep8cleaning branch. -- To view, visit

Change in vdsm[master]: change the code style of persistentDict.py for PEP8 complian...

2012-07-19 Thread shaohef
ShaoHe Feng has abandoned this change. Change subject: change the code style of persistentDict.py for PEP8 compliance .. Patch Set 1: Abandoned it was merged in pep8cleaning branch. -- To view, visit

Change in vdsm[master]: change the code style of before_vm_start.py for PEP8 complia...

2012-07-19 Thread shaohef
ShaoHe Feng has abandoned this change. Change subject: change the code style of before_vm_start.py for PEP8 compliance .. Patch Set 1: Abandoned it was merged in pep8cleaning branch. -- To view, visit

Change in vdsm[master]: change startup process for vdsm and supervdsm

2012-07-19 Thread lvroyce
Royce Lv has posted comments on this change. Change subject: change startup process for vdsm and supervdsm .. Patch Set 7: verified: (1)start restart service (2)kill vdsm, service automatically restart (3)kill supervdsm,