Nir Soffer has posted comments on this change.
Change subject: netlink: Introduce socket pool
..
Patch Set 2:
(5 comments)
http://gerrit.ovirt.org/#/c/24603/2/lib/vdsm/netlink.py
File lib/vdsm/netlink.py:
Line 84:
Line 85:
Francesco Romani has posted comments on this change.
Change subject: clientif: add initial tests
..
Patch Set 1: Verified+1
old code passes tests;
--
To view, visit http://gerrit.ovirt.org/24614
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientif: add initial tests
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7296/ :
Yaniv Bronhaim has posted comments on this change.
Change subject: introducing capability to stream data to image
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/24597
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: introducing capability to stream data to image
..
Patch Set 3:
thanks. now just verify on ovirt-3.4 branch
--
To view, visit http://gerrit.ovirt.org/24597
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientif: add initial tests
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7297/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: clientif: add initial tests
..
Patch Set 1:
(4 comments)
Looks great! Can you address the last few cleanups?
Liron Ar has posted comments on this change.
Change subject: introducing capability to stream data to image
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/24597
To unsubscribe, visit
Itamar Heim has posted comments on this change.
Change subject: Schema: Typemap changes
..
Patch Set 1:
ping?
--
To view, visit http://gerrit.ovirt.org/23375
To unsubscribe, visit http://gerrit.ovirt.org/settings
Itamar Heim has posted comments on this change.
Change subject: avoid redundant domain produce() in createStoragePool
..
Patch Set 3:
ping?
--
To view, visit http://gerrit.ovirt.org/7347
To unsubscribe, visit
Itamar Heim has posted comments on this change.
Change subject: [WIP]add simple balloon functional testcase
..
Patch Set 2:
ping?
--
To view, visit http://gerrit.ovirt.org/12820
To unsubscribe, visit
Itamar Heim has posted comments on this change.
Change subject: Add functions getNetworkList and getNetworkInfo to API
..
Patch Set 4:
ping
--
To view, visit http://gerrit.ovirt.org/2664
To unsubscribe, visit
Itamar Heim has posted comments on this change.
Change subject: Misc storage exception class name style
..
Patch Set 3:
ping
--
To view, visit http://gerrit.ovirt.org/8847
To unsubscribe, visit
Itamar Heim has posted comments on this change.
Change subject: [WIP]add simple balloon functional testcase
..
Patch Set 2:
ping
--
To view, visit http://gerrit.ovirt.org/12820
To unsubscribe, visit
Itamar Heim has posted comments on this change.
Change subject: avoid redundant domain produce() in createStoragePool
..
Patch Set 3:
ping
--
To view, visit http://gerrit.ovirt.org/7347
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: clientif: add initial tests
..
Patch Set 1:
(4 comments)
http://gerrit.ovirt.org/#/c/24614/1/tests/clientifTests.py
File tests/clientifTests.py:
Line 24:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientif: add initial tests
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7298/ : SUCCESS
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: introducing capability to stream data to image
..
introducing capability to stream data to image
This patch introduces the a new capabaility to vdsm
Nir Soffer has posted comments on this change.
Change subject: clientif: add initial tests
..
Patch Set 1:
(2 comments)
How to monkeypatch clientIF.supervdsm.
http://gerrit.ovirt.org/#/c/24614/1/tests/clientifTests.py
File
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 8: -Verified
--
To view, visit http://gerrit.ovirt.org/22928
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: clientif: add initial tests
..
Patch Set 3:
(1 comment)
Looks good, except the way you modify clientIF.supervdsm, which is not safe -
this will break other tests
Vinzenz Feenstra has uploaded a new change for review.
Change subject: GuestIF Refactoring
..
GuestIF Refactoring
Change-Id: Ib357d770a26ef1dc80b89a32bf6808551a7d622d
Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com
---
M
oVirt Jenkins CI Server has posted comments on this change.
Change subject: GuestIF Refactoring
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7299/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: GuestIF Refactoring
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7300/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: clientif: add initial tests
..
Patch Set 3:
Nir, thanks for the suggestion about MonkeyPatch suggestion. Looks like it is
the best way to go.
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: test: unstable jsonrpc tests
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7301/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: tests: add initial tests for clientIF
..
Patch Set 3:
Patch set 4: moved to MonkeyPatch in order to do not pollute the environment
for the other tests.
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: add initial tests for clientIF
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7302/ : SUCCESS
Assaf Muller has uploaded a new change for review.
Change subject: Fix defaultRoute handling
..
Fix defaultRoute handling
defaultRoute wasn't being past correctly to objectivizeNetwork,
so that defaultRoute was always None
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix defaultRoute handling
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7303/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix defaultRoute handling
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7304/ : FAILURE
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix defaultRoute handling
..
Patch Set 2: Code-Review+1
I'd love if there was a check added to a functional test for this.
--
To view, visit
Moti Asayag has posted comments on this change.
Change subject: Fix defaultRoute handling
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/24631/2/vdsm/configNetwork.py
File vdsm/configNetwork.py:
Line 278:
Line 279:
Francesco Romani has uploaded a new change for review.
Change subject: clientIF: prepareVolumePath payload cleanup
..
clientIF: prepareVolumePath payload cleanup
the prepareVolumePath code path for cdrom/floppy
images is
Francesco Romani has abandoned this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Abandoned
Patch fully splitted. refactoring: http://gerrit.ovirt.org/24636
tests: http://gerrit.ovirt.org/#/c/24614/
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix defaultRoute handling
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/24631/2/vdsm/configNetwork.py
File vdsm/configNetwork.py:
Line 278:
Nir Soffer has posted comments on this change.
Change subject: tests: add initial tests for clientIF
..
Patch Set 4: Code-Review+1
I would give you couple of +, but I have only one :)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7305/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7306/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 2:
Does it pass the tests?
--
To view, visit http://gerrit.ovirt.org/24636
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 2:
patch set 2 pass the tests.
patch set 1 had a check which raised a different exception
oVirt Jenkins CI Server has posted comments on this change.
Change subject: GuestIF Refactoring
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7307/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24636
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24636/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 327:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: StoragePool connect missing default value
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7308/
Francesco Romani has posted comments on this change.
Change subject: tests: add initial tests for clientIF
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/24614
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: test: declare unstable test as broken
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24645
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: test: declare unstable test as broken
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7309/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: Reload daemon file after each install
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/24535
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Ensure that XMLRPC threads do not delay shutdown
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/24555
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: recover must finish with libvirt connection
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7310/ : FAILURE
Adam Litke has posted comments on this change.
Change subject: Misc storage exception class name style
..
Patch Set 3: Verified+1
I am willing to mark this Verified by inspection. I did a grep through the
sources and there
Adam Litke has posted comments on this change.
Change subject: Misc storage exception class name style
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/8847
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: test: unstable jsonrpc tests
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24624/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate:
Francesco Romani has posted comments on this change.
Change subject: GuestIF Refactoring
..
Patch Set 3:
(3 comments)
http://gerrit.ovirt.org/#/c/24618/3/vdsm/guestIF.py
File vdsm/guestIF.py:
Line 51: self.log =
Antoni Segura Puimedon has posted comments on this change.
Change subject: netlink: Introduce socket pool
..
Patch Set 2:
(4 comments)
http://gerrit.ovirt.org/#/c/24603/2/lib/vdsm/netlink.py
File lib/vdsm/netlink.py:
Line
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 4: Code-Review-1
(1 comment)
Vinzenz Feenstra has posted comments on this change.
Change subject: GuestIF Refactoring
..
Patch Set 3:
(3 comments)
http://gerrit.ovirt.org/#/c/24618/3/vdsm/guestIF.py
File vdsm/guestIF.py:
Line 51: self.log =
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: Introduce socket pool
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7311/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: GuestIF Refactoring
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7313/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: test: unstable jsonrpc tests
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7314/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 4: Verified-1
Build Failed
Itamar Heim has abandoned this change.
Change subject: Add functions getNetworkList and getNetworkInfo to API
..
Abandoned
no activity - revive if still relevant
--
To view, visit http://gerrit.ovirt.org/2664
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: dump the core of a VM
..
Patch Set 18:
(2 comments)
http://gerrit.ovirt.org/#/c/7329/18/vdsm/API.py
File vdsm/API.py:
Line 286:
Francesco Romani has posted comments on this change.
Change subject: get the status of core dump
..
Patch Set 12: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/11131
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: get the status of core dump
..
Patch Set 12:
(1 comment)
http://gerrit.ovirt.org/#/c/11131/12/vdsm_api/vdsmapi-schema.json
File
Francesco Romani has posted comments on this change.
Change subject: get the status of core dump
..
Patch Set 12: -Code-Review
--
To view, visit http://gerrit.ovirt.org/11131
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 5: Verified-1
Build Failed
Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 5: Code-Review-1
(1 comment)
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/5/lib/vdsm/netinfo.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: Fix defaultRoute handling
..
Patch Set 2: Verified+1 Code-Review+2
verified that now defaultRoute=True translates to DEFROUTE=yes in the ifcfg
file,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix defaultRoute handling
..
Fix defaultRoute handling
defaultRoute wasn't being past correctly to objectivizeNetwork,
so that defaultRoute was always
Hello Antoni Segura Puimedon, Assaf Muller,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/24677
to review the following change.
Change subject: Fix defaultRoute handling
..
Fix defaultRoute
Assaf Muller has posted comments on this change.
Change subject: Fix defaultRoute handling
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/24677
To unsubscribe, visit http://gerrit.ovirt.org/settings
Assaf Muller has posted comments on this change.
Change subject: Fix defaultRoute handling
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24677
To unsubscribe, visit http://gerrit.ovirt.org/settings
Federico Simoncelli has posted comments on this change.
Change subject: avoid redundant domain produce() in createStoragePool
..
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/7347/3/vdsm/storage/sp.py
Nir Soffer has posted comments on this change.
Change subject: netlink: Introduce socket pool
..
Patch Set 3:
(2 comments)
Nice except the unneeded possibly not thread safe lazy initialization.
But I think the biggest issue
Nir Soffer has posted comments on this change.
Change subject: test: unstable jsonrpc tests
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/24624/2/tests/jsonRpcTests.py
File tests/jsonRpcTests.py:
Line 103:
Yaniv Bronhaim has posted comments on this change.
Change subject: Fix defaultRoute handling
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/24677
To unsubscribe, visit http://gerrit.ovirt.org/settings
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Fix defaultRoute handling
..
Fix defaultRoute handling
defaultRoute wasn't being past correctly to objectivizeNetwork,
so that defaultRoute was always
Nir Soffer has posted comments on this change.
Change subject: client: add the domainsMap in connectStoragePool
..
Patch Set 2:
(3 comments)
http://gerrit.ovirt.org/#/c/24491/2/client/vdsClient.py
File client/vdsClient.py:
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 5:
(2 comments)
http://gerrit.ovirt.org/#/c/24456/5/lib/vdsm/netinfo.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 6: Verified-1
Build Failed
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/7/lib/vdsm/netinfo.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 7: Verified-1
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 7: Code-Review-1
(4 comments)
http://gerrit.ovirt.org/#/c/24456/7/lib/vdsm/netinfo.py
Dan Kenigsberg has submitted this change and it was merged.
Change subject: avoid redundant domain produce() in createStoragePool
..
avoid redundant domain produce() in createStoragePool
As the domains in hsm.createStoragePool
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Misc storage exception class name style
..
Misc storage exception class name style
All the misc storage exception class name should
be prefixed with
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/7/lib/vdsm/netinfo.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: net_scale: Allow NetInfo update just the devices
..
Patch Set 6: Code-Review-1
(2 comments)
two minor comments
Dan Kenigsberg has posted comments on this change.
Change subject: net_scale: Don't instantiate NetInfo needlessly
..
Patch Set 5: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/23576/5/vdsm/configNetwork.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: remove code duplication between nics, bridges, bonds
and vlans
..
Patch Set 4: Code-Review-1
(2 comments)
Nice! (one little comment, though)
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: pass _netinfo to addNetwork
..
Patch Set 4:
Lovely. Commit 88acbb1f added _netinfo to addNetwork() with no one passing it
ever since.
--
To view,
Dan Kenigsberg has restored this change.
Change subject: confNet: ifcfg's VLAN should be set only on vlan cfg
..
Restored
it's very partial, but let us restore it.
--
To view, visit http://gerrit.ovirt.org/7411
To
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: avoid needless modulu
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/24193
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sampling: avoid needless modulu
..
sampling: avoid needless modulu
Since Linux jiffies counters wrap at 32 bits, we take modulu 2 ** 32
when we
oVirt Jenkins CI Server has posted comments on this change.
Change subject: confNet: ifcfg's VLAN should be set only on vlan cfg
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7318/ :
Dan Kenigsberg has posted comments on this change.
Change subject: caps: Collect numa information
..
Patch Set 5: Code-Review-1
(5 comments)
Welcome, Xiaolei Shi. I believe that your suggested API needs more discussion.
Dan Kenigsberg has posted comments on this change.
Change subject: tests: add initial tests for clientIF
..
Patch Set 4: Code-Review+2
Trusting you guys!
--
To view, visit http://gerrit.ovirt.org/24614
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: add initial tests for clientIF
..
tests: add initial tests for clientIF
This patch adds the tests for prepareVolumePath,
and prepares the
1 - 100 of 101 matches
Mail list logo
