Change in vdsm[master]: migration: wait properly for migration to begin

2016-07-11 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: migration: wait properly for migration to begin .. Patch Set 9: Verified+1 done -- To view, visit https://gerrit.ovirt.org/60073 To unsubscribe, visit

Change in vdsm[master]: migration: wait properly for migration to begin

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: wait properly for migration to begin .. Patch Set 9: * #1354344::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1354344::OK, public bug *

Change in vdsm[master]: Modify reports to metrics

2016-07-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Modify reports to metrics .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 450:

Change in vdsm[ovirt-4.0]: build: enable vdsm-gluster build

2016-07-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: build: enable vdsm-gluster build .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60329 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: image: Add timing for copy volume operations

2016-07-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: image: Add timing for copy volume operations .. Patch Set 1: Verified+1 Verified on master -- To view, visit https://gerrit.ovirt.org/60542 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: image: Add timing for copy volume operations

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: image: Add timing for copy volume operations .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url

Change in vdsm[ovirt-4.0]: image: Add timing for copy volume operations

2016-07-11 Thread nsoffer
Hello Adam Litke, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/60542 to review the following change. Change subject: image: Add timing for copy volume operations .. image: Add

Change in vdsm[master]: properties: Add properties module

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: properties: Add properties module .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: properties: Add properties module

2016-07-11 Thread alitke
Adam Litke has submitted this change and it was merged. Change subject: properties: Add properties module .. properties: Add properties module Properties are reusable objects similar to builtin property() function, adding

Change in vdsm[master]: properties: Add properties module

2016-07-11 Thread alitke
Adam Litke has posted comments on this change. Change subject: properties: Add properties module .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40822 To unsubscribe, visit

Change in vdsm[master]: sd: Support volume leases

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sd: Support volume leases .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: sd: Unify getVolumeLease signature

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sd: Unify getVolumeLease signature .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: clusterlock: Support for multiple leases

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: clusterlock: Support for multiple leases .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sd: Move getVolumeLease to StorageDomainManifest .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: properties: Add properties module

2016-07-11 Thread alitke
Adam Litke has posted comments on this change. Change subject: properties: Add properties module .. Patch Set 9: Verified+1 No users, so verified using supplied tests. -- To view, visit https://gerrit.ovirt.org/40822 To

Change in vdsm[master]: clusterlock: Raise if lock is used improperly

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: clusterlock: Raise if lock is used improperly .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: clusterlock: Fix LocalLock.supports_volume_leases

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: clusterlock: Fix LocalLock.supports_volume_leases .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: fix make_block_volume size units

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: fix make_block_volume size units .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: tests: fix make_block_volume size units

2016-07-11 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: tests: fix make_block_volume size units .. tests: fix make_block_volume size units The utility function make_block_volume takes size in bytes.

Change in vdsm[master]: sd: Unify getVolumeLease signature

2016-07-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sd: Unify getVolumeLease signature .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/60281 To unsubscribe, visit

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

2016-07-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sd: Move getVolumeLease to StorageDomainManifest .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/60282/2/vdsm/storage/sd.py File vdsm/storage/sd.py:

Change in vdsm[master]: clusterlock: Fix LocalLock.supports_volume_leases

2016-07-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clusterlock: Fix LocalLock.supports_volume_leases .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/60423 To unsubscribe, visit

Change in vdsm[master]: clusterlock: Support for multiple leases

2016-07-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clusterlock: Support for multiple leases .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/60422/2/lib/vdsm/storage/clusterlock.py File

Change in vdsm[master]: clusterlock: Fix double close on EINTR

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: clusterlock: Fix double close on EINTR .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: cluserlock: Use errno instead of os.errno

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: cluserlock: Use errno instead of os.errno .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: cluserlock: Use errno instead of os.errno

2016-07-11 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: cluserlock: Use errno instead of os.errno .. cluserlock: Use errno instead of os.errno The errno attribute in the os module is not part of the module api but a

Change in vdsm[master]: clusterlock: Fix double close on EINTR

2016-07-11 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: clusterlock: Fix double close on EINTR .. clusterlock: Fix double close on EINTR If os.close(fd) was interrupted by signal, we would try to close again - this may

Change in vdsm[master]: sd: Support volume leases

2016-07-11 Thread alitke
Adam Litke has posted comments on this change. Change subject: sd: Support volume leases .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60425 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: clusterlock: Support for multiple leases

2016-07-11 Thread alitke
Adam Litke has posted comments on this change. Change subject: clusterlock: Support for multiple leases .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/60422/2/lib/vdsm/storage/clusterlock.py File

Change in vdsm[master]: clusterlock: Fix LocalLock.supports_volume_leases

2016-07-11 Thread alitke
Adam Litke has posted comments on this change. Change subject: clusterlock: Fix LocalLock.supports_volume_leases .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60423 To unsubscribe, visit

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

2016-07-11 Thread alitke
Adam Litke has posted comments on this change. Change subject: sd: Move getVolumeLease to StorageDomainManifest .. Patch Set 2: -Code-Review (1 comment) https://gerrit.ovirt.org/#/c/60282/2/vdsm/storage/sd.py File

Change in vdsm[master]: tests: Add make_volume to FakeEnv

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add make_volume to FakeEnv .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: fix make_block_volume size units

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: fix make_block_volume size units .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: sdm: base.Job should not always require host_id

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sdm: base.Job should not always require host_id .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: Define the SDM.copy_data API

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Define the SDM.copy_data API .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: Implement SDM.copy_data

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Implement SDM.copy_data .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: sdc: Safer way to access storage domain manifest

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sdc: Safer way to access storage domain manifest .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Add tmpdir and sdcache to FakeEnv

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add tmpdir and sdcache to FakeEnv .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: fix make_block_volume size units

2016-07-11 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: fix make_block_volume size units .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/60408 To unsubscribe, visit

Change in vdsm[master]: Modify reports to metrics

2016-07-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Modify reports to metrics .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 450:

Change in vdsm[master]: tox: fail make process if required tox version isn't installed.

2016-07-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: tox: fail make process if required tox version isn't installed. .. Patch Set 21: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59306 To

Change in vdsm[master]: Modify reports to metrics

2016-07-11 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: Modify reports to metrics .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60450 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: Modify reports to metrics

2016-07-11 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: Modify reports to metrics .. Patch Set 2: We don't want to use the terminology "reports" at all here, as it confused with other reports mechanism we used to

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Moving vmstatus to vdsm.common.virt .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

2016-07-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Moving vmstatus to vdsm.common.virt .. Patch Set 9: done -- To view, visit https://gerrit.ovirt.org/57820 To unsubscribe, visit

Change in vdsm[master]: docs: add README about logging configuration

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: docs: add README about logging configuration .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: docs: add README about logging configuration

2016-07-11 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: docs: add README about logging configuration .. docs: add README about logging configuration Most notably, document how to tune the logging settings of Vdsm

Change in vdsm[ovirt-3.6]: sla: Use GuestIoTuneOptional collector in MOM

2016-07-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: sla: Use GuestIoTuneOptional collector in MOM .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60525 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

2016-07-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Configure mom to ignore missing balloon device .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60524 To unsubscribe, visit

Change in vdsm[master]: gluster:enforce gluster fencing policies

2016-07-11 Thread mperina
Martin Peřina has posted comments on this change. Change subject: gluster:enforce gluster fencing policies .. Patch Set 4: Code-Review-1 I'd really like to move get_gluster_volinfo(), get_gluster_vol_status(),

Change in vdsm[master]: virt: Limit the number of workers in executor

2016-07-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Limit the number of workers in executor .. Patch Set 18: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/57754/18/tests/executorTests.py File

Change in vdsm[master]: Fix return value names for VM.ioTune calls

2016-07-11 Thread msivak
Martin Sivák has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 1: But I am still getting the same error while doing

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

2016-07-11 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: Moving vmstatus to vdsm.common.virt .. Patch Set 8: Code-Review-1 This patch (commit message) lacks explanation why is the move needed. -- To view, visit

Change in vdsm[master]: v2v: Log detailed output of virt-v2v

2016-07-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: Log detailed output of virt-v2v .. Patch Set 6: (1 comment) partial review, but as the story unfolds, the shell redirect approach is gaining some

Change in vdsm[master]: Modify reports to metrics

2016-07-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Modify reports to metrics .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 450:

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

2016-07-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Moving vmstatus to vdsm.common.virt .. Patch Set 8: Code-Review-1 Martin's right, I remember _now_ why this is a good idea, but what about in 3 months?

Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

2016-07-11 Thread rmohr
Roman Mohr has posted comments on this change. Change subject: Configure mom to ignore missing balloon device .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60524 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: sla: Use GuestIoTuneOptional collector in MOM

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sla: Use GuestIoTuneOptional collector in MOM .. Patch Set 1: * #1353559::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1353559::OK, public bug *

Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

2016-07-11 Thread msivak
Martin Sivák has posted comments on this change. Change subject: Configure mom to ignore missing balloon device .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/60524 To unsubscribe, visit

Change in vdsm[master]: migration: wait properly for migration to begin

2016-07-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migration: wait properly for migration to begin .. Patch Set 8: Code-Review+1 please just amend the commit message adding Backport-To: 4.0 and it should be

Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Configure mom to ignore missing balloon device .. Patch Set 1: * #1337882::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1337882::OK, public bug *

Change in vdsm[ovirt-3.6]: sla: Use GuestIoTuneOptional collector in MOM

2016-07-11 Thread msivak
Hello Dan Kenigsberg, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/60525 to review the following change. Change subject: sla: Use GuestIoTuneOptional collector in MOM .. sla:

Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

2016-07-11 Thread msivak
Hello Roman Mohr, Dan Kenigsberg, Francesco Romani, Roy Golan, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/60524 to review the following change. Change subject: Configure mom to ignore missing balloon device

Change in vdsm[master]: Fix return value names for VM.ioTune calls

2016-07-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 1: Code-Review+1 it seems I missed this when reviewing the original patches :\ -- To view, visit

Change in vdsm[master]: storage: Add inplace virt-sparsify support

2016-07-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 9: looks good to me, but it seems one comment from Nir about vol.isSparse(0 was not handled. -- To

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Moving vmstatus to vdsm.common.virt .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

2016-07-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Moving vmstatus to vdsm.common.virt .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/57820 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: sp: try lock when executing user initated pool upgrade

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: try lock when executing user initated pool upgrade .. Patch Set 2: -Verified * #1260428::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: vdscli: added DeprecationWarning to module

2016-07-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: vdscli: added DeprecationWarning to module .. Patch Set 8: can you post the output ? -- To view, visit https://gerrit.ovirt.org/60318 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: sp: try lock when executing user initated pool upgrade

2016-07-11 Thread laravot
Liron Aravot has posted comments on this change. Change subject: sp: try lock when executing user initated pool upgrade .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/60520 To unsubscribe, visit

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

2016-07-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Moving vmstatus to vdsm.common.virt .. Patch Set 7: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/57820/7/lib/vdsm/common/virt/vmstatus.py File

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

2016-07-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Moving vmstatus to vdsm.common.virt .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57820 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: vdsm: adding handling for NGN in osinfo.py

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 4: * #1324447::Update tracker: OK * Set MODIFIED::bug 1324447#1324447OK -- To view, visit

Change in vdsm[ovirt-4.0]: vdsm: adding handling for NGN in osinfo.py

2016-07-11 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: vdsm: adding handling for NGN in osinfo.py .. vdsm: adding handling for NGN in osinfo.py Current osinfo.py implementation lacks handling for NGN (New

Change in vdsm[ovirt-4.0]: sp: allow executing upgradePool even if there is a pending u...

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: allow executing upgradePool even if there is a pending update .. Patch Set 2: -Verified * #1260428::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[ovirt-4.0]: sp: allow executing upgradePool even if there is a pending u...

2016-07-11 Thread laravot
Liron Aravot has posted comments on this change. Change subject: sp: allow executing upgradePool even if there is a pending update .. Patch Set 1: Verified+1 Rerun-hooks: all -- To view, visit https://gerrit.ovirt.org/60519

Change in vdsm[ovirt-4.0]: sp: allow executing upgradePool even if there is a pending u...

2016-07-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: allow executing upgradePool even if there is a pending update .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/60519/1//COMMIT_MSG Commit Message:

Change in vdsm[ovirt-4.0]: sp: try lock when executing user initated pool upgrade

2016-07-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: try lock when executing user initated pool upgrade .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/60520/1//COMMIT_MSG Commit Message: Line 18: is

Change in vdsm[master]: sp: try lock when executing user initated pool upgrade

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: try lock when executing user initated pool upgrade .. Patch Set 8: * #1260428::Update tracker: OK * Set MODIFIED::bug 1260428#1260428IGNORE, not all

Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...

2016-07-11 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: allow executing upgradePool even if there is a pending update .. sp: allow executing upgradePool even if there is a pending update Currently when a

Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: allow executing upgradePool even if there is a pending update .. Patch Set 11: * #1260428::Update tracker: OK * Set MODIFIED::bug

Change in vdsm[master]: sp: try lock when executing user initated pool upgrade

2016-07-11 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: try lock when executing user initated pool upgrade .. sp: try lock when executing user initated pool upgrade When attempting to execute

Change in vdsm[master]: vmxml: move metadata handling into helpers

2016-07-11 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vmxml: move metadata handling into helpers .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57380 To unsubscribe, visit

Change in vdsm[master]: vmxml: move namespace declaration

2016-07-11 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vmxml: move namespace declaration .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57381 To unsubscribe, visit

Change in vdsm[master]: Modify reports to metrics

2016-07-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Modify reports to metrics .. Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 446:

Change in vdsm[master]: vm: split device init from domDependentInit

2016-07-11 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: split device init from domDependentInit .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59814 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: sp: allow executing upgradePool even if there is a pending u...

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: allow executing upgradePool even if there is a pending update .. Patch Set 1: Verified-1 * #1260428::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[ovirt-4.0]: sp: try lock when executing user initated pool upgrade

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: try lock when executing user initated pool upgrade .. Patch Set 1: Verified-1 * #1260428::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[ovirt-4.0]: sp: allow executing upgradePool even if there is a pending u...

2016-07-11 Thread laravot
Liron Aravot has uploaded a new change for review. Change subject: sp: allow executing upgradePool even if there is a pending update .. sp: allow executing upgradePool even if there is a pending update Currently when a pool

Change in vdsm[ovirt-4.0]: sp: try lock when executing user initated pool upgrade

2016-07-11 Thread laravot
Liron Aravot has uploaded a new change for review. Change subject: sp: try lock when executing user initated pool upgrade .. sp: try lock when executing user initated pool upgrade When attempting to execute upgradeStoragePool a

Change in vdsm[master]: vm: split vcpu settings from domDependentInit

2016-07-11 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: split vcpu settings from domDependentInit .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59813 To unsubscribe, visit

Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: allow executing upgradePool even if there is a pending update .. Patch Set 10: * #1260428::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: sp: try lock when executing user initated pool upgrade

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: try lock when executing user initated pool upgrade .. Patch Set 7: * #1260428::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1260428::OK,

Change in vdsm[master]: sp: try lock when executing user initated pool upgrade

2016-07-11 Thread laravot
Liron Aravot has posted comments on this change. Change subject: sp: try lock when executing user initated pool upgrade .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/59514 To unsubscribe, visit

Change in vdsm[master]: vm: reorder sampling initialization

2016-07-11 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: reorder sampling initialization .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59815 To unsubscribe, visit

Change in vdsm[master]: vm: split guest agent init from domDependentInit

2016-07-11 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: split guest agent init from domDependentInit .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59816 To unsubscribe, visit

Change in vdsm[master]: storage: Add inplace virt-sparsify support

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 9: * #734120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#734120::OK, public bug * Check

Change in vdsm[master]: storage: Add inplace virt-sparsify support

2016-07-11 Thread smelamud
Shmuel Leib Melamud has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 9: (5 comments) https://gerrit.ovirt.org/#/c/57347/8/lib/api/vdsm-api.yml File

Change in vdsm[master]: Define the SDM.copy_data API

2016-07-11 Thread alitke
Adam Litke has posted comments on this change. Change subject: Define the SDM.copy_data API .. Patch Set 1: (5 comments) https://gerrit.ovirt.org/#/c/60419/1/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: Line 6956:

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

2016-07-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Moving vmstatus to vdsm.common.virt .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

  1   2   3   >