Tomas Jelinek has posted comments on this change.
Change subject: migration: wait properly for migration to begin
..
Patch Set 9: Verified+1
done
--
To view, visit https://gerrit.ovirt.org/60073
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: migration: wait properly for migration to begin
..
Patch Set 9:
* #1354344::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1354344::OK, public bug
*
Yaniv Bronhaim has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 450:
Dan Kenigsberg has posted comments on this change.
Change subject: build: enable vdsm-gluster build
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60329
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: image: Add timing for copy volume operations
..
Patch Set 1: Verified+1
Verified on master
--
To view, visit https://gerrit.ovirt.org/60542
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: image: Add timing for copy volume operations
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url
Hello Adam Litke, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60542
to review the following change.
Change subject: image: Add timing for copy volume operations
..
image: Add
gerrit-hooks has posted comments on this change.
Change subject: properties: Add properties module
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Adam Litke has submitted this change and it was merged.
Change subject: properties: Add properties module
..
properties: Add properties module
Properties are reusable objects similar to builtin property() function,
adding
Adam Litke has posted comments on this change.
Change subject: properties: Add properties module
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40822
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: sd: Support volume leases
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: sd: Unify getVolumeLease signature
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: clusterlock: Support for multiple leases
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sd: Move getVolumeLease to StorageDomainManifest
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has posted comments on this change.
Change subject: properties: Add properties module
..
Patch Set 9: Verified+1
No users, so verified using supplied tests.
--
To view, visit https://gerrit.ovirt.org/40822
To
gerrit-hooks has posted comments on this change.
Change subject: clusterlock: Raise if lock is used improperly
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: clusterlock: Fix LocalLock.supports_volume_leases
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: fix make_block_volume size units
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: tests: fix make_block_volume size units
..
tests: fix make_block_volume size units
The utility function make_block_volume takes size in bytes.
Nir Soffer has posted comments on this change.
Change subject: sd: Unify getVolumeLease signature
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/60281
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: sd: Move getVolumeLease to StorageDomainManifest
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/60282/2/vdsm/storage/sd.py
File vdsm/storage/sd.py:
Nir Soffer has posted comments on this change.
Change subject: clusterlock: Fix LocalLock.supports_volume_leases
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/60423
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: clusterlock: Support for multiple leases
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/60422/2/lib/vdsm/storage/clusterlock.py
File
gerrit-hooks has posted comments on this change.
Change subject: clusterlock: Fix double close on EINTR
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: cluserlock: Use errno instead of os.errno
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has uploaded a new change for review.
Change subject: cluserlock: Use errno instead of os.errno
..
cluserlock: Use errno instead of os.errno
The errno attribute in the os module is not part of the module api but a
Nir Soffer has uploaded a new change for review.
Change subject: clusterlock: Fix double close on EINTR
..
clusterlock: Fix double close on EINTR
If os.close(fd) was interrupted by signal, we would try to close again -
this may
Adam Litke has posted comments on this change.
Change subject: sd: Support volume leases
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60425
To unsubscribe, visit https://gerrit.ovirt.org/settings
Adam Litke has posted comments on this change.
Change subject: clusterlock: Support for multiple leases
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/60422/2/lib/vdsm/storage/clusterlock.py
File
Adam Litke has posted comments on this change.
Change subject: clusterlock: Fix LocalLock.supports_volume_leases
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60423
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: sd: Move getVolumeLease to StorageDomainManifest
..
Patch Set 2: -Code-Review
(1 comment)
https://gerrit.ovirt.org/#/c/60282/2/vdsm/storage/sd.py
File
gerrit-hooks has posted comments on this change.
Change subject: tests: Add make_volume to FakeEnv
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: fix make_block_volume size units
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sdm: base.Job should not always require host_id
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: Define the SDM.copy_data API
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: sdc: Safer way to access storage domain manifest
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Add tmpdir and sdcache to FakeEnv
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has posted comments on this change.
Change subject: tests: fix make_block_volume size units
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/60408
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 450:
Yaniv Bronhaim has posted comments on this change.
Change subject: tox: fail make process if required tox version isn't installed.
..
Patch Set 21: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59306
To
Oved Ourfali has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60450
To unsubscribe, visit https://gerrit.ovirt.org/settings
Oved Ourfali has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 2:
We don't want to use the terminology "reports" at all here, as it confused with
other reports mechanism we used to
gerrit-hooks has posted comments on this change.
Change subject: Moving vmstatus to vdsm.common.virt
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Yaniv Bronhaim has posted comments on this change.
Change subject: Moving vmstatus to vdsm.common.virt
..
Patch Set 9:
done
--
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has uploaded a new change for review.
Change subject: docs: add README about logging configuration
..
docs: add README about logging configuration
Most notably, document how to tune the logging
settings of Vdsm
Francesco Romani has posted comments on this change.
Change subject: sla: Use GuestIoTuneOptional collector in MOM
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60525
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Configure mom to ignore missing balloon device
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60524
To unsubscribe, visit
Martin Peřina has posted comments on this change.
Change subject: gluster:enforce gluster fencing policies
..
Patch Set 4: Code-Review-1
I'd really like to move get_gluster_volinfo(), get_gluster_vol_status(),
Francesco Romani has posted comments on this change.
Change subject: virt: Limit the number of workers in executor
..
Patch Set 18: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/57754/18/tests/executorTests.py
File
Martin Sivák has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 1:
But I am still getting the same error while doing
Martin Polednik has posted comments on this change.
Change subject: Moving vmstatus to vdsm.common.virt
..
Patch Set 8: Code-Review-1
This patch (commit message) lacks explanation why is the move needed.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 6:
(1 comment)
partial review, but as the story unfolds, the shell redirect approach is
gaining some
Yaniv Bronhaim has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 450:
Francesco Romani has posted comments on this change.
Change subject: Moving vmstatus to vdsm.common.virt
..
Patch Set 8: Code-Review-1
Martin's right, I remember _now_ why this is a good idea, but what about in 3
months?
Roman Mohr has posted comments on this change.
Change subject: Configure mom to ignore missing balloon device
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60524
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: sla: Use GuestIoTuneOptional collector in MOM
..
Patch Set 1:
* #1353559::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1353559::OK, public bug
*
Martin Sivák has posted comments on this change.
Change subject: Configure mom to ignore missing balloon device
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/60524
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: migration: wait properly for migration to begin
..
Patch Set 8: Code-Review+1
please just amend the commit message adding Backport-To: 4.0 and it should be
gerrit-hooks has posted comments on this change.
Change subject: Configure mom to ignore missing balloon device
..
Patch Set 1:
* #1337882::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1337882::OK, public bug
*
Hello Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60525
to review the following change.
Change subject: sla: Use GuestIoTuneOptional collector in MOM
..
sla:
Hello Roman Mohr, Dan Kenigsberg, Francesco Romani, Roy Golan,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60524
to review the following change.
Change subject: Configure mom to ignore missing balloon device
Francesco Romani has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 1: Code-Review+1
it seems I missed this when reviewing the original patches :\
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 9:
looks good to me, but it seems one comment from Nir about vol.isSparse(0 was
not handled.
--
To
gerrit-hooks has posted comments on this change.
Change subject: Moving vmstatus to vdsm.common.virt
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Yaniv Bronhaim has posted comments on this change.
Change subject: Moving vmstatus to vdsm.common.virt
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: sp: try lock when executing user initated pool upgrade
..
Patch Set 2: -Verified
* #1260428::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Yaniv Bronhaim has posted comments on this change.
Change subject: vdscli: added DeprecationWarning to module
..
Patch Set 8:
can you post the output ?
--
To view, visit https://gerrit.ovirt.org/60318
To unsubscribe, visit
Liron Aravot has posted comments on this change.
Change subject: sp: try lock when executing user initated pool upgrade
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/60520
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Moving vmstatus to vdsm.common.virt
..
Patch Set 7: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/57820/7/lib/vdsm/common/virt/vmstatus.py
File
Francesco Romani has posted comments on this change.
Change subject: Moving vmstatus to vdsm.common.virt
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vdsm: adding handling for NGN in osinfo.py
..
Patch Set 4:
* #1324447::Update tracker: OK
* Set MODIFIED::bug 1324447#1324447OK
--
To view, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: vdsm: adding handling for NGN in osinfo.py
..
vdsm: adding handling for NGN in osinfo.py
Current osinfo.py implementation lacks handling for NGN (New
gerrit-hooks has posted comments on this change.
Change subject: sp: allow executing upgradePool even if there is a pending
update
..
Patch Set 2: -Verified
* #1260428::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Liron Aravot has posted comments on this change.
Change subject: sp: allow executing upgradePool even if there is a pending
update
..
Patch Set 1: Verified+1
Rerun-hooks: all
--
To view, visit https://gerrit.ovirt.org/60519
Nir Soffer has posted comments on this change.
Change subject: sp: allow executing upgradePool even if there is a pending
update
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60519/1//COMMIT_MSG
Commit Message:
Nir Soffer has posted comments on this change.
Change subject: sp: try lock when executing user initated pool upgrade
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60520/1//COMMIT_MSG
Commit Message:
Line 18: is
gerrit-hooks has posted comments on this change.
Change subject: sp: try lock when executing user initated pool upgrade
..
Patch Set 8:
* #1260428::Update tracker: OK
* Set MODIFIED::bug 1260428#1260428IGNORE, not all
Nir Soffer has submitted this change and it was merged.
Change subject: sp: allow executing upgradePool even if there is a pending
update
..
sp: allow executing upgradePool even if there is a pending update
Currently when a
gerrit-hooks has posted comments on this change.
Change subject: sp: allow executing upgradePool even if there is a pending
update
..
Patch Set 11:
* #1260428::Update tracker: OK
* Set MODIFIED::bug
Nir Soffer has submitted this change and it was merged.
Change subject: sp: try lock when executing user initated pool upgrade
..
sp: try lock when executing user initated pool upgrade
When attempting to execute
Milan Zamazal has posted comments on this change.
Change subject: vmxml: move metadata handling into helpers
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57380
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vmxml: move namespace declaration
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57381
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 446:
Milan Zamazal has posted comments on this change.
Change subject: vm: split device init from domDependentInit
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59814
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: sp: allow executing upgradePool even if there is a pending
update
..
Patch Set 1: Verified-1
* #1260428::Update tracker: OK
* Check Bug-Url::OK
* Check Public
gerrit-hooks has posted comments on this change.
Change subject: sp: try lock when executing user initated pool upgrade
..
Patch Set 1: Verified-1
* #1260428::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Liron Aravot has uploaded a new change for review.
Change subject: sp: allow executing upgradePool even if there is a pending
update
..
sp: allow executing upgradePool even if there is a pending update
Currently when a pool
Liron Aravot has uploaded a new change for review.
Change subject: sp: try lock when executing user initated pool upgrade
..
sp: try lock when executing user initated pool upgrade
When attempting to execute upgradeStoragePool a
Milan Zamazal has posted comments on this change.
Change subject: vm: split vcpu settings from domDependentInit
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59813
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: sp: allow executing upgradePool even if there is a pending
update
..
Patch Set 10:
* #1260428::Update tracker: OK
* Check Bug-Url::OK
* Check Public
gerrit-hooks has posted comments on this change.
Change subject: sp: try lock when executing user initated pool upgrade
..
Patch Set 7:
* #1260428::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1260428::OK,
Liron Aravot has posted comments on this change.
Change subject: sp: try lock when executing user initated pool upgrade
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/59514
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: reorder sampling initialization
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59815
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: split guest agent init from domDependentInit
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59816
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 9:
* #734120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#734120::OK, public bug
* Check
Shmuel Leib Melamud has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 9:
(5 comments)
https://gerrit.ovirt.org/#/c/57347/8/lib/api/vdsm-api.yml
File
Adam Litke has posted comments on this change.
Change subject: Define the SDM.copy_data API
..
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/60419/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Line 6956:
gerrit-hooks has posted comments on this change.
Change subject: Moving vmstatus to vdsm.common.virt
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
1 - 100 of 235 matches
Mail list logo