Maor Lipchuk has posted comments on this change.
Change subject: volume: Add compat level to volume's info
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/65867
To unsubscribe, visit
Maor Lipchuk has uploaded a new change for review.
Change subject: volume: Add compat level to volume's info
..
volume: Add compat level to volume's info
Change-Id: Ic01646173a2b62dabb965cd79e393ca65e724f3b
Signed-off-by: Maor
Maor Lipchuk has posted comments on this change.
Change subject: image: Calculate qcow volume size on import.
..
Patch Set 2:
(15 comments)
https://gerrit.ovirt.org/#/c/65039/2/vdsm/storage/image.py
File
Maor Lipchuk has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 25: Verified+1
--
To view, visit https://gerrit.ovirt.org/64373
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: image: Calculate qcow volume size on import.
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/65039
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: image: Calculate qcow volume size on import.
..
Patch Set 2: -Verified
--
To view, visit https://gerrit.ovirt.org/65039
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: hsm:Use sd compat instead of qemu conf compat.
..
Patch Set 11: Verified+1
--
To view, visit https://gerrit.ovirt.org/64951
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 24:
(3 comments)
https://gerrit.ovirt.org/#/c/64373/24/tests/storage_sdm_copy_data_test.py
File
Maor Lipchuk has posted comments on this change.
Change subject: hsm:Use sd compat instead of qemu conf compat.
..
Patch Set 10:
(4 comments)
https://gerrit.ovirt.org/#/c/64951/10/tests/storage_hsm_test.py
File
Maor Lipchuk has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 24: Verified+1
--
To view, visit https://gerrit.ovirt.org/64373
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 24: Verified+1
--
To view, visit https://gerrit.ovirt.org/64372
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: storagetestlib: Add sdVersion param to the test API.
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/65308
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: hsm:Use sd compat instead of qemu conf compat.
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/64951
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: storagetestlib: Add sdVersion param to the test API.
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/65308
To unsubscribe, visit
Maor Lipchuk has uploaded a new change for review.
Change subject: storagetestlib: Add sdVersion param to the test API.
..
storagetestlib: Add sdVersion param to the test API.
Add a storage domain version when creating a mock
Maor Lipchuk has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 20:
(1 comment)
https://gerrit.ovirt.org/#/c/64372/20/vdsm/storage/sdm/volume_artifacts.py
File
Maor Lipchuk has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 23: Verified+1
--
To view, visit https://gerrit.ovirt.org/64377
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: image: Calculate qcow volume size on import.
..
Patch Set 1:
(7 comments)
https://gerrit.ovirt.org/#/c/65039/1/vdsm/storage/image.py
File vdsm/storage/image.py:
Maor Lipchuk has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/64377/21/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2698:
Maor Lipchuk has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 21: Verified+1
--
To view, visit https://gerrit.ovirt.org/64377
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 20:
(2 comments)
https://gerrit.ovirt.org/#/c/64377/20/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2698:
Maor Lipchuk has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 19:
(4 comments)
https://gerrit.ovirt.org/#/c/64377/18/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2698
Line 2699
Maor Lipchuk has posted comments on this change.
Change subject: volume: Add qcow2_compat on create
..
Patch Set 20: Verified+1
--
To view, visit https://gerrit.ovirt.org/64375
To unsubscribe, visit
Maor Lipchuk has uploaded a new change for review.
Change subject: image: Calculate qcow volume size on import.
..
image: Calculate qcow volume size on import.
Estimating qcow2 file size when converting from raw to
qcow.
The
Maor Lipchuk has posted comments on this change.
Change subject: image: Calculate qcow volume size on import.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/65039
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/64377/15/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2701: try:
Maor Lipchuk has posted comments on this change.
Change subject: volume: Add qcow2_compat on create
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/64375/15/vdsm/storage/volume.py
File vdsm/storage/volume.py:
Line
Maor Lipchuk has posted comments on this change.
Change subject: image: Pass compat version.
..
Patch Set 18:
@Nir, this can also be merged, you already acked it at patchset 10
--
To view, visit
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 27: Verified+1
--
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: file_volume: Add qcow2_compat on create
..
Patch Set 15: Verified+1
--
To view, visit https://gerrit.ovirt.org/64374
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: image: Pass compat version.
..
Patch Set 18: Verified+1
--
To view, visit https://gerrit.ovirt.org/64293
To unsubscribe, visit https://gerrit.ovirt.org/settings
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 25: Verified+1
--
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: blockVolume: Add qcow2_compat on create
..
Patch Set 13: Verified+1
--
To view, visit https://gerrit.ovirt.org/64376
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 23: Verified+1
--
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: sd: Select qcow2_compat by storage domain version
..
Patch Set 17: Verified+1
--
To view, visit https://gerrit.ovirt.org/64244
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg: Fix calling convention.
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/64522
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 13: -Verified
--
To view, visit https://gerrit.ovirt.org/64372
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: volume: Add qcow2_compat on create
..
Patch Set 13: Verified+1
--
To view, visit https://gerrit.ovirt.org/64375
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 13: Verified+1
--
To view, visit https://gerrit.ovirt.org/64372
To unsubscribe, visit
Maor Lipchuk has uploaded a new change for review.
Change subject: qemuimg: Fix calling convention.
..
qemuimg: Fix calling convention.
Use kwarg calling stype for qemuimg API calls.
Change-Id:
Maor Lipchuk has abandoned this change.
Change subject: for_now
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/64506
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Maor Lipchuk has uploaded a new change for review.
Change subject: for_now
..
for_now
Change-Id: I325ee1a112bfea4b502ab98dbf592686b5227e22
Signed-off-by: Maor Lipchuk
---
M vdsm/storage/blockVolume.py
M
Maor Lipchuk has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/64373/6/vdsm/storage/sdm/api/copy_data.py
File
Maor Lipchuk has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 6:
I will add the desired tests in the next patchset
--
To view, visit
Maor Lipchuk has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 6:
I will add the desired tests in the next patchset
--
To view, visit https://gerrit.ovirt.org/64373
To
Maor Lipchuk has posted comments on this change.
Change subject: sd: Select qcow2_compat by storage domain version
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/64244/11/tests/sdm_indirection_tests.py
File
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 18:
(3 comments)
https://gerrit.ovirt.org/#/c/64169/18/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Maor Lipchuk has posted comments on this change.
Change subject: file_volume: Add qcow2_compat on create
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/64374
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: blockVolume: Add qcow2_compat on create
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/64376
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: volume: Add qcow2_compat on create
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/64375
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: image: Pass compat version.
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/64293
To unsubscribe, visit https://gerrit.ovirt.org/settings
Maor Lipchuk has posted comments on this change.
Change subject: sd: Select qcow2_compat by storage domain version
..
Patch Set 11: Verified+1
--
To view, visit https://gerrit.ovirt.org/64244
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 18: Verified+1
--
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 17:
Found the issue, it is not related to a whitespace but a failing space, next
upload should be with
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 16:
I already fixed the trailing whitespaces issue in patchset 17.
The make check for this patch ends
Maor Lipchuk has abandoned this change.
Change subject: qemuimg_test: make test pass.
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/64371
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType:
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg_test: make test pass.
..
Patch Set 2:
(1 comment)
This is what I get when I run ./run_tests.sh qemuimg_test.py on latest VDSM:
FAIL:
Maor Lipchuk has uploaded a new change for review.
Change subject: copy_data: Add qcow2_compat on convert.
..
copy_data: Add qcow2_compat on convert.
Pass qcow2 compat on convert.
Change-Id:
Maor Lipchuk has uploaded a new change for review.
Change subject: blockVolume: Add qcow2_compat on create
..
blockVolume: Add qcow2_compat on create
Pass qcow2 compat on create.
Change-Id:
Maor Lipchuk has uploaded a new change for review.
Change subject: qemuimg_test: make test pass.
..
qemuimg_test: make test pass.
There are few failures in the qemuimg test
which makes it consistently fail.
This patch should
Maor Lipchuk has uploaded a new change for review.
Change subject: file_volume: Add qcow2_compat on create
..
file_volume: Add qcow2_compat on create
Pass qcow2 compat on create.
Change-Id:
Maor Lipchuk has uploaded a new change for review.
Change subject: volume: Add qcow2_compat on create
..
volume: Add qcow2_compat on create
Pass qcow2 compat on create.
Change-Id: I8655be6da0b4cbd1c286b0c40288681a991aff19
Maor Lipchuk has uploaded a new change for review.
Change subject: vm: Add qcow2_compat on create
..
vm: Add qcow2_compat on create
Pass qcow2 compat on create.
Change-Id: I331eee6a12853c2fa65e62f42c51504f88723538
Maor Lipchuk has uploaded a new change for review.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
volume_artifacts: Add qcow2_compat on create.
Pass qcow2 compat on initialize volume.
Change-Id:
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 12:
(4 comments)
https://gerrit.ovirt.org/#/c/64169/12/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter for.
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/64169/7//COMMIT_MSG
Commit Message:
Line 9: Add
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/64169/7/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/64169/7/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/64169/6/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Maor Lipchuk has posted comments on this change.
Change subject: build: Disable tests during build
..
Patch Set 3:
/s/test/patch
--
To view, visit https://gerrit.ovirt.org/63966
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: build: Disable tests during build
..
Patch Set 3: Verified+1
My VDSM failed with NOSE version even with commit
4c0a7e27945c82ce043a872ceac8a509bc5676c4 which
Maor Lipchuk has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 4:
(5 comments)
https://gerrit.ovirt.org/#/c/64169/4//COMMIT_MSG
Commit Message:
Line 3:
Maor Lipchuk has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 4:
(6 comments)
@Nir, I disagree regarding the approach of no upload new versions while
Maor Lipchuk has uploaded a new change for review.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
[QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
Add kwargs of storage domain metadata to
Maor Lipchuk has posted comments on this change.
Change subject: formatConverter: Add module doc string for format converter
class.
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64098/4//COMMIT_MSG
Commit Message:
Maor Lipchuk has posted comments on this change.
Change subject: formatConverter: Adding comment for format converter class.
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: formatConverter: Adding comment for format converter class.
..
Patch Set 1:
(1 comment)
Maor Lipchuk has uploaded a new change for review.
Change subject: formatConverter: Adding comment for format converter class.
..
formatConverter: Adding comment for format converter class.
Change-Id:
Maor Lipchuk has posted comments on this change.
Change subject: upgrade: Support upgrade from v3 to v4.
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: upgrade: Support upgrade from v3 to v4.
..
Patch Set 12: -Verified
--
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: formatConverter: Use module logger
..
Patch Set 5: Verified+1
(1 comment)
https://gerrit.ovirt.org/#/c/63630/4/vdsm/storage/imageRepository/formatConverter.py
Maor Lipchuk has posted comments on this change.
Change subject: upgrade: Support upgrade from v3 to v4.
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: formatConverter: Use module logger
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/63630
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 3:
(2 comments)
Thanks for the review!
Regarding the general comment, the change at constants.py.in is
Maor Lipchuk has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 3: Verified+1
Verified upgrade storage pool with NFS and iSCSI.
Version format in the metadata changed to 4
Maor Lipchuk has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 2: Verified-1
Will upload another verified patch soon
--
To view, visit https://gerrit.ovirt.org/63547
To
Maor Lipchuk has uploaded a new change for review.
Change subject: formatConverter: Use module logger
..
formatConverter: Use module logger
Make formatConverter to use module logger.
Change-Id:
Maor Lipchuk has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/63547/1/vdsm/storage/imageRepository/formatConverter.py
File
Maor Lipchuk has uploaded a new change for review.
Change subject: upgrade: Support upgrade to v4 from v3
..
upgrade: Support upgrade to v4 from v3
Adding support for v4 upgrade.
Change-Id:
Maor Lipchuk has posted comments on this change.
Change subject: lvm: Improve logging lv activation logging
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/62737
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: lvm: Fix error handling when resizing lvs
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/62739
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: lvm: Refresh lvs during activation
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/62736
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: lvm: Never hide lvm errors
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/62738
To unsubscribe, visit https://gerrit.ovirt.org/settings
Maor Lipchuk has posted comments on this change.
Change subject: lvm: Separate lv reduce and extend
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/62740
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: ceph: Support OVF_STORE upload for ceph.
..
Patch Set 2:
draft
--
To view, visit https://gerrit.ovirt.org/43296
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: volume: Add volumePath setter to manifest.
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/57194/1//COMMIT_MSG
Commit Message:
Line 11: an exception
Maor Lipchuk has posted comments on this change.
Change subject: volume: Add volumePath setter to manifest.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/57194
To unsubscribe, visit
Maor Lipchuk has uploaded a new change for review.
Change subject: volume: Add volumePath setter to manifest.
..
volume: Add volumePath setter to manifest.
Fix broken merge volume flow by adding volumePath setter.
Currently
Maor Lipchuk has posted comments on this change.
Change subject: storage: Move mount module to vdsm storage lib.
..
Patch Set 15: Verified+1
--
To view, visit https://gerrit.ovirt.org/55292
To unsubscribe, visit
1 - 100 of 267 matches
Mail list logo